aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* remove obsolete flagGravatar Cary Clark2017-01-26
| | | | | | | | | | | | Added by humper in 2013, it is not referenced anywhere I can find. R=reed@google.com Change-Id: I35b3891b29b2fddb132647b5a1e337a0fc68e79e Reviewed-on: https://skia-review.googlesource.com/7610 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* SkOpts_hsw ODR paranoiaGravatar Mike Klein2017-01-26
| | | | | | | | | | | | | | | | | | I'm warming back up to the idea of very careful use of SkOpts_hsw. But if we're going to do that, we need a strict header discipline. No header can be assumed to be safe without vetting, and most aren't. Today there's only one function defined in SkOpts_hsw, so this CL mostly rewrites that convolve_vertically() to use no headers beyond immintrin.h and stdint.h, both safe. It shared very little code with the others anyway, so we're not losing anything by putting it directly into SkOpts_hsw.cpp. I have also streamlined the implementation considerably to improve maintainability and readability. Change-Id: Ia03daae660e54125a0d2e2988464cfc930349e80 Reviewed-on: https://skia-review.googlesource.com/7611 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove SkBlitter::getShaderContext()Gravatar Florin Malita2017-01-26
| | | | | | | | | | | Unused. Also ComposeShaderContext::getShaderContext{A,B}. R=reed@google.com,mtklein@google.com Change-Id: I36a8346f0c7e842455774339f388c04920db0040 Reviewed-on: https://skia-review.googlesource.com/7613 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix extension suffic for getting procs from GL_EXT_debug_marker on ESGravatar Brian Salomon2017-01-26
| | | | | | | Change-Id: I483fbf7c5f6d4489802def78fa855f70313e4a19 Reviewed-on: https://skia-review.googlesource.com/7602 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* add test for big cubic -- currently disabledGravatar Mike Reed2017-01-26
| | | | | | | | | BUG=skia: Change-Id: Ief11a1e54d427b1241b47f3cfab5b44fb656443a Reviewed-on: https://skia-review.googlesource.com/7607 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Move SkGammaColorFilter to tools, limit to sRGBGravatar Brian Osman2017-01-26
| | | | | | | | | | | Similarly, limit GrGammaEffect to sRGB (and rename it). BUG=skia: Change-Id: I88feef11ab7040bca2fa4c2eed71923ded87a0d0 Reviewed-on: https://skia-review.googlesource.com/7375 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* remove legacy clipbounds flag for androidGravatar Mike Reed2017-01-26
| | | | | | | | | BUG=skia: Change-Id: Ie13c85bfbb5b1b173e8ac6a2fb0c9a23ea8ba7de Reviewed-on: https://skia-review.googlesource.com/7583 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Move GrDrawingManager pointer to GrSurfaceContextGravatar Robert Phillips2017-01-26
| | | | | | | | Change-Id: Ic285b24b384bbf284cc680fe770433dd4d643833 Reviewed-on: https://skia-review.googlesource.com/7561 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Check that the upper bits are correct in the SkArenaAlloc footer.Gravatar herb2017-01-26
| | | | | | | | | TBR=mtklein@google.com Change-Id: I8dc21778d1b8b24dd9d7b6919bb7e2bcfe090e82 Reviewed-on: https://skia-review.googlesource.com/7588 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Fix clang warning about unused lambda capture.Gravatar Brian Salomon2017-01-26
| | | | | | | | | This was found by a tip of tree build of clang. Change-Id: I9aa3fecd47ae69350e8d58e796f960a991b7759e Reviewed-on: https://skia-review.googlesource.com/7586 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove redundant caps field from GrProcessorTestDataGravatar Brian Salomon2017-01-25
| | | | | | | Change-Id: Ic31338f08d1bd5b55ffab75d30c0f54436c8b917 Reviewed-on: https://skia-review.googlesource.com/7510 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Simplify Footers in SkArenaAlloc to 64-bit values using pointers.Gravatar Herb Derby2017-01-25
| | | | | | | | | TBR=mtklein@google.com Change-Id: I72c6cf6857b2bb00f4259cc9c4de2d51d454e6ab Reviewed-on: https://skia-review.googlesource.com/7582 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Switch GrConfigConversionEffect over to taking GrTextureProxiesGravatar Robert Phillips2017-01-25
| | | | | | | Change-Id: Ic8be773e210e1ac05dcb9aad6c89dcd63e9e4ba2 Reviewed-on: https://skia-review.googlesource.com/7521 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* utils/win/SkTScopedComPtr<T>: Add C++11ish move semanticsGravatar Hal Canary2017-01-25
| | | | | | | Change-Id: I026ffa81d583fddc4a2c7238a176232ef98fcd89 Reviewed-on: https://skia-review.googlesource.com/7434 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Use GrSurfaceContext::read/write-Pixels moreGravatar Robert Phillips2017-01-25
| | | | | | | | Change-Id: I04bcaf91aa7a43e0563e332c1fe2836d762a04d4 Reviewed-on: https://skia-review.googlesource.com/7520 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add test for bad reuse of SkJpegCodec internal stateGravatar Matt Sarett2017-01-25
| | | | | | | | | | | | This is a test for the following fix: https://skia-review.googlesource.com/c/7451/ b/34637813 Change-Id: I3fdb0d7d50537948039b75c3a22454e789ca810a Reviewed-on: https://skia-review.googlesource.com/7454 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Move SkShadowTessellator to GrShadowTessellatorGravatar Jim Van Verth2017-01-25
| | | | | | | | | BUG=skia:6119 Change-Id: I9756b5aeaced1f21a65063470ccb013c7b856f28 Reviewed-on: https://skia-review.googlesource.com/7505 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Roll recipe DEPSGravatar Eric Boren2017-01-25
| | | | | | | | | BUG=skia: Change-Id: If10fe8b3691c8a71b52774f763a08120ef20dfd8 Reviewed-on: https://skia-review.googlesource.com/7502 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add geometric implementation for ambient shadowsGravatar Jim Van Verth2017-01-25
| | | | | | | | | | | Original: https://skia-review.googlesource.com/7273 BUG=skia:6119 Change-Id: Ie7debd7727768f55dafad922a2b8b9fd3a638fda Reviewed-on: https://skia-review.googlesource.com/7500 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revert "Remove SkImage::MakeTextureFromPixmap"Gravatar Brian Osman2017-01-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8ccbbb455c6ef194920c47e846b95b50f5017138. Reason for revert: Chrome perf regression BUG=chrome:684483 Original change's description: > Remove SkImage::MakeTextureFromPixmap > > Another step towards reducing the number of texture upload paths. > > BUG=skia: > > Change-Id: Ica185e7334f52dc9ebf87e21fe6f60589ef87bb3 > Reviewed-on: https://skia-review.googlesource.com/7346 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com,cblume@google.com # Not skipping CQ checks because original CL landed > 1 day ago. BUG=skia: Change-Id: I8bf6970b764018f3ebcac8123e4d6a8ad05317ff Reviewed-on: https://skia-review.googlesource.com/7484 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Revert "Add geometric implementation for ambient shadows"Gravatar Ethan Nicholas2017-01-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit fdb1bdf1aa4e7f14befcb3acc3f586e7734190ea. Reason for revert: Breaking the roll (see e.g. https://codereview.chromium.org/2652833006) Original change's description: > Add geometric implementation for ambient shadows > > BUG=skia:6119 > > Change-Id: I3140522f223c35fc059a33b593064897485dff7c > Reviewed-on: https://skia-review.googlesource.com/7273 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> > TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6119 Change-Id: I307f6084c40e5ba305c38d15b6b433465295553c Reviewed-on: https://skia-review.googlesource.com/7480 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Add geometric implementation for ambient shadowsGravatar Jim Van Verth2017-01-24
| | | | | | | | | BUG=skia:6119 Change-Id: I3140522f223c35fc059a33b593064897485dff7c Reviewed-on: https://skia-review.googlesource.com/7273 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Revert "Remove sentinal GLContext used in early days of Vulkan in our tools"Gravatar Brian Salomon2017-01-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bfd97c59350c112ad85301eb6ff6005ae4fd9e8c. Reason for revert: Windows bots crashing. Original change's description: > Remove sentinal GLContext used in early days of Vulkan in our tools > > I've ran this through multiple variations of dm and nanobench on Linux > and no longer see any crash/hangs. I forget what the original repo case > for the bug was, but I'm at least not seeing it now with updated drivers. > > BUG=skia: > > Change-Id: I6b7129a4c4d67938baa35d2e2c720cb078fc4c18 > Reviewed-on: https://skia-review.googlesource.com/7441 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> > TBR=egdaniel@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: I94a16b2b13d09182232061b0aebd0d58df96db8a Reviewed-on: https://skia-review.googlesource.com/7453 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Allow GrSingleTextureEffect to take GrTextureProxiesGravatar Robert Phillips2017-01-24
| | | | | | | Change-Id: I1dd441a5838f665c6815a5c629f5763f43f66e09 Reviewed-on: https://skia-review.googlesource.com/7429 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Use appropriate options in SkJpegCodec readRows()Gravatar Matt Sarett2017-01-24
| | | | | | | | | b/34637813 Change-Id: Ibebac2ef8cfe004beb2272c266b580946cedcb08 Reviewed-on: https://skia-review.googlesource.com/7451 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Make the footer big to handle bug 684061.Gravatar Herb Derby2017-01-24
| | | | | | | | | | | | R=mtklein@google.com BUG=chromium:684061 Change-Id: I210ca93e00ec6fa5d166c0fde5cdcff0f60c26ca Reviewed-on: https://skia-review.googlesource.com/7450 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove sentinal GLContext used in early days of Vulkan in our toolsGravatar Greg Daniel2017-01-24
| | | | | | | | | | | | | I've ran this through multiple variations of dm and nanobench on Linux and no longer see any crash/hangs. I forget what the original repo case for the bug was, but I'm at least not seeing it now with updated drivers. BUG=skia: Change-Id: I6b7129a4c4d67938baa35d2e2c720cb078fc4c18 Reviewed-on: https://skia-review.googlesource.com/7441 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* SkPixelInfo::CopyPixels() refactor part 0: only one memcpy() caseGravatar Matt Sarett2017-01-24
| | | | | | | | | | | | | | | I envision this eventually looking like the following: Fast Path 1: memcpy Fast Path 2: Legacy RGBA/BGRA unpremul/premul Fast Path 3: SkColorSpaceXform Fallback: Raster pipeline BUG=skia:6021 Change-Id: I3f0e36b08b051ab4ba3949f04474f20d0c20a963 Reviewed-on: https://skia-review.googlesource.com/7435 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* move sk_memset16,32,64 out-of-lineGravatar Mike Klein2017-01-24
| | | | | | | | | | | | | This helps pick it out on profiles and when debugging. This will have a negligible impact on speed in most cases (small memsets are always fast, large memsets dwarf function call overhead), and clients like Chrome that use link-time optimization should see exactly zero impact. This does however affect code size: it makes libskia 43K smaller on my laptop. Change-Id: I55bdc75b7429a63024ab3b7d55dc1f886bde102a Reviewed-on: https://skia-review.googlesource.com/6589 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Make GrConvolutionEffect only support Gaussian kernels and rename.Gravatar Brian Salomon2017-01-24
| | | | | | | Change-Id: Ia874ad5bacc550b7ecec579719242e3354dca34b Reviewed-on: https://skia-review.googlesource.com/7432 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove SkTDict and calls from SkView.Gravatar Herb Derby2017-01-24
| | | | | | | | | | R=reed@google.com Change-Id: Iebfddf752a2ac210a3f5c69de8decd06d0c35617 Reviewed-on: https://skia-review.googlesource.com/7436 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Do not embed glyph image data in SkGlyphCache.Gravatar Herb Derby2017-01-24
| | | | | | | | | | | | | | Instead of allocating memory for glyph images eagerly by embedding the memory in the glyph cache, allocate memory dynamically on need. TBR=bungeman@google.com BUG=chromium:684366 Change-Id: If32bbc4d2608c976b93868feb519dcfa1212ce59 Reviewed-on: https://skia-review.googlesource.com/7433 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* conservativelyContainsRect is assertingGravatar Mike Reed2017-01-24
| | | | | | | | | BUG=skia:6156 Change-Id: Iea571f001e9a4c4e70313c1bd49fb4e3c598869a Reviewed-on: https://skia-review.googlesource.com/7423 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Add F16 and gamma correct support to webp encoderGravatar Matt Sarett2017-01-24
| | | | | | | | | BUG=skia: Change-Id: Ib788466fa1e2bed26e7ffd8f03bee42930eae1d6 Reviewed-on: https://skia-review.googlesource.com/7425 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* restore bool version of clip-boundsGravatar Mike Reed2017-01-24
| | | | | | | | | BUG=skia: Change-Id: I94e35566cf5bcd250515c71a566dd79030e2acb4 Reviewed-on: https://skia-review.googlesource.com/7430 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Reenable index8 dstsGravatar Matt Sarett2017-01-24
| | | | | | | | | | | | | | | | | | | This is causing problems with image-cacherator-from-ctable gm. In that gm, we use an index8->index8 readPixels() to take a subset. I think we need to keep this as long as we support index8 in the generator/cacherator. Though it's really strange because we don't really bother to verify that color tables are the same and we don't try to overwrite the dst color table... BUG=skia: Change-Id: Icf008caa571c4b81a52a23b8b7d9226789626ef5 Reviewed-on: https://skia-review.googlesource.com/7424 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Make GrYUVEffect take GrTextureProxiesGravatar Robert Phillips2017-01-24
| | | | | | | | | This opens the door for swapping all the effects over to taking GrTextureProxies. Change-Id: I3b03ba93a68f9945c9a8fee008fd170ed57616eb Reviewed-on: https://skia-review.googlesource.com/7344 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Update SkAndroidSDKCanvas.Gravatar Mike Klein2017-01-24
| | | | | | | | | Hope that's right... nothing but the Android roll builds this code. Change-Id: Ib86099deaaa5a67a480d6dc0eece8552e58aae1c Reviewed-on: https://skia-review.googlesource.com/7428 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Temporarily restore colorcube bench and GM files.Gravatar Mike Klein2017-01-24
| | | | | | | | | | | | Just the usual... we don't generate .bp for DM or nanobench yet. See https://skia-review.googlesource.com/c/7363/ and https://googleplex-android-review.git.corp.google.com/#/c/1819530/-1..1 Change-Id: If0098ed8a71a170d5efa773495d5bbf02a1e13fc Reviewed-on: https://skia-review.googlesource.com/7427 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Fix comparison that overflows for addresses near uint max.Gravatar Herb Derby2017-01-23
| | | | | | | | | | | | - Fix Assert TBR=mtklein@google.com BUG=chromium:683578 Change-Id: Iba503d1febace367c71f79a3b9accc0ec3e50f11 Reviewed-on: https://skia-review.googlesource.com/7418 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* make SkPath::conservativelyContainsRect consume degenerate segmentsGravatar Lee Salzman2017-01-23
| | | | | | | | | BUG=skia: Change-Id: I3a39318bceaf6c95a50d84961d93af4ba62550e3 Reviewed-on: https://skia-review.googlesource.com/6900 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* rename virtuals for clipbounds, and deprecate older bool/var-arg patternGravatar Mike Reed2017-01-23
| | | | | | | | | BUG=skia: Change-Id: I08bcc2d0559e02838772538816b928e0716dd3aa Reviewed-on: https://skia-review.googlesource.com/7412 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "Update libwebp to 0.6.0-pre"Gravatar Ethan Nicholas2017-01-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e2f6ffbf49671713356881af70a093e99e80bd31. Reason for revert: iOS build failures, see https://luci-milo.appspot.com/swarming/task/33e5e02cf8419d10/steps/build_iOSShell/0/stdout Original change's description: > Update libwebp to 0.6.0-pre > > Corresponds with Android change > https://android-review.googlesource.com/#/c/326439/ > > "this prerelease snapshot includes encoder and performance > improvements" > > Update build file > * Many files have been renamed from > src/<subdir>/<name>.c > to > src/<subdir>/<name>_<subdir>.c > > * Build new files (*_msa.c, *_neon.c, predictor_enc.c) > > This should fix issue 5876, which was caused by a compiler bug. > With the added NEON implementation, we will no longer trigger > the bug. > > BUG=skia:5876 > > Change-Id: I0fcce4362ee70138547b1d23aa9ef537a4126e73 > Reviewed-on: https://skia-review.googlesource.com/7376 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Leon Scroggins <scroggo@google.com> > TBR=msarett@google.com,scroggo@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5876 Change-Id: Ib81f63861d9f1c6936bd7f790b5e16a9544a4df0 Reviewed-on: https://skia-review.googlesource.com/7420 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Update libwebp to 0.6.0-preGravatar Leon Scroggins III2017-01-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | Corresponds with Android change https://android-review.googlesource.com/#/c/326439/ "this prerelease snapshot includes encoder and performance improvements" Update build file * Many files have been renamed from src/<subdir>/<name>.c to src/<subdir>/<name>_<subdir>.c * Build new files (*_msa.c, *_neon.c, predictor_enc.c) This should fix issue 5876, which was caused by a compiler bug. With the added NEON implementation, we will no longer trigger the bug. BUG=skia:5876 Change-Id: I0fcce4362ee70138547b1d23aa9ef537a4126e73 Reviewed-on: https://skia-review.googlesource.com/7376 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Stop tracking whether GrFragmentProcessors read their inputGravatar Brian Salomon2017-01-23
| | | | | | | Change-Id: Id5338901978b97289798eaef873527597bd8dfd6 Reviewed-on: https://skia-review.googlesource.com/7414 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Move shader register setup to SkRasterPipelineBlitter.Gravatar Mike Klein2017-01-23
| | | | | | | | | | | | | | | | | | | | | We've been seeding the initial values of our registers to x+0.5,y+0.5, 1,0, 0,0,0,0 (useful values for shaders to start with) in all pipelines. This CL changes that to do so only when blitting, and only when we have a shader. The nicest part of this change is that SkRasterPipeline itself no longer needs to have a concept of y, or what x means. It just marches x through [x,x+n), and the blitter handles y and layers the meaning of "dst x coordinate" onto x. This ought to make SkSplicer a little easier to work with too. dm --src gm --config f16 srgb 565 all draws the same. Change-Id: I69d8c1cc14a06e5dfdd6a7493364f43a18f8dec5 Reviewed-on: https://skia-review.googlesource.com/7353 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Fix comparison that overflows for addresses near uint max."Gravatar Ethan Nicholas2017-01-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit db8b8376b09cec9656b0ab864413b7911d81a84c. Reason for revert: Assertion failure, see https://luci-milo.appspot.com/swarming/task/33e5ae4d2bb25210/steps/dm/0/stdout Original change's description: > Fix comparison that overflows for addresses near uint max. > > BUG=chromium:683578 > > Change-Id: I3f9b79eeeba3c68cccb72bd6423811c8ff8f2067 > Reviewed-on: https://skia-review.googlesource.com/7410 > Commit-Queue: Herb Derby <herb@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> > Reviewed-by: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:683578 Change-Id: I198ea4c7209d060d0d15dfa3f6e555fa06e1a632 Reviewed-on: https://skia-review.googlesource.com/7415 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* SkRasterPipeline: implement support for SkTableColorFilterGravatar Mike Klein2017-01-23
| | | | | | | | | | | | | This adds and uses a byte_tables stage that converts to bytes, looks up in the tables, then converts back to floats. We treat this as color filter as pure math, not considering anything colorspace related: no transfer functions, no gamut to change, etc. Change-Id: If5fefc1bcef61a0fb0ae279002a0dd1547e429ea Reviewed-on: https://skia-review.googlesource.com/7413 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GN: add 32-bit and Release iOS builders.Gravatar Mike Klein2017-01-23
| | | | | | | | | | | | And roll recipes to the point where they pass target_cpu to GN, adding x86_64 as an alias for x64. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-arm64-Debug-GN_iOS,Build-Mac-Clang-arm64-Release-GN_iOS,Build-Mac-Clang-arm-Debug-GN_iOS,Build-Mac-Clang-arm-Release-GN_iOS Change-Id: I1933d5803ec7f59f78576c5a7b16489362905a97 Reviewed-on: https://skia-review.googlesource.com/7403 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix comparison that overflows for addresses near uint max.Gravatar Herb Derby2017-01-23
| | | | | | | | | | BUG=chromium:683578 Change-Id: I3f9b79eeeba3c68cccb72bd6423811c8ff8f2067 Reviewed-on: https://skia-review.googlesource.com/7410 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 20:27:57 +0000