aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Make DefaultPathOp a non-legacy GrMeshDrawOpGravatar Brian Salomon2017-07-13
| | | | | | | Change-Id: I9abc795e7c3aca7c129faee48190be749c6dc159 Reviewed-on: https://skia-review.googlesource.com/23101 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Re-enable uploading to partner bucket"Gravatar Ravi Mistry2017-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4e91f16fdf94cab7f3361d7efa6b12bccabee25e. Reason for revert: Still does not work Original change's description: > Re-enable uploading to partner bucket > > This is a revert of > https://skia.googlesource.com/skia/+/da066b865c1e2777a84a829486a7b37a984484b4 > > NoTry: true > Bug: skia:6797 > Change-Id: I9eca7e4b2234c79e39b2c25aaf459512dd206acc > Reviewed-on: https://skia-review.googlesource.com/23202 > Commit-Queue: Ravi Mistry <rmistry@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> > Reviewed-by: Eric Boren <borenet@google.com> TBR=borenet@google.com,rmistry@google.com Change-Id: If1abb65801ba93d409825e290e22d7a9eb3818fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:6797 Reviewed-on: https://skia-review.googlesource.com/23004 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Make GrDrawVerticesOp a non-legacy GrMeshDrawOpGravatar Brian Salomon2017-07-13
| | | | | | | Change-Id: I0e1e6815ed41764115bc84a5967b3da3be4ce147 Reviewed-on: https://skia-review.googlesource.com/22722 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Add null check for non-cached shadows.Gravatar Jim Van Verth2017-07-13
| | | | | | | Change-Id: I8015a026d4bb54f04ee86fca0d4b0be3bc1d9bd8 Reviewed-on: https://skia-review.googlesource.com/23123 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Re-enable uploading to partner bucketGravatar Ravi Mistry2017-07-13
| | | | | | | | | | | | | This is a revert of https://skia.googlesource.com/skia/+/da066b865c1e2777a84a829486a7b37a984484b4 NoTry: true Bug: skia:6797 Change-Id: I9eca7e4b2234c79e39b2c25aaf459512dd206acc Reviewed-on: https://skia-review.googlesource.com/23202 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Avoid unneeded picture shader color space transformsGravatar Florin Malita2017-07-13
| | | | | | | | | | Also update SkPictureImageFilter to use SkColorSpace::Equals instead of direct comparison. Change-Id: I434cd6d1afcb869d2a56601b72edf56d207d9868 Reviewed-on: https://skia-review.googlesource.com/23201 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Download gitcookies from GS for RecreateSKPs botGravatar Ravi Mistry2017-07-13
| | | | | | | | | NoTry: true Bug: skia:6797 Change-Id: Id7005ba5252c5f1e3f85a8bff92371e0562ab87b Reviewed-on: https://skia-review.googlesource.com/22726 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Make GrDrawAtlasOp a non-legacy GrMeshDrawOpGravatar Brian Salomon2017-07-13
| | | | | | | Change-Id: I4d517855dbe3ee6894d7d457e0fc4488f204300c Reviewed-on: https://skia-review.googlesource.com/22542 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* remove dead code for legacy image encode apiGravatar Mike Reed2017-07-13
| | | | | | | | Bug: skia: Change-Id: Ia90d776946281473c56cd93006df1b523475696a Reviewed-on: https://skia-review.googlesource.com/23022 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add trace events for shader generation.Gravatar Ryan Macnak2017-07-13
| | | | | | | | | This helps explain why some frames are slow in Flutter. Change-Id: Ic8b36186f1c8c262950e5ff9e0da3b808cff8d0c Reviewed-on: https://skia-review.googlesource.com/22087 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* New zero length path GMGravatar Brian Osman2017-07-13
| | | | | | | | | | | | | | | | | | | | | | I replaced the previous once, because I think this covers everything it was testing, and lots more. It renders many combinations of parameters, and automatically detects if the results are correct or not. Each test is color coded, and the overall image is tinted with gold's red/green to make triaging easy. Adds four new top-level GMs (single and double contour, with and without AA). Each one tests several more params: - Cap type - Stroke width - Path structure (M vs ML vs MZ vs MLZ) - Different verbs (L vs Q vs C vs A) Bug: skia:6781 Change-Id: Ie81b4417101fea0b439cb094a65257dc06b6b5c0 Reviewed-on: https://skia-review.googlesource.com/21480 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "Revert "Experimental blur code with 32 bit fix.""Gravatar Mike Reed2017-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 27b3d272a8fcce24813212f5816b177090111ec6. Reason for revert: guard has landed in android Original change's description: > Revert "Experimental blur code with 32 bit fix." > > This reverts commit d4b2c537d058ad4cb890ba116d00aa86c3416c08. > > Reason for revert: speculative fix for android-roll > > java.lang.AssertionError: expected:<0> but was:<255> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:834) > at org.junit.Assert.assertEquals(Assert.java:645) > at org.junit.Assert.assertEquals(Assert.java:631) > at android.graphics.cts.BlurMaskFilterTest.verifyColor(BlurMaskFilterTest.java:79) > at android.graphics.cts.BlurMaskFilterTest.verifyQuadrants(BlurMaskFilterTest.java:72) > at android.graphics.cts.BlurMaskFilterTest.testBlurMaskFilter(BlurMaskFilterTest.java:56) > > Original change's description: > > Experimental blur code with 32 bit fix. > > > > This uses a new method of blurring that runs the three > > passes of the box filter in a single pass. This implementation > > currently only does 1x1 pixel at a time, but it should be simple > > to expand to 4x4 pixels at a time. > > > > On the blur_10_normal_high_quality benchmark, the new is 7% faster > > than the old code. For the blur_100.50_normal_high_quality > > benchmark, the new code is 11% slower. > > > > Bug: skia: > > Change-Id: I847270906b0ceac1dfbf43ab5446756689ef660f > > Reviewed-on: https://skia-review.googlesource.com/22700 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Herb Derby <herb@google.com> > > TBR=herb@google.com,reed@google.com > > Change-Id: Ie84f6bf8872cae08c06d679f0c2f2e6c3d8a02a2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/22880 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=herb@google.com,reed@google.com Change-Id: I393d1c05f83ccf98137201bc7b4e7d8e8b0e8742 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/23121 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Give GrSimpleMeshDrawOpHelper a cpp fileGravatar Brian Salomon2017-07-13
| | | | | | | Change-Id: I1ac3f7d41d3d546801a7fc14008b801a11429472 Reviewed-on: https://skia-review.googlesource.com/22368 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* SPIR-V support for more integer operationsGravatar Ethan Nicholas2017-07-13
| | | | | | | | Bug: skia: Change-Id: Ic4ff8dd8b08df8c44222bd7844f4a872377ff240 Reviewed-on: https://skia-review.googlesource.com/21440 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Fix two issues in DashOpGravatar Brian Salomon2017-07-13
| | | | | | | | | | | | 1) Bitfield was too small on Windows for signed enum type 2) Check for unused stencil settings rather than null Also makes bool bitfields adjacent for better packing on Windows. Change-Id: I8115cc31c55e83aa7bd85d99c1fca72042617aa3 Reviewed-on: https://skia-review.googlesource.com/23120 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Make ShadowRRectOp a non-legacy GrMeshDrawOpGravatar Brian Salomon2017-07-13
| | | | | | | | | This also removes the ability to have an arbitrary GrPaint with this op and as a consequence simplifies the op and its GrGeometryProcessor. Change-Id: I19cc1c6f73a47e8925fc826291aad42e9423164d Reviewed-on: https://skia-review.googlesource.com/22380 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Fail to make render target context if GrContext is abandonedGravatar Brian Salomon2017-07-13
| | | | | | | Change-Id: I69eabbc0a8cd02ddd7292f81dd24e6b949bf38e5 Reviewed-on: https://skia-review.googlesource.com/23041 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* don't test index8 -- no longer supportedGravatar Mike Reed2017-07-13
| | | | | | | | Bug: skia:6828 Change-Id: I7ce4d91c2fa66b3a81e5143819dd9d774fa1c116 Reviewed-on: https://skia-review.googlesource.com/23140 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Add abandoned context check to SkImage::MakeFromDeferredTextureImageDataGravatar Brian Salomon2017-07-13
| | | | | | | Change-Id: Ibcae793339cfaf9dae8cb9122f387def535ce1bc Reviewed-on: https://skia-review.googlesource.com/23040 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Re-land of "converted GrSimpleTextureEffect to sksl"Gravatar Ethan Nicholas2017-07-13
| | | | | | | | | | This reverts commit baf981f71614e7a2fbe6af2726e65126d431ed8e. Bug: skia: Change-Id: I36f6bfb616f1ec2b89043e3a6f7cbdf473bc9588 Reviewed-on: https://skia-review.googlesource.com/22369 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Fix computeOutputColorSpaceGravatar Leon Scroggins III2017-07-13
| | | | | | | | | | | | This was accidentally broken when we added a guard for kIndex_8 (https://skia-review.googlesource.com/c/22721). Reenable the code for 32 bit color types. Change-Id: Ibb79a163dc1cffe14e19d2affa17856b549509c4 Reviewed-on: https://skia-review.googlesource.com/23020 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* add guard for api change in google3Gravatar Mike Reed2017-07-13
| | | | | | | Bug: skia: Change-Id: I2d84c546cd2bc097c809690bb423581cbd98f2a8 Reviewed-on: https://skia-review.googlesource.com/23060 Reviewed-by: Mike Reed <reed@google.com>
* Revert "add guard for recent api change"Gravatar Mike Reed2017-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 1c8bb8a4c63c327fb856a41e1b0b19775eac0ac1. Reason for revert: google3 now updated Original change's description: > add guard for recent api change > > Bug: skia: > Change-Id: Ief80e0eb08d091c54cacb045d074c8564adcedba > Reviewed-on: https://skia-review.googlesource.com/22640 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Mike Reed <reed@google.com> TBR=benjaminwagner@google.com,reed@google.com Change-Id: If534fa0f508b5087e3e7527f822906626fdb65c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/23002 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove renderTargetContext swapping from GaussianBlur method (take 2)Gravatar Robert Phillips2017-07-13
| | | | | | | | TBR=bsalomon@google.com Change-Id: I6c594a8dfef1c3319a56665437f1e13e746a2875 Reviewed-on: https://skia-review.googlesource.com/23001 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Remove renderTargetContext swapping from GaussianBlur method"Gravatar Robert Phillips2017-07-13
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0284de0a215d61a849678cb04e5f21f989ee858f. Reason for revert: assert firing in nanobench Original change's description: > Remove renderTargetContext swapping from GaussianBlur method > > Change-Id: Iee3d5165a09b5760e001cade4f9d68e823ae695f > Reviewed-on: https://skia-review.googlesource.com/22725 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> TBR=bsalomon@google.com,robertphillips@google.com Change-Id: Ied1e184c7ab5de0e41814ef8be9c4c94a679d56d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/23000 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Remove renderTargetContext swapping from GaussianBlur methodGravatar Robert Phillips2017-07-13
| | | | | | | Change-Id: Iee3d5165a09b5760e001cade4f9d68e823ae695f Reviewed-on: https://skia-review.googlesource.com/22725 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Guard to remove kIndex_8_SkColorTypeGravatar Mike Reed2017-07-13
| | | | | | | | | Bug: skia:6828 Change-Id: Ia942a36abb18213184f8d436555a658270d97d47 Reviewed-on: https://skia-review.googlesource.com/22721 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Remove dead gradient perspective codeGravatar Florin Malita2017-07-13
| | | | | | | | | | | The cool bit here is that Sk4fLinearGradient is now always fast, and never calls the slow base-class impl. This means we can rip out Sk4fGradientBase::{mapTs, shadeSpan4f, etc}. Change-Id: Id3788bc810873b2a209f66efa4187c84b3397e2f Reviewed-on: https://skia-review.googlesource.com/22366 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Make MSAAPathOp a non-legacy GrMeshDrawOpGravatar Brian Salomon2017-07-13
| | | | | | | Change-Id: Ibe1626a3ebecad0ccc51505c670f9a3ee98d5209 Reviewed-on: https://skia-review.googlesource.com/22361 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Temporarily stop uploading to partner bucket in RecreateSKPs ↵Gravatar Ravi Mistry2017-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bot"" This reverts commit 0f3942fc247cb541a7327b6335054694d7b8e186. Reason for revert: Still cannot upload to partner bucket Original change's description: > Revert "Temporarily stop uploading to partner bucket in RecreateSKPs bot" > > This reverts commit 6945c946ea800b7bff31920914a990c88a706718. > > Reason for revert: Should be able to upload to partner bucket now > > Original change's description: > > Temporarily stop uploading to partner bucket in RecreateSKPs bot > > > > Bug: skia:6797 > > Change-Id: I812837d02b90b78b6df3980649ccf6362e939afc > > Reviewed-on: https://skia-review.googlesource.com/20820 > > Commit-Queue: Ravi Mistry <rmistry@google.com> > > Reviewed-by: Eric Boren <borenet@google.com> > > TBR=borenet@google.com,rmistry@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: skia:6797 > Change-Id: I145275da0050da01fca3e6e9c3c5efd84bdadea1 > Reviewed-on: https://skia-review.googlesource.com/21738 > Reviewed-by: Ravi Mistry <rmistry@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> TBR=borenet@google.com,rmistry@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:6797 Change-Id: I5114c2cacd239c45c6a60cb7aa795c96ef28439e Reviewed-on: https://skia-review.googlesource.com/22840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Revert "Experimental blur code with 32 bit fix."Gravatar Mike Reed2017-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d4b2c537d058ad4cb890ba116d00aa86c3416c08. Reason for revert: speculative fix for android-roll java.lang.AssertionError: expected:<0> but was:<255> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:631) at android.graphics.cts.BlurMaskFilterTest.verifyColor(BlurMaskFilterTest.java:79) at android.graphics.cts.BlurMaskFilterTest.verifyQuadrants(BlurMaskFilterTest.java:72) at android.graphics.cts.BlurMaskFilterTest.testBlurMaskFilter(BlurMaskFilterTest.java:56) Original change's description: > Experimental blur code with 32 bit fix. > > This uses a new method of blurring that runs the three > passes of the box filter in a single pass. This implementation > currently only does 1x1 pixel at a time, but it should be simple > to expand to 4x4 pixels at a time. > > On the blur_10_normal_high_quality benchmark, the new is 7% faster > than the old code. For the blur_100.50_normal_high_quality > benchmark, the new code is 11% slower. > > Bug: skia: > Change-Id: I847270906b0ceac1dfbf43ab5446756689ef660f > Reviewed-on: https://skia-review.googlesource.com/22700 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Herb Derby <herb@google.com> TBR=herb@google.com,reed@google.com Change-Id: Ie84f6bf8872cae08c06d679f0c2f2e6c3d8a02a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/22880 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Make RegionOp a non-legacy GrMeshDrawOpGravatar Brian Salomon2017-07-13
| | | | | | | | | Also add a test factory function. Change-Id: I612973312824a4ba358965ce8378160a980b86fa Reviewed-on: https://skia-review.googlesource.com/22213 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* SkPDF: start to support AlphaOnly Images as masks.Gravatar Hal Canary2017-07-12
| | | | | | | | | Does not work when img->isAlphaOnly() && pnt.getMaskFilter(). Change-Id: I60712d035e3a505799258e24660bba30f2c0ed53 Reviewed-on: https://skia-review.googlesource.com/22723 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add arc support to gpu Obj c++ codeGravatar Greg Daniel2017-07-12
| | | | | | | | | | | | | This is mainly for getting ready to start adding lots of metal backend code. I've also update the "gpu tools" target to require ARC with involved updating one IOS file in there. Bug: skia: Change-Id: Ied22e8fe7532445cc274efb529e3450654a6614b Reviewed-on: https://skia-review.googlesource.com/22484 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* SkPDF: simplify drawImage/Bitmap/Sprite code.Gravatar Hal Canary2017-07-12
| | | | | | | | | | | | | | | - SkImageSubset becomes SkKeyedImage - SkPDFCanvas::onDraw{Bitmap, Image} go away - Remove SkPDFCanvas: base classes now do the right thing. - SkPDFDevice::draw{Bitmap,Image}{Rect,}() simplified - 244 fewer SLOC. All but a few PDFs are identical, those rasterize almost the same. Change-Id: I3ceb3b8935c689719cedf1ad544b0407b5c1733e Reviewed-on: https://skia-review.googlesource.com/22218 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Add some raster pipeline perspective assertsGravatar Florin Malita2017-07-12
| | | | | | | | | | | | | | | | | | | | | I meant to add these when removing the guard, but since we landed without a guard, might as well do it now. A couple of things exposed by these asserts: 1) we need to also catch perspective in local matrices 2) we need to disallow burst mode with perspective Also tweak the predicate to hasPerspective() instead of explicit mask check. Change-Id: I099e5125fca52dccffca77c60fc800bbdf539b53 Reviewed-on: https://skia-review.googlesource.com/22483 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Experimental blur code with 32 bit fix.Gravatar Herb Derby2017-07-12
| | | | | | | | | | | | | | | | | This uses a new method of blurring that runs the three passes of the box filter in a single pass. This implementation currently only does 1x1 pixel at a time, but it should be simple to expand to 4x4 pixels at a time. On the blur_10_normal_high_quality benchmark, the new is 7% faster than the old code. For the blur_100.50_normal_high_quality benchmark, the new code is 11% slower. Bug: skia: Change-Id: I847270906b0ceac1dfbf43ab5446756689ef660f Reviewed-on: https://skia-review.googlesource.com/22700 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Herb Derby <herb@google.com>
* On Windows, always re-create window for GL or VulkanGravatar Brian Osman2017-07-12
| | | | | | | | | | | | On at least one machine, I've seen SetPixelFormat fail after Vulkan was used to render to a window, preventing us from creating a GL context. This is ham-fisted, but solves the problem. Bug: skia: Change-Id: I76d0cb26e181304846aa06109c1af768f8363a18 Reviewed-on: https://skia-review.googlesource.com/22740 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Move expensive initialization to onOnceBeforeDrawGravatar Brian Osman2017-07-12
| | | | | | | | | | | | | This was being triggered at viewer startup, while initalizing the slide list (and then again when switching to the slide). Removing it declutters startup, particularly if you're trying to debug raster drawing code. Bug: skia: Change-Id: If21cdd10b0dbda74f4a845031ae3e33f7305a1d7 Reviewed-on: https://skia-review.googlesource.com/22742 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "Revert "Make DashOp a non-legacy GrMeshDrawOp.""Gravatar Brian Salomon2017-07-12
| | | | | | | | | | | This reverts commit beae8a9faa2afcdbeeec96e658db7e113a4fa1c9. Clean revert of revert. Change-Id: Ibb486bf3411ed347b560fc110a2cfbb0e0caa4f2 Reviewed-on: https://skia-review.googlesource.com/22730 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* remove references to kIndex_8_SkColorType from our tools/testsGravatar Mike Reed2017-07-12
| | | | | | | | | Bug: skia:6828 Change-Id: Ib5049c28c11b7320bece20f5a0a886de8b2a4343 Reviewed-on: https://skia-review.googlesource.com/22728 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Implement Sk4i's abs, min, maxGravatar Yuqian Li2017-07-12
| | | | | | | | | CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Bug: skia: Change-Id: Ia9ec3f72095e1c744f88df7bb990d99e0f87d578 Reviewed-on: https://skia-review.googlesource.com/22720 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Extend final point in closed degenerate hairline segmentsGravatar Brian Osman2017-07-12
| | | | | | | | | | | | | | | For single-contour paths (MLZ), the close is ignored during iteration, and we instead process the 'Done', which does extend in both directions. But if there's a second contour (MLZM), then we process the 'Close', and only extend the degenerate segment in one direction. Depending on where the path was positioned (relative to pixel centers), this led to some contours not drawing at all. Bug: skia: Change-Id: I88aeaecc94c0e69532479e50920ba2e0cc6f4bda Reviewed-on: https://skia-review.googlesource.com/22520 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Fix assert in lattice op triggered by GLProgramsTestGravatar Brian Salomon2017-07-12
| | | | | | Change-Id: Ia495a8c7bc7dd0832da7ad48c6dbdf4c0dc67119 Reviewed-on: https://skia-review.googlesource.com/22729 Reviewed-by: Robert Phillips <robertphillips@google.com>
* Clarify adjustMatrixAndAppendStages semanticsGravatar Florin Malita2017-07-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A false return from adjustMatrixAndAppendStages() currently means we'll attempt to create a legacy context wrapper stage. Only two gradient impls can return false, and they don't really want the same thing: 1) linear returns false when the stops are compressed, to get the "nice" legacy blend color behavior 2) two-point radial returns false when it cannot map the center points (degenerate matrix); in this case we prolly don't want to draw at all This setup made sense while we were retrofitting gradients with stages, but now that all of them support RP, it is confusing to sometimes get a legacy context wrapper even when we are specifically asked for stages. I propose we align the semantics with SkShader::onAppendStages(), such that a false return means "don't draw" rather than "try to draw with a legacy context". This means we're giving up the compressed stop behavior for linear, but that's such an arbitrary corner case that I don't think we care at all. Change-Id: I01256c4acb81b16fb68e6c74cf8d91ea77b95a3b Reviewed-on: https://skia-review.googlesource.com/22541 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Revert "Make DashOp a non-legacy GrMeshDrawOp."Gravatar Brian Salomon2017-07-12
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ebb38256c65f2d799dd64f0274256a0c1deffed1. Reason for revert: Assertions on ANGLE bots Original change's description: > Make DashOp a non-legacy GrMeshDrawOp. > > Change-Id: I84ee3c64a5af8889e9a122cbc08d70ed6b25fbab > Reviewed-on: https://skia-review.googlesource.com/22210 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com Change-Id: I886a0bd75221f05d737d8b27c6b3d8d6cce5573c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/22680 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* add guard for recent api changeGravatar Mike Reed2017-07-12
| | | | | | | | Bug: skia: Change-Id: Ief80e0eb08d091c54cacb045d074c8564adcedba Reviewed-on: https://skia-review.googlesource.com/22640 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Revert "Revert "Change image encode api to return sk_sp""Gravatar Mike Reed2017-07-12
| | | | | | | | | | This reverts commit 64778d9f275d8ce3df8f4ab39ff334b7ef5b70d3. Bug: skia: Change-Id: I779515ff1e16a40c33890a4bac7a8a07171aadfe Reviewed-on: https://skia-review.googlesource.com/22261 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Make DashOp a non-legacy GrMeshDrawOp.Gravatar Brian Salomon2017-07-12
| | | | | | | Change-Id: I84ee3c64a5af8889e9a122cbc08d70ed6b25fbab Reviewed-on: https://skia-review.googlesource.com/22210 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Revert "converted GrSimpleTextureEffect to sksl"Gravatar Ethan Nicholas2017-07-12
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 46b654df9e70bbfacf6dc45d3a2a7ceb13a61edb. Reason for revert: making Vulkan mad Original change's description: > converted GrSimpleTextureEffect to sksl > > Bug: skia: > Change-Id: If556c6baad75f22135f429759feabaaec095b900 > Reviewed-on: https://skia-review.googlesource.com/21720 > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,ethannicholas@google.com Change-Id: I06fac3d106435e1d58e19cc54a919c5d84784d92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/22266 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 15:04:24 +0000