aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* fix Rect docGravatar Cary Clark2018-02-20
| | | | | | | | | | | move the #Line directive to make bookmaker happy Docs-Preview: https://skia.org/?cl=108740 Bug: skia:6898 Change-Id: I8b993bab6b4f69cc266941e281a00a945f32f25e Reviewed-on: https://skia-review.googlesource.com/108740 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* hide complex versions of isOval and isRRectGravatar Mike Reed2018-02-20
| | | | | | | | Bug: skia: Change-Id: I9fa899d409470f424fdfbef5b0c3bb528bcce40e Reviewed-on: https://skia-review.googlesource.com/108660 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Introduce GrColorTypeGravatar Brian Salomon2018-02-20
| | | | | | | | | | | | | | | | | | This begins the journey towards using different types to refer to CPU data and GPU texture formats. This is one part of removing GrPixelConfig and more directly using GL/VK texture formats GrColorType represents a particular layout of color/gray/alpha channels in CPU memory. It does not refer to texture formats or sRGB-encoding. It is basically SkColorType specialized to the GPU backend with some formats added and some removed. Read/WritePixel interfaces use GrColorType to describe the CPU side of the transaction. There's still a lot of punting to GrPixelConfig in API-specific code. There's a lot more to be done. Bug: 6718 Bug: 7580 Change-Id: I8d813ae9a4416a06596f22a4b87da02091989718 Reviewed-on: https://skia-review.googlesource.com/107264 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Roll skia/third_party/externals/skcms/ 08d4cf2b3..fa14d14de (3 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/08d4cf2b3965..fa14d14dea7d $ git log 08d4cf2b3..fa14d14de --date=short --no-merges --format='%ad %ae %s' 2018-02-20 mtklein unify eval_tf() and skcms_TransferFunction_eval() 2018-02-20 mtklein Add an ARMv7 NEON+VFPv4 -O3 build 2018-02-20 mtklein handle integral powers in approx_powf() first Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=djsollen@google.com Change-Id: I9c1063062d1a012679b6ddd5cf6a5368032f18e1 Reviewed-on: https://skia-review.googlesource.com/108681 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* fix IRect docGravatar Cary Clark2018-02-20
| | | | | | | | | | | | | | | | | Florin pointed out docs that used SkPoint where SkIPoint was intended. This was caused by the original documentation guessing that 'points' referred to one and not the other. For now, use IPoint explicitly in the documentation to get around this. Docs-Preview: https://skia.org/?cl=108569 Bug: skia:6898 Change-Id: I12bac1d4cf82a614bee98895f12e4f99add2dbd7 Reviewed-on: https://skia-review.googlesource.com/108569 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* SkQP: update README.mdGravatar Hal Canary2018-02-20
| | | | | | | | No-Try: true Change-Id: I7b12f683901ece91e3a7e2d9fa432aa05fbcf12a Reviewed-on: https://skia-review.googlesource.com/108568 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add SkRect::contains(SkScalar x, SkScalar y)Gravatar Florin Malita2018-02-20
| | | | | | | | | | Similar to its SkIRect counterpart. Change-Id: I6872694d8602ed4181a1a15b4cd1c2c32aeab3f9 Reviewed-on: https://skia-review.googlesource.com/108506 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Drop unused support for MSAA sample locationsGravatar Chris Dalton2018-02-20
| | | | | | | | Bug: skia: Change-Id: I96f0c25732d79c5881e400b121e81c5696a747a6 Reviewed-on: https://skia-review.googlesource.com/107441 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* android_build_app: optionally disable gradle daemonGravatar Hal Canary2018-02-20
| | | | | | | | | Motivation: sometimes the gradle daemon breaks things for me. Change-Id: I920cd344a3b0f67cfa50529083fa7787d693637b Reviewed-on: https://skia-review.googlesource.com/108564 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* [sksg] Add 'plane' geometry nodeGravatar Florin Malita2018-02-20
| | | | | | | | | | | SG geometry corresponding to SkCanvas::drawPaint(). TBR= Change-Id: I3b368adda187fb92f524756496a3694c03a3113d Reviewed-on: https://skia-review.googlesource.com/108562 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add SKQP bot to build universal APK to masterGravatar Stephan Altmueller2018-02-20
| | | | | | | | Bug: skia: Change-Id: Ib0e9ddb621056ddce2422b53f312ec42d4d7aa3c Reviewed-on: https://skia-review.googlesource.com/107880 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* ccpr: Fix a couple issues with tessellation and windingGravatar Chris Dalton2018-02-20
| | | | | | | | Bug: skia: Change-Id: I7c7851230e0ed19719b06e833cbf45c0ef78ddae Reviewed-on: https://skia-review.googlesource.com/107908 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Some more cleanup of GrDrawOpAtlas compactionGravatar Jim Van Verth2018-02-20
| | | | | | | Change-Id: Ica00285d0071a31a09dc87d68d7ae7dfabab17b7 Reviewed-on: https://skia-review.googlesource.com/108522 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Reland "remove third_party/etc1"Gravatar Mike Klein2018-02-20
| | | | | | | | | | | | | | | | | | | This is a reland of 9d7a73527a6df7d3523e93a6a1f964df08b94510. Original change's description: > remove third_party/etc1 > > Nothing seems to reference it. > > Change-Id: Ib009a7dc33d31439b11588758015a07485f56eaa > Reviewed-on: https://skia-review.googlesource.com/99861 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> Change-Id: I3a6428074896c7b3c80cb23db61f70d7cb0c785f Reviewed-on: https://skia-review.googlesource.com/108460 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Docs: clean up linksGravatar Hal Canary2018-02-20
| | | | | | | | | | No-Try: true Docs-Preview: https://skia.org/user/api?cl=108502 Change-Id: I17547b53b50a00e4e9ad1704a032b5b0d14ea436 Reviewed-on: https://skia-review.googlesource.com/108502 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Drop unused shader support for multisample interpolationGravatar Chris Dalton2018-02-20
| | | | | | | | | Bug: skia: Change-Id: Ie19f13877bf6828ab94ffbb20e6f74e0e376f6cb Reviewed-on: https://skia-review.googlesource.com/107359 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* fix more include generation bugsGravatar Cary Clark2018-02-20
| | | | | | | | | | | | | | | | Recent changes to generate tables of methods require more parsing to figure things like indention params for structs. Fix other stuff that got broken since the last time all includes were generated. TBR=caryclark@google.com Bug: skia:6898 Change-Id: Icd6f5feb5324eb4e0feb307400aa53207109cb29 Reviewed-on: https://skia-review.googlesource.com/108182 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Roll Pixel to O 8.1Gravatar Kevin Lubick2018-02-20
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: I9b79044df1a265a086e77fbadcaab69bf86babe1 Reviewed-on: https://skia-review.googlesource.com/108521 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* SlideDir focus tweaksGravatar Florin Malita2018-02-20
| | | | | | | | | | | | | | * cubic-map animation * shade the background scene when focused * unfocus on click outside focus rect TBR= Bug: skia: Change-Id: I0ef8751b111b3b55c3fc36126c2ca1bc8ff6d33a Reviewed-on: https://skia-review.googlesource.com/108501 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Delete SkottieSlide2Gravatar Florin Malita2018-02-20
| | | | | | | | | | | Now superseded by the generic SlideDir. TBR= Change-Id: Ia9adfc54dcb86ebb0cd50d2e1f4739896279de8f Reviewed-on: https://skia-review.googlesource.com/108503 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll skia/third_party/externals/skcms/ c9b7366e8..08d4cf2b3 (1 commit)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/c9b7366e85cd..08d4cf2b3965 $ git log c9b7366e8..08d4cf2b3 --date=short --no-merges --format='%ad %ae %s' 2018-02-20 brianosman Change Curve back to skcms_Curve and accommodate MFT tables Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=djsollen@google.com Change-Id: I499a7830d302318ee1da440d9f1a7329285918d3 Reviewed-on: https://skia-review.googlesource.com/108485 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Update createWrappedRenderTargetProxy with BackendRT to work with lazy proxies.Gravatar Greg Daniel2018-02-20
| | | | | | | | | | | | This change also triggered a bunch of side changes thanks to WrappedProxyTest fixing/improving how we handle wrapped proxies in genernal. Bug: skia: Change-Id: I743a458923cff1c2e947627d0e9154a4c808a668 Reviewed-on: https://skia-review.googlesource.com/108102 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Start thread pool in skia_dm on Android.Gravatar Dongwon Kang2018-02-20
| | | | | | | | | | | | | Android media framework is expected to be run with the background thread pool for handling binder RPC calls. Test: skia_dm does not hang with heif files. Bug: 65463215 Bug: 72869975 Change-Id: I2333d5a13d6145e9468464fa93807851e3a17bc8 Reviewed-on: https://skia-review.googlesource.com/108141 Reviewed-by: Chong Zhang <chz@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Revert "Increase ninja thread count for Android build on Linux."Gravatar Stephan Altmueller2018-02-20
| | | | | | | | | | | | | | | also Revert "Increase ninja thread count for Windows builds." This reverts commit 98c4231592bfadbe92d906f707d28508c50b0c16. This reverts commit 50a808a518c895c956c6d30d07e1e81e5e7abddb. Bug: skia: Change-Id: I7cc50b0bec6e1ad9f9d971a5c88c029488bb80ed Reviewed-on: https://skia-review.googlesource.com/108504 Reviewed-by: Stephan Altmueller <stephana@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* don't trust stored segment maskGravatar Mike Reed2018-02-20
| | | | | | | | | Bug: skia:7604 Change-Id: I508bbdc006e1c6edce2006be0c43b037038c876b Reviewed-on: https://skia-review.googlesource.com/108360 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Pass Viewer touch events to slidesGravatar Florin Malita2018-02-20
| | | | | | | Change-Id: Ia7b097c22e497e4e84be45108ac9796d89305ef3 Reviewed-on: https://skia-review.googlesource.com/108363 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Change createWrappedTextureProxy for render targets to use lazy proxies.Gravatar Greg Daniel2018-02-20
| | | | | | | | Bug: skia: Change-Id: If5e5e4716dceeedb4c5ad0e8c621f72799d11eb2 Reviewed-on: https://skia-review.googlesource.com/107261 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Remove XSAN blacklistGravatar Kevin Lubick2018-02-20
| | | | | | | | Bug: skia: Change-Id: I97bf83ca001acc762a42d26207a394faee6d90fb Reviewed-on: https://skia-review.googlesource.com/107782 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* loop over all color and alpha typesGravatar Mike Klein2018-02-20
| | | | | | | | | Bug: skia:7614 Change-Id: Ib51c7e280044b0817ddddd562090b95496547680 Reviewed-on: https://skia-review.googlesource.com/108061 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* [recipes] More hackery to work around old depot_toolsGravatar Eric Boren2018-02-20
| | | | | | | | Bug: skia:7609 Change-Id: I3c23df024afda53d50409ef19e1de9274a664111 Reviewed-on: https://skia-review.googlesource.com/108440 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* null checkGravatar Mike Reed2018-02-20
| | | | | | | | Bug: oss-fuzz: 6478 Change-Id: I8730ce6444cdcaac5a610f864d902a16942635a6 Reviewed-on: https://skia-review.googlesource.com/108400 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Simplify decal for gradientsGravatar Mike Reed2018-02-19
| | | | | | | | | | | | Previous change extended the stored array of colors/positions, and lost the information that the intent was decal. This variant just uses custom stages already developed for imageshader, keeping the intent of decal. Bug: skia:7638 Change-Id: Ie3f30b42f4c1793487f08039cd3cea8e31aafc40 Reviewed-on: https://skia-review.googlesource.com/108280 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* hide virtual and rename to onMakeComposedGravatar Mike Reed2018-02-19
| | | | | | | | Bug: skia: Change-Id: Ic18ee2af3273f81ebec9c9031162e808186c0acd Reviewed-on: https://skia-review.googlesource.com/108300 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SlideDir focus w/ animationGravatar Florin Malita2018-02-19
| | | | | | | | | | | | | | Add an animated "focus" mode for SlideDir. Clicking a cell focuses. SPACE unfocuses. When a slide is focused, mouse and key events are passed through. TBR= Change-Id: Iec47e2327e3b21bd626846bb0d3f9107bf680b1b Reviewed-on: https://skia-review.googlesource.com/108101 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Fix thrashing issue with multitextured atlas.Gravatar Jim Van Verth2018-02-17
| | | | | | | | | | | | | | To try to reduce memory usage, the atlas will look for space in the earliest created pages and then invalidate plots in the latest page to try to move those plots into an earlier one. The problem was that the available space was not being evicted, so we kept loading data back into the latest page. Bug: skia: Change-Id: Ic8668f6f66bf1153dbcb5edae7622fa9edfa71dd Reviewed-on: https://skia-review.googlesource.com/98801 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* add decal tilemode to shadersGravatar Mike Reed2018-02-16
| | | | | | | | | | | | | Plenty more to follow-up: - gradients - gpu impl Bug: skia:7638 Change-Id: I8e54fd0e24921f040f178c793b36c7fb855b136e Reviewed-on: https://skia-review.googlesource.com/107420 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* [recipes] Expand depot_tools DEPS hack for flutter and PDFium buildsGravatar Eric Boren2018-02-16
| | | | | | | | Bug: skia:7609 Change-Id: Iaaaa2390d87656a4fa40e44fc31c35573abec7b5 Reviewed-on: https://skia-review.googlesource.com/108186 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll skia/third_party/externals/skcms/ 0fb1530a0..c9b7366e8 (2 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/0fb1530a0b7d..c9b7366e85cd $ git log 0fb1530a0..c9b7366e8 --date=short --no-merges --format='%ad %ae %s' 2018-02-16 mtklein test sRGB -> linear byte explicitly 2018-02-16 mtklein add skcms_IsSRGB() Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=caryclark@google.com Change-Id: I6843c343a20cdcae50c3c3a4fe41ae3088c62b45 Reviewed-on: https://skia-review.googlesource.com/108200 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Forward internal_private_accessTopLayerRenderTargetContext from ↵Gravatar Chris Dalton2018-02-16
| | | | | | | | | | | | | SkPaintFilterCanvas Fixes viewer slides that need direct access to Ganesh. Bug: skia: Change-Id: Icfdd814e53ce333f4a20353e8bc4dddde3cc72df Reviewed-on: https://skia-review.googlesource.com/108020 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Guard ignored SVG attribute logging with SK_VERBOSE_SVG_PARSINGGravatar Florin Malita2018-02-16
| | | | | | | Change-Id: I01bb8c70dfcd3180aaf620f987b99ae0286cc48c Reviewed-on: https://skia-review.googlesource.com/108160 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* report ignore attr once onlyGravatar Cary Clark2018-02-16
| | | | | | | | | | | | | | bots like this one https://chromium-swarm.appspot.com/task?id=3bb84dda02fc0e10 fill its log with this debug message, so just write it once R=fmalita@chromium.org Bug: skia: Change-Id: Ia82d89aa23c3a5984080f5d9efdc03ff18b6515e Reviewed-on: https://skia-review.googlesource.com/108100 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Add full scaling for color emoji.Gravatar Jim Van Verth2018-02-16
| | | | | | | | Bug: skia:7562 Change-Id: If6788a5004fe060b42a4e437f9b8c18459623225 Reviewed-on: https://skia-review.googlesource.com/106821 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Ensure all rows of a gif are initializedGravatar Leon Scroggins III2018-02-16
| | | | | | | | | | | | | | | | | Bug: oss-fuzz:6274 Even if a frame does not have enough LZW blocks to decode all rows, (which is unknown until we actually decode them), it is marked complete once there are no more LZW blocks. When decoding, even if we've decoded all LZW blocks, check fRowsDecoded to determine whether we've actually all the rows. Report the number of rows decoded so that SkCodec can fill in the remaining ones. Change-Id: I1d6e0c29e3c37649725836cf24a4a239e3266b76 Reviewed-on: https://skia-review.googlesource.com/106964 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Roll skia/third_party/externals/skcms/ c42baa572..0fb1530a0 (1 commit)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/c42baa5729aa..0fb1530a0b7d $ git log c42baa572..0fb1530a0 --date=short --no-merges --format='%ad %ae %s' 2018-02-16 mtklein fix typo Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=caryclark@google.com Change-Id: I1619e5eeaa92937ce87a6fdec3b69490166f4981 Reviewed-on: https://skia-review.googlesource.com/108080 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Fix nullptr access when ProcessorOptimizationValidationTest failsGravatar Brian Salomon2018-02-16
| | | | | | | Change-Id: Ifcd25299825b633b6eb26f8471ff8321ec65d267 Reviewed-on: https://skia-review.googlesource.com/108064 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add a generalized array of bytes with a given alignmentGravatar Herb Derby2018-02-16
| | | | | | | Change-Id: I1bf453754bdc16452aff7d6d63ef464c7edf6df3 Reviewed-on: https://skia-review.googlesource.com/108062 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add an actual config for GPU NativeFonts testsGravatar Jim Van Verth2018-02-16
| | | | | | | | Bug: skia:7562 Change-Id: I21eb1d9aa6717edcd89d958149e1ad250b4bf154 Reviewed-on: https://skia-review.googlesource.com/107944 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* register SIGTERM handler in DMGravatar Mike Klein2018-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should make it clear when we are terminated, and print out our memory usage on the way out the door. There's no way to register a handler for SIGKILL, so if we're being cut down that way, we'll have to restructure DM quite a bit internally to spawn processes instead of threads. The parent process should be able to at least notice that child processes have been SIGKILL'd. (This would be nice anyway, so one crash doesn't ruin our whole run.) Here's a demo with a slightly hacked up DM to make the demo easy: ~/skia (sig↑1|✔) $ ninja -C out dm; and out/dm ninja: Entering directory `out' [2/2] link dm my pid is 65360 We have been politely asked to die by Terminated: 15 (15). Currently using 11MB RAM, peak 11MB. fish: 'and out/dm' terminated by signal SIGTERM (Polite quit request) Bug: skia:7614 Change-Id: Ie43be78fa766433a9d7cf391d78801d4355e635c Reviewed-on: https://skia-review.googlesource.com/107720 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* improve bookmaker defines and referencesGravatar Cary Clark2018-02-16
| | | | | | | | | | | | | | | | generating replacement includes exposed errors mostly dealing with globals like SkAlphaType and members. Rewrite finding and resolving links to hopefully make this area more robust. TBR=caryclark@google.com Docs-Preview: https://skia.org/?cl=107160 Bug: skia:6898 Change-Id: I9b8025160203d204286f3f6ca0cebd70da6253b4 Reviewed-on: https://skia-review.googlesource.com/107160 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Fix flicker when changing backend on iOS viewerGravatar Brian Osman2018-02-16
| | | | | | | | | This is the same fix from: https://skia-review.googlesource.com/c/skia/+/107941 Change-Id: I1367b1fc466cecbc2733b4e337376ce9f48cb6d8 Reviewed-on: https://skia-review.googlesource.com/107980 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>