aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Add a method to convert SkCodec::Result to a stringGravatar Leon Scroggins III2018-01-16
| | | | | | | | Bug: b/63909536 Change-Id: Ic91e3401359f80eadd9d1cd79aa8ef642c60b0fc Reviewed-on: https://skia-review.googlesource.com/94781 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
* Fix Viewer slide load on backend changeGravatar Florin Malita2018-01-16
| | | | | | | | | | | | Currently Viewer fires unbalanced load events on backend change. Instead of calling setupCurrentSlide() with an invalid prevSlide and always forcing a slide load, pass a |force| argument on backend change. Change-Id: I146b42331f5aa9721d4f407b81c13f4512d67d61 Reviewed-on: https://skia-review.googlesource.com/94960 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Delete Gr testing contexts in reverse orderGravatar Greg Daniel2018-01-16
| | | | | | | | | | | This fixes issues where we create a child shared context and expect work on that to finish before deleting the parent. Bug: skia: Change-Id: Iab41b22026cd4b9ec1b9d74e7841ee5051df6036 Reviewed-on: https://skia-review.googlesource.com/94962 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Fix file loading from bundles on iOSGravatar Brian Osman2018-01-16
| | | | | | | | Bug: skia: Change-Id: I9b9a7dcbdeb1630794b04d2a5a00d5f496aae85d Reviewed-on: https://skia-review.googlesource.com/94963 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* request SPIR-V InputAttachment capability when neededGravatar Ethan Nicholas2018-01-16
| | | | | | | | Bug: skia: Change-Id: I800b2aaf250b39f7d5d5bf8d6c8f72afab0f3743 Reviewed-on: https://skia-review.googlesource.com/93720 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Move resourceProvider accessor to GrContextPrivGravatar Robert Phillips2018-01-16
| | | | | | | | Change-Id: I5cddd620a7ec4b006b7359864ede58e9d4dd684e Reviewed-on: https://skia-review.googlesource.com/94340 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Fix FPsGravatar Robert Phillips2018-01-16
| | | | | | | | | The generated FPs have been broken for a while Change-Id: I32bcb3f8c5510049f65a44e226fa78149e01587f Reviewed-on: https://skia-review.googlesource.com/94901 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Fix --preAbandonGpuContext botsGravatar Robert Phillips2018-01-16
| | | | | | | Change-Id: I6c6375b1c3c74c07d0723606f905fbbef233a4f1 Reviewed-on: https://skia-review.googlesource.com/94860 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Remove color space restrictions from GrBackendTextureImageGeneratorGravatar Brian Osman2018-01-16
| | | | | | | | | | | | | This restriction should have only been enforced in linear-blending mode, and even then, it's no longer true. Fixes https://github.com/flutter/flutter/issues/14077 Bug: skia: Change-Id: Ie0904475e29b213ad7995b8f39c02f6ea7396a9a Reviewed-on: https://skia-review.googlesource.com/94782 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "Revert "Added SkSL workaround for devices which cannot safely access ↵Gravatar Brian Osman2018-01-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gl_FragCoord"" This reverts commit 9d6929cccfc3e64e75e6ef5b37f284b01b68fb28. Reason for revert: Re-landing, backfill reveals none of the red was related to this CL. Original change's description: > Revert "Added SkSL workaround for devices which cannot safely access gl_FragCoord" > > This reverts commit 1001f843a45e95f6df1d44242b6b06c77898e870. > > Reason for revert: Many failures. > > Original change's description: > > Added SkSL workaround for devices which cannot safely access gl_FragCoord > > > > This is the root cause of https://github.com/flutter/flutter/issues/13216 > > I've got a GM that demonstrates the bug, but only in Viewer. > > > > Bug: skia:7410 > > Change-Id: Iaa1f27b10166aa09e4dc5949e5a6ca1bd14c99ac > > Reviewed-on: https://skia-review.googlesource.com/93920 > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Commit-Queue: Brian Osman <brianosman@google.com> > > TBR=bsalomon@google.com,brianosman@google.com,ethannicholas@google.com > > Change-Id: I2a2edc0a8fa11fe9dac1045dc79ae91106518b02 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7410 > Reviewed-on: https://skia-review.googlesource.com/94281 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=bsalomon@google.com,brianosman@google.com,ethannicholas@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:7410 Change-Id: Ib22bda7ff25bb7c8630cc6fa6dc809bf628ea853 Reviewed-on: https://skia-review.googlesource.com/94800 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Don't apply coverage aa on image edges when target has msaa.Gravatar Brian Salomon2018-01-16
| | | | | | | | | Instead use msaa. Change-Id: Iaf72781863ea9485e9a927f1fd53cfef1ef6485d Reviewed-on: https://skia-review.googlesource.com/94142 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Funnel most proxy creation through GrProxyProviderGravatar Robert Phillips2018-01-16
| | | | | | | | | This is to provide a choke point for DDL to create Lazy Proxies. Change-Id: If178da13bc6447b31b7601810236d34502d9efbd Reviewed-on: https://skia-review.googlesource.com/93303 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Update SKP versionGravatar UpdateSKPs2018-01-14
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I722c00929081ea067ba7afd5fbd98b1ca16d7c40 Reviewed-on: https://skia-review.googlesource.com/94580 Commit-Queue: update-skps <update-skps@skia.org> Reviewed-by: update-skps <update-skps@skia.org>
* Revert "Revert "Revert "Revert "Snap alpha for small rects""""Gravatar Yuqian Li2018-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ea560af463c2a791c7c320a81828e5f407360c84. Reason for revert: the guard flag is now in Google3 Original change's description: > Revert "Revert "Revert "Snap alpha for small rects""" > > This reverts commit 15150a60ebea7b268493d0595cec7db9a5465fac. > > Reason for revert: we suspect this is behind the roll failures > > Original change's description: > > Revert "Revert "Snap alpha for small rects"" > > > > This reverts commit 131c8ea4b7ffad7ebf6c49cf9337602f1249806d. > > > > Reason for revert: the CL does not seem to have caused any failures > > > > Original change's description: > > > Revert "Snap alpha for small rects" > > > > > > This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. > > > > > > Reason for revert: possibly causing Google3 roll failure? > > > > > > Original change's description: > > > > Snap alpha for small rects > > > > > > > > This is more similar to our alpha snapping in AAA. More critically, we > > > > may have a tiny alpha difference after some 90 degree rotations and that > > > > breaks the Chromium svg layout tests (where the expected reference is a > > > > rotated svg...) > > > > > > > > TBR: fmalita@google.com > > > > Bug: skia: > > > > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > > > > Reviewed-on: https://skia-review.googlesource.com/92940 > > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > > > > > Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: skia: > > > Reviewed-on: https://skia-review.googlesource.com/93323 > > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > > > TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > > > Change-Id: I0cb343fa5448ecf0e6a2073bb4e3603275d6984c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/93680 > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: If00c7c8cb6b44c489615444b9aca5a2f25b2d5fe > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/93860 > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I68d6b968460f0541d658a8641ca5e147405292d0 Reviewed-on: https://skia-review.googlesource.com/94540 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Revert "relax path bounds check so we can draw larger paths"Gravatar Mike Reed2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e2330261a704e2db762e2de0d297bf8b4dc510f1. Reason for revert: triggered assert 48.3s start tiles_rt-8888 gm bigrect 48.3s start tiles_rt-8888 gm big_rrect_circle_aa_effect 48.3s start tiles_rt-8888 gm big_rrect_ellipse_aa_effect ../../../src/core/SkScan_Path.cpp(229): fatal error: "assert(leftE->fFirstY <= stop_y)" Original change's description: > relax path bounds check so we can draw larger paths > > Bug:800804 > Change-Id: Ief0679de95887d8e11aa5853228c2bdef27d07a2 > Reviewed-on: https://skia-review.googlesource.com/94100 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=egdaniel@google.com,liyuqian@google.com,reed@google.com Change-Id: I63509625b8afaa2064f0b187c17b73bd7739cdb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800804 Reviewed-on: https://skia-review.googlesource.com/94481 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Use GrOvalOpFactory ops to draw non-AA rrects, ovals, and arcs."Gravatar Greg Daniel2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7cdabedc8b73b70e4aa70c5621a4bdc8e00ede44. Reason for revert: Speculative revert for causing GLProgram failure on textureBarrierSupport assert Original change's description: > Use GrOvalOpFactory ops to draw non-AA rrects, ovals, and arcs. > > This improves performance. > > Bug: skia: > Change-Id: Ie01170ec084be66ea166b2baffcdb415583aa523 > Reviewed-on: https://skia-review.googlesource.com/93321 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com Change-Id: I327e133c889207fb682bec7d6a95f9bf1403770b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/94161 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Added SkSL workaround for devices which cannot safely access ↵Gravatar Brian Osman2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gl_FragCoord" This reverts commit 1001f843a45e95f6df1d44242b6b06c77898e870. Reason for revert: Many failures. Original change's description: > Added SkSL workaround for devices which cannot safely access gl_FragCoord > > This is the root cause of https://github.com/flutter/flutter/issues/13216 > I've got a GM that demonstrates the bug, but only in Viewer. > > Bug: skia:7410 > Change-Id: Iaa1f27b10166aa09e4dc5949e5a6ca1bd14c99ac > Reviewed-on: https://skia-review.googlesource.com/93920 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=bsalomon@google.com,brianosman@google.com,ethannicholas@google.com Change-Id: I2a2edc0a8fa11fe9dac1045dc79ae91106518b02 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7410 Reviewed-on: https://skia-review.googlesource.com/94281 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add Android ASAN botGravatar Kevin Lubick2018-01-12
| | | | | | | | | | | It should work on 32 and 64 bit android running M or newer. Bug: skia: Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c Reviewed-on: https://skia-review.googlesource.com/93700 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Roll skia/third_party/externals/angle2/ 1ea85a131..dda048cdc (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/1ea85a1316cf..dda048cdc9a6 $ git log 1ea85a131..dda048cdc --date=short --no-merges --format='%ad %ae %s' 2018-01-11 fjhenigman Make scripts executable by python2. 2018-01-11 kvark Fix the format check in TextureD3D_2DArray::redefineImage Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: Iced3e8b1c8c026c74aa93343262dfd78bdbbbf10 Reviewed-on: https://skia-review.googlesource.com/94240 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [skotty] Refactor paint opacityGravatar Florin Malita2018-01-12
| | | | | | | | | | Promote to a PaintNode attribute, drop color composite. TBR= Change-Id: Ia79d5f7e193a472d53ac4ff8beb7234d4dc26cef Reviewed-on: https://skia-review.googlesource.com/94280 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Force BackendTextureImageGenerator to work on only 1 consumer contextGravatar Greg Daniel2018-01-12
| | | | | | | | Bug: skia: Change-Id: I83d3e4af6f20c877c541964fdd489434f6a62b25 Reviewed-on: https://skia-review.googlesource.com/93200 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Add an SkDrawable for animated images (e.g. GIF)Gravatar Leon Scroggins III2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: b/63909536 SkAnimatedImage is a simple drawable for animating a GIF. Thread-safety is left up to the client. At most two bitmaps are stored in the drawable; one for the current frame and one for a frame that may need to be restored. The backup frame prevents some cases where we would otherwise have to re-decode from the beginning of the image. The API lets the client set the time value, and decodes to match that time. TODO: - Callback for when the animation is complete - Ability to use SkAndroidCodec - Modify the loop count (or leave that up to client?) - Better and/or client-specific caching Other changes: - Add a sample which animates a GIF - Reenable SK_CODEC_PRINTF for debug builds and Android Change-Id: I945ffbccdb6008f2a05ed4d9b2af869a261fb300 Reviewed-on: https://skia-review.googlesource.com/93420 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Updating lazy proxys to support the case where we know a lot more info about ↵Gravatar Greg Daniel2018-01-12
| | | | | | | | | | | | the texture. This is needed for future DDL texture work. Bug: skia: Change-Id: I07e0b9c67509e63b9cac00adc355254d03784df8 Reviewed-on: https://skia-review.googlesource.com/91500 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* relax path bounds check so we can draw larger pathsGravatar Mike Reed2018-01-12
| | | | | | | | Bug:800804 Change-Id: Ief0679de95887d8e11aa5853228c2bdef27d07a2 Reviewed-on: https://skia-review.googlesource.com/94100 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Use GrOvalOpFactory ops to draw non-AA rrects, ovals, and arcs.Gravatar Brian Salomon2018-01-12
| | | | | | | | | | This improves performance. Bug: skia: Change-Id: Ie01170ec084be66ea166b2baffcdb415583aa523 Reviewed-on: https://skia-review.googlesource.com/93321 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Added SkSL workaround for devices which cannot safely access gl_FragCoordGravatar Brian Osman2018-01-12
| | | | | | | | | | | This is the root cause of https://github.com/flutter/flutter/issues/13216 I've got a GM that demonstrates the bug, but only in Viewer. Bug: skia:7410 Change-Id: Iaa1f27b10166aa09e4dc5949e5a6ca1bd14c99ac Reviewed-on: https://skia-review.googlesource.com/93920 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Begin support for large color emoji glyphsGravatar Jim Van Verth2018-01-12
| | | | | | | | Bug: skia: Change-Id: I10184a0c2ffae9baf3adb3c670d5e61ceeaf90ff Reviewed-on: https://skia-review.googlesource.com/93360 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* [skotty,sksg] Initial gradient supportGravatar Florin Malita2018-01-12
| | | | | | | | TBR= Change-Id: I61e4d46ac14660f4c9ea757be2278e4098131a6b Reviewed-on: https://skia-review.googlesource.com/94121 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* GrTessellator: eliminate some redundant computation.Gravatar Stephen White2018-01-12
| | | | | | | | | No need to recompute the bisector when mitering. Change-Id: If7b99244d530d4b2241b7b45611f9401b2f02d69 Reviewed-on: https://skia-review.googlesource.com/93673 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Bitmap: clearing pixelref keeps rowbytesGravatar Hal Canary2018-01-12
| | | | | | | Change-Id: Ibf8b69adcb4e9df597079a8d9ada75b4a31194e6 Reviewed-on: https://skia-review.googlesource.com/94040 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* [recipes] Define variables in __init__Gravatar Eric Boren2018-01-12
| | | | | | | | | | This may fix weird races in tests. Bug: skia: Change-Id: I41c36424c7b559301e915a0892590c74931ae463 Reviewed-on: https://skia-review.googlesource.com/93942 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll skia/third_party/externals/angle2/ e1aa92193..1ea85a131 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/e1aa92193142..1ea85a1316cf $ git log e1aa92193..1ea85a131 --date=short --no-merges --format='%ad %ae %s' 2018-01-11 fjhenigman Add #! line to scripts/bootstrap.py. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: I01c930dac176088759a32de780e70645673732e6 Reviewed-on: https://skia-review.googlesource.com/93786 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Blacklist SkImage_makeNonTextureImage on Skylake vkGravatar Chris Dalton2018-01-12
| | | | | | | | Bug: skia: Change-Id: I7394d2f392d7179777b65e77194436271efea80d Reviewed-on: https://skia-review.googlesource.com/93760 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Simplify call when finished with bitmaps.Gravatar Mike Reed2018-01-12
| | | | | | | Bug: skia: Change-Id: I841052bdaf68f6ec4c98a045712941f313a7b27b Reviewed-on: https://skia-review.googlesource.com/94000 Reviewed-by: Hal Canary <halcanary@google.com>
* Revert "Revert "fix legacy makeRasterImage()""Gravatar Mike Klein2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ef29e42ef3d81a0e704cf0efcfc9937b531f0327. Reason for revert: probably not either roll. Original change's description: > Revert "fix legacy makeRasterImage()" > > This reverts commit 7c4ca043361f6adb3d17a9d3db2397d86bac5a2d. > > Reason for revert: layout, cereal tests? > > Original change's description: > > fix legacy makeRasterImage() > > > > Passing the color space down into SkImage_Lazy ends up triggering a > > SkTransferFunctionBehavior::kRespect decode (tf(r*a)), where we want > > ignore (tf(r)*a) to have any hope of working with the legacy backend. > > > > This fix in turn needs another little extension of another old hack in > > SkImage_Gpu for makeNonTextureImage() to keep working there. > > > > Bug: skia:7479 > > > > Change-Id: If48ca68e95d9eee597f6b10434498049981314ba > > Reviewed-on: https://skia-review.googlesource.com/93380 > > Commit-Queue: Mike Klein <mtklein@chromium.org> > > Reviewed-by: Brian Osman <brianosman@google.com> > > TBR=mtklein@chromium.org,brianosman@google.com > > Change-Id: I65092e01d767ef1fd35563f0b79ceded3c12b267 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7479 > Reviewed-on: https://skia-review.googlesource.com/93820 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com Change-Id: Ic9b48d311cca152ab2e620363dd4528ed382eb88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7479 Reviewed-on: https://skia-review.googlesource.com/93960 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Revert "Revert "Revert "Snap alpha for small rects"""Gravatar Ethan Nicholas2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 15150a60ebea7b268493d0595cec7db9a5465fac. Reason for revert: we suspect this is behind the roll failures Original change's description: > Revert "Revert "Snap alpha for small rects"" > > This reverts commit 131c8ea4b7ffad7ebf6c49cf9337602f1249806d. > > Reason for revert: the CL does not seem to have caused any failures > > Original change's description: > > Revert "Snap alpha for small rects" > > > > This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. > > > > Reason for revert: possibly causing Google3 roll failure? > > > > Original change's description: > > > Snap alpha for small rects > > > > > > This is more similar to our alpha snapping in AAA. More critically, we > > > may have a tiny alpha difference after some 90 degree rotations and that > > > breaks the Chromium svg layout tests (where the expected reference is a > > > rotated svg...) > > > > > > TBR: fmalita@google.com > > > Bug: skia: > > > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > > > Reviewed-on: https://skia-review.googlesource.com/92940 > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > > > Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/93323 > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: I0cb343fa5448ecf0e6a2073bb4e3603275d6984c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/93680 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: If00c7c8cb6b44c489615444b9aca5a2f25b2d5fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/93860 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert "fix legacy makeRasterImage()"Gravatar Mike Klein2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7c4ca043361f6adb3d17a9d3db2397d86bac5a2d. Reason for revert: layout, cereal tests? Original change's description: > fix legacy makeRasterImage() > > Passing the color space down into SkImage_Lazy ends up triggering a > SkTransferFunctionBehavior::kRespect decode (tf(r*a)), where we want > ignore (tf(r)*a) to have any hope of working with the legacy backend. > > This fix in turn needs another little extension of another old hack in > SkImage_Gpu for makeNonTextureImage() to keep working there. > > Bug: skia:7479 > > Change-Id: If48ca68e95d9eee597f6b10434498049981314ba > Reviewed-on: https://skia-review.googlesource.com/93380 > Commit-Queue: Mike Klein <mtklein@chromium.org> > Reviewed-by: Brian Osman <brianosman@google.com> TBR=mtklein@chromium.org,brianosman@google.com Change-Id: I65092e01d767ef1fd35563f0b79ceded3c12b267 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7479 Reviewed-on: https://skia-review.googlesource.com/93820 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Roll skia/third_party/externals/angle2/ ea22b7a58..e1aa92193 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ea22b7a58bfd..e1aa92193142 $ git log ea22b7a58..e1aa92193 --date=short --no-merges --format='%ad %ae %s' 2018-01-08 geofflang Create a new DeviceImpl each time one is requested from a DisplayImpl. Created with: roll-dep skia/third_party/externals/angle2BUG=742034 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: Ibb70a692449ebc04580b2dc0cffd4340cebb804f Reviewed-on: https://skia-review.googlesource.com/93784 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/externals/angle2/ ed1390f80..ea22b7a58 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ed1390f808b0..ea22b7a58bfd $ git log ed1390f80..ea22b7a58 --date=short --no-merges --format='%ad %ae %s' 2018-01-04 oetuaho Constant fold array indexing and comparison Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: I40707309b62099c563c42a817d53b2cfe0901944 Reviewed-on: https://skia-review.googlesource.com/93781 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/externals/angle2/ 540a1dfe1..ed1390f80 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/540a1dfe131e..ed1390f808b0 $ git log 540a1dfe1..ed1390f80 --date=short --no-merges --format='%ad %ae %s' 2018-01-05 fjhenigman Doc fix and improvement. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: Ic25dba51a36787cf7ffdb0ff679deb00837e85dd Reviewed-on: https://skia-review.googlesource.com/93677 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert cert dim now that all Mac builders have new cert.Gravatar Ben Wagner2018-01-11
| | | | | | | | Bug: chromium:799625, skia:7408 Change-Id: Ibacb40c8383559d29bfe31dcc68d40b28844853e Reviewed-on: https://skia-review.googlesource.com/92687 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Fix invalid switch in FuzzCanvasGravatar Kevin Lubick2018-01-11
| | | | | | | | | | | Also tweak when we report OOM - AFL-fuzz is fine, but libfuzzer should abort, not exit. Bug: skia: Change-Id: Ic19277bbceec5e7c0ac966d6d9ac677bcfebcfae Reviewed-on: https://skia-review.googlesource.com/93201 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Roll skia/third_party/externals/angle2/ 0e1224c82..540a1dfe1 (8 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0e1224c82c67..540a1dfe131e $ git log 0e1224c82..540a1dfe1 --date=short --no-merges --format='%ad %ae %s' 2018-01-08 geofflang Refactor DeviceImpl creation. 2018-01-08 geofflang Remove the externallyForced method of DeviceImpl. 2017-12-05 jiajia.qin ES31: Update block members static use 2018-01-10 jmadill Vulkan: Add PipelineDesc. 2018-01-10 ynovikov Flatten "#pragma STDGL invariant(all)" also for ESSL to ESSL translation 2018-01-09 jmadill common: Add aligned memory allocator. 2017-12-25 jiajia.qin Use dirty bit for draw indirect buffer 2018-01-09 oetuaho Prune unreferenced variables with a constructor initializer Created with: roll-dep skia/third_party/externals/angle2BUG=742034,742034 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=ethannicholas@google.com Change-Id: If7f378c29be6101960b37e3fa7b64171ba60b283 Reviewed-on: https://skia-review.googlesource.com/93663 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Avoid nullptr deference when deserializing SkPictureGravatar Kevin Lubick2018-01-11
| | | | | | | | | | | | Avoid resetting SkAutoSTArray values to negatives. Additionally, clean up some misc logs that aren't helpful. Bug: skia:7405 Change-Id: Ied353a4e415e2efd5ab8180e7f6c681248dd9134 Reviewed-on: https://skia-review.googlesource.com/93240 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Revert "Revert "Snap alpha for small rects""Gravatar Yuqian Li2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 131c8ea4b7ffad7ebf6c49cf9337602f1249806d. Reason for revert: the CL does not seem to have caused any failures Original change's description: > Revert "Snap alpha for small rects" > > This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. > > Reason for revert: possibly causing Google3 roll failure? > > Original change's description: > > Snap alpha for small rects > > > > This is more similar to our alpha snapping in AAA. More critically, we > > may have a tiny alpha difference after some 90 degree rotations and that > > breaks the Chromium svg layout tests (where the expected reference is a > > rotated svg...) > > > > TBR: fmalita@google.com > > Bug: skia: > > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > > Reviewed-on: https://skia-review.googlesource.com/92940 > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/93323 > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I0cb343fa5448ecf0e6a2073bb4e3603275d6984c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/93680 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Changes to site documentationGravatar Andrew Monshizadeh2018-01-11
| | | | | | | | | | | | | | | | | Mostly just formatting fixes with a few grammatical changes. Two real notable changes: - Removed references to SkGLCanvas from Tips & FAQ and replaced with references to `SkDevice` and `SkSurface`. - Deleted deprecated "Quick Start Guides" folder Docs-Preview: https://skia.org/?cl=92361 Bug: skia: Change-Id: Ief790b1c2bae8fe0e39aa8d66c79f80560d18c9e Reviewed-on: https://skia-review.googlesource.com/92361 Reviewed-by: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Add bisect_roll toolGravatar Eric Boren2018-01-11
| | | | | | | | | | | | | 1. Loads the list of commits which have not yet rolled. 2. Loads the recent roll attempts. 3. Suggests a commit to try. 4. Uploads a roll CL at the commit specified by the user. Bug: skia: Change-Id: I68a7f6dbbca638cc9f17bad4eed71e889fe43b6e Reviewed-on: https://skia-review.googlesource.com/93580 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Add in Region SetPath FuzzerGravatar Kevin Lubick2018-01-11
| | | | | | | | | | Also refactor a few things to make it easier to use oss-fuzz. Bug: skia: Change-Id: Ie518a6cfc7d57a347b5d09089379f986d33f8b7f Reviewed-on: https://skia-review.googlesource.com/41740 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Make GrTextureOp capable of edge antialiasing.Gravatar Brian Salomon2018-01-11
| | | | | | | | Bug: skia: Change-Id: I0088bdbb6a76811611fa4628656bf9513c5bf04a Reviewed-on: https://skia-review.googlesource.com/91105 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* update bookmaker to ToTGravatar Cary Clark2018-01-11
| | | | | | | | | | | | | | | more image docs, still not done add ability to comment out non-working examples easily start work on additional self-checks clean up use of this-> in docs TBR=reed@google.com Docs-Preview: https://skia.org/?cl=91720 Bug: skia:6898 Change-Id: I706ab8145290e53ab67d3f509ccf4e1225adb3c3 Reviewed-on: https://skia-review.googlesource.com/91720 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-08 20:28:07 +0000