aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Support for color-spaces with multi-stop (texture) gradientsGravatar brianosman2016-09-22
| | | | | | | | | | | | | Texture is F16 linear, unless that's not supported. In that case, we pack down to sRGB. Added more test patches to the gamut GM with many stops, to test this case. Now they render correctly. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343253002 Review-Url: https://codereview.chromium.org/2343253002
* GN: build skiaserveGravatar mtklein2016-09-22
| | | | | | | | | | | | | | | | | I trimmed the libmicrohttpd sources and defines down to the minimum needed to build and run. This builds and runs on Linux and Android for me. Request.h was missing an include for SkTypes.h, which supplies the default for SK_GPU_SUPPORTED if not otherwise defined. To build on Android, exit() -> _exit(). build.py was unused. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2367513002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2367513002
* Reland of ix for conic fuzz (patchset #1 id:1 of ↵Gravatar caryclark2016-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2361473004/ ) Reason for revert: Landed suppression in Chrome's LayoutTests/TestExpectations Original issue's description: > Revert of fix for conic fuzz (patchset #3 id:40001 of https://codereview.chromium.org/2350263003/ ) > > Reason for revert: > See if this fixes the layout tests. > > Original issue's description: > > fix for conic fuzz > > > > A fuzzer generates a conic that hangs when drawn. > > The quads that approximate the conics move up and down > > in y, confusing the renderer. > > > > This fix ensures that the split conic maintains the > > same y direction as the original conic. > > > > R=reed@google.com > > BUG=647922 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350263003 > > > > Committed: https://skia.googlesource.com/skia/+/ac78863acdef4b428aaf66985b80c76d1be0fdea > > TBR=reed@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=647922 > > Committed: https://skia.googlesource.com/skia/+/08b345588414b861af8a55950e7dc21a1bd85a28 TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=647922 Review-Url: https://codereview.chromium.org/2359253002
* Revert of fix for conic fuzz (patchset #3 id:40001 of ↵Gravatar caryclark2016-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2350263003/ ) Reason for revert: See if this fixes the layout tests. Original issue's description: > fix for conic fuzz > > A fuzzer generates a conic that hangs when drawn. > The quads that approximate the conics move up and down > in y, confusing the renderer. > > This fix ensures that the split conic maintains the > same y direction as the original conic. > > R=reed@google.com > BUG=647922 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350263003 > > Committed: https://skia.googlesource.com/skia/+/ac78863acdef4b428aaf66985b80c76d1be0fdea TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=647922 Review-Url: https://codereview.chromium.org/2361473004
* Add output format properties to SkImageFilter::ContextGravatar brianosman2016-09-22
| | | | | | | | | | | | | For now, this is just the color space (of the original requesting device). This is used when constructing intermediate rendering surfaces, so that we ensure we land in a surface that's similar/compatible to the final consumer of the DAG's output. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357273002 Review-Url: https://codereview.chromium.org/2357273002
* Make SkColorSpaceXform::New() take bare ptrsGravatar msarett2016-09-22
| | | | | | | | | | There's no need to take sk_sp if we're not going to ref the ptr. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360863003 Review-Url: https://codereview.chromium.org/2360863003
* Run commandbuffer config on CommandBuffer Perf bots.Gravatar mtklein2016-09-22
| | | | | | | | | | | | | Uh, so hey, I just noticed that while the CommandBuffer Test bot runs with --config commandbuffer, the Perf bot just runs as a vanilla GPU bot. Shouldn't we pass --config commandbuffer? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364483002 CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer-Trybot Review-Url: https://codereview.chromium.org/2364483002
* Clean up dead code.Gravatar mtklein2016-09-22
| | | | | | | | | SkOSEnvironment was used to set --enable-gl-path-rendering, and is now unused. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365483002 Review-Url: https://codereview.chromium.org/2365483002
* Is char* or uintptr_t easier to read?Gravatar cblume2016-09-22
| | | | | | | | | | Using a char* instead of uintptr_t allows us to use fewer reinterpret_casts which may make the code easier to read. BUG=648512 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356703002 Review-Url: https://codereview.chromium.org/2356703002
* Add recipe support for Intel HD Graphics 530.Gravatar benjaminwagner2016-09-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358183002 Review-Url: https://codereview.chromium.org/2358183002
* Do not quickReject until virtual drawPatchGravatar msarett2016-09-22
| | | | | | | | TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358873003 Review-Url: https://codereview.chromium.org/2358873003
* fix next kevin fuzzGravatar caryclark2016-09-22
| | | | | | | | | | Fix one more fuzzer crash. R=kjlubick@google.com BUG=skia:5775 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357373002 Review-Url: https://codereview.chromium.org/2357373002
* fix for conic fuzzGravatar caryclark2016-09-22
| | | | | | | | | | | | | | | A fuzzer generates a conic that hangs when drawn. The quads that approximate the conics move up and down in y, confusing the renderer. This fix ensures that the split conic maintains the same y direction as the original conic. R=reed@google.com BUG=647922 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350263003 Review-Url: https://codereview.chromium.org/2350263003
* speed up debug dmGravatar caryclark2016-09-22
| | | | | | | | | | SkPathMeasure can take minutes with pathological cases. Limit the debug check to a reasonable number. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343004 Review-Url: https://codereview.chromium.org/2356343004
* Add hardware monitoring to skpbenchGravatar csmartdalton2016-09-22
| | | | | | | | | | | | | | | Adds a Hardware class with hooks for entering and exiting "benchmarking" mode (e.g. locking clocks, etc.) as well as periodic polling of hardware to verify the environment is stable. Adds a partial implementation for generic Android hardware, but ultimately we will need to write specific classes tailored to each unique platform we need to test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360473002 Review-Url: https://codereview.chromium.org/2360473002
* Add Jobs to tasks.jsonGravatar borenet2016-09-22
| | | | | | | BUG=skia:5723 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363443002 Review-Url: https://codereview.chromium.org/2363443002
* GN: take over CommandBuffer botGravatar mtklein2016-09-21
| | | | | | | | | | As you suspected, I see nothing preventing us from building our side of things unconditionally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2358173002
* Use sk_careful_memcpy when writing optional conic weights for GrShape path ↵Gravatar bsalomon2016-09-21
| | | | | | | | | | | data key. TBR=robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359933002 NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2359933002
* Add optional sw generated path coverage mask cachingGravatar bsalomon2016-09-21
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335343008 All the bots except the painfully slow windows compiler have finished so, NOTRY=true Review-Url: https://codereview.chromium.org/2335343008
* allow clip calls w/o op param, remove unnecessary kReplace opsGravatar reed2016-09-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357333002 Review-Url: https://codereview.chromium.org/2357333002
* Remove unused SkImage_Base and SkImage_Gpu onNewSurface methodsGravatar robertphillips2016-09-21
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353403002 Review-Url: https://codereview.chromium.org/2353403002
* Conditionally insert gl_PointSize into shaders.Gravatar bsalomon2016-09-21
| | | | | | | BUG=chromium:648816 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358843002 Review-Url: https://codereview.chromium.org/2358843002
* Always use transfer_dst for buffers.Gravatar jvanverth2016-09-21
| | | | | | | | | This will allow Adreno to use non-coherent buffers. BUG=skia:5034 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361473002 Review-Url: https://codereview.chromium.org/2361473002
* Build tools on NoGPU bots.Gravatar mtklein2016-09-21
| | | | | | | | | | | | | | | I was just lazy disabling this before. It turns out to not be difficult. This gets us slightly better testing out of the NoGPU bot, as we now know not only that Skia compiles, but also that DM and nanobench can link (and thus that Skia's got enough compiled in it to be a coherent library). skpbench requires GPU support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356283002 Review-Url: https://codereview.chromium.org/2356283002
* Add a transient image filter cache to SkImage::makeWithFilter & PDFGravatar brianosman2016-09-21
| | | | | | | | | | | Added a bench for makeWithFilter (~23 ms -> ~6 ms median locally). Also fixed indentation. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360663002 Review-Url: https://codereview.chromium.org/2360663002
* GN: is_skia_standaloneGravatar mtklein2016-09-21
| | | | | | | | | | | | is_skia_standalone will be defined and set to true iff we're using our standalone BUILDCONFIG.gn. Any other build (Fuchsia, Chrome, Pdfium) will have their own BUILDCONFIG.gn, which presumably does not define is_skia_standalone. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357963002 Review-Url: https://codereview.chromium.org/2357963002
* fix skia pathops fuzzersGravatar caryclark2016-09-21
| | | | | | | | | | Add isolated tests. R=kjlubick@google.com BUG=skia:5775 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358043002 Review-Url: https://codereview.chromium.org/2358043002
* Make GrShape compute keys for short paths from path data instead of using ↵Gravatar bsalomon2016-09-21
| | | | | | | | the gen id. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357643002 Review-Url: https://codereview.chromium.org/2357643002
* Stop closing filled paths in GrShapeGravatar bsalomon2016-09-21
| | | | | | | | This can force a copy of the path data and isn't really being taken advantage of. It complicates a forthcoming change to key small paths based on their data rather than gen id. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002 Committed: https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8 Review-Url: https://codereview.chromium.org/2355833002
* Add define of SK_ENABLE_VK_LAYERS to gn buildGravatar egdaniel2016-09-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357953002 Review-Url: https://codereview.chromium.org/2357953002
* Add setBounds to SkLiteDL for AndroidGravatar liyuqian2016-09-21
| | | | | | | | | | The RootRenderNode in Android is changing bounds dynamically. This is a temporary fix to accomodate that behaviour. (See also b/31304115) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358793002 Review-Url: https://codereview.chromium.org/2358793002
* Fix memory leaks reported by clang static analyzer.Gravatar sdefresne2016-09-21
| | | | | | | | | | | | | | The CFURLCopyFileSystemPath & CFURLCopyFileSystemPath methods respect the "Create Rule" [1] regarding the ownership of the returned reference. This means that the objects need to be deallocated explicitly by calling CFRelease. [1]: https://developer.apple.com/library/content/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html#//apple_ref/doc/uid/20001148-103029 BUG=648210 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360573002 Review-Url: https://codereview.chromium.org/2360573002
* Fix some GPU image filter code to preserve precision and color spaceGravatar brianosman2016-09-21
| | | | | | | | | | | | | | | | | | On the pure-GPU path, we just have an SkSpecialImage (that's definitely texture backed), and we need a renderable config for the draw context we make. Added a helper function to pick - this is basically the high precision analog of what we were doing before (always using 8888). The assert that I added catches many other problems in image filter code, but those fixes are coming in subsequent CLs. 12 GMs render correctly (or more correctly) in gpusrgb and gpuf16 configs. In most cases, they were drawing previously nothing. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359443003 Review-Url: https://codereview.chromium.org/2359443003
* Remove SK_ADDING_src_ports_SkFontConfigInterface_cppGravatar bungeman2016-09-20
| | | | | | | | | | This flag is no longer defined anywhere, so remove it and the code it was guarding. TBR=reed This is just removing dead transitional code. Review-Url: https://codereview.chromium.org/2352163002
* [SVGDom] Opacity optimizationGravatar fmalita2016-09-20
| | | | | | | | | | | Apply opacity as fill/stroke paint alpha instead of saveLayer, when possible. R=robertphillips@google.com,stephana@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005 Committed: https://skia.googlesource.com/skia/+/3dbb7b9f196d793fbd16243157ee67638891f5dc Review-Url: https://codereview.chromium.org/2353503005
* Blacklist serialize-8888 typefacerendering_pfaMacGravatar mtklein2016-09-20
| | | | | | | | | | | BUG=skia:5778 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356753003 TBR=halcanary@google.com NOTREECHECKS=true CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug-GN-Trybot Review-Url: https://codereview.chromium.org/2356753003
* GN: fold :vulkan into :gpu.Gravatar mtklein2016-09-20
| | | | | | | | | | | Obviously, :vulkan can't be used without :gpu, but more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2352923003
* Revert of Stop closing filled paths in GrShape (patchset #1 id:1 of ↵Gravatar fmalita2016-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2355833002/ ) Reason for revert: Triggers msaa16 asserts: https://build.chromium.org/p/client.skia/builders/Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/4236/steps/test_skia%20on%20Windows/logs/stdio c:\b\work\skia\src\gpu\grmesh.h:76: fatal error: "assert(indexCount)" Caught exception 2147483651 EXCEPTION_BREAKPOINT, was running: msaa16 svg cartman.svg Likely culprit: msaa16 svg cartman.svg Original issue's description: > Stop closing filled paths in GrShape > > This can force a copy of the path data and isn't really being taken advantage of. It complicates a forthcoming change to key small paths based on their data rather than gen id. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002 > > Committed: https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8 TBR=robertphillips@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2357713002
* Revert of [SVGDom] Opacity optimization (patchset #4 id:60001 of ↵Gravatar borenet2016-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2353503005/ ) Reason for revert: Failing assertion Original issue's description: > [SVGDom] Opacity optimization > > Apply opacity as fill/stroke paint alpha instead of saveLayer, when > possible. > > R=robertphillips@google.com,stephana@google.com,reed@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005 > > Committed: https://skia.googlesource.com/skia/+/3dbb7b9f196d793fbd16243157ee67638891f5dc TBR=reed@google.com,robertphillips@google.com,stephana@google.com,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2359603002
* GN: add skia_use_mesa for OSMesa in tools.Gravatar mtklein2016-09-20
| | | | | | | | | | | | I tested by running $ out/dm --src gm --config mesa $ out/nanobench --config mesa --match Xfermode ... but I ran out of patience waiting for nanobench to finish. Probably works. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357703002 Review-Url: https://codereview.chromium.org/2357703002
* Attempt to fix nanobench uploadGravatar borenet2016-09-20
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356813003 Review-Url: https://codereview.chromium.org/2356813003
* Revert of Clear stencil buffer before using it for drawing (patchset #2 ↵Gravatar stani2016-09-20
| | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/2342873004/ ) Reason for revert: performance regression in Android macrobench tests Original issue's description: > Clear stencil buffer before using it for drawing > > Clear stencil buffer before using it for drawing. This is > resolving an issue with a failing android CTS test in drawArc. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004 > > Committed: https://skia.googlesource.com/skia/+/c326a383e1069497884905f9dd3e720e17d8fcb5 TBR=bsalomon@google.com,reed@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2355923002
* Fix VkWrapTestsGravatar jvanverth2016-09-20
| | | | | | | | BUG=skia: TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352173002 Review-Url: https://codereview.chromium.org/2352173002
* GM: add test for type1 fontGravatar halcanary2016-09-20
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350453002 Review-Url: https://codereview.chromium.org/2350453002
* Disable framebuffer fetch on the Adreno5xx devices.Gravatar egdaniel2016-09-20
| | | | | | | | | | This should help with some of the rendering bugs currently in GL for the S7. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2348293004 Review-Url: https://codereview.chromium.org/2348293004
* Fix possible divide by zero in vulkan granularity adjustmentsGravatar egdaniel2016-09-20
| | | | | | | | | This should fix the divide by zero crash on the nexus player bots BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358613002 Review-Url: https://codereview.chromium.org/2358613002
* Stop closing filled paths in GrShapeGravatar bsalomon2016-09-20
| | | | | | | This can force a copy of the path data and isn't really being taken advantage of. It complicates a forthcoming change to key small paths based on their data rather than gen id. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002 Review-Url: https://codereview.chromium.org/2355833002
* [SVGDom] Opacity optimizationGravatar fmalita2016-09-20
| | | | | | | | | | Apply opacity as fill/stroke paint alpha instead of saveLayer, when possible. R=robertphillips@google.com,stephana@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005 Review-Url: https://codereview.chromium.org/2353503005
* Disable failing unit tests on adreno vulkanGravatar egdaniel2016-09-20
| | | | | | | | | | As mentioned in the attached bug, these failures all seem to be caused by driver issues that have no workarounds at this time. BUG=skia:5777 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355883002 Review-Url: https://codereview.chromium.org/2355883002
* Use STDArray to for tracked resources in vulkan command bufferGravatar egdaniel2016-09-20
| | | | | | | | | | This is a minor speed improvement to help with the number of times we are freeing and re-allocating the tracked resource arrays BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338963004 Review-Url: https://codereview.chromium.org/2338963004
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 05:55:11 +0000