aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Flush denorm half floats to zero.Gravatar mtklein2016-08-22
| | | | | | | | | | | | | | | | | | I think we convinced ourselves that denorms, while a good chunk of half floats, cover a rather small fraction of the representable range, which is always close enough to zero to flush. This makes both paths of the conversion to or from float considerably simpler. These functions now work for zero-or-normal half floats (excluding infinite, NaN). I'm not aware of a term for this class so I've called them "ordinary". A handful of GMs and SKPs draw differently in --config f16, but all imperceptibly. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256023002 Review-Url: https://codereview.chromium.org/2256023002
* GPU implementation of drawArc.Gravatar bsalomon2016-08-22
| | | | | | | | | This adds analytic shaders for filled arcs and butt-cap stroked arcs where the center point is not used. BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259323003 Review-Url: https://codereview.chromium.org/2259323003
* Add cap type variations to circular arcs GMsGravatar bsalomon2016-08-22
| | | | | | | BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269723002 Review-Url: https://codereview.chromium.org/2269723002
* check for wide-open inside quickContainsGravatar reed2016-08-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263373002 Review-Url: https://codereview.chromium.org/2263373002
* Fix MSAN - mark temporary memory as kNo_ZeroInitializedGravatar msarett2016-08-22
| | | | | | | | TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261173004 Review-Url: https://codereview.chromium.org/2261173004
* Add trooper documentation for CT bots and for iOS "the service is invalid"Gravatar rmistry2016-08-22
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263103003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2263103003 Review-Url: https://codereview.chromium.org/2263103003
* Fix Equals and serialization for rare pngsGravatar msarett2016-08-22
| | | | | | | | | | | | | | | | PNGs may contain a gAMA chunk that specifies gamma values as floats. If so, we will use these floats to create an SkColorSpace. This CL fixes Equals(), serialize(), and Deserialize() to correctly handle SkColorSpaces with strange gammas, where we are unable to fall back on the profile data. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221983002 Review-Url: https://codereview.chromium.org/2221983002
* Revert of Moving SkBlurImageFilter into core (patchset #8 id:140001 of ↵Gravatar vjiaoblack2016-08-22
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2255803003/ ) Reason for revert: Misnamed function. Original issue's description: > Moving SkBlurImageFilter into core > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003 > > Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48 > Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0 > Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75 TBR=reed@google.com,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2265263002
* Moving SkBlurImageFilter into coreGravatar vjiaoblack2016-08-22
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003 Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48 Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0 Review-Url: https://codereview.chromium.org/2255803003
* Remove quantization of device-space dest rect for Ganesh analytic rrect blursGravatar robertphillips2016-08-22
| | | | | | | | At least on Windows, this fixes a lot of the horrible banded blurs. AFAICT there is no good reason to quantize the device space rect passed to the GrRectBlurEffect. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2262263002 Review-Url: https://codereview.chromium.org/2262263002
* Mark temp paths in SkBaseDevice::drawArc and ::drawDRRect as volatileGravatar bsalomon2016-08-22
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261123004 Review-Url: https://codereview.chromium.org/2261123004
* Fix touch event parameter orderGravatar liyuqian2016-08-22
| | | | | | | | | | | The issue is so obvious... However, all newer Android devices (e.g., Nexus 6P, 5X, 9) are immune to this bug. So I didn't notice this until I tested Viewer app on Nexus 7 yesterday... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254223002 Review-Url: https://codereview.chromium.org/2254223002
* Revert of Moving SkBlurImageFilter into core (patchset #8 id:140001 of ↵Gravatar vjiaoblack2016-08-22
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2255803003/ ) Reason for revert: Fixed it wrong, needs to revert to re-discuss and re-land. Original issue's description: > Moving SkBlurImageFilter into core > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003 > > Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48 > Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0 TBR=reed@google.com,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2266063002
* Moving SkBlurImageFilter into coreGravatar vjiaoblack2016-08-22
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003 Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48 Review-Url: https://codereview.chromium.org/2255803003
* Add stroke-and-fill circular arc test, test near 180deg arc in all ↵Gravatar bsalomon2016-08-22
| | | | | | | | | circular_arc_tests BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261233002 Review-Url: https://codereview.chromium.org/2261233002
* Detect all named gammasGravatar msarett2016-08-22
| | | | | | | | | | | | | | | | | | | | | | | | Our DstColorSpace UMA is showing some named gammas that are not appropriately detected and placed in named categories. https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&histograms=Blink.ColorSpace.Destination&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial This CL should fix that. I'm not sure (yet) how I feel about this landing permanently. Seems a little messy. But it will be interesting to see how this affects the UMA. My best guess is that we are hitting this case when all three gammas are "invalid" in different ways. I'm expecting to see some profiles end up in the "invalid" category now. It's also possible that we'll see these cases being absorbed into sRGB or somewhere else. BUG=skia:5656 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261213002 Review-Url: https://codereview.chromium.org/2261213002
* compress_r11eac_blocks() required more alignment than dst has.Gravatar mtklein2016-08-22
| | | | | | | | | | | | | | This shouldn't change any behavior except that the stores to dst will no longer require 8-byte alignment. Empirically it seems like we can use 4-byte alignment here, but u8 (i.e. 1-byte alignment) is always safe. BUG=skia:5637 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264103002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2264103002
* Revert of Moving SkBlurImageFilter into core (patchset #6 id:100001 of ↵Gravatar mtklein2016-08-22
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2255803003/ ) Reason for revert: It looks like this breaks our roll into Google3: https://test.corp.google.com/ui#id=OCL:130943857:BASE:130944046:1471881622765:61dbdd3 Original issue's description: > Moving SkBlurImageFilter into core > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003 > > Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48 TBR=reed@google.com,fmalita@chromium.org,vjiaoblack@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2263283002
* Use ARMv8 CRC32 instructions for SkOpts::hash().Gravatar mtklein2016-08-22
| | | | | | | | | | | | | | | | | | | | | | | For large inputs, this runs ~11x faster than Murmur3. My bench drops from 1µs to 88ns. Like x86-64, this runs fastest if we work in 24 byte chunks. 16 byte chunks run at about 0.75x this speed, 8 byte chunks at about 0.4x (which would still be about 5x faster than Murmur3). This'll require plumbing support for opts_crc32 into Chrome first before it can roll. perf.skia.org charts we want to watch: https://perf.skia.org/#5490 Seach for compute_hash in these logs to see the difference: baseline: https://luci-milo.appspot.com/swarming/task/30ba22f3dfe30e10/steps/nanobench/0/stdout trybot: https://luci-milo.appspot.com/swarming/task/30bbc406cbf62d10/steps/nanobench/0/stdout BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2260823002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2260823002
* Moving SkBlurImageFilter into coreGravatar vjiaoblack2016-08-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003 Review-Url: https://codereview.chromium.org/2255803003
* Support color xforms for kIndex8 pngsGravatar msarett2016-08-22
| | | | | | | | | | | | | | This change started as: "Always use color xforms to premultiply". We need to be in a linear space to premultiply correctly. It became clear that we also need to support kIndex8 color xforms in order to make this change. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246143002 Review-Url: https://codereview.chromium.org/2246143002
* 'g' key toggles showgrid for PerlinPatchGravatar reed2016-08-22
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269673002 TBR= Review-Url: https://codereview.chromium.org/2269673002
* Supply a color space in sRGB/F16 mode of SampleAppGravatar brianosman2016-08-22
| | | | | | | | | | | Ganesh now uses this to decide if it should perform gamma-correct rendering, so the color space is necessary to get correct results in S32/F16. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2266763004 Review-Url: https://codereview.chromium.org/2266763004
* Roll recipe DEPSGravatar rmistry2016-08-22
| | | | | | | BUG=skia:5627 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2266933002 Review-Url: https://codereview.chromium.org/2266933002
* 'F' will toggle filtering for the --picture sampleGravatar reed2016-08-22
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263203002 TBR= Review-Url: https://codereview.chromium.org/2263203002
* Fix color xform width bug when scaling/subsettingGravatar msarett2016-08-22
| | | | | | | | | | | | | This was not caught by the bots because we don't test color correct modes with our many image decoding tests (takes too long). Adding a unit test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247743002 Review-Url: https://codereview.chromium.org/2247743002
* Build command buffer with is_component_build=falseGravatar borenet2016-08-22
| | | | | | | BUG=skia:5630 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265913002 Review-Url: https://codereview.chromium.org/2265913002
* Adjust angles in circular arcs GMs to test smaller arcsGravatar bsalomon2016-08-22
| | | | | | | BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267713002 Review-Url: https://codereview.chromium.org/2267713002
* add SkMatrixPriv for specialized helpersGravatar reed2016-08-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268443002 Review-Url: https://codereview.chromium.org/2268443002
* GN: _turbo -> -turbo to match FuchsiaGravatar mtklein2016-08-22
| | | | | | | | | | | | | | | We might as well match the folks who are using our GN files now. We've got plenty of strategies in our pocket for when we try to move Chrome onto our GN files (and who knows, there may be even a new better way by then): * Same sort of rename in Chrome's third_party * Aliased targets via //build/secondary in Chrome. * Indirection via build_overrides BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265503002 Review-Url: https://codereview.chromium.org/2265503002
* Simplify the gradient color stop optimizerGravatar fmalita2016-08-22
| | | | | | | | | | We're just discarding the leftmost/rightmost stops -- this can be achieved by simply adjusting the start offset and count. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265803002 Review-Url: https://codereview.chromium.org/2265803002
* Add a gradient edge optimization testGravatar fmalita2016-08-22
| | | | | | | R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267593002 Review-Url: https://codereview.chromium.org/2267593002
* make zoomer text clearerGravatar reed2016-08-21
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267623002 TBR= Review-Url: https://codereview.chromium.org/2267623002
* add translate to exercise non-identity ctm performanceGravatar reed2016-08-21
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261063002 TBR= Review-Url: https://codereview.chromium.org/2261063002
* Update SKP versionGravatar update-skps2016-08-21
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261983002 Review-Url: https://codereview.chromium.org/2261983002
* remove unused field from SkDrawIterGravatar reed2016-08-20
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267553002 TBR= Review-Url: https://codereview.chromium.org/2267553002
* store info in basedevice, change getter to non-virtual const&Gravatar reed2016-08-20
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261003003 Review-Url: https://codereview.chromium.org/2261003003
* src/utils/SkBitSet: simplifyGravatar halcanary2016-08-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265623002 Review-Url: https://codereview.chromium.org/2265623002
* Rename circular_arcs_circular_arcs_fill to circular_arcs_fill.Gravatar bsalomon2016-08-19
| | | | | | | | Also fix issue with second paint's alpha getting overwritten. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265643002 Review-Url: https://codereview.chromium.org/2265643002
* Move GrFixedClip into src directoryGravatar csmartdalton2016-08-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254343003 Review-Url: https://codereview.chromium.org/2254343003
* Added a small widget framework to the interactive bevel SampleAppGravatar dvonbeck2016-08-19
| | | | | | | | | | I made a small framework to add slider and radial controls more easily. The Sample now has controls for light direction and color. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259183003 Review-Url: https://codereview.chromium.org/2259183003
* Plumb drawArc to SkDevice.Gravatar bsalomon2016-08-19
| | | | | | | | | Plumbs the drawArc canvas method down to SkDevice without converting to a path. Plumbs through the various recording canvas classes. BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2257023003 Review-Url: https://codereview.chromium.org/2257023003
* Added SkColor4f::FromColor3f(SkColor3f, float a)Gravatar dvonbeck2016-08-19
| | | | | | | | | Planning to use this for the ColorDisplay widget in https://codereview.chromium.org/2259183003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264643002 Review-Url: https://codereview.chromium.org/2264643002
* Add GMs for testing drawArc.Gravatar bsalomon2016-08-19
| | | | | | | | | | | | | | | | This is in preparation for virtualizing this on SkCanvas/SkDevice. Tests the following variations: aa and non-aa stroke/hairline/fill cap types using center point and not BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264593002 Review-Url: https://codereview.chromium.org/2264593002
* Fast path translate() in SkCanvas and SkLiteDL.Gravatar mtklein2016-08-19
| | | | | | | | | | | | | | | | | | | | | | | This adds didTranslate() so that SkLiteDL (and other canvas recorders) can record the translate rather than the full concat. It also adds a case to SkMatrix::preTranslate() to fast path translate x translate -> translate (i.e. +=). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002 Committed: https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c Misc bots failing in pictureimagefilter replay modes. https://luci-milo.appspot.com/swarming/task/30b8e53f3a1f4f10/steps/dm/0/stdout Problem is FMA vs. not. CQ_INCLUDE_TRYBOTS=master.client.skia: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot Review-Url: https://codereview.chromium.org/2255283002
* Implement gradient simplification for 0,0,1 and 0,1,1 gradientsGravatar fmenozzi2016-08-19
| | | | | | | | | Depends on https://codereview.chromium.org/2259823005/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256843004 Review-Url: https://codereview.chromium.org/2256843004
* Simplify embeddability test.Gravatar bungeman2016-08-19
| | | | | | | | | There is no reason to read the whole OS/2 table, and no need to spell out the full names of all the types over and over. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256783002 Review-Url: https://codereview.chromium.org/2256783002
* Fix bug, always keep fIsScaleTranslate in correct stateGravatar msarett2016-08-19
| | | | | | | BUG:639179 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263513003 Review-Url: https://codereview.chromium.org/2263513003
* Step 1 of opts_crc32 rollout.Gravatar mtklein2016-08-19
| | | | | | | | | | | - This adds an crc32_sources variable to opts.gypi and hooks it into our GYP build with a dummy source file. Step 2 will hook crc32_sources into Chrome's GN build. Step 3 will actually land some code using CRC32 instructions. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259233002 Review-Url: https://codereview.chromium.org/2259233002
* Some assert fixes for running the Fuzzer sample in GPU mode.Gravatar senorblanco2016-08-19
| | | | | | | | | | | | | | | quadraticPointCount, cubicPointCount: passing NaN to GrNextPow2 causes it to assert, so detect that and return the max points per curve instead. Passing a zero scale to GrStyle::applyToPath() makes it assert, so draw nothing (likely what drawing with a zero scale is going to do anyway). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2257423002 Review-Url: https://codereview.chromium.org/2257423002
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 14:37:57 +0000