| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
| |
This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc.
picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw.
I don't see any significant effect on large picture recording times from our .skps.
BUG=chromium:470553
Review URL: https://codereview.chromium.org/1061783002
|
|
|
|
|
|
| |
Motivation: I'd like sizeof(SkString) to be the same in Debug and Release.
Review URL: https://codereview.chromium.org/1073473003
|
|
|
|
|
|
|
|
| |
Prep for adding Mali fix for distance field paths.
BUG=skia:3528
Review URL: https://codereview.chromium.org/1075543002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, GM's are now being composited against white
in some modes, where the alpha used to be ignored (or composited
against black, I'm not sure which). At any rate, it doesn't
make much sense to have alpha in the result anyway, so let's clear to
opaque black instead of transparent black and avoid the problem.
This is a trial balloon for bitmapsource and pictureimagefilter.
If all goes well, I'll make this change more widely.
R=scroggo
BUG=skia:3319
Review URL: https://codereview.chromium.org/1074513002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1073593002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu.
picture_overhead_draw 1.62us -> 1.6us 0.99x
picture_overhead_nodraw 792ns -> 342ns 0.43x
tiles and serialization modes will also test this a bit.
BUG=chromium:470553
Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d
Review URL: https://codereview.chromium.org/1067893002
|
|
|
|
|
|
| |
This change leaves the feature turned off by default.
Review URL: https://codereview.chromium.org/1032873002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1055843002
|
|
|
|
|
|
| |
BUG=skia:3585
Review URL: https://codereview.chromium.org/1071583003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1071603002
|
|
|
|
|
|
|
|
|
| |
R=reed@google.com, bsalomon@google.com
Let isNested(Fill)Rect return true if drawn path describes filled
rectangles.
Review URL: https://codereview.chromium.org/1073473002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1073483002
|
|
|
|
|
|
|
|
|
|
|
| |
This change will prevent the atlas from evicting glyphs the TextBlob
needs.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2
Review URL: https://codereview.chromium.org/1050113004
|
|
|
|
|
|
|
|
| |
This was added with r4719 (f7943035) to support testing
SkTRefArray. With 703d3c70 SkTRefArray and the associated test was
removed, but the supporting InstCounterClass was not.
Review URL: https://codereview.chromium.org/1063403003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1069013002
|
|
|
|
|
|
|
|
|
| |
Also tweak formatting.
BUG=3624
R=djsollen@google.com
Review URL: https://codereview.chromium.org/1068163004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1067893002/)
Reason for revert:
https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/builds/1816
Original issue's description:
> SkCanvas::resetForNextPicture()
>
> No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu.
>
> picture_overhead_draw 1.62us -> 1.6us 0.99x
> picture_overhead_nodraw 792ns -> 342ns 0.43x
>
> tiles and serialization modes will also test this a bit.
>
> BUG=chromium:470553
>
> Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:470553
Review URL: https://codereview.chromium.org/1062353002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu.
picture_overhead_draw 1.62us -> 1.6us 0.99x
picture_overhead_nodraw 792ns -> 342ns 0.43x
tiles and serialization modes will also test this a bit.
BUG=chromium:470553
Review URL: https://codereview.chromium.org/1067893002
|
|
|
|
|
|
| |
BUG=skia:3676
Review URL: https://codereview.chromium.org/1067053002
|
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1066013002
Review URL: https://codereview.chromium.org/1066013002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
approx-match.
This revealed some further 0..1 texture coordinate
depedencies,specifically in SkDisplacementMapEffect and
SkXfermodeImageFilter, fixed through use of
GrTextureDomain.
Note: causes minor pixel diffs in pictureimagefilter,
testimagefilters GMs.
Also causes minor pixel diffs in some Blink layout tests,
suppressed here: https://codereview.chromium.org/1064943002
BUG=skia:3532
Review URL: https://codereview.chromium.org/1065683002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1068783003
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since wide strings are only used in SkPDFDevice, I have moved the
function that manages them to that directory.
Motivation: The SkPDFString will be refactored later along with the
other SkPFObject heirarchy.
BUG=skia:3585
Review URL: https://codereview.chromium.org/1064013003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1050113004/)
Reason for revert:
Breaks linux builder
Original issue's description:
> Adding bulk plot reffer to cached textblobs
>
> This change will prevent the atlas from evicting glyphs the TextBlob
> needs.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2
TBR=bsalomon@google.com,jvanverth@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1061713003
|
|
|
|
|
|
|
|
|
| |
This change will prevent the atlas from evicting glyphs the TextBlob
needs.
BUG=skia:
Review URL: https://codereview.chromium.org/1050113004
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for the uniform scale case only. Using the dFdx() function on certain
Mali GPUs causes issues because the precision is too low, so we have to
compute 1/scale from the view matrix instead.
BUG=skia:3528
Committed: https://skia.googlesource.com/skia/+/5b143038cb47763974d2750ed78d436eb6c38bea
Review URL: https://codereview.chromium.org/1029423003
|
|
|
|
|
|
|
|
| |
source_options isn't always present.
BUG=skia:
Review URL: https://codereview.chromium.org/1067863002
|
|
|
|
|
|
|
|
|
| |
I'm going to start hacking on SkCanvas a bit to allow a fast reset method,
and I want to have some testing checking me.
BUG=skia:
Review URL: https://codereview.chromium.org/1062043004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1068883004
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/1068853002
|
|
|
|
|
|
|
|
|
| |
On Mac, it appears that sometimes fonts created from data have
their table data used after the table data copy is freed.
This appears to be most common with 'sbix' fonts for some reason,
so pin that table while in use.
Review URL: https://codereview.chromium.org/1061123002
|
|
|
|
|
|
| |
BUG=472872
Review URL: https://codereview.chromium.org/1068463004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1051113005/)
Reason for revert:
Android is still using this. See https://android-build.storage.googleapis.com/builds/git_master-skia-linux-razor-userdebug/1836783/4c2968b94c5f4b238ff5ba61111bf867ea872fd8dce930612f376711883419b8/logs/build_error.log?GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Signature=ATvg9ZvwZGFDDVb%2B1Ue2WHVGaCCL1hAD7QjXeZv2gBT08I3JaKLcseUhV5K2G%2F%2BWUnsnSgNNjzjBnBLmnPbK9Uu8NC%2B%2F5J0dU3sKD8TU9dvMtkQhFQSp2x5t5Xxf5mczi2EPps%2FwoPHqTKQqrMgqStySzw206W1%2Fc135RrdrgYg%3D&Expires=1428415459
Original issue's description:
> Remove now-redundant SkPathOps enum.
>
> R=caryclark,reed
> BUG=473772
>
> Committed: https://skia.googlesource.com/skia/+/143244e27d95255807d8fa505ce0affef96d1fc8
TBR=caryclark@google.com,reed@google.com,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=473772
Review URL: https://codereview.chromium.org/1068873002
|
|
|
|
|
|
|
|
| |
Copied from notes Robert emailed me.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1051653006
Review URL: https://codereview.chromium.org/1051653006
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If no one has read the picture's unique ID, there's no point invalidating it.
This is the same trick we pull with SkPixelRefs.
Before:
26M 1 1.49µs 1.6µs 1.77µs 6.25µs 42% picture_overhead_draw
13M 32 742ns 749ns 756ns 823ns 2% picture_overhead_nodraw
After:
26M 1 1.27µs 1.33µs 1.49µs 5.51µs 45% picture_overhead_draw
14M 43 677ns 680ns 681ns 701ns 1% picture_overhead_nodraw
BUG=skia:
Review URL: https://codereview.chromium.org/1061283002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1061193003
|
|
|
|
|
|
|
|
| |
use pre-allocated space in the canvas to avoid initial calls to malloc
BUG=skia:
Review URL: https://codereview.chromium.org/1060583007
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #6 id:100001 of https://codereview.chromium.org/1029423003/)
Reason for revert:
This appears to be breaking large text on Nexus 7.
Original issue's description:
> Calculate inverse scale for distance field text in vertex shader
>
> This is for the uniform scale case only. Using the dFdx() function on certain
> Mali GPUs causes issues because the precision is too low, so we have to
> compute 1/scale from the view matrix instead.
>
> BUG=skia:3528
>
> Committed: https://skia.googlesource.com/skia/+/5b143038cb47763974d2750ed78d436eb6c38bea
TBR=bsalomon@google.com,joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3528
Review URL: https://codereview.chromium.org/1066613003
|
|
|
|
|
|
|
|
|
| |
Replaced with an inline script in
https://codereview.chromium.org/1068503002/
BUG=skia:3521
Review URL: https://codereview.chromium.org/1062873002
|
|
|
|
|
|
|
| |
R=mtklein
BUG=skia:3654
Review URL: https://codereview.chromium.org/1064663003
|
|
|
|
|
|
|
|
|
|
| |
This is for the uniform scale case only. Using the dFdx() function on certain
Mali GPUs causes issues because the precision is too low, so we have to
compute 1/scale from the view matrix instead.
BUG=skia:3528
Review URL: https://codereview.chromium.org/1029423003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1057613002
|
|
|
|
|
|
|
|
|
|
|
| |
This is the same clamp we do in onCreateTexture() for Skia-native textures.
Without this fix, setting to a count higher than the max in Chrome results
in a black screen.
BUG=skia:
Review URL: https://codereview.chromium.org/1056253003
|
|
|
|
|
|
|
| |
R=caryclark,reed
BUG=473772
Review URL: https://codereview.chromium.org/1051113005
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- It's no longer needed to help the (2011?) transition to SkAutoTUnref.
- It prevents us from making classes that go in SkAutoTUnrefs final,
i.e. all ref-counted classes.
This had better not have been public API...
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1068443002
|
|
|
|
|
|
| |
BUG=skia:3653
Review URL: https://codereview.chromium.org/1054593006
|
|
|
|
|
|
|
|
| |
This looks a lot closer to what Chromium's profiling is showing.
BUG=chromium:470553
Review URL: https://codereview.chromium.org/1063723002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1063713002
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/1062703002
|
|
|
|
|
|
|
|
|
| |
The file is expected to contain a list of strings. If the hash for
any result is in this file, don't write an image for it.
BUG=skia:3521
Review URL: https://codereview.chromium.org/1059363002
|