aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Update MaliT764 ChromebooksGravatar Kevin Lubick2018-05-01
| | | | | | | | Bug: skia: NOTRY=true Change-Id: I739e3596e1266df6c533f552b5583de2a5f5f9f5 Reviewed-on: https://skia-review.googlesource.com/124808 Reviewed-by: Eric Boren <borenet@google.com>
* Alter the decimation portion of Ganesh's GaussianBlur methodGravatar Robert Phillips2018-05-01
| | | | | | | | | This CL doesn't change any GMs for me locally but (because of the backingFit and clipRect changes) it has the possibility of doing so. Change-Id: Iaa1ad9baf420624d118bf1b12d8bac726218274d Reviewed-on: https://skia-review.googlesource.com/124283 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* [skottie] Power-reduce paths (cubicTo -> lineTo)Gravatar Florin Malita2018-05-01
| | | | | | | | | | | | | | | | | For straight lines, Lottie exports control points conincident with the vertices. We can detect this case and emit more efficient lineTo's. One wrinkle: we can only apply this power-reduction post-interpolation (otherwise the path verbs and point count would not be guaranteed to match). Hence we store explicit shape data and defer the SkPath conversion. TBR= Change-Id: I7818be464eabee6096d2078440843243a55c6e98 Reviewed-on: https://skia-review.googlesource.com/124800 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-30
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/e86fe982e811360b8e9dcb3688c543efd153fff4 bot_update: Set user.{name,email} when applying patch refs. (ehmaldonado@chromium.org) https://crrev.com/43d72759fed16f6666fa08efb54400ff7887fd9e Revert "bot_update: Set user.{name,email} when applying patch refs." (martiniss@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibb4e9d0204158c1203fc8f447342e047e3de6203 Reviewed-on: https://skia-review.googlesource.com/124764 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2/ b90779ebf..ddd772455 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/b90779ebf018..ddd772455ce7 $ git log b90779ebf..ddd772455 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 courtneygo Add GLESv1_CM to angle library apk 2018-04-27 jmadill Use time tolerance in run_code_generation check. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=brianosman@google.com Change-Id: I6606337d16d6512af4a5c3d9518ecc8e05cd7816 Reviewed-on: https://skia-review.googlesource.com/124780 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* ccpr: Avoid inline array definitionsGravatar Chris Dalton2018-04-30
| | | | | | | | | | | | MoltenVK currently has an issue translating these to MSL: https://github.com/KhronosGroup/SPIRV-Cross/issues/558 Bug: skia: Change-Id: Id210780672f8ec3920f8087bd60a9108e8fb0256 Reviewed-on: https://skia-review.googlesource.com/124525 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Roll skia/third_party/skcms 42c2748..8cf2d2c (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-30
| | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/42c2748..8cf2d2c 2018-04-30 brianosman@google.com EnsureUsableAsDestination: Don't inherit the polynomial TF from fallback The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=brianosman@google.com Change-Id: I066d44b73109cabe18936393a3935a1e869107f5 Reviewed-on: https://skia-review.googlesource.com/124683 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-30
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/c6e57bb748380489c67d7f680627f09734c01845 bot_update: really check whether repo is pinned at an actual sha1 revision. (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4a76dfee0a1bb17be954dd3e075747c6544ae7df Reviewed-on: https://skia-review.googlesource.com/124642 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* [infra] Use new GS bucket for assetsGravatar Eric Boren2018-04-30
| | | | | | | | Bug: skia: Change-Id: I9e75a703c7063e8a74b7469507f87b44a52c07b3 Reviewed-on: https://skia-review.googlesource.com/124641 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Move TestForPreservingPMConversions memset to FP fileGravatar Brian Osman2018-04-30
| | | | | | | | | | | Fixes CheckGeneratedFiles error introduced by: https://skia-review.googlesource.com/c/skia/+/124350 Change-Id: I2e1314c6fa9e6a938a0c26ae49aa5b9121a7229f Reviewed-on: https://skia-review.googlesource.com/124640 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Remove GrPrimitiveType::kTriangleFanGravatar Brian Salomon2018-04-30
| | | | | | | Change-Id: Ia121198ebcdc34e32a3ff99b0821047256df282d Reviewed-on: https://skia-review.googlesource.com/124503 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll skia/third_party/skcms 03457e1..42c2748 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-30
| | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/03457e1..42c2748 2018-04-30 mtklein@chromium.org handle L==N-1 special case in PolyTF fit The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=brianosman@google.com Change-Id: Ie06b99b89bd8f1ac24efe9c6149450f4f9942009 Reviewed-on: https://skia-review.googlesource.com/124528 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Use skcms equality to detect sRGB profilesGravatar Brian Osman2018-04-30
| | | | | | | | | | | This ensures that table-based sRGB profiles convert to Skia's sRGB color space. Previously, they would turn into complex XYZ SkColorSpaces. Change-Id: Idda71970c6545b50d8ac8ff52872ed44e20aee39 Reviewed-on: https://skia-review.googlesource.com/124502 Auto-Submit: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com>
* Check that Android is not looking up fontsGravatar Herb Derby2018-04-30
| | | | | | | | Change-Id: I86529296dc1229a1c9864dd12886d52d7db3aae2 Reviewed-on: https://skia-review.googlesource.com/124580 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* memset arrays in TestForPreservingPMConversions in case of read pixels failureGravatar Brian Salomon2018-04-30
| | | | | | | | Bug: chromium:837649 Change-Id: Iced3cef5af8745964323ef3fa8cc5ac9d184c3b4 Reviewed-on: https://skia-review.googlesource.com/124350 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll skia/third_party/skcms dd901e0..03457e1 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-30
| | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/dd901e0..03457e1 2018-04-30 mtklein@chromium.org also fuzz optimized profile The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=brianosman@google.com Change-Id: I74e13c7e3c73b09815aaa72be3499ea8b2c0eb60 Reviewed-on: https://skia-review.googlesource.com/124521 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* skpbench: Add support for Pixel 2Gravatar Chris Dalton2018-04-30
| | | | | | | | Bug: skia: Change-Id: Ic0901ca84bf8e3fda29b3bd7a0504396445ca0f4 Reviewed-on: https://skia-review.googlesource.com/124282 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* [skottie] Show load stats in SkottieSlideGravatar Florin Malita2018-04-30
| | | | | | | | TBR= Change-Id: Ie3a1036d9a90cb16d2795134c453759aeff06e3c Reviewed-on: https://skia-review.googlesource.com/124461 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll third_party/externals/angle2/ bb3255b5a..b90779ebf (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/bb3255b5a507..b90779ebf018 $ git log bb3255b5a..b90779ebf --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jmadill Vulkan: Pass fewer Context pointers around. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=brianosman@google.com Change-Id: I529a4cd2072799d9413e4281dd95b5ce5d6240b3 Reviewed-on: https://skia-review.googlesource.com/124422 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [infra] Calmbench: fix path to nanobench executableGravatar Eric Boren2018-04-30
| | | | | | | | | | Bug: skia:7883 Change-Id: Id363d59d2466c3f4fae8a79e6ad9e6c270e445ae Reviewed-on: https://skia-review.googlesource.com/124403 Commit-Queue: Eric Boren <borenet@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com> Auto-Submit: Eric Boren <borenet@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* Add test to ensure that skcms' sRGB turns into Skia's sRGB color spaceGravatar Brian Osman2018-04-30
| | | | | | | | Change-Id: Ib69926218895f9c3df8d02906188f5e54d134fad Reviewed-on: https://skia-review.googlesource.com/124265 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Raise exceptions from child threads to the main threadGravatar Yuqian Li2018-04-30
| | | | | | | | | Bug: skia:7883 Change-Id: Ia71550b94867588c124e93eac347c67e35aa48e8 Reviewed-on: https://skia-review.googlesource.com/124380 Auto-Submit: Yuqian Li <liyuqian@google.com> Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Update SKP versionGravatar skia-recreate-skps2018-04-29
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: Icceb22e4d0f70ab18b0648eaa73dafe14cb49702 Reviewed-on: https://skia-review.googlesource.com/124376 Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com> Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
* Rewrite SkVertices specified with triangle fans as indexed trianglesGravatar Brian Salomon2018-04-28
| | | | | | | Change-Id: Ifaacc426bc657b324f6a885a8ef70b347b048226 Reviewed-on: https://skia-review.googlesource.com/124349 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* Call SkMatrix::getType to make it thread safeGravatar Yuqian Li2018-04-28
| | | | | | | | | TBR: reed@google.com, mtklein@google.com Bug: skia: Change-Id: I6da4b12b38ecaba71441de7a45a1990b000b1de4 Reviewed-on: https://skia-review.googlesource.com/124402 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Copy SkBitmap to make it thread safeGravatar Yuqian Li2018-04-28
| | | | | | | | | | TBR: reed@google.com, mtklein@google.com Bug: skia: Change-Id: I9aa1ac8bc5387c5a86301c242e12b3448b332d26 Reviewed-on: https://skia-review.googlesource.com/124400 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Roll third_party/externals/angle2/ de279590a..bb3255b5a (5 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/de279590a007..bb3255b5a507 $ git log de279590a..bb3255b5a --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jiawei.shao Remove redundant computations on combined interface block counts 2018-04-24 jiawei.shao ES31: Add REFERENCED_BY_GEOMETRY_SHADER as program interface property 2018-04-27 geofflang D3D11: Reorder VAO synchronization. 2018-04-24 geofflang D3D: Don't test for device loss as frequenty in tight loops. 2018-04-27 geofflang Supress failures in BlitFramebufferTest.MultisampleDepth on Mac OpenGL Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: I4204098ade4f43a4ef7753ea394f62058e455d7c Reviewed-on: https://skia-review.googlesource.com/124370 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Just pass color glyph masks to filters.Gravatar Ben Wagner2018-04-27
| | | | | | | | | | | | | | | Allow the filters to try to apply themselves to the color mask. Most mask filters will just return false, but allow them the opprotunity. This removes the behavior of trying to create a mask from the color mask. This updates the blur mask filter to handle kARGB32_Format directly by using just the alpha (which mirrors current behavior). Change-Id: I15eb736060ecf9b24aca874758c167b74d9ebc22 Reviewed-on: https://skia-review.googlesource.com/124185 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-27
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c17eef1bc11c5f44462101e8ceaa0f76c9e872bf file: method for creating temporary files (phosek@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie6864985ab23d8e5f70f550c7216531990abbcc3 Reviewed-on: https://skia-review.googlesource.com/124346 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* ccpr: Remove canMakeClipProcessorGravatar Chris Dalton2018-04-27
| | | | | | | | | | | | Now that conics are supported we can make a ccpr clip FP out of any path. No need to ask. And the 'fDrawCachablePaths' check was redundant since clip paths are always volatile anyway (for now). Bug: skia: Change-Id: I670474a3b91f1c252ed323eb627bbb109788e6b8 Reviewed-on: https://skia-review.googlesource.com/124362 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Reland "Reland "Reland "Exercise the threaded backend in test bots"""Gravatar Yuqian Li2018-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 47f2b7b089c688503b12caff9c8a84fb185d01c5. Reason for revert: try to fix the issue by reducing the set of bots Original change's description: > Revert "Reland "Reland "Exercise the threaded backend in test bots""" > > This reverts commit 7ddad479e464a3d481d106415c9c1b8cc8496848. > > Reason for revert: bots failure > > Original change's description: > > Reland "Reland "Exercise the threaded backend in test bots"" > > > > This reverts commit 0f5972604ce4439fd33118d6be1e4f24fe6c267f. > > > > Reason for revert: ASAN/MSAN should have been fixed > > > > Original change's description: > > > Revert "Reland "Exercise the threaded backend in test bots"" > > > > > > This reverts commit 654ca8a340700ca8089abb7828adc2c229c6241e. > > > > > > Reason for revert: ASAN,MSAN failures > > > > > > Original change's description: > > > > Reland "Exercise the threaded backend in test bots" > > > > > > > > This reverts commit ea51393ba918f75c1b40d521081789eeb3b42d6f. > > > > > > > > Reason for revert: try again after many fixes of the threaded backend > > > > > > > > Original change's description: > > > > > Revert "Exercise the threaded backend in test bots" > > > > > > > > > > This reverts commit a39991ebd70f4aaf1290dd516467d729811e45ee. > > > > > > > > > > Reason for revert: Random bots timeout > > > > > > > > > > Original change's description: > > > > > > Exercise the threaded backend in test bots > > > > > > > > > > > > We can't draw everything correctly now, but it's at least not crashing. > > > > > > > > > > > > The draw_to_canvas is modified by adding flush because now the raster > > > > > > canvas also needs flush like GPU canvases because of the threaded > > > > > > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink > > > > > > and that's why it was not crashing.) > > > > > > > > > > > > > > > > > > Bug: skia: > > > > > > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd > > > > > > Reviewed-on: https://skia-review.googlesource.com/118886 > > > > > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > > > > > > > Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: skia: > > > > > Reviewed-on: https://skia-review.googlesource.com/119100 > > > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: skia:7838 > > > > Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f > > > > Reviewed-on: https://skia-review.googlesource.com/121680 > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > > > Change-Id: Id1b273e22a1d0cbc15a2155252909f576b401fa4 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: skia:7838 > > > Reviewed-on: https://skia-review.googlesource.com/123360 > > > Reviewed-by: Mike Klein <mtklein@google.com> > > > Commit-Queue: Mike Klein <mtklein@google.com> > > > > TBR=mtklein@google.com,kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: skia:7838 > > Change-Id: I205d579f2959ea726b447993314c1326b731730e > > Reviewed-on: https://skia-review.googlesource.com/123660 > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > TBR=mtklein@google.com,kjlubick@google.com,stephana@google.com,liyuqian@google.com > > Change-Id: I1d3986cc2af12836dd7acbcbba713081a88301a6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7838 > Reviewed-on: https://skia-review.googlesource.com/124200 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=mtklein@google.com,kjlubick@google.com,stephana@google.com,liyuqian@google.com Change-Id: I2d4d0c172849a86b37c60b32938a7a2b828258fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7838 Reviewed-on: https://skia-review.googlesource.com/124201 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-27
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/179dd1e01695137c08ac1ccc49e3b909bb5f75e0 input_api.DEFAULT_BLACK_LIST should not block third_party/blink. (tkent@chromium.org) recipe_engine: https://crrev.com/8bb8a8eddc83b7110083f1fef2aaafaf7bd25d90 Handle long paths on Windows part 2 (martiniss@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id21781592e46ea2e1d1e286527344b2531cc16b8 Reviewed-on: https://skia-review.googlesource.com/124342 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Add ASYNC trace macrosGravatar Brian Osman2018-04-27
| | | | | | | | | These allow markers over long (non-nested, non-scoped) blocks of time. Change-Id: I2ebd724e644232f1b911121d25a37dcee193a15d Reviewed-on: https://skia-review.googlesource.com/124320 Reviewed-by: Xiao Yu <xster@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Reland "[recipes] Use named caches for git and workdirs"Gravatar Eric Boren2018-04-27
| | | | | | | | | | This reverts commit 01d3eb64e7b11b22cf206758f01b06a7ae0bbb20. Bug: skia: Change-Id: Ic05b89009eb59a231488bef382dd232a50d2b00f Reviewed-on: https://skia-review.googlesource.com/124260 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* use std::atomic in SkRegionPrivGravatar Mike Reed2018-04-27
| | | | | | | | Bug: skia:7882 Change-Id: I333f3457fbcd9621d712c40844f4896bd85a9a1c Reviewed-on: https://skia-review.googlesource.com/124266 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll third_party/externals/angle2/ 467c15f97..de279590a (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/467c15f970b9..de279590a007 $ git log 467c15f97..de279590a --date=short --no-merges --format='%ad %ae %s' 2018-04-26 oetuaho Add test coverage for BlitGL Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: I3271c1acad68cb213747ded6d059258b0454ab03 Reviewed-on: https://skia-review.googlesource.com/124286 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/skcms 5a327ce..dd901e0 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-27
| | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/5a327ce..dd901e0 2018-04-27 mtklein@chromium.org simplify Gauss-Newton interface The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stani@google.com Change-Id: Ie1fd5feba47cddeba47c71dfff2dc4dae1fe12ef Reviewed-on: https://skia-review.googlesource.com/124285 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* workaround for Intel OpCompositeConstruct bugGravatar Ethan Nicholas2018-04-27
| | | | | | | | | | | | | | | | The SPIR-V spec permits constructing a vector from mixed vectors and scalars, e.g. vec3(vec2, float). Intel's Vulkan driver does not handle this correctly. We already have a workaround in place for vector construction (writing the code as vec3(vec2.x, vec2.y, float) instead), but missed that matrix construction can produce the same problem, as each column requires a vector to be constructed for it. This CL extends the workaround to handle matrix construction as well. Bug: skia:7851 Change-Id: I0fe5d300ec7ad5db87bcc6662cf8371bcd6deed8 Reviewed-on: https://skia-review.googlesource.com/124321 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* [skottie] Apply opaque masks as clipsGravatar Florin Malita2018-04-27
| | | | | | | | | | | When the mask stack contains exactly one opaque mask path, we can apply as a clip. TBR= Change-Id: Iadff7534bfa4925557bfbddd59529113f4958d0d Reviewed-on: https://skia-review.googlesource.com/124000 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Revert "Remove Android compile bot from the CQ"Gravatar Ravi Mistry2018-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e033e969ca9335fe5ca8803ca9843fdd995e6419. Reason for revert: Should be fast now Original change's description: > Remove Android compile bot from the CQ > > NoTry: True > Bug: skia:7834 > Change-Id: Ia38a800da098101effb6804118ccf4b0a0a93c72 > Reviewed-on: https://skia-review.googlesource.com/122945 > Commit-Queue: Ravi Mistry <rmistry@google.com> > Auto-Submit: Ravi Mistry <rmistry@google.com> > Reviewed-by: Eric Boren <borenet@google.com> TBR=borenet@google.com,rmistry@google.com # Not skipping CQ checks because original CL landed > 1 day ago. NoTry: true Bug: skia:7815 Change-Id: I55bba2de4bbff904b92b99802f13c9de55bc9191 Reviewed-on: https://skia-review.googlesource.com/124300 Auto-Submit: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* [infra] Specify machine_type dimension for Linux GCE bots.Gravatar Ben Wagner2018-04-27
| | | | | | | | | | | | This is in preparation of assigning bots either "small" or "large" GCE machines. Bug: skia:7415, skia:7416 Change-Id: I82b6fe454ba3622ef8a9d515dc3e72362dd30ee5 Reviewed-on: https://skia-review.googlesource.com/124183 Commit-Queue: Eric Boren <borenet@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Roll third_party/externals/angle2/ 1633663b3..467c15f97 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/1633663b351c..467c15f970b9 $ git log 1633663b3..467c15f97 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 jiawei.shao Use ShaderMap in ProgramD3D - Part II 2018-04-17 jmadill Optimize ValidateDrawAttribs: Part 3. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: I18d6325649025c0feec3b87a336076743b5e4b9e Reviewed-on: https://skia-review.googlesource.com/124220 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Blacklist filltypespersp on IntelHD405 vulkanGravatar Chris Dalton2018-04-27
| | | | | | | | Bug: skia: Change-Id: Ie5840216ed0f34cf55bac9d720a2f78069022eb3 Reviewed-on: https://skia-review.googlesource.com/123916 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-26
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/97ce05851cb5559459058706a69e81ddaed54f1e gclient_scm: Try to rebase after printing what was wrong. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id9b641b97bdf3693ec4d47e2495af038c41c728c Reviewed-on: https://skia-review.googlesource.com/124184 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "[recipes] Use named caches for git and workdirs"Gravatar Ben Wagner2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e8615f969e92009551b70c85d1913202390e0b0d. Reason for revert: Causing CommandBuffer builds to time out Original change's description: > [recipes] Use named caches for git and workdirs > > Bug: skia: > Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c > Reviewed-on: https://skia-review.googlesource.com/123929 > Commit-Queue: Eric Boren <borenet@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> ---------------- Revert "[infra] Fix missing cache for Bookmaker" This reverts commit d19f039a16cc4ed29dc6f0ef7100125819ca291d. Reason for revert: Need to revert https://skia-review.googlesource.com/123929 Original change's description: > [infra] Fix missing cache for Bookmaker > > Bug: skia: > Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3 > Reviewed-on: https://skia-review.googlesource.com/124052 > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Commit-Queue: Eric Boren <borenet@google.com> ---------------- Revert "Fix missing/duplicate named caches" This reverts commit 0820a6fb697be598b41b65c7645659e216b30bc5. Reason for revert: Need to revert https://skia-review.googlesource.com/123929 Original change's description: > Fix missing/duplicate named caches > > Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929 > > No-Try: true > Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c > Reviewed-on: https://skia-review.googlesource.com/124180 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Auto-Submit: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> ---------------- TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com Change-Id: Id8443ad9dc50f018251a6b6892b06fe256e6c578 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/124203 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Roll third_party/externals/swiftshader/ 840f47ea8..ce8eb945c (1 commit)Gravatar swiftshader-skia-autoroll2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/840f47ea853b..ce8eb945ca82 $ git log 840f47ea8..ce8eb945c --date=short --no-merges --format='%ad %ae %s' 2018-04-26 capn Accept GL_HALF_FLOAT and GL_HALF_FLOAT_OES interchangeably. Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=stani@google.com Change-Id: I477bcccf0b4a88fa206b004d95ee4d30370cbcd4 Reviewed-on: https://skia-review.googlesource.com/124146 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add InternalSurfaceFlag so we know if RenderTargetProxys and RenderTargets ↵Gravatar Greg Daniel2018-04-26
| | | | | | | | | | use GL FBO 0. Bug: skia:7748 Change-Id: I2fda3cde12ccdef19fe06ff287a8024b58d28ef0 Reviewed-on: https://skia-review.googlesource.com/124048 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll third_party/externals/angle2/ 0086de179..1633663b3 (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0086de17943b..1633663b351c $ git log 0086de179..1633663b3 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 geofflang Don't test for device loss in SwapBuffers and MakeCurrent. 2018-04-26 courtneygo Cleanup for "Add angle library apk" 2018-04-26 jmadill Vulkan: Fix TexSubImage2D state change test. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: I5d6347e1b6d495df64ff518e99d8a29b4e844acb Reviewed-on: https://skia-review.googlesource.com/124140 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "Reland "Reland "Exercise the threaded backend in test bots"""Gravatar Yuqian Li2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7ddad479e464a3d481d106415c9c1b8cc8496848. Reason for revert: bots failure Original change's description: > Reland "Reland "Exercise the threaded backend in test bots"" > > This reverts commit 0f5972604ce4439fd33118d6be1e4f24fe6c267f. > > Reason for revert: ASAN/MSAN should have been fixed > > Original change's description: > > Revert "Reland "Exercise the threaded backend in test bots"" > > > > This reverts commit 654ca8a340700ca8089abb7828adc2c229c6241e. > > > > Reason for revert: ASAN,MSAN failures > > > > Original change's description: > > > Reland "Exercise the threaded backend in test bots" > > > > > > This reverts commit ea51393ba918f75c1b40d521081789eeb3b42d6f. > > > > > > Reason for revert: try again after many fixes of the threaded backend > > > > > > Original change's description: > > > > Revert "Exercise the threaded backend in test bots" > > > > > > > > This reverts commit a39991ebd70f4aaf1290dd516467d729811e45ee. > > > > > > > > Reason for revert: Random bots timeout > > > > > > > > Original change's description: > > > > > Exercise the threaded backend in test bots > > > > > > > > > > We can't draw everything correctly now, but it's at least not crashing. > > > > > > > > > > The draw_to_canvas is modified by adding flush because now the raster > > > > > canvas also needs flush like GPU canvases because of the threaded > > > > > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink > > > > > and that's why it was not crashing.) > > > > > > > > > > > > > > > Bug: skia: > > > > > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd > > > > > Reviewed-on: https://skia-review.googlesource.com/118886 > > > > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > > > > > Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: skia: > > > > Reviewed-on: https://skia-review.googlesource.com/119100 > > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: skia:7838 > > > Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f > > > Reviewed-on: https://skia-review.googlesource.com/121680 > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > Change-Id: Id1b273e22a1d0cbc15a2155252909f576b401fa4 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia:7838 > > Reviewed-on: https://skia-review.googlesource.com/123360 > > Reviewed-by: Mike Klein <mtklein@google.com> > > Commit-Queue: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,kjlubick@google.com,stephana@google.com,liyuqian@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: skia:7838 > Change-Id: I205d579f2959ea726b447993314c1326b731730e > Reviewed-on: https://skia-review.googlesource.com/123660 > Commit-Queue: Yuqian Li <liyuqian@google.com> > Reviewed-by: Yuqian Li <liyuqian@google.com> TBR=mtklein@google.com,kjlubick@google.com,stephana@google.com,liyuqian@google.com Change-Id: I1d3986cc2af12836dd7acbcbba713081a88301a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7838 Reviewed-on: https://skia-review.googlesource.com/124200 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Fix missing/duplicate named cachesGravatar Ben Wagner2018-04-26
| | | | | | | | | | | Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929 No-Try: true Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c Reviewed-on: https://skia-review.googlesource.com/124180 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>