aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Update the alias mapping for Noto Sans CJK.Gravatar jshin2014-09-09
| | | | | | | | | | | | | | | | | | | To make the family names 'future-proof', we decided to shorten the name of Noto Sans CJK, which requires a change in the alias table in Skia. Chrome OS CL (actually updating the fonts) and Chrome CL (updating the font preferences on CrOS) are going together with this CL. BUG=412151 TEST=With the above two CLs in on Chrome OS, Noto Sans CJK {JP, SC} are used when MS P Gothic / Simhei are asked for by a web page. R=bungeman@google.com Author: jshin@chromium.org Review URL: https://codereview.chromium.org/554943002
* Allow SkCanvas to be initialized to force conservative rasterclips. This has ↵Gravatar reed2014-09-09
| | | | | | | | | | | | | | | | | | the following effects: 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. 2. The conservative clips mean less work is done. 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. 4. API is private for now. R=robertphillips@google.com, bsalomon@google.com, mtklein@google.com, junov@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/541593005
* Make -d x86 have the default GPU cache size.Gravatar mtklein2014-09-09
| | | | | | | | | | | We have no a priori reason to limit the cache for new devices. BUG=skia: R=djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/556863006
* Outset the stroke width when computing the bounds for drawing a stroked ↵Gravatar george2014-09-09
| | | | | | | | | | | | | rect, or 1 if it's a hairline Adds a testcase for stroke rect bug R=reed@google.com, reed1 BUG=skia: Author: george@mozilla.com Review URL: https://codereview.chromium.org/552743004
* Allow negative values in SkBlurImageFilter sigma.Gravatar senorblanco2014-09-09
| | | | | | | | | | | | | | | | | | | | | There are two ways negative sigma values may occur: in the original filter parameters, or after multiplication by a negative scaling CTM. The former case is invalid according to the spec, so we continue to check for it at validation time. In the latter case, we should interpret it as a horizontal flip in the kernel pixel access, and simply take the absolute value (since the filter kernel is symmetric). Also refactor all this logic into a single place for the CPU, GPU and onFilterBounds() paths. BUG=https://code.google.com/p/chromium/issues/detail?id=409602 R=sugoi@google.com, reed@google.com, sugoi@chromium.org Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/555603002
* Back to hashing source content, not .png.Gravatar mtklein2014-09-09
| | | | | | | | | BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/560453002
* Revert of Use SkBitmapCache to optimize readPixels on a texture-backed ↵Gravatar fmalita2014-09-09
| | | | | | | | | | | | | | | | | | | | | | | | | | bitmap (patchset #6 id:100001 of https://codereview.chromium.org/533323002/) Reason for revert: Component inversions in Blink's printing/webgl-repeated-printing.html: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/24033/layout-test-results/printing/webgl-repeated-printing-diff.txt Reverting to unblock rolls. Original issue's description: > Use SkBitmapCache to optimize readPixels on a texture-backed bitmap > > BUG=skia:2786 > > Committed: https://skia.googlesource.com/skia/+/95fd68e5ccd242a91e6dd827dd695f18661efbe6 R=junov@chromium.org, reed@google.com, bsalomon@google.com, piotaixr@chromium.org TBR=bsalomon@google.com, junov@chromium.org, piotaixr@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2786 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/551523003
* Adding texture uploads without cache for YUV and ETC1Gravatar sugoi2014-09-09
| | | | | | | | | BUG=skia: R=bsalomon@google.com, robertphillips@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/552843004
* Update DM JSON format.Gravatar mtklein2014-09-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ex. dm --match patch -w bad --key arch x86 gpu nvidia model z620 --properties git_hash abcd build_number 20 -> { "build_number" : "20", "git_hash" : "abcd", "key" : { "arch" : "x86", "gpu" : "nvidia", "model" : "z620" }, "results" : [ { "key" : { "config" : "565", "name" : "ninepatch-stretch" }, "md5" : "f78cfafcbabaf815f3dfcf61fb59acc7", "options" : { "source_type" : "GM" } }, { "key" : { "config" : "8888", "name" : "ninepatch-stretch" }, "md5" : "3e8a42f35a1e76f00caa191e6310d789", "options" : { "source_type" : "GM" } }, ... This breaks -r, but that's okay. Going to follow up this CL with one that removes that entirely. BUG=skia: R=stephana@google.com, jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/551873003
* Remove expectations / -r from DM entirely.Gravatar mtklein2014-09-09
| | | | | | | | | | | | It's getting tricky to coordinate changes to output for bots with -r, and -r is not widely used. The suggested alternative is to run skdiff. BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/553583004
* SkRasterClip::quickReject doesn't need to check for emptiness as ↵Gravatar george2014-09-09
| | | | | | | | | | | SkIRect::Intersect already does that for us R=reed@google.com, reed1 BUG=skia: Author: george@mozilla.com Review URL: https://codereview.chromium.org/554743007
* Update SKP version to 96Gravatar borenet2014-09-08
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/551263002
* Remove a linear search in SkPictureRecord::addTextBlob.Gravatar jbroman2014-09-08
| | | | | | | | | | | | | It doesn't seem that harmful to have repeated text blobs in the array if they occur within the same picture recording. And that does not seem to be a common occurrence right now anyhow. BUG=skia:2919 R=fmalita@chromium.org, reed@google.com, mtklein@google.com Author: jbroman@chromium.org Review URL: https://codereview.chromium.org/550043003
* Hash .pngs instead of SkBitmaps.Gravatar mtklein2014-09-08
| | | | | | | | | | | | | | | | | | | | | | | This has the nice property of being able to double-check hashes after the fact. mtklein@mtklein ~/skia (hash-png)> md5sum bad/8888/3x3bitmaprect.png deede70ab2f34067d461fb4a93332d4c bad/8888/3x3bitmaprect.png mtklein@mtklein ~/skia (hash-png)> grep 3x3bitmaprect_8888 bad/dm.json "3x3bitmaprect_8888" : "deede70ab2f34067d461fb4a93332d4c", I have checked that no two premultiplied colors map to the same unpremultiplied color (math nerds: unpremultiplication is injective), so a change in premultiplied SkBitmap will always imply a change in the encoded unpremultiplied .png. This means, it's safe to hash .pngs; we won't miss subtle changes. BUG=skia: R=jcgregorio@google.com, stephana@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/549203003
* Make GrEffectStage copy constructor work correctly with pending execution refs.Gravatar bsalomon2014-09-08
| | | | | | | | R=egdaniel@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/551083002
* Fix two SkRecord-backed layer hoisting bugsGravatar robertphillips2014-09-08
| | | | | | | | | | | | | | | The two bugs are/were: The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change). The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change). Committed: https://skia.googlesource.com/skia/+/7c0cfd4ff8f6db50a8731c886db732b106268937 R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/551843002
* Add --nameByHash for the bots, and refactor hashing a bit.Gravatar mtklein2014-09-08
| | | | | | | | | | | | | | | | | | | | | No diff in dm.json output. Here's what we get when --nameByHash is on: mtklein@mtklein ~/skia (dm)> ls bad4/ 0077fefedcee39feae9d12751853758b.png 431921de1607b4e1ae6864cc684d9b8e.png 8a3e17eba9302498700a703bb286d1ef.png c6448cb266f5e0b8d02b512ad484a9ad.png 01b0dcd515e846ea3b7f3b4c68120943.png 4372eb0fce0b0bcf5a582c502f90ecef.png 8a6acdd96cf6915fa01a9cea6d6291b0.png c6db4e2c9860b900130af429373eafaa.png 02974ab0efa7aa325b3bf22515b33899.png 43bddc2e255a3501ce2728544b1d409d.png 8aa8763d11afd397c2768e54d5599181.png c716a9a53513a16e0572c67863e3be08.png 02b7b9e5e95e69f89b6cec9c4539d972.png 43cf7adda66b3719e4abd19e92dda55e.png 8ade6bb4c9e2244e0dbd9436cf6e2132.png c854bb6dd105644a71d0219025409039.png 02d29dbfd29260f9318fcd6177c6ba7b.png 4423958139a2b64185583dacb7379b13.png 8b039171593685112a9454879f40a965.png c863ac2394e519690c57e1392b14b19f.png ... BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/550283002
* Remove extra proctected in GrRODrawState.hGravatar egdaniel2014-09-08
| | | | | | | | | BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/550243002
* Remove debug-only ref of GrEffectStageGravatar bsalomon2014-09-08
| | | | | | | | | BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/553973002
* fail when coincidence is too far apartGravatar caryclark2014-09-08
| | | | | | | | | TBR= BUG=410552 Author: caryclark@google.com Review URL: https://codereview.chromium.org/556433002
* Revert of Fix two SkRecord-backed layer hoisting bugs (patchset #1 id:1 of ↵Gravatar robertphillips2014-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/551843002/) Reason for revert: turning bots red Original issue's description: > Fix two SkRecord-backed layer hoisting bugs > > The two bugs are/were: > The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change). > > The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change). > > Committed: https://skia.googlesource.com/skia/+/7c0cfd4ff8f6db50a8731c886db732b106268937 R=bsalomon@google.com TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/553983003
* Fix two SkRecord-backed layer hoisting bugsGravatar robertphillips2014-09-08
| | | | | | | | | | | | | The two bugs are/were: The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change). The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change). R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/551843002
* Let .skps have Expectations (i.e. work with -r) too.Gravatar mtklein2014-09-08
| | | | | | | | | BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/549183002
* Turn on the save-layer optimization.Gravatar mtklein2014-09-08
| | | | | | | | | BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/551853002
* Use SkBitmapCache to optimize readPixels on a texture-backed bitmapGravatar piotaixr2014-09-08
| | | | | | | | | BUG=skia:2786 R=junov@chromium.org, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/533323002
* Start to rework DM JSON handling.Gravatar mtklein2014-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | DM's striking off into its own JSON world. This gets strawman implementations in place for writing and reading a JSON file mapping test name to hashes. For what it's worth, I basically want to change _all_ these pieces, - MD5 is slow and we can replace it with something faster, - JSON schema needs room to grow more data, - it'd be nice to hash once instead of twice when reading and writing, - this code wants lots of refactoring, but this gives us a starting platform to work on these bits at our leisure. E.x. file for now: mtklein@mtklein ~/skia (dm)> cat good/dm.json { "3x3bitmaprect_565" : "fc70d985fbfbe70e3a3c9dc626d4f5bc", "3x3bitmaprect_8888" : "df1591dde35907399734ea19feb76663", "3x3bitmaprect_gpu" : "df1591dde35907399734ea19feb76663", "aaclip_565" : "1862798689b838a7ab0dc0652b9ace3a", "aaclip_8888" : "47bb314329f0ce243f1d83fd583decb7", "aaclip_gpu" : "75f72412d0ef4815770202d297246e7d", ... BUG=skia: R=jcgregorio@google.com, stephana@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/546873002
* Turn on all pixel-perfect SkRecord optimizations.Gravatar mtklein2014-09-08
| | | | | | | | | BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/550083006
* Update SKP version to 95Gravatar borenet2014-09-07
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/552663002
* Update SKP version to 94Gravatar borenet2014-09-06
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/541173005
* Update SKP version to 93Gravatar borenet2014-09-05
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/543343002
* move rasterclip_ helper into rasterclipGravatar reed2014-09-05
| | | | | | | | R=robertphillips@google.com, reed@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/546113002
* Make GrDrawState and GrEffectStage use the pending io/exec ref mechanisms.Gravatar bsalomon2014-09-05
| | | | | | | | | BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/542723004
* Refactored frontend for the rebaseline server.Gravatar stephana2014-09-05
| | | | | | | | | | | | This is going to serve as the starting point for the new front-end once the backend is rewritten. BUG=skia: NOTRY=true R=jcgregorio@google.com Author: stephana@google.com Review URL: https://codereview.chromium.org/538613002
* "NULL !=" = NULLGravatar bsalomon2014-09-05
| | | | | | | | R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/544233002
* For certain input skpdiff segfaulted. This prevents the segfault and should ↵Gravatar stephana2014-09-05
| | | | | | | | | | | fix the failed test in housekeeping. BUG=skia:2902 R=mtklein@google.com, rmistry@google.com Author: stephana@google.com Review URL: https://codereview.chromium.org/546753003
* Don't take a ref on GP in AutoEffectRestore.Gravatar bsalomon2014-09-05
| | | | | | | | | BUG=skia:2889 R=joshualitt@chromium.org, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/546043002
* Small fix for RODrawStateGravatar joshualitt2014-09-05
| | | | | | | | | BUG=skia: R=egdaniel@google.com, joshualitt@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/545273002
* Suppress mystery leak.Gravatar mtklein2014-09-05
| | | | | | | | | BUG=skia:2916 R=caryclark@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/543063002
* Change behavior of GrDS::AutoEffectRestort wrt GPs.Gravatar bsalomon2014-09-05
| | | | | | | | | BUG=skia:2889 R=robertphillips@google.com, joshualitt@chromium.org Author: bsalomon@google.com Review URL: https://codereview.chromium.org/545253002
* Add pop_back() to GrAllocator and add unit test.Gravatar bsalomon2014-09-05
| | | | | | | | | BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/538183002
* Update SKP version to 92Gravatar borenet2014-09-04
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/546583003
* Add method to GrProgramResource to record that pending a execution was ↵Gravatar bsalomon2014-09-04
| | | | | | | | | | | completed. BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/543833002
* Implement all SkCanvas overrides that SkPictureRecord does.Gravatar mtklein2014-09-04
| | | | | | | | | | | | Primarily this is for isDrawingToLayer(). drawData() and onNewSurface() are for completeness. BUG=409138 R=robertphillips@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/545613002
* Updating expectationsGravatar joshualitt2014-09-04
| | | | | | | | | TBR= BUG=skia: Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/543813003
* don't use local static bitmap -- racy and unnecessaryGravatar reed2014-09-04
| | | | | | | | | BUG=skia: R=mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/540993003
* Add GrProgramElement base class for GrEffect with deferred exec ref.Gravatar bsalomon2014-09-04
| | | | | | | | | BUG=skia:2889 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/537773004
* add SK_API to forward declare in canvas.hGravatar reed2014-09-04
| | | | | | | | | NOTRY=True TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/541073002
* remove getTotalClipAsPath, privatize getTotalClipGravatar reed2014-09-04
| | | | | | | | | R=robertphillips@google.com, djsollen@google.com TBR=robertphilips Author: reed@google.com Review URL: https://codereview.chromium.org/546493002
* disable flaky testGravatar mtklein2014-09-04
| | | | | | | | | BUG=skia:2912 R=reed@google.com, mtklein@google.com, tfarina@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/537363003
* cleanup rasterclip helperGravatar reed2014-09-04
| | | | | | | | | R=robertphillips@google.com TBR=robertphilips Author: reed@google.com Review URL: https://codereview.chromium.org/540983002
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-27 19:32:10 +0000