aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Make GrFragmentProcessor auto-compare coord xforms.Gravatar bsalomon2014-10-15
| | | | Review URL: https://codereview.chromium.org/657923002
* Prefer to recycle non-RT scratch textures that don't have pending IOGravatar bsalomon2014-10-15
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/650283002
* Last round of effect->processor (for now)Gravatar bsalomon2014-10-15
| | | | | | R=joshualitt@google.com Review URL: https://codereview.chromium.org/659803005
* webtry: Forgot onr log.Fatal.Gravatar Thiago Farina2014-10-15
| | | | | | | | | | Update it to use glog variant. BUG=skia:2980 TEST=go build webtry.go TBR=jcgregorio@google.com Review URL: https://codereview.chromium.org/659813003
* webtry: Switch from Go's log package to golang/glog.Gravatar tfarina2014-10-15
| | | | | | | | BUG=skia:2980 TEST=go get -d && go build webtry.go R=jcgregorio@google.com Review URL: https://codereview.chromium.org/655323002
* Treat (private, internal) grid bounds as doubly-inclusive in SkTileGrid.Gravatar mtklein2014-10-15
| | | | | | | | | | | | | The net effect is that two "+1" instructions are removed from insert(). search() nets no change: two +1 removed, two +1 added. When vectorized, this removes the need to add in userToGrid() at all and so the need to read an awkward {0, 0, 1, 1} constant from memory. Mostly the benefit is less vector code to look at and think about. BUG=skia: Review URL: https://codereview.chromium.org/659823004
* Don't use 'defined' in macro expansion.Gravatar bungeman2014-10-15
| | | | | | | | | | | | | | | | | | A careful reading of the preprocessor specification indicates that any use of the 'defined' operator outside the form of 'defined X' or 'defined ( X )' directly in the constant expression of a '#if' or '#elif' may cause undefined behavior. In particular, msvc is very unpredictable. The 'defined X' and 'defined ( X )' forms behave differently when created from marco expansion, with 'defined ( X )' generally evaluating to '0L'. The 'defined X' form generally behaves more the way one would expect, but still has a number of quirks which should simply be considered undefined behavior. BUG=chromium:419245 Review URL: https://codereview.chromium.org/657183002
* Move willUseInputColor check to computeInvariantOutputGravatar egdaniel2014-10-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/656503002
* webtry: Check the result of os.Chdir().Gravatar tfarina2014-10-15
| | | | | | | | | | | | | | As mentioned in http://golang.org/doc/effective_go.html#blank_assign, errors are provided for a reason, so always check them. The documentation for this function is available at http://golang.org/pkg/os/#Chdir. BUG=None TEST=None R=jcgregorio@google.com Review URL: https://codereview.chromium.org/651343002
* Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocateGravatar cdalton2014-10-15
| | | | | | | | | | all its commands interleaved in contiguous memory. GrTRecorder also supports extra data associated with objects, so we can store arrays inline without having to call malloc(). Committed: https://skia.googlesource.com/skia/+/360b6801cfd90485891d709e44cf395d527ba69e Review URL: https://codereview.chromium.org/628453002
* Remove unused NeedsDeepCopy.Gravatar scroggo2014-10-15
| | | | | | | | | | It was used to check to see if an SkPaint had mutable fields on it. Now that all the fields are immutable, this function is no longer used. Remove it. BUG=skia:2097 Review URL: https://codereview.chromium.org/661543002
* Revert of JPEG YUV Decoding (patchset #5 id:180001 of ↵Gravatar rmistry2014-10-15
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/399683007/) Reason for revert: Caused many test bots to go red: http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/22/steps/dm/logs/stdio http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Link-HD4000-x86_64-Debug/builds/168/steps/dm/logs/stdio http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/38/steps/dm/logs/stdio Original issue's description: > JPEG YUV Decoding > > Enabling JPEG YUV Decoding in Skia > > BUG=skia:3005, skia:1674 > > Committed: https://skia.googlesource.com/skia/+/8e6c3b93a39e19111662a760ede97df55e51d39f TBR=reed@google.com,scroggo@google.com,sugoi@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3005, skia:1674 Review URL: https://codereview.chromium.org/656163002
* Whitespace change to confirm Google Storage uploads are workingGravatar rmistry2014-10-15
| | | | | | | | | BUG=skia: TBR= NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/657083004
* More effect->processor cleanupGravatar bsalomon2014-10-15
| | | | | | R=joshualitt@google.com Review URL: https://codereview.chromium.org/660563003
* Some cleanup in processor header files.Gravatar bsalomon2014-10-15
| | | | | | R=joshualitt@google.com Review URL: https://codereview.chromium.org/659803004
* JPEG YUV DecodingGravatar sugoi2014-10-15
| | | | | | | | Enabling JPEG YUV Decoding in Skia BUG=skia:3005, skia:1674 Review URL: https://codereview.chromium.org/399683007
* Split GrFragmentProcessor into its own headerGravatar bsalomon2014-10-15
| | | | Review URL: https://codereview.chromium.org/660573002
* update dox for bounds in supersamplerGravatar reed2014-10-15
| | | | | | | | BUG=skia: TBR=caryclark@google.com NOTRY=True Review URL: https://codereview.chromium.org/657793003
* interesct path bounds with clip bounds before initializing supersamplerGravatar reed2014-10-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/656473004
* Push isEqual/onIsEqual down from GrProcessor to subclasses.Gravatar bsalomon2014-10-15
| | | | | | R=joshualitt@google.com Review URL: https://codereview.chromium.org/654273002
* add tests for large cordinates bounds when building aaclipGravatar reed2014-10-15
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/658753002
* bug_chomper: Consolidate public flag in a single place.Gravatar tfarina2014-10-14
| | | | | | | | BUG=None TEST=./run_server.sh --help and ./run_server.sh -public R=borenet@google.com Review URL: https://codereview.chromium.org/649303003
* Revert of Create a single command buffer for GrInOrderDrawBuffer (patchset ↵Gravatar mtklein2014-10-14
| | | | | | | | | | | | | | | | | | | | | | #17 id:1240001 of https://codereview.chromium.org/628453002/) Reason for revert: Leaking memory: http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/9/steps/gm/logs/stdio Original issue's description: > Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate > all its commands interleaved in contiguous memory. GrTRecorder also > supports extra data associated with objects, so we can store arrays > inline without having to call malloc(). > > Committed: https://skia.googlesource.com/skia/+/360b6801cfd90485891d709e44cf395d527ba69e TBR=bsalomon@google.com,reed@google.com,cdalton@nvidia.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/654863003
* Changed "Profile" to "Cube" in ColorCubeGravatar sugoi2014-10-14
| | | | | | | | A few references to "profile" still existed in SkColorCubeFilter, so I removed them. BUG=skia: Review URL: https://codereview.chromium.org/651303002
* Ignore ubuntu nvprmsaa4/mixed_xfermodes GM result.Gravatar Brian Salomon2014-10-14
| | | | | | BUG=skia:2443 Review URL: https://codereview.chromium.org/653153003
* Rebaseline mixedxfermodes on ubuntu/nvprmsaa4Gravatar Brian Salomon2014-10-14
| | | | | | TBR= Review URL: https://codereview.chromium.org/657603005
* Only use sized format on IMG/ES3 for single channel.Gravatar bsalomon2014-10-14
| | | | | | BUG=skia:2922 Review URL: https://codereview.chromium.org/638293004
* Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocateGravatar cdalton2014-10-14
| | | | | | | | all its commands interleaved in contiguous memory. GrTRecorder also supports extra data associated with objects, so we can store arrays inline without having to call malloc(). Review URL: https://codereview.chromium.org/628453002
* Remove uses of GrAutoScratchTexture.Gravatar bsalomon2014-10-14
| | | | | | | | | | Rename GrContext::lockAndRefScratchTexture to refScratchTexture. GrSurface::writePixels returns bool instead of void. BUG=skia:2889 Review URL: https://codereview.chromium.org/638403003
* Flush text contexts before drawing text as pathGravatar bsalomon2014-10-14
| | | | | | BUG=416289 Review URL: https://codereview.chromium.org/636233008
* webtry: Simplify template construction.Gravatar tfarina2014-10-14
| | | | | | | | | | | | | | | | text/template and html/template both have a helper function called "Must" that according to the docs in http://golang.org/pkg/text/template/#Must and http://golang.org/pkg/html/template/#Must, wraps a call to a function returning (*Template, error) and panics if the error is non-nil. So we don't need to that ourselves. Which is a good thing and makes code cleaner. BUG=None TEST=None R=jcgregorio@google.com Review URL: https://codereview.chromium.org/642243004
* create and modify matrices in luaGravatar reed2014-10-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/651823004
* Change GrTextContext fallbacks to be a linked list chain.Gravatar jvanverth2014-10-14
| | | | | | | | | Preliminary work for getting color emoji working with distance field text. BUG=skia:2887 Review URL: https://codereview.chromium.org/650273003
* Use GL_R8 rather than GL_RED for glTexImage2D on IMG/ES3. Check for failure ↵Gravatar bsalomon2014-10-14
| | | | | | | | of FP creation in SkImageFilter BUG=skia:2922 Review URL: https://codereview.chromium.org/656853002
* nanobench: flush after recording every Nth data point.Gravatar mtklein2014-10-14
| | | | | | | | | | Got to keep our precious data in event of a crash. With --flushEvery 10 I'm not seeing this cost any wall time. BUG=skia: Review URL: https://codereview.chromium.org/653083003
* add gamma value to devicepropertiesGravatar reed2014-10-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/652273002
* Adjust skimage expectations for Android reference deviceGravatar borenet2014-10-14
| | | | | | BUG=skia:3012 Review URL: https://codereview.chromium.org/650223004
* Add GrLayerCache::writeLayersToDiskGravatar robertphillips2014-10-14
| | | | | | I'm tired of readding this capability whenever I need to debug. Review URL: https://codereview.chromium.org/654653006
* Track if all stages modulate inputColor in computeInvariantOutputGravatar egdaniel2014-10-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/647863002
* Fix links to skia-buildbot code in preparation for deletionGravatar borenet2014-10-14
| | | | | | BUG=skia:761 Review URL: https://codereview.chromium.org/655643002
* parse outline to generate slidesGravatar reed2014-10-13
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/643113005
* Re-land ganesh checkbox. I needed to increase the size of the addressGravatar Greg Humphreys2014-10-13
| | | | | | | | | space available to a fiddle because linking against libGL causes the amount of memory used by a process to bloat to over 100M. Yikes. BUG=skia: Review URL: https://codereview.chromium.org/638003008
* Revert of add ganesh checkbox to skfiddle interface (patchset #6 id:270001 ↵Gravatar humper2014-10-13
| | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/649313002/) Reason for revert: adding -Dskia_mesa=1 broke production; don't yet know why and don't want to leave things in a broken state. Original issue's description: > add ganesh checkbox to skfiddle interface > > BUG=skia: > R=mtklein@google.com, tfarina@chromium.org > > Committed: https://skia.googlesource.com/skia/+/ccb54895c614632fd01d22b64ab614921f980eb1 TBR=tfarina@chromium.org,jcgregorio@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/655633003
* add ganesh checkbox to skfiddle interfaceGravatar Greg Humphreys2014-10-13
| | | | | | | BUG=skia: R=mtklein@google.com, tfarina@chromium.org Review URL: https://codereview.chromium.org/649313002
* Revert of No threadsafe statics. (patchset #1 id:1 of ↵Gravatar mtklein2014-10-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/654663002/) Reason for revert: Want to think about how to do this only to skialib and not to tools (gms, tests, etc.) Original issue's description: > No threadsafe statics. > > Chrome disables these for speed and code size, so we need > to disable them to make sure our code is safe when used > this way. > > int foo() { > static int32_t atomic_thing; > return sk_atomic_inc(&atomic_thing); > } > > is not safe in Chrome. Making the static global is: > > static int32_t atomic_thing; > int foo() { > return sk_atomic_inc(&atomic_thing); > } > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/cad5d3e264535c919b80e1e2a85407307961f221 TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/649343003
* Revert of Create a single command buffer for GrInOrderDrawBuffer (patchset ↵Gravatar mtklein2014-10-13
| | | | | | | | | | | | | | | | | | | | | #14 id:1050001 of https://codereview.chromium.org/628453002/) Reason for revert: New test failing on Android: http://build.chromium.org/p/client.skia.android/builders/Test-Android-Nexus7-Tegra3-Arm7-Release/builds/89/steps/dm/logs/stdio Original issue's description: > Adds a GrTBaseList class that GrInOrderDrawBuffer uses to allocate > all its commands interleaved in contiguous memory. GrTBaseList also > supports extra data associated with objects, so we can store arrays > inline without having to call malloc(). > > Committed: https://skia.googlesource.com/skia/+/47c844aaba81e5a29c773b660e1d6062c766d253 TBR=bsalomon@google.com,reed@google.com,cdalton@nvidia.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/652843002
* Link to skiadocs site, since that is the canonical location for documentation.Gravatar Thiago Farina2014-10-13
| | | | | | | | BUG=None TEST=None R=borenet@google.com, rmistry@google.com Review URL: https://codereview.chromium.org/646853002
* experimental parserGravatar reed2014-10-13
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/651023002
* Fix reference to non-existant 'tests' target.Gravatar Thiago Farina2014-10-13
| | | | | | | | | | This target was previously folded into dm. Do not advertise it anymore. BUG=None TEST=None R=borenet@google.com Review URL: https://codereview.chromium.org/646843002
* Require SK_DECLARE_STATIC_LAZY_PTR is used in global scope.Gravatar mtklein2014-10-13
| | | | | | | | | | | | | Function- or method- local scope isn't threadsafe; the pointer is generally zero-initialized on first use in function scope (i.e. lazily... we have to go deeper), but for globals we can be pretty sure the linker will do that for us. BUG=skia: No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/651723003