aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* re-re-land of skslc now automatically turns on derivatives supportGravatar ethannicholas2016-10-20
| | | | | | | | | | | Only change from last attempt is putting the call to shaderDerivativeExtensionString behind a check for shaderDerivativeSupport to avoid a spurious assertion failure. TBR=benjaminwagner@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2437063002 Review-Url: https://chromiumcodereview.appspot.com/2437063002
* Run ANGLE in GL mode on test botsGravatar Brian Salomon2016-10-20
| | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3724 Change-Id: Ic3d6efcb331ac3947026476e357e76214f2ccdf8 Reviewed-on: https://skia-review.googlesource.com/3724 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* fix fuzzersGravatar caryclark2016-10-20
| | | | | | | | | | | | | | | Many old pathops-related fuzz failures have built up while the codebase was under a state a flux. Now that the code is stable, address these failures. Most of the CL plumbs the debug global state to downstream routines so that, if the data is not trusted (ala fuzzed) the function can safely exit without asserting. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2426173002 Review-Url: https://chromiumcodereview.appspot.com/2426173002
* use 'real' SkImageDeserializerGravatar Mike Reed2016-10-20
| | | | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3727 Change-Id: Ic07ea6bd2756f1be08e80075c236a70ce6c08a3b TBR=mtklein Reviewed-on: https://skia-review.googlesource.com/3727 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Viewer on Mac.Gravatar Mike Klein2016-10-20
| | | | | | | | | | | | | | | | | - Support ObjC / ObjC++ - Build SDL on Mac. - Build viewer on Mac. Patched from Jim's CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3760 Change-Id: I12663f2ed2969e22f51aefed560fbc22b2524167 Reviewed-on: https://skia-review.googlesource.com/3760 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Slim down builder CIPD packages.Gravatar Mike Klein2016-10-20
| | | | | | | | | | | | | | The Android builders don't need the clang_linux asset. I don't think anything needs the android_sdk asset. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3740 Change-Id: I3e61ba23ed661a998f9dc0eb4c46cc8eb1cf3226 Reviewed-on: https://skia-review.googlesource.com/3740 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add SkRRectsGaussianEdgeMaskFilterGravatar Robert Phillips2016-10-20
| | | | | | | | | | | | | | SkRRectsGaussianEdgeShader will be removed once the usage of the MaskFilter flavor has been propagated to Android I will complete the raster implementation in a follow up CL. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3632 Change-Id: I42470b17308582b040a5db1a7283c3d717405345 Reviewed-on: https://skia-review.googlesource.com/3632 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Class delete call unsized delete when size not known.Gravatar Ben Wagner2016-10-19
| | | | | | | | | | | | | | | | | | Some classes directly call global operator new to reserve space in addition to the space the class will occupy. These clases must be deleted with the unsized global operator new. If a build is configured such that sized global operator new is called from a delete expression, this must be overridden by such classes. TBR=reed Only affects private bits of SkData. Change-Id: I797935db17a37aa8c2ca7b562a4ea65a7978a9f0 Reviewed-on: https://skia-review.googlesource.com/3678 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Revert "remove unneeded flags for android""Gravatar reed2016-10-19
| | | | | | | | | This reverts commit bbe17a66705aff6f34a22adc0c12883dcb6161b3. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2426343005 Review-Url: https://chromiumcodereview.appspot.com/2426343005
* More explicit body/tail function versioning.Gravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | | MSVC was not picking up that tail==0 in the non-_tail versions of the kernel functions in SkRasterPipeline_opts.h. This passes through a template bool parameter to convey the same message. This makes the body code a bit smaller and faster on MSVC now by removing the tail>0 check and code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3669 Change-Id: I8bf81717a83f216eb1eb28a75dac41779dc508c1 Reviewed-on: https://skia-review.googlesource.com/3669 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Try again with SkOpts_hsw and 8x pipelines, attempt 2.Gravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | | Originally reviewed: https://skia-review.googlesource.com/3667 This time around, don't forget swap_src_dst. CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3676 Change-Id: I127e7fb2bf9d3bfee61c3749fc1c334c9476cb4e Reviewed-on: https://skia-review.googlesource.com/3676 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Try again with SkOpts_hsw and 8x pipelines."Gravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | | | | This reverts commit 4f02ce7995554d899cdde2b7d82f600fc8017fcc. Reason for revert: missed a stage TBR=mtklein@chromium.org,msarett@google.com,herb@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I1dc1229183d67fe72977e492977a97b19dc630d2 Reviewed-on: https://skia-review.googlesource.com/3675 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Try again with SkOpts_hsw and 8x pipelines.Gravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | | All SkNx are now in anonymous namespaces and all their methods are force-inlined. We should not have any ODR problems. This is still a near 2x speedup, more so for f16. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3667 Change-Id: I6db9a46f7164f49827ab4d7983e80bf8cea99995 Reviewed-on: https://skia-review.googlesource.com/3667 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Subtract start_coord instead of adding itGravatar scroggo2016-10-19
| | | | | | | | | | | | | | | crrev.com/2420843003 (DIFFERENT ISSUE) introduced some changes in sampled images. (I already corrected the problem for interlaced PNGs in crrev.com/2424353003.) When deciding whether a row is needed, we need to subtract the starting coordinate, similar to how we subtracted fFirstRow in SkPngCodec. This should "fix" the remaining untriaged images in Gold (i.e. we will go back to producing the original image). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2440563002 Review-Url: https://chromiumcodereview.appspot.com/2440563002
* Recipe fix for buildbotless botsGravatar borenet2016-10-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2435803003 Review-Url: https://chromiumcodereview.appspot.com/2435803003
* Define SK_CPU_SSE_LEVEL on Windows builds.Gravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | | We check this define to know which intrinsics we can call safely. The -msse flags set it for us on non-MSVC, but MSVC has no such switch. We do this in GYP (and Chrome's GN) too. No need for any defines on :avx or :hsw targets... the /arch:AVX and /arch:AVX2 do set SK_CPU_SSE_LEVEL for us. Most directly, this means things like Sk4f::thenElse() will now use blendps when compiled into SkOpts_sse41.cpp. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3666 Change-Id: Ie80a8b8e5544250b45cfe51c40604fade06b3ef9 Reviewed-on: https://skia-review.googlesource.com/3666 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com>
* Make monobench more usable on Windows.Gravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | All small stuff: - printf doesn't go to the Visual Studio console, SkDebugf does; - the Windows console can't show an ellipsis; - overwriting the console line is a little different on Windows. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3664 Change-Id: I0175afd6d0147feaff8ff6edae2b35a7435c25f5 Reviewed-on: https://skia-review.googlesource.com/3664 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Correct a small mistake in SkPath::build_arc_conicsGravatar xidachen2016-10-19
| | | | | | | | | | | | | | | In this function, when count is 0, it maps the dst point to start, where it should really be stop. A test case is also added. In the test case, it should be drawing three lines, without the change in SkPath class, it will draw 2 lines only with the top horizontal line missing because it maps the dst point to the start point, and hence the horizontal line is not drawn. BUG=640031 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2409983004 Review-Url: https://chromiumcodereview.appspot.com/2409983004
* Add key params for buildbotless bots in DM/nanobenchGravatar borenet2016-10-19
| | | | | | | BUG=skia:5626 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2424793005 Review-Url: https://chromiumcodereview.appspot.com/2424793005
* Remove shaderc DEPS.Gravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | Was just perusing DEPS and I realized shaderc is probably no longer needed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3561 Change-Id: I054a424b26e51dbfee77dbe79e1e175399627902 Reviewed-on: https://skia-review.googlesource.com/3561 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Greg Daniel <egdaniel@google.com>
* disable packed texture tests on TSAN botGravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-Clang-Golo-GPU-GT610-x86_64-Release-TSAN is flaky. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3662 Change-Id: I5c80970cb81db71f4acc89dc287952b1d2a3656c Reviewed-on: https://skia-review.googlesource.com/3662 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Support inline uploads in VulkanGravatar Greg Daniel2016-10-19
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3586 Change-Id: I5913c336aa33851d6d2e80d9638df2efa8ac0400 Reviewed-on: https://skia-review.googlesource.com/3586 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Remove custom NINJA_STATUS.Gravatar Mike Klein2016-10-19
| | | | | | | | | | I think the Ninja [nnn/mmm] counts started going off when we landed this. I'd rather have the [nnn/mmm] be correct than have the timestamps. Change-Id: I96d24664789393056f94202f2b549ed5a4fe4bdb Reviewed-on: https://skia-review.googlesource.com/3604 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add helper to create random AsFPArgs for Ganesh unit testsGravatar Brian Osman2016-10-19
| | | | | | | | | | | | | | Reduces copy-paste and eases maintenance. I'll be adding another field to AsFPArgs soon, and this is going to streamline that change. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3639 Change-Id: I6372ed5dce50a5ba9d73039bd4714e34502a1f75 Reviewed-on: https://skia-review.googlesource.com/3639 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Roll recipe DEPSGravatar borenet2016-10-19
| | | | | | | | | | This is for https://codereview.chromium.org/2426013002/ ("Add Swarming magic environment variables to ENV_WHITELIST") BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2438553002 Review-Url: https://chromiumcodereview.appspot.com/2438553002
* SkNx: use SK_ALWAYS_INLINE thoroughly.Gravatar Mike Klein2016-10-19
| | | | | | | | | | | | | | | | | | MSVC's not so good at inlining. So tell it where to. It won't hurt the others. This has nothing directly to do with ODR safety. The anonymous namespaces and 'static' on freestanding functions provide the correctness we need there. But this change can help to mechanically prevent the sort of problems ODR violations can lead to. I may follow up by extending this strategy further to Sk4px, which is used to implement a lot of the legacy xfermodes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3608 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Change-Id: I927334c40910ce43da1fbabdf243c9cd5438bea6 Reviewed-on: https://skia-review.googlesource.com/3608 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkDescriptors to be held in unique_ptr.Gravatar bungeman2016-10-19
| | | | | | | | | | | | This also removes the class operator new override along with directly calling malloc in SkData, since it has a similar requirements. CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot;master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot Change-Id: Ic68aacf2028d6964d9735a55558862afc9edd19b Reviewed-on: https://skia-review.googlesource.com/3541 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* Revert of Generate Signed Distance Field directly from vector path (patchset ↵Gravatar benjaminwagner2016-10-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #18 id:340001 of https://chromiumcodereview.appspot.com/1643143002/ ) Reason for revert: Multiple assertion failures on multiple platforms: ../../../src/gpu/GrDistanceFieldGenFromVector.cpp:806: fatal error: "assert(((col != width - 1) || (windingNumber == 0)) && "Winding number should be zero at the end of a scan line.")" https://luci-milo.appspot.com/swarming/task/31f5353caf8cc410 https://luci-milo.appspot.com/swarming/task/31f567789cbcec10 c:\b\work\skia\src\pathops\skopangle.cpp:165: fatal error: "assert(lrOpposite != trOpposite)" https://luci-milo.appspot.com/swarming/task/31f570d74f750310 Original issue's description: > Generate Signed Distance Field directly from vector path > > Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002 > > Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f > Committed: https://skia.googlesource.com/skia/+/e8f0a7b986f1e5583c9bc162efcdd92fd6430549 TBR=bsalomon@google.com,jvanverth@google.com,mtklein@google.com,wasim.abbas@arm.com,caryclark@google.com,joel.liang@arm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://chromiumcodereview.appspot.com/2435753002
* Generate Signed Distance Field directly from vector pathGravatar joel.liang2016-10-19
| | | | | | | | | | Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002 Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f Review-Url: https://chromiumcodereview.appspot.com/1643143002
* image serialize/deserialize callbacks in pipeGravatar Mike Reed2016-10-18
| | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3607 Change-Id: I403fec72cacfc6a821f676f0afef390c89749a8b Reviewed-on: https://skia-review.googlesource.com/3607 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Make ANGLE bot only run ANGLE configsGravatar Brian Salomon2016-10-18
| | | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3597 Change-Id: Id948caa1f28f415c453895fd30ff032bcadbb3d3 Reviewed-on: https://skia-review.googlesource.com/3597 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Revert "remove unneeded flags for android"Gravatar Greg Daniel2016-10-18
| | | | | | | | | | | | | | | | | This reverts commit f00decf64422fce118703f046b135a542c013857. Reason for revert: Breaking master-skia cause of SK_SUPPORT_LEGACY_PICTURE_PTR TBR=rmistry@google.com,scroggo@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ib33b8fafeee847e0ef92e5865e50c2070ba3939c Reviewed-on: https://skia-review.googlesource.com/3624 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Exclude viewer from NoGpu botsGravatar Brian Osman2016-10-18
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3623 Change-Id: Ie1146a7092e08b83e5a332a26d771652f977b52a Reviewed-on: https://skia-review.googlesource.com/3623 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* GN builds viewer on Linux, tooGravatar Brian Osman2016-10-18
| | | | | | | | | | BUG=skia: Change-Id: Ia0c10db49905fc5a3bdf424c38576e1a6cf09ecf Reviewed-on: https://skia-review.googlesource.com/3606 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* remove unneeded flags for androidGravatar Mike Reed2016-10-18
| | | | | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3595 Change-Id: I74bd11b2324c3e1ab07e5f67b01b90291deb879e NOTREECHECKS=True NOTRY=True Change-Id: I74bd11b2324c3e1ab07e5f67b01b90291deb879e Reviewed-on: https://skia-review.googlesource.com/3595 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Add testing for ANGLE msaa on botsGravatar Brian Salomon2016-10-18
| | | | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE-Trybot BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3587 Change-Id: I3895f9c2e662db400a47993987f5a16dc8ebba37 Reviewed-on: https://skia-review.googlesource.com/3587 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fix star artifact in SkRRectsGaussianEdgeShaderGravatar Robert Phillips2016-10-18
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3360 Change-Id: I791ae5f44a88ac3e4debdf1d4092c605acdf4969 Reviewed-on: https://skia-review.googlesource.com/3360 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Viewer builds (for Windows) with GNGravatar Brian Osman2016-10-18
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3599 Change-Id: Id6a142f90f544bef266d78e385f22e17288d5064 Reviewed-on: https://skia-review.googlesource.com/3599 Reviewed-by: Mike Klein <mtklein@google.com>
* Add SKSL fuzzerGravatar kjlubick2016-10-18
| | | | | | | BUG=skia:5490 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2418763004 Review-Url: https://codereview.chromium.org/2418763004
* Refactored SkColorSpace and added in a Lab PCS GMGravatar raftias2016-10-18
| | | | | | | | | | | | | | | | | | | | The refactoring breaks off A2B0 tag support into a separate subclass of SkColorSpace_Base, while keeping the current (besides CLUT) functionality in a XYZTRC subclass. ICC profile loading is now aware of this and creates the A2B0 subclass when SkColorSpace::NewICC() is called on a profile in need of the A2B0 functionality. The LabPCSDemo GM loads a .icc profile containing a LAB PCS and then runs a Lab->XYZ conversion on an image using it so we can display it and test out the A2B0 SkColorSpace functionality, sans a/b/m-curves, as well as the Lab->XYZ conversion code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389983002 Review-Url: https://codereview.chromium.org/2389983002
* Some GN-related recipe cleanup.Gravatar Mike Klein2016-10-18
| | | | | | | | | | | | | | | | | | | All our bots but the iOS ones are on GN now. This cleans up a bunch of GYP and other obsolete stuff. - Nothing's using default_flavor.py any more except as a base class. - There are no -CMake, -Shared or -VisualBench bots anymore. - Only the iOS bots care about GYP_DEFINES. You'll see the PDFium bot's GYP_DEFINES change, but that doesn't matter... it's using PDFium's own (GN) build system, and it ignores GYP_DEFINES. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3567 Change-Id: I699e10f013ea77df4dcaa1cb559c51c5bf55dfdb Reviewed-on: https://skia-review.googlesource.com/3567 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Fix ASAN bot.Gravatar Mike Klein2016-10-18
| | | | | | | | | | | | | TBR=caryclark@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3591 Change-Id: Ib80ee9c5a3277de64bcde85383ad712956118295 Reviewed-on: https://skia-review.googlesource.com/3591 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Refactor GrVkGpuCommandBuffer to handle multiple GrVkCommandBuffers.Gravatar Greg Daniel2016-10-18
| | | | | | | | | | | | | | | | | | | This CL is a pre CL to fix some issues where we will need a GpuCB to internally have multiple commandbuffers that it submits. Because of this, I need to move the bounds calculations down into the VkGpuCB since we need to know the bounds for each sub commandbuffer and not just entire set of commands. In part this is good since GL actually never needed the calculations so it saves some work there. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3142 Change-Id: Ied918765da3630aa6d87e29ccce6c883b96c4ead Reviewed-on: https://skia-review.googlesource.com/3142 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* skpbench: suppot Nexus 6PGravatar csmartdalton2016-10-18
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415033002 Review-Url: https://codereview.chromium.org/2415033002
* Consider the start_coord in interlaced PNGGravatar scroggo2016-10-18
| | | | | | | | | | | | | | crrev.com/2420843003 (DIFFERENT ISSUE) resulted in a slight difference in Gold for interlaced PNGs. The new images appeared to have slid down slightly, implying that we sampled pixels higher (earlier) in the image. It turns out we were not truly taking get_start_coord into account. This CL initializes the srcRow to consider get_start_coord, and should fix the problem/difference. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2424353003 Review-Url: https://codereview.chromium.org/2424353003
* fix -NoGPU build bots.Gravatar Mike Klein2016-10-18
| | | | | | | | | | | | | TBR=caryclark@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3589 Change-Id: I4bf4a6b812a8284f739c86d03f334521e896a1cf Reviewed-on: https://skia-review.googlesource.com/3589 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Run correctness tests on ANGLE bots using d3d9 backendGravatar Brian Salomon2016-10-18
| | | | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3584 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE-Trybot Change-Id: Ic70002d13261d22d374f0fd29e2f8dd3c783d552 Reviewed-on: https://skia-review.googlesource.com/3584 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Revert "re-land of skslc now automatically turns on derivatives support"Gravatar Mike Klein2016-10-18
| | | | | | | | | | | | | | | | | | | This reverts commit d7d1997643db3b9b5caaaac235c0e2cd0fa23ec2. This breaks the Chromium roll (it did last time it landed too). https://codereview.chromium.org/2429853002 Please gate your next attempt on at least one of linux_android_rel_ng, linux_chromium_rel_ng, or mac_chromium_rel_ng. TBR=benjaminwagner@google.com,ethannicholas@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I999d4af70a5704b8990f3cd7d145eabff57646f5 Reviewed-on: https://skia-review.googlesource.com/3590 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* break ambiguous angle sorting loopGravatar caryclark2016-10-18
| | | | | | | | | | | | | | | | | | A pair of cubics may be difficult to sort if the tangents suggest one sort but the midpoints suggest a different one. When in this gray area, and when the cumulative sort of all the angles fails to resolve, reverse the sort to break the tie. Before, when tiger8 was run through the signed distance field generated directly from the path data, the simplify call might hang since the angle could not be resolved. If the endless loop is detected, and if there is no tie to break, just fail instead. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2426753002 Review-Url: https://codereview.chromium.org/2426753002
* Add support for ANGLE MSAA framebuffer extensions.Gravatar Brian Salomon2016-10-18
| | | | | | | | | | | BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3505 Change-Id: I185ae0fdf5657271dc00b8dd88b78a69c3d6e4f1 Reviewed-on: https://skia-review.googlesource.com/3505 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 08:13:06 +0000