| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1364743002/ )"
removed test for unsupported SkInstallDiscardable...
This reverts commit 60c73d51808b9d78f65381b83f628a3f523042fe.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1369443002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests were isolated from their respective minimized test cases.
The tests work fine and pass path ops internal validation;
hopefully some more intensive x-san or valgrind test will help
isolate the bug.
Sheriff, please revert if it fails and I don't get to it first.
TBR=reed@google.com,halcanary@google.com
BUG=535127,535151
Review URL: https://codereview.chromium.org/1359263003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The last parameter of CTFontCreateWithGraphicsFont (CTFontDescriptorRef
attributes) *must* be nullptr. If non-nullptr then with fonts with
variation axes, the copy will fail in CGFontVariationFromDictCallback
when it assumes kCGFontVariationAxisName is CFNumberRef which it quite
obviously is not.
TBR=reed@google.com
Blocking dev builds, just removes code.
BUG=chromium:535109
Review URL: https://codereview.chromium.org/1362053003
|
|
|
|
|
|
|
|
|
| |
Land after http://crrev.com/1359943003
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=1360193002
Review URL: https://codereview.chromium.org/1360193002
|
|
|
|
|
|
| |
BUG=skia:4374
Review URL: https://codereview.chromium.org/1367623002
|
|
|
|
|
|
|
|
|
| |
Motivation: I want too finalize this API before working on the more
complex problem of adding XMP metadata for PDF/A.
BUG=skia:3110
Review URL: https://codereview.chromium.org/1359943003
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compare Ganesh and HWUI canvas rendering of SKPs on android.
Put SKP files in .../canvasproof/src/main/assets/skps
Run on a Marshmallow device.
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1258123004
|
|
|
|
|
|
|
|
| |
skia:4373
BUG=skia:4373
Review URL: https://codereview.chromium.org/1365683003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1364743002/ )
Reason for revert:
Build failure: https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_FrameworkDefs/builds/1146
Original issue's description:
> remove unused SkCachingPixelRef
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/70d58b7da535e32bcac35739d11ab8367e99f224
TBR=halcanary@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1359393004
|
|
|
|
|
|
| |
BUG=skia:4371
Review URL: https://codereview.chromium.org/1363963002
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1364743002
|
|
|
|
|
|
|
| |
This will allow the ANGLE guys to test the ANGLE gl backend
with nanobench and DM
Review URL: https://codereview.chromium.org/1343193005
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1345853005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkBitmapRegionDecoderInterface provides an interface
for multiple implementations of Android's
BitmapRegionDecoder.
We already have correctness tests in DM that will enable us
to compare the quality of our various BRD implementations.
We also need these performance tests to compare the speed
of our various implementations.
BUG=skia:4357
Review URL: https://codereview.chromium.org/1344993003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1359833005
|
|
|
|
|
|
| |
BUG=skia:4367
Review URL: https://codereview.chromium.org/1351073003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1359833004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1345853004
|
|
|
|
|
|
|
|
| |
- Add missing #include <new>.
- Simplify createT functions with C++11 variadic templates.
- Change destroyT helper function into a private static function.
Review URL: https://codereview.chromium.org/1359853002
|
|
|
|
|
|
|
|
| |
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/511684fb52f20862f8552f5009390ff3987b08d8
Review URL: https://codereview.chromium.org/1359453002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Probably unlikely to matter in practice, but SkTQSort calculates its
midpoint correctly, so we might as well do it here too. For more
background, see Joshua Bloch's "Nearly All Binary Searches and
Mergesorts are Broken" post:
http://googleresearch.blogspot.ru/2006/06/extra-extra-read-all-about-it-nearly.html
This doesn't change any public API.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1362613002
|
|
|
|
|
|
|
|
| |
This will allow us to batch over color changes for LCD text.
BUG=skia:
Review URL: https://codereview.chromium.org/1354423002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It appears that CTFontCreateCopyWithAttributes and
CTFontCreateCopyWithSymbolicTraits share similar issues with the default
font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as
it will not work with webfonts. Since this is all low-level use, create the
CTFonts from the underlying CGFonts directly.
BUG=chromium:524646
Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f
Review URL: https://codereview.chromium.org/1344213004
|
|
|
|
|
|
| |
BUG=skia:4367
Review URL: https://codereview.chromium.org/1347143006
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1359453002/ )
Reason for revert:
breaking bots
Original issue's description:
> Fix for degenerate stroke rect
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/511684fb52f20862f8552f5009390ff3987b08d8
TBR=robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1356223003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1359453002
|
|
|
|
|
|
| |
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/1350523004
|
|
|
|
|
|
| |
TBR=egdaniel@google.com
Review URL: https://codereview.chromium.org/1357773003 .
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1347943003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes the uses of SkNEW that have resprouted since commit
385fe4d, and removes the macros entirely now that Android and Chromium
have been cleaned up to no longer depend on them.
A bunch of files implicitly depend on #include <new> from SkPostConfig.h
still though, so keep that for now. To be fixed in a followup CL.
[mtklein mucking around]
Only public API removed.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1360653004
|
|
|
|
|
|
| |
BUG=530758
Review URL: https://codereview.chromium.org/1345373006
|
|
|
|
|
|
|
| |
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1349933004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1356133002/ )
Reason for revert:
whee
Original issue's description:
> Combined approach.
>
> This combines some ideas from these two CLs:
> - try stosd/w
> - update memset16/32 inlining heuristics
>
>
> BUG=skia:4316
>
> Blinking in and out for perf.skia.org.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/46243a7c02a1d5116e55a27ff59218f9c320df97
TBR=reed@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4316
Review URL: https://codereview.chromium.org/1353703006
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This combines some ideas from these two CLs:
- try stosd/w
- update memset16/32 inlining heuristics
BUG=skia:4316
Blinking in and out for perf.skia.org.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1356133002
|
|
|
|
|
|
| |
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1353383003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1357823003
|
|
|
|
|
|
| |
BUG=skia:4362
Review URL: https://codereview.chromium.org/1361453002
|
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1354413003
Review URL: https://codereview.chromium.org/1354413003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1351403005/ )
Reason for revert:
pingpong
Original issue's description:
> try simplest code: inline whenever vaguely sensible
>
> BUG=skia:4316
>
> Will land and revert.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/527a0c8235b454f5d0475a9a3e34caa9520db3a2
TBR=reed@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4316
Review URL: https://codereview.chromium.org/1355073002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:4316
Will land and revert.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1351403005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1355063002/ )
Reason for revert:
boink
Original issue's description:
> try stosd/w
>
> While we're trying things and reverting them, might as well try this too.
>
> BUG=skia:4316
>
> Blinking in and out for perf.skia.org.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/3ca0f626a07e9b534d14a2d8213eedb93c5f7534
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4316
Review URL: https://codereview.chromium.org/1356983004
|
|
|
|
|
|
|
|
|
|
|
| |
While we're trying things and reverting them, might as well try this too.
BUG=skia:4316
Blinking in and out for perf.skia.org.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1355063002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1357193002/ )
Reason for revert:
Who wants to land forever?
Original issue's description:
> update memset16/32 inlining heuristics
>
> I spent some time looking at perf.skia.org and it looks like we can do better.
>
> It is weird, weird, weird that on x86, we see three completely different behaviors:
> - x86 Android: inlining better for small N, custom better for large N;
> - Windows: inlining better for large N, custom better for small N;
> - other x86: inlining generally better
>
> BUG=skia:4316,chromium:516426
>
> (Temporary, plan to revert.)
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/b68fa409fc00ce2f38e2a0fd6f9dc2379b372481
TBR=reed@google.com,jcgregorio@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4316,chromium:516426
Review URL: https://codereview.chromium.org/1358793002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I spent some time looking at perf.skia.org and it looks like we can do better.
It is weird, weird, weird that on x86, we see three completely different behaviors:
- x86 Android: inlining better for small N, custom better for large N;
- Windows: inlining better for large N, custom better for small N;
- other x86: inlining generally better
BUG=skia:4316,chromium:516426
(Temporary, plan to revert.)
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1357193002
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/1360503002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1344213004/ )
Reason for revert:
Causes issues with synthetic bold italic on all versions of OSX, with OSX10.10 resulting in many measurement related changes (this is expected though).
fast/text/atsui-multiple-renderers.html
fast/css/font-face-synthetic-bold-italic.html
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9__retina_/6168/layout-test-results/results.html
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/4525/layout-test-results/results.html
Original issue's description:
> Avoid CTFontCreateCopyWithAttributes.
>
> It appears that CTFontCreateCopyWithAttributes and
> CTFontCreateCopyWithSymbolicTraits share similar issues with the default
> font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as
> it will not work with webfonts. Since this is all low-level use, create the
> CTFonts from the underlying CGFonts directly.
>
> BUG=chromium:524646
>
> Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f
TBR=erikchen@chromium.org,mtklein@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:524646
Review URL: https://codereview.chromium.org/1354323002
|
|
|
|
|
|
|
|
|
|
|
|
| |
It appears that CTFontCreateCopyWithAttributes and
CTFontCreateCopyWithSymbolicTraits share similar issues with the default
font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as
it will not work with webfonts. Since this is all low-level use, create the
CTFonts from the underlying CGFonts directly.
BUG=chromium:524646
Review URL: https://codereview.chromium.org/1344213004
|
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1353473007
Review URL: https://codereview.chromium.org/1353473007
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1353203002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1353553002
|