aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Return nullptr when ReadBuffer becomes invalidGravatar Kevin Lubick2018-05-17
| | | | | | | | | | | | | | | | | This especially helps in SkDrawLooper because we can bail out early instead of looping for a potentially long time, e.g. when fuzzed input says count is a large number. This also cleans up validate in a few spots, and adds validateCanReadN as a helper function. Bug: skia:7937 Change-Id: Ic5eff357c8cadc91eeafc6e39c78c570ba74df2f Reviewed-on: https://skia-review.googlesource.com/128847 Commit-Queue: Kevin Lubick <kjlubick@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Rewrite GrQuad to use separate arrays of x and y values to be Sk4f friendly.Gravatar Brian Salomon2018-05-17
| | | | | | | Change-Id: Ie2ad197c5f17849fe6e034b60bc7ec18a00edb24 Reviewed-on: https://skia-review.googlesource.com/128842 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* added basic texturing to metal sksl backendGravatar Timothy Liang2018-05-17
| | | | | | | | Bug: skia: Change-Id: I2e70efe53f5c2fb208979cc89be9c3c841944a48 Reviewed-on: https://skia-review.googlesource.com/128844 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* check path bounds before trying to shadowGravatar Mike Reed2018-05-17
| | | | | | | | Bug: oss-fuzz:8331 Change-Id: Idbff0deb0b9968edf4b4fafd4cf497bbb71c64fa Reviewed-on: https://skia-review.googlesource.com/128550 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove static initializer to register destructor.Gravatar Ben Wagner2018-05-17
| | | | | | | | | | | | | Skia cannot have global sk_sp objects because they will register an exit time destructor which will be done through a static initializer. BUG=chromium:843858 Change-Id: I43e3d18c9d8b50ff067414148c7524bffd3523da Reviewed-on: https://skia-review.googlesource.com/128843 Auto-Submit: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Set margin for outer blur masks with no blur.Gravatar Ben Wagner2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | The margin of a mask filter is intended to be the additional src region which the mask filter will take into account when creating the dst (a region which will be assumed to be fully transparent around the src). In the event there is an outer blur with no effective blur the src does not need to be considered at all since the outcome will always be an empty mask. The 'margin' is then effectively -inf in all directions, but currently users of margin expect the value to come back non-negative. This sets the margin in this case to 0 to allow the users to do their work and then the filter will simply discard that work. Currently the margin is not being set at all, leading to undefined behavior. In the future the users of mask filters need to be able to handle negative margins and there needs to be a way for the mask filter to signal that it will disregard any src image. BUG=oss-fuzz:8332 Change-Id: Ia9d1711b8c68142134bb6d393de17b9abaf7b23a Reviewed-on: https://skia-review.googlesource.com/128683 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* mapRect should not fiddle with nonfinite values.Gravatar Cary Clark2018-05-17
| | | | | | | | | Docs-Preview: https://skia.org/?cl=128682 Bug: skia:7967 Change-Id: Ic43387b7705ee8385b8df2430886484ff856077c Reviewed-on: https://skia-review.googlesource.com/128682 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/16f4bad9148c587a0254988138e713df72b035b7 gclient: Merge hook_os with hooks and deps_os with os. (ehmaldonado@chromium.org) https://crrev.com/ed1bb34fc59e5539ea29def4d68cd94a8e17e71b gclient: Remove condition_value. (ehmaldonado@chromium.org) https://crrev.com/23a358764dd8cd61e7d6efe086fb51c78ae0ac9b gclient: Fix for extra custom_deps. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4ba63046af4d1d1824c7e8850ef46103b1de781d Reviewed-on: https://skia-review.googlesource.com/128740 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2/ f299a378f..0e1c158ed (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/f299a378f1e6..0e1c158ed0e6 $ git log f299a378f..0e1c158ed --date=short --no-merges --format='%ad %ae %s' 2018-05-16 ynovikov Log error of RegisterClassA in DisplayWGL::initialize 2018-05-16 ynovikov Revert "Don't double-terminate a display." Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=herb@google.com Change-Id: I75978b3ebb3f0cdd87a367f41c2e045aa2af689b Reviewed-on: https://skia-review.googlesource.com/128720 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/skcms 5cc905d..e4c0e54 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/5cc905d..e4c0e54 2018-05-16 brianosman@google.com Add lerping to skcms_eval_curve The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: Ie44a66826197489e499a2ce7dcbba8592a43973f Reviewed-on: https://skia-review.googlesource.com/128650 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/swiftshader/ c8403ec14..89c43d202 (1 commit)Gravatar swiftshader-skia-autoroll2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/c8403ec14aaf..89c43d202302 $ git log c8403ec14..89c43d202 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 capn Ignore glGenerateMipmap for unspecified or zero-sized textures. Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=herb@google.com Change-Id: I3c12b97d4f57176d10e1a10a92c4aa8f76ca39d1 Reviewed-on: https://skia-review.googlesource.com/128657 Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2/ 80c32ccbb..f299a378f (6 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/80c32ccbbcc6..f299a378f1e6 $ git log 80c32ccbb..f299a378f --date=short --no-merges --format='%ad %ae %s' 2018-05-14 lucferron Vulkan: Implement copyImage and enable all tests for it 2018-05-14 lucferron Vulkan: Finish implementation of the copySubImage 2018-05-14 lucferron Vulkan: Implement PACK_STATE dirty bit and remove warning 2018-05-16 jmadill dEQP: Implement --deqp-case for GTest. 2018-05-10 lucferron Vulkan: Basic support of copySubImage 2018-05-15 geofflang Add more dEQP EGL expectations for Linux and Android. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=herb@google.com Change-Id: I406b94873c427557c759279cf3e288d01aec1b6b Reviewed-on: https://skia-review.googlesource.com/128654 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/babd098f3684f1bc965a0f72f96cb701eec91e52 gclient: Simplify GetScmName and CreateSCM. (ehmaldonado@chromium.org) https://crrev.com/cbf0204555fe07fda96d20456e03f105e2922005 do not try collecting issues information for an empty issues list (vbendeb@chromium.org) https://crrev.com/8de3800ce55ba459ffcbedcfa52ef5e6e59caab6 print access errors separately (vbendeb@chromium.org) https://crrev.com/3f0591d4f12991ed39bae2dca96d3593879be382 Reland "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id709515589c521a2896f4ecbf50385b936773930 Reviewed-on: https://skia-review.googlesource.com/128686 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Suppress bad-function-cast warningGravatar Brian Osman2018-05-16
| | | | | | | | | | Bug: skia: Change-Id: Ic5efe371b6365913a47d833c698958cc842d16ae Reviewed-on: https://skia-review.googlesource.com/128685 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Driver bug workaround: pack_parameters_workaround_with_pack_bufferGravatar Adrienne Walker2018-05-16
| | | | | | | | Bug: chromium: 829614 Change-Id: I3fae2b4181e4a6e37fb31fe2f2e9a6cfacb1860f Reviewed-on: https://skia-review.googlesource.com/128206 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Fix check for valid proxies returned by AtlasManager.Gravatar Jim Van Verth2018-05-16
| | | | | | | | | | | | Also renames a lot of variables to make it clearer that getProxies() returns the number of instantiated proxies, not the number of all proxies. Bug: skia: Change-Id: Ifbc910cbd6635dccdb4e7f0df2e69a0f341130af Reviewed-on: https://skia-review.googlesource.com/128660 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/skcms a7e79c5..5cc905d (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/a7e79c5..5cc905d 2018-05-16 mtklein@chromium.org remove BUILD.gn The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: I97601850cec8011097ec66d8ece8efd50e86c41c Reviewed-on: https://skia-review.googlesource.com/128640 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/swiftshader/ 596f653f5..c8403ec14 (1 commit)Gravatar swiftshader-skia-autoroll2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/596f653f59eb..c8403ec14aaf $ git log 596f653f5..c8403ec14 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 sugoi Fix glBlitFramebuffer validation for BGRA8 IOSurfaces Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=herb@google.com Change-Id: Ie1a520ee9674b2ec436eacff0e832829da109567 Reviewed-on: https://skia-review.googlesource.com/128644 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* SkImage::onRefEncoded to return sk_sp.Gravatar Ben Wagner2018-05-16
| | | | | | | | | | | | This changes SkImage::onRefEncoded and downstack calls to return sk_sp. All of the values returned are already sk_sp, so this just updates the API. This change is currently behind the new flag SK_IGNORE_SKIMAGE_ONREFENCODED_CHANGE so that Chromium can be updated. Change-Id: Ic53a88ae23fa8b3b41b84c4abdc4b74e9879da38 Reviewed-on: https://skia-review.googlesource.com/128311 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Driver bug workaround: gl_clear_brokenGravatar Adrienne Walker2018-05-16
| | | | | | | | | | | | | Skia does not appear to use depth buffers and this appears to be identical to ClearFramebufferResourceManager::ClearFramebuffer in Chromium code. Therefore, just hook up this workaround to turn on these internal Skia workarounds. Bug: chromium: 829614 Change-Id: Icc5f2eb981e39ffef487efa16940d2e50cdbc399 Reviewed-on: https://skia-review.googlesource.com/127220 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org>
* Roll third_party/externals/swiftshader/ e475674ef..596f653f5 (1 commit)Gravatar swiftshader-skia-autoroll2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/e475674ef6e1..596f653f59eb $ git log e475674ef..596f653f5 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 sugoi Fixed atan corner case Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=herb@google.com Change-Id: Ie9f4f83d9ba24e7014e20cff944b8e86aae991a0 Reviewed-on: https://skia-review.googlesource.com/128620 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Driver bug workaround: restore_scissor_on_fbo_changeGravatar Adrienne Walker2018-05-16
| | | | | | | | Bug: chromium: 829614 Change-Id: I333aed9a378ab9b7aafaa96bb495378d1db4a61d Reviewed-on: https://skia-review.googlesource.com/127118 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Remove problematic pre-allocations when deserializingGravatar Kevin Lubick2018-05-16
| | | | | | | | | | | The fuzzer would frequently OOM on these. Bug: skia:7937 Change-Id: I5e6a7dabeca327452f774100c9db05cd6be4cb06 Reviewed-on: https://skia-review.googlesource.com/128551 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Fix compiler warning for MSVCGravatar Herb Derby2018-05-16
| | | | | | | | | BUG=skia:7954 Change-Id: I2b100f723a88a57aaa4de08860f40ab73b9b674f Reviewed-on: https://skia-review.googlesource.com/128580 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Roll skia/third_party/skcms e040063..a7e79c5 (2 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/e040063..a7e79c5 2018-05-16 mtklein@chromium.org try yet again to fix gauss-newton stepping 2018-05-16 mtklein@chromium.org add clang.O0 build The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: I63a0ed3f912f69b114e3100ea44311f478563d3a Reviewed-on: https://skia-review.googlesource.com/128475 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll skia/third_party/skcms ce2fabc..e040063 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/ce2fabc..e040063 2018-05-16 mtklein@chromium.org spin off Curve.[ch] The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: Ie9571b17589849e55d2db079f38c40ba5a8fede4 Reviewed-on: https://skia-review.googlesource.com/128465 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add MacBookPro11,5 jobs.Gravatar Ben Wagner2018-05-16
| | | | | | | | | Bug: chromium:807743 Change-Id: Iafd826c97ceaee745a70bdb1cb52f3cf9f6c1ebf No-Try: true Reviewed-on: https://skia-review.googlesource.com/116461 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix capitalization of "twitter" in RecreateSKPs botGravatar Ravi Mistry2018-05-16
| | | | | | | | | | | Case has suddenly started to matter. NoTry: true Bug: skia:7917 Change-Id: I6020622bd12481a2ac291caf565632451a3c8da5 Reviewed-on: https://skia-review.googlesource.com/128480 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Run RecreateSKPs bot on SkiaCT pool which has more disk spaceGravatar Ravi Mistry2018-05-16
| | | | | | | | | | Should not take up much capacity since it only runs once a day. Bug: skia:7917 Change-Id: I6e489341032ef40df8cedae4e92c5f00d9a2df91 Reviewed-on: https://skia-review.googlesource.com/128405 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* check for too-big rects, as we do for pathsGravatar Mike Reed2018-05-16
| | | | | | | | Bug: oss-fuzz:8334 Change-Id: Ibeeb8adfbfa543406da4b42aa742a6290bd65509 Reviewed-on: https://skia-review.googlesource.com/128541 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* [recipes] Normalize SwiftShader build dirGravatar Eric Boren2018-05-16
| | | | | | | | Bug: skia:6473 Change-Id: If145e2c29ddafdafaf9b8ed3fecbd6a6de31ac0a Reviewed-on: https://skia-review.googlesource.com/128481 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Use Chromium ToT instead of lkcrGravatar Ravi Mistry2018-05-16
| | | | | | | | | | | | https://chromium.googlesource.com/chromium/src/+/lkcr has not been updated in months now. CT uses Chromium ToT and has rarely run into problems because of that. Bug: skia:7917 Change-Id: I007b8f29b2320ffbc45ab5c5a75b081fbb8d7afa Reviewed-on: https://skia-review.googlesource.com/128319 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Reland "Reland "remove obsolete color defines""Gravatar Cary Clark2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d286aa73f13ee10d778381c20d4f0c7dd4bfa354. Reason for revert: fuchsia has rolled forward Original change's description: > Revert "Reland "remove obsolete color defines"" > > This reverts commit 05cfcff70ced3af834e0c9c5309f98bd6662f851. > > Reason for revert: breaks flutter > > Original change's description: > > Reland "remove obsolete color defines" > > > > This reverts commit 3155d9c912ec71c95d8f210d86a1c6deba0f78d9. > > > > Reason for revert: pdfium bots are no more > > > > Original change's description: > > > Revert "remove obsolete color defines" > > > > > > This reverts commit 8afbecbcc05412fadc66cc9d29955064145b8ba5. > > > > > > Reason for revert: broke pdfium > > > > > > Original change's description: > > > > remove obsolete color defines > > > > > > > > The uses in Skia, Chrome, and Google3 have already > > > > been removed. If I missed one or more, please let > > > > me know (and feel free to revert). > > > > > > > > TBR=reed@google.com,brianosman@google.com > > > > Bug: skia:6898 > > > > Change-Id: I9d15b1a06f5abfc3a0fc6f3f1b4d348916c3d362 > > > > Reviewed-on: https://skia-review.googlesource.com/124840 > > > > Reviewed-by: Cary Clark <caryclark@skia.org> > > > > Commit-Queue: Cary Clark <caryclark@skia.org> > > > > Auto-Submit: Cary Clark <caryclark@skia.org> > > > > > > TBR=brianosman@google.com,reed@google.com,caryclark@skia.org > > > > > > Change-Id: Ic7c1003261cda5dee80e222da123c6717b4ea707 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: skia:6898 > > > Reviewed-on: https://skia-review.googlesource.com/124880 > > > Reviewed-by: Cary Clark <caryclark@skia.org> > > > Commit-Queue: Cary Clark <caryclark@skia.org> > > > > TBR=brianosman@google.com,reed@google.com,caryclark@skia.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: skia:6898 > > Change-Id: I3605fa0ebb2bfecc26d198e9de008c82d31d747b > > Reviewed-on: https://skia-review.googlesource.com/126001 > > Reviewed-by: Cary Clark <caryclark@google.com> > > Commit-Queue: Cary Clark <caryclark@google.com> > > TBR=brianosman@google.com,caryclark@google.com,reed@google.com,caryclark@skia.org > > Change-Id: I469794b86487322c385e50275d548c1895c30cff > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:6898 > Reviewed-on: https://skia-review.googlesource.com/126040 > Reviewed-by: Cary Clark <caryclark@google.com> > Commit-Queue: Cary Clark <caryclark@google.com> TBR=brianosman@google.com,caryclark@google.com,reed@google.com,caryclark@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:6898 Change-Id: I03bd75d28dfad86455b48dea7930bebc95bf82d3 Reviewed-on: https://skia-review.googlesource.com/128500 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* [docker] Move to testing-slim as the base image.Gravatar Joe Gregorio2018-05-16
| | | | | | | | | | Also clean out more unneeded packages. Bug: skia: Change-Id: Iae642c8878e6d65cda0862e92a881b54634f8f30 Reviewed-on: https://skia-review.googlesource.com/128409 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* [recipes] Move 'gclient runhooks' from flutter build to coreGravatar Eric Boren2018-05-16
| | | | | | | | Bug: skia:6473 Change-Id: I89b384668a6a45eaae9995ad8f7b404a1b7f9824 Reviewed-on: https://skia-review.googlesource.com/128318 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Fix UBSAN warnings in SkPerlinNoiseShaderImplGravatar Kevin Lubick2018-05-16
| | | | | | | | | | Also update the docs in places. Bug: oss-fuzz:6138, oss-fuzz:6275, oss-fuzz:6118 Change-Id: Idfef4118dd6e58f8aa528365895f7d7b8ebc50e5 Reviewed-on: https://skia-review.googlesource.com/128300 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Roll third_party/externals/angle2/ 10e7e5013..80c32ccbb (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/10e7e5013c41..80c32ccbbcc6 $ git log 10e7e5013..80c32ccbb --date=short --no-merges --format='%ad %ae %s' 2018-04-25 jiawei.shao ES31: Add extra transform feedback rules in EXT_geometry_shader Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=herb@google.com Change-Id: I8698114728cc634f97d030dc3b2d567081c66c46 Reviewed-on: https://skia-review.googlesource.com/128460 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Documentation refreshGravatar Cary Clark2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | - add links to types within methods - add check to see that all references and definitions match - add style to tables to make them easier to read - use https everywhere - remove trailing spaces - move overview inside class - split class and struct in summary tables - add missing #Line - clean up SkImageInfo constant documentation - work on SkColor documentation - allow common phrases to take different parameters - add more flexibility to generated tables - tighten token parent requirements - generalize deprecated and example interfaces - detect inner constructors R=caryclark@google.com Docs-Preview: https://skia.org/?cl=121799 Bug: skia:6898 Change-Id: Ia75a23740b80259460916890b310e2a9f024962a Reviewed-on: https://skia-review.googlesource.com/121799 Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Roll third_party/externals/angle2/ 2a849bf31..10e7e5013 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/2a849bf31162..10e7e5013c41 $ git log 2a849bf31..10e7e5013 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 geofflang Don't double-terminate a display. 2018-05-15 geofflang Add dEQP EGL expectations OpenGL on Windows. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=herb@google.com Change-Id: Iec08683b55be7f22a037b63fe1d65744365766ce Reviewed-on: https://skia-review.googlesource.com/128441 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "Check atlasPageCount before accessing the proxy array"Gravatar Yuqian Li2018-05-15
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 072c69cad3b50ba3d04ba7a7d6c9dbec50c1cd4f. Reason for revert: 3000+ seemingly bad gold differences and flutter breakage Original change's description: > Check atlasPageCount before accessing the proxy array > > Bug: skia: > Change-Id: Ib4bca46ea105285f4edea05d78ea4d9ea047d0df > Reviewed-on: https://skia-review.googlesource.com/128295 > Reviewed-by: Jim Van Verth <jvanverth@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=jvanverth@google.com,csmartdalton@google.com Change-Id: Ia568b3884101aeda46e94ef8c6144da3479bc50d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/128420 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* fonts: Fix memory accounting for deserialized glyphs.Gravatar Khushal2018-05-15
| | | | | | | | | | | | | | | When deserializing glyphs in the SkRemoteGlyphCache, we allocate from the arena for the SkGlyphCache but don't account for it in the total memory used by the cache. Fix that and avoid exposing the SkArenaAlloc from SkGlyphCache, since that can result in such brittle use. R=herb@google.com Bug: 829622 Change-Id: Iecff9ce6e0ed2c641957535363edec3e3fad178d Reviewed-on: https://skia-review.googlesource.com/128112 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
* [docker] Add Dockerfile that builds skiaserve.Gravatar Joe Gregorio2018-05-15
| | | | | | | | | Bug: skia: Change-Id: If43c546fd7909329a015302580bc50925f4b7630 Reviewed-on: https://skia-review.googlesource.com/128313 Commit-Queue: Joe Gregorio <jcgregorio@google.com> Auto-Submit: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Driver bug workaround: max_msaa_sample_count_4Gravatar Adrienne Walker2018-05-15
| | | | | | | | Bug: chromium: 829614 Change-Id: I54054191815ace6159585dab7dd811ebdc863095 Reviewed-on: https://skia-review.googlesource.com/126983 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Driver bug workaround: disallow_large_instanced_drawGravatar Adrienne Walker2018-05-15
| | | | | | | | Bug: chromium: 829614 Change-Id: I3c64cd360674f08b4ca3c4a2d0ef946e40a5c60a Reviewed-on: https://skia-review.googlesource.com/126751 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* remove typedef InfoGravatar Cary Clark2018-05-15
| | | | | | | | | | | | | | | | | | typedef SkImageInfo Info saves a little typing at the cost of obfuscating the parameter type. It's only used in a couple of places so remove it. The documentation catalog has gotten a bit stale, so update that as well. Docs-Preview: https://skia.org/?cl=128400 Bug: skia:6898 Change-Id: I621743a2b2d9a78d5f62742501eebf5f4327efa0 Reviewed-on: https://skia-review.googlesource.com/128400 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add a vknostencils configGravatar Chris Dalton2018-05-15
| | | | | | | | Bug: skia: Change-Id: Id4781799ba0b30b01a60788afc235fd6134516cf Reviewed-on: https://skia-review.googlesource.com/128380 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll skia/third_party/skcms 14c31bf..ce2fabc (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-15
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/14c31bf..ce2fabc 2018-05-15 brianosman@google.com Ignore srcAlpha when the input is CMYK The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: I32b52c1b555778c72d8038da698c26fb6c3585c0 Reviewed-on: https://skia-review.googlesource.com/128299 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Check atlasPageCount before accessing the proxy arrayGravatar Chris Dalton2018-05-15
| | | | | | | | Bug: skia: Change-Id: Ib4bca46ea105285f4edea05d78ea4d9ea047d0df Reviewed-on: https://skia-review.googlesource.com/128295 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Scrub SkPictureData/SkPictureRecordGravatar Florin Malita2018-05-15
| | | | | | | | | | | | | | - replace manual ref fiddling with smart types - remove unused SkPictureData::fBitmapImageRefs - remove the preallocation in new_array_from_buffer (to prevent fuzzer OOMs) Bug: skia:7937 Change-Id: I50f49fa8e594a138ea09c22f7bf73cf57ec006ff Reviewed-on: https://skia-review.googlesource.com/128309 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Driver bug workaround: max_texture_size_limit_4096Gravatar Adrienne Walker2018-05-15
| | | | | | | | Bug: chromium: 829614 Change-Id: I127157fa04df2ec6505411aa42f1232910e251d4 Reviewed-on: https://skia-review.googlesource.com/126608 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-12 06:44:30 +0000