aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Revert of Update version of SVG asset (patchset #1 id:1 of ↵Gravatar djsollen2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2341043003/ ) Reason for revert: breaking the build Original issue's description: > Update version of SVG asset > > BUG=skia:5757 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003 > > Committed: https://skia.googlesource.com/skia/+/ab00f4222c9fff8c08873e1218e79f49845f95a1 TBR=borenet@google.com,rmistry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5757 Review-Url: https://codereview.chromium.org/2337763007
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot Review-Url: https://codereview.chromium.org/2340463008
* Update version of SVG assetGravatar rmistry2016-09-15
| | | | | | | BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003 Review-Url: https://codereview.chromium.org/2341043003
* Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of ↵Gravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2340463008/ ) Reason for revert: https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304 Original issue's description: > GN: support 32-bit x86 builds > > Take over Ubuntu -x86- bots. > > Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. > We'll want target_cpu="x86" there too. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 > > Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 TBR=jcgregorio@google.com,borenet@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2338173004
* Add storage and computation of SkColor4f version of gradient stops.Gravatar brianosman2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | For now, we still only have the SkColor factory, but the Descriptor can now carry either an SkColor or SkColor4f specified gradient. Base class constructor automatically populates both forms of color, so that legacy raster backend will continue to work, and new backend work can operate directly from the float4 version. On the GPU side, we have similar logic, but GrGradientEffect only keeps one version of colors around: SkColor if the destination is legacy, and SkColor4f (with an optional gamut xform) if the destination is gamma correct. The 4f colors are already linear, and we gamut xform them in setData, so gradients are now fully color-correct in sRGB and F16 modes... ... unless there are more than three stops. Then we use a texture, and that code path isn't handled yet. We have a few choices here (do we use an 8-bit sRGB atlas, or just always use F16 linear atlas so we can share it among both sRGB and wide-gamut rendering). In any case, I'd like to defer that to a second CL. This change does fix the non-texture gradients in the gamut GM. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337313002 Review-Url: https://codereview.chromium.org/2337313002
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Review-Url: https://codereview.chromium.org/2340463008
* Blacklist slsrgb + image decoding.Gravatar mtklein2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345723003 Review-Url: https://codereview.chromium.org/2345723003
* Revert of SkFontData to use smart pointers. (patchset #3 id:40001 of ↵Gravatar bungeman2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2339273002/ ) Reason for revert: Killing Mac Original issue's description: > SkFontData to use smart pointers. > > The SkFontData type is not exposed externally, so any method which uses > it can be updated to use smart pointers without affecting external > users. Updating this first will make updating the public API much > easier. > > This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to > std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It > appears that no one outside Skia is currently using SkStream::NewfromFile > so this is a good time to update it as well. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 > > Committed: https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c TBR=mtklein@chromium.org,halcanary@google.com,mtklein@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2343933002
* GN: link executables with -rdynamic on Linux.Gravatar mtklein2016-09-15
| | | | | | | | | -rdynamic makes sure the executable exposes all its symbols, which allows things like DM's built-in stack trace dumper to show symbols instead of just addresses. We do this in GYP too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339983005 Review-Url: https://codereview.chromium.org/2339983005
* SkFontData to use smart pointers.Gravatar bungeman2016-09-15
| | | | | | | | | | | | | | | | The SkFontData type is not exposed externally, so any method which uses it can be updated to use smart pointers without affecting external users. Updating this first will make updating the public API much easier. This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It appears that no one outside Skia is currently using SkStream::NewfromFile so this is a good time to update it as well. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 Review-Url: https://codereview.chromium.org/2339273002
* simple fix?Gravatar mtklein2016-09-15
| | | | | | | | | Scope cmdInfo more tightly to where it's not a null reference. BUG=skia:5759 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342063002 Review-Url: https://codereview.chromium.org/2342063002
* Add ability to create and upload SVGs from a local dirGravatar rmistry2016-09-15
| | | | | | | BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346663003 Review-Url: https://codereview.chromium.org/2346663003
* Fix NoGPU bot, which is compiling in GPU supportGravatar borenet2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342683003 Review-Url: https://codereview.chromium.org/2342683003
* Remove the unused 16-bit gradient cacheGravatar brianosman2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343863002 Review-Url: https://codereview.chromium.org/2343863002
* More NoGPU compile fixesGravatar brianosman2016-09-15
| | | | | | | | | I can now build 'most' with skia_gpu=0 on my machine. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340133003 Review-Url: https://codereview.chromium.org/2340133003
* Pass rietveld as the default patch_storage.Gravatar mtklein2016-09-15
| | | | | | | | | | | | Passing around empty strings as command line arguments requires us to be really careful about command line quoting, parsing, etc. It seems easy enough here to just supply the implied value. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003 Review-Url: https://codereview.chromium.org/2323233003
* quad and conic do not intersectGravatar caryclark2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a quad a conic intersect only where the end of one is contained by the convex hull of the other, and the curve contained by the hull is nearly a straight line, treating it as a line may move the end point to the other side of the curve. Detect this by checking to see if the end point is in the hull, and if so, continue to subdivide the curve rather than treating it as a line. This fixes several existing tests that were disabled earlier this year. A typo in SkDCurve::nearPoint() prevented detecting when the end of a line was nearly touching a curve. Also fixed concidence a bit to get the second half of tiger further along. All existing tests, including extended testing in Release and the first half of tiger, work. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338323002 Review-Url: https://codereview.chromium.org/2338323002
* Remove "f" suffix from literal in LCD DF text shader.Gravatar bsalomon2016-09-15
| | | | | | | Also improve DF GP names GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340603003 Review-Url: https://codereview.chromium.org/2340603003
* Fix SampleApp compilation with skia_gpu=0Gravatar brianosman2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347593002 Review-Url: https://codereview.chromium.org/2347593002
* add helpers for using SkData with picture serializationGravatar reed2016-09-15
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341693004 TBR= Review-Url: https://codereview.chromium.org/2341693004
* Bundle common arguments to GrGradientEffect creationGravatar brianosman2016-09-15
| | | | | | | | | | | I'm going to be adding more (to deal with color spaces), so trying to fix this before it gets out of control. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007 Committed: https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd Review-Url: https://codereview.chromium.org/2332213007
* Tidy up DM blacklists.Gravatar mtklein2016-09-15
| | | | | | | | | | | No need to blacklist specific instances of configs that won't be run. There's no bug or anything here... this is entirely about keeping the command lines as noise-free as possible. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341963003 Review-Url: https://codereview.chromium.org/2341963003
* Roll recipe DEPSGravatar rmistry2016-09-15
| | | | | | | | BUG=skia:5749 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2339443003
* Clean up unused SkPictureRecorder::optimizeFor()Gravatar mtklein2016-09-15
| | | | | | | | | | | Don't worry about the failing Shield bot... unrelated experiment. It's failing at head. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340133002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2340133002
* Revert of Bundle common arguments to GrGradientEffect creation (patchset #2 ↵Gravatar djsollen2016-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/2332213007/ ) Reason for revert: This seems to be causing the autoroll into Chromium to fail. https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/69618/steps/compile/logs/stdio Original issue's description: > Bundle common arguments to GrGradientEffect creation > > I'm going to be adding more (to deal with color spaces), so trying to fix > this before it gets out of control. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007 > > Committed: https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2343703003
* Fix SkDrawTextBlobCommand null blob crashGravatar fmalita2016-09-14
| | | | | | | | | | After https://codereview.chromium.org/2335493005, we're moving the param into a local field -> we should no longer access it. TBR=robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344523003 Review-Url: https://codereview.chromium.org/2344523003
* Update GN droid scriptGravatar egdaniel2016-09-14
| | | | | | | | | | | | Splits the pushes into different lines since old adbs cannot handle the one line command TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339293002 Review-Url: https://codereview.chromium.org/2339293002
* [SVGDom] Expose intrinsic size infoGravatar fmalita2016-09-14
| | | | | | | | | | | | | | * expose intrinsic size info on <svg> nodes. * tweak the SkSVGDOM constructor to no longer take an container size param, but instead default to intrinsic size * update clients to call SkSVGDOM::setContainerSize() explicitly, when needed R=robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345533002 Review-Url: https://codereview.chromium.org/2345533002
* Don't let the compiler complain that |a| is uninitGravatar msarett2016-09-14
| | | | | | | | | TBR=mtklein@google.com NOTRY=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339793003 Review-Url: https://codereview.chromium.org/2339793003
* Disable ignore discard optimization in VulkanGravatar egdaniel2016-09-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346553002 Review-Url: https://codereview.chromium.org/2346553002
* CQ updateGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | | | | - swap the N5 experiment over to the new GN N5 bot - cut down on the Windows build duplication: the other two bots cover x86, x86-64, Release, Debug, _and_ Vulkan already. - remove the Release-Shared tester: I added this bot to act as a proxy for the also Shared-build Android bots, but 1) they're fast enough to no longer need a proxy (see N5 above) and 2) they're no longer Shared builds. I intend to completely drop support for dm and nanobench in Shared builds, so this bot will not just drop from the CQ but completely disappear. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346463002 Review-Url: https://codereview.chromium.org/2346463002
* GN: add is_official_buildGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | ... and use it to control debug symbols and SK_ALLOW_STATIC_GLOBAL_INITIALIZERS. This will most directly have the effect of disabling GLProgramsTest and a bunch of similar failing Vk tests on Android. Hopefully this makes the N7 trybot go green, keeping the N5 trybot green. Just running the N10 for fun. (is_official_build is how Chrome terms this sort of ReleaseForReal build.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340723003 Review-Url: https://codereview.chromium.org/2340723003
* merge run and check-rc stepsGravatar mtklein2016-09-14
| | | | | | | | | | | This'll make the 'dm' or 'nanobench' step go red like you'd hope. The N5 should pass and the N10 and N7 should fail, showing us both sides. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003 Review-Url: https://codereview.chromium.org/2339713003
* Store SkColorSpaceXform gamma LUTs in a malloced fieldGravatar msarett2016-09-14
| | | | | | | | | | | | | | | | | | In order of likelihood: (1) Tables are never used, since gamma is recognized and named. (2) Only use one table, since all three gammas are the same. (3) Actually need three tables. No reason to waste a bunch of space for these tables on SkColorSpaceXform, when it will likely be unused. This will be more efficient in lots of cases, but is particularly useful when the client really only wants a gamut xform. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336913005 Review-Url: https://codereview.chromium.org/2336913005
* 565 is not this important.Gravatar mtklein2016-09-14
| | | | | | | | | | Reduce its testing and perfing to just the fast Linux bots, and remove it from the default set of dm/nanobench configs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002 Review-Url: https://codereview.chromium.org/2344553002
* Convert back to 0-255 scale before storing linear bytesGravatar msarett2016-09-14
| | | | | | | | TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338203005 Review-Url: https://codereview.chromium.org/2338203005
* Improved optional command handling in SkParsePath::FromSVGString()Gravatar fmalita2016-09-14
| | | | | | | | | | | | | | | | Repeating command letters are optional in SVG path data strings: https://www.w3.org/TR/SVG/paths.html#PathData FromSVGString() already supports this feature, but only checks for scalars prefixes == (digit | '-' | '+'). A decimal point is also a valid scalar prefix though, so it should be included in the test. R=caryclark@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339813003 Review-Url: https://codereview.chromium.org/2339813003
* Bundle common arguments to GrGradientEffect creationGravatar brianosman2016-09-14
| | | | | | | | | | I'm going to be adding more (to deal with color spaces), so trying to fix this before it gets out of control. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007 Review-Url: https://codereview.chromium.org/2332213007
* Fix SVG flag iOS linkingGravatar fmalita2016-09-14
| | | | | | | TBR=mtklein@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344533002 Review-Url: https://codereview.chromium.org/2344533002
* Nanobench SVG supportGravatar fmalita2016-09-14
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339743002 Review-Url: https://codereview.chromium.org/2339743002
* Rewriting path writerGravatar caryclark2016-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | The path writer takes constructs the output path out of curves that satisfy the pathop operation. Curves contain lists of t/point pairs that may not be comparable to each other. To match up curve ends in the output path, look for adjacent curves to have a shared membership rather than comparing point values. Use path utilities to connect partial curve lists into closed contours. Share the angle code that determines if a curve has become a degenerate line with the path writer. Clean up some code on the way, and delete some unused functions. TBR=reed@google.com BUG=5188 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321973005 Review-Url: https://codereview.chromium.org/2321973005
* Reduce overhead for linear color xformsGravatar msarett2016-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We used to build src and dst transfer fn tables every time a new xform was created with linear src and dst. Now we don't compute them because we don't need them. This will make SkColorSpaceXform a far better option for any xforms with float or half-float inputs or outputs, particularly on a small number of pixels. This CL also moves SkColorSpaceXform closer to what I anticipate will be the eventual 'API design'. I think apply() will want to take a SrcColorType enum (not created yet because it's not necessary yet) and a DstColorType enum (still using SkColorType because there's not yet a reason not to). Performance changes: toSRGB 341us -> 366us to2Dot2 404us -> 403us toF16 318us -> 304us There's no reason for toSRGB or to2Dot2 to change. The refactor seems to have caused the compiler to order the instructions a little differently... This is something to come back to if we need to squeeze more performance out of sRGB. For now, let's not be held up by something we don't control. F16 likely improves because we are no longer (unnecessarily) building the linear tables. Code size gets a little bigger. Measuring SkColorSpaceXform size as a percentage of src/ size, we go from 0.8% to 1.4%. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335723002 Review-Url: https://codereview.chromium.org/2335723002
* Switch default for SkGaussianBlurShader radius size.Gravatar jvanverth2016-09-14
| | | | | | | | One step towards removing the 6.2 radius entirely. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333403002 TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2333403002
* GN: Android Vulkan supportGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | | | Android's the easiest place to start supporting Vulkan, so it's up first. ndk_api becomes user-specifiable so that the Vulkan bots can kick it up to 24, the first release supporting Vulkan. The defaults remain the same: 18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit. To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then $ ninja -C out dm; and droid out/dm --config vk --src gm Seems to work! Bot scripts to follow. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002 Review-Url: https://codereview.chromium.org/2336343002
* update derive_compile_bot_name() for GN_Android_VulkanGravatar mtklein2016-09-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336233005 Review-Url: https://codereview.chromium.org/2336233005
* Android GN scripts: distingush directories for data and binaries.Gravatar mtklein2016-09-14
| | | | | | | | | This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004 Review-Url: https://codereview.chromium.org/2335203004
* change write-image to use pipeverbs like everyone else, and add testGravatar reed2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335973003 Review-Url: https://codereview.chromium.org/2335973003
* re-add SkDebug_stdio for Fuchsia buildsGravatar mikejurka2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2331383004 Review-Url: https://codereview.chromium.org/2331383004
* Simulated fonts aren't TrueType fonts.Gravatar bungeman2016-09-13
| | | | | | | | | | | | Some font back-ends provide simulated fonts such as fake bold or fake oblique. These fonts should not be reported as TrueType, since the font data isn't what is actually used to draw the glyphs. BUG=chromium:639198 BUG=chromium:614612 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333423002 Review-Url: https://codereview.chromium.org/2333423002
* [SVGDom] Linear gradient 'gradientTransform' supportGravatar fmalita2016-09-13
| | | | | | | R=stephana@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339533002 Review-Url: https://codereview.chromium.org/2339533002
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-15 23:30:51 +0000