aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Make GrConvexPolyEffect support inverse fills and non-AA rectsGravatar commit-bot@chromium.org2014-02-28
| | | | | | | | | | | BUG=skia:2151 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/183833003 git-svn-id: http://skia.googlecode.com/svn/trunk@13621 2bbb7eff-a529-9590-31e7-b0007b416f81
* add new onClip* methods to SkCanvasGravatar robertphillips@google.com2014-02-28
| | | | | | | | https://codereview.chromium.org/183453002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13620 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-28
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13619 2bbb7eff-a529-9590-31e7-b0007b416f81
* Modify how gpu.gyp includes angle.gyp.Gravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | | | | | | | | Instead of including dependencies on angle.gyp and then removing them if skia_angle is not true, only include angle.gyp to begin with skia_angle is true. This allows gyp_to_android.py to work when run in the Android tree, where we don't have third_party/externals (since we do only a git merge, and no gclient sync. R=djsollen@google.com, robertphillips@google.com, bsalomon@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/178223015 git-svn-id: http://skia.googlecode.com/svn/trunk@13618 2bbb7eff-a529-9590-31e7-b0007b416f81
* add SkCanvas::NewRaster factory -- a very common use-case in chromeGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/183533004 git-svn-id: http://skia.googlecode.com/svn/trunk@13617 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add GrSet class built on top of RedBlackTreeGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/176903003 git-svn-id: http://skia.googlecode.com/svn/trunk@13616 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rename Path to Path2DGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/177963005 git-svn-id: http://skia.googlecode.com/svn/trunk@13615 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use chromium's gyp if third_party is not available.Gravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | | | This is for building Android.mk inside an Android tree where there is no third_party directory. R=djsollen@google.com, epoger@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/177073022 git-svn-id: http://skia.googlecode.com/svn/trunk@13614 2bbb7eff-a529-9590-31e7-b0007b416f81
* replace gm_fprintf() calls with SkDebugf()Gravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | BUG=skia:1221 R=bsalomon@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/181933002 git-svn-id: http://skia.googlecode.com/svn/trunk@13613 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: fix "Results current as of <timestamp>" bannerGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | | | | | (SkipBuildbotRuns) BUG=skia:2232 NOTREECHECKS=True NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/183523002 git-svn-id: http://skia.googlecode.com/svn/trunk@13612 2bbb7eff-a529-9590-31e7-b0007b416f81
* Culling APIGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** SKP format breaking change *** Adding a couple of culling primitives: pushCull(SkRect) & popCull(). These are currently only plumbed for SKP playback quickreject. At record time, we perform a couple of optimizations to trim down the number of redundant culls: * collapse empty pushCull/popCull pairs * skip pushCull/popCull pairs nested within an identical cull rect Things still missing/to consider: * use an inlineable, simplified quickreject (Mike's old prototype) * debugger visualization for cull boxes * BBH integration: the initial prototype had some minimal BBH support, but since the optimizations required expensive rewinds and culling is expected to be a BBH alternative, it got dropped. R=bsalomon@google.com, reed@google.com, robertphillips@google.com, caryclark@google.com, tomhudson@google.com, iancottrell@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/138013009 git-svn-id: http://skia.googlecode.com/svn/trunk@13611 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use SkTLazy to hold path in SkClipStack::ElementGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | R=reed@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/178583002 git-svn-id: http://skia.googlecode.com/svn/trunk@13610 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move SkV8Example to SkSurfaceGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/148523019 git-svn-id: http://skia.googlecode.com/svn/trunk@13609 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to verify build fixGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | | | R=rmistry@google.com TBR=rmistry NOTREECHECKS=true NOTRY=true Author: borenet@google.com Review URL: https://codereview.chromium.org/180843013 git-svn-id: http://skia.googlecode.com/svn/trunk@13608 2bbb7eff-a529-9590-31e7-b0007b416f81
* try to deprecate fFlagsMask from SkLayerDrawLooperGravatar reed@google.com2014-02-27
| | | | | | | | | | | | | | | We think we want to move around how flags/fields like linearText and strikeThru are specified. SkPaint has helpers for nearly all of these, but LayerInfo in the draw looper just exposes the raw bitfield. On survey of chrome/android, it appears that no one uses those, so it may be safe to just remove the feature entirely from the looper. R=bungeman@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/181433009 git-svn-id: http://skia.googlecode.com/svn/trunk@13607 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test CQGravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | | | (SkipBuildbotRuns) TBR= BUG=skia: NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/183073002 git-svn-id: http://skia.googlecode.com/svn/trunk@13606 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factory methods for heap-allocated SkAnnotation objects.Gravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | | | | | | | This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkAnnotation non-public and instead provides factory methods for creating these objects on the heap. BUG=skia:2187 R=reed@google.com, mtklein@google.com, scroggo@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/181703003 git-svn-id: http://skia.googlecode.com/svn/trunk@13605 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-27
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13604 2bbb7eff-a529-9590-31e7-b0007b416f81
* DM: also run benches once.Gravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | | | | | | | Also: - make GrMemoryPoolBenches threadsafe - some tweaks to various DM code - rename GM::shortName() to getName() to match benches and tests On my desktop, (289 GMs, 617 benches) x 4 configs, 227 tests takes 46s in Debug, 14s in Release. (Still minutes faster than running tests && bench && gm.) GPU singlethreading is definitely the limiting factor again; going to reexamine whether that's helpful to thread it again. BUG=skia: R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/178473006 git-svn-id: http://skia.googlecode.com/svn/trunk@13603 2bbb7eff-a529-9590-31e7-b0007b416f81
* BlendTest: implicit casts -> explicit castsGravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | | | BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13595 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/181503003 git-svn-id: http://skia.googlecode.com/svn/trunk@13602 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add point count to lua SkPath.Gravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | Add some scripts for classifying rrects and counting complex clip combinations. R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/181843004 git-svn-id: http://skia.googlecode.com/svn/trunk@13601 2bbb7eff-a529-9590-31e7-b0007b416f81
* Upstream changes from AndroidGravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | R=scroggo@google.com, reed@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/176963003 git-svn-id: http://skia.googlecode.com/svn/trunk@13600 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert of Add getReducedClipStack to lua canvas ↵Gravatar bsalomon@google.com2014-02-26
| | | | | | | | | | | | (https://codereview.chromium.org/180283004/)" This reverts commit efded03a38d6147caaf2d951638d27fdd47eed64. Fixes builds Review URL: https://codereview.chromium.org/181903002 git-svn-id: http://skia.googlecode.com/svn/trunk@13599 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: use new intermediate JSON format as described in ↵Gravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | | | | | | | | | https://goto.google.com/ChangingRbsJson There are still some places in the frontend (HTML+Javascript) code where we assume we are handling expectations vs actuals, but there are just a few and we should be able to remove them easily in a coming CL. At that point, the frontend will work just as well for displaying any set of image pairs. BUG=skia:1919 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/178253010 git-svn-id: http://skia.googlecode.com/svn/trunk@13598 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Add getReducedClipStack to lua canvas ↵Gravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/180283004/) Reason for revert: breaking a bunch of builds Original issue's description: > Add getReducedClipStack to lua canvas > > Committed: http://code.google.com/p/skia/source/detail?r=13594 R=reed@google.com TBR=reed@google.com NOTREECHECKS=true NOTRY=true Author: bsalomon@google.com Review URL: https://codereview.chromium.org/181653004 git-svn-id: http://skia.googlecode.com/svn/trunk@13597 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SampleApp buildGravatar bsalomon@google.com2014-02-26
| | | | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/181833002 git-svn-id: http://skia.googlecode.com/svn/trunk@13596 2bbb7eff-a529-9590-31e7-b0007b416f81
* BlendTest: implicit casts -> explicit castsGravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/181503003 git-svn-id: http://skia.googlecode.com/svn/trunk@13595 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add getReducedClipStack to lua canvasGravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/180283004 git-svn-id: http://skia.googlecode.com/svn/trunk@13594 2bbb7eff-a529-9590-31e7-b0007b416f81
* update comments within expectations/gm/ignored-tests.txtGravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | | | (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True R=reed@android.com TBR=reed Author: epoger@google.com Review URL: https://codereview.chromium.org/179023004 git-svn-id: http://skia.googlecode.com/svn/trunk@13593 2bbb7eff-a529-9590-31e7-b0007b416f81
* Let DM run unit tests.Gravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | - refactor GYPs and a few flags - make GPU tests grab a thread-local GrContextFactory when needed as we do in DM for GMs - add a few more UI features to make DM more like tests I believe this makes the program 'tests' obsolete. It should be somewhat faster to run the two sets together than running the old binaries serially: - serial: tests 20s (3m18s CPU), dm 21s (3m01s CPU) - together: 27s (6m21s CPU) Next up is to incorporate benches. I'm only planning there on a single-pass sanity check, so that won't obsolete the program 'bench' just yet. Tested: out/Debug/tests && out/Debug/dm && echo ok BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13586 R=reed@google.com, bsalomon@google.com, mtklein@google.com, tfarina@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/178273002 git-svn-id: http://skia.googlecode.com/svn/trunk@13592 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adjusts one Win7 bench expectation (googlespreadsheetdashed, scalar1.1_gpu).Gravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | | BUG=skia:2163 NOTRY=true R=rmistry@google.com TBR=rmistry@google.com Author: bensong@google.com Review URL: https://codereview.chromium.org/178363012 git-svn-id: http://skia.googlecode.com/svn/trunk@13591 2bbb7eff-a529-9590-31e7-b0007b416f81
* Builder class for SkLayerRasterizer.Gravatar commit-bot@chromium.org2014-02-26
| | | | | | | | | | | | | | | | Provide builder class to make SkLayerRasterizer immutable. We have to keep the addLayer() methods for now because they are used in Chrome. They will be removed once this changed has been rolled into Chrome. An added benefit of this is that this class can only be allocated on the heap. BUG=skia:2187 R=reed@google.com, scroggo@google.com, mtklein@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/176873004 git-svn-id: http://skia.googlecode.com/svn/trunk@13590 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-26
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13589 2bbb7eff-a529-9590-31e7-b0007b416f81
* Check in today's exhaustive blend experiments.Gravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | | BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/179733005 git-svn-id: http://skia.googlecode.com/svn/trunk@13588 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Let DM run unit tests. (https://codereview.chromium.org/178273002/)Gravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reason for revert: broke tests Original issue's description: > Let DM run unit tests. > - refactor GYPs and a few flags > - make GPU tests grab a thread-local GrContextFactory when needed as we do in DM for GMs > - add a few more UI features to make DM more like tests > > I believe this makes the program 'tests' obsolete. > > It should be somewhat faster to run the two sets together than running the old binaries serially: > - serial: tests 20s (3m18s CPU), dm 21s (3m01s CPU) > - together: 27s (6m21s CPU) > > Next up is to incorporate benches. I'm only planning there on a single-pass sanity check, so that won't obsolete the program 'bench' just yet. > > Tested: out/Debug/tests && out/Debug/dm && echo ok > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=13586 R=bsalomon@google.com, mtklein@google.com, tfarina@chromium.org, mtklein@chromium.org TBR=bsalomon@google.com, mtklein@chromium.org, mtklein@google.com, tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/179403010 git-svn-id: http://skia.googlecode.com/svn/trunk@13587 2bbb7eff-a529-9590-31e7-b0007b416f81
* Let DM run unit tests.Gravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | | | | | | | | | | | | | | | - refactor GYPs and a few flags - make GPU tests grab a thread-local GrContextFactory when needed as we do in DM for GMs - add a few more UI features to make DM more like tests I believe this makes the program 'tests' obsolete. It should be somewhat faster to run the two sets together than running the old binaries serially: - serial: tests 20s (3m18s CPU), dm 21s (3m01s CPU) - together: 27s (6m21s CPU) Next up is to incorporate benches. I'm only planning there on a single-pass sanity check, so that won't obsolete the program 'bench' just yet. Tested: out/Debug/tests && out/Debug/dm && echo ok BUG=skia: R=reed@google.com, bsalomon@google.com, mtklein@google.com, tfarina@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/178273002 git-svn-id: http://skia.googlecode.com/svn/trunk@13586 2bbb7eff-a529-9590-31e7-b0007b416f81
* Change comment for inverse_paths GM in ignored-tests.txtGravatar bsalomon@google.com2014-02-25
| | | | | | | | BUG=skia:2222 Review URL: https://codereview.chromium.org/180213002 git-svn-id: http://skia.googlecode.com/svn/trunk@13585 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline extractbitmap GMs, as the test itself changedGravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | | NOTRY=True TBR=bsalomon Author: reed@google.com Review URL: https://codereview.chromium.org/180153002 git-svn-id: http://skia.googlecode.com/svn/trunk@13584 2bbb7eff-a529-9590-31e7-b0007b416f81
* Enable the SSSE3 files to be built for Android when SSSE3 is not present.Gravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | | | Committed: http://code.google.com/p/skia/source/detail?r=13547 R=reed@google.com, mtklein@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/169753004 git-svn-id: http://skia.googlecode.com/svn/trunk@13583 2bbb7eff-a529-9590-31e7-b0007b416f81
* allow skia flags to be specified in a skia file, but reference by chrome's ↵Gravatar reed@google.com2014-02-25
| | | | | | | | | | | | skia_common.gypi in support of https://codereview.chromium.org/180083002/ which will land after this CL is visible in Chrome R=bungeman@google.com Review URL: https://codereview.chromium.org/180063003 git-svn-id: http://skia.googlecode.com/svn/trunk@13582 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline rrect gmsGravatar bsalomon@google.com2014-02-25
| | | | | | Review URL: https://codereview.chromium.org/180113002 git-svn-id: http://skia.googlecode.com/svn/trunk@13581 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix valgrind bot errors introduced in f84722e4777.Gravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | | | NOTREECHECKS=true NOTRY=true R=robertphillips@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/179843003 git-svn-id: http://skia.googlecode.com/svn/trunk@13580 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaselines for https://codereview.chromium.org/177963003/Gravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | | | | | | Signed-off-by: Kévin PETIT <kevin.petit@arm.com> BUG=skia: NOTRY=true NOTREECHECKS=true R=djsollen@google.com, mtklein@google.com Author: kevin.petit@arm.com Review URL: https://codereview.chromium.org/179723004 git-svn-id: http://skia.googlecode.com/svn/trunk@13579 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline canvas-layer-state (PDF only).Gravatar senorblanco@chromium.org2014-02-25
| | | | | | | | | | Remove expectations for now-passing tests. TBR=reed@google.com Review URL: https://codereview.chromium.org/179403007 git-svn-id: http://skia.googlecode.com/svn/trunk@13578 2bbb7eff-a529-9590-31e7-b0007b416f81
* ARM Skia NEON patches - 25 - S32A_D565_Opaque_Dither clean/bugfix/speedGravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | | | | | | | | | | | BlitRow565: S32A_D565_Opaque_Dither: some improvements - Supports ARGB and ABGR - Less magic numbers - Reduced instruction count : 5-25% speedup - Fixed indentation, removed some commented and useless code Signed-off-by: Kévin PETIT <kevin.petit@arm.com> BUG=skia: R=djsollen@google.com, mtklein@google.com Author: kevin.petit@arm.com Review URL: https://codereview.chromium.org/177963003 git-svn-id: http://skia.googlecode.com/svn/trunk@13577 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-25
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13576 2bbb7eff-a529-9590-31e7-b0007b416f81
* This is intended to make it easier for us to be backwards compatible.Gravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/178383003 git-svn-id: http://skia.googlecode.com/svn/trunk@13575 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add SK_API to GrGLExtensionsGravatar commit-bot@chromium.org2014-02-25
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/177653007 git-svn-id: http://skia.googlecode.com/svn/trunk@13574 2bbb7eff-a529-9590-31e7-b0007b416f81
* Simplify GM-as-bench code.Gravatar commit-bot@chromium.org2014-02-24
| | | | | | | | | | | | | | | Tested: bench --match GM running bench [870 540] GM:convex_poly_clip BUG=skia: R=bsalomon@google.com, mtklein@google.com, brian@thesalomons.net Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/178893002 git-svn-id: http://skia.googlecode.com/svn/trunk@13573 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add some SkPath lua functionsGravatar commit-bot@chromium.org2014-02-24
| | | | | | | | | | R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/178243002 git-svn-id: http://skia.googlecode.com/svn/trunk@13572 2bbb7eff-a529-9590-31e7-b0007b416f81