aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* WS: remove trailing WS.Gravatar Herb Derby2017-01-31
| | | | | | | | | TBR=stani@google.com Change-Id: I8d2b86697797977ed153cc65e2ca63941677c010 Reviewed-on: https://skia-review.googlesource.com/7826 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Make flag parsing work in GN-built iOS nanobench.Gravatar Mike Klein2017-01-31
| | | | | | | | | | | Just like DM. CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadMini4-GPU-GX6450-Arm7-Debug,Build-Mac-Clang-arm64-Debug-GN_iOS Change-Id: I4af3fa1813e3b7ee48407096e91373b5fee569c7 Reviewed-on: https://skia-review.googlesource.com/7824 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Automate more parts of gn/package_ios.py.Gravatar Mike Klein2017-01-31
| | | | | | | | | | | We can determine the signing identity by running 'security', and can find an installed mobile provisioning profile by looking in the directory where they're installed. Change-Id: Ia6a4579ef1918b5337cdf8745ac1e39743b38252 Reviewed-on: https://skia-review.googlesource.com/7798 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Reduce use of SkImage_Base::peekTextureGravatar Robert Phillips2017-01-31
| | | | | | | Change-Id: I079093c9706df4911d47fba04b786e59240e8cb4 Reviewed-on: https://skia-review.googlesource.com/7792 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* gn: iOS packaging scriptGravatar Mike Klein2017-01-31
| | | | | | | | | | | | | | This is enough to run DM on my iPad. I've tweaks DM so that it can run as built by both GN and GYP. When we kill off GYP, all the dm_main() nonsense goes away. CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadMini4-GPU-GX6450-Arm7-Debug,Build-Mac-Clang-arm64-Debug-GN_iOS Change-Id: I59176bc203ee3180618b94ac5f9d291e0ad20b62 Reviewed-on: https://skia-review.googlesource.com/7757 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Hal Canary <halcanary@google.com>
* Fix assert in SkShadowVertices constructorGravatar Brian Salomon2017-01-31
| | | | | | | Change-Id: Icedbe70079d41234c98330af64d71a4e60b67f1c Reviewed-on: https://skia-review.googlesource.com/7796 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Work around GCC 4.6 issue with constructing unique_ptr<const T[]> from a T*.Gravatar Brian Salomon2017-01-31
| | | | | | | | Change-Id: I74f309f56e5042ad58c7e959d5bc434de1446efa Reviewed-on: https://skia-review.googlesource.com/7793 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add GN target for skpinfoGravatar Ravi Mistry2017-01-31
| | | | | | | | | | BUG=skia:6178 Change-Id: If6f96063fcb4e541da560ff00b925fd8098ce6b9 Reviewed-on: https://skia-review.googlesource.com/7791 Commit-Queue: Ravi Mistry <rmistry@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Make SkShadowUtils tessellations ref counted in preparation for caching them.Gravatar Brian Salomon2017-01-31
| | | | | | | Change-Id: I60133fcc4101a27bcc3e7ad38e7348ad9147b8a9 Reviewed-on: https://skia-review.googlesource.com/7784 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* SkRasterPipeline shader adapterGravatar Florin Malita2017-01-31
| | | | | | | | | | | | | Reland of https://skia-review.googlesource.com/c/7615. (lifted from https://skia-review.googlesource.com/c/7088/) CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: I797a2f0ae80209c8637875418e08d2fa03249672 Reviewed-on: https://skia-review.googlesource.com/7731 Commit-Queue: Florin Malita <fmalita@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Make sure to preserve stencil on vulkan copy as drawsGravatar Greg Daniel2017-01-31
| | | | | | | | | BUG=skia: Change-Id: I65a7eebe2024585e0696f8185b8ae9af5069f459 Reviewed-on: https://skia-review.googlesource.com/7782 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* delete project.pbxprojGravatar Hal Canary2017-01-30
| | | | | | | Change-Id: Ibe6ab90eeeb76a8c75f2e8c2d881b099265a3f8e Reviewed-on: https://skia-review.googlesource.com/7785 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* GrTessellator (AA): improve AA quality for near-overlapping paths.Gravatar Stephen White2017-01-30
| | | | | | | | | | | | | | | When path features are very close together, the outer contours can overlap. This causes the connector edges (the ones joining the inner and outer vertices) to intersect other edges. Lerping the alpha along the connector edge gives us a good approximation of the coverage at that point. BUG=skia: Change-Id: I56bcc570fc185344c5f84d11ef995d3940a08793 Reviewed-on: https://skia-review.googlesource.com/7701 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephan White <senorblanco@chromium.org>
* delete SkLayer.cppGravatar Hal Canary2017-01-30
| | | | | | | | Change-Id: I7c0325daef62948ea9f5ef58a06236be502f3ef7 Reviewed-on: https://skia-review.googlesource.com/7783 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* GIF: Only report a frame after knowing dependencyGravatar Leon Scroggins III2017-01-30
| | | | | | | | | | | | | | | | | | | | Previously, getFrameInfo might report a frame that was truncated prior to setting its requiredFrame. As a result, fRequiredFrame may be different depending on how much data has already been received. If there is a local color table, do not report the frame until the color table has been received, since that is used to determine fRequiredFrame. If there is no local color table, set fRequiredFrame and report the frame after reading the header. Add a test. Replace make_from_resource with GetResourceAsData Change-Id: I1b697f766c1d0e1e12ab2ae1d27167af5193395d Reviewed-on: https://skia-review.googlesource.com/7756 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* remove unused SkLayerGravatar Mike Reed2017-01-30
| | | | | | | | | BUG=skia: Change-Id: Ia3b53bd3811a3b9246668739c304ad3654699da0 Reviewed-on: https://skia-review.googlesource.com/7737 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Fix SkShadowTessellator.cpp for Chrome iOS buildGravatar Jim Van Verth2017-01-30
| | | | | | | | | | BUG=skia:6119 Change-Id: I6ddd51c2ebc04e5f8ae29459dc818f0d96ace073 Reviewed-on: https://skia-review.googlesource.com/7758 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Add test for outre GrSurfaceProxy requestsGravatar Robert Phillips2017-01-30
| | | | | | | | | This would've caught the N7 failure in https://skia-review.googlesource.com/c/7738/ (Make blur utils take GrTextureProxies) Change-Id: I67b56c9d38c14829b2812253c2e3f3e54eb585a5 Reviewed-on: https://skia-review.googlesource.com/7751 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* experimental/documentation/gerrit.md: more detailGravatar Hal Canary2017-01-30
| | | | | | | | NOTRY=true Change-Id: I386013af35ae2a8b51fa78109ebd89a826334839 Reviewed-on: https://skia-review.googlesource.com/7754 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Rationalize GrContext's Gr*Proxy getter namingGravatar Robert Phillips2017-01-30
| | | | | | | | | | | | | | | | | | | | | | | | This CL replaces the entry points: asDeferredSurface asDeferredTexture asDeferredRenderTarget with: GrSurfaceProxy* asSurfaceProxy sk_sp<GrSurfaceProxy> asSurfaceProxyRef GrTextureProxy* asTextureProxy sk_sp<GrTextureProxy> asTextureProxyRef GrRenderTargetProxy* asRenderTargetProxy sk_sp<GrRenderTargetProxy> asRenderTargetProxyRef Change-Id: I7c2b1ea3d702023ff23019815ca13c9ff6f3b32d Reviewed-on: https://skia-review.googlesource.com/7741 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Change shadow tessellators to use SkColor and move to util.Gravatar Jim Van Verth2017-01-30
| | | | | | | | | BUG=skia:6119 Change-Id: I4c4a8933c663ccc057596318a06c538175b9f16b Reviewed-on: https://skia-review.googlesource.com/7726 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Make blur utils take GrTextureProxies - take 2Gravatar Robert Phillips2017-01-30
| | | | | | | | | This is a re-land of https://skia-review.googlesource.com/c/7738/ (Make blur utils take GrTextureProxies) with a fix for the Nexus7 Change-Id: I5821a26b1e986daa11d960ae826a1207512cd2a0 Reviewed-on: https://skia-review.googlesource.com/7746 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* experimental/documentation/gerrit.md: fix markdownGravatar Hal Canary2017-01-30
| | | | | | | | | | https://skia.googlesource.com/skia/+/master/experimental/documentation/gerrit.md NOTRY=true Change-Id: Id7fcb90c563dfb7cd160421d18ae84fd442eb98e Reviewed-on: https://skia-review.googlesource.com/7752 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* experimental/documentation/gerrit.md: improvementsGravatar Hal Canary2017-01-30
| | | | | | | | | https://skia.googlesource.com/skia/+/master/experimental/documentation/gerrit.md NOTRY=true Change-Id: I90d8e16e9d6146fefe0199bb98d5f8eea31d4e8f Reviewed-on: https://skia-review.googlesource.com/7750 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Fix PDFium botGravatar Eric Boren2017-01-30
| | | | | | | | | | | | | | | | Sync pdfium/third_party/skia to the correct revision and apply the patch there, as opposed to maintaining a parallel Skia checkout and attempting to use that. (Rolls recipe DEPS for skia-recipes) BUG=skia:6120 Change-Id: I6e1fa46741d7ccb0d950ef8a59c6174da7967ff2 Reviewed-on: https://skia-review.googlesource.com/7747 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Implement onAppendStages for SkPictureShaderGravatar Yuqian Li2017-01-30
| | | | | | | | | BUG=skia: Change-Id: Ibc525a666f17fed1d987c0316b1963ebed7de343 Reviewed-on: https://skia-review.googlesource.com/7739 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* remove SkArithmeticMode.h empty headerGravatar Mike Reed2017-01-30
| | | | | | | | | | | needs associated fix in critique to land, removing a reference to the header. BUG=skia: Change-Id: I55c919e0cca801ea424641253d3fb406cb73fd12 Reviewed-on: https://skia-review.googlesource.com/7729 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Do not crash when the resources are missingGravatar Leon Scroggins III2017-01-30
| | | | | | | | | | | In test_conversion_possible BUG=skia:5314 Change-Id: Ia0e4178a262820b4161e55e07b0669f18322a64b Reviewed-on: https://skia-review.googlesource.com/7742 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Make SkGpuDevice::drawVertices perform color byte order swap and premul step ↵Gravatar Brian Salomon2017-01-30
| | | | | | | | | using vertex shader. Change-Id: I8153ba8c6bb48d8b15d524fbfafbe3c6d83f39c5 Reviewed-on: https://skia-review.googlesource.com/7727 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* bin/fetch-gn is 3.5x fasterGravatar Hal Canary2017-01-30
| | | | | | | Change-Id: I8098a38eb81efe0a73201c1f00dff8363b9c2075 Reviewed-on: https://skia-review.googlesource.com/7025 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Revert "Make blur utils take GrTextureProxies"Gravatar Robert Phillips2017-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d0dc05b98b71af43b44f13beba1292db52b75539. Reason for revert: assertion failure on N7 Original change's description: > Make blur utils take GrTextureProxies > > Change-Id: I1c5054de6d9827eece2f73c4c78818b4db0bc611 > Reviewed-on: https://skia-review.googlesource.com/7738 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I82d9385e23279db4c7a6757f1224e603e231354c Reviewed-on: https://skia-review.googlesource.com/7744 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Make blur utils take GrTextureProxiesGravatar Robert Phillips2017-01-30
| | | | | | | Change-Id: I1c5054de6d9827eece2f73c4c78818b4db0bc611 Reviewed-on: https://skia-review.googlesource.com/7738 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll Recipe DEPSGravatar Eric Boren2017-01-30
| | | | | | | | | BUG=skia: Change-Id: I9a88c578e53f5df1ad3bf06df7469bf010bdae21 Reviewed-on: https://skia-review.googlesource.com/7736 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Push GrTextureProxy down to more effectsGravatar Robert Phillips2017-01-30
| | | | | | | Change-Id: Ie3f32a88f25af082c25bc6daf3fe24e303e80f9e Reviewed-on: https://skia-review.googlesource.com/7616 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Omit new test from Bazel ASAN.Gravatar Ben Wagner2017-01-30
| | | | | | | | | BUG=skia: Change-Id: Id22973cc861a41e5e72561cd47acdcc81e2824b0 Reviewed-on: https://skia-review.googlesource.com/7732 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "SkRasterPipeline shader adapter"Gravatar Florin Malita2017-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6d11ed2951fadc281433606a8edc6774bed39735. Build failure: https://chromium-swarm.appspot.com/task?id=3403da0cdee8c210&refresh=10 ../../../src/core/SkOpts.cpp -o obj/src/core/libskia.SkOpts.o In file included from ../../../src/core/SkOpts.cpp:46: ../../../src/opts/SkRasterPipeline_opts.h:1093:11: error: no member named 'Load4' in '(anonymous namespace)::SkNx<8, float>' SkNf::Load4(buf, &r, &g, &b, &a); ~~~~~~^ 1 error generated. Leak: https://chromium-swarm.appspot.com/task?id=3403df55fd5eaa10&refresh=10 Original change's description: > SkRasterPipeline shader adapter > > (lifted from https://skia-review.googlesource.com/c/7088/) > > R=​mtklein@google.com,herb@google.com,reed@google.com > > CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD > > Change-Id: Idddb84069423c5fc535bea0a65a5b21a4d07084d > Reviewed-on: https://skia-review.googlesource.com/7615 > Commit-Queue: Florin Malita <fmalita@chromium.org> > Reviewed-by: Mike Klein <mtklein@chromium.org> > Reviewed-by: Mike Reed <reed@google.com> > TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: I68c0be3398bde93cd0842baf25b025c5fe1c3df7 Reviewed-on: https://skia-review.googlesource.com/7730 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* SkRasterPipeline shader adapterGravatar Florin Malita2017-01-29
| | | | | | | | | | | | | | (lifted from https://skia-review.googlesource.com/c/7088/) R=mtklein@google.com,herb@google.com,reed@google.com CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: Idddb84069423c5fc535bea0a65a5b21a4d07084d Reviewed-on: https://skia-review.googlesource.com/7615 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Rename GrFragmentProcessor::MulOutputByInputUnpremulColor to ↵Gravatar Brian Salomon2017-01-28
| | | | | | | | | MakeInputPremulAndMulByOutput. Change-Id: I33d74ddb8a7836e8f1922a5ae73f0adb74d59db3 Reviewed-on: https://skia-review.googlesource.com/7609 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Make SkSmallAllocator obey alignment properties of objects.Gravatar herb2017-01-28
| | | | | | | | | TBR=mtklein@google.com Change-Id: I505590f18a7e5babc9f0fc8af07d89b774d267bf Reviewed-on: https://skia-review.googlesource.com/7728 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Update SkJPEGImageEncoderGravatar Matt Sarett2017-01-28
| | | | | | | | | | | | | | (1) Use libjpeg-turbo color space extensions when possible. (2) Use transform_scanline_procs when pre-libjpeg-turbo transformation are required. (3) Add support for Gray and F16. BUG=skia: Change-Id: I77b977cb8c9e0afc17d907dd73a1cf3f16539bcc Reviewed-on: https://skia-review.googlesource.com/7642 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Add missing nextafter() clamping to SkLinearBitmapPipeline tile procsGravatar Florin Malita2017-01-27
| | | | | | | | | | Fixes the asserts trigered in https://skia-review.googlesource.com/c/7615 Change-Id: I7e1802bc699becf85396445fe0df4cb110ab69c4 Reviewed-on: https://skia-review.googlesource.com/7720 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* AA GrTessellator: fix bevelling of acute angles.Gravatar Stephen White2017-01-27
| | | | | | | | | | | | | | | | | The code to handle acute outer angles in generated geometry was pretty broken: it did a simple runnning average of consecutive acute vertices, and didn't handle acute angles between the last and first edges. Replaced it with something simpler that does proper bevelling for angles less than 2.5 degrees. This revealed a bug with thin path segments, exposed by the thinconcavepaths test. This will be fixed by upcoming changes, but I've also dded a few more test cases to make it clearer. Change-Id: I23a628ab2e16acaab798c746a5fd87842cacbfab Reviewed-on: https://skia-review.googlesource.com/7660 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephan White <senorblanco@chromium.org>
* experimental/documentation/gerrit.mdGravatar Hal Canary2017-01-27
| | | | | | | | NOTRY=true Change-Id: I5f429b48732ca99409cb923c2a3d7bf5f4189d24 Reviewed-on: https://skia-review.googlesource.com/7723 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* verify that glyph position rect is non-empty in GrAtlasTextBlob::appendGlyphGravatar Lee Salzman2017-01-27
| | | | | | | | | BUG=skia: Change-Id: I35d170480cb3320a9d116e34aaf740aa201a294f Reviewed-on: https://skia-review.googlesource.com/7700 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Generate Android build targets for dm and nanobenchGravatar Leon Scroggins III2017-01-27
| | | | | | | | | | | | | | | Generate targets for dm and nanobench from ninja and add them to the generated Android.bp file. Remove nanobenchAndroid and SkAndroidSDKCanvas. These rely on HWUI internals and are currently unused. Update gyp file references to removed files, just in case. Change-Id: Ic6ae18a70bfd0c33804e7996d077f2081dfdfe07 Reviewed-on: https://skia-review.googlesource.com/7635 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Add geometric version of spot shadowGravatar Jim Van Verth2017-01-27
| | | | | | | | | BUG=skia:6119 Change-Id: Ib9770bd88f4eebd68f2d893c5788f966d89f193c Reviewed-on: https://skia-review.googlesource.com/7585 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Remove old generator codeGravatar Leon Scroggins III2017-01-27
| | | | | | | | | | We're generating Android.bp from BUILD.gn, so no need for the old version. Change-Id: Ie5bcec1d4f15d0e9a178feb9191e42c872bd8e08 Reviewed-on: https://skia-review.googlesource.com/7639 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Set fOptions in SkCodec::getPixelsGravatar Leon Scroggins III2017-01-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Subclasses sometimes try to read fOptions, but it used to not get set for full decodes. As a result, they might be reading the Options from a previous scanline/incremental decode. In addition to being wrong, this is bad in the case of an fSubset pointing to a rectangle that no longer exists. So set fOptions in getPixels, prior to any attempts to read it by sub- classes. Use a different workaround for the webp/incomplete bug. Set fSubset to null prior to calling fillIncompleteImage. It can only be non-null for webp, and in that case we do not want the fill call to be using the subset width. Modify the Codec_jpeg_rewind test to use an incomplete image, so that it will also test fillIncompleteImage. DM tests of inc0.webp and inc1.webp will verify that the incomplete bug has not resurfaced. BUG=skia:5772 Change-Id: If5e1e3c9a7f337183783299c0a9e58dcbbc84119 Reviewed-on: https://skia-review.googlesource.com/7682 Commit-Queue: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* give up on big cubics (for now) and just draw a lineGravatar Mike Reed2017-01-27
| | | | | | | | | BUG=683631, skia:6152 Change-Id: I69aa741af74a37e1d7bed25ad0401535599f6af0 Reviewed-on: https://skia-review.googlesource.com/7659 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkTScopedComPtr: implicit nullptr cast to SkTScopedComPtr<T>()Gravatar Hal Canary2017-01-27
| | | | | | | Change-Id: Ic09da242650eb20164f31333e912fc899428c548 Reviewed-on: https://skia-review.googlesource.com/7634 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-02 14:44:33 +0000