aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert "Rename sg tests and samples targets to fix Visual Studio name conflict"Gravatar Brian Osman2018-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ba2f82986f63812d7b5ca529771d1c3962343c55. Reason for revert: This is going to be hard to maintain long-term. I've fixed the python script to handle this case: https://skia-review.googlesource.com/c/skia/+/131580 Original change's description: > Rename sg tests and samples targets to fix Visual Studio name conflict > > GN was emitting projects for the SG versions of tests and samples, which > conflicted with the top-level versions of those. This made the normal GN > VS IDE files confusing, and the merged ones totally broken. > > Change-Id: Ifd048258d4358ed2852d5263b16278c5b8ebd9c4 > Reviewed-on: https://skia-review.googlesource.com/131391 > Commit-Queue: Brian Osman <brianosman@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > Auto-Submit: Brian Osman <brianosman@google.com> > Reviewed-by: Jim Van Verth <jvanverth@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> TBR=jvanverth@google.com,brianosman@google.com,fmalita@chromium.org,fmalita@google.com Change-Id: I25553fdcfd063c920635fe1bd71553b578d0b0c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/131600 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Replace GrContextPriv::read/writeSurfacePixels with ↵Gravatar Brian Salomon2018-06-01
| | | | | | | | | | | GrContextPriv::read/WritePixels2 Change-Id: I08be0f347d360e97bf9a6d1aeb25f9f584cc3d89 Reviewed-on: https://skia-review.googlesource.com/131442 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Remove GalaxyS7 ATT jobs.Gravatar Ben Wagner2018-06-01
| | | | | | | | | | | We no longer have bots to run them. No-Try: true Change-Id: Ia30acf064a12b46d56f6445cf8d6d610fa1cf5a4 Reviewed-on: https://skia-review.googlesource.com/131524 Commit-Queue: Kevin Lubick <kjlubick@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Set bounds correctly for color emoji that need post-cache transfomsGravatar Jim Van Verth2018-06-01
| | | | | | | | | | | | | | | We need to handle the bounds for transformed color emoji the same way we handle the bounds for distance field text. Without this bounds correction, the glyphs were being clipped out. Also adds a sample to test this case. Bug: 848616 Change-Id: I39dedbe2fd19331ad67978c95519f5c9d46f59fc Reviewed-on: https://skia-review.googlesource.com/131523 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Jim Van Verth <jvanverth@google.com>
* Always keep buffers in vulkan persistently mapped.Gravatar Greg Daniel2018-06-01
| | | | | | | | | | | | | This should hopefully fix (and possibly even improve) some of the perf regressions we had form switching the memory allocator which were caused by us now mapping and unmapping the entire VkDeviceMemory instead of just subsets. Bug: skia: Change-Id: Ia8232594f33003e88969bf16febea4e4eec0ac95 Reviewed-on: https://skia-review.googlesource.com/131443 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Add option for fuzzer to toggle DAAGravatar Kevin Lubick2018-06-01
| | | | | | | | | | | | | | | | Of note, this is a breaking change to the fuzzed format for any canvas fuzzers. I've updated the seed corpora to match but any repro cases predating this will need to have the a single byte added to the front of the test case: echo -n -e '\x00' | cat - file > outputfile Bug: 847386 Change-Id: I10b3b228e9c121340857fb8e7807464e54e9238a Reviewed-on: https://skia-review.googlesource.com/131522 Auto-Submit: Kevin Lubick <kjlubick@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* Avoid compilation error on older compilersGravatar Kevin Lubick2018-06-01
| | | | | | | | | | | | | | | | | The constness on null_provider causes: "default initialization of an object of const type 'const NullResourceProvider' without a user-provided default constructor" See https://stackoverflow.com/a/47368753 for more. TL;DR; clang 3.8 and older is not happy Bug: skia: Change-Id: Icfc38680163c3bd4952c0e35551706cad8dbfee6 Reviewed-on: https://skia-review.googlesource.com/131521 Commit-Queue: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Dest color space no longer impacts mipmaps or texture samplingGravatar Brian Osman2018-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PS5: Removes SkDestinationSurfaceColorMode, tracking of mipmap mode on GrTexture, sRGB decode state per-texture. Because we were often choosing sRGB configs for RGB color types, legacy rendering would then be incorrect (too dark). So... PS7: Stops ever using sRGB pixel configs when translating image info or color type. Also removes a bunch of GrCaps bits and a GrContextOption that are no longer relevant. PS9: Adjusts surface creation unit test expectations, and changes the raster rules accordingly. At this point, sRGB configs are (obviously) going to be broken. Locally, I ran 8888, gl, and the gbr- versions of both. Across all GMs x configs, there are 13 diffs. 12 are GMs that create surfaces with a color-space attached (and thus, the offscreen is no longer getting sRGB pixel config). The only remainder constructs an SkPictureImageGenerator, (with an attached color space) and renders it to the gbr-gl canvas, which triggers a a tagged surface inside the generator. Bug: skia: Change-Id: Ie5edfa157dd799f3121e8173fc4f97f6c8ed6789 Reviewed-on: https://skia-review.googlesource.com/131282 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Roll third_party/externals/swiftshader 8e6ed2e..419e8a7 (1 commits)Gravatar swiftshader-skia-autoroll2018-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/8e6ed2e..419e8a7 git log 8e6ed2e..419e8a7 --date=short --no-merges --format='%ad %ae %s' 2018-06-01 capn@google.com Fix the unittests Ninja build. Created with: gclient setdep -r third_party/externals/swiftshader@419e8a7 The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=rmistry@google.com Change-Id: Ic1ccd181f824151568bc559552ec7641f6fc9d25 Reviewed-on: https://skia-review.googlesource.com/131461 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* exclude cgms.cpp from DM on Google3 buildGravatar Mike Klein2018-06-01
| | | | | | | | | | | | Having a mix of C and C++ sources in DM makes setting build flags tricky. This removes the C sources. I don't think it's important to run these C-based GMs in Google3... I don't even really think it's terribly important to run DM there at all. Change-Id: I2c2653ee15981f9a63965fb8b7e483a5c5e94830 Reviewed-on: https://skia-review.googlesource.com/131441 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Reland [recipes] Isolate build outputs with no subdirsGravatar Eric Boren2018-06-01
| | | | | | | | Bug: skia:6473 Change-Id: I730cb860abc72473aaa9af98527fd220b9a55120 Reviewed-on: https://skia-review.googlesource.com/131389 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Rename sg tests and samples targets to fix Visual Studio name conflictGravatar Brian Osman2018-06-01
| | | | | | | | | | | | | | | GN was emitting projects for the SG versions of tests and samples, which conflicted with the top-level versions of those. This made the normal GN VS IDE files confusing, and the merged ones totally broken. Change-Id: Ifd048258d4358ed2852d5263b16278c5b8ebd9c4 Reviewed-on: https://skia-review.googlesource.com/131391 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Added support for visual debugging on Android StudioGravatar ziadb2018-06-01
| | | | | | | Change-Id: Icaf848c31167db10d6fbb13d74c7287b03628fb6 Bug: skia: Reviewed-on: https://skia-review.googlesource.com/130144 Reviewed-by: Derek Sollenberger <djsollen@google.com>
* GrTessellator: fix winding merged to zero on split edge.Gravatar Stephen White2018-06-01
| | | | | | | | | | | | | | | | Occasionally, the top edge of a split edge can be merged out of existence (if it can't be mathematically distinguished from one of its adjacent edges). In this case, we need to save its winding count before it's merged so that the other half of the split doesn't also get zero winding. NOTE: this adds a new test case to the concavepaths GM. Bug: skia:7785 Change-Id: Iff8b0a2ed3065e57b737ff915ff436146987caf6 Reviewed-on: https://skia-review.googlesource.com/131223 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Fix compile when SK_XML undefinedGravatar Hal Canary2018-06-01
| | | | | | | Change-Id: Ia23b07434939acbf544854b94c4b10810c20ae1a Reviewed-on: https://skia-review.googlesource.com/131221 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com>
* Avoid divide-by-zero in shadow codeGravatar Jim Van Verth2018-06-01
| | | | | | | | Bug: oss-fuzz:6728 Change-Id: Id87140c8ee3b4e438c0c1e7d9b108a40e2a65fbe Reviewed-on: https://skia-review.googlesource.com/131145 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* [skottie] Remove inPoint/outPoint/frameRate from public APIGravatar Florin Malita2018-06-01
| | | | | | | | TBR= Change-Id: Ice4de3abe350c4570c22e859a36dbd445527fa41 Reviewed-on: https://skia-review.googlesource.com/131300 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Move SkColorTable to src/codecGravatar Leon Scroggins III2018-06-01
| | | | | | | | | | | | | | | It is no longer needed anywhere else, and simply happens to be an implementation detail of SkCodec (at least for now). Remove references to SkColorTable in other classes, and clean up some includes of SkConvertPixels I found along the way. Remove unused includes/methods on SkColorTable Change-Id: I46c8e46f5b77c37710b6cf595d48107d55871d52 Reviewed-on: https://skia-review.googlesource.com/130845 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Skip bad line segments inside gen_alpha_deltasGravatar Yuqian Li2018-06-01
| | | | | | | | | Bug: chromium:847386 Change-Id: I5bb3268c27ecfbd66268adbc36be3ea72e0a69ba Reviewed-on: https://skia-review.googlesource.com/131324 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Cary Clark <caryclark@google.com> Auto-Submit: Yuqian Li <liyuqian@google.com>
* Revert "[recipes] Isolate build outputs with no subdirs"Gravatar Eric Boren2018-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0c9d2805e81e15e3afdf7ebcdc030771dbe7750b. Reason for revert: Broke iOS and SwiftShader (and maybe others) Original change's description: > [recipes] Isolate build outputs with no subdirs > > Bug: skia:6473 > Change-Id: If243b6afb748529d2bdb212e360cd4338edc929c > Reviewed-on: https://skia-review.googlesource.com/130942 > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Commit-Queue: Eric Boren <borenet@google.com> TBR=borenet@google.com,benjaminwagner@google.com Change-Id: Icf9490f2f88dc454c6d971f35258e219137b0c0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:6473 Reviewed-on: https://skia-review.googlesource.com/131400 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [recipes] Isolate build outputs with no subdirsGravatar Eric Boren2018-06-01
| | | | | | | | Bug: skia:6473 Change-Id: If243b6afb748529d2bdb212e360cd4338edc929c Reviewed-on: https://skia-review.googlesource.com/130942 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll third_party/externals/angle2 46bcea5..cbab275 (5 commits)Gravatar angle-skia-autoroll2018-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/46bcea5..cbab275 git log 46bcea5..cbab275 --date=short --no-merges --format='%ad %ae %s' 2018-05-31 ehmaldonado@chromium.org DEPS.chromium: Sync dEQP to ANGLE (not Chromium) third_party. 2018-05-30 lfy@google.com GLES1: Shade model API 2018-05-30 lfy@google.com GLES1: Alpha test 2018-05-08 jiawei.shao@intel.com Use ShaderMap in Caps - Part II 2018-05-31 jiawei.shao@intel.com Use IsCubeMapFaceTarget on texture targets Created with: gclient setdep -r third_party/externals/angle2@cbab275 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=rmistry@google.com Change-Id: Ice3d96d60593c8440310144bb098524ed73a828a Reviewed-on: https://skia-review.googlesource.com/131360 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 05cd6df..46bcea5 (6 commits)Gravatar angle-skia-autoroll2018-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/05cd6df..46bcea5 git log 05cd6df..46bcea5 --date=short --no-merges --format='%ad %ae %s' 2018-05-31 lucferron@chromium.org D3D,Vulkan: Prep work to share useful functions from D3D 2018-05-21 xinghua.cao@intel.com Validate the total invocations within a work group 2018-05-14 geofflang@chromium.org Add support for EGL_ANDROID_presentation_time. 2018-05-30 lucferron@chromium.org Vulkan: varyings of type Matrix/Struct can't use components. 2018-05-31 jmadill@chromium.org StateManager11: Cache impl objects. 2018-05-31 jie.a.chen@intel.com Fix a trivial parentheses compile warning Created with: gclient setdep -r third_party/externals/angle2@46bcea5 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=rmistry@google.com Change-Id: I7e50425ceb31d1c149178493982db687800aaf7e Reviewed-on: https://skia-review.googlesource.com/131325 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Reland fonts: Use correct SurfaceProps in analysis canvas for remoting.Gravatar Khushal2018-05-31
| | | | | | | | | | | This reverts commit cd21d676b782cf27a9ded17a69c0393e4d3e34cc. TBR=herb@google.com Bug: 829622 Change-Id: I515fdf67fde118db774ab170e021100eef13ce68 Reviewed-on: https://skia-review.googlesource.com/130701 Commit-Queue: Khusal Sagar <khushalsagar@chromium.org> Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
* Roll third_party/externals/swiftshader f459b04..8e6ed2e (1 commits)Gravatar swiftshader-skia-autoroll2018-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/f459b04..8e6ed2e git log f459b04..8e6ed2e --date=short --no-merges --format='%ad %ae %s' 2018-05-31 capn@google.com Define GLAPI the same way as GL_APICALL. Created with: gclient setdep -r third_party/externals/swiftshader@8e6ed2e The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=rmistry@google.com Change-Id: I742ef557f7fd1367e1622d5d533a2a03c4dbec3e Reviewed-on: https://skia-review.googlesource.com/131179 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* don't walk off end of pointerGravatar Cary Clark2018-05-31
| | | | | | | | | | | | | Avoids pointer-overflow in ASAN/UBSAN. R=mtklein@google.com Bug:836282 Change-Id: I2125fa7927c30ae601431af8daec0f900c84799c Reviewed-on: https://skia-review.googlesource.com/131261 Auto-Submit: Cary Clark <caryclark@skia.org> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* SkFloatToDecimal: optimize the less common cases.Gravatar Hal Canary2018-05-31
| | | | | | | | | | bench PDFScalar_random goes from 120 ns to 70 ns. Change-Id: I6254f5c900395ee470ffee26303915025a8f0dda Reviewed-on: https://skia-review.googlesource.com/131151 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
* font remoting: Fix errors with sub-pixel positioning mismatch.Gravatar Khushal2018-05-31
| | | | | | | | | | | | | | | | | 1) Use correct offset from SkTextBlobRunIterator. Only kHorizontal_Positioning needs to use the y offset specified on the run. 2) Use the same mapping function from SkFindAndPlaceGlyph for mapping the glyph position from transform for the run. This avoids minor rounding differences between analysis and draw. R=bungeman@google.com,herb@google.com Bug:829622 Change-Id: Iaef74a8d01f0850ce042149458b2ea795c2a2b61 Reviewed-on: https://skia-review.googlesource.com/131169 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
* Make CMakeLists.txt less relative.Gravatar Ben Wagner2018-05-31
| | | | | | | Change-Id: I8ac60937d793161b37a3975735d21d93bbe7b216 Reviewed-on: https://skia-review.googlesource.com/131222 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* add std::sort() to SortBenchGravatar Mike Klein2018-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Smaller is better, winner of each group marked with *: * 0.81 sort_stdsort_repeated 2.60 sort_qsort_repeated 11.06 sort_skheap_repeated 15.81 sort_skqsort_repeated * 1.76 sort_stdsort_backward 23.17 sort_qsort_backward 14.32 sort_skheap_backward 7.06 sort_skqsort_backward * 0.78 sort_stdsort_forward 4.00 sort_qsort_forward 15.19 sort_skheap_forward 2.76 sort_skqsort_forward 13.47 sort_stdsort_rand10 27.71 sort_qsort_rand10 15.80 sort_skheap_rand10 * 11.11 sort_skqsort_rand10 17.94 sort_stdsort_rand 48.69 sort_qsort_rand 16.52 sort_skheap_rand * 11.98 sort_skqsort_rand libc++ must special case repeated, forward, and backward sorted data? To reproduce, run this and ignore (unrelated) sort_topo_rand: $ ninja -C out nanobench; and out/nanobench -m sort_ -q Change-Id: I3724188f2a6acac61d9e8c2bd43443792e0ae0ce Reviewed-on: https://skia-review.googlesource.com/131156 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com>
* Stop using legacy pixel ops on windows buildsGravatar Brian Salomon2018-05-31
| | | | | | | | | Change-Id: I48cd86aa0285bdd821570651de9203d449674592 Reviewed-on: https://skia-review.googlesource.com/131220 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* draw skottie in 3dGravatar Mike Reed2018-05-31
| | | | | | | | Bug: skia: Change-Id: I6321da0d9f06b4d5637d2ce611e1c81cc75c0eb2 Reviewed-on: https://skia-review.googlesource.com/131113 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Remove SK_SUPPORT_GPU checks in tool-only codeGravatar Brian Osman2018-05-31
| | | | | | | | | | | | | | | | Most of this is (obviously) not necessary to do, but once I started, I figured I'd just get it all. Tools (nanobench, DM, skiaserve), all GMs, benches, and unit tests, plus support code (command line parsing and config stuff). This is almost entirely mechanical. Bug: skia: Change-Id: I209500f8df8c5bd43f8298ff26440d1c4d7425fb Reviewed-on: https://skia-review.googlesource.com/131153 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Expose API for temporary use by the Android WebView.Gravatar Derek Sollenberger2018-05-31
| | | | | | | | | | | The WebView needs this information in order to correctly draw into an unclipped layer. This API can be removed when we update the Android framework to no longer depend on unclipped layers. Change-Id: Ibba63005730158021363d1d09e5338578f4fa541 Reviewed-on: https://skia-review.googlesource.com/131148 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* Reland "Use GrVkMemoryAllocator for vulkan memory allocations in ganesh."Gravatar Greg Daniel2018-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of 331c266ed716526478a10885aff66181cec64486 Original change's description: > Use GrVkMemoryAllocator for vulkan memory allocations in ganesh. > > Besides using the new allocator, the big logical change is that map > and unmap calls form GrVkMemory are specc'd to map the entire GrVkAlloc > instead of a specific offset and size as they did before. As a > consequence of this, we move the handling of non-coherent alignment > for flush/invalidate calls to GrVkMemory instead of the callers. > > Bug: skia: > Change-Id: I794d713106602f27aa7e808c306bbb69fd2b67be > Reviewed-on: https://skia-review.googlesource.com/130021 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Jim Van Verth <jvanverth@google.com> Bug: skia: Change-Id: Ia9a4192d344449fb444d2adaa1d62ff1ede4b21d Reviewed-on: https://skia-review.googlesource.com/131083 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll third_party/externals/swiftshader e92a88e..f459b04 (1 commits)Gravatar swiftshader-skia-autoroll2018-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/e92a88e..f459b04 git log e92a88e..f459b04 --date=short --no-merges --format='%ad %ae %s' 2018-05-31 capn@google.com Don't use X11 on Mac OS. Created with: gclient setdep -r third_party/externals/swiftshader@f459b04 The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=rmistry@google.com Change-Id: I7ee5885869a66a5fd37c821830c00d87b6c73ce9 Reviewed-on: https://skia-review.googlesource.com/131164 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Require the GPU backend to build our internal toolsGravatar Brian Osman2018-05-31
| | | | | | | | | | | | | This causes builders with skia_enable_gpu set to false to stop building DM, nanobench, etc. Next step is to remove all of the GPU shimming used throughout those tools, and conditional code and tests. Bug: skia: Change-Id: I59c1c64b7e4e300c3a72a2eed9b481ed1bdf732c Reviewed-on: https://skia-review.googlesource.com/131146 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Enable GPU support in MSAN buildsGravatar Brian Osman2018-05-31
| | | | | | | | | | | Don't want to test GPU with MSAN, but I'd like to make GPU support required for DM and other internal tools. Bug: skia: Change-Id: I5f1a7669242be9767aa3b579b39740a1741977f3 Reviewed-on: https://skia-review.googlesource.com/131143 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add DDL skpbench bot for just DDL recording timeGravatar Robert Phillips2018-05-31
| | | | | | | | Change-Id: If75799bfd719ccc47c2064571723e6852c07bfaa Reviewed-on: https://skia-review.googlesource.com/131144 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Allow CCPR in DDL mode (take 2)Gravatar Robert Phillips2018-05-31
| | | | | | | | | | | | A lot of the changes to get this compiling on the win_chromium_compile_dbg_ng bot (i.e., moving a lot of header files to private) should be undone if that bot is ever "fixed". Bug: skia:7988 Change-Id: I704ff793d80b18e7312048538874498824803580 Reviewed-on: https://skia-review.googlesource.com/130920 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* remove map() from SkRasterPipeline_opts.hGravatar Mike Klein2018-05-31
| | | | | | | | | | | It seems to be confusing some obscure build configuration in Google3. I don't really mind writing these out longform. Change-Id: I78e82d9fa18726d89d206e692fd260317c5f8686 Reviewed-on: https://skia-review.googlesource.com/131108 Auto-Submit: Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* skqp: update apk list scriptGravatar Hal Canary2018-05-31
| | | | | | Change-Id: I3e8cfdc246d6f264675b307c1f5004438f3ed8b6 Reviewed-on: https://skia-review.googlesource.com/131142 Reviewed-by: Hal Canary <halcanary@google.com>
* [skottie] Make the resource provider factory argument optionalGravatar Florin Malita2018-05-31
| | | | | | | | | Most of the existing clients don't care about nested resources. Change-Id: Ie7991dd25ebbd679b5b49e5624772c7e19e7ec79 Reviewed-on: https://skia-review.googlesource.com/131141 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add a DDL Skpbench botGravatar Robert Phillips2018-05-31
| | | | | | | | | | | | | | | | | | This adds a 9 threads 3x3 grid of tiles DDL SKPBench bot that reports the total time. We will eventually want a 4x4 bot, a 1x1 bot and a 0x1 bot. Additionally, we will want another whole set that only emits the DDL record time. So the ultimate naming scheme would be: DDLTotal_9x9 DDLRecord_9x9 DDLTotal_4x4 DDLRecord_4x4 DDLTotal_1x1 DDLRecord_1x1 DDLTotal_0x1 Change-Id: Ia96c79ec05602077f4112c69cb344bd8c9b2b4b1 Reviewed-on: https://skia-review.googlesource.com/130923 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* fonts: Fix image cache miss from glyphs too large for atlas.Gravatar Khushal2018-05-31
| | | | | | | | | | R=herb@google.com Bug: 829622 Change-Id: I17994663318c8db3537e99ef11aaee7beb2da23f Reviewed-on: https://skia-review.googlesource.com/131056 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
* Fix fuzzer bugsGravatar Robert Phillips2018-05-31
| | | | | | | | | | This adds checking for the input to SkColorMatrixFilterRowMajor255 and handles a potential seg fault. Bug: skia:7955 Change-Id: I9aba6712c38d32c9fe20f617744a4dce6ebacae4 Reviewed-on: https://skia-review.googlesource.com/131111 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* binary literals!Gravatar Mike Klein2018-05-31
| | | | | | | | | | | feels so good. Change-Id: I24d223957945ee81f34e5815a8e9afe32ef5004e Reviewed-on: https://skia-review.googlesource.com/131110 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Roll FreeType to pick up color stuff.Gravatar Ben Wagner2018-05-31
| | | | | | | Change-Id: Ide7d414dc0f5e112b213390dc9f62e097c6a7ef9 Reviewed-on: https://skia-review.googlesource.com/130848 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Roll third_party/externals/angle2 86ce210..05cd6df (1 commits)Gravatar angle-skia-autoroll2018-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/86ce210..05cd6df git log 86ce210..05cd6df --date=short --no-merges --format='%ad %ae %s' 2018-05-24 lucferron@chromium.org Vulkan: generateMipmaps with vkCmdBlitImage when possible Created with: gclient setdep -r third_party/externals/angle2@05cd6df The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=rmistry@google.com Change-Id: I4abc55fab7138d04e0a1adbb0bcef3de4f367907 Reviewed-on: https://skia-review.googlesource.com/131122 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add LICENSE file to vulkanmemoryallocaotrGravatar Greg Daniel2018-05-31
| | | | | | | | Bug: skia:8027 Change-Id: If5230d4c85b5501d0ba67a14a5fc93b51fb3f7e3 Reviewed-on: https://skia-review.googlesource.com/131105 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>