aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Converts a drawPaint through a rrect clip to a drawRRect in GrDrawContext.Gravatar bsalomon2016-08-26
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271053004 Review-Url: https://codereview.chromium.org/2271053004
* Update ANGLE to latest as of August 25, 2016Gravatar brianosman2016-08-26
| | | | | | | | | | | | | | | | | | With this version, it's now exposing GL_EXT_color_buffer_half_float, but it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES. In addition, release builds were crashing in EGLImageTest due to an apparent disagreement about calling convention on function-pointer to exported symbol. There is a proper typedef for that in one of their headers, but I can't seem to include it without creating more problems, so I just fixed the decoration on our local typedef. With those changes, all tests pass, and (on my Windows machine), all GMs and SKPs produce identical results vs. master in angle and angle-gl. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003 Review-Url: https://codereview.chromium.org/2282733003
* Remove SVG serialization suppressionsGravatar fmalita2016-08-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282883002 Review-Url: https://codereview.chromium.org/2282883002
* Add imagemasksubset GMGravatar fmalita2016-08-26
| | | | | | | | | | (GM for non-N32 SkImage subsetting) BUG=skia:5687 R=bsalomon@google.com,robertphillips@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286733002 Review-Url: https://codereview.chromium.org/2286733002
* Restrict supported font formats in Chrome contextGravatar drott2016-08-26
| | | | | | | | | | | | | | | | | | Chrome's complex text path uses HarfBuzz OpenType glyph lookup functions. These do not support glyph lookup in Type 1 / Postscript fonts and we do not wish to support those in Chrome any longer. In order to avoid matching fonts against Type 1 fonts possible present on Linux installations and exposed through fontconfig, this CL filters those out in Skia's font matching code. This change might not be desirable for all context in which Skia is used, hence making it conditional on a Chrome context define. BUG=skia:5685 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2280053002 Review-Url: https://codereview.chromium.org/2280053002
* Move work from ctor to onOnceBeforeDraw in ShowMipLevel GMsGravatar robertphillips2016-08-26
| | | | | | | | These were making debugging stroking more difficult than necessary GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2285813002 Review-Url: https://codereview.chromium.org/2285813002
* avoid generating degenerate conic from arcGravatar caryclark2016-08-26
| | | | | | | | R=bsalomon@google.com BUG=skia:5672 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281953002 Review-Url: https://codereview.chromium.org/2281953002
* Added distance attenuation and diffuse shading to PointLightsGravatar vjiaoblack2016-08-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246463004 Review-Url: https://codereview.chromium.org/2246463004
* Fix for fat stroked roundrects.Gravatar jvanverth2016-08-26
| | | | | | | | | The original method did not correctly compute the distance value along the inner edge, so the antialiasing was not quite correct. This fixes that by adding additional vertices and setting a different outerRadius. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275423002 Review-Url: https://codereview.chromium.org/2275423002
* GN: mac host and armv7 targetGravatar mtklein2016-08-26
| | | | | | | | | | | Just when I thought it wouldn't be useful to override ar... Tested by building 32- and 64-bit DM on my MBP and running it on my N5x. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2279703003 Review-Url: https://codereview.chromium.org/2279703003
* SkOSFile instead of dirent in android font parser.Gravatar bungeman2016-08-26
| | | | | | | | | This makes the parser more portable while making essentially the same file system calls on Android. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2279033004 Review-Url: https://codereview.chromium.org/2279033004
* Fix bounds check in grshape testGravatar bsalomon2016-08-26
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274113004 Review-Url: https://codereview.chromium.org/2274113004
* drawRegion() cleanupsGravatar msarett2016-08-26
| | | | | | | | | | (1) Move implementation to the cpp. (2) Check for the isRect() case. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286693002 Review-Url: https://codereview.chromium.org/2286693002
* Ignore fill when stroke & filling convex line-only pathsGravatar robertphillips2016-08-26
| | | | | | | | | | | | | | | | | | This seems to work well for miter and bevel joins with the resulting stroke and fill path remaining convex. There seems to be an issue with round joins where the outer generated shell is usually not convex. Without this CL the resulting stroke & filled paths are always concave. Perf-wise (on Windows): convex-lineonly-paths-stroke-and-fill bench (in ms) w/o w/CL %decrease 8888 2.88 2.01 30.2 gpu 4.4 1.38 68.6 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003 Review-Url: https://codereview.chromium.org/2275243003
* GPU implementation of drawRegion()Gravatar msarett2016-08-25
| | | | | | | | | | | Nexus 6P drawregion Bench Performance Before 48.0ms After 3.57ms BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267273006 Review-Url: https://codereview.chromium.org/2267273006
* GN: AndroidGravatar mtklein2016-08-25
| | | | | | | | | | | | | | | | Once you have downloaded an android NDK, you can set the ndk GN arg to use it. E.g. my gn.args looks like: is_debug = false ndk = "/opt/android-ndk" This should be enough to get you going for an arm64 build. You ought to be able to tweak that to other architectures by changing target_cpu to "arm", "x86", "x86-64", etc. That won't quite work until I follow this up a bit, but the skeleton is there. This is enough to get me compiled, linked, and running to completion on my N5x. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275983004 Review-Url: https://codereview.chromium.org/2275983004
* Add drawRegion() API to SkCanvasGravatar msarett2016-08-25
| | | | | | | | | | | | | | This will allow us to optimize for the RectGrid macrobench. Currently, SkiaGL is much slower than OpenGL. SkiaGL 12 items/s OpenGL 160 items/s This contains everything except for the fast implementation on GPU. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277053002 Review-Url: https://codereview.chromium.org/2277053002
* Add support for getting vulkan descriptor sets without a GrVkUniformHandler.Gravatar egdaniel2016-08-25
| | | | | | | | | | | This change allows us to use the current descriptor set system for doing copies as draws. This is a step towards being able to track resources for draws that don't go through out normal pipeline. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275633002 Review-Url: https://codereview.chromium.org/2275633002
* Do not spam the debugging informationGravatar liyuqian2016-08-25
| | | | | | | | | | | Currently, whenever there's a frame being rendered, we log such an invalidation event. This is very spammy for animations or frame rates test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276303003 Review-Url: https://codereview.chromium.org/2276303003
* Respecify SkCanvas::drawArc, consolidate conversion to SkPath, add GM for ↵Gravatar bsalomon2016-08-25
| | | | | | | | | | oddball drawArcs Allows the arc to wind more than 360 degrees when useCenter is true, specs that nothing draws if the oval is empty or the sweep angle is 0. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281653002 Review-Url: https://codereview.chromium.org/2281653002
* path ops stream-liningGravatar caryclark2016-08-25
| | | | | | | | | | | | | | | | The addT() function is a workhorse of pathops. Make it simpler, removing branches and parameters. Separate addOpp() into const and modify parts. Add more debugging that asserts if the function fails and the data is not extreme (e.g., fuzzer generated). TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273293004 Review-Url: https://codereview.chromium.org/2273293004
* SkDrawCommand: hintingGravatar halcanary2016-08-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274373003 Review-Url: https://codereview.chromium.org/2274373003
* BUILD.gn: Fix fiddle raster.Gravatar jcgregorio2016-08-25
| | | | | | BUG=skia: Review-Url: https://codereview.chromium.org/2269143007
* SkPDF: Stop `#include PREPROCESSOR_DEFINE` patternGravatar halcanary2016-08-25
| | | | | | | | | | | | | | | | | | No more: #include SK_SFNTLY_SUBSETTER #include ZLIB_INCLUDE Also, rename SK_SFNTLY_SUBSETTER to SK_PDF_USE_SFNTLY to follow my pattern of prefixing SkPDF-specific defines with 'SK_PDF_'. The ZLIB_INCLUDE define is no longer is used by anyone. TODO: rename Sfntly to something pronounceable. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273343002 Review-Url: https://codereview.chromium.org/2273343002
* Remove pixel config fallback - failing is a better option.Gravatar brianosman2016-08-25
| | | | | | | | | | | | This produces surprising results in some cases. For example: Attempt to make an F16 SkSurface on ANGLE. We can't render to F16, but this succeeds and gives you back an N32 surface instead. Ran all tests and GMs in DM on ANGLE (where this is most likely to be an issue). No problems. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272423004 Review-Url: https://codereview.chromium.org/2272423004
* update Android auto-detection.Gravatar mtklein2016-08-25
| | | | | | | | | | | | Clang defines __ANDROID__ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278483004 No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2278483004
* Reland: Experimental parsing expression grammar (PEG) template libraryGravatar fmalita2016-08-25
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271743002 Committed: https://skia.googlesource.com/skia/+/9d08cbc8c6131ff61a1e71cc5c8cf27841d62b42 Review-Url: https://codereview.chromium.org/2271743002
* Add Ganesh support for circular roundrects with strokes > 2*radii.Gravatar jvanverth2016-08-25
| | | | | | | | | Overstroked rrects are supported by adding additional geometry to the center of the nine patch, and setting constant offset vectors to fake out the distance calculation. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272703004 Review-Url: https://codereview.chromium.org/2272703004
* Make bleed GM produce consistent bitmaps on all platformsGravatar bsalomon2016-08-25
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264133003 Review-Url: https://codereview.chromium.org/2264133003
* Made shadows blurry (thru implementing variance mapping)Gravatar vjiaoblack2016-08-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2224163005 Review-Url: https://codereview.chromium.org/2224163005
* Update Skia milestone to 55Gravatar hcm2016-08-25
| | | | | | | | | TBR=reed@google.com No API changes, just moving version fwd. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281533002 Review-Url: https://codereview.chromium.org/2281533002
* Add fat stroke test case to roundrects GM.Gravatar jvanverth2016-08-25
| | | | | | | Prep for supporting fat stroked roundrects in Ganesh. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272703009 Review-Url: https://codereview.chromium.org/2272703009
* Revert of Experimental parsing expression grammar (PEG) template library ↵Gravatar fmalita2016-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | (patchset #8 id:140001 of https://codereview.chromium.org/2271743002/ ) Reason for revert: G3 roll & Msan woes. Original issue's description: > Experimental parsing expression grammar (PEG) template library > > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271743002 > > Committed: https://skia.googlesource.com/skia/+/9d08cbc8c6131ff61a1e71cc5c8cf27841d62b42 TBR=mtklein@google.com,bungeman@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2275943004
* add pathops debuggingGravatar caryclark2016-08-25
| | | | | | | | | | | | | | | | | | | Pathops has many points of failure, most of which are triggered by extreme data generated by fuzzers. It's difficult to figure out which failure point was triggered when the operation gives up. Add instrumentation so that the failure can be debugged when the data is well-behaved. Also, add a check that looks for a sequence of coincident points on multiple edges that are out of order when compared to each other. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274803003 Review-Url: https://codereview.chromium.org/2274803003
* Add neon and crc32 sources for aarch64Gravatar anmittal2016-08-25
| | | | | | | | | This fixes the build for aarch64 arch BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272243003 Review-Url: https://codereview.chromium.org/2272243003
* Experimental parsing expression grammar (PEG) template libraryGravatar fmalita2016-08-24
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271743002 Review-Url: https://codereview.chromium.org/2271743002
* Update GrShape test to allow more flexible shape creation.Gravatar bsalomon2016-08-24
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277483002 Review-Url: https://codereview.chromium.org/2277483002
* GN: miscGravatar mtklein2016-08-24
| | | | | | | | | | | | | | | - Use options' template pattern for opts too. - Simplify opt's and options' configs... they should all be the same. - When building a static-library component in our GN environment (i.e. libskia.a), make it a complete static lib, fully containing its transitive deps. - It has not proved useful to override ar. TBR=jcgregorio@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002 Review-Url: https://codereview.chromium.org/2278673002
* We can't infer the right type for voidp for old png_jmpbuf()Gravatar mtklein2016-08-24
| | | | | | | | | | In libpng 1.2 it's just a macro that's ->jmpbuf, so there's nothing forcing the conversion to png_structp. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268953005 Review-Url: https://codereview.chromium.org/2268953005
* SkPDF: set SK_SFNTLY_SUBSETTER uniformlyGravatar halcanary2016-08-24
| | | | | | | | | | | | | | When Skia is built into the Android framework, SK_SFNTLY_SUBSETTER="sample/chromium/font_subsetter.h". This #includes the same value for GOOGLE3. Once Chrome is also using this value, we can do away with the `#ifdef GOOGLE3` line. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272103002 Review-Url: https://codereview.chromium.org/2272103002
* mark fuzz test flaky since it may fail on some platformsGravatar caryclark2016-08-24
| | | | | | | | NOTRY=true TBR=bungeman@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277893004 Review-Url: https://codereview.chromium.org/2277893004
* gyp/sfntly: set SK_SFNTLY_SUBSETTER uniformlyGravatar halcanary2016-08-24
| | | | | | | | | | | | | | | When Skia is built into the Android framework, SK_SFNTLY_SUBSETTER="sample/chromium/font_subsetter.h". This sets the same value for Skia's test framework I will eventually move away from the #include PREPROCESSOR_DEFINE trick, which does not work everywhere. No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2274223002
* GN: guard tools (except fiddle) by skia_enable_tools.Gravatar mtklein2016-08-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our tools use third-party libraries pretty freely, some of which may not be available in other GN environments (e.g. Fuchsia). Most can also not function when Skia is built as a shared library. fiddle stands alone as the exception to both those points: it depends on only Skia, and works fine with both a shared or static library. So guard everything but fiddle with this flag skia_enable_tools, disabled when we're building for Fuchsia or when we're build a shared library. This CL has a couple of little tweaks to Fiddle to keep it working: - divorce it from :tool_utils, instead just building SkForceLinking.cpp itself; - fix up a buggy rebase_path() that was accidentally working when we depended on :tool_utils; - drop test_only: it now only requires production-code dependencies. The SkImageEncoder Create* methods need to be SK_API if we want SkForceLinking to work across .so's. Without this, SkForceLinking needs to be part of Skia; it can't be part of the application using Skia. The rest is mostly just a re-indent under if (skia_enable_tools), courtesy of gn format. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273823003 No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2273823003
* SkPngCodec: voidp instead of forward-declares for png.h types.Gravatar mtklein2016-08-24
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277903002 Review-Url: https://codereview.chromium.org/2277903002
* Fix leak in GrTextureStripAtlasTestGravatar ajuma2016-08-24
| | | | | | | | | | This is a followup to https://codereview.chromium.org/2262233002/, adding a missing call to GrTextureStripAtlas::unlockRow. BUG=chromium:637678 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272953003 Review-Url: https://codereview.chromium.org/2272953003
* s/invertable/invertibleGravatar bungeman2016-08-24
| | | | | | | | English orthography is often made difficult by poor phonology. TBR=oxford-english-dictionary,mtklein Review-Url: https://codereview.chromium.org/2272083002
* tiny line breaks gl renderGravatar caryclark2016-08-24
| | | | | | | | | | | | | | | | This pie cut draws correctly on raster but extends to the right on Ganesh. The path is not convex, and has a tiny line that contributes to the error. TBR=robertphillips@google.com BUG=640176 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276083002 Review-Url: https://codereview.chromium.org/2276083002
* Fix SkTLazy(const T*) initializationGravatar fmalita2016-08-24
| | | | | | | | | | Splitting the fix from https://codereview.chromium.org/2271743002/. R=bungeman@google.com,mtklein@google.com TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278633002 Review-Url: https://codereview.chromium.org/2278633002
* GN: Fuchsia probably cannot link without this.Gravatar mtklein2016-08-24
| | | | | | | | | | | | We removed this _none variant globally, thinking we'd put back platform specific versions as we added support for those platforms. We don't have anything for Fuchsia. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271273002 Review-Url: https://codereview.chromium.org/2271273002
* SkPDF: vector canvases can't hint!Gravatar halcanary2016-08-24
| | | | | | | BUG=637571 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273073002 Review-Url: https://codereview.chromium.org/2273073002