aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Sketch splitting SkPicture into an interface and SkBigPicture.Gravatar mtklein2015-05-07
| | | | | | | | | | | | | | | | | | | | | | | | | | Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). These cover about 89% of draw calls from Blink SKPs, and about 25% of draw calls from our GMs. SkPicture handles: - serialization and deserialization - unique IDs Everything else is left to the subclasses: - playback(), cullRect() - hasBitmap(), hasText(), suitableForGPU(), etc. - LayerInfo / AccelData if applicable. The time to record a 1-op picture improves a good chunk (2 mallocs to 1), and the time to record a 0-op picture greatly improves (2 mallocs to none): picture_overhead_draw: 450ns -> 350ns picture_overhead_nodraw: 300ns -> 90ns BUG=skia: Review URL: https://codereview.chromium.org/1112523006
* tesselating path renderer unit testsGravatar joshualitt2015-05-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1127183006
* SkPDF: detect YUV-JPEG without relying on ImageGeneratorGravatar halcanary2015-05-07
| | | | | | | | | | | JPEG/JFIF References: * http://www.w3.org/Graphics/JPEG/itu-t81.pdf * http://www.w3.org/Graphics/JPEG/jfif3.pdf BUG=476721 BUG=446940 Review URL: https://codereview.chromium.org/1133443003
* Iterate over instanced draws in GrGpu rather than above GrBatchTargetGravatar bsalomon2015-05-07
| | | | Review URL: https://codereview.chromium.org/1127273007
* Initial CL to create Reorder command builder behind a flagGravatar joshualitt2015-05-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1129943004
* SK_ARRAY_COUNT shouldn't work on pointers.Gravatar mtklein2015-05-07
| | | | | | | | | | | | Simpler version of https://codereview.chromium.org/1123923002/ BUG=skia:3593 R=brucedawson@chromium.org,reed@google.com,tfarina@chromium.org No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1114283003
* Add default resourcePath to SampleApp on Android.Gravatar bungeman2015-05-07
| | | | | | | | | | | Currently SampleApp on Android cannot find resources. This sets the resourcePath to /data/local/tmp/skia/resources/ which is the path used in documentationo. A future change will allow this default to be overridden. BUG=skia:3815 Review URL: https://codereview.chromium.org/1125363004
* DM: use SkFunction to make required argument type clearer.Gravatar mtklein2015-05-07
| | | | | | | | Previously it was hard to tell that DrawFn took an SkCanvas* and returned an Error. Now it's clear from the type. BUG=skia: Review URL: https://codereview.chromium.org/1125233002
* We don't use boxBlurY.Gravatar mtklein2015-05-07
| | | | | | | | Also noticed nobody sets SK_DISABLE_BLUR_DIVISION_OPTIMIZATION. BUG=skia: Review URL: https://codereview.chromium.org/1134513003
* Test sp-8888 mode on a few fast bots.Gravatar mtklein2015-05-07
| | | | | | | | (It's not particularly slow, but this mode doesn't really need global coverage.) BUG=skia: Review URL: https://codereview.chromium.org/1129903003
* Isolate GrBufferAllocPools inside GrBatchTargetGravatar robertphillips2015-05-07
| | | | | | This CL refactors the location of the GrBufferAllocPools so they reside entirely inside the GrBatchTarget. This is in preparation for making them use scratch resources. Review URL: https://codereview.chromium.org/1131553002
* adding uniqueID to GrContextGravatar joshualitt2015-05-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1128873009
* Adding unit tests for limited subset of DefaultPathRendererGravatar joshualitt2015-05-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1129203002
* Re-enable validation for glBlendBarrierKHR and glBlendEquationGravatar cdalton2015-05-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1103673002
* Implement support for KHR_blend_equation_advancedGravatar cdalton2015-05-06
| | | | | | | | | Uses KHR(or NV)_blend_equation_advanced to implement custom Xfer modes in hardware. BUG=skia: Review URL: https://codereview.chromium.org/1037123003
* Really use SSE4 (and SSSE3) in SkBlurImage_SSE4Gravatar mtklein2015-05-06
| | | | | | | | | | | | We don't seem to be making good use of the available instruction set. SSE4.1 gives us an easy way to unpack a pixel into an __m128i, and SSSE3 gave us an easy way to do the reverse. This should be bit-perfect and about a 10% speedup. BUG=skia: Review URL: https://codereview.chromium.org/1123263003
* Place nvpr above tesselating path renderer in the chainGravatar cdalton2015-05-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1123343003
* use floor for mip-level choiceGravatar reed2015-05-06
| | | | | | | | this chrome change must land first: https://codereview.chromium.org/1131663002/ BUG=skia: Review URL: https://codereview.chromium.org/1131613002
* Make drawImage a virtual on SkDeviceGravatar reed2015-05-06
| | | | | | | | This reverts commit 06dad4b92f1fcb593bc686f9537d3e0d866b2241. BUG=485243 Review URL: https://codereview.chromium.org/1129843003
* Add a control benchmark.Gravatar mtklein2015-05-06
| | | | | | | | | | | | | | I'm thinking of using this in perf with something like: ratio(fill(filter("test=foo")), fill(filter("test=control"))) Does that make sense to you? Not sure that this is really a good control bench on all bots, but I propose we just run it a bit and find out if it needs work. BUG=skia: Review URL: https://codereview.chromium.org/1129823003
* Add layout qualifiers to GrGLShaderBuilderGravatar cdalton2015-05-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1114813002
* Do we still need this DOUBLE_LOOP feature?Gravatar mtklein2015-05-06
| | | | | | | | | If so, let's do it this way so it works for all source types and doesn't need to be chosen at compile time. BUG=skia: Review URL: https://codereview.chromium.org/1129693003
* SkPDF: Move utility fns to SkPDFUtilsGravatar halcanary2015-05-06
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1124193003
* Revert of Revert of Revert of Make drawImage a virtual on SkDevice (patchset ↵Gravatar reed2015-05-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #1 id:1 of https://codereview.chromium.org/1126273002/) Reason for revert: still breaking webglconformance Original issue's description: > Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/1124003002/) > > Reason for revert: > retry now that some fixes (onDrawImage overrides) have landed in chrome/blink > > Original issue's description: > > Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/) > > > > Reason for revert: > > speculative to see if it unblocks DEPS roll > > > > Original issue's description: > > > Make drawImage a virtual on SkDevice > > > > > > Now with patch for SkDeferredCanvas > > > > > > This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57. > > > > > > BUG=skia: > > > > > > Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8 > > > > TBR=robertphillips@google.com,mtklein@google.com,reed@google.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b > > TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/620ba3afe09d4173c87537040fe50c1c1895fb1a TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1127993004
* Remove upright-matrix- configs from Android botsGravatar borenet2015-05-06
| | | | | | | | | | The Android bots are flaking like crazy. I'm not sure if these configs are hurting the situation, but let's see if this helps. TBR=mtklein,halcanary BUG=skia: Review URL: https://codereview.chromium.org/1131603002
* Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 ↵Gravatar reed2015-05-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1124003002/) Reason for revert: retry now that some fixes (onDrawImage overrides) have landed in chrome/blink Original issue's description: > Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/) > > Reason for revert: > speculative to see if it unblocks DEPS roll > > Original issue's description: > > Make drawImage a virtual on SkDevice > > > > Now with patch for SkDeferredCanvas > > > > This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57. > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8 > > TBR=robertphillips@google.com,mtklein@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1126273002
* DM: add Via abstract classGravatar mtklein2015-05-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1117183007
* Make SkFunction copyable so it can go in containers.Gravatar mtklein2015-05-06
| | | | | | | | | | | | This totally overhauls the implementation to use ordinary inheritance-based type erasure. I give up for now getting my manual vtable shenanigans to work with MSVC. Still those same "expected ; before ), also expected ) before ;" errors. I added support for uninitialized SkFunctions and operator=(), because it was fairly straightforward with this implementation. The main downside here is that I've removed the inline implementation. All SkFunctions involve a heap allocation, even when just wrapping function pointers. BUG=skia: Review URL: https://codereview.chromium.org/1056673002
* small fix to correct bounds on distance field textGravatar joshualitt2015-05-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1122253003
* Add GrAAConvexTessellator classGravatar robertphillips2015-05-06
| | | | | | This CL adds a GrAAConvexTessellator class. It does not connect it to the GrAAConvexPathRenderer. Review URL: https://codereview.chromium.org/1084943003
* Reduce the API surface of GrBufferAllocPool and its derivativesGravatar robertphillips2015-05-06
| | | | | | This utility class is going to be revamped and moved. This CL shrinks it a bit so there will be less to shuffle around. Review URL: https://codereview.chromium.org/1126753003
* Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of ↵Gravatar reed2015-05-05
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1122643005/) Reason for revert: speculative to see if it unblocks DEPS roll Original issue's description: > Make drawImage a virtual on SkDevice > > Now with patch for SkDeferredCanvas > > This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8 TBR=robertphillips@google.com,mtklein@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1124003002
* small cleanup in GrOvalRendererGravatar joshualitt2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1126723004
* trivial fix for drawvertices boundsGravatar joshualitt2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1127633003
* Fix vertex/index buffer leaksGravatar bsalomon2015-05-05
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1123823004
* Add matrix configs to DMGravatar borenet2015-05-05
| | | | | | BUG=skia:832 Review URL: https://codereview.chromium.org/1125793002
* DM: add a Via to simulate SP pictures.Gravatar mtklein2015-05-05
| | | | | | | | | | Will use this to test the other CL that adds small SkPicture implementations. Not quite sure why patch_primitive doesn't draw the same in 8888 and sp-8888, but everything else does, so I'm not going to let that hold me back for now. BUG=skia: Review URL: https://codereview.chromium.org/1126613005
* Make drawImage a virtual on SkDeviceGravatar reed2015-05-05
| | | | | | | | | | Now with patch for SkDeferredCanvas This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57. BUG=skia: Review URL: https://codereview.chromium.org/1122643005
* add DeferredCanvas mode to SampleAppGravatar reed2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1129603002
* create GrInOrderCommandBuilderGravatar joshualitt2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1118403003
* DM: add draw_to_canvas() to trim some boilerplate for Vias.Gravatar mtklein2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1123743007
* remove dead code behind BOOL_ONGETINFOGravatar reed2015-05-05
| | | | | | | | | need this to land in chrome first https://codereview.chromium.org/1125573002 BUG=skia: TBR= Review URL: https://codereview.chromium.org/1123473004
* SkPDF: Remove unused deprecated functions in SkPDFTypesGravatar halcanary2015-05-05
| | | | | | | | | | | | | depends on: http://crrev.com/1107923002 http://crrev.com/1103163002 http://crrev.com/1110533002 http://crrev.com/1107913002 http://crrev.com/1106163002 BUG=skia:3585 Review URL: https://codereview.chromium.org/1113583002
* Move RectBatch to GrRectGravatar joshualitt2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1127713002
* Add presubmit to run `{dm,nanobench}_flags.py test` when changed.Gravatar mtklein2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1129443005
* SkPDF: clean up uses of deprecated calls in SkPDFFontGravatar halcanary2015-05-05
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1110533002
* Move DrawInfo out from GrDrawTarget and rename to GrVertices.Gravatar bsalomon2015-05-05
| | | | Review URL: https://codereview.chromium.org/1124733004
* Create GrCommandBuilderGravatar joshualitt2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1113313003
* Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4Gravatar borenet2015-05-05
| | | | | | BUG=skia:3802 Review URL: https://codereview.chromium.org/1115303004
* add deferred config to DMGravatar reed2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1113273006