aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Disable ignore discard optimization in VulkanGravatar egdaniel2016-09-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346553002 Review-Url: https://codereview.chromium.org/2346553002
* CQ updateGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | | | | - swap the N5 experiment over to the new GN N5 bot - cut down on the Windows build duplication: the other two bots cover x86, x86-64, Release, Debug, _and_ Vulkan already. - remove the Release-Shared tester: I added this bot to act as a proxy for the also Shared-build Android bots, but 1) they're fast enough to no longer need a proxy (see N5 above) and 2) they're no longer Shared builds. I intend to completely drop support for dm and nanobench in Shared builds, so this bot will not just drop from the CQ but completely disappear. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346463002 Review-Url: https://codereview.chromium.org/2346463002
* GN: add is_official_buildGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | ... and use it to control debug symbols and SK_ALLOW_STATIC_GLOBAL_INITIALIZERS. This will most directly have the effect of disabling GLProgramsTest and a bunch of similar failing Vk tests on Android. Hopefully this makes the N7 trybot go green, keeping the N5 trybot green. Just running the N10 for fun. (is_official_build is how Chrome terms this sort of ReleaseForReal build.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340723003 Review-Url: https://codereview.chromium.org/2340723003
* merge run and check-rc stepsGravatar mtklein2016-09-14
| | | | | | | | | | | This'll make the 'dm' or 'nanobench' step go red like you'd hope. The N5 should pass and the N10 and N7 should fail, showing us both sides. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003 Review-Url: https://codereview.chromium.org/2339713003
* Store SkColorSpaceXform gamma LUTs in a malloced fieldGravatar msarett2016-09-14
| | | | | | | | | | | | | | | | | | In order of likelihood: (1) Tables are never used, since gamma is recognized and named. (2) Only use one table, since all three gammas are the same. (3) Actually need three tables. No reason to waste a bunch of space for these tables on SkColorSpaceXform, when it will likely be unused. This will be more efficient in lots of cases, but is particularly useful when the client really only wants a gamut xform. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336913005 Review-Url: https://codereview.chromium.org/2336913005
* 565 is not this important.Gravatar mtklein2016-09-14
| | | | | | | | | | Reduce its testing and perfing to just the fast Linux bots, and remove it from the default set of dm/nanobench configs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002 Review-Url: https://codereview.chromium.org/2344553002
* Convert back to 0-255 scale before storing linear bytesGravatar msarett2016-09-14
| | | | | | | | TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338203005 Review-Url: https://codereview.chromium.org/2338203005
* Improved optional command handling in SkParsePath::FromSVGString()Gravatar fmalita2016-09-14
| | | | | | | | | | | | | | | | Repeating command letters are optional in SVG path data strings: https://www.w3.org/TR/SVG/paths.html#PathData FromSVGString() already supports this feature, but only checks for scalars prefixes == (digit | '-' | '+'). A decimal point is also a valid scalar prefix though, so it should be included in the test. R=caryclark@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339813003 Review-Url: https://codereview.chromium.org/2339813003
* Bundle common arguments to GrGradientEffect creationGravatar brianosman2016-09-14
| | | | | | | | | | I'm going to be adding more (to deal with color spaces), so trying to fix this before it gets out of control. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007 Review-Url: https://codereview.chromium.org/2332213007
* Fix SVG flag iOS linkingGravatar fmalita2016-09-14
| | | | | | | TBR=mtklein@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344533002 Review-Url: https://codereview.chromium.org/2344533002
* Nanobench SVG supportGravatar fmalita2016-09-14
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339743002 Review-Url: https://codereview.chromium.org/2339743002
* Rewriting path writerGravatar caryclark2016-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | The path writer takes constructs the output path out of curves that satisfy the pathop operation. Curves contain lists of t/point pairs that may not be comparable to each other. To match up curve ends in the output path, look for adjacent curves to have a shared membership rather than comparing point values. Use path utilities to connect partial curve lists into closed contours. Share the angle code that determines if a curve has become a degenerate line with the path writer. Clean up some code on the way, and delete some unused functions. TBR=reed@google.com BUG=5188 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321973005 Review-Url: https://codereview.chromium.org/2321973005
* Reduce overhead for linear color xformsGravatar msarett2016-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We used to build src and dst transfer fn tables every time a new xform was created with linear src and dst. Now we don't compute them because we don't need them. This will make SkColorSpaceXform a far better option for any xforms with float or half-float inputs or outputs, particularly on a small number of pixels. This CL also moves SkColorSpaceXform closer to what I anticipate will be the eventual 'API design'. I think apply() will want to take a SrcColorType enum (not created yet because it's not necessary yet) and a DstColorType enum (still using SkColorType because there's not yet a reason not to). Performance changes: toSRGB 341us -> 366us to2Dot2 404us -> 403us toF16 318us -> 304us There's no reason for toSRGB or to2Dot2 to change. The refactor seems to have caused the compiler to order the instructions a little differently... This is something to come back to if we need to squeeze more performance out of sRGB. For now, let's not be held up by something we don't control. F16 likely improves because we are no longer (unnecessarily) building the linear tables. Code size gets a little bigger. Measuring SkColorSpaceXform size as a percentage of src/ size, we go from 0.8% to 1.4%. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335723002 Review-Url: https://codereview.chromium.org/2335723002
* Switch default for SkGaussianBlurShader radius size.Gravatar jvanverth2016-09-14
| | | | | | | | One step towards removing the 6.2 radius entirely. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333403002 TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2333403002
* GN: Android Vulkan supportGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | | | Android's the easiest place to start supporting Vulkan, so it's up first. ndk_api becomes user-specifiable so that the Vulkan bots can kick it up to 24, the first release supporting Vulkan. The defaults remain the same: 18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit. To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then $ ninja -C out dm; and droid out/dm --config vk --src gm Seems to work! Bot scripts to follow. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002 Review-Url: https://codereview.chromium.org/2336343002
* update derive_compile_bot_name() for GN_Android_VulkanGravatar mtklein2016-09-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336233005 Review-Url: https://codereview.chromium.org/2336233005
* Android GN scripts: distingush directories for data and binaries.Gravatar mtklein2016-09-14
| | | | | | | | | This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004 Review-Url: https://codereview.chromium.org/2335203004
* change write-image to use pipeverbs like everyone else, and add testGravatar reed2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335973003 Review-Url: https://codereview.chromium.org/2335973003
* re-add SkDebug_stdio for Fuchsia buildsGravatar mikejurka2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2331383004 Review-Url: https://codereview.chromium.org/2331383004
* Simulated fonts aren't TrueType fonts.Gravatar bungeman2016-09-13
| | | | | | | | | | | | Some font back-ends provide simulated fonts such as fake bold or fake oblique. These fonts should not be reported as TrueType, since the font data isn't what is actually used to draw the glyphs. BUG=chromium:639198 BUG=chromium:614612 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333423002 Review-Url: https://codereview.chromium.org/2333423002
* [SVGDom] Linear gradient 'gradientTransform' supportGravatar fmalita2016-09-13
| | | | | | | R=stephana@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339533002 Review-Url: https://codereview.chromium.org/2339533002
* Update gn_android_flavor for Vulkan.Gravatar mtklein2016-09-13
| | | | | | | | | C.f. https://codereview.chromium.org/2336343002 for basic GN support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004 Review-Url: https://codereview.chromium.org/2333293004
* No \n in bench names.Gravatar jcgregorio2016-09-13
| | | | | | | | BUG=skia: R=mtklein GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332153003 Review-Url: https://codereview.chromium.org/2332153003
* Android GN: don't reboot before runningGravatar mtklein2016-09-13
| | | | | | | | | We're already rebooting after running, so we should already be ready to go when the task starts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334223003 Review-Url: https://codereview.chromium.org/2334223003
* [SVGDom] Linear gradient 'spreadMethod' supportGravatar fmalita2016-09-13
| | | | | | | R=stephana@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337203002 Review-Url: https://codereview.chromium.org/2337203002
* Remove clear /data/local/tmp steps.Gravatar mtklein2016-09-13
| | | | | | | | | | | | | | | | | | | These were intended to prevent GN and GYP Android bots from stomping on each other. Turns out, they don't, even without this... they're writing most files to completely separate paths: - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher) in /data/local/tmp; - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench) don't overlap GYP's. So clearing /data/local/tmp was essentially just removing GN's data; GYP's data file caching was never affected and can't conflict with GN's. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002 Review-Url: https://codereview.chromium.org/2340473002
* Add ContextOptions field to SkCommandLineConfigGpuGravatar csmartdalton2016-09-13
| | | | | | | | | Reduces duplicate code by computing the ContextOptions in one spot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337163002 Review-Url: https://codereview.chromium.org/2337163002
* Use sk_sp text blob APIsGravatar fmalita2016-09-13
| | | | | | | | | | | SkTextBlobBuilder::build() -> make() SkAutoTUnref<const SkTextBlob> -> sk_sp<SkTextBlob> drawTextBlob(const SkTextBlob*) -> drawTextBlob(const sk_sp<SkTextBlob>&) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335493005 Review-Url: https://codereview.chromium.org/2335493005
* Lots of little cleanup improvements to VulkanGravatar egdaniel2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336763002 Review-Url: https://codereview.chromium.org/2336763002
* Implement Fill() for incomplete decodes to RGBA_F16Gravatar msarett2016-09-13
| | | | | | | | | Before this patch, we would hit an SkASSERT(false). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203002 Review-Url: https://codereview.chromium.org/2335203002
* Add Nexus5 to CQ as an experimentGravatar kjlubick2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332353002 Review-Url: https://codereview.chromium.org/2332353002
* Add tests for gamma correction of gradient stops to gamma GMGravatar brianosman2016-09-13
| | | | | | | | | Includes three different cases to exercise different cases in Ganesh. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336973003 Review-Url: https://codereview.chromium.org/2336973003
* add pipecanvasGravatar reed2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201323003 Review-Url: https://codereview.chromium.org/2201323003
* SkPDF: SkTypeface_FreeType ToUnicode table improvement.Gravatar halcanary2016-09-13
| | | | | | | | | | | | Currently the SkTypeface_FreeType::onGetAdvancedTypefaceMetrics synthesized glyph to Unicode mapping returns the Unicode point of the last character to map to the glyph. In practice it is better to guess the first character to map to the glyph instead. BUG=359065 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329953003 Review-Url: https://codereview.chromium.org/2329953003
* I missed an infra_step, pushing directories.Gravatar mtklein2016-09-13
| | | | | | | | | NOTREECHECKS=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337793003 Review-Url: https://codereview.chromium.org/2337793003
* Encode kIndex8 to PNG more efficientlyGravatar msarett2016-09-13
| | | | | | | | | Only write non-opaque alpha values to the tRNS chunk. BUG=skia:5616 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330053002 Review-Url: https://codereview.chromium.org/2330053002
* Mark infra steps as infra_step in GN recipe flavors.Gravatar mtklein2016-09-13
| | | | | | | | | NOTREECHECKS=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329943004 Review-Url: https://codereview.chromium.org/2329943004
* Fixup SkRRectsGaussianEdgeShader's shadersGravatar robertphillips2016-09-12
| | | | | | | | This fixes some visual artifacts in the original CL. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335783003 Review-Url: https://codereview.chromium.org/2335783003
* [SVGDom] Initial linear gradient supportGravatar fmalita2016-09-12
| | | | | | | | | | | | | | | Kind of a big change, to connect several new bits into something useful: * ID tracking & lookup * new asPaint() node virtual to support shader (and in the future filter) based paint servers * <defs>, <linearGradient> and <stop> element support * 'href', 'offset', 'stop-color', 'stop-opacity' attribute support * IRI/FuncIRI and rgb(...) parsing BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2327233003 Review-Url: https://codereview.chromium.org/2327233003
* Change shared_sources.gni to use relative pathGravatar mikejurka2016-09-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333923003 Review-Url: https://codereview.chromium.org/2333923003
* Disable png encodes from Alpha8, Float16Gravatar msarett2016-09-12
| | | | | | | | | | These don't behave as we would want anyway. They just copy to N32, and then encode. BUG=skia:5616 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332743003 Review-Url: https://codereview.chromium.org/2332743003
* Alternate approach to turn on freetype in Fuchsia.Gravatar mtklein2016-09-12
| | | | | | | | | | | | | | | | | | | What do you think of this? It's basically what you wrote, factored differently. Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files via the :typeface_freetype target. Then we just pull out the SkFontMgr Fuchsia wants to use into its own little :fontmgr_fuchsia target. No major difference here, except the availability of freetype headers, etc, is a bit more tightly scoped to just those that need them. We (obviously?) don't have Fuchsia builders, so I've got to rely on you for sanity testing this. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002 Review-Url: https://codereview.chromium.org/2333913002
* Support RGBA/BGRA Premul/Unpremul from SkPNGImageEncoderGravatar msarett2016-09-12
| | | | | | | BUG=skia:5616 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2325223002 Review-Url: https://codereview.chromium.org/2325223002
* Add back the GalaxyS3 and GalaxyS4 entries in recipesGravatar borenet2016-09-12
| | | | | | | | | | S3 is needed for some recipe simulation stuff and in general having these present does not hurt us. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336513003 Review-Url: https://codereview.chromium.org/2336513003
* Remove unused GrGLSLGeometryProcessor::emitTransform variationGravatar bsalomon2016-09-12
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338453002 Review-Url: https://codereview.chromium.org/2338453002
* Revert of SkLiteRecorder: don't tell SkCanvas about clips (patchset #1 id:1 ↵Gravatar liyuqian2016-09-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/2227833004/ ) Reason for revert: This CL breaks Android CTS tests CanvasStateTests#testClipPathReturnValues, CanvasStateTests#testClipRectReturnValues, and CanvasStateTests#testQuickReject. Reverting it won't significantly affect Android's performance. See the following test result of testInvalidateTree Jank test. (Derek said that this is the only test closely related to this CL.) **After reverting** INSTRUMENTATION_STATUS: gfx-max-slow-draw=0.0 INSTRUMENTATION_STATUS: gfx-max-high-input-latency=0.0 INSTRUMENTATION_STATUS: gfx-max-slow-ui-thread=100.0 INSTRUMENTATION_STATUS: gfx-avg-slow-bitmap-uploads=100.0 INSTRUMENTATION_STATUS: gfx-avg-missed-vsync=72.96467105972435 INSTRUMENTATION_STATUS: gfx-avg-high-input-latency=0.0 INSTRUMENTATION_STATUS: gfx-max-slow-bitmap-uploads=100.0 INSTRUMENTATION_STATUS: gfx-max-missed-vsync=73.56181150550796 INSTRUMENTATION_STATUS: gfx-avg-frame-time-90=69.0 INSTRUMENTATION_STATUS: gfx-avg-frame-time-95=69.0 INSTRUMENTATION_STATUS: gfx-avg-frame-time-99=69.0 INSTRUMENTATION_STATUS: gfx-max-jank=100.0 INSTRUMENTATION_STATUS: gfx-avg-slow-draw=0.0 INSTRUMENTATION_STATUS: gfx-avg-slow-ui-thread=100.0 INSTRUMENTATION_STATUS: gfx-max-frame-time-90=69 INSTRUMENTATION_STATUS: gfx-max-frame-time-95=69 INSTRUMENTATION_STATUS: gfx-max-frame-time-99=69 INSTRUMENTATION_STATUS: gfx-avg-jank=100.0 INSTRUMENTATION_STATUS_CODE: -1 . Test results for InstrumentationTestRunner=. Time: 77.404 **Before Reverting** gfx-max-slow-draw=1.1135857461024499 INSTRUMENTATION_STATUS: gfx-max-high-input-latency=0.0 INSTRUMENTATION_STATUS: gfx-max-slow-ui-thread=100.0 INSTRUMENTATION_STATUS: gfx-avg-slow-bitmap-uploads=100.0 INSTRUMENTATION_STATUS: gfx-avg-missed-vsync=70.79687591131983 INSTRUMENTATION_STATUS: gfx-avg-high-input-latency=0.0 INSTRUMENTATION_STATUS: gfx-max-slow-bitmap-uploads=100.0 INSTRUMENTATION_STATUS: gfx-max-missed-vsync=76.94174757281553 INSTRUMENTATION_STATUS: gfx-avg-frame-time-90=67.66666666666667 INSTRUMENTATION_STATUS: gfx-avg-frame-time-95=67.66666666666667 INSTRUMENTATION_STATUS: gfx-avg-frame-time-99=69.0 INSTRUMENTATION_STATUS: gfx-max-jank=100.0 INSTRUMENTATION_STATUS: gfx-avg-slow-draw=0.5317509395832639 INSTRUMENTATION_STATUS: gfx-avg-slow-ui-thread=100.0 INSTRUMENTATION_STATUS: gfx-max-frame-time-90=69 INSTRUMENTATION_STATUS: gfx-max-frame-time-95=69 INSTRUMENTATION_STATUS: gfx-max-frame-time-99=69 INSTRUMENTATION_STATUS: gfx-avg-jank=100.0 INSTRUMENTATION_STATUS_CODE: -1 . Test results for InstrumentationTestRunner=. Time: 77.411 OK (1 test) Original issue's description: > SkLiteRecorder: don't tell SkCanvas about clips > > If no one reads our clip, and we don't expect quickReject() to help, > we can probably get away without maintaining a proper clip stack. > > This puts us at about 0.6-0.7x of previous record cost. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227833004 > > Committed: https://skia.googlesource.com/skia/+/8369e32a05543c2619b1d7e740fe6ff6d2f03af3 TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Review-Url: https://codereview.chromium.org/2335773002
* Remove base class for installed transforms in GrPrimitiveProcessorGravatar bsalomon2016-09-12
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336723002 Review-Url: https://codereview.chromium.org/2336723002
* GN: Android perf/testsGravatar mtklein2016-09-12
| | | | | | | | | | | | | | | | | | | | | | | | | Just to take inventory of which old problems still linger and which are now moot, I've gone out of my way to have this stand alone. All of gn_android_flavor's logic is self contained, without any dependency on the platform_tools scripts. The tricky bits turn out to be, copying directories containing symlinks---or really any copying involving more than one file---and getting the exit code back from adb shell. Luckily the ADB I've got on my desktop and my Nexus 5x seems to handle this all without the awkward workarounds you see here, so there's hope that One Day Soon the weird parts (basically, anything with inline python) can go away. Once we've got these bots landed green, I'll go see whether the fixes are due to ADB updates, Android updates, or perhaps something else like hardware. The parts marked TEMPORARY are a nod to the fact that the devices are used by gn_android_flavor and android_flavor both today. It's mostly about not stepping on each other's toes or leaving anything laying around that might confuse each other. The marked parts can go away when bots are either gn_ or non-gn_ but not both. I have omitted a few steps that may be important, but which are easy independent follow-ups: - running as root - locking clocks - waiting on battery levels - fancier wait-for-ready than adb wait-for-usb-device It'd be nice to, e.g., reaffirm that locking clocks helps perf stability, and that we're locking to the best policy. I've tried to keep this CL as trim as possible, leaving any of these vaguely optional steps for later. As of PS 41 or so, it looks like the trybots are all behaving as expected. We should expect no new images in Gold. Can we see trybots in Perf yet? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2320153002 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot Review-Url: https://codereview.chromium.org/2320153002
* Gamut transformation of the paint color in GaneshGravatar brianosman2016-09-12
| | | | | | | | | | | | Conversion from sRGB to destination gamut is going to be very common, so I'm caching that xform (if there is one) on the draw context. Results verified in the gamut GM (two more boxes correct). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330553003 Review-Url: https://codereview.chromium.org/2330553003
* Match Android framework's non-AA point and line offsetGravatar bsalomon2016-09-12
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336623002 Review-Url: https://codereview.chromium.org/2336623002
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-06 17:59:40 +0000