aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Read color space info from raw exif dataGravatar Matt Sarett2017-02-24
| | | | | | | | | b/35516531 Change-Id: I86ad40b059f300375b0293bd96ecb967811f3a07 Reviewed-on: https://skia-review.googlesource.com/8951 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Improve comment in SkICC.hGravatar Matt Sarett2017-02-24
| | | | | | | | | BUG=skia: Change-Id: Ib0d30883a9e790bf1c4a85fce74a095a7df708c1 Reviewed-on: https://skia-review.googlesource.com/8908 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Use construct/init pattern with GrPipeline to replace CreateAt.Gravatar Brian Salomon2017-02-24
| | | | | | | Change-Id: Ic6c7432a9a298a143ce4f2431e94c89a0ea79793 Reviewed-on: https://skia-review.googlesource.com/8938 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Fix some viewer crashes when switching color modeGravatar Brian Osman2017-02-24
| | | | | | | | | | | | | | | The whole idea of immediate mode GUIs is to put your GUI code and the resulting action close together. Unfortunately, for actions that tear down the backend (possibly freeing the surfaces we're drawing to), we can't do that. So defer that action until the next frame (really, the next idle). Only required when an action might call setDisplayParams. BUG=skia: Change-Id: I3eb95fdb462526cb6d95819612ad2725c6f1050b Reviewed-on: https://skia-review.googlesource.com/8953 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* abs -> abs_ to avoid name conflictsGravatar Mike Klein2017-02-24
| | | | | | | | | CQ_INCLUDE_TRYBOTS=skia.primary:Build-Ubuntu-Clang-x86_64-Debug-MSAN Change-Id: I16296131e60381173e258e08110e10cb8f61b394 Reviewed-on: https://skia-review.googlesource.com/8954 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Add GrExternalTextureData and SkCrossContextImageData"Gravatar Brian Osman2017-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9ad1f92e2fceea33215c0f13cee42a679fb88d44. Reason for revert: Breaking lots of bots Original change's description: > Add GrExternalTextureData and SkCrossContextImageData > > GrExternalTextureData is an API for exporting the backend-specific > information about a texture in a type-safe way, and without pointing > into the GrTexture. The new detachBackendTexture API lets us release > ownership of a texture to the client. > > SkCrossContextImageData is the public API that lets clients upload > textures on one thread/GrContext, then safely transfer ownership to > another thread and GrContext for rendering. > > Only GL is implemented/supported right now. Vulkan support requires > that we add thread-safe memory pools, or otherwise transfer the > actual memory block containing the texture to the new context. > > BUG=skia: > > Change-Id: I784a3a74be69807df038c7d192eaed002c7e45ca > Reviewed-on: https://skia-review.googlesource.com/8529 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com,brianosman@google.com,reviews@skia.org,chinmaygarde@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: If27d1f4c3a169efb6533170f67a172664c0fe8ce Reviewed-on: https://skia-review.googlesource.com/8955 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* SkJumper: perspective matrixGravatar Mike Klein2017-02-24
| | | | | | | Change-Id: I2c63e0996e4689950f8f3b82da0fb07941c26044 Reviewed-on: https://skia-review.googlesource.com/8952 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add SkTypeface::getVariationDesignPosition.Gravatar Ben Wagner2017-02-24
| | | | | | | | | Allow users to query a typeface's position in variation design space. Change-Id: Id7cae439e795b8c9586394f11359fb7fe55e1c0b Reviewed-on: https://skia-review.googlesource.com/8861 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* SkJumper: tiling modesGravatar Mike Klein2017-02-24
| | | | | | | | | | | | | | Slight changes to clamp to make it look more like the other two. Mirror gets a fun new SSE/AVX abs() that requires no constants: abs(v) = v & (0-v) Change-Id: Iab4a61e39a7d28b47d9a10e7283df58b5e5a034e Reviewed-on: https://skia-review.googlesource.com/8950 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove the skip-draw xp optimizationGravatar Brian Salomon2017-02-24
| | | | | | | | | This seems like extra complexity for a impractical case. Also, if this is important a lot more work could be saved by catching this upstack (e.g. SkCanvas or SkPaintToGrPaint). Change-Id: Ib47be9f3cdc8ce9e5b12d9e9eac5266f04c337a9 Reviewed-on: https://skia-review.googlesource.com/8949 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add GrExternalTextureData and SkCrossContextImageDataGravatar Brian Osman2017-02-24
| | | | | | | | | | | | | | | | | | | | | | GrExternalTextureData is an API for exporting the backend-specific information about a texture in a type-safe way, and without pointing into the GrTexture. The new detachBackendTexture API lets us release ownership of a texture to the client. SkCrossContextImageData is the public API that lets clients upload textures on one thread/GrContext, then safely transfer ownership to another thread and GrContext for rendering. Only GL is implemented/supported right now. Vulkan support requires that we add thread-safe memory pools, or otherwise transfer the actual memory block containing the texture to the new context. BUG=skia: Change-Id: I784a3a74be69807df038c7d192eaed002c7e45ca Reviewed-on: https://skia-review.googlesource.com/8529 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* headers: forward declare SkDOM, and include SkClipOpGravatar Hal Canary2017-02-24
| | | | | | | Change-Id: I38041cd2c71a89604f35832415287e2356592efd Reviewed-on: https://skia-review.googlesource.com/8925 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* ImGui color space controlsGravatar Brian Osman2017-02-24
| | | | | | | | | | | | | | Adds radio buttons for switching among legacy, sRGB and F16. Also adds a list of primaries you can pick from, as well as a gamut diagram showing the primaries. The primaries can be dragged around to alter the working space. BUG=skia: Change-Id: Ibd8c67dfe085594c0d7462f0efe4d79d73999919 Reviewed-on: https://skia-review.googlesource.com/8311 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* gn_to_bp to recurse deps.Gravatar Ben Wagner2017-02-24
| | | | | | | | | | | | | Currently gn_to_bp GrabDependentSrcs only grabs the top level deps of a target. In a proposed change there are more levels of deps to clarify the real dependencies. To make this work well, a number of lists are now sets to avoid including the same file multiple times. Change-Id: I5005718e42762fe411215920e8991ab27138c7eb Reviewed-on: https://skia-review.googlesource.com/8936 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* SkJumper: a8Gravatar Mike Klein2017-02-24
| | | | | | | Change-Id: I123caaee0bb8e3967c0a1f2acf1d80bcf0f41758 Reviewed-on: https://skia-review.googlesource.com/8944 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix a confusing typo in a comment about MSAAGravatar Brian Osman2017-02-24
| | | | | | | | BUG=skia: Change-Id: I8d35862fc5f8ff2b511d716d30c734a2f0e92442 Reviewed-on: https://skia-review.googlesource.com/8946 Reviewed-by: Robert Phillips <robertphillips@google.com>
* Wrap cached GrTextures in GrTextureProxies (e.g., blur profiles, nine-patch ↵Gravatar Robert Phillips2017-02-24
| | | | | | | | | | | blurs, etc.) This is pulled out of: https://skia-review.googlesource.com/c/8823/ (Remove GrFragmentProcessor-derived class' GrTexture-based ctors) Change-Id: I5feac04dc1bf54bd74c65febdf6bba9e7ce28f55 Reviewed-on: https://skia-review.googlesource.com/8942 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* SkJumper: scales and lerpsGravatar Mike Klein2017-02-24
| | | | | | | Change-Id: I6057ba3e9243641fecbc6b78f6f83ee3265ad3d4 Reviewed-on: https://skia-review.googlesource.com/8941 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Revert "removed flags for g3""Gravatar Mike Reed2017-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a6e431b2c1baa564d2619bdc2a51a3b5bfa7e276. Reason for revert: g3 updated Original change's description: > Revert "removed flags for g3" > > This reverts commit 319ca08ba27d4582d716ce21b290eeb3f997394e. > > Reason for revert: missed some callers (drawARGB at least) > > Original change's description: > > removed flags for g3 > > > > BUG=skia: > > > > Change-Id: I2b1f748c23f2a5cd8d25f5f74f175f0d3beec75d > > Reviewed-on: https://skia-review.googlesource.com/8896 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Mike Reed <reed@google.com> > > > > TBR=reed@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Change-Id: Ic1d03407da436fa4024643d8fce869541fea13b9 > Reviewed-on: https://skia-review.googlesource.com/8897 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reviews@skia.org,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. BUG=skia: Change-Id: I1c33cc3e494dc60dd1f2724ded95ad4e4577cfd5 Reviewed-on: https://skia-review.googlesource.com/8939 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* GrTessellator (AA): simplify boundary extraction.Gravatar Stephen White2017-02-23
| | | | | | | | | | | | | | Perform boundary simplification and meshing inline with extraction. Removed EdgeList::fNext (don't need to concatenate edge lists). Removed new_contour() (don't need to heap-allocate them either). BUG=skia: Change-Id: I0f89bad105c03f3021b0d2f021064f408a361b59 Reviewed-on: https://skia-review.googlesource.com/8794 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* One-liner fix that allows Viewer to switch between Raster and OpenGLGravatar Chet Haase2017-02-23
| | | | | | | | | | | | | | A previous change to Viewer removed a key setTag() call that meant that the logic to replace the SurfaceView on a toggle between OpenGL/Raster was not able to execute, making the app useless after that toggle was performed. BUG=skia: Change-Id: Idddb7612209ce83d3461155c59f451407118e1d5 Reviewed-on: https://skia-review.googlesource.com/8789 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chet Haase <chet@google.com>
* Revert "Add SkTypeface::getVariationDesignPosition."Gravatar Ben Wagner2017-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0f3d0c37dbcaf4ec271d5fe847becc9b1aa6f537. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add SkTypeface::getVariationDesignPosition. > > Allow users to query a typeface's position in variation design space. > > Change-Id: I173ee9eefdddee6b2613435ebcc6b08c25b382ed > Reviewed-on: https://skia-review.googlesource.com/8684 > Commit-Queue: Ben Wagner <bungeman@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=bungeman@google.com,reed@google.com,reviews@skia.org,drott@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I484fe52c1f89e7b6d0024dcabf7c59d0e8b5b5e7 Reviewed-on: https://skia-review.googlesource.com/8929 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* SkJumper: 565Gravatar Mike Klein2017-02-23
| | | | | | | Change-Id: Icbd41e3dde9b39a61ccbe8e7622334ae53e5212a Reviewed-on: https://skia-review.googlesource.com/8922 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkJumper: portable round() was truncating...Gravatar Mike Klein2017-02-23
| | | | | | | Change-Id: Iabbe3617d59dbf60a36597f6c80016670a10d119 Reviewed-on: https://skia-review.googlesource.com/8924 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add SkTypeface::getVariationDesignPosition.Gravatar bungeman2017-02-23
| | | | | | | | | Allow users to query a typeface's position in variation design space. Change-Id: I173ee9eefdddee6b2613435ebcc6b08c25b382ed Reviewed-on: https://skia-review.googlesource.com/8684 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com>
* SkPDF: Stop using SkRasterClip/SkRegionGravatar Hal Canary2017-02-23
| | | | | | | | | All test PDFs render the same now. Change-Id: Ia912fd3adc1e1285cbd27f6deb5861df8396e44d Reviewed-on: https://skia-review.googlesource.com/8906 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Fix Chrome iOS no GPU build and block includes from src/gpu on our NoGpu bot.Gravatar Brian Salomon2017-02-23
| | | | | | | Change-Id: I934f0d6096a6eb0305e24f06dfb6c49299a195a9 Reviewed-on: https://skia-review.googlesource.com/8919 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fix memory leak: adopt rather than ref GrTexture* in GrTextureStripAtlasGravatar Robert Phillips2017-02-23
| | | | | | | | | | This was introduced in: https://skia-review.googlesource.com/c/8881/ (Switch GrTextureStripAtlas over to GrTextureProxies) Change-Id: I6635e9fee9f63d703373b31c31fda459f5b63763 Reviewed-on: https://skia-review.googlesource.com/8916 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Don't use mixed samples if NVPR is disabledGravatar csmartdalton2017-02-23
| | | | | | | | | BUG=skia: Change-Id: I48c72268e30e202a101177393eb777f18a11cb6f Reviewed-on: https://skia-review.googlesource.com/8790 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* GrTessellator (AA): sorting and comparison performance improvements.Gravatar Stephen White2017-02-23
| | | | | | | | | | | | | | | | | | | Change comparison functions to perform the common case first (a.fX > b.fX), and the uncommon case (a.fX == b.fX) after the short-circuit. Change Comparator to switch on a direction enum instead of using function pointers. Inline sorted_merge() and front_back_split() into merge_sort(), and template it on the comparator function, so it instantiates two versions. This is even faster (but costs us some code bloat of course). BUG=skia: Change-Id: I45a2376492240ed7e0552ca2aed75e303e918bc6 Reviewed-on: https://skia-review.googlesource.com/8791 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* SkJumper: fill in AVX f16 stages, turn on AVXGravatar Mike Klein2017-02-23
| | | | | | | | | As far as I can tell, this draws identically to the SSE4.1 backend. Change-Id: Id650db59a84d779b84d45f42e60321732e28d803 Reviewed-on: https://skia-review.googlesource.com/8913 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Blacklist test on Vulkan Ubuntu Intel caused by driver bugGravatar Greg Daniel2017-02-23
| | | | | | | | | BUG=skia:6280 Change-Id: Ib8d0a8fe7ca2e0174daa209eac487027e833e6ec Reviewed-on: https://skia-review.googlesource.com/8907 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Make shadow_utils GM use its own SkResourceCacheGravatar Brian Salomon2017-02-23
| | | | | | | | | This should stabilize the replay testing on the bots. Change-Id: I89e3e308000743da6e1a765751103cffabc7e4ba Reviewed-on: https://skia-review.googlesource.com/8902 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "skslc switch support"Gravatar Ethan Nicholas2017-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2b1e468dabd2ac7bea7ec17740275f4f4aad30c3. Reason for revert: bot breakage Original change's description: > skslc switch support > > BUG=skia: > > Change-Id: Ida7f9e80139aa1e4f43804cafbcac640e47fab25 > Reviewed-on: https://skia-review.googlesource.com/8771 > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > TBR=benjaminwagner@google.com,ethannicholas@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: Iaaa35d10a15704279c6883d4d68f6d4ad5078320 Reviewed-on: https://skia-review.googlesource.com/8792 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Do not throw away the savelayer if kDontClipToLayer_PrivateSaveLayerFlag is setGravatar Yuqian Li2017-02-23
| | | | | | | | | | | | This affects the Android CTS test android.uirendering.cts.testclasses.LayerTests#testSaveLayerUnclippedWithAlpha BUG=skia: Change-Id: Idae150e7e4f7ed9a1a225c382ba0b40d3f840937 Reviewed-on: https://skia-review.googlesource.com/8892 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Move around GL dependencies.Gravatar Mike Klein2017-02-23
| | | | | | | | | | | | | | | | :gpu gets GL and GLU :gpu_tool_utils gets X11 :views gets GL and X11 {shared,static}x{gpu,no-gpu} all seem to link. May not be perfect, but it's a start. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Ubuntu-GCC-x86_64-Debug-NoGPU,Build-Ubuntu-GCC-x86_64-Release-Shared Change-Id: Ia6f595a9d601f623a3c686aa00528a80401bcb24 Reviewed-on: https://skia-review.googlesource.com/8911 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove no longer used links from directoryGravatar Heather Miller2017-02-23
| | | | | | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=8914 Change-Id: I8497764cf12c0a0df96ea559f0595365d76252a3 Reviewed-on: https://skia-review.googlesource.com/8914 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* skslc switch supportGravatar Ethan Nicholas2017-02-23
| | | | | | | | | BUG=skia: Change-Id: Ida7f9e80139aa1e4f43804cafbcac640e47fab25 Reviewed-on: https://skia-review.googlesource.com/8771 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* In Vulkan make sure resolve is sent to GPU when preparing msaa RenderTarget ↵Gravatar Greg Daniel2017-02-23
| | | | | | | | | | | | | | | | | | for external IO In GrDrawingManager, when preparing for I/O we first flush the GPU then call resolve. However, in Vulkan the resolve lives in a command buffer that needs to be flushed to the GPU as well. This is most likely the cause we were seeing in Viewer app where first frame was always black since the actually resolve command buffer was not flushed to the gpu before presenting. All future frames would then typically show one frame behind. BUG=skia: Change-Id: Iaf492f88680b998be0087637279cc78d5a38ec50 Reviewed-on: https://skia-review.googlesource.com/8903 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Switch GrTextureStripAtlas over to GrTextureProxiesGravatar Robert Phillips2017-02-23
| | | | | | | | | This is split out of: https://skia-review.googlesource.com/c/8823/ (Remove GrFragmentProcessor-derived class' GrTexture-based ctors) Change-Id: I9f602985b6010fc58b595e2be6d4e67e50179747 Reviewed-on: https://skia-review.googlesource.com/8881 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Revert[2] "hide deprecated underline and strikethru"""Gravatar Mike Reed2017-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit cfd3d9ff8f370e3a4a53e2aba84dc4d682501f4c. Reason for revert: derek is fixing caller Original change's description: > Revert "Revert[2] "hide deprecated underline and strikethru"" > > This reverts commit aab68c56ef8fc88b0d1536f99aa1cc9ae7a0573a. > > Reason for revert: android still broken RecordingCanvasTests.cpp > > Original change's description: > > Revert[2] "hide deprecated underline and strikethru" > > > > android now updated. > > > > This reverts commit e005edd3a5deb602beec59f59cdc8b14d3764d58. > > > > BUG=skia:6250 > > > > Change-Id: If08d344cdd863fde1d9955dc3fab671a83be0f73 > > Reviewed-on: https://skia-review.googlesource.com/8815 > > Commit-Queue: Mike Reed <reed@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > > > TBR=reed@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:6250 > > Change-Id: I954575a0e4b9aca8414e10901a7be03a2d7e6396 > Reviewed-on: https://skia-review.googlesource.com/8900 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reviews@skia.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6250 Change-Id: Ie518b64219a0262cd343644754940774bf42faec Reviewed-on: https://skia-review.googlesource.com/8901 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert[2] "hide deprecated underline and strikethru""Gravatar Mike Reed2017-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit aab68c56ef8fc88b0d1536f99aa1cc9ae7a0573a. Reason for revert: android still broken RecordingCanvasTests.cpp Original change's description: > Revert[2] "hide deprecated underline and strikethru" > > android now updated. > > This reverts commit e005edd3a5deb602beec59f59cdc8b14d3764d58. > > BUG=skia:6250 > > Change-Id: If08d344cdd863fde1d9955dc3fab671a83be0f73 > Reviewed-on: https://skia-review.googlesource.com/8815 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6250 Change-Id: I954575a0e4b9aca8414e10901a7be03a2d7e6396 Reviewed-on: https://skia-review.googlesource.com/8900 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Make GrPipeline::CreateAt take GrRenderTarget and not GrRenderTargetContextGravatar Brian Salomon2017-02-23
| | | | | | | | | This is needed in order to create pipelines at flush time. Change-Id: I0bcd64d503d45c3383dbb932b048e2d7faa07c67 Reviewed-on: https://skia-review.googlesource.com/8849 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* SkJumper: reformat .S filesGravatar Mike Klein2017-02-23
| | | | | | | | | | | | Decimal byte encoding makes more horizontal space for comments, which are the only thing you really want to read. No code change here. Change-Id: I674d78c898976063b0d89b747af41c62dc294303 Reviewed-on: https://skia-review.googlesource.com/8899 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add AVX to the SkJumper mix.Gravatar Mike Klein2017-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | AVX is a nice little halfway point between SSE4.1 and HSW, in terms of instructions available, performance, and availability. Intel chips have had AVX since ~2011, compared to ~2013 for HSW and ~2007 for SSE4.1. Like HSW it's got 8-wide 256-bit float vectors, but integer (and double) operations are essentially still only 128-bit. It also doesn't have F16 conversion or FMA instructions. It doesn't look like this is going to be a burden to maintain, and only adds a few KB of code size. In exchange, we now run 8x wide on 45% to 70% of x86 machines, depending on the OS. In my brief testing, speed eerily resembles exact geometric progression: SSE4.1: 1x speed (baseline) AVX: ~sqrt(2)x speed HSW: ~2x speed This adds all the basic plumbing for AVX but leaves it disabled. I'll flip it on once I've implemented the f16 TODOs. Change-Id: I1c378dabb8a06386646371bf78ade9e9432b006f Reviewed-on: https://skia-review.googlesource.com/8898 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "removed flags for g3"Gravatar Mike Reed2017-02-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 319ca08ba27d4582d716ce21b290eeb3f997394e. Reason for revert: missed some callers (drawARGB at least) Original change's description: > removed flags for g3 > > BUG=skia: > > Change-Id: I2b1f748c23f2a5cd8d25f5f74f175f0d3beec75d > Reviewed-on: https://skia-review.googlesource.com/8896 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: Ic1d03407da436fa4024643d8fce869541fea13b9 Reviewed-on: https://skia-review.googlesource.com/8897 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* removed flags for g3Gravatar Mike Reed2017-02-23
| | | | | | | | | BUG=skia: Change-Id: I2b1f748c23f2a5cd8d25f5f74f175f0d3beec75d Reviewed-on: https://skia-review.googlesource.com/8896 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* abstract access to device-clip-boundsGravatar Mike Reed2017-02-23
| | | | | | | | | | | | | apply this to GpuDevice. Should allow us to switch to per-device-clipping with minimal change (since we've abstracted how the device sees its clip-bounds.) BUG=skia: Change-Id: I5245d90f308c21abdb58d441c326670b65e9179d Reviewed-on: https://skia-review.googlesource.com/8884 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkPDF: stop using RasterClip for drawAnnotation()Gravatar Hal Canary2017-02-22
| | | | | | | Change-Id: Idc3a4151f1b6bd3cb11b59e39ddb1458af385035 Reviewed-on: https://skia-review.googlesource.com/8891 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkPDF: do not use SkRegion in populateGraphicStateEntryFromPaint()Gravatar Hal Canary2017-02-22
| | | | | | | Change-Id: I3eb192426f5b648fe7ad7db3c8dac42771be0197 Reviewed-on: https://skia-review.googlesource.com/8893 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>