aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* SkPDF: consolidate two functions in SkPDFObjNumMapGravatar Hal Canary2017-10-10
| | | | | | | Change-Id: Id815920e664ba986258867b7c35a7618a6927b0f Reviewed-on: https://skia-review.googlesource.com/54360 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkColorSpaceXform: clamp before table lookupsGravatar Mike Klein2017-10-10
| | | | | | | | | | | | | | | | | | | | | | The fuzzer has built a single test case that causes out-of-bounds reads on both the src and dst tables. I'm glad we have it. Next follow ups may include: - have byte_tables_rgb do its own clamping - replace table_{r,g,b} here with a single stage analogous to byte_tables_rgb that looks up the three float tables safely - maybe replace byte_tables_rgb with that. I'm not really sure why src->XYZ tables are floats but XYZ->dst are bytes. I'm going to try some of these out before attempting to reland in Chrome. As usual, rebaselining Blink makes things a pain. Bug: chromium:772684, skia:7114 Change-Id: Id8759e766330e1c7689c0847bf2cd35d422ebbcd Reviewed-on: https://skia-review.googlesource.com/57760 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll skia/third_party/externals/angle2/ 8886f0fc8..1fce3283f (2 commits)Gravatar angle-deps-roller@chromium.org2017-10-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/8886f0fc8d68..1fce3283f083 $ git log 8886f0fc8..1fce3283f --date=short --no-merges --format='%ad %ae %s' 2017-10-09 jmadill Samples: Add command line flag to select renderer. 2017-10-09 brianosman Fix several bugs in the timeout logic of clientWait Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=reed@google.com Change-Id: I8f9c178dc0485f299e5bfda18402414a92c9bfd9 Reviewed-on: https://skia-review.googlesource.com/57700 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* [SVGDom] stroke-miterlimit supportGravatar Florin Malita2017-10-10
| | | | | | | | https://www.w3.org/TR/SVG/painting.html#StrokeMiterlimitProperty Change-Id: I5e488e95afe17c4b753e8177ea5783d4820e3d2c Reviewed-on: https://skia-review.googlesource.com/57221 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix drawSpecialImageGravatar Robert Phillips2017-10-10
| | | | | | | | | | | | | | W/o this fix the strict constraint on the specialImage draws can sometimes be removed. This CL ensures that the temporary SkImage always has the actual dimensions of the special Image. Note: the replacement of full screen clears w/ draws revealed this bug b.c. the image filters were only drawing a rect for the content area of the special images. Thus when the final DAG result was drawn to the canvas some of the bleed through (from the removal of the strict constraint) was showing. Bug: 755871, 768134 skbug.com/7122 Change-Id: Id67b7143225c24b716e260c973f3bbf68f20188a Reviewed-on: https://skia-review.googlesource.com/57660 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add Linux GPU Coverage botGravatar Kevin Lubick2017-10-10
| | | | | | | | | | | Adds it for Vulkan and non-Vulkan Bug: skia:7080 NOTRY=true Change-Id: I5c4b30b91b96ad6ce9694c42550c4e909de4ba41 Reviewed-on: https://skia-review.googlesource.com/57560 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Roll skia/third_party/externals/angle2/ 180f43c6b..8886f0fc8 (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-10
| | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/180f43c6b398..8886f0fc8d68 $ git log 180f43c6b..8886f0fc8 --date=short --no-merges --format='%ad %ae %s' 2017-10-10 oetuaho Clean redundant semicolons from HLSL branch statements Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=reed@google.com Change-Id: I48339b1d93e0c46dee10341b00f476db555c76e1 Reviewed-on: https://skia-review.googlesource.com/57640 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* [SVGDom] Add support for <a> elementsGravatar Florin Malita2017-10-10
| | | | | | | | | | | | | | | https://www.w3.org/TR/SVG/linking.html#AElement The Skia SVG DOM is not a user agent, so link semantics are not particularly interesting. But since <a> can wrap actual content, it is important to not drop it on the floor. The simplest thing to do is turn it into a <g> node and run with it. Change-Id: I4e103553354746ceb49bc1038680a1c477a1320a Reviewed-on: https://skia-review.googlesource.com/57620 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* DM: move skiatest functions into separate file.Gravatar Hal Canary2017-10-10
| | | | | | | | | Motivation: allows reuse. Change-Id: I5732305a213acd83de4ba4e84e0ae27d094cf649 Reviewed-on: https://skia-review.googlesource.com/57241 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* [SVGDom] Fix href handling for radial gradientsGravatar Florin Malita2017-10-10
| | | | | | | | | | Currently, the href logic only visits linear gradient nodes. Update to also visit radial gradients, per https://www.w3.org/TR/SVG/pservers.html#RadialGradientElementHrefAttribute. Change-Id: I8d33d9faa65dae776c13e134c497acccfb428abb Reviewed-on: https://skia-review.googlesource.com/57480 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ d63d0007c..180f43c6b (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/d63d0007c119..180f43c6b398 $ git log d63d0007c..180f43c6b --date=short --no-merges --format='%ad %ae %s' 2017-10-09 oetuaho Refactor creating temporary symbols Created with: roll-dep skia/third_party/externals/angle2 BUG=735497 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=reed@google.com Change-Id: I06fd36db77e5d51103c491eda49f653d289eab0a Reviewed-on: https://skia-review.googlesource.com/57500 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Roll skia/third_party/externals/angle2/ 359487c82..d63d0007c (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/359487c822bb..d63d0007c119 $ git log 359487c82..d63d0007c --date=short --no-merges --format='%ad %ae %s' 2017-10-06 kainino dontInitializeUninitializedLocals on Qualcomm only Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=reed@google.com Change-Id: If5b0c9b3517a789931cb896da8f7ece996114181 Reviewed-on: https://skia-review.googlesource.com/57422 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Revert "Revert "Fix a couple float-cast-overflow in SkScan*.""Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit b6abb9b4e088abee8b8dfcce9c9f7eb759518198. Reason for revert: It doesn't make sense that this CL would affect the tests implicated in the perf regression in skia:7143, and the revert had no effect on the perf of those tests. Seems like the perf alert was either noise or due to a different CL. Original change's description: > Revert "Fix a couple float-cast-overflow in SkScan*." > > This reverts commit 3cd0bef0fd9d062bbcc313c329b4f31925e8ded7. > > Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143 > > Original change's description: > > Fix a couple float-cast-overflow in SkScan*. > > > > Bug: skia:5060 > > Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 > > Reviewed-on: https://skia-review.googlesource.com/47422 > > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > TBR=benjaminwagner@google.com,reed@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: skia:7143 > Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae > Reviewed-on: https://skia-review.googlesource.com/57240 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> TBR=benjaminwagner@google.com,reed@google.com Change-Id: I29ac47d6665e2e52ee2a6500488dc407c8d2af1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7143 Reviewed-on: https://skia-review.googlesource.com/57440 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Small pathops cleanup.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | | | | | | Newer clang compiler produces the diagnostic ../../tests/PathOpsDebug.cpp:1349:44: error: comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-unsigned-enum-zero-compare] if (!firstOp && c->operand() && op >= 0) { The check seems to be defending against bad values of SkPathOp, but this now seems unnecessary. This also adds 'rdiff' to kPathOpStr for future debugging. Change-Id: I08e5ba77c56e519ce4d9ae89491f7ccd5eb7f944 Reviewed-on: https://skia-review.googlesource.com/57104 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Remove trailing whitespace.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | Also adds a presubmit to prevent adding trailing whitespace to source code in the future. Change-Id: I41a4df81487f6f00aa19b188f0cac6a3377efde6 Reviewed-on: https://skia-review.googlesource.com/57380 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Remove references to Rietveld from skia's presubmitGravatar Aaron Gable2017-10-09
| | | | | | | | | R=rmistry@chromium.org Change-Id: I75c171b9fc9843b5289c759e85b32e51a126fe9b Reviewed-on: https://skia-review.googlesource.com/57302 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove carriage returns.Gravatar Ben Wagner2017-10-09
| | | | | | | | | Also add a presubmit so they don't get added to source code. Change-Id: I6a85c6a934b1068a63646a0dcc0d3a08baa96ced Reviewed-on: https://skia-review.googlesource.com/57110 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* [SVGDom] Radial gradient supportGravatar Florin Malita2017-10-09
| | | | | | | | | | | | Implement support for https://www.w3.org/TR/SVG/pservers.html#RadialGradients. BUG=skia:7074 Change-Id: I19645a4a3bbddfd1ee0d08a2775381a0017acbfc Reviewed-on: https://skia-review.googlesource.com/57340 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Disable GL buffer mapping on TSAN/Mac.""Gravatar Brian Salomon2017-10-09
| | | | | | | | | | This reverts commit 4e7cdd5a0052aa76bed6f80ec325be19e09e6ab1. Bug: skia:7058 Change-Id: I3b92c35835cf7a8c04e9218194bf293b790413e0 Reviewed-on: https://skia-review.googlesource.com/57222 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add Linux CPU Coverage BotGravatar Kevin Lubick2017-10-09
| | | | | | | | | | | This simply uploads the results of an LLVM coverage to GCS for later ingestion/display. Bug: skia:7080 Change-Id: I7dcfa2307a239734a614990aca899ea37129126b Reviewed-on: https://skia-review.googlesource.com/53880 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [SVGDom] Factor out common gradient logicGravatar Florin Malita2017-10-09
| | | | | | | | | | In preparation of radial gradient support, move common logic into an abstract base class (SkSVGGradient). Change-Id: Ie5361048ca8fddd9070c573c8daef0d0f57dc95e Reviewed-on: https://skia-review.googlesource.com/57108 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
* first cut at SkRect, SkIRect documentationGravatar Cary Clark2017-10-09
| | | | | | | | | | | | | | All functions should have descriptions, examples, cross-references. References and spelling have been checked. More work to do creating and organizing topics. Docs-Preview: https://skia.org/?cl=56140 Tbr: caryclark@google.com Bug: skia:6898 Change-Id: I9d1e55d04ab64874c33cac8b91534aa192c2f545 Reviewed-on: https://skia-review.googlesource.com/56140 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Reduce the frequency of the text atlas compaction.Gravatar Derek Sollenberger2017-10-09
| | | | | | | Change-Id: I2e3e9add5f9a9074243d220fa37e610e6ad086c8 Reviewed-on: https://skia-review.googlesource.com/57111 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* fix use of uninitialized flag in SkCodecGravatar Ivan Afanasyev2017-10-09
| | | | | | | | | | | | | SkCodec class has the fStartedIncrementalDecode field, which is not initialized on construction, but may be used in incrementalDecode method being uninitialized. Bug: skia: Change-Id: I378412a375100ad2df4aa38f2dd5682867e0e34b Reviewed-on: https://skia-review.googlesource.com/53160 Commit-Queue: Heather Miller <hcm@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Cleanup jobs.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | | | NUC6i7KYK with GTX960 is an experimental eGPU setup that will be replaced with the NUC7i5BNK. IntelHD4600 has been replaced with IntelHD4400. Move remainder of *AbandonGpuContext jobs to QuadroP400. No-Try: true Change-Id: Ic81392ec162cb88500c9da7609471dbdc4a64f84 Reviewed-on: https://skia-review.googlesource.com/57320 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Enable coverage counting path rendering except on Android framework"Gravatar Chris Dalton2017-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 196efbf71cdd9a64b807e5e869cd45da5a66ac36. Reason for revert: 1k SKPs GPU bot fails, perf regressions to look into. Original change's description: > Enable coverage counting path rendering except on Android framework > > Android framework will come after collecting a bit more data. > > Bug: skia: > Change-Id: I6f4738e457f09c976b8bf282153ca75160a1d91c > Reviewed-on: https://skia-review.googlesource.com/55563 > Commit-Queue: Chris Dalton <csmartdalton@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,csmartdalton@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I3f1a7022414ccec80541772d9912065fa4efd74e Reviewed-on: https://skia-review.googlesource.com/57300 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* use unsigned to allow for using all 32bits for approx distanceGravatar Mike Reed2017-10-09
| | | | | | | | | Bug:757146 Change-Id: If783f1b36fc70c443d0808947275acf003a872ee Reviewed-on: https://skia-review.googlesource.com/57109 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* fix include guardGravatar Mike Reed2017-10-09
| | | | | | | | Bug: skia:7136 Change-Id: I4bc7bb932b24deb1e8fc2938ce641ac6677458e0 Reviewed-on: https://skia-review.googlesource.com/57107 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Disable deferred proxies a different way in ChromeGravatar Robert Phillips2017-10-09
| | | | | | | | | | This keeps crbug.com/769760 working but also fixes the new bug (crbug.com/769898) Bug: 769898 Change-Id: I53c00e2bca602fa9c33e5a50a98274c1ce8b2534 Reviewed-on: https://skia-review.googlesource.com/57282 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* remove legacy computeByteSize flag, now returns max_size_tGravatar Mike Reed2017-10-09
| | | | | | | Bug: skia: Change-Id: Ia2f2627ba4ea81e715f27e94d900951ba5e19f79 Reviewed-on: https://skia-review.googlesource.com/57106 Reviewed-by: Mike Reed <reed@google.com>
* use new computeByteSize apiGravatar Mike Reed2017-10-09
| | | | | | | Bug: skia: Change-Id: I92ddb7768ace21afa45b3c2b07db556bf42f4f50 Reviewed-on: https://skia-review.googlesource.com/57261 Reviewed-by: Derek Sollenberger <djsollen@google.com>
* Revert "Fix a couple float-cast-overflow in SkScan*."Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3cd0bef0fd9d062bbcc313c329b4f31925e8ded7. Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143 Original change's description: > Fix a couple float-cast-overflow in SkScan*. > > Bug: skia:5060 > Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 > Reviewed-on: https://skia-review.googlesource.com/47422 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Reed <reed@google.com> TBR=benjaminwagner@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:7143 Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae Reviewed-on: https://skia-review.googlesource.com/57240 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "change computeByteSize to return max_size_t on overflow""Gravatar Mike Reed2017-10-09
| | | | | | | | | | | This reverts commit 384f0a7d6626026f21313e85e51890d747171ee8. Bug: skia: Change-Id: I392ef5c1a5172181caf81ae270befeba6e778241 Reviewed-on: https://skia-review.googlesource.com/57084 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Fix new compiler warnings in GLInstancedRendering.cppGravatar Chris Dalton2017-10-09
| | | | | | | | Bug: skia:7109 Change-Id: I6d42991d4aba611819260411aaebd508ff242d09 Reviewed-on: https://skia-review.googlesource.com/56921 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* initClassID no longer auto-allocates idsGravatar Ethan Nicholas2017-10-09
| | | | | | | | | | | | | Auto-allocated IDs mean that the IDs depend upon the order in which classes happen to get initialized and are therefore not consistent from run to run. This change paves the way for a persistent shader cache by fixing the IDs in an enum. Bug: skia: Change-Id: I3e923c6c54f41b3b3eb616458abee83e0909c09f Reviewed-on: https://skia-review.googlesource.com/56401 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revert "Disable GL buffer mapping on TSAN/Mac."Gravatar Brian Salomon2017-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c203e65265ccf0dcf426eafa4fae97b2b99cba7d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable GL buffer mapping on TSAN/Mac. > > Also reverts 65e706379657d64371012c2e95ccf1354d741145 which disabled buffer mapping in GrResourceProvider::createPatternedIndexBuffer. > > Bug: skia:7058 > Change-Id: I6816abe53251e1cd8e92eae41b8cdbe45218a341 > Reviewed-on: https://skia-review.googlesource.com/50100 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=mtklein@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: Icf0cf40ba4d6e7081971eee2eea0a41033790df7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7058 Reviewed-on: https://skia-review.googlesource.com/57220 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* add helper to check for overflowGravatar Mike Reed2017-10-09
| | | | | | | | | | pre-CL to aid in changing the convention for when we overflow Bug: skia: Change-Id: I1e34a18fefb80187787a1c0c8ed7ee3516744d24 Reviewed-on: https://skia-review.googlesource.com/57103 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Omit flaky test.Gravatar Ben Wagner2017-10-09
| | | | | | | | | Bug: skia:6857 No-Try: true Change-Id: I32a2a867ee52f497b39b799053020e1b875dd1a6 Reviewed-on: https://skia-review.googlesource.com/57080 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Mark ~LuaView as override.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | Newer clang versions report ../../samplecode/SampleLua.cpp:44:13: error: '~LuaView' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override] Change-Id: I6f3e69482a79e9580e51b957fff06e6d4d270735 Reviewed-on: https://skia-review.googlesource.com/57164 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Get HelloWorld example running againGravatar Jim Van Verth2017-10-09
| | | | | | | Change-Id: I5956f7c52d265d9f52dd061f1555c54ad092fe76 Reviewed-on: https://skia-review.googlesource.com/57101 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Disable GL buffer mapping on TSAN/Mac.Gravatar Brian Salomon2017-10-09
| | | | | | | | | | Also reverts 65e706379657d64371012c2e95ccf1354d741145 which disabled buffer mapping in GrResourceProvider::createPatternedIndexBuffer. Bug: skia:7058 Change-Id: I6816abe53251e1cd8e92eae41b8cdbe45218a341 Reviewed-on: https://skia-review.googlesource.com/50100 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove SkTypeface::Style use in API.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | All known callers of SkTypeface::MakeDefault call it with kNormal and the only users specifying kNormal explicitly are in Skia, so remove the parameter. There appear to be no users of SkTypeface::MakeFromTypeface, so remove it. The current alternative is SkFontMgr::matchFaceStyle which can do a better job anyway. Change-Id: I89d94c77f9593407b0a319786848a8b823fcbae4 Reviewed-on: https://skia-review.googlesource.com/56762 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fix merge conflict.Gravatar Ben Wagner2017-10-08
| | | | | | | | | | | | This resolves the conflict between https://skia-review.googlesource.com/57120 and https://skia-review.googlesource.com/57081. No-Try: true Change-Id: I45f47eb13dd7151b37b3b37f821232a02b9a43ff Reviewed-on: https://skia-review.googlesource.com/57082 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Win Clang Vulkan jobs.Gravatar Ben Wagner2017-10-08
| | | | | | | | No-Try: true Change-Id: I0b9f07e9057892443934da399f60762005495bde Reviewed-on: https://skia-review.googlesource.com/57081 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* CCPR: Blacklist Intel driver except on MacGravatar Chris Dalton2017-10-08
| | | | | | | | | | TBR=bsalomon@google.com Bug: skia: Change-Id: I93306a285c5bd1d71a69c4c8a12b7fc583a52e12 Reviewed-on: https://skia-review.googlesource.com/57160 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Update SKP versionGravatar UpdateSKPs2017-10-08
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I0e9f38de166cfb7823a943f28e525f0bb008f1e7 Reviewed-on: https://skia-review.googlesource.com/57120 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* CCPR: Block older Intel/Mesa setupsGravatar Chris Dalton2017-10-07
| | | | | | | | | | TBR=bsalomon@google.com Bug: skia:7134 Change-Id: I71af6c8ca75804f7ac6d187ecdc1467cad686494 Reviewed-on: https://skia-review.googlesource.com/56941 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add Win Clang Vulkan builds.Gravatar Ben Wagner2017-10-07
| | | | | | | | | Fix Clang compiler warning. Change-Id: Ic6f5b161058d1ed2df45e12b72dbff3b486ec986 Reviewed-on: https://skia-review.googlesource.com/56740 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix a couple float-cast-overflow in SkScan*.Gravatar Ben Wagner2017-10-07
| | | | | | | | Bug: skia:5060 Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 Reviewed-on: https://skia-review.googlesource.com/47422 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Enable coverage counting path rendering except on Android frameworkGravatar Chris Dalton2017-10-07
| | | | | | | | | | Android framework will come after collecting a bit more data. Bug: skia: Change-Id: I6f4738e457f09c976b8bf282153ca75160a1d91c Reviewed-on: https://skia-review.googlesource.com/55563 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-02 22:05:07 +0000