aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Rebasing more conic stuffGravatar egdaniel2015-01-07
| | | | | | | | | TBR= NOTRY=True NOTREECHECKS=True BUG=skia: Review URL: https://codereview.chromium.org/837913002
* rebaseline after use-conicsGravatar reed2015-01-07
| | | | | | | | | BUG=skia: TBR= NOTRY=True NOTREECHECKS=True Review URL: https://codereview.chromium.org/800193004
* More rebases from conic changeGravatar egdaniel2015-01-07
| | | | | | | | | TBR= NOTRY=True NOTREECHECKS=True BUG=skia: Review URL: https://codereview.chromium.org/841693003
* rebaseline after use-conicsGravatar reed2015-01-07
| | | | | | | | | BUG=skia: TBR= NOTRY=True NOTREECHECKS=True Review URL: https://codereview.chromium.org/841703002
* use conics for ovals and roundrectsGravatar reed2015-01-06
| | | | | | | | | This reverts commit e3b61eb7997d12c5f9b844dd3af1847492d9f411. BUG=skia: TBR= Review URL: https://codereview.chromium.org/834303002
* Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback (patchset ↵Gravatar reed2015-01-06
| | | | | | | | | | | | | | | | | | #2 id:20001 of https://codereview.chromium.org/829983003/) Reason for revert: speculative revert to unblock DEPS roll Original issue's description: > Rename SkDrawPictureCallback to SkPicture::AbortCallback > > Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c TBR=reed@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/824013004
* Remove SkPDFDocument and SkPDFDevice from the public headers.Gravatar halcanary2015-01-06
| | | | | | Committed: https://skia.googlesource.com/skia/+/8b1f761365df6652ea9304b6572d2dd91917b9aa Review URL: https://codereview.chromium.org/841533002
* Comment out unused names in src/core/SkGlyphCache.hGravatar tomhudson2015-01-06
| | | | | | | | | | | | Android violates our encapsulation and depends on this file; to keep their compiles clean they want us to hide the names of unused parameters. Follow-up to https://codereview.chromium.org/726923002/. R=djsollen@google.com Review URL: https://codereview.chromium.org/839583005
* Rename SkDrawPictureCallback to SkPicture::AbortCallbackGravatar robertphillips2015-01-06
| | | | Review URL: https://codereview.chromium.org/829983003
* will write a custom one for blink laterGravatar reed2015-01-06
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/810603003
* rebaseline after conic fixesGravatar reed2015-01-06
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/831993004
* Revert "Remove SkPDFDocument and SkPDFDevice from the public headers."Gravatar reed2015-01-06
| | | | | | | | | | | This reverts commit 8b1f761365df6652ea9304b6572d2dd91917b9aa. BUG=skia: TBR= NOTRY=True NOTREECHECKS=True Review URL: https://codereview.chromium.org/839603002
* Remove SkPDFDocument and SkPDFDevice from the public headers.Gravatar halcanary2015-01-06
| | | | Review URL: https://codereview.chromium.org/841533002
* Require explicit disabling of cross process pictureimagefiltersGravatar robertphillips2015-01-06
| | | | | | | | This is to allow capturing .skp files with their pictureimagefilters intact. This is a companion to https://codereview.chromium.org/810933004/ (Provide a way of allowing cross process pictureimagefilters). Review URL: https://codereview.chromium.org/834673006
* fixes for conicsGravatar reed2015-01-06
| | | | | | | | | | - use std tolerance in edgebuilder, since the path has not been scaled-up to its super-sample size (that happens in the builder methods. - off-by-1 fix for pathops when using the output of the conicquadder BUG=skia: Review URL: https://codereview.chromium.org/837023002
* add --listfailingbase optionGravatar reed2015-01-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/833223002
* Update SKP versionGravatar skia.buildbots2015-01-06
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/840533002
* Revert of use conics for ovals and roundrects (patchset #1 id:1 of ↵Gravatar reed2015-01-06
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/817283005/) Reason for revert: need fix in edgebuilder+aa Original issue's description: > use conics for ovals and roundrects > > adapted from https://codereview.chromium.org/831313002/ > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/2bf1c4d58b84c73c6421edcb25e3afb4971da200 TBR=reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/840573002
* improve sanity checks on gradient constructor parametersGravatar reed2015-01-06
| | | | | | BUG=445807 Review URL: https://codereview.chromium.org/837013002
* Revert of add missed tests for conics (patchset #1 id:1 of ↵Gravatar reed2015-01-06
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/835993004/) Reason for revert: need to fix edgebuilder+aa Original issue's description: > add missed tests for conics > > BUG=skia: > TBR= > NOTRY=True > NOTREECHECKS=True > > Committed: https://skia.googlesource.com/skia/+/6b0f701687edcdfc4fc996aed085054912866aff TBR=reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/797403003
* add missed tests for conicsGravatar reed2015-01-05
| | | | | | | | | BUG=skia: TBR= NOTRY=True NOTREECHECKS=True Review URL: https://codereview.chromium.org/835993004
* use conics for ovals and roundrectsGravatar reed2015-01-05
| | | | | | | | | adapted from https://codereview.chromium.org/831313002/ BUG=skia: TBR= Review URL: https://codereview.chromium.org/817283005
* Cleanup: More override fixes - another round.Gravatar tfarina2015-01-05
| | | | | | | | BUG=skia:3075 TEST=ninja -C out/Debug TBR=reed@google.com Review URL: https://codereview.chromium.org/831113002
* Rebaseline thinstrokedrects GMGravatar fmalita2015-01-05
| | | | | | | | BUG=skia:3278 TBR=caryclark@google.com NOTRY=true Review URL: https://codereview.chromium.org/836023002
* Remove draw window size state from SkDebugCanvasGravatar kkinnunen2015-01-05
| | | | | | | | | | | | | | | | | The SkDebugCanvas can be (or is currently) being used to draw to multiple different canvases. If this use-case is intended, then storing draw -related state in the canvas causes bugs. Remove draw window size state form SkDebugCanvas. Instead, use the canvas base layer size as the window size to clip to. This is consistent with the current use in debugger. This is part of work trying to remove bugs in debugger that result from replaying one SkDrawCanvas to two different canvases. Currently the SkDrawCanvas stores state that can only be valid if it is used for one canvas. Review URL: https://codereview.chromium.org/835113002
* Rebase perspective gpu gm's after conic changeGravatar egdaniel2015-01-05
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/831333002
* Cap id size returned by GrScratchKey::GenerateResourceTypeGravatar robertphillips2015-01-05
| | | | | | kkinnunen@ has been seeing compiler warnings on GrScratchKey::GenerateResourceType (https://codereview.chromium.org/833913002/ - Cast the scratch resource key in order to fix a warning)(presumably due to the unsigned/signed comparison in kInvalidResourceType == type). This CL limits the returned id to its effective range to, hopefully, clarify the whole int32_t -> uint32_t conversion & wrapping problem. Review URL: https://codereview.chromium.org/827923006
* Remove SkPath::asRectGravatar robertphillips2015-01-05
| | | | | | | | | | AFAICT the asRect entry point is not needed. Greg: GPU Reed: API Cary: Path Review URL: https://codereview.chromium.org/833193002
* debugger: Update the picture view when the first command is selectedGravatar kkinnunen2015-01-05
| | | | | | | Update the picture view in the debugger when the first command is selected. DebugCanvas::drawTo(index) draws up to and including the index. Review URL: https://codereview.chromium.org/837483002
* Fix thin rect stroking.Gravatar fmalita2015-01-05
| | | | | | | | | | | When both edges of a thin (sub-unit) stroke fall within the same pixel, we compute the wrong coverage and also blit the same line twice. To avoid these issues, tweak the inner/outer hulls to ensure one of the edges is always pixel-aligned. BUG=skia:3278 R=reed@google.com Review URL: https://codereview.chromium.org/819253003
* First set of minimal docs for the new Markdown server, which will eventually ↵Gravatar jcgregorio2015-01-05
| | | | | | | | | | | | | | | | replace https://sites.google.com/site/skiadocs/. Design of the new Markdown server is documented here: https://github.com/google/skia-buildbot/blob/master/doc/README.md You can see the server up and running here: http://skiadocs.com:8000/ This is *reed because it adds a new top level directory to the skia repo. BUG=skia: Review URL: https://codereview.chromium.org/835083003
* Update PdfViewer's SkNulCanvasGravatar robertphillips2015-01-05
| | | | | | This appears to have been missed in https://codereview.chromium.org/831253002/ (move remaining virtual draw methods to onDraw) Review URL: https://codereview.chromium.org/839433002
* Add conic support to Default and AAConvex path redender.Gravatar egdaniel2015-01-05
| | | | | | | | | | This is achieved but chopping up conics into quads. With this change conics should be ready to be used on the gpu side of things BUG=skia:3258 Review URL: https://codereview.chromium.org/825443002
* Cleanup isRect variantsGravatar robertphillips2015-01-05
| | | | Review URL: https://codereview.chromium.org/832083002
* Revert of Revert of enable conics gm (patchset #1 id:1 of ↵Gravatar reed2015-01-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/811863006/) Reason for revert: maybe this wasn't the cause of the chromeos crash? Original issue's description: > Revert of enable conics gm (patchset #3 id:40001 of https://codereview.chromium.org/835593002/) > > Reason for revert: > did I break the build? > > Original issue's description: > > enable conics gm > > > > BUG=skia: > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/03119ba4f815bc2c2774a9349ca8278ab1695072 > > TBR=egdaniel@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ede901c7a2e21a44552b8c1436d9521ce33f4de5 TBR=egdaniel@google.com,reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/836773002
* Print out failing PathRef test on ChromeOSGravatar robertphillips2015-01-05
| | | | | | | | This is intended to provide additional information for a flaky assertion failure on ChromeOS Daisy. BUG=skia:3282 Review URL: https://codereview.chromium.org/821683002
* Correctly declare skiagm::DCShader to be not flattenable.Gravatar halcanary2015-01-05
| | | | | | | Motivation: As part of my testing I serialize all of our GMs to SKP files. This was breaking my code. Review URL: https://codereview.chromium.org/832393002
* experimental skp_to_pdf_md5 program.Gravatar halcanary2015-01-05
| | | | | | | | | This program takes a list of Skia Picture (SKP) files and renders each as a multipage PDF, then prints out the MD5 checksum of the PDF file. This can be used to verify that changes to the PDF backend will not change PDF output. Review URL: https://codereview.chromium.org/832403002
* removing dashcubics from ignore, may cause failuresGravatar joshualitt2015-01-05
| | | | | | | | NOTRY=True TBR= BUG=skia: Review URL: https://codereview.chromium.org/834673004
* Revert of Revert of move remaining virtual draw methods to onDraw (patchset ↵Gravatar reed2015-01-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #1 id:1 of https://codereview.chromium.org/835913002/) Reason for revert: test to see if it wasn't this CL that broke chromeos Original issue's description: > Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/817723005/) > > Reason for revert: > did this cause chromeos heap corruption on skp? > > Original issue's description: > > move remaining virtual draw methods to onDraw > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419 > > TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e87e383351e1547b21d96d02bcd0c3cbbe0837f1 TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com,reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/831253002
* Clean up dead clear() code in SkRecord.Gravatar mtklein2015-01-05
| | | | | | | | | | | | | This removes the SkRecords::Clear struct and everything that refers to it. Notice there is nothing actually creating a Clear, which means this is all dead code. Now that all ops obey the clip, I don't think we need the weird inflate-empty-to-epsilon hack for BBH queries. BUG=skia: Review URL: https://codereview.chromium.org/835813002
* add SkGeometry.h to core.gypiGravatar reed2015-01-05
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/820683005
* dm/gold: Let's consider source_type a key.Gravatar mtklein2015-01-05
| | | | | | | | | | | | | | | | | | | Ex. "results" : [ { "key" : { "config" : "565", "mode" : "direct", "name" : "textblob", "source_type" : "GM" }, "md5" : "024ecfc3be8c08ea0cc580c12411fe09" }, BUG=skia:3255 Review URL: https://codereview.chromium.org/811403003
* Whitespace change to trigger rebuilds after gsutil fixGravatar borenet2015-01-05
| | | | | | | | | BUG=434422 TBR=rmistry NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/776463003
* Revert of move remaining virtual draw methods to onDraw (patchset #5 ↵Gravatar reed2015-01-05
| | | | | | | | | | | | | | | | | | | | | id:80001 of https://codereview.chromium.org/817723005/) Reason for revert: did this cause chromeos heap corruption on skp? Original issue's description: > move remaining virtual draw methods to onDraw > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419 TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/835913002
* debugger: Remove few redundant variablesGravatar kkinnunen2015-01-05
| | | | | | | | | | | Use the GUI widget states instead of instance variables reflecting the widget state. Fixes the case where pause state would be left on when switching files, but the image would change to the last frame of newly loaded image. Review URL: https://codereview.chromium.org/810033004
* Update SKP versionGravatar skia.buildbots2015-01-04
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/835813003
* move remaining virtual draw methods to onDrawGravatar reed2015-01-04
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/817723005
* Revert of enable conics gm (patchset #3 id:40001 of ↵Gravatar reed2015-01-04
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/835593002/) Reason for revert: did I break the build? Original issue's description: > enable conics gm > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/03119ba4f815bc2c2774a9349ca8278ab1695072 TBR=egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/811863006
* enable conics gmGravatar reed2015-01-04
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/835593002