aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove SkCanvas::drawBitmapMatrix()Gravatar Florin Malita2014-12-10
| | | | | | R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/789033002
* more rebaselinesGravatar Brian Salomon2014-12-10
| | | | Review URL: https://codereview.chromium.org/789263002
* Add more ignore gm's for recent Xfer Processor CLGravatar egdaniel2014-12-10
| | | | | | | | | TBR=bsalomon@google.com NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/786083004
* Add baseline images for new filterfastbounds GMGravatar robertphillips2014-12-10
| | | | | | TBR=scroggo@google.com Review URL: https://codereview.chromium.org/787423002
* Create xfer processor backend.Gravatar egdaniel2014-12-10
| | | | | | | | | | | This includes: -Having an actual XP stage at the end of the gl pipeline. -All Blending work is handled by XP until actually setting GL blend states -GLPrograms test to test XP BUG=skia: Review URL: https://codereview.chromium.org/764643004
* Add GM for 2-rects blur which cannot break into nine-patchGravatar qiankun.miao2014-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/791943002
* Remove canvas::NewRaster, and rename surface::NewRasterPMColor to N32PremulGravatar reed2014-12-10
| | | | | | | | | | patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001) BUG=skia: TBR= re-landing after chrome fixes have landed Review URL: https://codereview.chromium.org/784223007
* Add SSSE3 acceleration for S32_D16_filter_DXGravatar qiankun.miao2014-12-10
| | | | | | | | | | | With this CL, related nanobench can be improved for 565 config. bitmap_BGRA_8888_update_scale_bilerp 76.1us -> 46.7us 0.61x bitmap_BGRA_8888_scale_bilerp 78.7us -> 47us 0.6x bitmap_BGRA_8888_update_volatile_scale_bilerp 82.7us -> 46.9us 0.57x BUG=skia: Review URL: https://codereview.chromium.org/788853002
* fix surface test for gpu and codecsGravatar reed2014-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/789173004
* Update SKP versionGravatar skia.buildbots2014-12-09
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/790073002
* Add bench to measure blur rects performanceGravatar qiankun.miao2014-12-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/787913002
* Update SKP versionGravatar skia.buildbots2014-12-09
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/760943003
* add readPixels to SkSurface (later try to remove it from SkCanvas)Gravatar reed2014-12-09
| | | | | | | BUG=skia: TBR=bsalomon, robertphilips Review URL: https://codereview.chromium.org/789993002
* Skia: Track the fIsWrapped separately so that we delete correctlyGravatar hendrikw2014-12-09
| | | | | | | | | | | | | | | GrGlTextureRenderTarget inherits virtually from both GrGlRenderTarget and GrGLTexture, which both have a 'wrap' flag. The passed in wrap setting could be different for the two base classes, but since it's virtually inherited, they share the same flag, so they're either both on, or both off. As a result, we fail to delete the frambuffer. To fix this, we now keep a separate isWrapped flag for GrGlRenderTarget. BUG=437998 Review URL: https://codereview.chromium.org/791493003
* rrrrrrrrrrrreeeeeeeeeeebaseline!Gravatar Brian Salomon2014-12-09
| | | | Review URL: https://codereview.chromium.org/790643004
* Revert of remove (dumb) canvas::NewRaster, and rename ↵Gravatar reed2014-12-09
| | | | | | | | | | | | | | | | | | | | | | | surface::NewRasterPMColor to N32Premul (patchset #3 id:40001 of https://codereview.chromium.org/790733003/) Reason for revert: need to update chrome first Original issue's description: > remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul > > patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2c1605a1fbaa2e35a27399a34254fb1200ec2ae6 TBR=fmalita@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/791763002
* This cl moves color and coverage off of drawstate. In an effort to keep ↵Gravatar joshualitt2014-12-09
| | | | | | | | | | this CL manageable, I have left the compute invariant input / output in a bit of a strange state(fixing this will be complicated). In addition, NVPR makes this very complicated, and I haven't quite figured out a good way to handle it, so for now color and coverage DO live on optstate, but I will figure out some way to refactor that in future CLs. BUG=skia: Review URL: https://codereview.chromium.org/783763002
* Adding an option for pixelated rendering in SkPictureImageFilterGravatar junov2014-12-09
| | | | | | BUG=skia:3209 Review URL: https://codereview.chromium.org/787073003
* More N10 rebaselinesGravatar Brian Salomon2014-12-09
| | | | | | TBR= Review URL: https://codereview.chromium.org/784413002
* Remove unused static function skcolor_to_grcolor_nopremultiply.Gravatar egdaniel2014-12-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/762223003
* remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to ↵Gravatar reed2014-12-09
| | | | | | | | | | N32Premul patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001) BUG=skia: Review URL: https://codereview.chromium.org/790733003
* Rebaseline after texture coord precision changes.Gravatar Brian Salomon2014-12-09
| | | | | | TBR=scroggo@google.com Review URL: https://codereview.chromium.org/788903003
* change SkPoint::setLength to set itself to (0,0) if it starting length is ↵Gravatar reed2014-12-09
| | | | | | | | | degenerate. BUG=skia:3203 TBR=caryclark Review URL: https://codereview.chromium.org/785933003
* Fix for alpha textures on Nexus 6.Gravatar jvanverth2014-12-09
| | | | | | | | Nexus 6 appears to require a sized internal format for A8 textures, much like other newer mobile devices. Changed to use sized format for A8 textures in general with ES 3.0. Review URL: https://codereview.chromium.org/783523003
* Don't call GetShaderPrecisionFormat for geometry shaders.Gravatar bsalomon2014-12-09
| | | | | | TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/791713002
* Make all blending up to GrOptDrawState be handled by the xp/xp factory.Gravatar egdaniel2014-12-09
| | | | | | | | | | | | In this cl the blending information is extracted for the xp and stored in the ODS which is then used as it currently is. In the follow up cl, an XP backend will be added and at that point all blending work will take place inside XP's. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7c66342a399b529634bed0fabfaa562db2c0dbd4 Review URL: https://codereview.chromium.org/759713002
* Use threshold of 1 texture coord value per pixel w/ nearest neighbor.Gravatar bsalomon2014-12-09
| | | | Review URL: https://codereview.chromium.org/787873002
* Use GrCoordTransform precision to set uniform matrix precisionGravatar bsalomon2014-12-09
| | | | Review URL: https://codereview.chromium.org/784103003
* Rename CustomCoordTextureEffect to GrBitmapTextGeoProc.Gravatar egdaniel2014-12-09
| | | | | | | | Also add in explicit set for LCD text in invariantOutput. BUG=skia: Review URL: https://codereview.chromium.org/786293002
* Update nanobench so the non-MPD path doesn't permit layer hoistingGravatar robertphillips2014-12-09
| | | | Review URL: https://codereview.chromium.org/787923002
* Switch non-MPD nanobench path to use a separate canvas per tileGravatar robertphillips2014-12-09
| | | | | | | | | | | | | | | | | | | | | | | | It is desirable that, when layer hoisting is disabled, the MPD and non-MPD timings be roughly the same. Unfortunately, using a separate canvas for each tile (a requirement for MPD) introduces its own discrepancy into the timing. Using a separate canvas for each tile doesn't seem to make a difference for 8888 (see the non-MPD 8888 column below) but slows down GPU rendering (see the non-MPD GPU column below). Since this is how Chromium renders I propose switching to this regimen (even though it is "slowing down" GPU rendering). nanobench mean times (ms) with layer hoisting disabled (for desk_amazon.skp) 8888 MPD non-MPD 1 canvas (old-style) 0.628 1.71 separate (new-style) 0.795 1.63 GPU MPD non-MPD 1 canvas (old-style) 2.34 1.69 separate (new-style) 2.32 2.66 Review URL: https://codereview.chromium.org/779643002
* Increase timeouts for CSS3Gradients and GooglePlus pagesetsGravatar rmistry2014-12-09
| | | | | | | BUG=skia:3187 BUG=skia:3196 Review URL: https://codereview.chromium.org/786353002
* Make addUniform take a precisionGravatar bsalomon2014-12-09
| | | | Review URL: https://codereview.chromium.org/788733003
* Move shader precision out of GrShaderVarGravatar bsalomon2014-12-09
| | | | Review URL: https://codereview.chromium.org/777443003
* Use texture size to determine precision of texture coord varyings.Gravatar bsalomon2014-12-09
| | | | Review URL: https://codereview.chromium.org/778783002
* Revert of Replace EncodeBitmap with an interface. (patchset #12 id:210001 of ↵Gravatar scroggo2014-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/784643002/) Reason for revert: Failing serialization tasks in DM: http://build.chromium.org/p/client.skia/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/352/steps/dm/logs/stdio Original issue's description: > Replace EncodeBitmap with an interface. > > Gives more flexibility to the caller to decide whether to use the > encoded data returned by refEncodedData(). > > Provides an implementation that supports the old version of > SkPicture::serialize(). > > TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely > > BUG=skia:3190 > > Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 > > Committed: https://skia.googlesource.com/skia/+/02b217f80b01a7dda8493422e5257c36a9ce8464 TBR=reed@google.com,rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:3190 Review URL: https://codereview.chromium.org/783393004
* Replace EncodeBitmap with an interface.Gravatar scroggo2014-12-09
| | | | | | | | | | | | | | | | Gives more flexibility to the caller to decide whether to use the encoded data returned by refEncodedData(). Provides an implementation that supports the old version of SkPicture::serialize(). TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely BUG=skia:3190 Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 Review URL: https://codereview.chromium.org/784643002
* Rebaselines for https://codereview.chromium.org/785893004/ (Fix ↵Gravatar robertphillips2014-12-09
| | | | | | | | | | MatrixImageFilter computeFastBounds) The msaa4 image diffs aren't actually due to the named CL TBR=scroggo@google.com Review URL: https://codereview.chromium.org/787093002
* Avoid crash on some 64b ARM NEON platforms.Gravatar tomhudson2014-12-09
| | | | | | | | | | The compiler may choose to use x30 for a local loop counter; ensure it's saved. Patch from kevin.petit@arm.com, verified by benm@google.com. R=djsollen@google.com Review URL: https://codereview.chromium.org/786273003
* Rebaseline GalaxyS4 and Nexus10.Gravatar scroggo2014-12-09
| | | | | | TBR=bsalomon Review URL: https://codereview.chromium.org/757413003
* Revert of Replace EncodeBitmap with an interface. (patchset #11 id:190001 of ↵Gravatar robertphillips2014-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/784643002/) Reason for revert: Compilation is failing on some bots Original issue's description: > Replace EncodeBitmap with an interface. > > Gives more flexibility to the caller to decide whether to use the > encoded data returned by refEncodedData(). > > Provides an implementation that supports the old version of > SkPicture::serialize(). > > TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely > > BUG=skia:3190 > > Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 TBR=reed@google.com,scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:3190 Review URL: https://codereview.chromium.org/787833002
* Fix MatrixImageFilter computeFastBoundsGravatar robertphillips2014-12-09
| | | | | | | | This CL makes the bounding box returned from SkMatrixImageFilter::computeFastBounds actually contain the final result pixels. This, in turn, fixes the first two rows of the filterfastbounds GM and the SVG web page cited in the bug. BUG=418417 Review URL: https://codereview.chromium.org/785893004
* Display text blob bounds in the debugger.Gravatar fmalita2014-12-09
| | | | | | | | Also fix YPOS. R=robertphillips@google.com,jbroman@chromium.org Review URL: https://codereview.chromium.org/786083002
* Cleanup GM:pictureshadertileGravatar fmalita2014-12-09
| | | | | | | | Post review cleanup for https://codereview.chromium.org/733203005/ TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/784053002
* Replace EncodeBitmap with an interface.Gravatar scroggo2014-12-09
| | | | | | | | | | | | | | Gives more flexibility to the caller to decide whether to use the encoded data returned by refEncodedData(). Provides an implementation that supports the old version of SkPicture::serialize(). TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely BUG=skia:3190 Review URL: https://codereview.chromium.org/784643002
* Revert of Make all blending up to GrOptDrawState be handled by the xp/xp ↵Gravatar egdaniel2014-12-08
| | | | | | | | | | | | | | | | | | | | | | | | | factory. (patchset #7 id:140001 of https://codereview.chromium.org/759713002/) Reason for revert: break many gm's Original issue's description: > Make all blending up to GrOptDrawState be handled by the xp/xp factory. > > In this cl the blending information is extracted for the xp and stored in the ODS > which is then used as it currently is. In the follow up cl, an XP backend will be added > and at that point all blending work will take place inside XP's. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7c66342a399b529634bed0fabfaa562db2c0dbd4 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/766653008
* Fix GrUnPreMulColor.Gravatar egdaniel2014-12-08
| | | | | | | | Current version incorrectly unpacked the resulting sk unpremulled color into rgba. BUG=skia:3208 Review URL: https://codereview.chromium.org/787713002
* Remove virtual clear in PdfViewer's SkNulCanvasGravatar robertphillips2014-12-08
| | | | | | Causing compilation complaints on Windows Review URL: https://codereview.chromium.org/783683004
* Make all blending up to GrOptDrawState be handled by the xp/xp factory.Gravatar egdaniel2014-12-08
| | | | | | | | | | In this cl the blending information is extracted for the xp and stored in the ODS which is then used as it currently is. In the follow up cl, an XP backend will be added and at that point all blending work will take place inside XP's. BUG=skia: Review URL: https://codereview.chromium.org/759713002
* Tweak SkPictureShader's tile semantics.Gravatar fmalita2014-12-08
| | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the tile offset is added when drawing the picture. This might have made a tiny bit of sense when the picture was always positioned at origin, but with a picture cull rect offset things looks really strange. For example, to specify a tile == the picture cull rect we have to pass in [-cullrect.x, -cullrect.y, cullrect.width, cullrect.height]. Yikes. (there's also a bug when not passing a tile, as we use a default tile == cullrect but don't compensate for the above oddity) This changes the semantics of the tile offset: it is now subtracted when drawing the picture tile. As a consequence, one can pass in a tile equal to the cull rect and get the expected behavior (same when not passing a tile). This will require a minor Blink change with the roll, as one client works around the current behavior: https://codereview.chromium.org/789503003 R=reed@google.com,robertphillips@google.com BUG=440046 Review URL: https://codereview.chromium.org/733203005