aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert of Add regression test (patchset #2 id:20001 of ↵Gravatar msarett2016-08-16
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2243143002/ ) Reason for revert: Nexus 9 and Nexus Player failures. Original issue's description: > Add regression test > > Original bug fix was in: > https://codereview.chromium.org/2230163002 > > BUG:636268 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243143002 > > Committed: https://skia.googlesource.com/skia/+/bcae9d3d15d34a59d279c34e187e6101975500c0 TBR=reed@google.com,gogil@stealien.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2243403003
* Fix WIC encoder to support kJPEG_TypeGravatar msarett2016-08-15
| | | | | | | | | | | | | | | | | | (1) Add support for kJPEG to WIC (2) Add encoding test. (3) Turn on WIC jpeg encoder on Windows and CG jpeg encoder on Mac. A follow-up may make Skia's encoders the default on all platforms. But, in order to do that, I think we need to write better encoding unit tests for CG and WIC. BUG=skia:3969 BUG=skia:5632 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245453002 Committed: https://skia.googlesource.com/skia/+/b3a7ef1fc0adc24859d2498aee54d3ec2cbcac3a Review-Url: https://codereview.chromium.org/2245453002
* SkPDF: unify drawText and drawPosTextGravatar halcanary2016-08-15
| | | | | | | | | | | | | Motivation: a later CL will add drawTextBlob() (after https://crrev.com/2084533004 lands). This CL is designed with that change in mind. Also fewer redundant lines of code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241683005 Committed: https://skia.googlesource.com/skia/+/6059dc32fe36358175cb81541c91e74a2a7e771a Review-Url: https://codereview.chromium.org/2241683005
* Revert of SkPDF: unify drawText and drawPosText (patchset #2 id:40001 of ↵Gravatar robertphillips2016-08-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2241683005/ ) Reason for revert: I believe this is breaking the Google3 roll Original issue's description: > SkPDF: unify drawText and drawPosText > > Motivation: a later CL will add drawTextBlob() (after > https://crrev.com/2084533004 lands). This CL is designed > with that change in mind. Also fewer redundant lines of > code. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241683005 > > Committed: https://skia.googlesource.com/skia/+/6059dc32fe36358175cb81541c91e74a2a7e771a TBR=bungeman@google.com,halcanary@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2248923002
* Defined SkDEBUGFAILF on Release buildsGravatar hstern2016-08-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244253003 Review-Url: https://codereview.chromium.org/2244253003
* Attempt to throw away rrect clips of rrects.Gravatar bsalomon2016-08-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241273003 Review-Url: https://codereview.chromium.org/2241273003
* Fix compile warning on MSVC-vulkan (VkDeviceSize -> size_t)Gravatar brianosman2016-08-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246183002 Review-Url: https://codereview.chromium.org/2246183002
* Revert of Fix WIC encoder to support kJPEG_Type (patchset #3 id:140001 of ↵Gravatar msarett2016-08-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2245453002/ ) Reason for revert: Broken Windows bot. Original issue's description: > Fix WIC encoder to support kJPEG_Type > > (1) Add support for kJPEG to WIC > (2) Add encoding test. > (3) Turn on WIC jpeg encoder on Windows and CG jpeg > encoder on Mac. > > A follow-up may make Skia's encoders the default on all > platforms. But, in order to do that, I think we need > to write better encoding unit tests for CG and WIC. > > BUG=skia:3969 > BUG=skia:5632 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245453002 > > Committed: https://skia.googlesource.com/skia/+/b3a7ef1fc0adc24859d2498aee54d3ec2cbcac3a TBR=mtklein@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3969 Review-Url: https://codereview.chromium.org/2246203002
* Print error from driver when shader compiler failsGravatar bsalomon2016-08-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248853002 Review-Url: https://codereview.chromium.org/2248853002
* Fix up infra bot changeGravatar fmalita2016-08-15
| | | | | | | | | Follow up to https://codereview.chromium.org/2246943002/. R=mtklein@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247903002 Review-Url: https://codereview.chromium.org/2247903002
* Fix WIC encoder to support kJPEG_TypeGravatar msarett2016-08-15
| | | | | | | | | | | | | | | | | (1) Add support for kJPEG to WIC (2) Add encoding test. (3) Turn on WIC jpeg encoder on Windows and CG jpeg encoder on Mac. A follow-up may make Skia's encoders the default on all platforms. But, in order to do that, I think we need to write better encoding unit tests for CG and WIC. BUG=skia:3969 BUG=skia:5632 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245453002 Review-Url: https://codereview.chromium.org/2245453002
* Revert of add parallel public API for recording SkLiteDL. (patchset #1 id:1 ↵Gravatar mtklein2016-08-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/2246893002/ ) Reason for revert: looking like we won't need this Original issue's description: > add parallel public API for recording SkLiteDL. > > The API is restricted to pretty much just what Derek calls, > but it's enough that we can switch testing over to use it. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002 > > Committed: https://skia.googlesource.com/skia/+/ced26a3d6b77d3a6744a8ccb8eff23eda45fc867 TBR=djsollen@google.com,reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2243393002
* [SVGDom] Add opacity supportGravatar fmalita2016-08-15
| | | | | | | | | | Group opacity support. Unlike the other presentation attributes we support thus far, group opacity is not inherited. R=robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002 Review-Url: https://codereview.chromium.org/2246943002
* Update blurred rrect mask filter creation method to also handle cachingGravatar robertphillips2016-08-15
| | | | | | | | | | | The caching of the mask will also be required for the vertex attribute path so I moved that into the helper. The parameters computed by ComputeBlurredRRectParams will be needed to construct the coverage geometry by the vertex attribute path so I moved that out of the helper. This is split out of https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249463002 Review-Url: https://codereview.chromium.org/2249463002
* add gm that exercises compose shader allocationsGravatar caryclark2016-08-15
| | | | | | | | | | | | This gm triggers the assert in SkSmallAllocator.h commented out by this CL. PDFium constructs shaders that resemble the GM. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249703002 Review-Url: https://codereview.chromium.org/2249703002
* SkPDF: unify drawText and drawPosTextGravatar halcanary2016-08-15
| | | | | | | | | | | | Motivation: a later CL will add drawTextBlob() (after https://crrev.com/2084533004 lands). This CL is designed with that change in mind. Also fewer redundant lines of code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241683005 Review-Url: https://codereview.chromium.org/2241683005
* just add SkLiteDL::empty()Gravatar mtklein2016-08-15
| | | | | | | | | TBR=djsollen@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249713002 Review-Url: https://codereview.chromium.org/2249713002
* LightingFP now supports multiple directional lightsGravatar dvonbeck2016-08-15
| | | | | | | BUG=skia:5518 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239933004 Review-Url: https://codereview.chromium.org/2239933004
* Convert GrAppliedClip interface to builder styleGravatar csmartdalton2016-08-15
| | | | | | | | | | | | | GrAppliedClip was about at its limit for how many "make" functions it could have. Window rectangles would push it over the edge. This change makes it so GrDrawTarget supplies the original draw bounds to the constructor, and then GrClip adds the various required clipping techniques. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246113002 Review-Url: https://codereview.chromium.org/2246113002
* Fix 4444 on Vulkan devices who don't support RGBA_4444Gravatar egdaniel2016-08-15
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002 Committed: https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971 Review-Url: https://codereview.chromium.org/2238563002
* Increase hard and io timeouts for CT builds.Gravatar rmistry2016-08-15
| | | | | | | | BUG=skia:5641 TBR=borenet GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249523004 Review-Url: https://codereview.chromium.org/2249523004
* Add regression testGravatar msarett2016-08-15
| | | | | | | | | | Original bug fix was in: https://codereview.chromium.org/2230163002 BUG:636268 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243143002 Review-Url: https://codereview.chromium.org/2243143002
* Pull handling of blurred circles out of GrRRectBlurEffect::MakeGravatar robertphillips2016-08-15
| | | | | | | | | | GrRRectBlurEffect is going away so this process can't live there anymore. Split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243133002 Review-Url: https://codereview.chromium.org/2243133002
* Revert of increase small allocator limit to encompass compose shader ↵Gravatar caryclark2016-08-15
| | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/2234423005/ ) Reason for revert: Increase in stack broke Google3 Original issue's description: > increase small allocator limit to encompass compose shader > > R=reed@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234423005 > > Committed: https://skia.googlesource.com/skia/+/8c200694f8eec5f623b3934b85c31dbb382be12c TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2244293002
* Optimize color xforms when src and dst are matchingGravatar msarett2016-08-15
| | | | | | | | | | | | | | | Useful when: (1) Client does not realize src and dst match (calls color xform anyway). (2) Client wants half floats, src and dst have matching gamuts (3) Client wants premul (done correctly in linear space), src and dst have matching gamuts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206403003 Review-Url: https://codereview.chromium.org/2206403003
* Fix copying of data in vulkan testing textureGravatar egdaniel2016-08-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248703002 Review-Url: https://codereview.chromium.org/2248703002
* add parallel public API for recording SkLiteDL.Gravatar mtklein2016-08-15
| | | | | | | | | | The API is restricted to pretty much just what Derek calls, but it's enough that we can switch testing over to use it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002 Review-Url: https://codereview.chromium.org/2246893002
* [SVGDom] Deferred SampleApp parsingGravatar fmalita2016-08-15
| | | | | | | | | | Parse SVG files in onOnceBeforeDraw() rather than ctor, to avoid front-loading a bunch of work when passed a loarge number of SVGs. R=stephana@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245993002 Review-Url: https://codereview.chromium.org/2245993002
* Skip CompressCheckerboard unit test on N6.Gravatar mtklein2016-08-15
| | | | | | | | | | | | | | This is at least one of the failures making the bot red. The particular signal indicates it's probably an alignment problem. BUG=skia:5637 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245063002 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-GCC-Nexus6-CPU-NEON-Arm7-Debug-Trybot TBR=robertphillips@google.com Review-Url: https://codereview.chromium.org/2245063002
* Add specialized code for hard stop gradients on GPUGravatar fmenozzi2016-08-15
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223203003 Committed: https://skia.googlesource.com/skia/+/0c63006b88a16e3418d92852a62771615799839d Committed: https://skia.googlesource.com/skia/+/99818d69372d29a139935cfe5c379e491432931b Committed: https://skia.googlesource.com/skia/+/2a4959181fc98d5d7ee862e7cd1c7993b3343be6 Review-Url: https://codereview.chromium.org/2223203003
* Documentation: Important things on front pageGravatar halcanary2016-08-15
| | | | | | | NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2112643003 Review-Url: https://codereview.chromium.org/2112643003
* increase small allocator limit to encompass compose shaderGravatar caryclark2016-08-14
| | | | | | | R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234423005 Review-Url: https://codereview.chromium.org/2234423005
* Webp has_alpha is a hint onlyGravatar msarett2016-08-14
| | | | | | | | | | | | The has_alpha bit on webps is a hint only. We are correct to always assume that the image may have alpha. https://groups.google.com/a/webmproject.org/forum/#!msg/webp-discuss/2rFPKOzxuSM/uabYhmSNJAAJ TBR=scroggo@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243153002 Review-Url: https://codereview.chromium.org/2243153002
* Assert fDeviceClipBounds is always empty when clip is emptyGravatar msarett2016-08-14
| | | | | | | | | | | | | | | | I've fixed a few issues where this assert triggers. The nastiest case is when the client sets the clip to a strange version of an empty rect (Ex: L,T,R,B=0,0,0,10). I think I've made sufficient fixes so that fDeviceClipBounds is always empty when clip is empty. Let's test it though. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246503003 Review-Url: https://codereview.chromium.org/2246503003
* Prevent overflows when using gamma_alloc_sizeGravatar gogil2016-08-14
| | | | | | | BUG=636268 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230163002 Review-Url: https://codereview.chromium.org/2230163002
* Update SKP versionGravatar update-skps2016-08-14
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249443002 Review-Url: https://codereview.chromium.org/2249443002
* Remove stencil settings param from stencilPath()Gravatar csmartdalton2016-08-12
| | | | | | | | | | stencilPath() picks its own user stencil settings. This argument should not be there. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241873002 Review-Url: https://codereview.chromium.org/2241873002
* [SVGDom] SVGPong sample appGravatar fmalita2016-08-12
| | | | | | | | | Shows off SVG dom-based animations. R=robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243853003 Review-Url: https://codereview.chromium.org/2243853003
* Re-adding analytical GeoProc for rectanglesGravatar dvonbeck2016-08-12
| | | | | | | | | | | | | Adapted old GeoProc because its knowledge of the geometry is helpful for computing the distance vector: https://skia.googlesource.com/skia/+/6006d0f8c4f19d19a12de20826f731f52ac822a7/src/gpu/GrAARectRenderer.cpp Added distance vector capabilities to this GeoProc. Modified GrDrawContext to used this GeoProc when drawing anti-aliased vectors with a shader that requires distance vectors. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230513004 Review-Url: https://codereview.chromium.org/2230513004
* Revert of Exact Ganesh Gradients for Special Cases (patchset #9 id:160001 of ↵Gravatar halcanary2016-08-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2223203003/ ) Reason for revert: specualtive revert to fix valgrind bot Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind Original issue's description: > Remove generalized gradient code > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223203003 > > Committed: https://skia.googlesource.com/skia/+/0c63006b88a16e3418d92852a62771615799839d > Committed: https://skia.googlesource.com/skia/+/99818d69372d29a139935cfe5c379e491432931b > Committed: https://skia.googlesource.com/skia/+/2a4959181fc98d5d7ee862e7cd1c7993b3343be6 TBR=bsalomon@google.com,fmenozzi@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2245533005
* [SVGDom] <polygon> & <polyline> supportGravatar fmalita2016-08-12
| | | | | | | R=robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2235273003 Review-Url: https://codereview.chromium.org/2235273003
* Allow vulkan to upload data to testing textures with optimal layoutsGravatar egdaniel2016-08-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242553002 Review-Url: https://codereview.chromium.org/2242553002
* Added PointLights to SkLights::LightGravatar vjiaoblack2016-08-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237493002 Review-Url: https://codereview.chromium.org/2237493002
* Add Android Shadow sampleGravatar jvanverth2016-08-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245693002 Review-Url: https://codereview.chromium.org/2245693002
* Add extracting GM comments to the housekeeper bot.Gravatar jcgregorio2016-08-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237033002 Review-Url: https://codereview.chromium.org/2237033002
* Optimized implementation of quickReject()Gravatar msarett2016-08-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Impl Overview (1) Keep the device clip bounds up to date. This requires minimal additional work in a few places throughout canvas. (2) Keep track of if the ctm isScaleTranslate. Yes, there's a function that does this, but it's slow to call. (3) Perform the src->device transform in quick reject, then check intersection/nan. Other Notes: (1) NaN and intersection checks are performed simultaneously. (2) We no longer quick reject infinity. (3) Affine and perspective are both handled in the slow case. (4) SkRasterClip::isEmpty() is handled by the intersection check. Performance on Nexus 6P: 93.2ms -> 59.8ms Overall Android Jank Tests Performance Impact: Should gain us a ms or two on some tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225393002 Committed: https://skia.googlesource.com/skia/+/d22a817ff57986407facd16af36320fc86ce02da Review-Url: https://codereview.chromium.org/2225393002
* SkPDF: Subset Type3 (fallback) fontGravatar halcanary2016-08-12
| | | | | | | | | | | | | | | | | | | Motivation: significant file-size reduction. Also: SkPDFFont::subsetFont() returns a sk_sp<SkPDFObject> rather than a SkPDFFont*. SkPDFType3Font constructor no longer populates font info; relies on subsetting. SkPDFFont::Create is easier to read Also: SkPDFType3Font are scaled by emSize rather than 1000. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231483002 Committed: https://skia.googlesource.com/skia/+/88b138da99328b04cae9a8ee19c3882b8847a550 Review-Url: https://codereview.chromium.org/2231483002
* Turn on SVGs for all Test botsGravatar rmistry2016-08-12
| | | | | | | BUG=skia:5628 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240153002 Review-Url: https://codereview.chromium.org/2240153002
* Remove generalized gradient codeGravatar fmenozzi2016-08-12
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223203003 Committed: https://skia.googlesource.com/skia/+/0c63006b88a16e3418d92852a62771615799839d Committed: https://skia.googlesource.com/skia/+/99818d69372d29a139935cfe5c379e491432931b Review-Url: https://codereview.chromium.org/2223203003
* Create gradient fuzzersGravatar kjlubick2016-08-12
| | | | | | | | | This would have caught the bug patched by https://codereview.chromium.org/2234663002 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239463002 Review-Url: https://codereview.chromium.org/2239463002