aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove test expectations from ignored-tests.txt.Gravatar senorblanco2014-10-23
| | | | | | | | TBR=mtklein@google.com NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/659393006
* Adding an option to render only the shadow in SkDropShadowImageFilterGravatar sugoi2014-10-23
| | | | | | | | This is basically how blink uses the filter. Currently, I can't use it for "ShadowOnly" mode with the filter at all, but instead of copying the code and risking to have the codepaths diverge, I'm simply going to add the option here. BUG=skia: Review URL: https://codereview.chromium.org/646213004
* Rebaselines for tests affected by image filter PDF change.Gravatar senorblanco2014-10-23
| | | | | | | | | | | (aka https://codereview.chromium.org/644323006/) TBR=mtklein@google.com NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/671303003
* Add utils to better quantize grayscale values to three bit indices whileGravatar pavel2014-10-23
| | | | | | | | | | compressing coverage masks. Signed-off-by: Pavel Krajcevski <pavel@cs.unc.edu> BUG=skia: Review URL: https://codereview.chromium.org/669243003
* add float equivalent in dumpHex output as commentGravatar caryclark2014-10-23
| | | | | | R=reed@google.com,bsalomon@google.com Review URL: https://codereview.chromium.org/676803002
* Revert of create shaderproc for nofilter-opaque-dx (patchset #7 id:120001 of ↵Gravatar mtklein2014-10-23
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/664783004/) Reason for revert: Many GMs fixed. Needs rebaseline, perhaps layout test rebaselines. Original issue's description: > create shaderproc for nofilter-opaque-dx > > > speedup nofilter > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/a40a276bcee2246439dcf816273c1307f5c3c69f TBR=djsollen@google.com,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/656913005
* use SkMaskCache inside SkBlurMaskFilterGravatar reed2014-10-23
| | | | | | | | depends on https://codereview.chromium.org/670063004/ BUG=skia: Review URL: https://codereview.chromium.org/669993003
* Correct typo in SkRemotableFontMgr_win_dw.cpp.Gravatar bungeman2014-10-23
| | | | | | | New code was introduced behind a flag, but in that code there is a comma before a parameter name instead of after. Review URL: https://codereview.chromium.org/646323003
* create shaderproc for nofilter-opaque-dxGravatar reed2014-10-23
| | | | | | | | speedup nofilter BUG=skia: Review URL: https://codereview.chromium.org/664783004
* Revert of Add test for new FrontBufferedStream behavior. (patchset #1 id:1 ↵Gravatar mtklein2014-10-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/641813009/) Reason for revert: Test is SkASSERTing on Macs, e.g: http://chromegw.corp.google.com/i/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/builds/257/steps/dm/logs/stdio 210 tasks left 1737M peak 1ms test FrontBufferedStream../../src/ports/SkImageDecoder_CG.cpp:43: failed assertion "data" Signal 11: _sigtramp (+0x1a) SkStreamToCGImageSource(SkStream*) (+0x62) SkImageDecoder_CG::onDecode(SkStream*, SkBitmap*, SkImageDecoder::Mode) (+0x2e) SkImageDecoder::decode(SkStream*, SkBitmap*, SkColorType, SkImageDecoder::Mode) (+0x81) SkImageDecoder::DecodeStream(SkStreamRewindable*, SkBitmap*, SkColorType, SkImageDecoder::Mode, SkImageDecoder::Format*) (+0xff) SkImageDecoder::DecodeStream(SkStreamRewindable*, SkBitmap*) (+0x31) test_ShortFrontBufferedStream(skiatest::Reporter*) (+0x97) skiatest::ShortFrontBufferedStreamClass::onRun(skiatest::Reporter*) (+0x19) skiatest::Test::run() (+0x7c) DM::CpuTestTask::draw() (+0x5a) DM::CpuTask::run() (+0x9e) non-virtual thunk to DM::CpuTask::run() (+0x1c) (anonymous namespace)::ThreadPool::Loop(void*) (+0xf4) thread_start(void*) (+0x54) _pthread_start (+0x14b) Original issue's description: > Add test for new FrontBufferedStream behavior. > > Test for https://skia.googlesource.com/skia/+/dd5a1e094c19fa10202c37c50a1f799e5af5dac0 > > Verify that FrontBufferedStream does not attempt to read beyond the > end of its underlying stream. > > Committed: https://skia.googlesource.com/skia/+/da59f05c6738dbb9a92cad21c608cdfae53a76b2 TBR=reed@google.com,scroggo@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/649553003
* Allocate only the vertices we need for text.Gravatar jvanverth2014-10-23
| | | | | | | | | | This restructures the vertex allocation for text rendering to compute the max number of vertices we would need for a line of text, and then only allocate that much. If this number exceeds the quad index limit, then it will allocate for the max number of quads, and reallocate for the rest later. Review URL: https://codereview.chromium.org/663423003
* updating k1 expectationsGravatar joshualitt2014-10-23
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/642543003
* Removed simple tests steps from CanvasTest.Gravatar piotaixr2014-10-23
| | | | | | | | | | | | | CanvasTest only checks if the state of the different canvas implementations are consistent with the one of the default implementation. Because most of the draw calls are stateless and already tested in GMs the test steps that exercices them are not useful. BUG=skia:3054 Review URL: https://codereview.chromium.org/672273002
* Remove android specific genID from SkPaint.Gravatar djsollen2014-10-23
| | | | Review URL: https://codereview.chromium.org/677453002
* Add test for new FrontBufferedStream behavior.Gravatar scroggo2014-10-23
| | | | | | | | | Test for https://skia.googlesource.com/skia/+/dd5a1e094c19fa10202c37c50a1f799e5af5dac0 Verify that FrontBufferedStream does not attempt to read beyond the end of its underlying stream. Review URL: https://codereview.chromium.org/641813009
* This return_false is now only used on Android. Squelch a warning.Gravatar mtklein2014-10-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/659393004
* Rename Nexus9 expectationsGravatar borenet2014-10-23
| | | | | | | BUG=skia:3047 TBR=djsollen Review URL: https://codereview.chromium.org/652003003
* Add SkMaskCacheGravatar qiankun.miao2014-10-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/670063004
* Revert of Delete unused method aliases and texture flag. (patchset #1 id:1 ↵Gravatar bsalomon2014-10-23
| | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/672753002/) Reason for revert: Need to remove one more reference to this in blink before relanding. Original issue's description: > Delete unused method aliases and texture flag. > > Committed: https://skia.googlesource.com/skia/+/7fdffe41494cbd78a8ee2a6ef0509e46ec77039f TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/671203002
* Update fontMgr to take list of bcp47 language tags.Gravatar bungeman2014-10-23
| | | | | | | | | This will enable clients to pass more than one bcp47 tag to ensure that the most appropriate font is selected. BUG=chromium:422180 Review URL: https://codereview.chromium.org/670243002
* Delete unused method aliases and texture flag.Gravatar bsalomon2014-10-23
| | | | Review URL: https://codereview.chromium.org/672753002
* fix memory leakGravatar joshualitt2014-10-22
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/668333005
* some more expectations, update ignoresGravatar joshualitt2014-10-22
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/668393002
* New baselinesGravatar joshualitt2014-10-22
| | | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/668823006
* one more test to ignoreGravatar joshualitt2014-10-22
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/674713002
* Oval and stroke AA rect now batchGravatar joshualitt2014-10-22
| | | | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d Committed: https://skia.googlesource.com/skia/+/18055afb838a278b5a8436cd51dbfbb688e1e0a0 Review URL: https://codereview.chromium.org/664193002
* Revert of Oval and stroke AA rect now batch (patchset #7 id:110001 of ↵Gravatar joshualitt2014-10-22
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/664193002/) Reason for revert: whoops, accidental commit Original issue's description: > Oval and stroke AA rect now batch > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d > > Committed: https://skia.googlesource.com/skia/+/18055afb838a278b5a8436cd51dbfbb688e1e0a0 TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/675623002
* Oval and stroke AA rect now batchGravatar joshualitt2014-10-22
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d Review URL: https://codereview.chromium.org/664193002
* Revert of Oval and stroke AA rect now batch (patchset #7 id:110001 of ↵Gravatar mtklein2014-10-22
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/664193002/) Reason for revert: Many GMs failing, e.g. http://build.chromium.org/p/client.skia.android/builders/Test-Android-Nexus5-Adreno330-Arm7-Release/builds/95/steps/Compare%20GMs/logs/stdio Original issue's description: > Oval and stroke AA rect now batch > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d TBR=robertphillips@google.com,joshualitt@google.com,bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/671993003
* Oval and stroke AA rect now batchGravatar joshualitt2014-10-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/664193002
* Add SkTypeface::getBounds()Gravatar reed2014-10-22
| | | | | | | | | mirrored from https://codereview.chromium.org/666303002/ BUG=skia: TBR= Review URL: https://codereview.chromium.org/676523002
* fix some bit-rot in the ios port of sampleappGravatar reed2014-10-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/637263004
* Qualify the return value of SkImageDecoder::decodeGravatar scroggo2014-10-22
| | | | | | | | | | | | | | | | | | | | | | | Add a new enum to differentiate between a complete decode and a partial decode (with the third value being failure). Return this value from SkImageDecoder::onDecode (in all subclasses, plus SkImageDecoder_empty) and ::decode. For convenience, if the enum is treated as a boolean, success and partial success are both considered true. Note that the static helper functions (DecodeFile etc) still return true and false (for one thing, this allows us to continue to use SkImageDecoder::DecodeMemory as an SkPicture::InstallPixelRefProc in SkPicture::CreateFromStream). Also correctly report failure in SkASTCImageDecoder::onDecode when SkTextureCompressor::DecompressBufferFromFormat fails. BUG=skia:3037 BUG:b/17419670 Review URL: https://codereview.chromium.org/647023006
* webtry: Improve error handling/message when creating sqlite tables.Gravatar tfarina2014-10-22
| | | | | | | | | | | In case they fail, lets fail with an ERROR message rather than an INFO, and lets make the error message a little bit better. BUG=None TEST=None R=jcgregorio@google.com Review URL: https://codereview.chromium.org/669643004
* explicitly size fType in SkRRect, to ensure the are no uninitialized bytesGravatar reed2014-10-22
| | | | | | | | (so it can be used as a key in a cache) BUG=skia: Review URL: https://codereview.chromium.org/670183002
* SkResourceCache::Key namespace support.Gravatar fmalita2014-10-22
| | | | | | | | | | | | Add a unique-per-subclass namespace tag to make Keys from different domains comparable. Also drop the SkPictureShader cache and convert to using the global resource cache instead. R=reed@google.com,mtklein@google.com,robertphillips@google.com Review URL: https://codereview.chromium.org/668223002
* Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipeGravatar piotaixr2014-10-22
| | | | | | | | | | Depend on https://codereview.chromium.org/663233002 BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8 Review URL: https://codereview.chromium.org/613673005
* GP Emit Code takes a structGravatar joshualitt2014-10-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/666693012
* More genericity: overload isPaintOpaque(SkPaint, SkBitmap)Gravatar piotaixr2014-10-22
| | | | | | | | | | | Instead of taking a Bitmap as an argument this version takes only the type of content (None/Opaque/Transparent). This will be used to check the opaqueness of a SkPaint that draws a SkImage. BUG=skia:3042 Review URL: https://codereview.chromium.org/663233002
* Use correct size for font style name search.Gravatar bungeman2014-10-22
| | | | | | | | | | This fixes an out of bounds read introduced with a4c4a2d8cd65abb1e5ac20813831cdb9ace6c7ee "Replace SkTypeface::Style with SkFontStyle." BUG=chromium:425856 Review URL: https://codereview.chromium.org/645223006
* Picture shader resource caching.Gravatar fmalita2014-10-22
| | | | | | | | | | | | | Replace the current/naive shader caching mechanism with a more general implementation based on SkResourceCache. Caching the bitmap shader itself (as opposed to just the tile bitmap) makes for a chunkier key, but OTOH avoids allocating new shaders on cache hit. R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/671683004
* Ignore failure on internal botGravatar joshualitt2014-10-22
| | | | | | | BUG=skia:3023 TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/640063004
* Add back page_sets/skia_googlespreadsheet_desktopGravatar rmistry2014-10-22
| | | | | | | | | Absolutely could not get the old page to work so I just created a new page. NOTRY=true BUG=skia:3008 Review URL: https://codereview.chromium.org/671883002
* Track nested picture xform state for layer hoistingGravatar robertphillips2014-10-22
| | | | | | The accumulated matrix state of any enclosing SkPictures must be stored separate from the picture-local CTM. Any setMatrix calls inside a layer need to replace the picture-local CTM but concatenate with the enclosing SkPicture transform state (and the transform state needed to translate the layer to the correct location in the cached GrTexture). Review URL: https://codereview.chromium.org/639863005
* Update webpages_playback script and all page_sets to use new ↵Gravatar rmistry2014-10-22
| | | | | | | | | | | | | | | | skpicture_printer benchmark The purpose of this CL is to turn the RecreateSKPs bot green after https://codereview.chromium.org/665193002/ lands. Description of changes in this CL: * After https://codereview.chromium.org/665193002/ lands we will no longer need to copy the archives and pagesets to telemetry's data directory, I removed the code that did this in https://codereview.chromium.org/655313003/ * page_sets now need unique class names. Updated all page_sets to have unique class names. * Using the new --page_set_name and --page_set_base_dir and --also-run-disabled-tests parameters BUG=skia:3046 Review URL: https://codereview.chromium.org/671513009
* Bug fix for es 3.00 fb fetchGravatar joshualitt2014-10-21
| | | | | | | | patch for es 300 shader fb fetch BUG=skia: Review URL: https://codereview.chromium.org/665893008
* add round/ceil/etc. for SkMScalarGravatar reed2014-10-21
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/645793006
* Draw SKPs in 256x256 tiles in nanobench.Gravatar mtklein2014-10-21
| | | | | | | | (This CL will certainly trigger performance regression alerts. Tiled drawing is slower than non-tiled drawing.) BUG=skia: Review URL: https://codereview.chromium.org/669983002
* Implement maxrss for WindowsGravatar mtklein2014-10-21
| | | | | | | | | | No more -1 in the first column on Windows! E.g. http://build.chromium.org/p/client.skia/builders/Perf-Win8-ShuttleA-HD7770-x86_64-Release-Trybot/builds/0/steps/nanobench/logs/stdio BUG=skia: Review URL: https://codereview.chromium.org/661413004
* SkLazyPtr follow upsGravatar mtklein2014-10-21
| | | | | | | | | - moves test to LazyPtrTest.cpp - adds the ability to use a Create() method with an argument BUG=skia: Review URL: https://codereview.chromium.org/669783002