aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix memory leak in https://skia-review.googlesource.com/c/4227/ (Back ↵Gravatar robertphillips2016-11-02
| | | | | | | | SkSpecialImage_Gpu with a GrTextureProxy) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2472703005 Review-Url: https://codereview.chromium.org/2472703005
* Add a Windows Android builder.Gravatar Mike Klein2016-11-02
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4320 Change-Id: Ifd693f5de978565f694bc0173a1248e705303e68 Reviewed-on: https://skia-review.googlesource.com/4320 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* s/C++'s gmtime/POSIX's gmtime_r/Gravatar Hal Canary2016-11-02
| | | | | | | | | | | BUG=skia:5923 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4341 Change-Id: I258da9bfa98f16e1abdea0f18ae786f9df118a8e Reviewed-on: https://skia-review.googlesource.com/4341 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com>
* Update vulkan ranges to be 0 to 1 for all z valuesGravatar Greg Daniel2016-11-02
| | | | | | | | | | | | | | The spec has been updated to require setting the range for z/depth values to be 0-1 when the image is 2D instead of just ignoring the field as before. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4308 Change-Id: Ic054ee732472cd9c69f7197fd62cb0cb4f2b26ce Reviewed-on: https://skia-review.googlesource.com/4308 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* For debug builds, -O0 by default, adding -O1 only on bots.Gravatar Mike Klein2016-11-02
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4344 Change-Id: Idc1435d75e51ea0b54d369efa91993d369aa74c0 Reviewed-on: https://skia-review.googlesource.com/4344 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update ProxyTestsGravatar Robert Phillips2016-11-02
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4306 Change-Id: I0753047eeda71a22b6126f932fc14dd242c5a2e7 Reviewed-on: https://skia-review.googlesource.com/4306 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Back SkSpecialImage_Gpu with a GrTextureProxyGravatar Robert Phillips2016-11-02
| | | | | | | | | | | | | This is split out of https://codereview.chromium.org/2215323003/ (Start using RenderTargetProxy (omnibus)) The addition of the gpuMemorySize methods is for the SkSpecialImage cache. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4227 Change-Id: Ia9b9d42fb2a0caf61bbfa3ebcc84308c56f541fc Reviewed-on: https://skia-review.googlesource.com/4227 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add a Windows Android NDK asset.Gravatar Mike Klein2016-11-02
| | | | | | | | | | | | | | | We can build for Android from Windows now. I intend to add a bot to keep it that way, just like Build-Mac-Clang-arm64-Debug-GN_Android does for Mac. The Windows Android builder will need this NDK. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4280 DOCS_PREVIEW= https://skia.org/?cl=4280 Change-Id: Ifaeeb9b81822a410bdf79b39c7e66d0765f78e0b Reviewed-on: https://skia-review.googlesource.com/4280 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Loosen restriction on F16 surfaces - allow "legacy" F16 modeGravatar Brian Osman2016-11-01
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4231 Change-Id: I032cdf82468ca11639760eb99773a88a5808ebe6 Reviewed-on: https://skia-review.googlesource.com/4231 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove SkImageInfoIsGammaCorrect, etc...Gravatar Brian Osman2016-11-01
| | | | | | | | | | | | | | | | | | | | Our internal definition is (and will continue to be) that anything with a color space is gamma correct. F16 is irrelevant (whether or not we choose to support untagged F16). This makes these helpers less than helpful, and lets us remove them from (public) API. API change is just removal (of unused functions). TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4228 Change-Id: Ia84a423548bfee14a3ba4a43d6d5b8c4686fb5ff Reviewed-on: https://skia-review.googlesource.com/4228 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Sk4fLinearGradient fuzzer fixesGravatar fmalita2016-11-01
| | | | | | | | | | | | | | 1) update in_range() to actually follow the documented rules regarding interval open/close endpoints 2) detect cases where the intervals provide negligible advance and fall back to using a color average BUG=skia:5647 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2472483002 Review-Url: https://codereview.chromium.org/2472483002
* remove legacy flags from g3Gravatar Mike Reed2016-11-01
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4225 Change-Id: Icb3e8f132975d1ef2b6b89de05b49f89e2424f78 Reviewed-on: https://skia-review.googlesource.com/4225 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Make fuzzers use cleaner interfaceGravatar Kevin Lubick2016-11-01
| | | | | | | | | | | | | | | signalBoring() no longer exists. When the fuzzer runs out of randomness, it just returns 0. Fuzzers should not go into infinite loops if this happens. do while loops are particularly error-prone. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3963 Change-Id: Iebcfc14cc6b0a19c5dd015cd39875c81fa44003e Reviewed-on: https://skia-review.googlesource.com/3963 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* SkRasterPipeline: implement SkLumaColorFilterGravatar Mike Klein2016-11-01
| | | | | | | | | | | | | | | | | | After getting discouraged by the non-separable xfermodes, I decided to look at filling out the color filters instead. This one's nice and easy. There's only 1 GM that exercises this color filter, and it's drawing noticeably lighter now in f16 and sRGB configs. 565 is unchanged. This makes me think the diffs are due to lost precision in the previous method, which was going through the default fallback to 8888 filterSpan(). I double checked: the f16 config now draws nearly identically to the gpuf16 config. It used to be quite different. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4183 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Change-Id: Ic6feaecae5cf18493b5df89733f6a5ca362e9a75 Reviewed-on: https://skia-review.googlesource.com/4183 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* fixed skslc's handling of ivec(vec)Gravatar Ethan Nicholas2016-11-01
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4222 Change-Id: I9b32067af51f3a04efa702cf2eb1ac1ed480df6a Reviewed-on: https://skia-review.googlesource.com/4222 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Delete qcmsGravatar Matt Sarett2016-11-01
| | | | | | | | | | | | | | | | | | | | This was always intended to be a temporary dependency to use for testing. It has served its purpose. Also, this has already been dropped (accidentally, I think) by the new GN build. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4220 Change-Id: Ic72ee08bbfaf86ed86a4122fd38be2921eb1327e Reviewed-on: https://skia-review.googlesource.com/4220 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Allow most third_party targets to use system libraries if asked.Gravatar Mike Klein2016-11-01
| | | | | | | | | | | | | | | | | This extends the pattern in freetype2 to expat, icu, libjpeg-turbo, libpng, libwebp, and zlib, and gives all these an arg to control which to use. Homebrew doesn't have dng_sdk, piex, or sftnly, or I'd have done the same for them too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4260 DOCS_PREVIEW= https://skia.org/?cl=4260 Change-Id: I82e780502bf2217336e791787f172a6fc8f55460 Reviewed-on: https://skia-review.googlesource.com/4260 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Hal Canary <halcanary@google.com>
* hide setImageFilter(ptr)Gravatar Mike Reed2016-11-01
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4184 Change-Id: Iad792cfdf54087ad4c424fd268559c162a9a5f5c Reviewed-on: https://skia-review.googlesource.com/4184 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Remove GrStencilSettings from GrPipelineGravatar csmartdalton2016-11-01
| | | | | | | | | | | | | | | | Updates the GrPipeline to have user stencil settings instead of actual settings. This allows us to further defer creating and attaching a stencil buffer. This change is a partial step. The ultimate goal is to attach the stencil buffer and create the stencil settings during render target flush, but for the sake of keeping this CL smaller, we create the stencil settings right before use for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468653002 Review-Url: https://codereview.chromium.org/2468653002
* SkPDF: Always individually position glyphs in Windows.Gravatar Hal Canary2016-11-01
| | | | | | | | | | | Confirmed to fix BUG=chromium:659604 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4202 Change-Id: Ied25284e285ee51ee1a4712b7e17d752f50d88d2 Reviewed-on: https://skia-review.googlesource.com/4202 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Report repetition count in SkCodecGravatar scroggo2016-11-01
| | | | | | | | | | | | | | | | | | | | | Add a new accessor to retrieve the repetition count. Remove constants (and corresponding copyright) in SkCodecAnimation. These may make sense for the calling code, but are not needed here. kRepetitionCountInfinite corresponds to Blink's kAnimationLoopInfinite. Move cLoopCountNotSeen to private. It is used to determine whether we still need to parse. Add a new enum to the parse query - only parse enough to determine the repetition count. Unlike Chromium, SkGifCodec does not account for deleting the reader (which SkGifCodec does not do) or failed decodes. Add a test. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2447863002 Review-Url: https://codereview.chromium.org/2447863002
* Move memoization of multisample specs id to GrRenderTargetGravatar csmartdalton2016-11-01
| | | | | | | | | | | GrGpu used to perform the memoization on behalf of GrRenderTarget via a public accessor. This change updates GrRenderTarget to do its own work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2467593002 Review-Url: https://codereview.chromium.org/2467593002
* TEMPORARY: track stencil clip state in GrRenderTargetOpListGravatar csmartdalton2016-11-01
| | | | | | | | | | | Tracks the stencil clip state in GrRenderTargetOpList instead of GrStencilAttachment. This is a temporary move to unblock MDB, after which point we will be able to overhaul clipping. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468743002 Review-Url: https://codereview.chromium.org/2468743002
* Remove check of INITIALIZATION_FAILED in qcomm vulkan runsGravatar Greg Daniel2016-10-31
| | | | | | | | | | | | | | | | This was another workaround for a flaky bug that happened on Adreno devices. With all the devices updated to newer drivers I want to see if it still happens. I haven't been able to repo the original bug locally with multiple runs, so I think it is time to step it up to the bots. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4212 Change-Id: Idc260785096b054cf0fb30ce9ff0d97178c10ed6 Reviewed-on: https://skia-review.googlesource.com/4212 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add SkShadowMaskFilterGravatar Jim Van Verth2016-10-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3824 Change-Id: Idde7f7d6a61583a8be26df7a7c4b293c4710bccf Reviewed-on: https://skia-review.googlesource.com/3824 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Always write files in binary mode when unzippingGravatar Brian Osman2016-10-31
| | | | | | | | | | | | | | Prevents CRLF conversion on Windows, which was corrupting SKP files downloaded with fetch-skps BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4210 Change-Id: Ia876f403d10792ee185d50a29fe30402b733441d Reviewed-on: https://skia-review.googlesource.com/4210 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* remove lots of legacy flagsGravatar Mike Reed2016-10-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4209 Change-Id: I49ae36a9b2bb51a6470638d3264923ff4a4dea0a Reviewed-on: https://skia-review.googlesource.com/4209 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Use correct color table for prior GIF framesGravatar Leon Scroggins III2016-10-31
| | | | | | | | | | | | | | | | | | | | | | | | | | While investigating skbug.com/5883 I noticed that we use the color table for the current frame even while recursively decoding frames that the current frame depends on. This CL updates fCurrColorTable, fCurrColorTableIsReal and fSwizzler before decoding prior frames, and then sets them back afterwards. Move telling the client about the color table into prepareToDecode, since the other callers do not need to do so. (That is only necessary for decoding to index 8, which is unsupported for frames with dependencies.) Add a test that exposes the bug. colorTables.gif has a local color table in its second frame that does not match the global table used by the first frame. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4208 Change-Id: Id2dc9e3283adfd92801d2f38726afa74574b1955 Reviewed-on: https://skia-review.googlesource.com/4208 Reviewed-by: Joost Ouwerling <joostouwerling@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Tag images as sRGB by default in SkCodecGravatar Matt Sarett2016-10-31
| | | | | | | | | | | | | | Unmarked images should be treated as sRGB. BUG=skia:4895 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4151 Change-Id: I5f8c308d22fd2d069cbfa89c5a5bb19ae6fde8bd Reviewed-on: https://skia-review.googlesource.com/4151 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Fork skia_vulkan_sdk default value on is_android.Gravatar Mike Klein2016-10-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4205 Change-Id: I091801af7e5e0093ef01a5708c0994928997ddf3 Reviewed-on: https://skia-review.googlesource.com/4205 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add GrNextSizePow2Gravatar Robert Phillips2016-10-31
| | | | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4069 BUG=skia:5882 Change-Id: Ib9af5918716be594c3c07239eca179dbb4eb8566 Reviewed-on: https://skia-review.googlesource.com/4069 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Reject non-D50 matrices from ICC profilesGravatar Matt Sarett2016-10-31
| | | | | | | | | | | | BUG:660838 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4200 Change-Id: Ib57eb3705d6fe638e3a9cb56788937fc7e282847 Reviewed-on: https://skia-review.googlesource.com/4200 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Update Nexus6p to MR1 build.Gravatar Ben Wagner2016-10-31
| | | | | | | | | | | | BUG=skia:5908 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4157 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-Clang-Nexus6p-GPU-Adreno430-arm64-Debug-GN_Android_Vulkan Change-Id: I7b670f878e5df9c5785b56fd5694c7601655710a Reviewed-on: https://skia-review.googlesource.com/4157 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* remove bunch of legacy flagsGravatar Mike Reed2016-10-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4203 Change-Id: I0e23437a77cd8f70595ca54ae421a420e2bb9b43 Reviewed-on: https://skia-review.googlesource.com/4203 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove legacy xfermode build flagGravatar Mike Reed2016-10-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4201 Change-Id: Id60623220daf5a600d8143dedc46714c8dd9896d Reviewed-on: https://skia-review.googlesource.com/4201 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Minor fix to GN for vulkan android buildsGravatar Greg Daniel2016-10-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4155 Change-Id: Ib6a630bbdaf503ff44fbc699aaffdf13ee9c2b59 Reviewed-on: https://skia-review.googlesource.com/4155 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Script to fix GN generated solutionsGravatar Brian Osman2016-10-31
| | | | | | | | | | | | | | | | | | Assumes that all GN configurations are in 'out'. Takes the name of a single directory (which should have been generated with --ide=vs) as input. Creates a new solution and project tree in 'out/sln/skia.sln' with one configuration per directory in 'out'. Example: From skia directory, run 'python fix-gn-sln.py Debug' BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4158 Change-Id: I797b779eb5bc30cec0e6741d4262894fc0648e97 Reviewed-on: https://skia-review.googlesource.com/4158 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* Reland "Build SkRawCodec in GN"Gravatar scroggo2016-10-31
| | | | | | | | | | | | | | | | Add BUILD.gn files for dng_sdk and piex and updated BUILD.gn to build SkRawCodec. We stopped testing raw images when we switched to GN, so this will bring back our testing. Leave SkRawCodec disabled on Windows, where we've had problems in the past. Originally landed in issue 4603. Reverted due to build errors. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2463433002 Review-Url: https://codereview.chromium.org/2463433002
* Draw Alpha8 + color filter correctly in softwareGravatar Matt Sarett2016-10-31
| | | | | | | | | | | | | This makes the behavior match our gpu backend. BUG=android:31019366 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3979 Change-Id: I941623d0bdf54f61aafb1383de46bbedceb7578d Reviewed-on: https://skia-review.googlesource.com/3979 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* update SkFixed15 float conversion notes.Gravatar Mike Klein2016-10-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4181 Change-Id: Iec7ec71340a2b17db067b5e7fc0c34f3a2d313b2 Reviewed-on: https://skia-review.googlesource.com/4181 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix GN config for skpbenchGravatar Jim Van Verth2016-10-31
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4154 Change-Id: I817ce9d8baa72200c622e38e954c81ea37bd99e8 Reviewed-on: https://skia-review.googlesource.com/4154 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add missing sk_tool_utils flags_common dependencyGravatar fmalita2016-10-31
| | | | | | | | | | | | | | | | | | | | Not sure why this is only a problem on my workstation, but SampleApp linking is borked with obj/gyp/../tools/sk_tool_utils.sk_tool_utils.o: In function `sk_tool_utils::platform_os_name()': /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:128: undefined reference to `FLAGS_key' /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:129: undefined reference to `FLAGS_key' /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:127: undefined reference to `FLAGS_key' obj/gyp/../tools/sk_tool_utils.sk_tool_utils.o: In function `sk_tool_utils::major_platform_os_name()': /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:140: undefined reference to `FLAGS_key' /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:141: undefined reference to `FLAGS_key' obj/gyp/../tools/sk_tool_utils.sk_tool_utils.o:/mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:139: more undefined references to `FLAGS_key' follow collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. R=mtklein@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2464903002 Review-Url: https://codereview.chromium.org/2464903002
* Disable some SkDebugfs for dbg bots debuggingGravatar liyuqian2016-10-31
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2464893002 Review-Url: https://codereview.chromium.org/2464893002
* SkPixmap::getColor()Gravatar Hal Canary2016-10-31
| | | | | | | | | | | Implement SkBitmap::getColor() in terms of SkPixmap::getColor(). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4160 Change-Id: I6192a7979d82b3d301a06ae1339bcab4c7ebf7c1 Reviewed-on: https://skia-review.googlesource.com/4160 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkFixed15Gravatar Mike Klein2016-10-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3981 Change-Id: I811b22004e8e2d5b7135f574caea296ffdff7011 Reviewed-on: https://skia-review.googlesource.com/3981 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* update androidsdkcanvas for SkBlendModeGravatar reed2016-10-31
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2464433003 TBR= Review-Url: https://codereview.chromium.org/2464433003
* add isAlphaOnly() queryGravatar reed2016-10-31
| | | | | | | | | BUG=skia:5904 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461773002 TBR= Review-Url: https://codereview.chromium.org/2461773002
* Treat a GIF with no color table as transparentGravatar scroggo2016-10-31
| | | | | | | | | | | | | | | When checking to see whether a GIF has transparency to determine its alpha type, treat an empty color table as having alpha, since we will draw it as a transparent image. (This is a separate bug from skbug.com/5883, but the image I used to verify that bug was drawn to 565 as black. The fix is to not support 565 in that case, by changing its recommended alpha type.) BUG=skia:5883 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461813002 Review-Url: https://codereview.chromium.org/2461813002
* Revert "Speculative fix for flaky webp encode/decode on Nexus 5"Gravatar Matt Sarett2016-10-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 18a11a6f374fe430c8736c53ff4f8bc3c72cd54b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Speculative fix for flaky webp encode/decode on Nexus 5 > > I'm not really expecting this to work anymore... > > The docs don't say anything about the rgb pointer needing > to stay valid, and it looks like we are done with it > after the call to import. > > Still, worth a try I think. > > BUG=skia:5876 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4024 > > Change-Id: I6e65ef96a2b661b01eb92bedab0acd73ed4f6218 > Reviewed-on: https://skia-review.googlesource.com/4024 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Matt Sarett <msarett@google.com> > TBR=mtklein@chromium.org,msarett@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Id764782ea58acc99e4719c0bff22619abaf9c6e5 Reviewed-on: https://skia-review.googlesource.com/4150 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Update SKP versionGravatar update-skps2016-10-30
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461223002 Review-Url: https://codereview.chromium.org/2461223002
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-25 19:14:12 +0000