aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Check pixelRef before attempting to ktx encode.Gravatar scroggo2014-07-02
| | | | | | | | | | | | | | If there is no pixelRef, do not attempt to dereference it. This was caught running on Android, where we don't have the resources folder (tracked in b/14406768). We fail to decode anything, and then attempt to encode an SkBitmap without a pixelRef. R=krajcevski@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/362413005
* Gate CrashHandler with SK_CRASH_HANDLER.Gravatar mtklein2014-07-02
| | | | | | | | | BUG=skia: R=bsalomon@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/364033002
* More expectation updates for https://codereview.chromium.org/337603008.Gravatar jvanverth2014-07-02
| | | | | | | | | R=bungeman@google.com TBR=bungeman@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/368073002
* rebaseline_server: add urlSchemaVersion parameterGravatar epoger2014-07-02
| | | | | | | | | | | | In https://codereview.chromium.org/369473005 ('rebaseline_server: handle category filtering more generically'), I am changing the meaning of some URL parameters. If a user pastes an old URL into an updated rebaseline_server instance, they may get unexpected results. Adding a urlSchemaVersion parameter allows us to automatically convert the URL, or at least warn the user. BUG=skia:2230 NOTRY=True R=jcgregorio@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/368933002
* Make GrAllocator Iter return non-const TGravatar bsalomon2014-07-02
| | | | | | | | R=egdaniel@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/362333004
* Remove SK_IGNORE_FASTER_TEXT_FIX.Gravatar Ben Wagner2014-07-02
| | | | This flag is no longer defined, so remove its use and guarded code.
* Remove SK_IGNORE_DWRITE_RENDERING_FIX.Gravatar Ben Wagner2014-07-02
| | | | This flag is no longer defined anywhere, so remove it's use.
* Revert of Remove the AA requirement for selecting GrEffect-based clipping. ↵Gravatar mtklein2014-07-02
| | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/367013003/) Reason for revert: We think this is breaking the roll. Original issue's description: > Remove the AA requirement for selecting GrEffect-based clipping. > > Also, optionally use the scissor for a bw clip rect element instead of an effect. > > Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11 > > Committed: https://skia.googlesource.com/skia/+/e9a729cb4d3f05b9c750dc1f63a9cc65b5659f04 R=robertphillips@google.com, bsalomon@google.com TBR=bsalomon@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: mtklein@google.com Review URL: https://codereview.chromium.org/361313002
* gen_bench_expectations: use subprocess instead of shell_utils due to ↵Gravatar borenet2014-07-02
| | | | | | | | | | | | | buildbot-side name collision BUG=skia:2714 R=rmistry@google.com TBR=rmistry NOTRY=true Author: borenet@google.com Review URL: https://codereview.chromium.org/368043002
* Exclude Clang on Windows too. Comment this up a bit.Gravatar mtklein2014-07-02
| | | | | | | | | BUG=391016 R=tomhudson@chromium.org, mtklein@google.com, rnk@chromium.org, thakis@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/363983004
* Combine clip stack and clip origin into one struct in GrIODB.Gravatar bsalomon2014-07-02
| | | | | | | | R=egdaniel@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/364823004
* Remove the AA requirement for selecting GrEffect-based clipping.Gravatar bsalomon2014-07-02
| | | | | | | | | | | | Also, optionally use the scissor for a bw clip rect element instead of an effect. Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/367013003
* Disable assembly code in MemorySanitizer builds.Gravatar Mike Klein2014-07-02
| | | | | | | | | | MemorySanitizer is an unitialized memory use detector which is used in Chromium, and does not presently support assembly code. BUG=chromium:344505, chromium:373739 R=mtklein@google.com Review URL: https://codereview.chromium.org/367973005
* Update some expectations for https://codereview.chromium.org/337603008.Gravatar jvanverth2014-07-02
| | | | | | | | | R=bungeman@google.com TBR=bungeman@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/362373002
* Revert of Remove the AA requirement for selecting GrEffect-based clipping. ↵Gravatar bsalomon2014-07-02
| | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/367013003/) Reason for revert: Assertion failing. Original issue's description: > Remove the AA requirement for selecting GrEffect-based clipping. > > Also, optionally use the scissor for a bw clip rect element instead of an effect. > > Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11 R=robertphillips@google.com TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: bsalomon@google.com Review URL: https://codereview.chromium.org/369613002
* Fix no previous prototype for function errorGravatar halcanary2014-07-02
| | | | | | | | | BUG=skia:2720 R=scroggo@google.com, caryclark@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/363983002
* Remove the AA requirement for selecting GrEffect-based clipping.Gravatar bsalomon2014-07-02
| | | | | | | | | | Also, optionally use the scissor for a bw clip rect element instead of an effect. R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/367013003
* Fix RecreateSkpsGravatar borenet2014-07-02
| | | | | | | | | | | | | | | - Use shell_utils to auto-print all subprocesses. - Only download bench_pictures data. - Skip or error out on bots which failed BenchPictures, PostBench, or UploadBenchResults. BUG=skia:2714 R=rmistry@google.com TBR=rmistry NOTRY=true Author: borenet@google.com Review URL: https://codereview.chromium.org/363833004
* CTFontCopy*Name may return NULL.Gravatar bungeman2014-07-02
| | | | | | | | | BUG=skia:2708 R=caryclark@google.com, reed@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/365683004
* Reduce integer divides in GrAllocatorGravatar bsalomon2014-07-02
| | | | | | | | R=egdaniel@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/362023002
* rebaseline_server: use just skpdiff, not Python Image LibraryGravatar epoger2014-07-02
| | | | | | | | | BUG=skia:2414 R=djsollen@google.com, borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/325413003
* Fix int to float bug in shader on gpu Dotted Line clGravatar egdaniel2014-07-02
| | | | | | | | | | | | NOTRY=True NOTREECHECKS=True R=bsalomon@google.com TBR=bsalomon@google.com BUG=skia: Author: egdaniel@google.com Review URL: https://codereview.chromium.org/361253002
* Revert of Update SKP version to 39 (https://codereview.chromium.org/367863003/)Gravatar borenet2014-07-02
| | | | | | | | | | | | | | | | | | | | | | Reason for revert: Deleted expectations again. https://code.google.com/p/skia/issues/detail?id=2714 Original issue's description: > Update SKP version to 39 > > Automatic commit by the RecreateSKPs bot. > > TBR= > > Committed: https://skia.googlesource.com/skia/+/50b3dab100a6537ace504357d38e49ba0a14de43 TBR= NOTREECHECKS=true NOTRY=true Author: borenet@google.com Review URL: https://codereview.chromium.org/367983002
* Add the ability for gpu to render dotted lines (dashed line, 0 on interval, ↵Gravatar egdaniel2014-07-02
| | | | | | | | | | | round caps) BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/345113003
* return early instead of crashing if fileData failsGravatar reed2014-07-02
| | | | | | | | | BUG=skia: R=krajcevski@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/362833004
* Update SKP version to 39Gravatar borenet2014-07-01
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/367863003
* Uses optional mutex to guard construction of the singleton, whichGravatar tomhudson2014-07-01
| | | | | | | | | | | | | | | | | initializes the non-threadsafe libfontconfig. Without this change, Skia's parallel path ops test runner crashes 6/10 and hangs 2/10 on startup; with this change, 0/10 problems. BUG=skia:2693 R=mtklein@google.com, bungeman@google.com, reed@google.com Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8 Committed: https://skia.googlesource.com/skia/+/60b08a0adfe73f593af62c8d3f55958438360e1b Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/355573006
* Remove A8_LCD luminance hack.Gravatar jvanverth2014-07-01
| | | | | | | | | | | It no longer appears to be necessary, and the powf function is slowing down Android text rendering. R=bungeman@google.com, bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/337603008
* Revert of Fix race condition in parallel font initialization. ↵Gravatar mtklein2014-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/355573006/) Reason for revert: canaries still slightly broken Original issue's description: > Fix race condition in parallel font initialization. > > Uses a mutex to guard construction of the singleton, which initialies > the non-threadsafe libfontconfig. Without this change, the parallel > path ops test runner crashes 6/10 and hangs 2/10 on startup; with this > change, 0/10 problems. > > BUG=skia:2693 > R=mtklein@google.com,bungeman@google.com > > Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8 > > Committed: https://skia.googlesource.com/skia/+/60b08a0adfe73f593af62c8d3f55958438360e1b R=bungeman@google.com, reed@google.com, tomhudson@google.com, tomhudson@chromium.org TBR=bungeman@google.com, reed@google.com, tomhudson@chromium.org, tomhudson@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2693 Author: mtklein@google.com Review URL: https://codereview.chromium.org/354133004
* correctly plumb through explicit rowbytes for allocPixelsGravatar reed2014-07-01
| | | | | | | | | BUG=skia: R=caryclark@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/357073003
* Cleanup usage of GetResourcePath() after commit ↵Gravatar tfarina2014-07-01
| | | | | | | | | | | | | | | | | bcbc1788b478b1e54079318ad073e8490aa66fae. There was a clean up opportunity left over after https://skia.googlesource.com/skia/+/bcbc1788b478b1e54079318ad073e8490aa66fae, that could make use of the default parameter of GetResourcePath() function to make some call sites cleaner. We decided to make it in a separate CL to make reviewer's and author's life easier, so we could catch errors and/or mistakes easily. BUG=None TEST=make all && out/Debug/dm && out/Debug/SampleApp R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/351133003
* Temporarily resurface matrix/clip save flags enum values.Gravatar fmalita2014-07-01
| | | | | | | | | | Pending Android build fixes. R=reed@google.com, scroggo@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/365463005
* Hey, maybe we should _call_ glFinish.Gravatar mtklein2014-07-01
| | | | | | | | | | | BUG=skia: CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-x86-Debug-Trybot R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/345063004
* Rename SkPicturePlayback to SkPictureDataGravatar robertphillips2014-07-01
| | | | | | | | | | This is in preparation for splitting the playback portion of the new SkPictureData class into a new SkPicturePlayback class. R=reed@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/362773002
* draft gpu support in nanobenchGravatar mtklein2014-07-01
| | | | | | | | | BUG=skia: R=bsalomon@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/359473004
* Fix race condition in parallel font initialization.Gravatar tomhudson2014-07-01
| | | | | | | | | | | | | | | | Uses a mutex to guard construction of the singleton, which initialies the non-threadsafe libfontconfig. Without this change, the parallel path ops test runner crashes 6/10 and hangs 2/10 on startup; with this change, 0/10 problems. BUG=skia:2693 R=mtklein@google.com, bungeman@google.com, reed@google.com, tomhudson@google.com Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8 Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/355573006
* Specify the name of tool for creating a makefile.Gravatar scroggo2014-07-01
| | | | | | | | | | | | | | | | | When generating tool Android.mks from gyp files, specify the name of the target needed. This fixes a bug where nanobench was being added to the same makefile as bench, which would not compile. TODO: Make gyp_to_android more general, so that it handles this case better. See http://skbug.com/2709 R=mtklein@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/366653002
* Add multithreaded mode to quilt mode in DM.Gravatar mtklein2014-07-01
| | | | | | | | | | | Default off for now. Something to work toward. BUG=skia: R=robertphillips@google.com, tomhudson@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/360793002
* When performing offscreen rendering on windows, attempt to use a pbuffer ↵Gravatar bsalomon2014-07-01
| | | | | | | | | | | | context. A pbuffer context is less likely to have a blocking SwapBuffers (due to vsync). R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/336863009
* Adjust the alpha type for pixelRefs.Gravatar scroggo2014-07-01
| | | | | | | | | | | | | | Move SkBitmap's validate_alphaType to SkImageInfo, with the new name SkColorTypeValidateAlphaType. Use it in SkPixelRef's constructors, as well as in SkDecodingImageGenerator. This fixes a bug where an SkPixelRef's SkAlphaType could get out of sync with its SkBitmap, when both were assigned the same SkAlphaType. R=reed@google.com, halcanary@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/346593003
* Revert of Update SKP version to 34 (https://codereview.chromium.org/347303003/)Gravatar Eric Boren2014-07-01
| | | | | | | | | | | | | | | | | | | | Reason for revert: This removed all bench expectations! Original issue's description: > Update SKP version to 34 > > Automatic commit by the RecreateSKPs bot. > > TBR= > > Committed: https://skia.googlesource.com/skia/+/0808c82e83749c24183af92a43c2e0e69b35d745 TBR= NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/362753002
* Grant independence to SkBaseMutex on Windows.Gravatar tomhudson2014-07-01
| | | | | | | | | | | | | | | | Under POSIX, class SkMutex inherits from struct SkBaseMutex. Since we can't have a POD mutex on Windows, we used to just typedef SkMutex SkBaseMutex there. However, that makes it impossible to forward-declare SkBaseMutex consistently across platforms. With this CL we declare an empty struct SkBaseMutex on Windows, which should have 0 cost but make the compiler happy. R=bungeman@google.com, mtklein@google.com, tomhudson@google.com, bungeman, mtklein BUG=skia: Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/364473002
* Hide symbols in S32A_Opaque_BlitRow32_SSE4Gravatar henrik.smiding2014-07-01
| | | | | | | | | | | | | | Marks the symbols in the S32A_Opaque_BlitRow32_SSE4 files as hidden, so Chromium can build. Also enables the optimizations. Signed-off-by: Henrik Smiding <henrik.smiding@intel.com> R=mtklein@google.com, joakim.landberg@intel.com Author: henrik.smiding@intel.com Review URL: https://codereview.chromium.org/368573002
* remove flags that are now in chrome's SkUserConfig.hGravatar reed2014-07-01
| | | | | | | | | R=reed@google.com NOTRY=True Author: reed@chromium.org Review URL: https://codereview.chromium.org/367483003
* Cleanup: Delete SkJSON header.Gravatar tfarina2014-06-30
| | | | | | | | | | | | | It seems it does not have any implementation so it is unlikely it will have any user, either internal or external. BUG=None TEST=make all R=bsalomon@google.com, mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/353183006
* Revert of Fix race condition in parallel font initialization. ↵Gravatar reed2014-06-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/355573006/) Reason for revert: breaks chrome builds Original issue's description: > Fix race condition in parallel font initialization. > > Uses a mutex to guard construction of the singleton, which initialies > the non-threadsafe libfontconfig. Without this change, the parallel > path ops test runner crashes 6/10 and hangs 2/10 on startup; with this > change, 0/10 problems. > > BUG=skia:2693 > R=mtklein@google.com,bungeman@google.com > > Committed: https://skia.googlesource.com/skia/+/df022f5972ae6a2a1d96d15c50eca52cade3abd8 R=mtklein@google.com, bungeman@google.com, reed@google.com, tomhudson@google.com, tomhudson@chromium.org TBR=bungeman@google.com, mtklein@google.com, reed@google.com, tomhudson@chromium.org, tomhudson@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2693 Author: reed@chromium.org Review URL: https://codereview.chromium.org/365503003
* Fix race condition in parallel font initialization.Gravatar tomhudson2014-06-30
| | | | | | | | | | | | | | Uses a mutex to guard construction of the singleton, which initialies the non-threadsafe libfontconfig. Without this change, the parallel path ops test runner crashes 6/10 and hangs 2/10 on startup; with this change, 0/10 problems. BUG=skia:2693 R=mtklein@google.com, bungeman@google.com, reed@google.com, tomhudson@google.com Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/355573006
* force opaque if kCGImageAlpha returns NoneGravatar reed2014-06-30
| | | | | | | | | BUG=skia:2424 R=caryclark@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/355403003
* add SK_API to config helpers so chrome can call themGravatar reed2014-06-30
| | | | | | | | TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/359353003
* Expectations updates for DirectWrite change 761b25.Gravatar Ben Wagner2014-06-30
|
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 10:56:00 +0000