aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Get HelloWorld example running againGravatar Jim Van Verth2017-10-09
| | | | | | | Change-Id: I5956f7c52d265d9f52dd061f1555c54ad092fe76 Reviewed-on: https://skia-review.googlesource.com/57101 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Disable GL buffer mapping on TSAN/Mac.Gravatar Brian Salomon2017-10-09
| | | | | | | | | | Also reverts 65e706379657d64371012c2e95ccf1354d741145 which disabled buffer mapping in GrResourceProvider::createPatternedIndexBuffer. Bug: skia:7058 Change-Id: I6816abe53251e1cd8e92eae41b8cdbe45218a341 Reviewed-on: https://skia-review.googlesource.com/50100 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove SkTypeface::Style use in API.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | All known callers of SkTypeface::MakeDefault call it with kNormal and the only users specifying kNormal explicitly are in Skia, so remove the parameter. There appear to be no users of SkTypeface::MakeFromTypeface, so remove it. The current alternative is SkFontMgr::matchFaceStyle which can do a better job anyway. Change-Id: I89d94c77f9593407b0a319786848a8b823fcbae4 Reviewed-on: https://skia-review.googlesource.com/56762 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fix merge conflict.Gravatar Ben Wagner2017-10-08
| | | | | | | | | | | | This resolves the conflict between https://skia-review.googlesource.com/57120 and https://skia-review.googlesource.com/57081. No-Try: true Change-Id: I45f47eb13dd7151b37b3b37f821232a02b9a43ff Reviewed-on: https://skia-review.googlesource.com/57082 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Win Clang Vulkan jobs.Gravatar Ben Wagner2017-10-08
| | | | | | | | No-Try: true Change-Id: I0b9f07e9057892443934da399f60762005495bde Reviewed-on: https://skia-review.googlesource.com/57081 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* CCPR: Blacklist Intel driver except on MacGravatar Chris Dalton2017-10-08
| | | | | | | | | | TBR=bsalomon@google.com Bug: skia: Change-Id: I93306a285c5bd1d71a69c4c8a12b7fc583a52e12 Reviewed-on: https://skia-review.googlesource.com/57160 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Update SKP versionGravatar UpdateSKPs2017-10-08
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I0e9f38de166cfb7823a943f28e525f0bb008f1e7 Reviewed-on: https://skia-review.googlesource.com/57120 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* CCPR: Block older Intel/Mesa setupsGravatar Chris Dalton2017-10-07
| | | | | | | | | | TBR=bsalomon@google.com Bug: skia:7134 Change-Id: I71af6c8ca75804f7ac6d187ecdc1467cad686494 Reviewed-on: https://skia-review.googlesource.com/56941 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add Win Clang Vulkan builds.Gravatar Ben Wagner2017-10-07
| | | | | | | | | Fix Clang compiler warning. Change-Id: Ic6f5b161058d1ed2df45e12b72dbff3b486ec986 Reviewed-on: https://skia-review.googlesource.com/56740 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix a couple float-cast-overflow in SkScan*.Gravatar Ben Wagner2017-10-07
| | | | | | | | Bug: skia:5060 Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 Reviewed-on: https://skia-review.googlesource.com/47422 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Enable coverage counting path rendering except on Android frameworkGravatar Chris Dalton2017-10-07
| | | | | | | | | | Android framework will come after collecting a bit more data. Bug: skia: Change-Id: I6f4738e457f09c976b8bf282153ca75160a1d91c Reviewed-on: https://skia-review.googlesource.com/55563 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Roll skia/third_party/externals/angle2/ a3d384ada..359487c82 (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/a3d384ada3dc..359487c822bb $ git log a3d384ada..359487c82 --date=short --no-merges --format='%ad %ae %s' 2017-10-03 ynovikov Build angle_perftests on Android Created with: roll-dep skia/third_party/externals/angle2 BUG=675997 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=scroggo@google.com Change-Id: I7965662576fa4bb32ea183bab8bf6b5b5cc09015 Reviewed-on: https://skia-review.googlesource.com/56960 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* CCPR: Add workaround for PowerVR crashGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: Icd00f81fda5366813f9c959fdc91b0415894cbfc Reviewed-on: https://skia-review.googlesource.com/55360 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* CCPR: Blacklist intel 4xxx and 6xxxGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: I590725027a6ed66a5612631686f41d62aeeb09fd Reviewed-on: https://skia-review.googlesource.com/56803 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "change computeByteSize to return max_size_t on overflow"Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 24295462722fd5a298d108a80b0aacbb0964da53. Reason for revert: broke running dm on google3 Original change's description: > change computeByteSize to return max_size_t on overflow > > Bug: skia:7132 > Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf > Reviewed-on: https://skia-review.googlesource.com/56620 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=bungeman@google.com,herb@google.com,reed@google.com Change-Id: I5f58ec37241d2fae3ebdb7a3d6b41f9fd6d3c2ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7132 Reviewed-on: https://skia-review.googlesource.com/56880 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add option to create a deferred render target context with mipsGravatar Greg Daniel2017-10-06
| | | | | | | | | | | | | | We need this since we have texture generators that draw the base level but nothing more. Thus we want them to be able to directly draw into a pre allocated mipped target instead of doing a copy later. TBR: bsalomon@google.com Bug: skia: Change-Id: I1dfae0da7153b21b30fdfa51a7061fc255739a1e Reviewed-on: https://skia-review.googlesource.com/54100 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add GS Invocations caps to SkSL StandaloneShaderCapsGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: I58f0caf97048e62a11cf8732acc79e3c2fbc683b Reviewed-on: https://skia-review.googlesource.com/56801 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert[3] "remove legacy fontmgr flag from flutter"Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit cbfd8bf7c098bff938d0f575584a7a82b354c621. Reason for revert: broke again ../../garnet/public/lib/ui/skia/skia_font_loader.cc:29:42: error: no member named 'createFromData' in 'SkFontMgr' SkFontMgr::RefDefault()->createFromData(font_data.get()))); Original change's description: > Revert "Revert "remove legacy fontmgr flag from flutter"" > > This reverts commit da6cf4e97ca334b408dda2344b6758970802eddd. > > Reason for revert: fix landed in flutter > > Original change's description: > > Revert "remove legacy fontmgr flag from flutter" > > > > This reverts commit 7077ae855519a23b087ded7386e18b475ac73c48. > > > > Reason for revert: Breaking flutter [1]: > > > > ../../flutter/sky/engine/platform/fonts/fuchsia/FontCacheFuchsia.cpp:136:53: error: no member named 'createFromData' in 'SkFontMgr' > > return sk_sp<SkTypeface>(SkFontMgr::RefDefault()->createFromData(data.get())); > > ~~~~~~~~~~~~~~~~~~~~~~~ ^ > > 1 error generated. > > > > [1] https://luci-logdog.appspot.com/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8966486899186212448%2F%2B%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fninja%2F0%2Fstdout > > > > Original change's description: > > > remove legacy fontmgr flag from flutter > > > > > > Bug: skia: > > > Change-Id: I82d16b398ea8bb7309378f475d94d9dea0b263d5 > > > Reviewed-on: https://skia-review.googlesource.com/56160 > > > Reviewed-by: Mike Reed <reed@google.com> > > > Commit-Queue: Mike Reed <reed@google.com> > > > > TBR=reed@google.com,reed@chromium.org > > > > Change-Id: I942a9c51dd4673fb2088610ddc2bffd414fbc4d8 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/56320 > > Reviewed-by: Leon Scroggins <scroggo@google.com> > > Commit-Queue: Leon Scroggins <scroggo@google.com> > > TBR=scroggo@google.com,reed@google.com,reed@chromium.org > > Change-Id: Idbb1205e4f7548b683da7d08e9a954fc97be7489 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/56761 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=scroggo@google.com,reed@google.com,reed@chromium.org Change-Id: I43a92fccae128f944ed1c6b57d635db322698545 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56840 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* change computeByteSize to return max_size_t on overflowGravatar Mike Reed2017-10-06
| | | | | | | | Bug: skia:7132 Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf Reviewed-on: https://skia-review.googlesource.com/56620 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove Perf SurfacePro2017 jobs.Gravatar Ben Wagner2017-10-06
| | | | | | | | | | | Perf numbers track closely with IntelIris540, although Perf numbers from SurfacePro2017 are more noisy. No-Try: true Change-Id: I9dfefd6daf69644a1c0850453334876269cd7942 Reviewed-on: https://skia-review.googlesource.com/56540 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "remove legacy fontmgr flag from flutter""Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit da6cf4e97ca334b408dda2344b6758970802eddd. Reason for revert: fix landed in flutter Original change's description: > Revert "remove legacy fontmgr flag from flutter" > > This reverts commit 7077ae855519a23b087ded7386e18b475ac73c48. > > Reason for revert: Breaking flutter [1]: > > ../../flutter/sky/engine/platform/fonts/fuchsia/FontCacheFuchsia.cpp:136:53: error: no member named 'createFromData' in 'SkFontMgr' > return sk_sp<SkTypeface>(SkFontMgr::RefDefault()->createFromData(data.get())); > ~~~~~~~~~~~~~~~~~~~~~~~ ^ > 1 error generated. > > [1] https://luci-logdog.appspot.com/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8966486899186212448%2F%2B%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fninja%2F0%2Fstdout > > Original change's description: > > remove legacy fontmgr flag from flutter > > > > Bug: skia: > > Change-Id: I82d16b398ea8bb7309378f475d94d9dea0b263d5 > > Reviewed-on: https://skia-review.googlesource.com/56160 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Mike Reed <reed@google.com> > > TBR=reed@google.com,reed@chromium.org > > Change-Id: I942a9c51dd4673fb2088610ddc2bffd414fbc4d8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/56320 > Reviewed-by: Leon Scroggins <scroggo@google.com> > Commit-Queue: Leon Scroggins <scroggo@google.com> TBR=scroggo@google.com,reed@google.com,reed@chromium.org Change-Id: Idbb1205e4f7548b683da7d08e9a954fc97be7489 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56761 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add a cap for geometry shader invocationsGravatar Chris Dalton2017-10-06
| | | | | | | | | Bug: skia:7116 Change-Id: I3cc2ce7b2e5123c9adfd9781b2a5a8553747dfa5 Reviewed-on: https://skia-review.googlesource.com/56000 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fix window origin on mac viewsGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: I25e4e791760bd1d95a2bfac1a1b5d18d9caa78e8 Reviewed-on: https://skia-review.googlesource.com/56581 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "Revert "remove guard for computeByteSize api""Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 297e4d3f2763f5163011afceff59b2a685aa7965. Reason for revert: landed fix in google3 Original change's description: > Revert "remove guard for computeByteSize api" > > This reverts commit d72747c5c3b3aaaa9e5957242bd478980cac942e. > > Reason for revert: broke //htmlrender/webkit_headless/engine/testing:platform_web_unittests > > Original change's description: > > remove guard for computeByteSize api > > > > Bug: skia: > > Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665 > > Reviewed-on: https://skia-review.googlesource.com/56402 > > Reviewed-by: Mike Reed <reed@google.com> > > TBR=reed@google.com,reed@chromium.org > > Change-Id: If721607583204df9f32e54a041ecc8b34ad1a749 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/56321 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=reed@google.com,reed@chromium.org Change-Id: I6d26a8623122e69af550d9a257c21943fe70b9f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56640 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ b433e872c..a3d384ada (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/b433e872c87f..a3d384ada3dc $ git log b433e872c..a3d384ada --date=short --no-merges --format='%ad %ae %s' 2017-10-06 oetuaho Fix signed integer overflow in GLSL preprocessor left shift Created with: roll-dep skia/third_party/externals/angle2 BUG=743136 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=scroggo@google.com Change-Id: I92194cd4221d516285ae06faa1331fc0f9bb92b0 Reviewed-on: https://skia-review.googlesource.com/56500 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Generate warning settings for Android frameworkGravatar Leon Scroggins III2017-10-06
| | | | | | | | | | | | | | | | | | Bug: b/66996870 Android wants to build with warnings as errors. Keep the external/skia warnings in sync with other Skia builds by pulling them from the json generated by GN. Fix a couple small errors that show up in the framework build. Uploaded in response to AOSP's https://android-review.googlesource.com/#/c/platform/external/skia/+/498211/ Change-Id: I4d791d43a9b00f9d6b79ecf16839716f241cba99 Reviewed-on: https://skia-review.googlesource.com/55703 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Don't execute onFlush op lists until after GPU data is uploadedGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: Ide85e802fd6e6a19412457dbaded3545b962c240 Reviewed-on: https://skia-review.googlesource.com/55562 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll skia/third_party/externals/angle2/ a87121f9d..b433e872c (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/a87121f9d19a..b433e872c87f $ git log a87121f9d..b433e872c --date=short --no-merges --format='%ad %ae %s' 2017-10-05 geofflang Change robust resource init into a context creation attribute. Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=scroggo@google.com Change-Id: I582df11b720d24783e428e3074f211ed76c3da30 Reviewed-on: https://skia-review.googlesource.com/56421 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* Revert "remove guard for computeByteSize api"Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d72747c5c3b3aaaa9e5957242bd478980cac942e. Reason for revert: broke //htmlrender/webkit_headless/engine/testing:platform_web_unittests Original change's description: > remove guard for computeByteSize api > > Bug: skia: > Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665 > Reviewed-on: https://skia-review.googlesource.com/56402 > Reviewed-by: Mike Reed <reed@google.com> TBR=reed@google.com,reed@chromium.org Change-Id: If721607583204df9f32e54a041ecc8b34ad1a749 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56321 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* CCPR: Don't forget resource provider in Pipeline InitArgsGravatar Chris Dalton2017-10-06
| | | | | | | | | | | | Ideally this would use an initializer list to guarantee we never forget another value in the future, but the default member values don't allow it. Bug: skia: Change-Id: I21e5b33bb99c4e0d42a7988b444d08266320bf37 Reviewed-on: https://skia-review.googlesource.com/56262 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* remove guard for computeByteSize apiGravatar Mike Reed2017-10-06
| | | | | | | Bug: skia: Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665 Reviewed-on: https://skia-review.googlesource.com/56402 Reviewed-by: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ e159717d4..a87121f9d (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/e159717d4bb5..a87121f9d19a $ git log e159717d4..a87121f9d --date=short --no-merges --format='%ad %ae %s' 2017-10-06 oetuaho Fix build warning by specializing clampCast Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=scroggo@google.com Change-Id: I5ccb29d4cad7df1e3e698aa543704eb312d016fe Reviewed-on: https://skia-review.googlesource.com/56380 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Revert "remove legacy fontmgr flag from flutter"Gravatar Leon Scroggins2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7077ae855519a23b087ded7386e18b475ac73c48. Reason for revert: Breaking flutter [1]: ../../flutter/sky/engine/platform/fonts/fuchsia/FontCacheFuchsia.cpp:136:53: error: no member named 'createFromData' in 'SkFontMgr' return sk_sp<SkTypeface>(SkFontMgr::RefDefault()->createFromData(data.get())); ~~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. [1] https://luci-logdog.appspot.com/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8966486899186212448%2F%2B%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fninja%2F0%2Fstdout Original change's description: > remove legacy fontmgr flag from flutter > > Bug: skia: > Change-Id: I82d16b398ea8bb7309378f475d94d9dea0b263d5 > Reviewed-on: https://skia-review.googlesource.com/56160 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=reed@google.com,reed@chromium.org Change-Id: I942a9c51dd4673fb2088610ddc2bffd414fbc4d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56320 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/d325eb349608f54d84a74ce124331a3fa170e5dc gclient: make predefined variables native (phajdan.jr@chromium.org) https://crrev.com/3ba2a7cf3801c62ef583761493c5e4cd4f717c27 gclient config: add support for custom vars (phajdan.jr@chromium.org) https://crrev.com/a58f1dacf1574708c916ece68b7edf3a27251010 [vpython] Roll CIPD version. (dnj@chromium.org) https://crrev.com/b5807979e8a9515f57cece1df7b19808b83d24ab Use HTTPS links in CheckAuthorizedAuthor (xiaoyin.l@outlook.com) recipe_engine: https://crrev.com/3e09a61a1ad7c8f21e2ce2afd7240855c318d7ce Update source_manifest to e8149bf in luci-go (hinoka@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic8f593e6f56863d34e11cff62643300dd336aa57 Reviewed-on: https://skia-review.googlesource.com/56300 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll skia/third_party/externals/angle2/ af143feff..e159717d4 (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/af143feff929..e159717d4bb5 $ git log af143feff..e159717d4 --date=short --no-merges --format='%ad %ae %s' 2017-10-05 geofflang Filter EGL attributes before passing them to the native driver. Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=scroggo@google.com Change-Id: If0e1c134267019ebea0e7ae3b092b48ac8f00705 Reviewed-on: https://skia-review.googlesource.com/56003 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* remove legacy fontmgr flag from flutterGravatar Mike Reed2017-10-05
| | | | | | | | Bug: skia: Change-Id: I82d16b398ea8bb7309378f475d94d9dea0b263d5 Reviewed-on: https://skia-review.googlesource.com/56160 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ 000dab88d..af143feff (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/000dab88d3d3..af143feff929 $ git log 000dab88d..af143feff --date=short --no-merges --format='%ad %ae %s' 2017-10-05 geofflang Refactor the eglQueryContext entry point. Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=scroggo@google.com Change-Id: I76deed54e115650aecde765d0f6278d3ab1d717c Reviewed-on: https://skia-review.googlesource.com/56080 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* When mip mapping, do YUV mip generation on CPU then upload to GPU.Gravatar Greg Daniel2017-10-05
| | | | | | | | Bug: skia: Change-Id: I930508b38e828652dfbb7c3f9d934d206cf1d72a Reviewed-on: https://skia-review.googlesource.com/56060 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* experiments to speed up drawing 32bit images into 565Gravatar Mike Reed2017-10-05
| | | | | | | | | | | | New (legacy style) blitters only coded for shaders (and very restricted blendmodes) Bug: skia: See https://buganizer.corp.google.com/issues/64884885 Change-Id: Ie2546093bfe1e670a825dfd9542d252d53732c40 Reviewed-on: https://skia-review.googlesource.com/54103 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Roll skia/third_party/externals/angle2/ 63c5a5974..000dab88d (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/63c5a59741df..000dab88d3d3 $ git log 63c5a5974..000dab88d --date=short --no-merges --format='%ad %ae %s' 2017-09-27 geofflang Make pack and unpack image extensions enableable. Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=scroggo@google.com Change-Id: I1896e2cc9b21c012c4f72af8f4d6bc5d290582cb Reviewed-on: https://skia-review.googlesource.com/55920 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Fewer atomic ops in debug with SkBufferHead.Gravatar Ben Wagner2017-10-05
| | | | | | | | | | | | | | In debug builds an assert would do an atomic load to assert the reference count was greater than zero, then a fetch_add would access the value again to do the reference counting. Instead just assert in debug on the value produced by the reference counting. This both improves debug performance and (more importantly) makes the debug asserts correct instead of mearly opprotunistic. Change-Id: Ic4ce788930d2564b5f86ab0e09fcd66006c8b73d Reviewed-on: https://skia-review.googlesource.com/55880 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* Revert "Attempt both GL and GLES for GPU unit tests"Gravatar Chris Dalton2017-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 454818b80ae57edfa410f884de3ed31db1e7ea9c. Reason for revert: the GPU unit tests on Chromebook that this change enabled are not surprisingly broken. Original change's description: > Attempt both GL and GLES for GPU unit tests > > The hardcoded logic was not all inclusive and caused Chromebooks to > not run GPU unit tests. > > Bug: skia: > Change-Id: I7688adab314d12234ee03363609a1c4bf8f2edb5 > Reviewed-on: https://skia-review.googlesource.com/55561 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=bsalomon@google.com,brianosman@google.com,csmartdalton@google.com Change-Id: I48a6fdf0b21d3f3a795d9cf20564208f7c35ff5b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/55960 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll skia/third_party/externals/angle2/ ce8602ab7..63c5a5974 (1 commit)Gravatar angle-deps-roller@chromium.org2017-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ce8602ab794b..63c5a59741df $ git log ce8602ab7..63c5a5974 --date=short --no-merges --format='%ad %ae %s' 2017-09-27 geofflang Make GL_ANGLE_instanced_arrays enableable. Created with: roll-dep skia/third_party/externals/angle2 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=scroggo@google.com Change-Id: I3794b168f0794f095d8e5362510bbac2e2b140a9 Reviewed-on: https://skia-review.googlesource.com/55860 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* clamp to [0,1] in all gradient tilersGravatar Mike Klein2017-10-05
| | | | | | | | | | | | | | | | | Today gradient mirror and repeat don't explicitly clamp. They work fine for normal float values, but blow up with inputs like infinity and NaN, and those aren't hard to construct with a combination of a funky matrix and some squaring for xy -> radius. So explicitly clamp in each of the three matrix tilers. This should fix the fuzz at the associated bug. Bug: skia:7093 Change-Id: Idd44e3c7a1ed95e2b1ace8eb953b62eddeb4e00e Reviewed-on: https://skia-review.googlesource.com/55702 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Clean up SkString reference counting a bit.Gravatar Ben Wagner2017-10-05
| | | | | | | | | | | This reverts commit 01f8e41c1368bfd60d3f011cb5aa9cc478799e63, and then works around whatever issues were seen on Ubuntu 14 by continuing the clean up. Change-Id: I3523b12c83e4efef01a8142c00cde4e3e12189fa Reviewed-on: https://skia-review.googlesource.com/55761 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Attempt both GL and GLES for GPU unit testsGravatar Chris Dalton2017-10-05
| | | | | | | | | | | The hardcoded logic was not all inclusive and caused Chromebooks to not run GPU unit tests. Bug: skia: Change-Id: I7688adab314d12234ee03363609a1c4bf8f2edb5 Reviewed-on: https://skia-review.googlesource.com/55561 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Use draws instead of clears on Macs w/ Intel Iris Pro GPUsGravatar Robert Phillips2017-10-05
| | | | | | | | Bug: 768134 Change-Id: Iebebb617208c0d8415bebef495c6ff02b17efd65 Reviewed-on: https://skia-review.googlesource.com/55800 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* abort if glyph metrics fall outside safe rectGravatar Mike Klein2017-10-05
| | | | | | | | | | | | Caught this while debugging a fuzz from Kevin. Haven't seen this on Windows, but seems like it's got roughly the same possible issue. Change-Id: I5e1c7328890492b3f3295af27757e456e26f9cbf Reviewed-on: https://skia-review.googlesource.com/55760 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* reformat hard-to-read preprocessor in SkJumper.cppGravatar Mike Klein2017-10-05
| | | | | | | Change-Id: I9a140e342e7b12b1cbb09503ca8fc03016717784 Reviewed-on: https://skia-review.googlesource.com/55701 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* converted GrConfigConversionEffect to SkSLGravatar Ethan Nicholas2017-10-05
| | | | | | | | Bug: skia: Change-Id: If17cf0fc8b857d22f33a462a39a02bcddd15deda Reviewed-on: https://skia-review.googlesource.com/55741 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-29 16:53:29 +0000