aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix nvpr path renderer to reject styles with nonDashPathEffects.Gravatar bsalomon2016-05-10
| | | | | | | | | TBR=robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1965903002 NOTRY=true Review-Url: https://codereview.chromium.org/1965903002
* Remove config range asserts that cause ↵Gravatar bsalomon2016-05-10
| | | | | | | | | tautological-constant-out-of-range-compare warnings on clang GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1964053002 Review-Url: https://codereview.chromium.org/1964053002
* Fix AllocedProxyTest on MesaGravatar robertphillips2016-05-10
| | | | | | | | Mesa is handing us a context that supports MSAA but has 0 as the max number of color samples GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1967503004 Review-Url: https://codereview.chromium.org/1967503004
* Replace GrStrokeInfo with GrStyle.Gravatar bsalomon2016-05-10
| | | | | | | | | A side effect is that arbitrary path effects can no be pushed deeper into the Ganesh flow for paths. They may be applied by path renderers. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957363002 Committed: https://skia.googlesource.com/skia/+/33595bdf4b64a745f6340338d307e806e96c587f Review-Url: https://codereview.chromium.org/1957363002
* Only enable SRGB write control on desktop GL when SRGB is supported.Gravatar bsalomon2016-05-10
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1961273004 Review-Url: https://codereview.chromium.org/1961273004
* Add flexible keybinding/command system to sk_app.Gravatar brianosman2016-05-10
| | | | | | | | | | | | | | | | | | | | | | Viewer demonstrates use: Just create an instance of CommandSet, register with the window, and add commands. Hopefully, we can keep all commands in one place, and get some nice side-benefits. With this framework, if you want to add a new command, you are only required to add code in ONE place. And you get added to the help screen, for free. CommandSet automatically binds 'h' to cycle through the help modes. (Functional grouping is most useful for general use, but the other mode is nice to know what a key does, or to find an unused key for a new feature). Grouped by function: https://screenshot.googleplex.com/G5h3f52wFKu.png Alphabetical by key: https://screenshot.googleplex.com/nZiopabLKJ6.png BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955293002 Review-Url: https://codereview.chromium.org/1955293002
* Set level count for wrapped backbufferGravatar jvanverth2016-05-10
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1965533002 Review-Url: https://codereview.chromium.org/1965533002
* Revert of Replace GrStrokeInfo with GrStyle. (patchset #4 id:160001 of ↵Gravatar bsalomon2016-05-10
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1957363002/ ) Reason for revert: Breaking some bots Original issue's description: > Replace GrStrokeInfo with GrStyle. > > A side effect is that arbitrary path effects can no be pushed deeper into the Ganesh flow for paths. They may be applied by path renderers. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957363002 > > Committed: https://skia.googlesource.com/skia/+/33595bdf4b64a745f6340338d307e806e96c587f TBR=egdaniel@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1967513002
* Run RAW images serially on Win8-MSVC-ShuttleBGravatar scroggo2016-05-10
| | | | | | | BUG=skia:5283 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1960153005 Review-Url: https://codereview.chromium.org/1960153005
* Replace GrStrokeInfo with GrStyle.Gravatar bsalomon2016-05-10
| | | | | | | A side effect is that arbitrary path effects can no be pushed deeper into the Ganesh flow for paths. They may be applied by path renderers. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957363002 Review-Url: https://codereview.chromium.org/1957363002
* refactor drawPath to have drawDevPathGravatar reed2016-05-09
| | | | | | | | | | | pre-CL for larger change to support read-only paths BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957263003 TBR= Review-Url: https://codereview.chromium.org/1957263003
* Approximate common gamma tables as single valuesGravatar msarett2016-05-09
| | | | | | | | | | | | | | | | | | | | | This should improve performance of gamma conversion in software (we can use vector math instead of table look ups). Additionally this allows us to quickly and easily identify sRGB-like gammas. On gpu, identifying sRGB gamma improves performance/memory, because the hardware may support gamma conversion. This will help us identify situations where gamma conversion is not necessary. Ex: sRGB input -> sRGB display BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950183006 Review-Url: https://codereview.chromium.org/1950183006
* Make DM fail if no configs were successfully createdGravatar brianosman2016-05-09
| | | | | | | BUG=skia:5261 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957273002 Review-Url: https://codereview.chromium.org/1957273002
* Stop valgrind bot from crashingGravatar scroggo2016-05-09
| | | | | | | | | | | | | | make_surface is returning nullptr, resulting in an invalid read. Add an error message with debugging information and skip this iteration. Also switch to cleaner for loop syntax. BUG=skia:5282 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1959173002 Review-Url: https://codereview.chromium.org/1959173002
* Incorporate scale into GrStyle and GrShapeGravatar bsalomon2016-05-09
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952383003 Review-Url: https://codereview.chromium.org/1952383003
* Make SkAssertResult work with SK_WARN_UNUSED_RESULT in Release on gccGravatar bsalomon2016-05-09
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1962723003 Review-Url: https://codereview.chromium.org/1962723003
* Allow gpu ResourceHandle class to be shared for multiple purposesGravatar egdaniel2016-05-09
| | | | | | | | | | | | | | Currently this class was just used for resource handles when building up a shader. However, I want to now use this class for things like objects owned/held by the GrVkResourceProvider which are used by other classes. An example of this will be for GrVkRenderTargets to hold a handle to a collection of compatible render passes without having to own/hold onto the render passes themselves. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955893002 Review-Url: https://codereview.chromium.org/1955893002
* Break apart shared use of varying and uniform transformsGravatar egdaniel2016-05-09
| | | | | | | | | This is a pre-cl for: https://codereview.chromium.org/1955893002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1961093002 Review-Url: https://codereview.chromium.org/1961093002
* No error if function marked with SK_WARN_UNUSED_RESULT is used in SkAssertResultGravatar bsalomon2016-05-09
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955263002 Review-Url: https://codereview.chromium.org/1955263002
* Reset layout to undefined when we realloc VkTexture memoryGravatar egdaniel2016-05-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1958123002 Review-Url: https://codereview.chromium.org/1958123002
* Initial commit of our new Android app to demo Skia.Gravatar liyuqian2016-05-09
| | | | | | | | | | | | | | | Currently, there's only a simple Activity with a title bar and a surface view that connects with Skia viewer native application. Before integrating user action events, I want to make sure that the design and implementation so far are good. Note that the old NativeApplication-based Activity (ViewerActivity) is still there for reference and test purposes. It will be removed eventually. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952323004 Review-Url: https://codereview.chromium.org/1952323004
* Less indentation.Gravatar bungeman2016-05-09
| | | | Review-Url: https://codereview.chromium.org/1963693002
* harfbuzz test: compile fewer filesGravatar halcanary2016-05-09
| | | | | | | TBR= GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957353002 Review-Url: https://codereview.chromium.org/1957353002
* DEPS: update icu + sfntlyGravatar halcanary2016-05-09
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1960153002 Review-Url: https://codereview.chromium.org/1960153002
* Reland of Simplify SkGpuBlurUtils::GaussianBlur method (patchset #1 id:1 of ↵Gravatar robertphillips2016-05-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1956023002/ ) Reason for revert: May not be as bad as was thought Original issue's description: > Revert of Simplify SkGpuBlurUtils::GaussianBlur method (patchset #2 id:20001 of https://codereview.chromium.org/1958603002/ ) > > Reason for revert: > Looks like it's causing some issues with the bleed_image GM. > > Original issue's description: > > Simplify SkGpuBlurUtils::GaussianBlur method > > > > No one was using the canClobberSrc capability and moving the direct filtering case forward makes the rest of the logic simpler. > > > > Split out of: https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) > > > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1958603002 > > > > Committed: https://skia.googlesource.com/skia/+/56a85e69a8d034e0fdee00e8207cda0a9da06fee > > TBR=bsalomon@google.com,robertphillips@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/67a58dcd4a1e79e5832161ae953526d27893aa61 TBR=bsalomon@google.com,jvanverth@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/1961953002
* SkAdvancedTypefaceMetrics: getAdvanceData uses std::functionGravatar halcanary2016-05-09
| | | | | | | Reduce templatedness. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955053002 Review-Url: https://codereview.chromium.org/1955053002
* Reland of Disable layer hoisting for non-8888 canvases (patchset #1 id:1 of ↵Gravatar robertphillips2016-05-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1961483002/ ) Reason for revert: This CL was not the culprit in the perf regression. Original issue's description: > Revert of Disable layer hoisting for non-8888 canvases (patchset #2 id:20001 of https://codereview.chromium.org/1957433002/ ) > > Reason for revert: > Experimental revert to investigate perf regression > > Original issue's description: > > Disable layer hoisting for non-8888 canvases > > > > This just stops the bleeding. A real fix would propagate the canvas' backing type down to the layer hoister. > > > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957433002 > > > > Committed: https://skia.googlesource.com/skia/+/4e30f27164179d344f0c8efa9a691d1bc9a53e3f > > TBR=bsalomon@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/6b53b9daeb2137a91d8ddb8e890d66c702bfbaa3 TBR=bsalomon@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/1962603002
* SkAdvancedTypefaceMetrics: abstract out linked listGravatar halcanary2016-05-08
| | | | | | | | | | | | | + use SkSinglyLinkedList<T> + move SkSinglyLinkedList.h to core + remove SkHackyAutoTDelete + getAdvanceData() -> setGlyphWidths() + finishRange no longer templated + remove unused templated functions GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1953153004 Review-Url: https://codereview.chromium.org/1953153004
* Update SKP versionGravatar update-skps2016-05-08
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955283002 Review-Url: https://codereview.chromium.org/1955283002
* documentation: SkMilestoneGravatar halcanary2016-05-06
| | | | | | | | https://skia.org/schedule?cl=1956473006 NOTRY=true TBR= Review-Url: https://codereview.chromium.org/1956473006
* Add sRGB mode toggle to Viewer.Gravatar brianosman2016-05-06
| | | | | | | | | | Unlike SampleApp, this just switches out the format of the window surface (and then adjusts the gamma-correct flag on the SkSurfaces). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950983007 Review-Url: https://codereview.chromium.org/1950983007
* Revert of Simplify SkGpuBlurUtils::GaussianBlur method (patchset #2 id:20001 ↵Gravatar jvanverth2016-05-06
| | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1958603002/ ) Reason for revert: Looks like it's causing some issues with the bleed_image GM. Original issue's description: > Simplify SkGpuBlurUtils::GaussianBlur method > > No one was using the canClobberSrc capability and moving the direct filtering case forward makes the rest of the logic simpler. > > Split out of: https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1958603002 > > Committed: https://skia.googlesource.com/skia/+/56a85e69a8d034e0fdee00e8207cda0a9da06fee TBR=bsalomon@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1956023002
* Clean up GrVkImage::setLayout()Gravatar jvanverth2016-05-06
| | | | | | | | Fixes issues with mipmap generation, and calculates src information inside the routine rather than having the client do it. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950713006 Review-Url: https://codereview.chromium.org/1950713006
* Remove Sk(Float|Double)PinToFixed functions, only used in tests.Gravatar brianosman2016-05-06
| | | | | | | | | | These were triggering compile-time floating point overflow for one user, and we don't use them. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952303005 Review-Url: https://codereview.chromium.org/1952303005
* Fix issue where GrStyle::applyToPath exited before applying strokeGravatar bsalomon2016-05-06
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1954123002 Review-Url: https://codereview.chromium.org/1954123002
* Fix for Sk4f Ubuntu compile warningGravatar jvanverth2016-05-06
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1958633003 TBR=herbderby@google.com Review-Url: https://codereview.chromium.org/1958633003
* Remove hasMixedSamples() from GrPipelineBuilderGravatar cdalton2016-05-06
| | | | | | | | | | This info is unknown until after any clip has been applied to the stencil settings, so it's misleading to include in the builder. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952323002 Review-Url: https://codereview.chromium.org/1952323002
* Fix for Ubuntu compile warningGravatar jvanverth2016-05-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955913002 Review-Url: https://codereview.chromium.org/1955913002
* Disable skia_warnings_as_errors for Fast bot.Gravatar benjaminwagner2016-05-06
| | | | | | | BUG=skia:5257 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955923002 Review-Url: https://codereview.chromium.org/1955923002
* Detect an invalid intervalCount in SkRegion during deserialiation.Gravatar senorblanco2016-05-06
| | | | | | | BUG=609260 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1961463003 Review-Url: https://codereview.chromium.org/1961463003
* SkAdvancedTypefaceMetrics: fail cleanly.Gravatar halcanary2016-05-06
| | | | | | | BUG=567031 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1956753002 Review-Url: https://codereview.chromium.org/1956753002
* https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMgGravatar halcanary2016-05-06
| | | | | | | | | No public API changes. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957503002 Review-Url: https://codereview.chromium.org/1957503002
* Revert of Retract GrRenderTarget a bit within SkGpuDevice (patchset #2 ↵Gravatar robertphillips2016-05-06
| | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/1956473002/ ) Reason for revert: Experimental revert to track down perf regression Original issue's description: > Retract GrRenderTarget a bit within SkGpuDevice > > Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1956473002 > > Committed: https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1954103002
* SkAdvancedTypefaceMetrics: improve robustnessGravatar halcanary2016-05-06
| | | | | | | | | Manually unwind linked list. BUG=567031 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955033002 Review-Url: https://codereview.chromium.org/1955033002
* Take SkStrokeRec::InitStyle rather than SkPaint::Style in mask filter and ↵Gravatar bsalomon2016-05-06
| | | | | | | | DrawMask GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955633002 Review-Url: https://codereview.chromium.org/1955633002
* Compile SkForceLinking on CMakeGravatar msarett2016-05-06
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1956573002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review-Url: https://codereview.chromium.org/1956573002
* Simplify SkGpuBlurUtils::GaussianBlur methodGravatar robertphillips2016-05-06
| | | | | | | | | | No one was using the canClobberSrc capability and moving the direct filtering case forward makes the rest of the logic simpler. Split out of: https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1958603002 Review-Url: https://codereview.chromium.org/1958603002
* Revert of Disable layer hoisting for non-8888 canvases (patchset #2 id:20001 ↵Gravatar robertphillips2016-05-06
| | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1957433002/ ) Reason for revert: Experimental revert to investigate perf regression Original issue's description: > Disable layer hoisting for non-8888 canvases > > This just stops the bleeding. A real fix would propagate the canvas' backing type down to the layer hoister. > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957433002 > > Committed: https://skia.googlesource.com/skia/+/4e30f27164179d344f0c8efa9a691d1bc9a53e3f TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1961483002
* Whitespace change to test botsGravatar borenet2016-05-06
| | | | | | | | BUG=skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1956713002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/1956713002
* remove alias for SkMatrix44.h -- chrome callers have been updatedGravatar reed2016-05-05
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1949113006 TBR= Review-Url: https://codereview.chromium.org/1949113006
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-02 15:30:55 +0000