aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert of Switch SkJpegCode to libjpeg-turbo (patchset #11 id:540001 of ↵Gravatar mtklein2015-06-24
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1180983002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-MipsDSP2-Debug-Android/builds/1136/steps/build%20most/logs/stdio Original issue's description: > Add libjpeg-turbo library (depends on yasm) > Mangle external function names to avoid conflict with libjpeg > Take advantage of direct color conversion (RGBA, BGRA, 565) > Prepare to use jpeg_skip_scanlines (when it is upstreamed) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b60c3f8291529303299262dba19b1a896060bd2d TBR=scroggo@google.com,djsollen@google.com,emmaleer@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1199253006
* Add libjpeg-turbo library (depends on yasm)Gravatar msarett2015-06-24
| | | | | | | | | | Mangle external function names to avoid conflict with libjpeg Take advantage of direct color conversion (RGBA, BGRA, 565) Prepare to use jpeg_skip_scanlines (when it is upstreamed) BUG=skia: Review URL: https://codereview.chromium.org/1180983002
* Revert of remove workaround for dx9 angle slow rgba pixel ops (patchset #1 ↵Gravatar bsalomon2015-06-24
| | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1207003002/) Reason for revert: users are still on dx9 angle :( Original issue's description: > remove workaround for dx9 angle slow rgba pixel ops > > TBR=robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/1e1adc33ba1acb9a2ad41c0a5a9b6166ee9d7a2a TBR=robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1205183002
* Add a 64-bit ARM builder to the CQ.Gravatar mtklein2015-06-24
| | | | | | | | | It's possible this rarely breaks, but I do write ARMv8 code frequently enough that it'll help prevent broken trees. BUG=skia: Review URL: https://codereview.chromium.org/1209763003
* Revert of Implement four more xfermodes with Sk4px. (patchset #16 id:290001 ↵Gravatar mtklein2015-06-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1196713004/) Reason for revert: 64-bit ARM build failures. Original issue's description: > Implement four more xfermodes with Sk4px. > > HardLight, Overlay, Darken, and Lighten are all > ~2x faster with SSE, ~25% faster with NEON. > > This covers all previously-implemented NEON xfermodes. > 3 previous SSE xfermodes remain. Those need division > and sqrt, so I'm planning on using SkPMFloat for them. > It'll help the readability and NEON speed if I move that > into [0,1] space first. > > The main new concept here is c.thenElse(t,e), which behaves like > (c ? t : e) except, of course, both t and e are evaluated. This allows > us to emulate conditionals with vectors. > > This also removes the concept of SkNb. Instead of a standalone bool > vector, each SkNi or SkNf will just return their own types for > comparisons. Turns out to be a lot more manageable this way. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b9d4163bebab0f5639f9c5928bb5fc15f472dddc TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1205703008
* Implement four more xfermodes with Sk4px.Gravatar mtklein2015-06-24
| | | | | | | | | | | | | | | | | | | | | | | HardLight, Overlay, Darken, and Lighten are all ~2x faster with SSE, ~25% faster with NEON. This covers all previously-implemented NEON xfermodes. 3 previous SSE xfermodes remain. Those need division and sqrt, so I'm planning on using SkPMFloat for them. It'll help the readability and NEON speed if I move that into [0,1] space first. The main new concept here is c.thenElse(t,e), which behaves like (c ? t : e) except, of course, both t and e are evaluated. This allows us to emulate conditionals with vectors. This also removes the concept of SkNb. Instead of a standalone bool vector, each SkNi or SkNf will just return their own types for comparisons. Turns out to be a lot more manageable this way. BUG=skia: Review URL: https://codereview.chromium.org/1196713004
* remove workaround for dx9 angle slow rgba pixel opsGravatar bsalomon2015-06-24
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1207003002
* Clarify iOS flush-to-zero status.Gravatar bungeman2015-06-24
| | | | | | | | | | | Modern processors support flush-to-zero and denormalized-are-zero for floating point operations (with ARM NEON unable to disable them). However, iOS on ARM is the only current system which defaults processes to using both all the time. However, this is only iOS on ARM, iOS on x86 (the simulator) does not. Correctly defining this allows the math tests to run error free in the simulator. Review URL: https://codereview.chromium.org/1203533003
* Cleanup: Comment and ordering changes.Gravatar herb2015-06-24
| | | | | | | This should be a whitespace only change. BUG=skia: Review URL: https://codereview.chromium.org/1194423004
* Add default for GrGLSLCaps::fGLSLGenerationGravatar jvanverth2015-06-24
| | | | Review URL: https://codereview.chromium.org/1203153002
* add SkCanvas::drawAtlasGravatar reed2015-06-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1181913003
* Fix debugger compilationGravatar robertphillips2015-06-24
| | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1205933002
* Alter shader code for soft light to avoid driver bug.Gravatar egdaniel2015-06-24
| | | | | | | | | | | | | | On the n5 there seems to be an issue where negating a variable at the start of an equation doesn't work. Moving the negated variable to a subtract at the end works around the issue (as would multiplying by -1.0). The main bug was caused by the -DaCub in the else if block, but I also adjusted the else block to make sure the same issue doesn't appear there at some later date. BUG=chromium:502434 Review URL: https://codereview.chromium.org/1210573002
* Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS (patchset #1 id:1 of ↵Gravatar scroggo2015-06-24
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1200323005/) Reason for revert: Breaking the Android build. Original issue's description: > remove SK_SUPPORT_LEGACY_PATHOP_ENUMS > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/8bcc7a00febd737f7e82513bd5e4a697526626de TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1203983003
* Move GLSL-specific routines/classes to separate glsl directoryGravatar jvanverth2015-06-24
| | | | | | | The purpose is to begin separating our GLSL-specific code from our GL-specific code, so it can be used with the GL45 platform Review URL: https://codereview.chromium.org/1202293002
* Refactor GrBufferAllocPools to use resource cacheGravatar robertphillips2015-06-24
| | | | | | Committed: https://skia.googlesource.com/skia/+/e935f1a0e2351373c33600b8388492ce1218014a Review URL: https://codereview.chromium.org/1139753002
* remove SK_SUPPORT_LEGACY_PATHOP_ENUMSGravatar reed2015-06-23
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1200323005
* remove SK_SUPPORT_LEGACY_FILTERLEVEL_ENUMGravatar reed2015-06-23
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1205803002
* remove (legacy) NewFromDataGravatar reed2015-06-23
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1199413003
* Make SkGpuDevice know its alpha typeGravatar bsalomon2015-06-23
| | | | | | | | Make SkImage_Gpu snapshots opaque if surface is opaque. BUG=skia:3965 Review URL: https://codereview.chromium.org/1205643002
* add more testsGravatar reed2015-06-23
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1201333002
* Make SkNSView's window accept mouseMoved eventsGravatar bsalomon2015-06-23
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1206563003
* Rename SkFontConfigParser_android SkFontMgr_android_parser.Gravatar bungeman2015-06-23
| | | | | | | | | There are a number of files with 'FontConfig' in their names which just have to do with font configuration, but nothing to do with the FontConfig project or even with each other. This clarifies that these files deal with parsing for the Android font manager. Review URL: https://codereview.chromium.org/1200103008
* Implement SkGLContext swapBuffers with fence syncsGravatar cdalton2015-06-23
| | | | | | | | | | | Improves the GPU measuring accuracy of nanobench by using fence syncs. Fence syncs are very widely supported and available on almost every platform. NO_MERGE_BUILDS BUG=skia: Review URL: https://codereview.chromium.org/1194783003
* Revert of Refactor GrBufferAllocPools to use resource cache (patchset #15 ↵Gravatar robertphillips2015-06-23
| | | | | | | | | | | | | | | | | | | id:280001 of https://codereview.chromium.org/1139753002/) Reason for revert: Will reland after Chromium branch Original issue's description: > Refactor GrBufferAllocPools to use resource cache > > Committed: https://skia.googlesource.com/skia/+/e935f1a0e2351373c33600b8388492ce1218014a TBR=bsalomon@google.com,joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1204773003
* remove SK_SUPPORT_LEGACY_OPTIONLESS_GET_PIXELSGravatar reed2015-06-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1201233002
* Revert of SkPDF: Annotations are clipped by canvas clip stack. (patchset #2 ↵Gravatar halcanary2015-06-23
| | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/1148263005/) Reason for revert: http://crbug.com/503541 Original issue's description: > SkPDF: Annotations are clipped by canvas clip stack. > > Also, remove some SkPDFDevice functions. > > Will fix this GM: http://crrev.com/1159273003 > > BUG=skia:3872 > > Committed: https://skia.googlesource.com/skia/+/eee0e4e9d343d8b6c5ae2da7f17196f00d8859bc TBR=tomhudson@google.com,reed@google.com BUG=skia:3872 BUG=503541 Review URL: https://codereview.chromium.org/1200193003
* Fix memory leak in simple-offsetimagefilterGravatar robertphillips2015-06-23
| | | | Review URL: https://codereview.chromium.org/1203613004
* more tests for offsetimagefilterGravatar reed2015-06-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1199933011
* Refactor GrBufferAllocPools to use resource cacheGravatar robertphillips2015-06-23
| | | | Review URL: https://codereview.chromium.org/1139753002
* Stop using the NVPR glyph loading functionalityGravatar kkinnunen2015-06-23
| | | | | | Remove the NVPR glyph loading functionality. A bit risky feature. Review URL: https://codereview.chromium.org/1176113008
* Rename SkFontHost_none.cpp to SkFontMgr_empty_factory.Gravatar bungeman2015-06-23
| | | | | | | | | | When the current function was added in https://skia.googlesource.com/skia/+/070da5edcb1c6e9b9507f06a5e2c270e1c1fd796%5E%21/#F3 the SkFontHost was still alive and well. Now that this file no longer contains any SkFontHost related code, rename the file for clarity and uniformity. Review URL: https://codereview.chromium.org/1196313003
* add autotuning to visualbenchGravatar joshualitt2015-06-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1201003002
* Fix memory leak in SkPictureRecordGravatar robertphillips2015-06-23
| | | | Review URL: https://codereview.chromium.org/1197283007
* Fix indirect use of defined() directiveGravatar tomhudson2015-06-23
| | | | | | | BUG=432391 R=bsalomon,bungeman1 Review URL: https://codereview.chromium.org/876933004
* Propagate SkSurfaceProps to more call sitesGravatar robertphillips2015-06-23
| | | | | | | | | | Start moving to a world where everyone provides surface properties. Most notably this exposes a portion of SkSurfaceProps to the C API. BUG=skia:3934 Review URL: https://codereview.chromium.org/1195003003
* Tweak SkiaLab docsGravatar borenet2015-06-23
| | | | | | | | BUG=skia:3850 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1203443003 Review URL: https://codereview.chromium.org/1203443003
* add simple test for offsetimagefilterGravatar reed2015-06-23
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1204723002
* add break statement -- lost during rewrite earlierGravatar reed2015-06-22
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1193333004
* change old picture serialization to really handle imagesGravatar reed2015-06-22
| | | | | | BUG=skia:3965 Review URL: https://codereview.chromium.org/1199473002
* fix for calling bindFragDataLocation on OpenGL 2.1Gravatar joshualitt2015-06-22
| | | | | | BUG=skia:3966 Review URL: https://codereview.chromium.org/1201623003
* Clean up usage of SkSurfacePropsGravatar robertphillips2015-06-22
| | | | | | | | | | | | This CL continues cleaning up Skia's usage of SkSurfaceProps. It: Removes the duplicate SkSurfaceProps object from SkImageFilter::Proxy. Removes a dispreferred ctor from SkCanvas Removes the initForRootLayer entry point from SkDevice (since the root device and the canvas should always have the same pixel geometry now). Review URL: https://codereview.chromium.org/1201983006
* Use vmulq_n_u32(..., 0x01010101) to distribute alphas.Gravatar mtklein2015-06-22
| | | | | | | | | | | | | | | | | | | | | | | This seems to make alphas() faster and Load[24]Alphas() no slower. The change is particularly noticeable on xfermodes that call alphas() twice (on src and dst), with a 10-12% speedup. Xfermode_Difference_aa 29ms -> 28.4ms 0.98x Xfermode_DstATop_aa 27.2ms -> 26.7ms 0.98x Xfermode_Xor_aa 27.2ms -> 26.5ms 0.98x Xfermode_DstOver 23.6ms -> 22.9ms 0.97x Xfermode_DstOver_aa 27.8ms -> 26.8ms 0.96x Xfermode_DstOut 22.6ms -> 21.7ms 0.96x Xfermode_Multiply_aa 30ms -> 28.5ms 0.95x Xfermode_DstOut_aa 26.1ms -> 24.8ms 0.95x Xfermode_DstIn_aa 25.4ms -> 24.1ms 0.95x Xfermode_DstATop 28.7ms -> 26ms 0.9x Xfermode_Multiply 35.5ms -> 31.3ms 0.88x Xfermode_Difference 31.8ms -> 27.7ms 0.87x Xfermode_Xor 30.1ms -> 26.1ms 0.87x BUG=skia: Review URL: https://codereview.chromium.org/1203513002
* fix spurious init on VisualBench startupGravatar joshualitt2015-06-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1202023002
* Implemented onGetScanlines and onSkipScanlines for interlaced pngsGravatar emmaleer2015-06-22
| | | | | | | | Modified DM tests to be faster when decoding interlaced pngs BUG=skia: Review URL: https://codereview.chromium.org/1194703002
* Update some Sk4px APIs.Gravatar mtklein2015-06-22
| | | | | | | | | | | | | | | Mostly this is about ergonomics, making it easier to do good operations and hard / impossible to do bad ones. - SkAlpha / SkPMColor constructors become static factories. - Remove div255TruncNarrow(), rename div255RoundNarrow() to div255(). In practice we always want to round, and the narrowing to 8-bit is contextually obvious. - Rename fastMulDiv255Round() approxMulDiv255() to stress it's approximate-ness over its speed. Drop Round for the same reason as above... we should always round. - Add operator overloads so we don't have to keep throwing in seemingly-random Sk4px() or Sk4px::Wide() casts. - use operator*() for 8-bit x 8-bit -> 16-bit math. It's always what we want, and there's generally no 8x8->8 alternative. - MapFoo can take a const Func&. Don't think it makes a big difference, but nice to do. BUG=skia: Review URL: https://codereview.chromium.org/1202013002
* Begin kLegacyFontHost_InitType cleanupGravatar robertphillips2015-06-22
| | | | | | | | | | | | | | | | | | This CL starts the process of pushing kLegacyFontHost_InitType-type SkSurfaceProps up the call stack and out of Skia. It: Gets rid of the default SkBaseDevice ctor. This means everyone has to always hand an explicit SkSurfaceProps to it. It makes public the SkBitmapDevice creation methods that require SkSurfaceProps. Removes (in Skia's code base) all SkBitmapDevice ctor calls w/o SkSurfaceProps. Makes the "recording" canvases (e.g., pdf, svg, xps) explicitly not use kLegacyFontHost_InitType. Replicates the creating canvas/device's flags on saveLayer devices BUG=skia:3934 Review URL: https://codereview.chromium.org/1204433002
* clean offsetimagefilter gmGravatar reed2015-06-22
| | | | | | | BUG=skia: TBR=robertphilips Review URL: https://codereview.chromium.org/1203473002
* Change large glyph check back to > threshold.Gravatar jvanverth2015-06-22
| | | | | | | | | Using >= misses some Chromium test cases that are still being rendered as paths. BUG=chromium:467569 Review URL: https://codereview.chromium.org/1202433002
* Remove distance field flag from SkPaintGravatar jvanverth2015-06-22
| | | | Review URL: https://codereview.chromium.org/1192413005