aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Revert "fix nextContour bug"Gravatar Stan Iliev2018-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 473f69276f1854db80e094cc4af091f7f8a5b00b. Reason for revert: a CTS test PathMeasureTest.android.graphics.cts.PathMeasureTest.testNextContour is failing Original change's description: > fix nextContour bug > > Calling nextContour() needs to ensure that we've already measured the "current" one. > > Bug: skia: > Change-Id: I501c26d0b068028d67103888f06ec89125a5407a > Reviewed-on: https://skia-review.googlesource.com/114692 > Reviewed-by: Cary Clark <caryclark@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=caryclark@google.com,reed@google.com Change-Id: I7f1e08651dfe73c02158b209dc28af2b174e246f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114823 Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Stan Iliev <stani@google.com>
* Correctly discard or load RT when doing copies as draws in VulkanGravatar Greg Daniel2018-03-16
| | | | | | | | | | | This fixes all the copy as draw issues we've had with certain devices and the cap is no longer needed. Bug: skia: Change-Id: Id0b750849c4c920beae2d8cb3eda5f402018f194 Reviewed-on: https://skia-review.googlesource.com/114860 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add GT610 Debug ANGLE jobs.Gravatar Ben Wagner2018-03-16
| | | | | | | | | Bug: skia:7312 Change-Id: Ib84b57c8ca029e94da8897de5b7d400a394bf87c No-Try: true Reviewed-on: https://skia-review.googlesource.com/74140 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Apply filterTextFlags so the fonts are the same.Gravatar Herb Derby2018-03-16
| | | | | | | | | | | | | | | | | | In order to apply filterTextFlags correctly, teach TrackLayerDevice how to process save and restore layers. At this point, I don't see any other traffic than the cache warming traffic. This code has a performance between 82% and 105% of just drawing the picture. BUG=skia:7515 Change-Id: I44736be46884f18b6d120d4b5ca582f34dbdff0f Reviewed-on: https://skia-review.googlesource.com/114641 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add DoneProc to Promise ImagesGravatar Greg Daniel2018-03-16
| | | | | | | | | | | | | This proc will notify the client when we will no longer call fulfill on their promise image so that can delete any meta data they needed to store to be able to complete the fulfill requests. Bug: skia: Change-Id: Ife1e6845f221c31ce1ae2c0d2ba5e4c8f0203b74 Reviewed-on: https://skia-review.googlesource.com/114092 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* handle bad xform in drawTextRSXformGravatar Mike Reed2018-03-16
| | | | | | | | Bug: oss-fuzz:6955 Change-Id: Ide1f57459a611980a86afea577eb4c2425e49e63 Reviewed-on: https://skia-review.googlesource.com/114782 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* fix overflow in rgnbuilderGravatar Mike Reed2018-03-16
| | | | | | | | Bug: oss-fuzz:6956 Change-Id: I244e49d458eb78e0c6200fc3c147f0f67823f97f Reviewed-on: https://skia-review.googlesource.com/114780 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Remove Android Framework bot from CQ while server is being upgraded"Gravatar Ravi Mistry2018-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2ab6f7e580bb9624d65a9a64cd56952d896db602. Reason for revert: Server back with more cores Original change's description: > Remove Android Framework bot from CQ while server is being upgraded > > NoTry: true > Bug: skia:7716 > Change-Id: I67695c5f45ac5b9c57d0599ba2ab2e825fa75e4b > Reviewed-on: https://skia-review.googlesource.com/114788 > Reviewed-by: Ravi Mistry <rmistry@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=benjaminwagner@google.com,rmistry@google.com Change-Id: I01626d9a4de98a27a350b053cb1aa7612d71d136 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7716 Reviewed-on: https://skia-review.googlesource.com/114820 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* more imageinfo text and warnings and cleanupGravatar Cary Clark2018-03-16
| | | | | | | | | | | | | | | | | | | more imageinfo text rewrote many examples to fix newly exposed compiler warnings marked a couple of YUV method bodies as deprecated also cleaned up line endings to use the linux style R=bsalomon@google.com TBR=caryclark@google.com Docs-Preview: https://skia.org/?cl=112302 Bug: skia:6898 Change-Id: I89626a27353aa84526f9b9475d927bd0e9d8f0d5 Reviewed-on: https://skia-review.googlesource.com/112302 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* Make sure we do a render pass load if we copied to a surface before handGravatar Greg Daniel2018-03-16
| | | | | | | | Bug: skia: Change-Id: I4858e0774956f6283122bf71c84f3c6161e1d349 Reviewed-on: https://skia-review.googlesource.com/114790 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* fix SkSL SPIR-V geometry shaders' entry point declarationGravatar Ethan Nicholas2018-03-16
| | | | | | | | Bug: skia: Change-Id: I5cd5a35fe1a554b127548a7809c106de70df0be7 Reviewed-on: https://skia-review.googlesource.com/114785 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Remove Android Framework bot from CQ while server is being upgradedGravatar Ravi Mistry2018-03-16
| | | | | | | | | | | NoTry: true Bug: skia:7716 Change-Id: I67695c5f45ac5b9c57d0599ba2ab2e825fa75e4b Reviewed-on: https://skia-review.googlesource.com/114788 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* we now complain if an SkSL program tries to override the default outputGravatar Ethan Nicholas2018-03-16
| | | | | | | | Bug: skia: Change-Id: I387ddc3aac0712eb6c0a6ea39e48e5f3d809bc48 Reviewed-on: https://skia-review.googlesource.com/114691 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Fix vulkan layout barriers when we are doing in line uploads.Gravatar Greg Daniel2018-03-16
| | | | | | | | Bug: skia: Change-Id: I0842a4eebba8cfa8310d0680941d59f1e363e574 Reviewed-on: https://skia-review.googlesource.com/114760 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll skia/third_party/externals/angle2/ 5ae6ee457..1c08cbb39 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5ae6ee457860..1c08cbb398cd $ git log 5ae6ee457..1c08cbb39 --date=short --no-merges --format='%ad %ae %s' 2018-03-15 jiawei.shao Clean up link validations on interface blocks Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: Ic7da673d0bda6d4c013112c2f7b39c73611cadc6 Reviewed-on: https://skia-review.googlesource.com/114694 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* fix nextContour bugGravatar Mike Reed2018-03-16
| | | | | | | | | | Calling nextContour() needs to ensure that we've already measured the "current" one. Bug: skia: Change-Id: I501c26d0b068028d67103888f06ec89125a5407a Reviewed-on: https://skia-review.googlesource.com/114692 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Fix Vulkan Copy as draw shaderGravatar Greg Daniel2018-03-16
| | | | | | | | Bug: skia:7663 Change-Id: I745900ccc56c697e4abb982e921d99bc28502b33 Reviewed-on: https://skia-review.googlesource.com/114687 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Prevent crash when flushing while DDL recordingGravatar Robert Phillips2018-03-16
| | | | | | | Change-Id: I35e96d3c3020092b33d9b952394d40d4fd5a587b Reviewed-on: https://skia-review.googlesource.com/114685 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Support GL_OES_EGL_image_external on newer GLSL without essl3Gravatar Brian Osman2018-03-16
| | | | | | | | Bug: skia:7713 Change-Id: I15c6a55370848cd211c783c886923f31dec1788c Reviewed-on: https://skia-review.googlesource.com/114505 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Make TestForPreservingPMConversions helper use lazy createTextureProxy call.Gravatar Greg Daniel2018-03-16
| | | | | | | | Bug: skia: Change-Id: I337efc531aa5685c138b2f9e2bd47b47ba4e1fd5 Reviewed-on: https://skia-review.googlesource.com/114583 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Output fiddleout.json in bookmaker recipeGravatar Ravi Mistry2018-03-16
| | | | | | | | Bug: skia: Change-Id: Id4c613385a6948af9808dfbaef8f437e765fb9b5 Reviewed-on: https://skia-review.googlesource.com/114571 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Roll skia/third_party/externals/angle2/ 44a73fcfb..5ae6ee457 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/44a73fcfbe2d..5ae6ee457860 $ git log 44a73fcfb..5ae6ee457 --date=short --no-merges --format='%ad %ae %s' 2018-03-06 jiajia.qin ES31: Sync dirty objects for compute shader 2018-03-08 oetuaho Don't use TIntermSymbol nodes for function parameters Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I4d8d978eb7a9f647e4dfa8759acb96438361f05e Reviewed-on: https://skia-review.googlesource.com/114700 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Fix GPU dimension for Win2k8 QuadroP400 jobs.Gravatar Ben Wagner2018-03-15
| | | | | | | | | | Fixes a bug in https://skia-review.googlesource.com/113740 No-Try: true Change-Id: I1d03f1a266dfb50b223c665a44bc0ace8ab081c7 Reviewed-on: https://skia-review.googlesource.com/114621 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Handle GrContext creation failure in DDLGravatar Robert Phillips2018-03-15
| | | | | | | | | TBR=bsalomon@google.com Change-Id: Ib34448a60cb127ef89bcb0b1f85d07abc91af582 Reviewed-on: https://skia-review.googlesource.com/114569 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Make get_images_from_skps always return successGravatar Leon Scroggins III2018-03-15
| | | | | | | | | | | | | | Previously, it would fail (and thus turn the bot red) if an image failed to decode (e.g. with SkCodec::Result of kInvalidInput). This tends to happen because the captured page had not fully downloaded yet. Stop treating this an error. It may still be useful to test using SkCodec just to be sure that we didn't crash, so keep running the test. Change-Id: I1a0530fb82fa32d95c5f01d5131626745cf6c4f2 Reviewed-on: https://skia-review.googlesource.com/114582 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* rm guard for google3Gravatar Mike Reed2018-03-15
| | | | | | | | Bug: skia: Change-Id: I86495e0fefff2dbd34e39e3a0be891bfc62ec08b Reviewed-on: https://skia-review.googlesource.com/114581 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Cleanup SkImage YUV texture factories.Gravatar Brian Salomon2018-03-15
| | | | | | | | | | | | | Remove unused GrBackendObject variants. Add versions without redundant size param. Make this work with GrBackendTextures that weren't created with a GrPixelConfig. Change-Id: Ic1bbf5f2817cebab938b4f31000126a6ab5c44d5 Reviewed-on: https://skia-review.googlesource.com/114460 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll skia/third_party/externals/angle2/ 0b0dcbc1c..44a73fcfb (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0b0dcbc1cffa..44a73fcfbe2d $ git log 0b0dcbc1c..44a73fcfb --date=short --no-merges --format='%ad %ae %s' 2018-03-06 brandon1.jones Always Invalidate Vertex Attribute Translation 2018-03-13 lucferron Vulkan: Additional texture formats support. RGB565, RGBA4444, RGBA5551 Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I830a5f7b33ad65524aab37112dc954969028608a Reviewed-on: https://skia-review.googlesource.com/114564 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* detect non-finite ptsGravatar Mike Reed2018-03-15
| | | | | | | | Bug: oss-fuzz:6638 Change-Id: I72dab6783099facbe8d658ec1bc4b175a383e174 Reviewed-on: https://skia-review.googlesource.com/114565 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Upgrade OS and NVIDIA driver on Win10 Golo/MTV lab bots.Gravatar Ben Wagner2018-03-15
| | | | | | | | | Bug: chromium:821040, chromium:821857 No-Try: true Change-Id: Iebad9eca31dedfda484faa91333c42c3ba3df186 Reviewed-on: https://skia-review.googlesource.com/113740 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Disable CCPR path rendering in DDL modeGravatar Robert Phillips2018-03-15
| | | | | | | Change-Id: Ib16a7b037eff6cd0528177646c2eced467763a06 Reviewed-on: https://skia-review.googlesource.com/114560 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add DDL SkpOnly botGravatar Robert Phillips2018-03-15
| | | | | | | Change-Id: If9402ad5a3ae7d17221cf1bca621b8aad4d9e9d0 Reviewed-on: https://skia-review.googlesource.com/114466 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* update_meta_config: Use new LUCI optional GPU trybotGravatar Eric Boren2018-03-15
| | | | | | | | Bug: skia: Change-Id: I1eca549d38b64869a763951b8469712d620e24bf Reviewed-on: https://skia-review.googlesource.com/114516 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* drawTextRSXform should not apply matrix to shaderGravatar Mike Reed2018-03-15
| | | | | | | | | | | drawTextRSXform should draw the same as drawTextOnPath (as regards shaders) Bug: b/69904791 Change-Id: I393dd8fd7a5bdc6a018b1ca33592b208c7141868 Reviewed-on: https://skia-review.googlesource.com/114468 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Delete unused VkClearTestGravatar Greg Daniel2018-03-15
| | | | | | | | Bug: skia: Change-Id: I4aa1886e7f4048fc13a741ddbc37b9ca3f48a41d Reviewed-on: https://skia-review.googlesource.com/114510 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* GrGLES: unify MakeNativeInterface_{android,egl}Gravatar Hal Canary2018-03-15
| | | | | | | | BUG=skia:3508 Change-Id: Ibc98ea3e579cb545635c28d345cae24f57d0c2a3 Reviewed-on: https://skia-review.googlesource.com/114471 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* fix pathops fuzzers and debuggingGravatar Cary Clark2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | En route to fixing fuzzer bugs, I discovered that most debugging in pathops was broken. Pathops has extensive runtime functions that trace links and connections between data structures that are invaluable to debugging. The only practical way to use these functions is to call them from the debugger in immediate mode. Some time, some where, the MSVS Immediate Window ceased to be able to call functions that are members of structs or classes, and functions that take templated parameters. I can find no mention of this on the web, so I assume that something about our setup is triggering this, but I've had no luck finding the culprit. In the meantime, I've added global functions wrapped in a namespace to sneak calls to these functions without MSVS being any the wiser. While this works, it is likely to bitrot by tomorrow or next Tuesday so I will continue to try to find and fix the root cause. This also fixes the fuzzer bugs; generally one-line edits that change asserts to fails. All pathops tests succeed with this. To run all tests, do: ./out/debug/pathops_unittest -V -x ./out/release/pathops_unittest -V -x TBR=caryclark@google.com Bug: skia: Change-Id: I956ae3d8df6d25e155e62bd6dede64519c7fbdb1 Reviewed-on: https://skia-review.googlesource.com/114321 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* SkAutoGlyphCache change some sites to Find*.Gravatar Herb Derby2018-03-15
| | | | | | | Change-Id: Iec3a0c60106017394fcdd981052713b6e42fa595 Reviewed-on: https://skia-review.googlesource.com/114506 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Make CreateBackendFormatFromTexture shared codeGravatar Robert Phillips2018-03-15
| | | | | | | | | TBR=bsalomon@google.com Change-Id: I19e6e6c8dc32ba584738545d443de092e4987a5a Reviewed-on: https://skia-review.googlesource.com/114374 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Fix initialLayout update in Vk createTestingOnlyImageGravatar Greg Daniel2018-03-15
| | | | | | | | Bug: skia: Change-Id: I5d4321e68c065e3775266994c65a4abf18360731 Reviewed-on: https://skia-review.googlesource.com/114497 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Check GL_EXT_texture_format_BGRA8888 before GL_APPLE_texture_format_BGRA8888Gravatar Alexis Hetu2018-03-15
| | | | | | | | | | | | | | | | When both GL_EXT_texture_format_BGRA8888 and GL_APPLE_texture_format_BGRA8888 extensions are present, the presence of GL_APPLE_texture_format_BGRA8888 was preventing GL_EXT_texture_format_BGRA8888 from allowing BGRA8888 to be used as a render target. By checking for GL_EXT_texture_format_BGRA8888 first, this solves the issue. The issue was encountered trying to run vr_pixeltests on top of SwiftShader on the bots with a version of SwiftShader exposing both extension strings. Change-Id: I446ec502a4703d24c24339708dcbbe9c334a7533 Reviewed-on: https://skia-review.googlesource.com/114495 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Alexis Hetu <sugoi@google.com>
* protect PathMeasure against input paths with NaNsGravatar Cary Clark2018-03-15
| | | | | | | | | | | found by fuzzer R=kjlubick@google.com Bug: skia: Change-Id: Ifde8706a7ca6fad785a1b0b50f3df3fb099c0e36 Reviewed-on: https://skia-review.googlesource.com/114477 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* Remove SK_RASTER_RECORDER_IMPLEMENTATIONGravatar Robert Phillips2018-03-15
| | | | | | | | | TBR=bsalomon@google.com Change-Id: I9608ce5ce2b9d38c5e356d8428a8ff05df6ccda7 Reviewed-on: https://skia-review.googlesource.com/114490 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Revert "ccpr: Unblacklist vulkan"Gravatar Greg Daniel2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 30ce2a3620ffe428762de08be50f3a62462524a2. Reason for revert: Crashing drivers on intel and powerVR. Possible SPIR-V error Original change's description: > ccpr: Unblacklist vulkan > > All issues have been resolved. > > Bug: skia: > Change-Id: Id63d63ad081725885cb0225b410b0d3972abd8f7 > Reviewed-on: https://skia-review.googlesource.com/113060 > Commit-Queue: Chris Dalton <csmartdalton@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,csmartdalton@google.com Change-Id: Ibb9ea75cc0fbe2db0ff11a8b22bac8f47242f775 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114540 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Make sure we set correct GrPixelConfig in promise imagesGravatar Greg Daniel2018-03-15
| | | | | | | | | | Land just the Promise image fixes from, https://skia-review.googlesource.com/c/skia/+/114261 Bug: skia: Change-Id: I917cf2c1f5c6e51f9d7f1d3ec4526db551e89d84 Reviewed-on: https://skia-review.googlesource.com/114472 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Prepare ddl skp rendering for prime timeGravatar Robert Phillips2018-03-15
| | | | | | | Change-Id: I87742b8ef043588c4e835ab6ec49b217dd49f829 Reviewed-on: https://skia-review.googlesource.com/114289 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ 5eaddbd01..0b0dcbc1c (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5eaddbd018ea..0b0dcbc1cffa $ git log 5eaddbd01..0b0dcbc1c --date=short --no-merges --format='%ad %ae %s' 2018-03-14 oetuaho Prune empty cases and switch statements Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I4577adae4389eb5f8e248c5cbb46d226434e84f2 Reviewed-on: https://skia-review.googlesource.com/114487 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* ccpr: Unblacklist vulkanGravatar Chris Dalton2018-03-15
| | | | | | | | | | All issues have been resolved. Bug: skia: Change-Id: Id63d63ad081725885cb0225b410b0d3972abd8f7 Reviewed-on: https://skia-review.googlesource.com/113060 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll skia/third_party/externals/angle2/ 87db7c524..5eaddbd01 (9 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/87db7c524e70..5eaddbd018ea $ git log 87db7c524..5eaddbd01 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 jmadill Vulkan: Flag uniforms as dirty when they are updated. 2018-03-14 lucferron Vulkan: Support of float uniform matrixes (2,3,4). 2018-03-14 geofflang Add an EGL extension to disable GL extensions by default. 2018-03-14 jmadill VertexArray: Add perf tests for VAO dirty bits. 2018-03-14 jiawei.shao ES31: Support program parameter queries on geometry shader 2018-03-13 lucferron Vulkan: Get/SetUniform for float / int and vec* 2018-03-14 cwallez cq.cfg: equivalent_to to 100% for Linux tryservers. 2018-03-13 cwallez Fix cubemap robust resource init for GenerateMipmap 2018-03-14 jmadill Move DrawCallParams to the gl front-end. Created with: roll-dep skia/third_party/externals/angle2 BUG=815092 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: Iaa1f591c7efbc29332e1ef5075e52c8f06aed6a1 Reviewed-on: https://skia-review.googlesource.com/114520 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add a png.imp for include-what-you-use.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | The png.h header provides some macros and declarations from subincludes. By default include-what-you-use will suggest using these subincludes directly, but this was not the intent of png.h. This adds a mapping file so that include-what-you-use knows that these subincludes are actually private and png.h should be used instead. Change-Id: Ibf9df6dbdbde0e657f6e548ed0e8f2310f44cfea Reviewed-on: https://skia-review.googlesource.com/114481 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>