aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Move GrFragmentProcessor implementation to its own cpp fileGravatar bsalomon2015-09-22
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1350523004
* fix factory countGravatar Brian Salomon2015-09-22
| | | | | | TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/1357773003 .
* Replace GrExtractAlphaFragmentProcessor with DstIn compose processorGravatar bsalomon2015-09-22
| | | | Review URL: https://codereview.chromium.org/1347943003
* Remove SkNEW and SkDELETE macrosGravatar mdempsky2015-09-22
| | | | | | | | | | | | | | | This CL removes the uses of SkNEW that have resprouted since commit 385fe4d, and removes the macros entirely now that Android and Chromium have been cleaned up to no longer depend on them. A bunch of files implicitly depend on #include <new> from SkPostConfig.h still though, so keep that for now. To be fixed in a followup CL. [mtklein mucking around] Only public API removed. TBR=reed@google.com Review URL: https://codereview.chromium.org/1360653004
* SkTLList throw on sk_malloc failGravatar halcanary2015-09-21
| | | | | | BUG=530758 Review URL: https://codereview.chromium.org/1345373006
* whitespace changeGravatar halcanary2015-09-21
| | | | | | | NOTRY=true TBR= Review URL: https://codereview.chromium.org/1349933004
* Revert of Combined approach. (patchset #2 id:20001 of ↵Gravatar mtklein2015-09-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1356133002/ ) Reason for revert: whee Original issue's description: > Combined approach. > > This combines some ideas from these two CLs: > - try stosd/w > - update memset16/32 inlining heuristics > > > BUG=skia:4316 > > Blinking in and out for perf.skia.org. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/46243a7c02a1d5116e55a27ff59218f9c320df97 TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4316 Review URL: https://codereview.chromium.org/1353703006
* Combined approach.Gravatar mtklein2015-09-21
| | | | | | | | | | | | | This combines some ideas from these two CLs: - try stosd/w - update memset16/32 inlining heuristics BUG=skia:4316 Blinking in and out for perf.skia.org. TBR=reed@google.com Review URL: https://codereview.chromium.org/1356133002
* CMake: Compile in OSMesa on Linux, if found.Gravatar halcanary2015-09-21
| | | | | | CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot Review URL: https://codereview.chromium.org/1353383003
* SK_API for include/gpu/gl/GrGLInterface.hGravatar halcanary2015-09-21
| | | | Review URL: https://codereview.chromium.org/1357823003
* Buildbot specs for Linux ANGLE botGravatar borenet2015-09-21
| | | | | | BUG=skia:4362 Review URL: https://codereview.chromium.org/1361453002
* update roadmap link to latestGravatar hcm2015-09-21
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1354413003 Review URL: https://codereview.chromium.org/1354413003
* Revert of try simplest code: inline whenever vaguely sensible (patchset #1 ↵Gravatar mtklein2015-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1351403005/ ) Reason for revert: pingpong Original issue's description: > try simplest code: inline whenever vaguely sensible > > BUG=skia:4316 > > Will land and revert. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/527a0c8235b454f5d0475a9a3e34caa9520db3a2 TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4316 Review URL: https://codereview.chromium.org/1355073002
* try simplest code: inline whenever vaguely sensibleGravatar mtklein2015-09-20
| | | | | | | | | BUG=skia:4316 Will land and revert. TBR=reed@google.com Review URL: https://codereview.chromium.org/1351403005
* Revert of try stosd/w (patchset #2 id:20001 of ↵Gravatar mtklein2015-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1355063002/ ) Reason for revert: boink Original issue's description: > try stosd/w > > While we're trying things and reverting them, might as well try this too. > > BUG=skia:4316 > > Blinking in and out for perf.skia.org. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/3ca0f626a07e9b534d14a2d8213eedb93c5f7534 TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4316 Review URL: https://codereview.chromium.org/1356983004
* try stosd/wGravatar mtklein2015-09-20
| | | | | | | | | | | While we're trying things and reverting them, might as well try this too. BUG=skia:4316 Blinking in and out for perf.skia.org. TBR=reed@google.com Review URL: https://codereview.chromium.org/1355063002
* Revert of update memset16/32 inlining heuristics (patchset #1 id:1 of ↵Gravatar mtklein2015-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1357193002/ ) Reason for revert: Who wants to land forever? Original issue's description: > update memset16/32 inlining heuristics > > I spent some time looking at perf.skia.org and it looks like we can do better. > > It is weird, weird, weird that on x86, we see three completely different behaviors: > - x86 Android: inlining better for small N, custom better for large N; > - Windows: inlining better for large N, custom better for small N; > - other x86: inlining generally better > > BUG=skia:4316,chromium:516426 > > (Temporary, plan to revert.) > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/b68fa409fc00ce2f38e2a0fd6f9dc2379b372481 TBR=reed@google.com,jcgregorio@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4316,chromium:516426 Review URL: https://codereview.chromium.org/1358793002
* update memset16/32 inlining heuristicsGravatar mtklein2015-09-20
| | | | | | | | | | | | | | | | I spent some time looking at perf.skia.org and it looks like we can do better. It is weird, weird, weird that on x86, we see three completely different behaviors: - x86 Android: inlining better for small N, custom better for large N; - Windows: inlining better for large N, custom better for small N; - other x86: inlining generally better BUG=skia:4316,chromium:516426 (Temporary, plan to revert.) TBR=reed@google.com Review URL: https://codereview.chromium.org/1357193002
* Update SKP versionGravatar update-skps2015-09-20
| | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS Review URL: https://codereview.chromium.org/1360503002
* Revert of Avoid CTFontCreateCopyWithAttributes. (patchset #4 id:60001 of ↵Gravatar bungeman2015-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1344213004/ ) Reason for revert: Causes issues with synthetic bold italic on all versions of OSX, with OSX10.10 resulting in many measurement related changes (this is expected though). fast/text/atsui-multiple-renderers.html fast/css/font-face-synthetic-bold-italic.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9__retina_/6168/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/4525/layout-test-results/results.html Original issue's description: > Avoid CTFontCreateCopyWithAttributes. > > It appears that CTFontCreateCopyWithAttributes and > CTFontCreateCopyWithSymbolicTraits share similar issues with the default > font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as > it will not work with webfonts. Since this is all low-level use, create the > CTFonts from the underlying CGFonts directly. > > BUG=chromium:524646 > > Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f TBR=erikchen@chromium.org,mtklein@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524646 Review URL: https://codereview.chromium.org/1354323002
* Avoid CTFontCreateCopyWithAttributes.Gravatar bungeman2015-09-18
| | | | | | | | | | | | It appears that CTFontCreateCopyWithAttributes and CTFontCreateCopyWithSymbolicTraits share similar issues with the default font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as it will not work with webfonts. Since this is all low-level use, create the CTFonts from the underlying CGFonts directly. BUG=chromium:524646 Review URL: https://codereview.chromium.org/1344213004
* skia.og: Update the home page to have a showcase of Skia capabilities.Gravatar jcgregorio2015-09-18
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1353473007 Review URL: https://codereview.chromium.org/1353473007
* Delete the typefaces.Gravatar herb2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1353203002
* Create append methods in batch namespacesGravatar joshualitt2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1353553002
* Fix for combining with perspective local rectsGravatar joshualitt2015-09-18
| | | | | | | TBR=robertphillips@google.com BUG=skia: Review URL: https://codereview.chromium.org/1347913004
* Font cache stress test.Gravatar herb2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1348883002
* Disable dithering in libjpeg-turbo for 565 decodesGravatar msarett2015-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | libjpeg-turbo turns on dithering by default. When we decode to RGBA, it uses Floyd-Steinberg dithering - consistent with the libjpeg6b gold standard, When we decode to 565, it uses ordered dithering. Ordered dithering for 565 is not part of the 6b standard (libjpeg6b doesn't even support 565) and is causing us a number of issues: (1) Ordered dithering + nearest neighbor sampling is causing checkerboard visual artifacts in some outputs. (2) The ordered dither function in libjpeg-turbo actually behaves differently depending on the alignment of the memory that it decodes into. This means that two image decodes that should be identical may look different just because they decode into different memory blocks. This was causing some diffs on Gold with the scanline_subset test that were causing me some confusion. (3) Maybe not the best evidence, but visually I can't tell a difference with and without dithering (except when nearest neighbor scaling causes the checkerboard artifact). (4) Turning off dithering should be a more significant performance improvement than you might expect. libjpeg-turbo has SIMD color conversions to 565, but when dithering is on, it defaults to scalar code. This CL should make every jpeg decode to 565 on Gold look slightly different. Yay! BUG=skia: Review URL: https://codereview.chromium.org/1349563007
* add new gm to test overlapping lcd textGravatar joshualitt2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1358563002
* Make Ben happyGravatar joshualitt2015-09-18
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/1351193004
* Use rounding when converting desiredScale to a sampleSizeGravatar msarett2015-09-18
| | | | | | | | | | | | | | | | | | | | | Right now we have a bug in Gold where some images are labeled _0.167 and others are labeled _0.166. They are all 1/6 scales and should be labeled the same way and compared. The fix involves changing 0.166 to 0.167 in the list of scales that we test on, but SkScaledCodec does not scale to 0.167 as I expected. SkScaledCodec converts 0.167 to sampleSize = 5.999 and then casts to sampleSize = 5. I would argue that we should do a true round, so 0.167 represents a sampleSize of 6. In general, this CL change onGetScaledDimensions so that we now round desiredScale to the nearest sampleSize. BUG=skia: Review URL: https://codereview.chromium.org/1356923002
* Add shared mutex benchmark.Gravatar herb2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1352863004
* Revert of add ImageShader, sharing code with its Bitmap cousin (patchset #10 ↵Gravatar tomhudson2015-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:180001 of https://codereview.chromium.org/1342113002/ ) Reason for revert: Failing ImageNewShaderTest on both Android (Tegra3 GPU) and iOS bots. e.g. /Users/chrome-bot/buildbot/skiabot-ipad4-000/build/slave/workdir/build/skia/tests/ ImageNewShaderTest.cpp:24 0 == memcmp(bm1.getPixels(), bm2.getPixels(), bm1.getSize()) ImageNewShaderTest.cpp:95 0xFFFF0000 == bmt.getColor(0, y) ImageNewShaderTest.cpp:98 0xFFDEDEDE == bmt.getColor(x, y) ImageNewShaderTest.cpp:98 0xFFDEDEDE == bmt.getColor(x, y) ImageNewShaderTest.cpp:98 0xFFDEDEDE == bmt.getColor(x, y) ImageNewShaderTest.cpp:98 0xFFDEDEDE == bmt.getColor(x, y) ImageNewShaderTest.cpp:95 0xFFFF0000 == bmt.getColor(0, y) ... Original issue's description: > add ImageShader, sharing code with its Bitmap cousin > > This is done by having abstracted the BitmapShaderContext to take a BitmapProvider, instead of just a bitmap. This allows us to share all of that code between SkBitmap and SkImage, since both are valid providers. > > It also means that we can simplify SkImage_Base to not need a virtual for onNewShader, since ALL images can uniformly be turned into a shader now. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/0b93e3149d2cb30860c51f9f3204ae811d9a97ca TBR=fmalita@chromium.org,bsalomon@google.com,robertphillips@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1355863002
* Benchmark all mutex implementations.Gravatar herb2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1342283004
* Add slice toolGravatar robertphillips2015-09-18
| | | | | | Don't know if we want to add this but I found it useful when tracking down blur circle bugs. Review URL: https://codereview.chromium.org/1350323002
* add ImageShader, sharing code with its Bitmap cousinGravatar reed2015-09-18
| | | | | | | | | | This is done by having abstracted the BitmapShaderContext to take a BitmapProvider, instead of just a bitmap. This allows us to share all of that code between SkBitmap and SkImage, since both are valid providers. It also means that we can simplify SkImage_Base to not need a virtual for onNewShader, since ALL images can uniformly be turned into a shader now. BUG=skia: Review URL: https://codereview.chromium.org/1342113002
* Purge cached resources on SkImage destruction.Gravatar fmalita2015-09-18
| | | | | | | BUG=532981 R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1352883004
* Move StrokeRectBatches into .cpp filesGravatar joshualitt2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1353683003
* Add debug mode to shared mutex.Gravatar herb2015-09-18
| | | | Review URL: https://codereview.chromium.org/1307863009
* unplumb sknx_no_simdGravatar mtklein2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1355833002
* Not correctly initializing VisualBench commandline argumentsGravatar joshualitt2015-09-18
| | | | | | | TBR=mtklein@google.com BUG=skia: Review URL: https://codereview.chromium.org/1340163004
* Buildbot spec and gyp defs for SK_USE_DISCARDABLE_SCALEDIMAGECACHE botGravatar borenet2015-09-18
| | | | | | BUG=skia:4354 Review URL: https://codereview.chromium.org/1350283003
* Test-...-Release-SK_FOO --> -DSK_FOOGravatar mtklein2015-09-18
| | | | | | | | | | | When a bot ends with extra_config SK_LIKE_THIS, we'll define SK_LIKE_THIS when compiling. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot BUG=skia:4354 Review URL: https://codereview.chromium.org/1346833004
* Merge sub-device annotations in SkPDFDevice::drawDevice()Gravatar wangxianzhu2015-09-17
| | | | | | | | | | | | | | | | | | Previously annotations added between saveLayer/restore were lost. Merge annotations in SkPDFDevice::drawDevice(). Also modified code to apply correct transformation and clipping on annotations added between saveLayer/restore: - Apply the initial transform only when adding the annotations into the doc, otherwise we need to unapply sub-device's initial transform before merging the annotations into parent-device. - Apply only device-local clipping. fClipStack is in global coordinates, which is not suitable to clip rects in sub-devices. BUG=skia:4080 BUG=503515 Review URL: https://codereview.chromium.org/1257533004
* Reland of add a ClassID function to GrBatch (patchset #1 id:1 of ↵Gravatar reed2015-09-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1353043002/ ) Reason for revert: DEPS roll seems to have landed w/o this revert, so revert it again Original issue's description: > Revert of add a ClassID function to GrBatch (patchset #5 id:80001 of https://codereview.chromium.org/1352813003/ ) > > Reason for revert: > Speculative revert to unblock DEPS roll > > Original issue's description: > > add a ClassID function to GrBatch > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/4078d529e9e199eea13456db7bf3a63a104ab5b9 > > > > Committed: https://skia.googlesource.com/skia/+/eb44d53cf96a7eaf103a98d76079ce1f5495e343 > > TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/48e3a45ade15c52c0c1a10cb00907dd444897745 TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1344373005
* Revert of add a ClassID function to GrBatch (patchset #5 id:80001 of ↵Gravatar reed2015-09-17
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1352813003/ ) Reason for revert: Speculative revert to unblock DEPS roll Original issue's description: > add a ClassID function to GrBatch > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4078d529e9e199eea13456db7bf3a63a104ab5b9 > > Committed: https://skia.googlesource.com/skia/+/eb44d53cf96a7eaf103a98d76079ce1f5495e343 TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1353043002
* share IDs between cacherator and its host-imageGravatar reed2015-09-17
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1357543002
* use allocator (if present) when we allocate our cache bitmapGravatar reed2015-09-17
| | | | | | | | Remove some bogus tests on the cache, as they are not thread-reliable. Running w/ discardable these are racy. BUG=532981 Review URL: https://codereview.chromium.org/1351453004
* remove racy tests, as they assume the cache can't be purged behind their backGravatar reed2015-09-17
| | | | | | | | If I explicitly purge the resource-cache after every DM, these tests fail (sporadically) . BUG=skia: Review URL: https://codereview.chromium.org/1350143002
* add a ClassID function to GrBatchGravatar joshualitt2015-09-17
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/4078d529e9e199eea13456db7bf3a63a104ab5b9 Review URL: https://codereview.chromium.org/1352813003
* Revert of add a ClassID function to GrBatch (patchset #5 id:80001 of ↵Gravatar joshualitt2015-09-17
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1352813003/ ) Reason for revert: breaks mac bot Original issue's description: > add a ClassID function to GrBatch > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4078d529e9e199eea13456db7bf3a63a104ab5b9 TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1345393003
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-24 15:29:33 +0000