aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* fix leaks in SkConfGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | | | | These leaks were small and would only happen with non-default runtime configuration things set, but they were still leaks and they should be squished. Valgrind reported leaks pre-patch, and all the rtconf leaks are gone after patch. BUG=skia:1722 R=reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/136963004 git-svn-id: http://skia.googlecode.com/svn/trunk@13269 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaselines for ↵Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | | | https://skia.googlesource.com/skia.git/+/0b9ada1318acf7d5fe90c57331c2a4548aad8b98 BUG=skia:2113 NOTREECHECKS=True NOTRY=True R=epoger@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/151623002 git-svn-id: http://skia.googlecode.com/svn/trunk@13268 2bbb7eff-a529-9590-31e7-b0007b416f81
* remaining rebaselines for rects GM testGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | BUG=skia:2108 NOTREECHECKS=True NOTRY=True R=humper@google.com TBR=humper Author: epoger@google.com Review URL: https://codereview.chromium.org/148483005 git-svn-id: http://skia.googlecode.com/svn/trunk@13267 2bbb7eff-a529-9590-31e7-b0007b416f81
* remaining GM rebaselines for blurquickreject and megalooper testsGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | BUG=skia:2108 NOTREECHECKS=True NOTRY=True R=humper@google.com TBR=humper Author: epoger@google.com Review URL: https://codereview.chromium.org/134923007 git-svn-id: http://skia.googlecode.com/svn/trunk@13266 2bbb7eff-a529-9590-31e7-b0007b416f81
* Have peek32 return uint32_t& to make it harder to look at more than 4 bytes.Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=reed@google.com, robertphillips@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/145053003 git-svn-id: http://skia.googlecode.com/svn/trunk@13265 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix bad gyp file moveGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/151353004 git-svn-id: http://skia.googlecode.com/svn/trunk@13264 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebase simpleblurroundrect and bleed GMs after GPU blur radius changes.Gravatar bsalomon@google.com2014-01-31
| | | | | | | | BUG=skia:1998 Review URL: https://codereview.chromium.org/151503005 git-svn-id: http://skia.googlecode.com/svn/trunk@13263 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add GM with convex polygon clipsGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia:2051 R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/136563004 git-svn-id: http://skia.googlecode.com/svn/trunk@13262 2bbb7eff-a529-9590-31e7-b0007b416f81
* Set the horizontal scanline to NULL when the vertical one failsGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/150013004 git-svn-id: http://skia.googlecode.com/svn/trunk@13261 2bbb7eff-a529-9590-31e7-b0007b416f81
* release the scanline textures in GrRectBlurEffectGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/131163007 git-svn-id: http://skia.googlecode.com/svn/trunk@13260 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add shim for SkOrderedReadBuffer.h too.Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | Sorry, I specifically looked for this and failed the first time. BUG=skia: R=robertphillips@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/151093002 git-svn-id: http://skia.googlecode.com/svn/trunk@13259 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-01-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13258 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix auto-delete bug that crept in with new fast blur path; is causingGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | some of the valgrind errors. BUG=skia:2111 R=bsalomon@google.com, robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/148593003 git-svn-id: http://skia.googlecode.com/svn/trunk@13257 2bbb7eff-a529-9590-31e7-b0007b416f81
* initial import of Chrome's trace_event into skia frameworkGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | | | | | | | | | | This patch includes a modified version of Chrome's trace_event.h, which provides tracing macros that can easily integrate into the about://tracing framework. Currently the macros link to a default implementation of the (narrow) tracing class SkDefaultEventTracer which does nothing; next step will be to have Chrome subclass the SkEventTracer with a shim that bolts Skia's trace events to its own, allowing Skia's trace events to show up in about://tracing. I've verified that this file builds properly, and when I added a simple scoped TRACE_EVENT0 to SkCanvas::drawRect, along with some debug prints in the NOP implementation of tracing, I saw what I expected printed to the screen. BUG=skia: R=nduca@chromium.org, reed@google.com, mtklein@google.com, bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/149563004 git-svn-id: http://skia.googlecode.com/svn/trunk@13256 2bbb7eff-a529-9590-31e7-b0007b416f81
* even more rebaselines for blurGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia:2108 R=epoger@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/149823003 git-svn-id: http://skia.googlecode.com/svn/trunk@13255 2bbb7eff-a529-9590-31e7-b0007b416f81
* Port SkBase64 test to our test driver.Gravatar tfarina@chromium.org2014-01-30
| | | | | | | | | | BUG=None TESTS=tests --match SkBase64Test R=mtklein@google.com, reed@google.com Review URL: https://codereview.chromium.org/132233060 git-svn-id: http://skia.googlecode.com/svn/trunk@13254 2bbb7eff-a529-9590-31e7-b0007b416f81
* Set write buffer flags only in SkWriteBuffer and SkFlatController constructors.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | This is a baby step toward refactored (and faster in-process) typeface and flattenable factory encoding and decoding. The sooner SkWriteBuffer knows its flags, the better. Next steps will be to rearrange Sk{Read,Write}Buffer members into disjoint strategies to handle typefaces and flattenable factories: one for in-process, one for cross-process, one when validating. BUG=skia: R=reed@google.com, scroggo@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/138803005 git-svn-id: http://skia.googlecode.com/svn/trunk@13253 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove (unnecessary) SkScalarMul and SkScalarMulAdd macros from SkMatrix.cpp.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | SkScalarMulDiv remains, but it can be removed later (though it is slightly clearer to use it at times). BUG=skia: R=caryclark@google.com, mtklein@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/150493002 git-svn-id: http://skia.googlecode.com/svn/trunk@13252 2bbb7eff-a529-9590-31e7-b0007b416f81
* add_codereview_message script to append messages to a CLGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add add_codereview_message.py script. This script takes a message and a codereview URL as arguments calls `git cl upload` to append the message to the given codereview issue. Motivation: We are automating a process of testing Chromium/Skia DEPS rolls where roll_deps.py is automatically run every night, and then at a later time, compare_codereview.py is run to generate a report of the trybot results. This script can be used to append that report to the DEPS roll Cl. This CL also refactors functioanlity common to roll_deps and add_codereview_message: * Add tools/git_utils.py module. - ChangeGitBranch class was factored out of roll_deps.GitBranchCLUpload. The other half of that class became roll_deps.git_cl_uploader function. I make use of this new class in both roll_deps and upload_deps_roll. - test_git_executable moved to this new module. * Add tools/misc_utils.py - move VerboseSubprocess, ChangeDir, and ReSearch classes from roll_deps module. * Remove generic functions from roll_deps. * Add git_cl_uploader function to roll_deps. Refactor roll_deps.roll_deps function to make use of it BUG=skia: R=borenet@google.com, robertphillips@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/141483011 git-svn-id: http://skia.googlecode.com/svn/trunk@13251 2bbb7eff-a529-9590-31e7-b0007b416f81
* mark imageblur_gpu gm tests as ignore-failure on IntelRhbGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | BUG=skia:2085 NOTRY=True R=senorblanco@google.com TBR=senorblanco Author: epoger@google.com Review URL: https://codereview.chromium.org/150813002 git-svn-id: http://skia.googlecode.com/svn/trunk@13250 2bbb7eff-a529-9590-31e7-b0007b416f81
* Replace factory generation of TextContexts with persistent objects.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia:2018 R=bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/150743002 git-svn-id: http://skia.googlecode.com/svn/trunk@13249 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove GM expectations for all ASAN/Valgrind buildersGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | BUG=skia:2112 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/140323020 git-svn-id: http://skia.googlecode.com/svn/trunk@13248 2bbb7eff-a529-9590-31e7-b0007b416f81
* more blurrect rebaselinesGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia:2108 R=epoger@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/136813005 git-svn-id: http://skia.googlecode.com/svn/trunk@13247 2bbb7eff-a529-9590-31e7-b0007b416f81
* create empty expectations for Logan botsGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | BUG=skia:2107 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/150543004 git-svn-id: http://skia.googlecode.com/svn/trunk@13246 2bbb7eff-a529-9590-31e7-b0007b416f81
* Refactor read and write buffers.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer a step each in the hierarchy. What used to be this: SkFlattenableWriteBuffer -> SkOrderedWriteBuffer SkFlattenableReadBuffer -> SkOrderedReadBuffer SkFlattenableReadBuffer -> SkValidatingReadBuffer is now SkWriteBuffer SkReadBuffer -> SkValidatingReadBuffer Benefits: - code is simpler, names are less wordy - the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed - write buffers are completely devirtualized, important for record speed This refactoring was mostly mechanical. You aren't going to find anything interesting in files with less than 10 lines changed. BUG=skia: R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/134163010 git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81
* Suppress new valgrind complaintGravatar robertphillips@google.com2014-01-30
| | | | | | | | https://codereview.chromium.org/144853006/ git-svn-id: http://skia.googlecode.com/svn/trunk@13244 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline GM changes resulting from fast GPU blur algorithmGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/150493005 git-svn-id: http://skia.googlecode.com/svn/trunk@13243 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add convex polygon rendering effect and GM to test it.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia:2051 R=robertphillips@google.com, jvanverth@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/149683004 git-svn-id: http://skia.googlecode.com/svn/trunk@13242 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline imagefiltersgraph_gpu GMs on Nexus10Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | BUG=skia:2106 NOTREECHECKS=True NOTRY=True R=bsalomon@google.com TBR=bsalomon Author: epoger@google.com Review URL: https://codereview.chromium.org/150113003 git-svn-id: http://skia.googlecode.com/svn/trunk@13241 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline perf because of faster tests after GPU glur changesGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/150563002 git-svn-id: http://skia.googlecode.com/svn/trunk@13240 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move GrTextContext to private interfaceGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | NOTRY=true R=bsalomon@google.com, reed@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/145073005 git-svn-id: http://skia.googlecode.com/svn/trunk@13239 2bbb7eff-a529-9590-31e7-b0007b416f81
* patch from issue 119343003Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | compile on 10.6, exclude failing gms Sorry for making another CL; rebasing ToT on the old one ended up with code in a tangled mess; was easier to start over. NOTRY=true R=bsalomon@google.com, epoger@google.com, reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/148883005 git-svn-id: http://skia.googlecode.com/svn/trunk@13238 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reland "Add --skip_cpu and --skip_gpu options to tests"Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | NOTRY=true BUG=skia:2074 R=djsollen@google.com, mtklein@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/135163004 git-svn-id: http://skia.googlecode.com/svn/trunk@13237 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add fallback code for TextContexts that don't support all featuresGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | BUG=skia:2018 NOTRY=true R=bsalomon@google.com, reed@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/135683006 git-svn-id: http://skia.googlecode.com/svn/trunk@13236 2bbb7eff-a529-9590-31e7-b0007b416f81
* And before I forget: Remove UnitTest() method declaration from GrRedBlackTreeGravatar tfarina@chromium.org2014-01-30
| | | | | | | | | | | | | I forgot to remove it while doing r13233 (https://codereview.chromium.org/137423009/) BUG=None TEST=tests TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/145973010 git-svn-id: http://skia.googlecode.com/svn/trunk@13235 2bbb7eff-a529-9590-31e7-b0007b416f81
* GrRedBlackTree test is GPU specific.Gravatar tfarina@chromium.org2014-01-30
| | | | | | | | | | | | | | Wrapp the entire file/test in a SK_SUPPORT_GPU. This should fix the tree breakage. BUG=None TEST=tests TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/147843006 git-svn-id: http://skia.googlecode.com/svn/trunk@13234 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reland "Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT()."Gravatar tfarina@chromium.org2014-01-29
| | | | | | | | | | BUG=None TEST=tests R=robertphillips@google.com Review URL: https://codereview.chromium.org/137423009 git-svn-id: http://skia.googlecode.com/svn/trunk@13233 2bbb7eff-a529-9590-31e7-b0007b416f81
* Win8 baselines for displacement GM (razzin' frazzin' --keep-going-on-failure).Gravatar senorblanco@chromium.org2014-01-29
| | | | | | | | | TBR=epoger BUG=skia: Review URL: https://codereview.chromium.org/149073008 git-svn-id: http://skia.googlecode.com/svn/trunk@13232 2bbb7eff-a529-9590-31e7-b0007b416f81
* New baselines for displacement GM.Gravatar senorblanco@chromium.org2014-01-29
| | | | | | | | | | | This had a new test case added in r12773. TBR=epoger@google.com BUG=skia: Review URL: https://codereview.chromium.org/143263020 git-svn-id: http://skia.googlecode.com/svn/trunk@13231 2bbb7eff-a529-9590-31e7-b0007b416f81
* New baselines for GM tests affected by r13221.Gravatar senorblanco@chromium.org2014-01-29
| | | | | | | | | | | | | | | | | | | | The following tests were affected: imagefiltersbase imagefilterscropped imagefiltersgraph imagefiltersscaled dropshadowimagefilter offsetimagefilter spritebitmap tileimagefilter TBR=epoger@google.com BUG=skia: Review URL: https://codereview.chromium.org/148283008 git-svn-id: http://skia.googlecode.com/svn/trunk@13230 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaslines for https://codereview.chromium.org/23835006/Gravatar commit-bot@chromium.org2014-01-29
| | | | | | | | | | | | | Signed-off-by: Kévin PETIT <kevin.petit@arm.com> BUG=skia: R=djsollen@google.com, mtklein@google.com, reed@google.com Author: kevin.petit.arm@gmail.com Review URL: https://codereview.chromium.org/137833005 git-svn-id: http://skia.googlecode.com/svn/trunk@13229 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-01-29
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13228 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add standalone drawText for GrTextContext.Gravatar commit-bot@chromium.org2014-01-28
| | | | | | | | | | | | | | | This unifies the interface between GrBitmapTextContext and GrDistanceFieldTextContext so that they don't need special case code. The future GrNVPRTextContext will also use this interface. BUG=skia:2018 R=bsalomon@google.com, reed@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/141863005 git-svn-id: http://skia.googlecode.com/svn/trunk@13227 2bbb7eff-a529-9590-31e7-b0007b416f81
* tests: add --veryVerbose / -VGravatar commit-bot@chromium.org2014-01-28
| | | | | | | | | | | BUG=skia: R=caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/135723013 git-svn-id: http://skia.googlecode.com/svn/trunk@13226 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove BOM from SkFontHost_FreeType.cpp.Gravatar bungeman@google.com2014-01-28
| | | | | | | | | | | | | | | | | | | | With r12822 a UTF-8 BOM was added to SkFontHost_FreeType.cpp. This change removes it. Running find . -type f \( -name '*.cpp' -o -name '*.h' \) -exec file {} \; | grep BOM makes it look like this is the only file with a UTF-8 BOM at this time. The BOM is easily removed with tail -c +4 <filename> R=rmistry@google.com Review URL: https://codereview.chromium.org/141433025 git-svn-id: http://skia.googlecode.com/svn/trunk@13225 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Add --skip_cpu and --skip_gpu options to tests ↵Gravatar commit-bot@chromium.org2014-01-28
| | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/144343004/) Reason for revert: Broke tests on Win7 and Mac Original issue's description: > Add --skip_cpu and --skip_gpu options to tests > > BUG=skia:2074 > > Committed: http://code.google.com/p/skia/source/detail?r=13223 R=djsollen@google.com, mtklein@google.com TBR=djsollen@google.com, mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2074 Author: borenet@google.com Review URL: https://codereview.chromium.org/148173010 git-svn-id: http://skia.googlecode.com/svn/trunk@13224 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add --skip_cpu and --skip_gpu options to testsGravatar commit-bot@chromium.org2014-01-28
| | | | | | | | | | | BUG=skia:2074 R=djsollen@google.com, mtklein@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/144343004 git-svn-id: http://skia.googlecode.com/svn/trunk@13223 2bbb7eff-a529-9590-31e7-b0007b416f81
* Give correct bounds to SkCanvas's AutoDrawLooper use for filter draws.Gravatar senorblanco@chromium.org2014-01-28
| | | | | | | | | | | In conjuction with https://codereview.chromium.org/137423005/, this allows the canvas to tighten the bounds passed to saveLayer() only the affected region. R=reed@google.com BUG=100703 Review URL: https://codereview.chromium.org/141433017 git-svn-id: http://skia.googlecode.com/svn/trunk@13221 2bbb7eff-a529-9590-31e7-b0007b416f81
* Clamp negative sigma to 0 in SkDropShadowImageFilter.Gravatar senorblanco@chromium.org2014-01-28
| | | | | | | | | | | This can occur when the matrix includes a perspective transform. BUG=skia:2094 R=bsalomon@google.com Review URL: https://codereview.chromium.org/137833004 git-svn-id: http://skia.googlecode.com/svn/trunk@13220 2bbb7eff-a529-9590-31e7-b0007b416f81
* change setAlphaType to not modify the pixelref's genIDGravatar reed@google.com2014-01-28
| | | | | | | | | BUG=skia: R=bsalomon@google.com, halcanary@google.com Review URL: https://codereview.chromium.org/137263009 git-svn-id: http://skia.googlecode.com/svn/trunk@13219 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-29 20:32:19 +0000