aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Roll third_party/externals/swiftshader/ 840f47ea8..ce8eb945c (1 commit)Gravatar swiftshader-skia-autoroll2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/840f47ea853b..ce8eb945ca82 $ git log 840f47ea8..ce8eb945c --date=short --no-merges --format='%ad %ae %s' 2018-04-26 capn Accept GL_HALF_FLOAT and GL_HALF_FLOAT_OES interchangeably. Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=stani@google.com Change-Id: I477bcccf0b4a88fa206b004d95ee4d30370cbcd4 Reviewed-on: https://skia-review.googlesource.com/124146 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add InternalSurfaceFlag so we know if RenderTargetProxys and RenderTargets ↵Gravatar Greg Daniel2018-04-26
| | | | | | | | | | use GL FBO 0. Bug: skia:7748 Change-Id: I2fda3cde12ccdef19fe06ff287a8024b58d28ef0 Reviewed-on: https://skia-review.googlesource.com/124048 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll third_party/externals/angle2/ 0086de179..1633663b3 (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0086de17943b..1633663b351c $ git log 0086de179..1633663b3 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 geofflang Don't test for device loss in SwapBuffers and MakeCurrent. 2018-04-26 courtneygo Cleanup for "Add angle library apk" 2018-04-26 jmadill Vulkan: Fix TexSubImage2D state change test. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: I5d6347e1b6d495df64ff518e99d8a29b4e844acb Reviewed-on: https://skia-review.googlesource.com/124140 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "Reland "Reland "Exercise the threaded backend in test bots"""Gravatar Yuqian Li2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7ddad479e464a3d481d106415c9c1b8cc8496848. Reason for revert: bots failure Original change's description: > Reland "Reland "Exercise the threaded backend in test bots"" > > This reverts commit 0f5972604ce4439fd33118d6be1e4f24fe6c267f. > > Reason for revert: ASAN/MSAN should have been fixed > > Original change's description: > > Revert "Reland "Exercise the threaded backend in test bots"" > > > > This reverts commit 654ca8a340700ca8089abb7828adc2c229c6241e. > > > > Reason for revert: ASAN,MSAN failures > > > > Original change's description: > > > Reland "Exercise the threaded backend in test bots" > > > > > > This reverts commit ea51393ba918f75c1b40d521081789eeb3b42d6f. > > > > > > Reason for revert: try again after many fixes of the threaded backend > > > > > > Original change's description: > > > > Revert "Exercise the threaded backend in test bots" > > > > > > > > This reverts commit a39991ebd70f4aaf1290dd516467d729811e45ee. > > > > > > > > Reason for revert: Random bots timeout > > > > > > > > Original change's description: > > > > > Exercise the threaded backend in test bots > > > > > > > > > > We can't draw everything correctly now, but it's at least not crashing. > > > > > > > > > > The draw_to_canvas is modified by adding flush because now the raster > > > > > canvas also needs flush like GPU canvases because of the threaded > > > > > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink > > > > > and that's why it was not crashing.) > > > > > > > > > > > > > > > Bug: skia: > > > > > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd > > > > > Reviewed-on: https://skia-review.googlesource.com/118886 > > > > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > > > > > Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: skia: > > > > Reviewed-on: https://skia-review.googlesource.com/119100 > > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: skia:7838 > > > Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f > > > Reviewed-on: https://skia-review.googlesource.com/121680 > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > Change-Id: Id1b273e22a1d0cbc15a2155252909f576b401fa4 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia:7838 > > Reviewed-on: https://skia-review.googlesource.com/123360 > > Reviewed-by: Mike Klein <mtklein@google.com> > > Commit-Queue: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,kjlubick@google.com,stephana@google.com,liyuqian@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: skia:7838 > Change-Id: I205d579f2959ea726b447993314c1326b731730e > Reviewed-on: https://skia-review.googlesource.com/123660 > Commit-Queue: Yuqian Li <liyuqian@google.com> > Reviewed-by: Yuqian Li <liyuqian@google.com> TBR=mtklein@google.com,kjlubick@google.com,stephana@google.com,liyuqian@google.com Change-Id: I1d3986cc2af12836dd7acbcbba713081a88301a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7838 Reviewed-on: https://skia-review.googlesource.com/124200 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Fix missing/duplicate named cachesGravatar Ben Wagner2018-04-26
| | | | | | | | | | | Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929 No-Try: true Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c Reviewed-on: https://skia-review.googlesource.com/124180 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* remove GrBackendObject from example fiddlesGravatar Cary Clark2018-04-26
| | | | | | | | | | | R=robertphillips@google.com Docs-Preview: https://skia.org/?cl=123930 Bug: skia:6898 Change-Id: If579d0e0c0323a86d6ab86056b36f8660cbbde6f Reviewed-on: https://skia-review.googlesource.com/123930 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* Reland "Reland "Exercise the threaded backend in test bots""Gravatar Yuqian Li2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0f5972604ce4439fd33118d6be1e4f24fe6c267f. Reason for revert: ASAN/MSAN should have been fixed Original change's description: > Revert "Reland "Exercise the threaded backend in test bots"" > > This reverts commit 654ca8a340700ca8089abb7828adc2c229c6241e. > > Reason for revert: ASAN,MSAN failures > > Original change's description: > > Reland "Exercise the threaded backend in test bots" > > > > This reverts commit ea51393ba918f75c1b40d521081789eeb3b42d6f. > > > > Reason for revert: try again after many fixes of the threaded backend > > > > Original change's description: > > > Revert "Exercise the threaded backend in test bots" > > > > > > This reverts commit a39991ebd70f4aaf1290dd516467d729811e45ee. > > > > > > Reason for revert: Random bots timeout > > > > > > Original change's description: > > > > Exercise the threaded backend in test bots > > > > > > > > We can't draw everything correctly now, but it's at least not crashing. > > > > > > > > The draw_to_canvas is modified by adding flush because now the raster > > > > canvas also needs flush like GPU canvases because of the threaded > > > > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink > > > > and that's why it was not crashing.) > > > > > > > > > > > > Bug: skia: > > > > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd > > > > Reviewed-on: https://skia-review.googlesource.com/118886 > > > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > > > Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: skia: > > > Reviewed-on: https://skia-review.googlesource.com/119100 > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: skia:7838 > > Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f > > Reviewed-on: https://skia-review.googlesource.com/121680 > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com > > Change-Id: Id1b273e22a1d0cbc15a2155252909f576b401fa4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7838 > Reviewed-on: https://skia-review.googlesource.com/123360 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,kjlubick@google.com,stephana@google.com,liyuqian@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:7838 Change-Id: I205d579f2959ea726b447993314c1326b731730e Reviewed-on: https://skia-review.googlesource.com/123660 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* Roll skia/third_party/skcms c3b186a..5a327ce (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/c3b186a..5a327ce 2018-04-26 mtklein@chromium.org drop GaussNewton to max 3 parameters The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stani@google.com Change-Id: Ic242cd2f2d2e3ba599362b6f19725c831b1e9f61 Reviewed-on: https://skia-review.googlesource.com/124143 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Rotate about the slide center, and before perspectiveGravatar Brian Osman2018-04-26
| | | | | | | | | | This causes rotation to happen in the perspective plane, which is more (?) interesting/useful. Change-Id: If57a81de6662591be67cb68f0278f71038ac8d40 Reviewed-on: https://skia-review.googlesource.com/124160 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Fix AUTHORS check (take two)Gravatar Ben Wagner2018-04-26
| | | | | | | | | | | | Fixes a bug in https://skia.googlesource.com/skia/+/47ed6f10ef1d6c29512f95e88a7e51456c4d8f87%5E%21/#F0 Bug: skia:7833, skia:7050 Change-Id: I6441a08b926c84b918d1285b33c3784d4732f904 Reviewed-on: https://skia-review.googlesource.com/124161 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Roll skia/third_party/skcms ba9fcb3..c3b186a (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/ba9fcb3..c3b186a 2018-04-26 mtklein@google.com add poly_tf to skcms_sRGB_profile The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stani@google.com Change-Id: I456a54f4c810dc7c77978c4a68bcec6a875ff802 Reviewed-on: https://skia-review.googlesource.com/124064 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Replace flatten with writeFlattenable for desc.Gravatar Ben Wagner2018-04-26
| | | | | | | | | | | | | | | | This replaces calls to SkFlattenable::flatten(SkWriteBuffer&) with calls to SkWriteBuffer::writeFlattenable(const SkFlattenable*) when creating the descriptor for an SkScalerContext. This adds the identifier of the flattenable to the descriptor to avoid collisions when two flattenables take the same (or no) parameters. This used to be enforced when the SkScalerContext re-created the flattenable from the descriptor, but since this is no longer required these possible collisions may occur. Change-Id: I2b7efebebf20ffcc0f2b58a081ff0c58158f7d70 Reviewed-on: https://skia-review.googlesource.com/124054 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Add perspective support (rect to rect) to ViewerGravatar Brian Osman2018-04-26
| | | | | | | | | | | Change-Id: I312d5b3e6b7f37a3a7bfd5561bcdb31b43e207b8 Reviewed-on: https://skia-review.googlesource.com/123934 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Brian Osman <brianosman@google.com>
* Don't use triangle fans in default path rendererGravatar Brian Salomon2018-04-26
| | | | | | | Change-Id: Ie5dc65adfb843ba22690fe624c8bcb882a5fe43f Reviewed-on: https://skia-review.googlesource.com/123744 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Call destructors during reset to avoid memory leakGravatar Yuqian Li2018-04-26
| | | | | | | | | | | | | | Otherwise, the following ASAN test would fail: out/ASAN/dm --config t8888 -m savelayer_initfromprev Bug: skia: Change-Id: I464dd419c64dcb06197169cca51253f26c44e93e Reviewed-on: https://skia-review.googlesource.com/124053 Commit-Queue: Yuqian Li <liyuqian@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Yuqian Li <liyuqian@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Update Win2016 bots.Gravatar Ben Wagner2018-04-26
| | | | | | | | Change-Id: I6b8a16dd6aa1d188a46ca1bdf82c4023d6bab21a Reviewed-on: https://skia-review.googlesource.com/124043 Commit-Queue: Eric Boren <borenet@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [infra] Fix missing cache for BookmakerGravatar Eric Boren2018-04-26
| | | | | | | | Bug: skia: Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3 Reviewed-on: https://skia-review.googlesource.com/124052 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Revert "Reland "Revert "Add arcs as a specialized geometry to GrShape."""Gravatar Brian Salomon2018-04-26
| | | | | | | | | | This reverts commit 580aee2fa4a57bf8208498fbc23acea04e16e092. Bug: skia:7794 Change-Id: I9c2b923859c826dff58c22c529dc4e2ab4d0f186 Reviewed-on: https://skia-review.googlesource.com/124042 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-26
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/990148ed24f058d28c3abc12eb9b3ef7ffc3c56e gclient: Fix logic to match --patch-ref with dependencies. (ehmaldonado@chromium.org) https://crrev.com/7580f9dac98552b038f9644cf9712f09712c7858 Revert "Reland "bot_update: Patch on gclient by default."" (bpastene@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic19122334c0dea7318b8238df286b1040df765d5 Reviewed-on: https://skia-review.googlesource.com/124049 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* [recipes] Use named caches for git and workdirsGravatar Eric Boren2018-04-26
| | | | | | | | Bug: skia: Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c Reviewed-on: https://skia-review.googlesource.com/123929 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Update SKP versionGravatar skia-recreate-skps2018-04-26
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I3d3d0fb933915f79bf993bf6734e1bdf0dfd52f9 Reviewed-on: https://skia-review.googlesource.com/123909 Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com> Commit-Queue: Eric Boren <borenet@google.com>
* Track tail of strike cacheGravatar Herb Derby2018-04-26
| | | | | | | | | Change-Id: Ic5d5ae5d4c45d0bc5b82dd2257752184a8b529d0 Reviewed-on: https://skia-review.googlesource.com/123935 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* [infra] Fix AUTHORS checkGravatar Eric Boren2018-04-26
| | | | | | | | | | | It's looking for "google.com" but skia-swarming-bots doesn't have that prefix. Bug: skia:7833, skia:7050 Change-Id: I851453a20f46cd62772b9301226a315a6076ff89 Reviewed-on: https://skia-review.googlesource.com/123980 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-26
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/e38cf570fc8c0df53b576c179701efe6d683f7d2 Reland "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I132f51f6f407c8a2e77abef4b0adc7a2f9d5ced9 Reviewed-on: https://skia-review.googlesource.com/123938 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* AUTHORS check: Allow service accounts from skia-swarming-botsGravatar Eric Boren2018-04-26
| | | | | | | | Bug: skia:7833, skia:7050 Change-Id: Id5b3fdd1b0a4ae50fce7a5d1212c744a85274012 Reviewed-on: https://skia-review.googlesource.com/123936 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Update test expectations for Debian9Gravatar Kevin Lubick2018-04-26
| | | | | | | | | | | The removal of the blacklists is really a no-op because of https://skia-review.googlesource.com/c/skia/+/9339 Bug: skia:7840 Change-Id: I72e2e03bbbc813737655a3d5f3a1e874d3a41909 Reviewed-on: https://skia-review.googlesource.com/123925 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* alternative no anonymous enumsGravatar Cary Clark2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Anonymous enums play havoc with documentation; there's no name to refer to. It may be that all enums may either be named or replaced with constexpr without breaking anything. Try replacing all anonymous enums in include/core to see what happens. This names SkCanvas::SaveLayerFlagsSet but leaves SkCanvas::SaveLayerFlags as a uint32_t, to reduce risk as compared to review.skia.org/123584. There's also some chance that external linkage will break if some client refers to anonymous enum in a way that could require its address: see https://stackoverflow.com/questions/22867654/enum-vs-constexpr-for-actual-static-constants-inside-classes (This CL does not require definitions + declarations) Brought bookmaker docs in line with this change. This also tripped over missing code in bookmaker handling constexpr so added that as well. R=reed@google.com,bsalomon@google.com Docs-Preview: https://skia.org/?cl=123920 Docs-Preview: https://skia.org/?cl=123584 Bug: skia:6898 Change-Id: I14a342edcfd59e139ef9e4501f562417c4c60391 Reviewed-on: https://skia-review.googlesource.com/123920 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* ccpr: Don't use varying matricesGravatar Chris Dalton2018-04-26
| | | | | | | | Bug: skia:7869 Change-Id: Ie6071fd49d0eb32b2f5dfdf6413f99a9a8d41637 Reviewed-on: https://skia-review.googlesource.com/123908 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* [infra] RecreateSKPs and Bookmaker need the Git packagesGravatar Eric Boren2018-04-26
| | | | | | | | Bug: skia:7833, skia:7050 Change-Id: I8272e4b0beaed2a56260546f4a599a4586c71792 Reviewed-on: https://skia-review.googlesource.com/123921 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Make rounding code publicGravatar Herb Derby2018-04-26
| | | | | | | Change-Id: I37fec55277fe99734980c7473f964d37ca4248b8 Reviewed-on: https://skia-review.googlesource.com/123931 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* [infra] Enable retries for Windows compilesGravatar Eric Boren2018-04-26
| | | | | | | | | | | They're flaky due to https://github.com/golang/go/issues/21376 Bug: skia: Change-Id: Ic629c84b72c492b35d393328aa2178762ce3c7d8 Reviewed-on: https://skia-review.googlesource.com/123932 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Count the correct number of pos using text encoding.Gravatar Yuqian Li2018-04-26
| | | | | | | | | | | | | Otherwise, the following will crash: out/ASAN/dm --config t8888 --verbose --src gm -m skbug_5321 Bug: skia: Change-Id: I9b1d3412b9695b0fbd8a9afb0e6d3ae7159aeee6 Reviewed-on: https://skia-review.googlesource.com/123750 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Yuqian Li <liyuqian@google.com>
* Check negative width before blitAntiRectGravatar Yuqian Li2018-04-26
| | | | | | | | | | | Since we decrease the width when clipped, it might be negative. Bug: skia:7858 Change-Id: I348bd07d917905a55bec1a4b4e0915c6528fe6b1 Reviewed-on: https://skia-review.googlesource.com/123927 Auto-Submit: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Remove stale gradient color space assertGravatar Florin Malita2018-04-26
| | | | | | | | | | | | | SkGradientShaderBase asserts gammaIsLinear() -- but we don't enforce this in factories. Based on comments, this may be a stale restriction. Can we drop it? Bug: chromium:798208 Change-Id: Id9639cb2bb87f112b26c05372f2a3181c139e5ec Reviewed-on: https://skia-review.googlesource.com/123860 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add more granularity inside of SkCanvas::Flush traces.Gravatar Xiao Yu2018-04-26
| | | | | | | | | | We currently just get a big nondescript block when trying to understand what's taking rendering time. This will help us get an idea of the general categories of time consuming things when we toggle skia traces on. Bug: skia: Change-Id: Ia231cfc0e6e984172ad04547e95e269e8cc2d12a Reviewed-on: https://skia-review.googlesource.com/123820 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* [infra] Make the Android_Framework bot run on demandGravatar Eric Boren2018-04-26
| | | | | | | | | | | | | | This causes it to never get triggered automatically, so it will only run as a try job or when force-triggered. Caveat: if the job is defined on non-master branches, it will still trigger for those branches. Bug: skia: Change-Id: Idff63bd22536b21ec21eb4b569cc392642297d7b Reviewed-on: https://skia-review.googlesource.com/123923 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Disable optimizing xforms for speed on FlutterGravatar Brian Osman2018-04-26
| | | | | | | | | | Ironically, this is a giant slowdown, because xforms are being constructed every frame, and this takes multiple ms. Change-Id: Ib242b6b7b212c715d20fdd572ed6db5a167f07e2 Reviewed-on: https://skia-review.googlesource.com/123922 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Move Braswell HD 405 bots to Debian 9.4Gravatar Kevin Lubick2018-04-26
| | | | | | | Bug: skia:7840 Change-Id: I36114c55322a886a02d5588cc403984ea3c09aca Reviewed-on: https://skia-review.googlesource.com/123745 Reviewed-by: Eric Boren <borenet@google.com>
* Roll third_party/externals/angle2/ 197d52949..0086de179 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/197d52949eed..0086de17943b $ git log 197d52949..0086de179 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 lucferron Vulkan: Add test to reproduce graph issue when draw->subImage->draw Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: I461f7bcdaa78c2c9483e265748391a9013e8dc43 Reviewed-on: https://skia-review.googlesource.com/123881 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-26
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/3cb0767ac14e06a63a6e90d34c1c139b128dd87b recipes: cache destination branch of a Gerrit change. (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia51e2e05c41b375483ab88b5a99f8973f7de9690 Reviewed-on: https://skia-review.googlesource.com/123868 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-26
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c93ee0e7a9941356e1a7489af1abc2dca43f2c97 Add OWNERS to LUCI recipe modules. (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9eb65fd8b6d65c7a5116cf9800e8bb455d977875 Reviewed-on: https://skia-review.googlesource.com/123867 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-26
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0a82af179bce717e9be1240286497312309487d0 service_account: remove ability to vary lifetime and set it to 180s. (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I953b7f1a8ddb6b9f289f580e79dbdf01d6700001 Reviewed-on: https://skia-review.googlesource.com/123863 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/355b11a31f0d2bd2fcc4e14f8abc8681edbf3b2d bot_update: Patch on gclient by default. (ehmaldonado@chromium.org) https://crrev.com/cab00ccf8edb80933cd74612c232959fc3beae05 CQ: switch to 100% LUCI builders. (tandrii@chromium.org) https://crrev.com/2acf4957984643d8ac1a856afed0730c4449e190 Revert "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org) recipe_engine: https://crrev.com/e315ab3c7742e21b293911eb61e0c0a2e877acab cq: switch to 100% LUCI. (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I764502e99af4388c917db514f55763ff031e15d2 Reviewed-on: https://skia-review.googlesource.com/123861 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2/ f827123d9..197d52949 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/f827123d9945..197d52949eed $ git log f827123d9..197d52949 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 geofflang Wrap all preprocessor code in the angle namespace. 2018-04-23 lfy GLES1: Enable/disable for texture targets Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=stani@google.com Change-Id: Ib8cb85f7a1ba14dcba4f7c3192ce5f576ce30900 Reviewed-on: https://skia-review.googlesource.com/123821 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [skottie] Add support for inverse mask pathsGravatar Florin Malita2018-04-26
| | | | | | | | TBR= Change-Id: I442033b2e82777c90ee497d8a5b2310af1d2e631 Reviewed-on: https://skia-review.googlesource.com/123840 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll third_party/externals/swiftshader/ c8eedebdf..840f47ea8 (5 commits)Gravatar swiftshader-skia-autoroll2018-04-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/c8eedebdf51e..840f47ea853b $ git log c8eedebdf..840f47ea8 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 capn Fix Linux build. 2018-04-24 jemoreira Use the correct constant name for the Android SDK version 2018-04-25 tikuta Use override for overridden function 2018-04-24 sugoi Fixed sampler within struct uniform used as function argument 2018-04-16 sugoi Load sibling libraries from the same directory Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=stani@google.com Change-Id: I19c13710a072bfdbf7e07431874f845e533e2acb Reviewed-on: https://skia-review.googlesource.com/123801 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Fix GrAAConvexTessellator trying to fan a 0 point ringGravatar Adrienne Walker2018-04-25
| | | | | | | | | | | | This prevents accessing off an empty array. Bug: chromium:830038 Change-Id: I5ad019d56659c667564efc498dcef7fb112da4af Reviewed-on: https://skia-review.googlesource.com/123800 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com>
* Reland "Revert "Add arcs as a specialized geometry to GrShape.""Gravatar Brian Salomon2018-04-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8a98bc96748d1bdaf9c2d8cfa0b672e3a035973d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Revert "Add arcs as a specialized geometry to GrShape."" > > This reverts commit af88ec37124846a0168a4ab061bf10cc6030c2d6. > > Bug: skia:7794 > Change-Id: I2d0e1d7b4e025481241d823b09f5de5d0f1a13eb > Reviewed-on: https://skia-review.googlesource.com/123627 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,robertphillips@google.com Change-Id: Ib09a533600028b76a69b455c952f3dd12b39bdba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7794 Reviewed-on: https://skia-review.googlesource.com/123780 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove SkASSERT(fConvexity == kUnknown_Convexity) due to racingGravatar Yuqian Li2018-04-25
| | | | | | | | | | Bug: skia:7822 Change-Id: I2def72a6d032c43376906d189e5ee834c76b0898 Reviewed-on: https://skia-review.googlesource.com/123749 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com> Auto-Submit: Yuqian Li <liyuqian@google.com>
* Make SkString::appendf safe for long strings.Gravatar Brian Salomon2018-04-25
| | | | | | | | Bug: skia:7841 Change-Id: I5bc77f5230b63da74e42d756ab4a1fefcfab9926 Reviewed-on: https://skia-review.googlesource.com/123634 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 17:23:55 +0000