aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Document return value of SkPaint::operator==.Gravatar mtklein2014-08-25
| | | | | | | | | BUG=skia:1491 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/467063003
* Revert of Fix recursive computation of filter bounds for drop shadow, ↵Gravatar djsollen2014-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 of https://codereview.chromium.org/481273005/) Reason for revert: This CL is currently breaking the Win7 and Win8 bots on some of the new tests (in DM). Original issue's description: > Fix recursive computation of filter bounds for drop shadow, > morphology, blur. > > Because we're computing "backwards" from a clip rect of destination > pixels to be filled to the required source pixels, we should use tail > recursion rather than head recursion in onFilterBounds(). > > This actually only makes a difference for drop-shadow, where > the computation is non-commutative. Blur and morphology commute, but I > moved them to tail recursion anyway for clarity (so all onFilterBounds > use tail recursion). > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/28648fe4a69b0cee8df42b5966e4e645c3aabefb R=bsalomon@google.com, senorblanco@chromium.org TBR=bsalomon@google.com, senorblanco@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: djsollen@google.com Review URL: https://codereview.chromium.org/504773003
* Fix recursive computation of filter bounds for drop shadow,Gravatar senorblanco2014-08-25
| | | | | | | | | | | | | | | | | | | | morphology, blur. Because we're computing "backwards" from a clip rect of destination pixels to be filled to the required source pixels, we should use tail recursion rather than head recursion in onFilterBounds(). This actually only makes a difference for drop-shadow, where the computation is non-commutative. Blur and morphology commute, but I moved them to tail recursion anyway for clarity (so all onFilterBounds use tail recursion). BUG=skia: R=bsalomon@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/481273005
* XPS to use PathOps for inverse winding paths.Gravatar bungeman2014-08-25
| | | | | | | | R=caryclark@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/484343003
* Reverse swap order in DirectWrite typeface.Gravatar bungeman2014-08-25
| | | | | | | | | | | C++ forbids temporaries to bind to non-const references. VC++ allows you to do so anyway, but it makes clang on Windows sad. R=reed@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/487533004
* add const to arrays of member functionsGravatar caryclark2014-08-25
| | | | | | | | | | | | | running 'size ./out/Release/libskia_core.a' revealed a couple of places where path ops chose poorly and declared arrays of member functions to be unnecessarily writable. R=reed@android.com TBR=reed Author: caryclark@google.com Review URL: https://codereview.chromium.org/461363003
* Add SK_API to SkTextBlob and SkTextBlobBuilder.Gravatar jbroman2014-08-25
| | | | | | | | | BUG=skia:2868 R=fmalita@chromium.org, reed@google.com Author: jbroman@chromium.org Review URL: https://codereview.chromium.org/497993002
* remove SkPurgeGlobalDiscardableMemoryPoolGravatar halcanary2014-08-25
| | | | | | | | | BUG=skia:2721 R=reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/495453004
* Clean up useless comments in SkScaledImageCache.hGravatar qiankun.miao2014-08-25
| | | | | | | | | BUG=skia: R=reed@google.com Author: qiankun.miao@intel.com Review URL: https://codereview.chromium.org/499203002
* Update SKP version to 82Gravatar borenet2014-08-23
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/499893002
* Update SKP version to 81Gravatar borenet2014-08-22
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/497343002
* Don't leak the shader by reffing twice in SkRectShaderImageFilter.Gravatar mtklein2014-08-22
| | | | | | | | | BUG=skia: R=bsalomon@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/501563002
* Disable Neon optimization of bad S32A/D565 blend.Gravatar mtklein2014-08-22
| | | | | | | | | | | | BUG=skia:2797 Committed: https://skia.googlesource.com/skia/+/84cab93186fbe3e87d931fea73cb31b70ff5017b R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/497823002
* Copy Ubuntu12 RenderSKPs expectations for Recipes botGravatar borenet2014-08-22
| | | | | | | | | | | | This is in preparation for implementing the render_skps workflow in recipes. BUG=skia:761 R=epoger@google.com, stephana@google.com TBR=epoger, stephana Author: borenet@google.com Review URL: https://codereview.chromium.org/496283005
* Add testing flag for XPS for deterministic ids.Gravatar Ben Wagner2014-08-22
| | | | | | | BUG=skia:455 R=mtklein@google.com Review URL: https://codereview.chromium.org/494423002
* Fix leak of GrResourceCacheEntryGravatar bsalomon2014-08-22
| | | | | | | | | R=robertphillips@google.com TBR=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/502543002
* Disable Neon optimization of bad S32A/D565 blend.Gravatar mtklein2014-08-22
| | | | | | | | | BUG=skia:2797 R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/497823002
* Support comment groups in SkRecord.Gravatar mtklein2014-08-22
| | | | | | | | | | | This should fix the failing paint-command-log-nodes.html layout test. BUG=406425 R=tomhudson@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/501533003
* suppress matrixconvolutionGravatar Mike Klein2014-08-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/476283003
* Fix saveLayer() with a pixel-moving filter vs SkBBoxHierarchyRecord / ↵Gravatar mtklein2014-08-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | SkRecordDraw In SkBBoxHierarchyRecord: Since the bounds we pass to saveLayer are in the pre-filtering coordinate space, they aren't correct for determining the actual device pixels touched by the saveLayer in this case. The easiest fix for now is to pass the clip bounds, since the final draw done in restore() will never draw outside the clip. In SkRecordDraw: We do adjust the bounds passed to saveLayer, so we just need to make sure that when we're using a paint that may affect transparent black, we ignore the calculated bounds of draw ops and use the clip intersected with those adjusted bounds. See originally crrev.com/497773002 BUG=skia: R=reed@google.com, senorblanco@chromium.org, junov@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/496963003
* Fix leak in multipicturedraw GMs.Gravatar bsalomon2014-08-22
| | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/502493002
* [SkTextBlob] Merge run font data at draw time.Gravatar fmalita2014-08-22
| | | | | | | | R=bungeman@google.com, reed@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/496773002
* extend SkShader to report a luminance-color to be used for gamma correctionGravatar reed2014-08-22
| | | | | | | | | BUG=skia:590 R=bungeman@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/492963002
* disable neon proc that is triggering assertsGravatar reed2014-08-22
| | | | | | | | | BUG=skia:2845 R=mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/498733002
* Some early 565 rebaselines.Gravatar Mike Klein2014-08-22
| | | | | | BUG=skia:2797 Review URL: https://codereview.chromium.org/488453003
* Add some text blob bounds unit tests.Gravatar fmalita2014-08-22
| | | | | | | | R=robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/498693002
* fix numerical overflows in 565 blendsGravatar reed2014-08-22
| | | | | | | | | BUG=skia:2797 R=mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/474983007
* Store vertex size in DrawState when setVertexAttribs is calledGravatar egdaniel2014-08-22
| | | | | | | | | | | | This will avoid recalculating vertex size throughout code, and will allow for a set original vertex size once optimizations start removing VA's BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/498483002
* Ignore GMs that will need 565 rebaselines.Gravatar Mike Klein2014-08-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/483883004
* Cleanup: Remove BenchTool xcode project file.Gravatar tfarina2014-08-22
| | | | | | | | | | BUG=None TEST=None R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/491263003
* fix leak in new createprocGravatar reed2014-08-22
| | | | | | | | | BUG=skia: R=caryclark@google.com, mike@reedtribe.org, mtklein@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/461253007
* add tool generated whitespaceGravatar caryclark2014-08-22
| | | | | | | | | | | | | | | | the rebaseline tool adds whitespace at the end of lines in the json file. While harmless, git flags this as something worth fixing. Fixing it causes the rebaseline tool to generate a new difference with the whitespace. Checking the whitespace back in to avoid future back-and-forth. TBR= NOTRY=true NOTREECHECKS=true Author: caryclark@google.com Review URL: https://codereview.chromium.org/494363002
* fix remaining arm64 expectationsGravatar caryclark2014-08-22
| | | | | | | | | | | | R=halcanary@google.com TBR=halcanary@google.com NOTRY=true NOTREECHECKS=true BUG=skia:2845 Author: caryclark@google.com Review URL: https://codereview.chromium.org/496253004
* Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline ↵Gravatar rmistry2014-08-22
| | | | | | | | | | | server. BUG=skia:2230 R=epoger@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/479613002
* create sk_tools::Expectation class, similar to skiagm::Expectations classGravatar epoger2014-08-21
| | | | | | | | | | | | | | | | | The overarching goal here is for our "gm" and "render_pictures" tools to handle image expectations/actuals in the same way, sharing the same code, so their results can be processed through a single pipeline. By adding an Expectation class within tools/image_expectations.h, similar to the Expectations class in gm/gm_expectations.h, we get one step closer to that goal. R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/493363002
* Update SKP version to 80Gravatar borenet2014-08-21
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/475873003
* Initial refactor of shaderbuilder to prepare for geometry shadersGravatar joshualitt2014-08-21
| | | | | | | | | | | gitignore for eclipse BUG=skia: R=bsalomon@google.com, bsalomon@chromium.org Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/491673002
* Revert of Revert back to SkPictureData pictures. Huge perf regression. ↵Gravatar mtklein2014-08-21
| | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 of https://codereview.chromium.org/496603002/) Reason for revert: Try again now that we have --bbh on nanobench and it's looking decent. Original issue's description: > Revert back to SkPictureData pictures. Huge perf regression. > > http://skiaperf.com/#108 > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4082d290eea2f70caa82120ff3bc4fbdccbf206c R=reed@google.com, mtklein@chromium.org TBR=mtklein@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/496173002
* 1.5x -> 2x text size for y pad.Gravatar mtklein2014-08-21
| | | | | | | | | | | | | | This will expand the cheat to just big enough to pass an assertion coming from our GDI bot. Currently failing: -6.000000 -1.500000 6.000000 1.500000 vs. -1.000000 -2.000000 3.000000 1.000000 Will become (-8 -2 8 2) vs. (-1 -2 3 1). BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/496153002
* Add --bbh (default true) to nanobench.Gravatar mtklein2014-08-21
| | | | | | | | | | | | | | | | | | | | | | | | | Chrome's using a bounding box, so it's a good idea for our bots to do so too. When set, we'll create an SkTileGrid to match the parameters of --clip, and so should always hit its fast path. This will impose a small overhead (querying the BBH) on all SKPs, but make large SKPs render more quickly. E.g. on GPU desk_pokemonwiki should show about a 30% improvement, tabl_mozilla about 40%, and one very long page from my personal suite, askmefast.com, gets 5x faster. (The performance changes are not the point of the CL, but something we should be aware of.) BUG= R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/497493003
* Add some SkTextBlob builder tests.Gravatar fmalita2014-08-21
| | | | | | | | R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/493443004
* Ignore small text sizes in the text bounding assert.Gravatar mtklein2014-08-21
| | | | | | | | | | | Seems we sometimes give back unduely large metrics for 0 text size. BUG=skia:2862 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/498503003
* Fix surface leak in multidraw GMs.Gravatar bsalomon2014-08-21
| | | | | | | | TBR=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/496793003
* fix android framework build for nanobenchGravatar djsollen2014-08-21
| | | | | | | | R=mtklein@google.com, tomhudson@chromium.org, tomhudson@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/495003004
* git-sync-deps handles recursive DEPSGravatar halcanary2014-08-21
| | | | | | | | | NOTRY=true R=mtklein@google.com, borenet@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/468113003
* SkMultiPictureDraw APIGravatar robertphillips2014-08-21
| | | | | | | | | | | | This CL adds a new API to optimize across multiple SkPicture draw calls. Note that multiple pictures rendered at once (i.e., picture piles) should be flattened into a single new picture that includes the required clipping on the different layers. R=bsalomon@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/491313003
* Fix root level Android.mk to now point to the correct nanobench makefileGravatar djsollen2014-08-21
| | | | | | | | R=mtklein@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/494193003
* Split up monolithic EXPERIMENTAL_drawPicture methodGravatar robertphillips2014-08-21
| | | | | | | | | | | | This is prep for the new multi-picture API. This is split out of (Add new API to allow layer hoisting/atlasing across picture piles - https://codereview.chromium.org/474623002/) R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/489103002
* Install a hook to swap between SkPicture backends with a single define.Gravatar mtklein2014-08-21
| | | | | | | | | BUG=skia: R=robertphillips@google.com, reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/492023002
* Cleanup FDO options.Gravatar djsollen2014-08-21
| | | | | | | | R=tomhudson@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/489373004