| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplify GrGLPathRendering interface by removing polymorphism and functions that
simply wrap GL functions unnecessarily.
Replace the polymorphism by if -condition.
Call the unconditional GL functions directly. GrGLPath, GrGLPathRange and
GrGLPathRendering are part of the same logical subsystem. This means that the
subsystem implementation details are taken into account within these
classes. Example: if support for using conics would be added, the feature flag
would go to GrGLPathRendering::Caps, the emulation would go to GrGLPath instead of
GrGLPathRendering::pathCommands. Wrapping glPathCommandsNV is not useful.
Try to expose the interface fully in same logical level; rename fragment input
function to reflect this.
R=bsalomon@google.com, cdalton@nvidia.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/450283002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate GL path rendering state from GrGpuGL to GrGLPathRendering. This
makes GrGpuGL code simpler.
The intention is that while GrGpuGL represents the global environment for GL,
the GrGLPathRendering represents the global environment for path rendering
extension.
Add GrPathRendering, a base class for path rendering, and inherit
GrGLPathRendering from that. Move the path rendering virtual functions from
GrGpu to GrPathRendering.
R=bsalomon@google.com, cdalton@nvidia.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/452823002
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=372341
Committed: https://skia.googlesource.com/skia/+/93cf46f7d687128d2ad05762bd65fea6c4539553
R=bsalomon@google.com, tomhudson@chromium.org
Author: changjun.yang@intel.com
Review URL: https://codereview.chromium.org/277323002
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out recording actual text metrics is currently really slow.
If we want to compete with the (cheating) status quo, gotta cheat too.
BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/494483002
|
|
|
|
|
|
|
|
|
|
|
| |
Everyone used MB, so update the API to just return that.
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/483323002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2766
R=junov@chromium.org, halcanary@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/406673003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/481443002/)
Reason for revert:
Likely caused a leak detected in Chromium after last Skia roll.
Original issue's description:
> Add GrResourceCache2.
>
> Currently it just replaces GrGpu as the owner of the linked list of resources.
>
> Committed: https://skia.googlesource.com/skia/+/94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f
R=mtklein@google.com, robertphillips@google.com
TBR=mtklein@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/477323006
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/486233003
|
|
|
|
|
|
|
|
| |
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/483313002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Friends with https://codereview.chromium.org/487233003/
Example of out/Release/nanobench --options build_number 12374 --match patch_grid_texs_small
{
"gitHash":"unknown-revision",
"options":{
"build_number":"12374",
"system":"UNIX"
},
"results":{
"patch_grid_texs_small_640_480":{
"565":{
"max_ms":0.268116,
"mean_ms":0.2318529,
"median_ms":0.235337,
"min_ms":0.219158,
"options":{
"source_type":"bench"
},
"stddev_ms":0.01491263917658814
},
"8888":{
"max_ms":0.231881,
"mean_ms":0.2214668,
"median_ms":0.219356,
"min_ms":0.218887,
"options":{
"source_type":"bench"
},
"stddev_ms":0.004595541070791701
},
"gpu":{
"max_ms":0.1398304782608696,
"mean_ms":0.128833402173913,
"median_ms":0.1316798695652174,
"min_ms":0.1111915434782609,
"options":{
"GL_RENDERER":"Quadro 600/PCIe/SSE2",
"GL_SHADING_LANGUAGE_VERSION":"4.40 NVIDIA via Cg compiler",
"GL_VENDOR":"NVIDIA Corporation",
"GL_VERSION":"4.4.0 NVIDIA 331.79",
"source_type":"bench"
},
"stddev_ms":0.008923738937837156
}
}
}
}
BUG=skia:
R=jcgregorio@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/490683002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
old/new
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/484763004
|
|
|
|
|
|
|
|
|
|
| |
Currently it just replaces GrGpu as the owner of the linked list of resources.
R=robertphillips@google.com, mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/481443002
|
|
|
|
|
|
|
|
|
| |
R=reed@google.com, reed
BUG=skia:2849
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/483273003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This rolls jsoncpp to head, crucially past "Added missing includes for
std::istream." which has given us some grief in the past. And it's required to
build jsoncpp against libc++.
Vanilla jsoncpp works just fine for us, so no need for Chromium's overrides.
Like all DEPS, only tools depend on jsoncpp.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/481823003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mainly this cuts out a type to have to think about in SkRecord world.
It also means all the CTMs are recorded directly in the SkRecord, so
we can track the current CTM by pointer rather than by copying.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/484673003
|
|
|
|
|
|
|
|
|
|
| |
DRAW_PICTURE_MATRIX_PAINT & DRAW_PATCH are drawing ops.
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/480463004
|
|
|
|
|
|
|
|
|
|
| |
Committed: https://skia.googlesource.com/skia/+/2a51d7c74cec217195f861677de8998b382b39e4
R=mtklein@google.com, reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/481053002
|
|
|
|
|
|
|
|
|
|
| |
TBR=
NOTREECHECKS=true
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/463353003
|
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/487073003
|
|
|
|
|
|
|
|
|
|
| |
used for willPlayBackBitmaps in http://skbug.com/2702."
This reverts commit 60c2a79cfa8ceebcbafc243407564dc71f5e3b4f.
BUG=skia:
Review URL: https://codereview.chromium.org/481173003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directories, not lists
Before this CL, we supported multiple setADirs/setBDirs for some operations but
not others... now we consistently support a single pair of directories.
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/480293002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
willPlayBackBitmaps in http://skbug.com/2702.
Also unifies that flag and this one into a struct so they and others can be computed together. The struct is stored const to enforce lifetime expectations. Adds a few new cases to the unit test.
BUG=skia:2700
R=mtklein@google.com, reed@google.com, robertphillips@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/364823009
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 2a51d7c74cec217195f861677de8998b382b39e4.
Breaking Blink
NOTRY=true
R=bungeman@google.com
TBR=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/472303006
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/485703002
|
|
|
|
|
|
|
|
|
|
|
|
| |
SKPs.
BUG=skia:2833
NOTRY=true
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/480153002
|
|
|
|
|
|
|
|
| |
R=mtklein@google.com, reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/481053002
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:399728
R=reed@google.com, nduca@chromium.org
Author: ajuma@chromium.org
Review URL: https://codereview.chromium.org/478673002
|
|
|
|
|
|
|
|
| |
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/480113002
|
|
|
|
|
|
|
|
|
|
|
| |
This covers most of the common draws.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/469213007
|
|
|
|
|
|
|
|
| |
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/481783002
|
|
|
|
|
|
|
|
|
|
|
| |
This is calved off of (Add new API to allow layer hoisting/atlasing across picture piles
- https://codereview.chromium.org/474623002/)
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/482773002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:761
R=epoger@google.com, rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/481963002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only substantive change in this CL is skipping atlasing
for any layers that are involved in nesting. Prior versions
have allowed nesting layers to be atlased.
--------------------------------------------------------
All times are on Windows with a repeat count of 200.
Format is: <time in ms> (<# of glBindframebuffer calls>)
How to interpret this:
For the boogie page:
both columns should be the same (since boogie has no
nested layers)
without the new API the tiled case doesn't show any real
benefit from hoisting
For the carsvg page:
The nesting change does increase the number of FBO
switches but doesn't kill performance
Because of the location & size of the layers the
tile case does show some improvement (even
without the new API)
boogie
-------
w/o nested change w/ nested change
simple 5.62 (811) N/A
tiled 7.72 (811) N/A
simple w/ hoisting 5.23 (409) 5.77 (409)
(but no caching)
tiled w/ hoisting 7.57 (809) 7.49 (809)
(but no caching)
carsvg
------
w/o nested change w/ nested change
simple 60.37 (141990) N/A
tiled 115.13 (256929) N/A
simple w/ hoisting 41.57 (64570) 42.82 (72279)
(but no caching)
tiled w/ hoisting 84.24 (154352) 84.71 (165630)
(but no caching)
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/476833004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug fixed: I was calling paint->canComputeFastBounds() where I should have been calling fSaveStack[i].paint->canComputeFastBounds().
This suggested I factor out the paint adjusting code, now called AdjustForPaint(). This removes the getImageFilter() check for SaveLayers, which seems like an optimization we can add back later if it proves important.
We're going to want to intersect the bounds with the current clip bounds eventually, so might as well land that here too.
Plus, more const.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/481543002
|
|
|
|
|
|
|
|
|
|
|
| |
We're only keeping bench_pictures around for the bots now. For human-initiated work, nanobench is the way to go.
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/484663002
|
|
|
|
|
|
|
|
| |
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/465823003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only seem to need to sort with SkQuadTree, which is not actively used by
client code. So it's really just wasted work. SkQuadTree is interesting, but
I'd rather disable it than slow down the production code path.
BUG=skia:2834
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/471063004
|
|
|
|
|
|
|
|
|
|
|
| |
Remove things related to no-longer-existing unittests, run makefile_writer_tests --rebaseline
BUG=skia:2843
R=djsollen@google.com, scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/481943002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=reed@google.com, mike@reedtribe.org
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/483593002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome/Chromium OS are getting a brand new CJK fonts (Noto Sans CJK).
We want them to be used in place of common Japanese and Simplified
Chinese sans-serif fonts.
BUG=chromium:399080
TEST=With CrOS CL
(https://chromium-review.googlesource.com/#/c/212624/), web pages
using 'Simhei' and 'MSP Gothic' are rendered with Noto Sans CJK.
R=reed@chromium.org, bungeman@google.com
Author: jshin@chromium.org
Review URL: https://codereview.chromium.org/476203003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We must be quite careful about the order of fields in a 'pragma pack(1)'.
On Android the order 'uint16_t, void*' will misalign the pointer,
potentially leading to a crash.
In the future we should move anything which is not strictly part of the
table definition outside of the packed region.
R=mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/474313002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/472123002
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/478533002
|
|
|
|
|
|
|
|
|
|
| |
With the recent Android changes and removal of chaining, this is no longer used.
R=djsollen@google.com, reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/476713003
|
|
|
|
|
|
|
|
| |
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/472153002
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com, krajcevski@gmail.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/475433004
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com, bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/464423003
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:761
NOTREECHECKS=true
R=robertphillips@google.com, bsalomon@google.com, krajcevski@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/481883003
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is on top of my previous cl to fix the mem leaks of the regular patch bench.
NOTREECHECKS=true
BUG=skia:
R=egdaniel@google.com, bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/470543004
|
|
|
|
|
|
|
|
|
|
|
| |
NOTREECHECKS=true
BUG=skia:
R=robertphillips@google.com, senorblanco@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/474983002
|