aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert "Revert "Revert of https://codereview.chromium.org/110593003/""Gravatar reed@google.com2014-01-06
| | | | | | | | | | This reverts commit 0fef787f33aa38109a0c8427e0098d997efdd5ff. failed in chrome: https://codereview.chromium.org/124503002/ Review URL: https://codereview.chromium.org/105523008 git-svn-id: http://skia.googlecode.com/svn/trunk@12906 2bbb7eff-a529-9590-31e7-b0007b416f81
* Convert two more tests to DEF_TEST() macro.Gravatar tfarina@chromium.org2014-01-06
| | | | | | | | | | | | | | | | Out of three, two were converted. These tests were found with the following command line: $ g grep "public Test" BUG=None TEST=ran tests executable fine. R=mtklein@google.com Review URL: https://codereview.chromium.org/122943004 git-svn-id: http://skia.googlecode.com/svn/trunk@12905 2bbb7eff-a529-9590-31e7-b0007b416f81
* SK_SUPPORTED_DEPRECATED_FIXEDROUND around deprecated fixed[round,ceil,floor]Gravatar mike@reedtribe.org2014-01-06
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12903 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaselines for more straggling bots.Gravatar senorblanco@chromium.org2014-01-04
| | | | | | | | TBR= Review URL: https://codereview.chromium.org/121943003 git-svn-id: http://skia.googlecode.com/svn/trunk@12902 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-01-04
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12901 2bbb7eff-a529-9590-31e7-b0007b416f81
* Yet more rebaselines from straggling bots.Gravatar senorblanco@chromium.org2014-01-04
| | | | | | | | | BUG= TBR= Review URL: https://codereview.chromium.org/116463005 git-svn-id: http://skia.googlecode.com/svn/trunk@12900 2bbb7eff-a529-9590-31e7-b0007b416f81
* Stragglers.Gravatar senorblanco@chromium.org2014-01-04
| | | | | | | | TBR= Review URL: https://codereview.chromium.org/124353004 git-svn-id: http://skia.googlecode.com/svn/trunk@12899 2bbb7eff-a529-9590-31e7-b0007b416f81
* New baselines for tileimagefilter, imagefiltersgraph, and everything Nexus4.Gravatar senorblanco@chromium.org2014-01-04
| | | | | | | | TBR= Review URL: https://codereview.chromium.org/101693010 git-svn-id: http://skia.googlecode.com/svn/trunk@12898 2bbb7eff-a529-9590-31e7-b0007b416f81
* Widen suppression to tileimagefilter-pdf.Gravatar senorblanco@chromium.org2014-01-03
| | | | | | | | TBR= Review URL: https://codereview.chromium.org/122683004 git-svn-id: http://skia.googlecode.com/svn/trunk@12897 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore failures on tileimagefilter-pdf_poppler.Gravatar senorblanco@chromium.org2014-01-03
| | | | | | | | TBR= Review URL: https://codereview.chromium.org/124263003 git-svn-id: http://skia.googlecode.com/svn/trunk@12896 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make SkImageFilter crop rects relative to the primitive origin, instead of ↵Gravatar senorblanco@chromium.org2014-01-03
| | | | | | | | | | | | | | | | | | relative to their parent's crop rect. This is required by SVG semantics, and is more sane anyway. To do this, this patch changes the "offset/loc" parameter in filterImage() / onFilterImage() from an inout-param to an out-param only, so that the calling filter can know how much the input filter wants its result offset (and doesn't include the original primitive position). This offset can then be applied to the current filter's crop rect. (I've renamed the parameter "offset" in all cases to make this clear.) This makes the call sites in SkCanvas/SkGpuDevice responsible for applying the resulting offset to the primitive's position, which is actually a fairly small change. This change also fixes SkTileImageFilter and SkOffsetImageFilter to correctly handle an input offset, which they weren't before. This required modifying the GM's, since they assumed the broken behaviour. NOTE: this will require rebaselining the imagefiltersgraph test, since it has a new test case. NOTE: this will "break" the Blink layout tests css3/filters/effect-reference-subregion-chained-hw.html and css3/filters/effect-reference-subregion-hw.html, but it actually makes them give correct results. It should be suppressed on the skia roll, and I'll rebaseline it. R=reed@google.com Review URL: https://codereview.chromium.org/112803004 git-svn-id: http://skia.googlecode.com/svn/trunk@12895 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert of https://codereview.chromium.org/110593003/"Gravatar reed@google.com2014-01-03
| | | | | | | | | | | | This reverts commit c7abb25b25ba8b97948371d2bf0a2e3e78468f73. and fixes the ashmem break BUG= Review URL: https://codereview.chromium.org/119753010 git-svn-id: http://skia.googlecode.com/svn/trunk@12887 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add SkPreConfig.h to core.gypiGravatar commit-bot@chromium.org2014-01-03
| | | | | | | | | | | BUG= R=reed@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/116903007 git-svn-id: http://skia.googlecode.com/svn/trunk@12886 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline gm self-tests after ↵Gravatar commit-bot@chromium.org2014-01-03
| | | | | | | | | | | | | | | | | https://code.google.com/p/skia/source/detail?r=12850 The GM self-test's fragility is already noted in https://code.google.com/p/skia/issues/detail?id=1068 ('make gm self-test more robust') NOTRY=True NOTREECHECKS=True R=mtklein@google.com TBR=mtklein Author: epoger@google.com Review URL: https://codereview.chromium.org/112203006 git-svn-id: http://skia.googlecode.com/svn/trunk@12885 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/110593003/Gravatar commit-bot@chromium.org2014-01-03
| | | | | | | | | | | | | | | | Reason for revert: SkImageRef_ashmem doesn't compile R=halcanary@google.com, scroggo@google.com TBR=halcanary@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG= Author: reed@google.com Review URL: https://codereview.chromium.org/119753009 git-svn-id: http://skia.googlecode.com/svn/trunk@12884 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add onNewLockPixels, that returns rowbytes and relies on info in pixelrefGravatar reed@google.com2014-01-03
| | | | | | | | | | | This reverts commit 890a6ec633c1f54891104a072a8964b4c2c81af9. BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/110593003 git-svn-id: http://skia.googlecode.com/svn/trunk@12883 2bbb7eff-a529-9590-31e7-b0007b416f81
* make results_test.py work better within python unittest frameworkGravatar commit-bot@chromium.org2014-01-03
| | | | | | | | | | | BUG= R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/122443006 git-svn-id: http://skia.googlecode.com/svn/trunk@12882 2bbb7eff-a529-9590-31e7-b0007b416f81
* assert in setPixelRef that the pr matches the bitmap's configGravatar reed@google.com2014-01-03
| | | | | | | | | BUG= R=halcanary@google.com Review URL: https://codereview.chromium.org/120063003 git-svn-id: http://skia.googlecode.com/svn/trunk@12880 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-01-03
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12875 2bbb7eff-a529-9590-31e7-b0007b416f81
* An SkOSWindow for Unix may experience stuttering, with missed events or long ↵Gravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | | | delays before events are processed when using SkEvent.postDelay(). The issue is with the use of a select loop to watch for events coming into the x11 file descriptor for the display. It turns out there may be XEvents queued in memory but not yet processed that need to be handled before entering the select loop. See: http://developerweb.net/viewtopic.php?id=3184 BUG=1960 R=reed@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/123303004 git-svn-id: http://skia.googlecode.com/svn/trunk@12874 2bbb7eff-a529-9590-31e7-b0007b416f81
* Function pointers -> templates in SkPictureFlat.Gravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | | | | These flatten/unflatten function pointers were driving me nuts when reading the generated assembly for this code. We don't need the flexibility of function pointers here, so let's use templates to make it more manageable. You'll notice we get much better typing now on flatten/unflatten. BUG= R=reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/123213004 git-svn-id: http://skia.googlecode.com/svn/trunk@12873 2bbb7eff-a529-9590-31e7-b0007b416f81
* Get rid of DEFINE_TESTCLASS_SHORT() macro.Gravatar tfarina@chromium.org2014-01-02
| | | | | | | | | | | | | Instead tests should be written using DEF_TEST() macro, which is much nicer and simplifies the process of setting up an unit test. BUG=None TEST=skpskgr_test, pathops_unittest R=mtklein@google.com Review URL: https://codereview.chromium.org/117863005 git-svn-id: http://skia.googlecode.com/svn/trunk@12870 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update 4 skimage expectations.Gravatar halcanary@google.com2014-01-02
| | | | | | | | | | | | | | | Grab expectations missed in codereview:102213009, sicne the bots were slow: - Test-ChromeOS-Daisy-MaliT604-Arm7-Debug - Test-ChromeOS-Daisy-MaliT604-Arm7-Release - Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind - Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN BUG= R=epoger@google.com Review URL: https://codereview.chromium.org/93713007 git-svn-id: http://skia.googlecode.com/svn/trunk@12869 2bbb7eff-a529-9590-31e7-b0007b416f81
* take 2: create simple 'skpmaker' tool to generate SKP files for testingGravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | (re-landing https://codereview.chromium.org/108343006 without the build breakages) BUG=skia:1943 R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/112253004 git-svn-id: http://skia.googlecode.com/svn/trunk@12866 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/108343006/Gravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | | | | Reason for revert: broke some builds R=rmistry@google.com, mtklein@google.com TBR=mtklein@google.com, rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:1943 Author: epoger@google.com Review URL: https://codereview.chromium.org/102243012 git-svn-id: http://skia.googlecode.com/svn/trunk@12865 2bbb7eff-a529-9590-31e7-b0007b416f81
* create simple 'skpmaker' tool to generate SKP files for testingGravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | (needed to create self-test for render_pictures) BUG=skia:1943 R=rmistry@google.com, mtklein@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/108343006 git-svn-id: http://skia.googlecode.com/svn/trunk@12864 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR and make fInfo constGravatar reed@google.com2014-01-02
| | | | | | | | | BUG= R=halcanary@google.com Review URL: https://codereview.chromium.org/107373004 git-svn-id: http://skia.googlecode.com/svn/trunk@12863 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add a release procedure to SkMallocPixelRef; remove SkDataPixelRefGravatar halcanary@google.com2014-01-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This works in a way that is similar to SkData. SkMallocPixelRef::NewWithProc Motivation: Chrome has a ETC1PixelRef which calls delete[] on the pixles on destruction. There is no reason for them to almost duplicate our class, when we can provide them a more flexible class. Example use: static void delete_uint8_proc(void* ptr, void*) { delete[] static_cast<uint8_t>(ptr); } SkPixelRef* new_delete_pixref(const SkImageInfo& info, SkColorTable* ctable) { size_t rb = info.minRowBytes(); return SkMallocPixelRef::NewWithProc( info, rb, ctable, new uint8_t[info.getSafeSize(rb)], delete_uint8_proc, NULL); } SkMallocPixelRef::NewWithData Motivation: This allows up to eliminate SkDataPixelRef. We modified SkImage_Raster to use MallocPixelRef rather than SkDataPixlRef. Also: Unit tests in tests/MallocPixelRefTest. BUG= R=reed@google.com Review URL: https://codereview.chromium.org/106883006 git-svn-id: http://skia.googlecode.com/svn/trunk@12861 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make tests output spin on the same line by default.Gravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | -v now gives a cleaned-up version of the existing output (every test timed, useless information removed) Example output, default: [ 36/193] PathOpsCubicIntersectionOneOffTest then later when finished... [193/193] BlurMaskFilter Example output, -v: (note, codereview is messing up my pretty spacing) Skia UnitTests: --resourcePath resources SK_RELEASE SK_SCALAR_IS_FLOAT skia_arch_width=32 [ 1/193] 0ms PathOpsSimplifyDontFailOneTest [ 2/193] 0ms PathOpsSimplifyFailOneTest [ 3/193] 30ms PathOpsSkpTest [ 4/193] 21ms PathOpsSimplifyFailTest .... [182/193] 1026ms BlitRow [183/193] 808ms AAClip [184/193] 4333ms Math [185/193] 5068ms PackBits [186/193] 2265ms DrawText_DrawPosText [187/193] 9163ms PathOpsRectsThreadedTest [188/193] 5540ms GLPrograms [189/193] 0ms GLInterfaceValidation [190/193] 2ms DeferredCanvas [191/193] 1ms ClipCache [192/193] 30ms BlurMaskFilter [193/193] 10396ms PathOpsOpCubicsThreadedTest Finished 193 tests, 0 failures, 0 skipped. (622610 internal tests) BUG= R=halcanary@google.com, mtklein@google.com, bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/109513002 git-svn-id: http://skia.googlecode.com/svn/trunk@12860 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unused function.Gravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | BUG= R=reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/121113005 git-svn-id: http://skia.googlecode.com/svn/trunk@12859 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add Options to SkDecodingImageGenerator, simplify API.Gravatar halcanary@google.com2014-01-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Motivation: We want to remove redundant classes from Skia. To that end we want to remove SkImageRef and its subclasses and replace their uses with SkDiscardablePixelRef + SkDecodingImageGenerator. Since Android uses SkImageRef, we need to make sure that SkDecodingImageGenerator allows all of the settings that Android exposes in BitmapFactory.Options. To that end, we have created an Options struct for the SkDecodingImageGenerator which lets the client of the generator set sample size, dithering, and bitmap config. We have made the SkDecodingImageGenerator constructor private and replaced the SkDecodingImageGenerator::Install functions with a SkDecodingImageGenerator::Create functions (one for SkData and one for SkStream) which now take a SkDecodingImageGenerator::Options struct. Also added a ImageDecoderOptions test which loops through a list of sets of options and tries them on a set of 5 small encoded images. Also updated several users of SkDecodingImageGenerator::Install to follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp, and PictureTest.cpp, CachedDecodingPixelRefTest.cpp. We also added a new ImprovedBitmapFactory Test which simulates the exact function that Android will need to modify to use this, installPixelRef() in BitmapFactory. R=reed@google.com, scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=12744 Review URL: https://codereview.chromium.org/93703004 git-svn-id: http://skia.googlecode.com/svn/trunk@12855 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-01-02
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12853 2bbb7eff-a529-9590-31e7-b0007b416f81
* speedup SkRect::intersectGravatar mike@reedtribe.org2014-01-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12851 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add default resource path for skia test cases in gm and bench tools.Gravatar tfarina@chromium.org2013-12-31
| | | | | | | | | | BUG=skia:1765 TEST=./out/Release/gm --match downsamplebitmap_image R=mtklein@google.com, scroggo@google.com, yunchao.he@intel.com Review URL: https://codereview.chromium.org/120873002 git-svn-id: http://skia.googlecode.com/svn/trunk@12850 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-12-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12849 2bbb7eff-a529-9590-31e7-b0007b416f81
* ComputeRowBytes must not overflow width when it shiftsGravatar reed@google.com2013-12-30
| | | | | | | | | BUG= R=halcanary@google.com Review URL: https://codereview.chromium.org/122473002 git-svn-id: http://skia.googlecode.com/svn/trunk@12848 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix drawVertices when we have both colors and texturesGravatar reed@google.com2013-12-30
| | | | | | | | | | | fix: don't re-call setContext on the composshader (i.e. on the tricolor shader) for each triangle, since the trishader handles that explicitly. Just call setContext on the original shader. BUG= Review URL: https://codereview.chromium.org/102193006 git-svn-id: http://skia.googlecode.com/svn/trunk@12847 2bbb7eff-a529-9590-31e7-b0007b416f81
* Possibly uninitialized SkRgnBuilder fStorage.Gravatar commit-bot@chromium.org2013-12-30
| | | | | | | | | | | | | | fStorage needs to be initialized regardless of SkRgnBuilder::init()'s outcome - otherwise the destructor can end up freeing garbage. BUG=330293 R=reed@google.com, fmalita@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/122313002 git-svn-id: http://skia.googlecode.com/svn/trunk@12846 2bbb7eff-a529-9590-31e7-b0007b416f81
* reenable vertices gm, adding picture supportGravatar reed@google.com2013-12-30
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/112913005 git-svn-id: http://skia.googlecode.com/svn/trunk@12845 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fixing crash found by fuzzerGravatar commit-bot@chromium.org2013-12-30
| | | | | | | | | | | | | | | A previous fix only partially fixed this issue by adding validation on some inputs of SkImageInfo. If anything invalid is detected in SkImageInfo, unfortunately, this can cause getSafeSize() to do an illegal memory access while calling bytesPerPixel(), which could have a bad color type at this point. A possible fix is to simply make sure we are in a valid state before calling getSafeSize(). BUG=329254 R=reed@google.com, mtklein@google.com, bsalomon@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/107003006 git-svn-id: http://skia.googlecode.com/svn/trunk@12844 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert of https://codereview.chromium.org/113823003/"Gravatar reed@google.com2013-12-30
| | | | | | | | | | This reverts commit 68b4b32066ea0ba9dbb5d326a836f8a54297b7aa. BUG= Review URL: https://codereview.chromium.org/122293002 git-svn-id: http://skia.googlecode.com/svn/trunk@12842 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/113823003/Gravatar commit-bot@chromium.org2013-12-30
| | | | | | | | | | | | | | | | Reason for revert: need to update callsites in linux codecs R=robertphillips@google.com TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG= Author: reed@google.com Review URL: https://codereview.chromium.org/122283002 git-svn-id: http://skia.googlecode.com/svn/trunk@12841 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove Sk64 from public API, and start to remove usage internallyGravatar reed@google.com2013-12-30
| | | | | | | | | BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/113823003 git-svn-id: http://skia.googlecode.com/svn/trunk@12840 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-12-30
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12838 2bbb7eff-a529-9590-31e7-b0007b416f81
* disable gm/vertices until I can find/fix all warningsGravatar mike@reedtribe.org2013-12-30
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12837 2bbb7eff-a529-9590-31e7-b0007b416f81
* really disable replayGravatar mike@reedtribe.org2013-12-30
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12836 2bbb7eff-a529-9590-31e7-b0007b416f81
* suppress pictures for vertices for nowGravatar mike@reedtribe.org2013-12-30
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12835 2bbb7eff-a529-9590-31e7-b0007b416f81
* add gm::verticesGravatar mike@reedtribe.org2013-12-30
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12834 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/119943002/Gravatar commit-bot@chromium.org2013-12-26
| | | | | | | | | | | | | | | | Reason for revert: False alert on zheng.xu's original CL - it didn't break anything. R=bungeman@google.com, reed@google.com, zheng.xu@arm.com, robertphillips@google.com, rmistry@google.com TBR=bungeman@google.com, reed@google.com, rmistry@google.com, robertphillips@google.com, zheng.xu@arm.com NOTREECHECKS=true NOTRY=true BUG= Author: bensong@google.com Review URL: https://codereview.chromium.org/117963003 git-svn-id: http://skia.googlecode.com/svn/trunk@12822 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-12-24
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12820 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-06 02:09:35 +0000