aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* harden line2d effectGravatar Mike Reed2018-05-18
| | | | | | | | | | Suggested by https://fuzzer.skia.org/category/n32_canvas/file/c3JjL2NvcmUvU2tTdHJva2UuY3Bw? Bug: skia: Change-Id: I8ec48f844bfa5d063f0ab1bdfe0612ec4673ada3 Reviewed-on: https://skia-review.googlesource.com/129260 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add rules for cmake 3.11 to not errorGravatar Herb Derby2018-05-18
| | | | | | | | | | | As of cmake 3.11, the add_library target must have sources associated with it. If there are sources, just compile the file empty.cpp. Change-Id: I7fec03dc0f0d2e6098572ed6e9fcdfaac3811024 Reviewed-on: https://skia-review.googlesource.com/129189 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* tweak conservative bounds value to save aberrant cubicGravatar Mike Reed2018-05-18
| | | | | | | | Bug: 844457 Change-Id: Ia3c7c0592df59022cf04f6747b1fe30975431ea4 Reviewed-on: https://skia-review.googlesource.com/129200 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
* added global variable and multi-texture support to metal sksl backendGravatar Timothy Liang2018-05-18
| | | | | | | | Bug: skia: Change-Id: If676774ec0a30c5b536ccffbff2220d180b7fa59 Reviewed-on: https://skia-review.googlesource.com/129187 Commit-Queue: Timothy Liang <timliang@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Fix fuzzer bug i.e., compute the correct repeated dst domainGravatar Robert Phillips2018-05-18
| | | | | | | | BUG: oss-fuzz:8367 Change-Id: Ib5a9bf6e8446459db88016176e4c22397a3f1965 Reviewed-on: https://skia-review.googlesource.com/129184 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Use inheritance to define TextureGeometryProcesor vertex structsGravatar Brian Salomon2018-05-18
| | | | | | | Change-Id: Ibddc994e6b5599ab20a6f3d81dfe9c6644fb1f69 Reviewed-on: https://skia-review.googlesource.com/129183 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add convenience overload of SkPointPriv::SetRectTriStrip that takes SkRectGravatar Brian Salomon2018-05-18
| | | | | | | Change-Id: Idf5bfafaf19c20f074f12d706b8b8984c5935e6d Reviewed-on: https://skia-review.googlesource.com/129185 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* GrTessellator: fix for zombie edge fuzzer crash.Gravatar Stephen White2018-05-18
| | | | | | | | | | | | | | | | While splitting one edge, merge_collinear_edges() may in rare cases merge the other edge of the intersection out of existence. split_edge() then brings these dead edges partially back to life, leaving the mesh in an inconsistent state. The fix is to null out the top and bottom pointers of dead edges to mark them as dead, and only split living edges. Bug: skia:7911 Change-Id: I1c0b59581acfcd0b8191f2d129b33f7d0d1a2516 Reviewed-on: https://skia-review.googlesource.com/129181 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Add BOOK and DEMI_LIGHT.Gravatar Ben Wagner2018-05-18
| | | | | | | | | | It would be nice to use FcWeightToOpenType but this was buggy until 2.12.4. Change-Id: Ifcf9bfc783ea63c684bedb2a22267e97461d4945 Reviewed-on: https://skia-review.googlesource.com/129182 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Driver bug workaround: unbind_attachments_on_bound_render_fbo_deleteGravatar Adrienne Walker2018-05-18
| | | | | | | | Bug: chromium: 829614 Change-Id: Ic6bc276d1203d24f96fe92b41655871e25f69623 Reviewed-on: https://skia-review.googlesource.com/128395 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org>
* Prevent SkMatrixConvolutionImageFilter from allocating large buffers it ↵Gravatar Kevin Lubick2018-05-18
| | | | | | | | | | can't fill Bug: skia:7937 Change-Id: I71a5673939b3d91864a4b788e1e3a520b0ee04dd Reviewed-on: https://skia-review.googlesource.com/129179 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* validate perlin inputsGravatar Mike Reed2018-05-18
| | | | | | | | Bug: oss-fuzz:8359 Change-Id: Ib539c8549f2e00d6b0da099f48c4084d2bfbefd8 Reviewed-on: https://skia-review.googlesource.com/129180 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* fix bookmaker typoGravatar Cary Clark2018-05-18
| | | | | | | | | | | | | Fix one character and update the web documentation. Docs-Preview: https://skia.org/?cl=128938 TBR=robertphillips@google.com Bug: skia:6898 Change-Id: I4525ef8d3bae85ef1d63f84ff414a32b9935ae0e Reviewed-on: https://skia-review.googlesource.com/128938 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org>
* Roll third_party/externals/angle2/ 4607148c6..8688bf46f (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/4607148c6be3..8688bf46f183 $ git log 4607148c6..8688bf46f --date=short --no-merges --format='%ad %ae %s' 2018-05-18 lucferron Vulkan: readPixels improvement - use DynamicBuffer Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=herb@google.com Change-Id: Ica913fa2f0036a43260525ec5b036e5e7f90226b Reviewed-on: https://skia-review.googlesource.com/129146 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/swiftshader/ 607771b44..cbb80f5f0 (1 commit)Gravatar swiftshader-skia-autoroll2018-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/607771b44474..cbb80f5f0078 $ git log 607771b44..cbb80f5f0 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 krzysio Accept GL_TEXTURE_MAX_ANISOTROPY_EXT for samplers. Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=herb@google.com Change-Id: Id1bc594cff9f77e9f51ff84ca093e57765fdd9b7 Reviewed-on: https://skia-review.googlesource.com/129149 Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Modifications to GrTextureOp outsetting, edge equation code.Gravatar Brian Salomon2018-05-18
| | | | | | | | | | | | | | | | Factor out to its own function to be reused with perspective. Avoid initial shuffles to fan order using nextCW and nextCCW helpers that assume tri strip order. Make sign test stay in 4f. Use fmas. Change-Id: I60cff205f6193c4e01ea84218812a663ce74038f Reviewed-on: https://skia-review.googlesource.com/129175 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Make SkStream readers report failure.Gravatar Ben Wagner2018-05-18
| | | | | | | | | | This also fixes an issue noticed while making this change where SkFontDescriptor improperly round trips negative axis values. Change-Id: Iacc5929a185659dcacc18c802c4908e4f34c6899 Reviewed-on: https://skia-review.googlesource.com/128341 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Add SkIRect::adjust methodGravatar Robert Phillips2018-05-18
| | | | | | | Change-Id: Ib18d1a82944524e20d5d72912d8db7a823c470de Reviewed-on: https://skia-review.googlesource.com/128884 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* [recipes] Remove a bunch of unnecessary expectationsGravatar Eric Boren2018-05-18
| | | | | | | | Bug: skia:6473 Change-Id: Ic2eee8074476c449cc9bed4701105609e91ea12b Reviewed-on: https://skia-review.googlesource.com/128929 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* [skiaserver] Start loading html/css/js from https://debugger-assets.skia.org.Gravatar Joe Gregorio2018-05-18
| | | | | | | | | | Also clean up quoting and fix a hard-coded URL to https://debugger.skia.org. Bug: skia: Change-Id: I31283f3769c81a138d82c03214f005c7fb82c5b2 Reviewed-on: https://skia-review.googlesource.com/129164 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Fix bugs related to SkMatrixConvolutionImageFilter in repeat modeGravatar Robert Phillips2018-05-18
| | | | | | | | | This should fix most of the fuzzer complaints Change-Id: I47a616e78b47bd162cbef647b03f5c1f23017c6f Reviewed-on: https://skia-review.googlesource.com/129165 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* [recipes] Move a lot of logic out of vars moduleGravatar Eric Boren2018-05-18
| | | | | | | | | | | | | In general, vars should only contain variables which are the same for all tasks. Variables specific to compilation belong in the build module (or compile recipe), and those specific to running tests belong in the flavor module, or the individual recipe which uses them. Bug: skia:6473 Change-Id: Ifd55a57118c5801e6f4934a6b5de9d1567415b9a Reviewed-on: https://skia-review.googlesource.com/128545 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Add proxy unique key management to GrOnFlushResourceProviderGravatar Chris Dalton2018-05-18
| | | | | | | | Bug: skia: Change-Id: I0c462e282ea6d78f22340546c03b357f1ba7666f Reviewed-on: https://skia-review.googlesource.com/129140 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll third_party/externals/angle2/ 1ce8aede0..4607148c6 (4 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/1ce8aede0043..4607148c6be3 $ git log 1ce8aede0..4607148c6 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 courtneygo Add build-id for all builds to help debugging 2018-05-17 courtneygo Format cleanup 2018-05-17 ynovikov Revert "Vulkan: readPixels improvement - use DynamicBuffer" 2018-05-15 lucferron Vulkan: readPixels improvement - use DynamicBuffer Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=herb@google.com Change-Id: I5426450c2e0fc6f4b6584ac7ed70b18e3ac38581 Reviewed-on: https://skia-review.googlesource.com/129122 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/swiftshader/ 419a5806a..607771b44 (1 commit)Gravatar swiftshader-skia-autoroll2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/419a5806a9ff..607771b44474 $ git log 419a5806a..607771b44 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 capn Prevent 32-bit numeric overflow on image allocation. Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=herb@google.com Change-Id: Ia1373841ed2db63eb726701f606b6e6c9e22b345 Reviewed-on: https://skia-review.googlesource.com/128997 Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* refactor setBoundsCheck() a bitGravatar Mike Klein2018-05-17
| | | | | | | | | | | | | This doesn't change anything practical, but makes sure setBoundsCheck() and setBoundsNoCheck() run through the same logic. Bug: skia:7967 Change-Id: Ic78e2ebd5ebf46d6251c84ba93dcd397a97816fc Reviewed-on: https://skia-review.googlesource.com/129060 Auto-Submit: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Roll third_party/externals/swiftshader/ 89c43d202..419a5806a (2 commits)Gravatar swiftshader-skia-autoroll2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/89c43d202302..419a5806a9ff $ git log 89c43d202..419a5806a --date=short --no-merges --format='%ad %ae %s' 2018-05-08 capn Refactor surface buffer size calculation. 2018-05-08 capn Refactor maximum texture dimensions. Created with: roll-dep third_party/externals/swiftshader The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader TBR=herb@google.com Change-Id: Ied9e8682161980e45f6bf7f66297b5a0c6416f4d Reviewed-on: https://skia-review.googlesource.com/128995 Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/8fe4d8cbef3bff9d615de14d9a414679cf9ca8c3 gclient: Actually fix roll-dep. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I78e4093faa596bc197e9777aad7d851e7b5e9d85 Reviewed-on: https://skia-review.googlesource.com/129040 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* fonts: Handle fallback to using paths for text rendering for remoting.Gravatar Khushal2018-05-17
| | | | | | | | | | | | | | | | | | SkRemoteGlyphCache only sends images for glyphs, even for cases where the gpu falls back to drawing text as paths. This includes cases in SkDraw::ShouldDrawTextAsPaths and when the glyph exceeds the max bounds that can fit on the atlas. Fix this by identifying these cases in the renderer and sending paths instead. Note: We still don't handle distance field text correctly. R=herb@google.com, bsalomon@google.com Bug: skia:7913 Change-Id: I17d4eccbeaa2e995ae67b61c76cebd27f8280329 Reviewed-on: https://skia-review.googlesource.com/128203 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
* Remove SK_IGNORE_SKIMAGE_ONREFENCODED_CHANGE.Gravatar Ben Wagner2018-05-17
| | | | | | | | | All implementers have been updated, so remove the flag and old code. Change-Id: Ie9747f37dd0ea3f1db682891bcae2496a470bc3a Reviewed-on: https://skia-review.googlesource.com/128883 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* fonts: Use empty glyphs on cache miss.Gravatar Khushal2018-05-17
| | | | | | | | | | | | | | In case of a cache miss, we end up using a glyph with garbage memory which can result in arbitrary memory allocations for generating images for these glyphs. Use empty glyphs instead. R=herb@google.com Bug: skia:7913 Change-Id: Ie81b006a6872e077f9fd37e0a5751750c66f9ecb Reviewed-on: https://skia-review.googlesource.com/128701 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
* Roll skia/third_party/skcms 3e527c6..5bfec77 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/3e527c6..5bfec77 2018-05-17 mtklein@chromium.org rm GaussNewton.[ch] The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: Idf7e24d60750f69db9d09a71e9665073380b8912 Reviewed-on: https://skia-review.googlesource.com/128987 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* fix setBoundsNoCheck exampleGravatar Cary Clark2018-05-17
| | | | | | | | | | | | | | fix setBoundsNoCheck example R=caryclark@google.com Docs-Preview: https://skia.org/?cl=129000 Bug: skia:6898 Change-Id: Ic7ad412089bf21fd4de93f3acbeb50c7efc30a81 Reviewed-on: https://skia-review.googlesource.com/129000 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org>
* Specify the ADB keys to use for ADBGravatar Kevin Lubick2018-05-17
| | | | | | | | | | | | | | | In the golo, specifically, the adb keys used by swarming are different than those used in the docker instance, unless configured otherwise. This means swarming can think a device is ready (authorized) but the adb we called was not (authorized) BUG: 843284 Change-Id: I697d5075258a176e7fc7a4b51a9e2c926e1b8fd0 Reviewed-on: https://skia-review.googlesource.com/128930 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Roll skia/third_party/skcms 3f444c5..3e527c6 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/3f444c5..3e527c6 2018-05-17 brianosman@google.com Added skcms_AreApproximateInverses(Curve, TransferFunction) The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: Ia10c2fe8dc17972b8e5570819ff6ac197f4d77f8 Reviewed-on: https://skia-review.googlesource.com/128984 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/b496b6a0570bd4c9be2c1034ae1b5ae4360b327b gclient: Fix roll-dep. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib1c636a7657412e3a45fbcfc20b6b4eb5bd069bb Reviewed-on: https://skia-review.googlesource.com/128933 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll skia/third_party/skcms 06d773b..3f444c5 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/06d773b..3f444c5 2018-05-17 mtklein@chromium.org rm skcms_PolyTF and skcms_OptimizeForSpeed() The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: Ibdab92aa3d3cd9cc478623051ad1abb915765a7e Reviewed-on: https://skia-review.googlesource.com/128981 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Roll skia/third_party/skcms 14afdb8..06d773b (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/14afdb8..06d773b 2018-05-17 mtklein@chromium.org add android.fp16 build The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: Iba574756d324fb12f2091a9af6d5f4da4a8b8f7d Reviewed-on: https://skia-review.googlesource.com/128965 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add MoltenVK_Vulkan botsGravatar Chris Dalton2018-05-17
| | | | | | | | | | | | | | Adds a prebuilt MoltenVK framework asset from: KhronosGroup/MoltenVK.git:0279543e0bb561f8d0166d4030481136bc914fec And creates bots that use it. Bug: skia: Change-Id: I081b2745c41a25de9ecd94a5363f4fb13b120215 Reviewed-on: https://skia-review.googlesource.com/128646 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Roll third_party/externals/angle2/ 0e1c158ed..1ce8aede0 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0e1c158ed0e6..1ce8aede0043 $ git log 0e1c158ed..1ce8aede0 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 jmadill dEQP: Shorten test case names. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=herb@google.com Change-Id: If6e173ca3092ee1bd938eb3c30e87fed54fa78bc Reviewed-on: https://skia-review.googlesource.com/128961 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Check for correct bounds of large rotated and skewed emoji.Gravatar Jim Van Verth2018-05-17
| | | | | | | | Bug: skia:7879 Change-Id: I039ca9d216c3a9a913f5dd5f63d7f01de3abfdc8 Reviewed-on: https://skia-review.googlesource.com/128923 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Roll skia/third_party/skcms e4c0e54..14afdb8 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/e4c0e54..14afdb8 2018-05-17 mtklein@chromium.org bump package versions on skcms tree The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Change-Id: Ic9cfb0c2fddca3e0ab3aca06f48af3fd94d3c5c5 Reviewed-on: https://skia-review.googlesource.com/128962 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Fix srcBounds computation in SkMatrixConvolutionImageFilterGravatar Robert Phillips2018-05-17
| | | | | | | | | | | Note that this does change the behavior of the cropRect for the repeated case. The cropRect now only acts as a hard clip on the output. BUG= skia:7766 Change-Id: I1d66678bc797cd4835701cd20c36e68b22ac880a Reviewed-on: https://skia-review.googlesource.com/127338 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Color DocumentationGravatar Cary Clark2018-05-17
| | | | | | | | | | | | | | | | - treat Color, ARGB, etc as things not requiring definitions - fix links to Anti-alias, RGB-565 - finish everything marked incomplete, color and elsewhere - add #Code blocks for #Typedef R=caryclark@google.com Docs-Preview: https://skia.org/?cl=128547 Bug: skia:6898 Change-Id: Icf12fe70bc2bf1a8b1a5b31380b2454610949f23 Reviewed-on: https://skia-review.googlesource.com/128547 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/4727c64750e84e093a8046384fb0d1f0fbb2b339 gclient: Fix getdep and setdep and add tests. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib044ca18ad05a485c779f94cf32484ce826bd731 Reviewed-on: https://skia-review.googlesource.com/128882 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Return nullptr when ReadBuffer becomes invalidGravatar Kevin Lubick2018-05-17
| | | | | | | | | | | | | | | | | This especially helps in SkDrawLooper because we can bail out early instead of looping for a potentially long time, e.g. when fuzzed input says count is a large number. This also cleans up validate in a few spots, and adds validateCanReadN as a helper function. Bug: skia:7937 Change-Id: Ic5eff357c8cadc91eeafc6e39c78c570ba74df2f Reviewed-on: https://skia-review.googlesource.com/128847 Commit-Queue: Kevin Lubick <kjlubick@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Rewrite GrQuad to use separate arrays of x and y values to be Sk4f friendly.Gravatar Brian Salomon2018-05-17
| | | | | | | Change-Id: Ie2ad197c5f17849fe6e034b60bc7ec18a00edb24 Reviewed-on: https://skia-review.googlesource.com/128842 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* added basic texturing to metal sksl backendGravatar Timothy Liang2018-05-17
| | | | | | | | Bug: skia: Change-Id: I2e70efe53f5c2fb208979cc89be9c3c841944a48 Reviewed-on: https://skia-review.googlesource.com/128844 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* check path bounds before trying to shadowGravatar Mike Reed2018-05-17
| | | | | | | | Bug: oss-fuzz:8331 Change-Id: Idbff0deb0b9968edf4b4fafd4cf497bbb71c64fa Reviewed-on: https://skia-review.googlesource.com/128550 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove static initializer to register destructor.Gravatar Ben Wagner2018-05-17
| | | | | | | | | | | | | Skia cannot have global sk_sp objects because they will register an exit time destructor which will be done through a static initializer. BUG=chromium:843858 Change-Id: I43e3d18c9d8b50ff067414148c7524bffd3523da Reviewed-on: https://skia-review.googlesource.com/128843 Auto-Submit: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>