aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add assertHeld() to SkMutex.Gravatar mtklein2014-06-09
| | | | | | | | | BUG=skia: R=bungeman@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/313823004
* Revert of Gamma correction for distance field text. ↵Gravatar scroggo2014-06-09
| | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/258883002/) Reason for revert: Memory leaks. I suspect this is due to the lack of destructors in SkAutoGlyphCache Original issue's description: > Gamma correction for distance field text. > > Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4d517fdbb145cb95e5e935470df331e1b6667cfc NOTRY=true NOTREECHECKS=true R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, mtklein@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/323513005
* Reland "Clean up Test's resourcePath code."Gravatar tfarina2014-06-09
| | | | | | | | | | | | | This relands commit 91359bed48bc006a4319da86eb26db3b2e6d4afb (Clean up Test's resourcePath code." BUG=None TEST=make dm && out/Debug/dm R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/321723002
* Gamma correction for distance field text.Gravatar jvanverth2014-06-09
| | | | | | | | | | | Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance. BUG=skia: R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/258883002
* Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.Gravatar egdaniel2014-06-09
| | | | | | | | | BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/311373003
* Generate path names on the client sideGravatar cdalton2014-06-09
| | | | | | | | | | | | | | Pre-allocates a range of path names and manages allocations within that range on the client side. This allows us to generate new path objects in a feed-forward manner that doesn't require round trips to the GL server. BUG=skia: R=bsalomon@google.com, markkilgard@gmail.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/304403003
* New etcbitmap baselinesGravatar krajcevski2014-06-09
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/325783003
* Make sure to copy the LATC alias when copying the GrGLCapsGravatar krajcevski2014-06-09
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/320273003
* Add LATC to alpha only pixel configGravatar krajcevski2014-06-09
| | | | | | | | R=robertphillips@google.com, bsalomon@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/323853003
* bench_record: No need for --flags if there are no RecordingFlags anymore.Gravatar mtklein2014-06-09
| | | | | | | | | BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/327533002
* Add some comments to GrRectanizer_skylineGravatar robertphillips2014-06-09
| | | | | | | | R=jvanverth@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/324693002
* Add dump() to SkClipStack to help with debugging.Gravatar bsalomon2014-06-09
| | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/311263015
* Fix Chrome build after 9f1c241e (https://codereview.chromium.org/316143003/)Gravatar robertphillips2014-06-09
| | | | | | | | | | | | Remove SkPicture::kUsePathBoundsForClip_RecordingFlag (https://codereview.chromium.org/316143003/) removed an SkPicture flag on which Chromium still relies. R=scroggo@google.com TBR=scroggo@google.com NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/325723002
* remove GM result-grooming tools that use skia-autogenGravatar epoger2014-06-09
| | | | | | | | | BUG=skia:553 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/320443002
* Remove SkPicture::kUsePathBoundsForClip_RecordingFlagGravatar robertphillips2014-06-09
| | | | | | | | | | The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer? R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316143003
* Chromium should no longer need the legacy SkCanvas::drawPicture interfaceGravatar robertphillips2014-06-08
| | | | | | | | | | | | | | | | With: Switch Blink to using new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/316863003/ Switch Chromium to new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/315963003/ Chromium/Blink should no longer need this flag. Note: this patch cannot be landed until the Blink change rolls into Chromium. R=jvanverth@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/317193002
* No longer limit SkPictureRecorder::partialReplay to AndroidGravatar robertphillips2014-06-08
| | | | | | | | | | Toggling this for local testing is a bit of a chore. R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316173004
* Revert of Clean up Test's resourcePath code. ↵Gravatar mtklein2014-06-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/319473003/) Reason for revert: Some benchmarks are written in a way that makes this change unsafe (e.g. const char* resPath = GetResourcePath().c_str(); in SkipZeroesBench) and Valgrind and ASAN caught that. We can try again after a more careful cleanup of GetResourcePath(). Original issue's description: > Clean up resourcePath code. > > 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test. > 2) Make gResourcePath a static pointer to const char and move it inside the classes. > > BUG=None > TEST=make tests && out/Debug/tests > make gm && out/Debug/gm > make bench && out/Debug/bench > R=mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/52e4f413ffe2d281f9e90ff2147db08083ffcba7 R=tfarina@chromium.org TBR=tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Author: mtklein@google.com Review URL: https://codereview.chromium.org/320733002
* First pass at splitting out SkPictureRecord from SkPictureGravatar robertphillips2014-06-08
| | | | | | | | | | | | This patch begins the process of splitting apart SkPicture, SkPicturePlayback and SkPictureRecord. This is still a bit messy. In a follow up CL I hope to delay the creation of SkPictureRecorder's SkPicture until endRecording time. R=reed@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/318763004
* Clean up resourcePath code.Gravatar tfarina2014-06-07
| | | | | | | | | | | | | | | | 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test. 2) Make gResourcePath a static pointer to const char and move it inside the classes. BUG=None TEST=make tests && out/Debug/tests make gm && out/Debug/gm make bench && out/Debug/bench R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/319473003
* whitespace to trigger buildsGravatar mtklein2014-06-07
| | | | | | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/5037fceeab7d29b99a6497bcdf1c97f03e532956 R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/314313004
* whitespace to trigger buildsGravatar mtklein2014-06-07
| | | | | | | | | BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/314313004
* Clean up Skia for Clang's -Wtautological-undefined-compareGravatar Mike Klein2014-06-07
| | | | | | | | This is blocking Chrome from rolling a new Clang, and me too for our TSAN bots. BUG=chromium:381910 Review URL: https://codereview.chromium.org/325603002
* use __atomics in SkBarriers_tsan.hGravatar mtklein2014-06-06
| | | | | | | | | | | | I am having a hard time getting TSAN's own atomic hooks to work on our bots, but __atomic_foo work fine and are understood just fine by TSAN. BUG=skia: R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/320063003
* MIPS: modified gypi files to support buildGravatar djordje.pesut2014-06-06
| | | | | | | | R=teodora.petrovic@gmail.com, djsollen@google.com Author: djordje.pesut@imgtec.com Review URL: https://codereview.chromium.org/304903003
* Rollback of fe689c46 and all subsequent changesGravatar jvanverth2014-06-06
| | | | | | | | | | | | BUG=skia: R=humper@google.com TBR=humper@google.com NOTRY=True NOTREECHECKS=True Author: jvanverth@google.com Review URL: https://codereview.chromium.org/324463005
* remove extra debug printsGravatar humper2014-06-06
| | | | | | | | | | | BUG=skia: TBR=jvanverth NOTRY=True NOTREECHECKS=True Author: humper@google.com Review URL: https://codereview.chromium.org/314423002
* fix 10.6 shader testsGravatar humper2014-06-06
| | | | | | | | | | | BUG=skia: TBR=jvanverth NOTRY=True NOTREECHECKS=True Author: humper@google.com Review URL: https://codereview.chromium.org/324543002
* repair math error introduced by windows build fixGravatar humper2014-06-06
| | | | | | | | | | | BUG=skia: TBR=jvanverth NOTRY=True NOTREECHECKS=True Author: humper@google.com Review URL: https://codereview.chromium.org/320593003
* Disable bigblurs GM (for fe689c46a76)Gravatar jvanverth2014-06-06
| | | | | | | | | | | | BUG=skia: R=humper@google.com TBR=humper@google.com NOTRY=True NOTREECHECKS=True Author: jvanverth@google.com Review URL: https://codereview.chromium.org/325453002
* one channel texture fix for blur shaderGravatar humper2014-06-06
| | | | | | | | | | | | BUG=skia: R=bsalomon@google.com TBR=bsalomon NOTRY=True NOTREECHECKS=True Author: humper@google.com Review URL: https://codereview.chromium.org/319543007
* disable GPU/CPU blur match test (possibly temporary)Gravatar humper2014-06-06
| | | | | | | | | | | BUG=skia: TBR=jvanverth NOTRY=True NOTREECHECKS=True Author: humper@google.com Review URL: https://codereview.chromium.org/322593002
* fix blur testGravatar humper2014-06-06
| | | | | | | | | | | BUG=skia: TBR=jvanverth NOTRY=True NOTREECHECKS=True Author: humper@google.com Review URL: https://codereview.chromium.org/323583002
* Revert of Revert of another GM to ignore for blur rebaseline ↵Gravatar humper2014-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/319943004/) Reason for revert: Hopefully working now Original issue's description: > Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/319203002/) > > Reason for revert: > Follow-on to fe689c46a76, which needs to be reverted due to bot failures. > > Original issue's description: > > another GM to ignore for blur rebaseline > > > > BUG=skia: > > TBR=jvanverth > > NOTRY=True > > NOTREECHECKS=True > > > > Committed: https://skia.googlesource.com/skia/+/f131055929afb9c9671aee3e575c380d48c5ee4d > > TBR=humper@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/f255de0fe160e33b340301859be1d9374c5607fe R=jvanverth@google.com TBR=jvanverth@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: humper@google.com Review URL: https://codereview.chromium.org/324453004
* Revert of another GM to ignore for blur rebaseline ↵Gravatar jvanverth2014-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/319203002/) Reason for revert: Follow-on to fe689c46a76, which needs to be reverted due to bot failures. Original issue's description: > another GM to ignore for blur rebaseline > > BUG=skia: > TBR=jvanverth > NOTRY=True > NOTREECHECKS=True > > Committed: https://skia.googlesource.com/skia/+/f131055929afb9c9671aee3e575c380d48c5ee4d R=humper@google.com TBR=humper@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: jvanverth@google.com Review URL: https://codereview.chromium.org/319943004
* another GM to ignore for blur rebaselineGravatar humper2014-06-06
| | | | | | | | | | | BUG=skia: TBR=jvanverth NOTRY=True NOTREECHECKS=True Author: humper@google.com Review URL: https://codereview.chromium.org/319203002
* Faster GPU rect blur that doesn't require computing vertical and horizontalGravatar humper2014-06-06
| | | | | | | | | | | | scanlines on the CPU first. Should make extremely large drop shadows fast again. BUG=skia: R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/316273004
* DM: SKP source / PDF backendGravatar mtklein2014-06-06
| | | | | | | | | | | | | Removed expectations code for PDF backend for now, given that we don't have any, and refactored a little to make that cleaner. We can now test .skp -> .pdf -> .png in DM. Neat eh? BUG=skia:2598 R=halcanary@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/316643003
* remove SK_SUPPORT_LEGACY_SETCONFIG_INFO and ↵Gravatar reed2014-06-06
| | | | | | | | | | | SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS from chrome TBR= NOTRY=True Author: reed@google.com Review URL: https://codereview.chromium.org/320583003
* ARM Skia NEON patches - 39 - arm64 565 blittersGravatar kevin.petit2014-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This enables all 565 blitters except S32A_D565_Opaque. Here are some performance results: S32_D565_Opaque: ================ +-------+------------+------------+ | count | Cortex-A53 | Cortex-A57 | +-------+------------+------------+ | 1 | -18.37% | -13.04% | +-------+------------+------------+ | 2 | -9.90% | -13.78% | +-------+------------+------------+ | 4 | -8.28% | -6.77% | +-------+------------+------------+ | 8 | 157.63% | 78.15% | +-------+------------+------------+ | 16 | 72.67% | 44.81% | +-------+------------+------------+ | 64 | 76.78% | 40.89% | +-------+------------+------------+ | 256 | 73.85% | 36.05% | +-------+------------+------------+ | 1024 | 75.73% | 36.70% | +-------+------------+------------+ S32_D565_Blend: =============== +-------+------------+------------+ | count | Cortex-A53 | Cortex-A57 | +-------+------------+------------+ | 1 | -9.99% | -13.79% | +-------+------------+------------+ | 2 | -9.17% | -6.74% | +-------+------------+------------+ | 4 | -6.73% | -4.42% | +-------+------------+------------+ | 8 | 163.31% | 112.82% | +-------+------------+------------+ | 16 | 55.21% | 44.68% | +-------+------------+------------+ | 64 | 54.09% | 41.99% | +-------+------------+------------+ | 256 | 52.63% | 40.64% | +-------+------------+------------+ | 1024 | 52.46% | 40.45% | +-------+------------+------------+ S32A_D565_Blend: ================ +-------+------------+------------+ | count | Cortex-A53 | Cortex-A57 | +-------+------------+------------+ | 1 | -5.88% | -6.06% | +-------+------------+------------+ | 2 | -4.74% | -0.01% | +-------+------------+------------+ | 4 | -5.42% | -3.03% | +-------+------------+------------+ | 8 | 78.78% | 77.96% | +-------+------------+------------+ | 16 | 98.19% | 79.61% | +-------+------------+------------+ | 64 | 111.56% | 72.60% | +-------+------------+------------+ | 256 | 113.80% | 69.96% | +-------+------------+------------+ | 1024 | 114.42% | 70.85% | +-------+------------+------------+ S32_D565_Opaque_Dither: ======================= +-------+------------+------------+ | count | Cortex-A53 | Cortex-A57 | +-------+------------+------------+ | 1 | -4.18% | -0.93% | +-------+------------+------------+ | 2 | -2.43% | -2.04% | +-------+------------+------------+ | 4 | -1.09% | -1.23% | +-------+------------+------------+ | 8 | 184.89% | 136.53% | +-------+------------+------------+ | 16 | 128.64% | 89.11% | +-------+------------+------------+ | 64 | 132.68% | 100.98% | +-------+------------+------------+ | 256 | 157.02% | 100.86% | +-------+------------+------------+ | 1024 | 163.85% | 103.62% | +-------+------------+------------+ S32_D565_Blend_Dither: ====================== +-------+------------+------------+ | count | Cortex-A53 | Cortex-A57 | +-------+------------+------------+ | 1 | -4.87% | 0.01% | +-------+------------+------------+ | 2 | -2.71% | 2.97% | +-------+------------+------------+ | 4 | -2.20% | 0.28% | +-------+------------+------------+ | 8 | 149.76% | 146.80% | +-------+------------+------------+ | 16 | 85.69% | 95.77% | +-------+------------+------------+ | 64 | 88.81% | 101.39% | +-------+------------+------------+ | 256 | 97.32% | 107.22% | +-------+------------+------------+ | 1024 | 98.08% | 115.71% | +-------+------------+------------+ S32A_D565_Opaque_Dither: ======================== +-------+------------+------------+ | count | Cortex-A53 | Cortex-A57 | +-------+------------+------------+ | 1 | -1.86% | 0.02% | +-------+------------+------------+ | 2 | -0.58% | -1.52% | +-------+------------+------------+ | 4 | -0.75% | 1.16% | +-------+------------+------------+ | 8 | 240.74% | 155.16% | +-------+------------+------------+ | 16 | 181.97% | 132.15% | +-------+------------+------------+ | 64 | 203.11% | 136.48% | +-------+------------+------------+ | 256 | 223.45% | 133.05% | +-------+------------+------------+ | 1024 | 225.96% | 134.05% | +-------+------------+------------+ Signed-off-by: Kévin PETIT <kevin.petit@arm.com> BUG=skia: R=djsollen@google.com, mtklein@google.com Author: kevin.petit@arm.com Review URL: https://codereview.chromium.org/317193003
* Effectively unlimited linking.Gravatar mtklein2014-06-06
| | | | | | | | | | | | Ninja will still cap concurrency with it's default value (from -j), so we just need a big number equal or greater than the number of cores in any machine. BUG=skia: R=borenet@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/319153002
* Revert of Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct ↵Gravatar egdaniel2014-06-06
| | | | | | | | | | | | | | | | | | | | | | | | bounds. (https://codereview.chromium.org/311373003/) Reason for revert: changed assert is failing Original issue's description: > Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/be4fd4f7349b97a7c34a4177ec26d8aea9616628 R=bsalomon@google.com TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: egdaniel@google.com Review URL: https://codereview.chromium.org/320573002
* Pull in GYP_LINK_CONCURRENCY=N support.Gravatar mtklein2014-06-06
| | | | | | | | | BUG=skia: R=borenet@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/315183003
* Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.Gravatar egdaniel2014-06-06
| | | | | | | | | BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/311373003
* Fixing another clusterfuzz issueGravatar sugoi2014-06-06
| | | | | | | | | | | | | | | This was introduced by removing SkValidatingReadBuffer::readBitmap in https://codereview.chromium.org/295793002/ Since SkReadBuffer::skip wasn't virtual, it was using the unsafe SkReadBuffer::skip within SkReadBuffer::readBitmap rather than using SkValidatingReadBuffer::skip. I also removed direct uses of fReader within SkReadBuffer::readBitmap so that it can use the virtual readInt / readFixed functions that have a version in SkValidatingReadBuffer. Also, I changed SkReadBuffer::readPoint so that it uses the virtual readScalar, that way, it becomes redundant with SkValidatingReadBuffer::readPoint, which can then be removed. BUG=380723 R=reed@google.com, mtklein@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/317003003
* Fix android_run_skia script running with command line optionsGravatar qiankun.miao2014-06-06
| | | | | | | | | | | | This script cannot recognize command line options when running bench: e.g. android_run_skia bench --config 8888. BUG=skia: R=mtklein@google.com, djsollen@google.com Author: qiankun.miao@intel.com Review URL: https://codereview.chromium.org/314903003
* Remove GrIsPow2 in favor of SkIsPow2.Gravatar tfarina2014-06-06
| | | | | | | | | | | | | Looks like there is no good reason to have two copies of this function doing the same thing with different name. BUG=None TEST=make tests R=bsalomon@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/318873002
* Add metrics reporting to SkFiddle.Gravatar jcgregorio2014-06-06
| | | | | | | | | | | Also update the headers for template.cpp while we're here. BUG=skia: R=mtklein@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/312373002
* Whitespace change to test new CQ trybotsGravatar rmistry2014-06-06
| | | | | | | | | | | BUG=skia:2203 TBR= (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/319123002
* Adding kernel offset validationGravatar sugoi2014-06-06
| | | | | | | | | | | Fixing bug found by clusterfuzz in SkMatrixConvolutionImageFilter. BUG=381244 R=senorblanco@google.com, senorblanco@chromium.org, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/319003002
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-02 02:55:04 +0000