aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Replace nearly all kRespect with kIgnoreGravatar Brian Osman2018-07-12
| | | | | | | | | | | | | | | | | | | | | | | | | | - Encoders and decoders always assume kIgnore. - They are less opinionated about F16 and color space, we just trust the color space that's passed in, and put that directly in the image (no sRGB encoding). - SkBitmap and SkPixmap read/write pixels functions were defaulting to kResepct, those are now always kIgnore. - Many other bits of plumbing are simplified, and I added a default of kIgnore to SkImage::makeColorSpace, so we can phase out that argument entirely. - Still need to add defaults to other public APIs that take SkTransferFunctionBehavior. - This makes gold think that we've dramatically changed the contents of all F16 images, but that's because it doesn't understand the (now linear) color space that's embedded. Once we triage them all once, they will work fine (and they'll look perfect in the browser). Bug: skia: Change-Id: I62fa090f96cae1b67d181ce14bd91f34ff2ed747 Reviewed-on: https://skia-review.googlesource.com/140570 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Drawing point cloud + planes on CanvasGravatar ziadb2018-07-12
| | | | | | | | | Java-only version of SkAR: drawing on android Canvas Bug: skia: Change-Id: I76285aa85c7523ad9ae213d32a159b671d8aa30f Reviewed-on: https://skia-review.googlesource.com/141048 Reviewed-by: Mike Reed <reed@google.com>
* Disable GPU clip masksGravatar Chris Dalton2018-07-12
| | | | | | | | | Bug: skia: Change-Id: I3abacfd17ea6247d0bdb2ab8a2584a88bf468dad Reviewed-on: https://skia-review.googlesource.com/140776 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Use simple buffers instead of vectorsGravatar Herb Derby2018-07-12
| | | | | | | | | | Start using simple buffers, these will be used for multiple runs latter on. Change-Id: Iab0559d5a47eb5e54254a985051d5d25a91be69f Reviewed-on: https://skia-review.googlesource.com/140791 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* update SkToSRGBColorFilter color managementGravatar Mike Klein2018-07-12
| | | | | | | Change-Id: Ia4a8bbc9d983bb5cfa02ba62c922efa1fa879d9b Reviewed-on: https://skia-review.googlesource.com/141054 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* update SkColor4f::FromColor() to preserve transfer functionGravatar Mike Klein2018-07-12
| | | | | | | | | | | | This kills off some sRGB tables, and lots of call sites can now use SkColor4f::FromColor(). It doesn't seem important to keep this test. Change-Id: Ia79ec8ace45e80bbc7a1e33f560f59289e61b2fb Reviewed-on: https://skia-review.googlesource.com/141046 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Add check before freeing op in GrTextureOpListGravatar Robert Phillips2018-07-12
| | | | | | | | | This now matches the behavior of the GrRenderTargetOpList and is probably behind all the TSAN complaints. Change-Id: I9a1cc65a893c20e9927d21814227673167f2f675 Reviewed-on: https://skia-review.googlesource.com/141047 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* SkArCamera* filesGravatar ziadb2018-07-12
| | | | | | | | Bug: skia: Change-Id: I711143c53bf66ebc8130b2401738da3cde644fbe Reviewed-on: https://skia-review.googlesource.com/140560 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add SkTypeface::getVariationDesignParametersGravatar Ben Wagner2018-07-12
| | | | | | | | | This adds a way for users to query the axis parameters for a typeface. Change-Id: Idc2ac0d84bc7ae2ca484ae410cba5b01883418e5 Reviewed-on: https://skia-review.googlesource.com/137706 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com>
* clean up some old busted color routinesGravatar Mike Klein2018-07-12
| | | | | | | | Change-Id: I6e1dcce0b1fd7e4a01dc44c07173e9742922d2c0 Reviewed-on: https://skia-review.googlesource.com/141044 Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* update color management for color shadersGravatar Mike Klein2018-07-12
| | | | | | | | | Change-Id: I4d85ad9d02576dbdb9c50f38418b5e96ba6d4164 Reviewed-on: https://skia-review.googlesource.com/141042 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Update SRGBReadWritePixelsTest again, to only test opaque colorsGravatar Brian Osman2018-07-12
| | | | | | | | | | | | | | | | With our new world (never doing linear blending), the read-back conversion from premul sRGB to premul linear no longer produces the same answer. By always using opaque pixels, the existing check functions in this test can continue to verify that the sRGB <-> linear conversion is happening correctly during read/write, independent of any color space transformation (which is now altering the outcome). Bug: skia: Change-Id: Id8e28b3bc4b9674043bd870a39d229207ccdc6d7 Reviewed-on: https://skia-review.googlesource.com/140987 Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* PathKit/WASM tweaksGravatar Florin Malita2018-07-12
| | | | | | | | | | | | | | | | | | The most interesting part is using variadic calls to push all verb data in one native -> JS go. This speeds up SkPathToVerbsArgsArray and SkPathToCmdArray by 30-35%. Other misc changes: * use SkPath::RawIter instead of Iter * add a VisitPath helper to cut down on boiler plate * use uintptr_t for pointer arguments (just in case we get to wasm64 some day) Change-Id: Ia0240f0e00e81db78eb1e9b48b31abbb3e33bfaf Reviewed-on: https://skia-review.googlesource.com/140984 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* update mode color filter color managementGravatar Mike Klein2018-07-12
| | | | | | | | Change-Id: I2f371e279f45086ae8885c7206fefff3fbc8c941 Reviewed-on: https://skia-review.googlesource.com/140985 Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove unused parts of SkModeColorFilterGravatar Mike Klein2018-07-12
| | | | | | | | | Change-Id: Iaa2d1087b3211ec427d8260fb6d7f80a87c5f480 Reviewed-on: https://skia-review.googlesource.com/140983 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Java-only version of SkAR: drawing on android CanvasGravatar ziadb2018-07-12
| | | | | | | Bug: skia: Change-Id: I3b85fac93a2854d1575f71554e2a7da66e8a6a6f Reviewed-on: https://skia-review.googlesource.com/138920 Reviewed-by: Mike Reed <reed@google.com>
* Remove SK_LEGACY_GPU_PIXEL_OPS testsGravatar Brian Osman2018-07-12
| | | | | | | | | | Bug: skia: Change-Id: I12ba9199845a43c8e070454093b744eed272a548 Reviewed-on: https://skia-review.googlesource.com/140981 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Generate GrVkInterface when we make the GrVkGpu.Gravatar Greg Daniel2018-07-12
| | | | | | | | | | | | | | Also add a GetProc function to the GrVkBackendContext which will be used to create the GrVkInterface. This change (and updating clients to use it), will allow us to move GrVkInterface out of public which is needed to fix vulkan header issues. Bug: skia: Change-Id: Id8067943ae27cec8cad29fd31b05f0b8387412d4 Reviewed-on: https://skia-review.googlesource.com/140783 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* remove unneeded scale from procsGravatar Mike Reed2018-07-12
| | | | | | | | Bug: skia: Change-Id: I85adbbaf0e9d7d23c3f07490a1d323c87e8aa4da Reviewed-on: https://skia-review.googlesource.com/140980 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
* In RGBA444TextureTest, use valid premul colorsGravatar Brian Osman2018-07-12
| | | | | | | | | | | | | | | In both the 565 and 4444 tests, we use a repeating pattern of two 16-bit values. Neither of these were valid premul colors in 4444, and the first one (FF00) had zero alpha. With upcoming changes to format conversion, that may need to be unpremul'd and premul'd during readPixels, causing this test to fail. Change-Id: Idbf0f8162d6f68ca2b70ede8c48f788f4379d414 Reviewed-on: https://skia-review.googlesource.com/140799 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Roll Chromium manually to last successful CommandBuffer runGravatar Eric Boren2018-07-12
| | | | | | | | Bug: skia: Change-Id: I93b224dcc2a94f4f04f7a6442d91f80714b828e4 Reviewed-on: https://skia-review.googlesource.com/140575 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* fix color management of CPU drawVertices()Gravatar Mike Klein2018-07-12
| | | | | | | | | Convert to dst, not linear dst. Change-Id: I2e2701cd08180c3e82730cd4d71a80342f40ab07 Reviewed-on: https://skia-review.googlesource.com/140789 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* remove more references to draw filterGravatar Cary Clark2018-07-12
| | | | | | | | | | | TBR=bungeman@google.com NOTRY=true Docs-Preview: https://skia.org/?cl=140798 Bug: skia:6818 Change-Id: Ia741238f65b55cf20b6f4a813a573e84d29a2dfd Reviewed-on: https://skia-review.googlesource.com/140798 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* remove debug gl interface, grcontextfactory context type, and config.Gravatar Brian Salomon2018-07-12
| | | | | | | | Change-Id: I476d1066a227d70e39c1dd49220972fb4a075393 Reviewed-on: https://skia-review.googlesource.com/140788 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Upgrade Skolo Mac bots to 10.13.6.Gravatar Ben Wagner2018-07-12
| | | | | | | | | No-Try: true Change-Id: Ie48e4bd1bc52180ee58327ff1c7e6d7221ef7286 Reviewed-on: https://skia-review.googlesource.com/140347 Commit-Queue: Joe Gregorio <jcgregorio@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com>
* Roll third_party/externals/angle2 5598148b7613..c9c259cccb2e (1 commits)Gravatar angle-skia-autoroll2018-07-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5598148b7613..c9c259cccb2e git log 5598148b7613..c9c259cccb2e --date=short --no-merges --format='%ad %ae %s' 2018-07-12 oetuaho@nvidia.com Add a shared traverse() function for most node types Created with: gclient setdep -r third_party/externals/angle2@c9c259cccb2e The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=robertphillips@google.com Change-Id: Id712537bf6a2eeb724dae8fb8052355e66a97fbe Reviewed-on: https://skia-review.googlesource.com/140920 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-12
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/2b138f742b74a9f8a81f7b0bdd3768019f01854c Avoid creating an empty netrc file in $TEMP (sdefresne@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idfe8937271a34dbca3a031aa6cecd6863372b09f Reviewed-on: https://skia-review.googlesource.com/140796 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Update markdown filesGravatar skia-bookmaker2018-07-12
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I6b5eaa27ead847abd34ab4d4cf68731bd86c5d1e Reviewed-on: https://skia-review.googlesource.com/140827 Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* Use new SkGlyphIDSet - v3Gravatar Herb Derby2018-07-12
| | | | | | | | | | | | | v1 - had problems with msan and unintialized glyphs. v2 - had problems with typefaces with no glyphs in them This adds a check to make sure there are glyphs in the font when going to uniquify. Change-Id: Id27fa4578be33da1e468b4652db19740ddcadfc6 Reviewed-on: https://skia-review.googlesource.com/140785 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Remove SkDrawFilter.Gravatar Ben Wagner2018-07-12
| | | | | | | | | Change-Id: I0204a9522e828c87bb7c6c20ae34ce51161442af Reviewed-on: https://skia-review.googlesource.com/137895 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Roll third_party/externals/angle2 5c8113d3c20f..5598148b7613 (8 commits)Gravatar angle-skia-autoroll2018-07-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5c8113d3c20f..5598148b7613 git log 5c8113d3c20f..5598148b7613 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 jmadill@chromium.org Vulkan: Don't use gl::ErrorOrResult. 2018-07-11 jmadill@chromium.org Vulkan: Clean up Error usage. 2018-07-11 jmadill@chromium.org Vulkan: Move Feature init before device creation. 2018-07-11 jmadill@chromium.org Generalize Context scratch buffer errors. 2018-07-11 jmadill@chromium.org Refactor internal format pixel math methods. 2018-07-11 geofflang@chromium.org EGL: Fix binding EGL_NO_SURFACE without surfaceless support. 2018-07-11 jmadill@chromium.org Vulkan: Remove vk::ErrorOrResult. 2018-07-11 jmadill@chromium.org Vulkan: Implement sampler structs as function args. Created with: gclient setdep -r third_party/externals/angle2@5598148b7613 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=robertphillips@google.com Change-Id: Ia17bc8b2c2ff0299d480f6df9d217a71bec506ff Reviewed-on: https://skia-review.googlesource.com/140759 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-12
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/32e3d1e37cd6a379cc5767dc3aaa43053df9a151 Add a library for monitoring. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I64e1c13526db1d02effdb594f77bc74a3c5a0a01 Reviewed-on: https://skia-review.googlesource.com/140794 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Revert "build debug on linux for gdb"Gravatar Robert Phillips2018-07-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3c3db72e69ef5dcdde57f1fbbd939579d50d96f1. Reason for revert: I suspect this is breaking the Build-Debian9-Clang-arm-Debug-Chromebook_GLES bot Original change's description: > build debug on linux for gdb > > Building with this define enables additional > checks for standard library functions when > running gdb, and allows printing std::string. > > R=​halcanary@google.com > > Bug: skia: > Change-Id: Ib71c179d8cbacbcd7f17a1c85f912072918e6be8 > Reviewed-on: https://skia-review.googlesource.com/140786 > Commit-Queue: Cary Clark <caryclark@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,halcanary@google.com,caryclark@google.com Change-Id: I56ae1c6c02032e6445f5585de51c48423d283636 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/140840 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-12
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/d64781e17af7bc40cf5a3ac9321c48907a02c219 gclient_scm: Fetch refs/changes/* when syncing. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I03a401e6c11bfc4a77cf636d8207d138bdaa7aea Reviewed-on: https://skia-review.googlesource.com/140792 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* build debug on linux for gdbGravatar Cary Clark2018-07-12
| | | | | | | | | | | | | | Building with this define enables additional checks for standard library functions when running gdb, and allows printing std::string. R=halcanary@google.com Bug: skia: Change-Id: Ib71c179d8cbacbcd7f17a1c85f912072918e6be8 Reviewed-on: https://skia-review.googlesource.com/140786 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Update Win10 in Skolo.Gravatar Ben Wagner2018-07-12
| | | | | | | | | No-Try: true Change-Id: Ic939bc0b2b18d00c29b753fe7626951c3930e211 Reviewed-on: https://skia-review.googlesource.com/140790 Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* fix color management in sprite blitterGravatar Mike Klein2018-07-11
| | | | | | | | | | | Basically exactly the same as the SkImageShader CL. 441 diffs -> 360 diffs Change-Id: Ib0d5498d0a286a879ba39bdc28979b20881f4acb Reviewed-on: https://skia-review.googlesource.com/140573 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Publish docs for rrect, picture, blendmodeGravatar Cary Clark2018-07-11
| | | | | | | | | | | | | | | | Complete basic docs for SkRRect, SkPicture, SkBlendMode. Add a new rule that checks the main description tense. Check for spelling errors. R=caryclark@google.com Docs-Preview: https://skia.org/?cl=138542 Bug: skia:6898 Change-Id: Iba547873775a89f1d652be9b0219b84ffa8d0628 Reviewed-on: https://skia-review.googlesource.com/138542 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org>
* Make CR and trailing whitespace errors.Gravatar Ben Wagner2018-07-11
| | | | | | | | | | | | | The canned CR and trailing whitespace presubmit checks only emit warnings, so no one pays any attention to them and they don't fail the build. All trailing whitespace was removed recently, and it has already returned. This makes these checks actual errors so they will fail the presubmit check on the bots, so that they will actually be seen. Change-Id: I5d774ae45a68b8eb881548d0158c37a8f5fe052e Reviewed-on: https://skia-review.googlesource.com/59164 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Reland "Make GPU cache invalidation SkMessageBus messages go to one GrContext."Gravatar Brian Salomon2018-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of f4c5bb9aba485aa47c27b15905d81992b7cf4707 Original change's description: > Make GPU cache invalidation SkMessageBus messages go to one GrContext. > > Makes it so the template param to SkMessageBus must implement: > bool shouldSend(uint32_t inboxID) const > > Updates all GPU backend message types to only go to the GrContext that > is adding a cache entry. > > Bug: skia: > Change-Id: I3e8a4eb90654b7b8ac57cac9fb508c0ef1d51058 > Reviewed-on: https://skia-review.googlesource.com/140220 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Reviewed-by: Jim Van Verth <jvanverth@google.com> Bug: skia: Change-Id: I8402bfe3ed0170c99936d47050458817030b473b Reviewed-on: https://skia-review.googlesource.com/140801 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove interal use of SkRefCnt_SafeAssign.Gravatar Ben Wagner2018-07-11
| | | | | | | | | | | | It turns out that SkDeviceProfile is no longer used and can just be deleted. The ResourceCacheTest and DebugGLTestContext are changed to use smart pointers where possible. This also clarifies the squirrelly part of the test. DebugGLTestContext is going away soon anyway. Change-Id: I95ef24afa58aa4d356429b93d4dec0d72e3fd827 Reviewed-on: https://skia-review.googlesource.com/140577 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* collapse parametric_{r,g,b} into parametric, remove _a and gamma_dstGravatar Mike Klein2018-07-11
| | | | | | | | | | | | | parametric_a and gamma_dst were unused outside of unit tests. In all other cases, we always use parametric_{r,g,b} together and always pass them the same argument. So we can collapse them into a single stage like gamma and to/from_srgb. Change-Id: I08cea896c7744f97b4f4bf9e029f5d643e45e177 Reviewed-on: https://skia-review.googlesource.com/140576 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Revert "Use new SkGlyphIDSet - v2"Gravatar Herb Derby2018-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0421083a447a8ab105d20c786f7d8377f30a6d5d. Reason for revert: fushia page fault Original change's description: > Use new SkGlyphIDSet - v2 > > Add bzero to make msan and valgrind happy. > > Change-Id: I9b4e2f2b8e690da4b4b920fef27d5a8854092219 > Reviewed-on: https://skia-review.googlesource.com/140563 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Herb Derby <herb@google.com> TBR=mtklein@google.com,herb@google.com Change-Id: I4e5e16644cbf56b5ff0b21afd6f3962e3976a1da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/140803 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add gltestpersistentcache config that tests GrContextOption's cache.Gravatar Brian Salomon2018-07-11
| | | | | | | | | | | Uses a new GPU sink that runs each test twice, once to populate the cache and then again with a new GrContext but a warmed cache. It verifies that the two generated images are the same. Change-Id: Iaba195a69751f14ea946afe7174228a813b83a63 Reviewed-on: https://skia-review.googlesource.com/140567 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Revert "Use simple buffers instead of vectors"Gravatar Herb Derby2018-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit b188da121c1575caa6b0b9755e3f80a6b5e44611. Reason for revert: Patch on a rollback Original change's description: > Use simple buffers instead of vectors > > Start using simple buffers, these will be used for > multiple runs latter on. > > Change-Id: I8dadbed036b7a60d708c49b84bb5e3bb3710f704 > Reviewed-on: https://skia-review.googlesource.com/140578 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Herb Derby <herb@google.com> TBR=mtklein@google.com,herb@google.com Change-Id: I51d9ad9bc0fd7efb93e5db4dc504d8dc31e7cfb4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/140802 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Revert "Make GPU cache invalidation SkMessageBus messages go to one GrContext."Gravatar Brian Salomon2018-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f4c5bb9aba485aa47c27b15905d81992b7cf4707. Reason for revert: Accidentally submitted without CQ Original change's description: > Make GPU cache invalidation SkMessageBus messages go to one GrContext. > > Makes it so the template param to SkMessageBus must implement: > bool shouldSend(uint32_t inboxID) const > > Updates all GPU backend message types to only go to the GrContext that > is adding a cache entry. > > Bug: skia: > Change-Id: I3e8a4eb90654b7b8ac57cac9fb508c0ef1d51058 > Reviewed-on: https://skia-review.googlesource.com/140220 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Reviewed-by: Jim Van Verth <jvanverth@google.com> TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: Iadb667d8027341703d254325320ddaa528fb33a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/140800 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Make GPU cache invalidation SkMessageBus messages go to one GrContext.Gravatar Brian Salomon2018-07-11
| | | | | | | | | | | | | | Makes it so the template param to SkMessageBus must implement: bool shouldSend(uint32_t inboxID) const Updates all GPU backend message types to only go to the GrContext that is adding a cache entry. Bug: skia: Change-Id: I3e8a4eb90654b7b8ac57cac9fb508c0ef1d51058 Reviewed-on: https://skia-review.googlesource.com/140220 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Use simple buffers instead of vectorsGravatar Herb Derby2018-07-11
| | | | | | | | | | Start using simple buffers, these will be used for multiple runs latter on. Change-Id: I8dadbed036b7a60d708c49b84bb5e3bb3710f704 Reviewed-on: https://skia-review.googlesource.com/140578 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Whitespace FixupGravatar Hal Canary2018-07-11
| | | | | | | | Change-Id: I6c4c4b43dfa6b59832c63f8fcf43192b4973d88b Reviewed-on: https://skia-review.googlesource.com/140565 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* also rm Perf-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-AllGravatar Mike Klein2018-07-11
| | | | | | | | | | | | | While we're on the topic of CPU bots whose performance I don't care much about, Perf-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-All is another. Once again, we've got Clang bots covering this configuration. Change-Id: Ia96f28f8adaf675ec7cf63320e001641054e23cb Reviewed-on: https://skia-review.googlesource.com/140574 Auto-Submit: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-22 14:13:41 +0000