aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix strange failures on Android NGravatar kjlubick2016-09-08
| | | | | | | | | | | We were seeing problems where dm ended with exit code 0, but the step still failed. It seems they changed what N returns when a thing completes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319843003 TBR=bugsbunny Review-Url: https://codereview.chromium.org/2319843003
* Benchmarks for testing changes to GrResourceCache replacement policy when ↵Gravatar bsalomon2016-09-08
| | | | | | | | over budget. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317263002 Review-Url: https://codereview.chromium.org/2317263002
* Checking for valid colorType, alphaType, colorSpace in SkCodecGravatar msarett2016-09-08
| | | | | | | | | | | | | | | | | * Refactor to share code between SkPngCodec and SkWebpCodec * Didn't end up sharing with SkJpegCodec but did refactor that code a bit * Disallow conversions to F16 with non-linear color spaces * Fail to decode if we fail to create a SkColorSpaceXform (should be an assert soon). We used to fallback on a legacy decode if we failed to create the transform. * A bunch of name changes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293003 Committed: https://skia.googlesource.com/skia/+/7a9900d6d34e437bb24beb5524a1f6488ae138c9 Review-Url: https://codereview.chromium.org/2319293003
* Move prepareForExternalIO implementation from GrContext to GrDrawingManagerGravatar bsalomon2016-09-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324473002 Review-Url: https://codereview.chromium.org/2324473002
* Apple devices do not support CRC32 instructions. Don't believe Clang's lies.Gravatar mtklein2016-09-08
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322033002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2322033002
* Revert of Checking for valid colorType, alphaType, colorSpace in SkCodec ↵Gravatar msarett2016-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:100001 of https://codereview.chromium.org/2319293003/ ) Reason for revert: Broken perf bots Original issue's description: > Checking for valid colorType, alphaType, colorSpace in SkCodec > > * Refactor to share code between SkPngCodec and SkWebpCodec > * Didn't end up sharing with SkJpegCodec but did refactor > that code a bit > * Disallow conversions to F16 with non-linear color spaces > * Fail to decode if we fail to create a SkColorSpaceXform > (should be an assert soon). We used to fallback on a > legacy decode if we failed to create the transform. > * A bunch of name changes > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293003 > > Committed: https://skia.googlesource.com/skia/+/7a9900d6d34e437bb24beb5524a1f6488ae138c9 TBR=scroggo@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2328663002
* Checking for valid colorType, alphaType, colorSpace in SkCodecGravatar msarett2016-09-08
| | | | | | | | | | | | | | | | * Refactor to share code between SkPngCodec and SkWebpCodec * Didn't end up sharing with SkJpegCodec but did refactor that code a bit * Disallow conversions to F16 with non-linear color spaces * Fail to decode if we fail to create a SkColorSpaceXform (should be an assert soon). We used to fallback on a legacy decode if we failed to create the transform. * A bunch of name changes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293003 Review-Url: https://codereview.chromium.org/2319293003
* Cache the inverse matrix on SkColorSpace. Rename xyz() to toXYZ().Gravatar brianosman2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323003002 Review-Url: https://codereview.chromium.org/2323003002
* GN: add a helper script for running Android buildsGravatar mtklein2016-09-08
| | | | | | | | | | | | Think of this as the spiritual equivalent of platform_tools/android/bin/android_run_skia, but for GN and easier to type. Cutting down the debug symbols makes Android builds about 1/4 the size. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323833002 DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2323833002 Review-Url: https://codereview.chromium.org/2323833002
* Push usage of GrColor4f into OverrideInputGravatar brianosman2016-09-08
| | | | | | | | | Just a change to preserve precision. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324553002 Review-Url: https://codereview.chromium.org/2324553002
* most is fine for *SAN bots nowGravatar mtklein2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326553002 Review-Url: https://codereview.chromium.org/2326553002
* removed const from ASTVarDeclaration::fName to avoid a Chromium build failureGravatar ethannicholas2016-09-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2325673002 Review-Url: https://codereview.chromium.org/2325673002
* Clean up target_os=llvm now that it does nothing.Gravatar mtklein2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317373004 Review-Url: https://codereview.chromium.org/2317373004
* Add GM/slide to simulate Android-style reveal clipGravatar robertphillips2016-09-08
| | | | | | | | | Hopefully, this will let us play w/ geometric and shader-based solutions. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003 Committed: https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0 Review-Url: https://codereview.chromium.org/2316593003
* Tests: DiscardableMemory test no longer relies on global stateGravatar halcanary2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323013002 Review-Url: https://codereview.chromium.org/2323013002
* SkLiteDL: drawAsLayer()Gravatar mtklein2016-09-08
| | | | | | | | | This more or less the API you were thinking? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2315283002 Review-Url: https://codereview.chromium.org/2315283002
* GN: add sanitize argGravatar mtklein2016-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Attempt to take over all *SAN builds. MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py. I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier to use locally. The compile steps should be much faster now. We no longer build CMake and Clang for every run, instead using the clang_linux CIPD package. This removes the need for all the third_party/externals/llvm/... dependencies. Similarly, since we're using the clang_linux package, we no longer depend on Chrome's Clang, and thus no longer need to sync chromium on these bots. Instead of packaging up MSAN libraries and llvm-symbolizer in the compile output, I have the test / perf bots also depend on the clang_linux package. These do not vary from build to build. No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja all track changes to xsan.blacklist without our help. This has the incidental effect of upgrading the compiler used by *SAN bots from Clang 3.8 to Clang 3.9. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002 Review-Url: https://codereview.chromium.org/2289343002
* Flesh out SkOpts namespaces.Gravatar mtklein2016-09-08
| | | | | | | | | | This makes it easier to see the baseline CPU feature settings for a build when looking at a stack trace or profile. This fills out all the features we currently might care about. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318313003 Review-Url: https://codereview.chromium.org/2318313003
* Asset management: Download from GS store instead of CIPDGravatar borenet2016-09-08
| | | | | | | | | This avoids strange CIPD symlink/permissions issues BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321623003 Review-Url: https://codereview.chromium.org/2321623003
* GN: do not set default GN argsGravatar mtklein2016-09-08
| | | | | | | | | | It's just visual noise... this should make future gn_flavor.py changes show fewer incidental diffs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324573002 Review-Url: https://codereview.chromium.org/2324573002
* Further increase run_benchmark timeoutGravatar Ravi Mistry2016-09-08
| | | | | | | | | | | | | | | Looks like the chromium page sets still hit the 10 min timeout. BUG=skia:5700 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342 # This code is not exercised by trybots. NOTRY=true Change-Id: I57aba4c1541a840d7e4e97112a6485abc20aa3c7 Reviewed-on: https://skia-review.googlesource.com/2342 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Add color xform support to SkWebpCodecGravatar msarett2016-09-08
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b Review-Url: https://codereview.chromium.org/2294993002
* Delete deprecated GammaNamedGravatar msarett2016-09-08
| | | | | | | | TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2320893002 Review-Url: https://codereview.chromium.org/2320893002
* GN: default to -O1Gravatar mtklein2016-09-07
| | | | | | | | | | | | | | | | | | | In a GN world we are no longer tied to the Debug/Release dichotomy of GYP, and extra_cflags makes it trivially easy to override any flags we set by default. These two together mean we don't have to make the default Debug build pointlessly unoptimized. -O1 takes negligibly longer to compile than -O0, doesn't make debugging difficult, and the code is considerably better. DM runs ~4x faster this way. Backstory: I just re-noticed we do this for our Debug MSAN builds, which has had a serious wall-time slimming effect. I was about to restore it to my GN MSAN builds when I realized, hey, maybe we should do this for all builds. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322753002 Review-Url: https://codereview.chromium.org/2322753002
* Rename SkColorSpace::GammaNamed to SkColorSpace::RenderTargetGammaGravatar msarett2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293002 Review-Url: https://codereview.chromium.org/2319293002
* Revert of Add color xform support to SkWebpCodec (patchset #2 id:80001 of ↵Gravatar msarett2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2294993002/ ) Reason for revert: Windows bots hate it when I upload new images. Original issue's description: > Add color xform support to SkWebpCodec > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 > > Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b TBR=scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2318253004
* Add color xform support to SkWebpCodecGravatar msarett2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 Review-Url: https://codereview.chromium.org/2294993002
* refactored SkSL VarDeclaration handlingGravatar ethannicholas2016-09-07
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2312233002 Review-Url: https://codereview.chromium.org/2312233002
* android_skp_capture.shGravatar halcanary2016-09-07
| | | | | | | | NOTRY=true TBR= GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324543002 Review-Url: https://codereview.chromium.org/2324543002
* clang_linux: also build an MSAN libc++Gravatar mtklein2016-09-07
| | | | | | | | | | This will be used by MSAN bots: build with -stdlib=libc++, then run with LD_LIBRARY_PATH=/path/to/clang_linux/msan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324503002 Review-Url: https://codereview.chromium.org/2324503002
* Delete SkColorSpace::gammaNamed() from public APIGravatar msarett2016-09-07
| | | | | | | | | Move fGammaNamed to SkColorSpace_Base. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003 Review-Url: https://codereview.chromium.org/2318663003
* Merge building of program desc in Vulkan into one stepGravatar egdaniel2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318143002 Review-Url: https://codereview.chromium.org/2318143002
* Revert of Add GM/slide to simulate Android-style reveal clip (patchset #6 ↵Gravatar robertphillips2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/2316593003/ ) Reason for revert: Shader compilation failure Original issue's description: > Add GM/slide to simulate Android-style reveal clip > > Hopefully, this will let us play w/ geometric and shader-based solutions. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003 > > Committed: https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0 TBR=jvanverth@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2316303002
* Add minimal support for readPixels in raster F16Gravatar brianosman2016-09-07
| | | | | | | | | | | Still doesn't support doing premul <-> unpremul conversions, but handles the simple cases (which would previously always fail). Fixes the new gamut gm (partially) in f16 config. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321673002 Review-Url: https://codereview.chromium.org/2321673002
* Use demux API in SkWebpCodecGravatar msarett2016-09-07
| | | | | | | | | | | | | | | * Necessary to read ICC profiles * Will be necessary to implement animation * Requires consolidated data with length Doesn't affect decode performance (thought I believe our performance tests only cover SkStreams with memory bases). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311793004 Review-Url: https://codereview.chromium.org/2311793004
* Add GM/slide to simulate Android-style reveal clipGravatar robertphillips2016-09-07
| | | | | | | | Hopefully, this will let us play w/ geometric and shader-based solutions. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003 Review-Url: https://codereview.chromium.org/2316593003
* Restructure flushing relationship between GrContext, GrDrawingManager, and ↵Gravatar bsalomon2016-09-07
| | | | | | | | | | | | | | | | | | GrResourceCache. Consolidates all flush actions into GrDrawingManager and makes GrContext::flush a passthrough. Removes the unused and untested discard flush variation. Replaces the indirect overbudget callback mechanism of GrResourceCache with a flag set by resource cache when it wants to flush that is checked after each draw by GrDrawContext. Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating whether it triggered the flush that just occurred. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002 Committed: https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744 Review-Url: https://codereview.chromium.org/2307053002
* SkPDF: remove unused fallback clipping codeGravatar halcanary2016-09-07
| | | | | | | | | This code is untested and unnecessary. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319653002 Review-Url: https://codereview.chromium.org/2319653002
* Run install-sysroot script before 'gn gen' on PDFium botGravatar borenet2016-09-07
| | | | | | | BUG=skia:5727 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317013002 Review-Url: https://codereview.chromium.org/2317013002
* Revert of Make AALinearizingConvexPathRenderer able to handle stroke and ↵Gravatar robertphillips2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | fill (patchset #7 id:120001 of https://codereview.chromium.org/2301353004/ ) Reason for revert: Image quality issues on Android devices Original issue's description: > Make AALinearizingConvexPathRenderer able to handle stroke and fill > > This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). > > It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 > > Committed: https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845 TBR=ethannicholas@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2318183002
* fix pathops fuzzersGravatar caryclark2016-09-07
| | | | | | | | | | | | | | Extreme values trigger asserts that in range values allow. Disable asserts and other tests to prevent extreme values from crashing. TBR=reed@google.com BUG=644684. 644680, 644640 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316173002 Review-Url: https://codereview.chromium.org/2316173002
* Add color gamut xform helpers to GrGLSLShaderBuilderGravatar brianosman2016-09-07
| | | | | | | | | | | | | | New helper functions inject the necessary shader function. Texture lookup functions can now insert the gamut xform at the appropriate place, too. As written, could be used to transform non-texture colors (e.g. vertex colors) as well. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180803005 Review-Url: https://codereview.chromium.org/2180803005
* GN: fontmgr_customGravatar mtklein2016-09-07
| | | | | | | | | | | | | This makes skia_use_fontconfig=false build on Linux. Instead of using fontconfig it looks in /usr/share/fonts. That alone is a nice feature to have, but it's mostly relevant for MSAN, where we can't link against any uninstrumented system libraries. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318133003 Review-Url: https://codereview.chromium.org/2318133003
* made point light shadowsGravatar vjiaoblack2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294323003 Review-Url: https://codereview.chromium.org/2294323003
* Merge GrGLSLProgramDesc into GrProgramDescGravatar egdaniel2016-09-07
| | | | | | BUG=skia: Review-Url: https://codereview.chromium.org/2318523006
* Add gammaIsLinear() API to SkColorSpaceGravatar msarett2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319073002 Review-Url: https://codereview.chromium.org/2319073002
* Add 6p to other device mappingGravatar kjlubick2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319593002 Review-Url: https://codereview.chromium.org/2319593002
* New gamut GM, to test gamut conversion in various code-pathsGravatar brianosman2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | After several different strategies, this one appears to work well. The basic test: 1) For a variety of drawing techniques, we render fixed size rectangles. (Solid colors via paint color, bitmap, etc...) 2) For each method in #1, we render to both an sRGB and WideGamutRGB offscreen surface. (AdobeRGB isn't wide enough to clearly demonstrate if things are working or not). 3) Use readPixels to fetch the raw (still in wide gamut) pixel data, then draw that directly to the final canvas. So, for each pair of squares, they should look clearly different. Currently, with the GPU backend, only the bicubic bitmap paths have that behavior. Adding more test cases (and fixing the ones that are already incorrect) will be the long tail of gamut transformation. Current output (with my other patchset, which fixes all bitmap draws): https://screenshot.googleplex.com/wsL3x7eCtWE.png BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293173002 Review-Url: https://codereview.chromium.org/2293173002
* docs: Add instructions on how to download isolated intermediaries.Gravatar jcgregorio2016-09-07
| | | | | | | | | | | | Screenshot: https://screenshot.googleplex.com/2cXAQMqypHv.png BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316113002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2316113002 Review-Url: https://codereview.chromium.org/2316113002
* Make AALinearizingConvexPathRenderer able to handle stroke and fillGravatar robertphillips2016-09-07
| | | | | | | | | | This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 Review-Url: https://codereview.chromium.org/2301353004
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 01:41:09 +0000