aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Restore read pixels perf on ANGLEGravatar bsalomon2015-07-31
| | | | | | BUG=chromium:513797 Review URL: https://codereview.chromium.org/1265003002
* remove drawimagerect flags, as skia no longer respects themGravatar reed2015-07-31
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1262333006
* bump the size of the atlas id to 64 bitsGravatar joshualitt2015-07-31
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1253003005
* Make SkIsPow2 templatedGravatar bsalomon2015-07-31
| | | | Review URL: https://codereview.chromium.org/1271533002
* Revert of Modifying TextBlobCacheTest to use SkRandomScalerContext (patchset ↵Gravatar joshualitt2015-07-31
| | | | | | | | | | | | | | | | | | | | | | #3 id:40001 of https://codereview.chromium.org/1266003002/) Reason for revert: breaking android Original issue's description: > Modifying TextBlobCacheTest to use SkRandomScalerContext > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/adcdca86ce425cf8c28bfad311cef028df756ee8 TBR=bungeman@google.com,bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1267623004
* Modifying TextBlobCacheTest to use SkRandomScalerContextGravatar joshualitt2015-07-31
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1266003002
* Also provides the ResourceProvider to onDrawPath which allows the DF PR to ↵Gravatar bsalomon2015-07-31
| | | | | | no longer require access to GrContext. Review URL: https://codereview.chromium.org/1265763002
* DM: track a direct/indirect bit for each Sink too.Gravatar mtklein2015-07-31
| | | | | | | | | | | | The decoding tests can now veto indirect sinks like pipe-8888. This moves Sink type detection from automatic to explicit; I can't think of any way to automatically differentiate pipe-8888 from 8888 based only on the output. (They should ideally be identical, after all.) BUG=skia:4138 Review URL: https://codereview.chromium.org/1263113002
* Remove unused field in micro cleanupGravatar joshualitt2015-07-31
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1268893002
* Fix repeat builds with Android.Gravatar bungeman2015-07-31
| | | | | | | | | Currently the SampleApp and VisualBench builds for Android don't work for rebuilds. The code is re-built, but the apks are not. This results from the use of a directory as 'output' and the action to build the apk not depending on the copied libraries. Review URL: https://codereview.chromium.org/1270643005
* Tweak the MaskFormat in one more place in GrBatchFontCacheGravatar joshualitt2015-07-31
| | | | | | BUG=510931 Review URL: https://codereview.chromium.org/1268743002
* Address some SkLightingShader TODOsGravatar robertphillips2015-07-31
| | | | | | | | This CL: switches the light colors to be 3 scalars (SkColor3f) adds some dox Review URL: https://codereview.chromium.org/1265983003
* Add android_run_app.goGravatar borenet2015-07-31
| | | | | | | | | | | Launches an app, pipes its output, and exits when the app exits. Loosely based on the old buildbot code in python: https://skia.googlesource.com/buildbot/+/ac0663c599a443a4958c8cad5aefd25eb09eff58/slave/skia_slave_scripts/utils/android_utils.py BUG=skia:4093 Review URL: https://codereview.chromium.org/1256353002
* Implement support for dual source blending in ESGravatar kkinnunen2015-07-30
| | | | | | | | | | | | | | | | | | | | | | | Use EXT_blend_func_extended to implement dual source blending in OpenGL ES. The extension is the ES version of ARB_blend_func_extended. The extension provides gl_SecondaryFragColorEXT for ES 2.0 contexts. The extension provides glBindFragDataLocationIndexed to bind a custom fragment shader output to the secondary color for ES 3.0 contexts. For ES 3.1 contexts, the extension would also give "layout (location=0, index=1)" output varible layout modifier syntax, but it is not used in this patch. The extension needs #extension GL_EXT_blend_func_extended : require directive for the variables to be available in ES 2.0. For ES 3.0, the directive relaxes the rules for the amount of output variables without layout location qualifiers. OpenGL continues to use GL_ARB_blend_func_extended for dual source blending. Review URL: https://codereview.chromium.org/1266773003
* Make it possible to toggle MSAA for ES (EXT_multisample_compatibility)Gravatar kkinnunen2015-07-30
| | | | | | | | | | | | | | | Make it possible to turn MSAA on and off for OpenGL ES, too. Use EXT_multisample_compatibility. The extension adds token: MULTISAMPLE_EXT 0x809D The token can be supplied to glEnable/glDisable/glGetInteger. This is needed in order to support mixed samples in OpenGL ES. This is important for path rendering Chromium command buffer integration. Review URL: https://codereview.chromium.org/1270533002
* lock pixels in image when bitmap is immutable and not-lazyGravatar reed2015-07-30
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1266143003
* fix empty image constructorGravatar reed2015-07-30
| | | | | | | | | fBitmap was not fully constructed yet BUG=skia: TBR= Review URL: https://codereview.chromium.org/1264773004
* unify pixelref and image ID space, so we can share IDs when we share pixelsGravatar reed2015-07-30
| | | | | | | | I view this as a performance opportunity, not a feature or bug fix per-se. BUG=skia: Review URL: https://codereview.chromium.org/1266883002
* Disable SRGB support on PowerVR Rogue due to SRGBReadWritePixels failureGravatar bsalomon2015-07-30
| | | | | | | TBR=jvanverth@google.com BUG=skia:4148 Review URL: https://codereview.chromium.org/1266933002
* Make TRecorder alloc_back return a void*Gravatar bsalomon2015-07-30
| | | | | | | | | | Speculative fix for this bug: BUG=chromium:515679 TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1268493003
* SRGB read and write pixels working and unit testGravatar bsalomon2015-07-30
| | | | Review URL: https://codereview.chromium.org/1264003002
* find image whenever we generateGlyph. This should ensure the glyph is fully ↵Gravatar joshualitt2015-07-30
| | | | | | | | initialized before we start using the maskformat. BUG=skia: Review URL: https://codereview.chromium.org/1270573003
* linear gradient with stops discretized gmGravatar caryclark2015-07-30
| | | | | | | TBR=reed@google.com BUG=skia:517 Review URL: https://codereview.chromium.org/1259983009
* Move some parts of onReadPixels up to GrGpu readPixels.Gravatar egdaniel2015-07-30
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1270583003
* Rename SkCodec_libbmp to SkBmpCodecGravatar msarett2015-07-30
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1254963006
* Call notifyPixelsChanged after modifying bitmapGravatar scroggo2015-07-30
| | | | | | | | | | | | | | | In CodecSrc's scanline_subset test, we decode a subset of an image to a bitmap, draw it to the canvas, and then repeat. This is fine for most backends, but not for pipe. Pipe sees the same generation ID, so it assumes it is the same bitmap it saw before, and just draws the original one. Call notifyPixelsChanged, so the bitmap will get a new generation ID, fixing pipe. BUG=skia:4138 Review URL: https://codereview.chromium.org/1265983004
* Build buckets: tryjob accessGravatar nodir2015-07-30
| | | | | | | | | | Allowed project-skia-tryjob-access group to schedule builds on public skia build buckets R=borenet@chromium.org, rmistry@chromium.org BUG=495680 Review URL: https://codereview.chromium.org/1256333006
* Revert character in typeface test on Android.Gravatar bungeman2015-07-30
| | | | | | | | | | | This is a partial revert of f20488b4f2, particularly https://skia.googlesource.com/skia/+/f20488b4f2139e6ca09fee7e39b731dd8ab467db%5E%21/#F11 BUG=chromium:515366 TBR=mtklein@google.com This is a (non-automatic) revert. Review URL: https://codereview.chromium.org/1265993003
* Minor cleanup of SkLightingShaderGravatar robertphillips2015-07-30
| | | | | | | | Fix: PM component swizzling on Macs Serialization Review URL: https://codereview.chromium.org/1270533003
* Runtime CPU detection for rsqrt().Gravatar mtklein2015-07-30
| | | | | | | | | | | | | | | This enables the NEON sk_float_rsqrt() code for configurations that have NEON at run-time but not compile-time. These devices will see about a 2x (1.26 -> 2.33) slowdown in sk_float_rsqrt(), but it should be more precise than our portable fallback. (When inlined, the portable fallback and the NEON code are almost identical in speed. The only difference is precision. Going through a function pointer is causing all this slowdown. This is a good example of a place where Skia really benefits from compile-time NEON.) BUG=skia:4117,skia:4114 No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1264893002
* Dont try to draw glyphs with unexpected mask formatsGravatar joshualitt2015-07-30
| | | | | | BUG=510931 Review URL: https://codereview.chromium.org/1269743003
* Remove SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONSGravatar scroggo2015-07-30
| | | | | | Now that Chrome no longer depends on it, remove dead code. Review URL: https://codereview.chromium.org/1263013002
* Make GrGpu read/write pixels take GrSurfaceGravatar bsalomon2015-07-30
| | | | Review URL: https://codereview.chromium.org/1262473004
* Lay groundwork for SkOpts.Gravatar mtklein2015-07-30
| | | | | | | | | | This doesn't really do anything yet. It's just the CPU detection code, skeleton new .cpp files, and a few little .gyp tweaks. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/ce2c5055cee5d5d3c9fc84c1b3eeed4b4d84a827 Review URL: https://codereview.chromium.org/1255193002
* buildbot_spec: Add configuration, do_*_steps, upload_*_results, more envGravatar borenet2015-07-30
| | | | | | | NOTRY=true BUG=skia:4132 Review URL: https://codereview.chromium.org/1258193004
* Revert of Optimize RGB16 blitH functions with NEON for ARM platform. ↵Gravatar mtklein2015-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/1229673008/) Reason for revert: This doesn't draw correctly, e.g. our GM test named dashcubics. Good: https://gold.skia.org/img/images/0f7e8e226379afbad8a700e0a80fd8f1.png Bad: https://gold.skia.org/img/images/56ce15fc67436065a3db4b8ee31f13ae.png Original issue's description: > Optimize RGB16 blitH functions with NEON for ARM platform. > > Here are some performance resultsi on Nexus 9: > SkRGB16BlitterBlitH_neon: > +--------+-----------+ > |height | C/NEON | > +--------+-----------+ > |1 | 0.888531 | > +--------+-----------+ > |8 | 1.231800 | > +--------+-----------+ > |18 | 1.073327 | > +--------+-----------+ > |32 | 1.136991 | > +--------+-----------+ > |76 | 1.174638 | > +--------+-----------+ > |85 | 1.188551 | > +--------+-----------+ > |120 | 1.180261 | > +--------+-----------+ > |128 | 1.183726 | > +--------+-----------+ > |512 | 1.220806 | > +--------+-----------+ > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6c72d5740231f47c664a8e765a8df05cd124c88c TBR=djsollen@google.com,caryclark@google.com,reed@google.com,bero@linaro.com,yang.zhang@linaro.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1268513003
* add radial gradient hard stop testGravatar caryclark2015-07-30
| | | | | | | TBR=reed@google.com BUG=skia:4140 Review URL: https://codereview.chromium.org/1269723002
* add helper to create RSXform w/ anchorPtGravatar reed2015-07-30
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1269563006
* Optimize RGB16 blitH functions with NEON for ARM platform.Gravatar yang.zhang2015-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here are some performance resultsi on Nexus 9: SkRGB16BlitterBlitH_neon: +--------+-----------+ |height | C/NEON | +--------+-----------+ |1 | 0.888531 | +--------+-----------+ |8 | 1.231800 | +--------+-----------+ |18 | 1.073327 | +--------+-----------+ |32 | 1.136991 | +--------+-----------+ |76 | 1.174638 | +--------+-----------+ |85 | 1.188551 | +--------+-----------+ |120 | 1.180261 | +--------+-----------+ |128 | 1.183726 | +--------+-----------+ |512 | 1.220806 | +--------+-----------+ BUG=skia: Review URL: https://codereview.chromium.org/1229673008
* Update SkLightingShader to take a localMatrixGravatar robertphillips2015-07-30
| | | | | | W/o this we can't draw lit objects anywhere but the origin. Review URL: https://codereview.chromium.org/1253223003
* Remove WEBKIT_VERSION_MIN_REQUIRED and config.h.Gravatar bungeman2015-07-29
| | | | | | | | | | | | | | | WebKit style guide (https://www.webkit.org/coding/coding-style.html) explicitly states: > All implementation files must #include "config.h" first. > Header files should never include "config.h". Also, it isn't currently being used. TBR=reed@google.com This just removes unused bits. Review URL: https://codereview.chromium.org/1256133004
* Double free in ~SkPictureData()Gravatar fmalita2015-07-29
| | | | | | | | | | | | | | On subpicture parsing failures we clean up all fPictureRefs entries *and* delete the array itself. But the destructor also deletes the array => double free. Alternatively, we can set fPictureCount to the number of successfully parsed pictures such that the destructor handles all the cleanup. BUG=515228 R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1264503011
* Remove SK_BUILD_FOR SDL, BREW, and PALM.Gravatar bungeman2015-07-29
| | | | | | | | SDL isn't an OS anyway, it's just a library views can use. Remaining support for Brew was removed some time ago, and there are currently no uses of SK_BUILD_FOR_PALM. Review URL: https://codereview.chromium.org/1268573002
* Move the last headers. Cross your fingers.Gravatar mtklein2015-07-29
| | | | | | | | | | | If this doesn't work, one at a time... BUG=skia:4126 No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1255373006
* Move non-trivial constructors out-of-line.Gravatar mtklein2015-07-29
| | | | | | | | | | | There is more than one way to skin this SkPathPriv.h cat. These constructors are large enough that they probably shouldn't have been inlined like this anyway. BUG=skia:4126 Review URL: https://codereview.chromium.org/1253963004
* remove (unnecessary?) call to notifyPixelsChangedGravatar reed2015-07-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1265733002
* Remove SK_BUILD_FOR_WINCE.Gravatar bungeman2015-07-29
| | | | | | | | This hasn't been tested for years, and no one currently knows when it last worked (if ever). It is doubtful that any of the remaining logic would even make sense with a modern version of Embedded Compact 2013. Review URL: https://codereview.chromium.org/1260453008
* Move LightingShader to effectsGravatar robertphillips2015-07-29
| | | | | | | | | | | Additionally this CL: forces the light colors to be opaque forces the light direction to be normalized adds a raster implementation adds a gm Review URL: https://codereview.chromium.org/1245883003
* Clean up a few includes, introduce iwyu.Gravatar bungeman2015-07-29
| | | | | | | | | The current include-what-you-use with current clang is much less noisy and more useful than it has been in the past. This change introduces a few IWYU directives (which are helpful documentation for humans as well) and fixes a few sets of includes. Review URL: https://codereview.chromium.org/1207893002
* SkImage_Raster's pixels are always immutable.Gravatar reed2015-07-29
| | | | | | | | | | | | | | | | | | To make this work, we tag their pixelrefs as temporarily immutable, allowing ourselves to restore the pixels to mutability only when the image drops away. This should allow us to wobble back and forth between writing to the Surface and reading from the Image without a COW, with the Surface seeing mutable pixels and the Image seeing immutable pixels. The big idea is, Image doesn't need forever-immutable pixels, it just needs pixels that are immutable as long as it's alive. BUG=skia: patch from issue 804523002 at patchset 40001 (http://crrev.com/804523002#ps40001) Review URL: https://codereview.chromium.org/1254383006