aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* refactor SkRasterPipelineBlitterGravatar Mike Klein2017-05-22
| | | | | | | | | | | | | | | | | This refactors the factories so that the create-from-paint factory is a front-patch to the create-from-shader-pipeline factory. Feature-wise, we make the pre-baked shader pipeline responsible for modulating by paint alpha; the factory only adds when creating from the paint. We can fold the alpha into the colors in drawVertices, which makes it run a bit faster, dropping the need for a scale_1_float runtime stage. This causes a few invisible diffs on the "vertices" GM, but everything else draws the same. Change-Id: I3eeacc9aafbce2023ab18991bbb68c35645e9387 Reviewed-on: https://skia-review.googlesource.com/17395 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* some basic speed ups for SkRasterPipeline::append()Gravatar Mike Klein2017-05-22
| | | | | | | | | | | The new bench demos the speedup: SkRasterPipelineReuse_… …full 1x …some 1.8x …none 5.22x Change-Id: I5e51fb4316ae04558710ce62560850584ccb4aea Reviewed-on: https://skia-review.googlesource.com/17449 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* [recipes] Copy file, isolate, swarming, swarming_client from build.gitGravatar Eric Boren2017-05-22
| | | | | | | | | | | | | | | | | Rename swarming -> skia_swarming. Some required heavy modification to remove other dependencies on modules in build.git. Expected changes: - RECIPE_MODULE[build::<module>] -> RECIPE_MODULE[skia::<module>] - No more runit; directly run through Python. Bug: skia:6628 Change-Id: I1b1370ed387966222ce10731771dbde9020cf542 Reviewed-on: https://skia-review.googlesource.com/17448 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* SkPDF: eliminate unnecessary clip for each pageGravatar Hal Canary2017-05-22
| | | | | | | | | | | | Somehow this improves the imagefilterscropped gm. This also makes it easier for me to manually parse PDF output for debugging. Change-Id: I3af39f4b0ca3fc7fcdeec4825bf8649bd9544917 Reviewed-on: https://skia-review.googlesource.com/17413 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-22
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/bc9dcd6ed4e53b32dcb134a634fcba2b3556f60f Dart: Trigger some dart2js bots on commit, not with special trigger. (whesse@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iadf6e0d49853e015bcaa021bf2479a052af623b0 Reviewed-on: https://skia-review.googlesource.com/17447 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-21
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/22da36e95697d92463b1b8ea002f7c4b8a4de41a remote_run: Remove BuildBot Python path injection. (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icaf0b1f0f2f3476a7525bf5832c5fcdc78c706ae Reviewed-on: https://skia-review.googlesource.com/17446 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-21
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/a757e193649738016b242a11f654c558adda8aaa Remove "url" recipe module. (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1caa2058733ef9dd28f4c21913eb7ff83007c331 Reviewed-on: https://skia-review.googlesource.com/17445 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-21
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/9d8e66c1f40b2318b042ebea3618d11fe831c689 Link to gerrit changes from buildbot build properties (agable@chromium.org) https://crrev.com/d9932108ec67f7d364de5f696f90a3c1ce8650b8 Remove "gitiles" recipe module. (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifbcedeb690ebc61e25e23f221b37a77bb74f17a9 Reviewed-on: https://skia-review.googlesource.com/17444 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Revert "Remove GrSurfaceDesc member from GrSurface.""Gravatar Brian Salomon2017-05-21
| | | | | | | | | | This reverts commit 4b30a96a3e96b7f051e25025f4f17f3c54e04153. Bug: skia: Change-Id: I14d5b402c87df8fffbc29f16686fcfa18474fc48 Reviewed-on: https://skia-review.googlesource.com/17408 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Update SKP versionGravatar UpdateSKPs2017-05-21
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Ic288e06ceeb0113f80f69c9975549c8c4045f2dc Reviewed-on: https://skia-review.googlesource.com/17423 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* tidy up dither stageGravatar Mike Klein2017-05-20
| | | | | | | | | | Using the float iota was just an expedient to write the stage... this CL adds the U32 iota that dither really wants. Change-Id: I7990b10afd0c5277186b6b8e730245d291bcef0c Reviewed-on: https://skia-review.googlesource.com/17441 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* streamline SkRasterPipeline::run()Gravatar Mike Klein2017-05-20
| | | | | | | | | | | | | This used to need to be complicated to check for unimplemented stages, but now that SkJumper rules the world, we can make this a lot simpler and move a lot of the tricky stage selection logic into an SkOnce. This should decrease the overhead of SkRasterPipeline::run(). Change-Id: I79d73f3315c7a1a52ab02747a5f17ce27d8cb9a4 Reviewed-on: https://skia-review.googlesource.com/17440 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "dither copies when decreasing precision"Gravatar Mike Klein2017-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 766f9cd5553ab091b85d287a79f47cbb91ad7989. Reason for revert: unit test failures, I think on bots running portable code path Original change's description: > dither copies when decreasing precision > > Still seeing the same 4444 diffs on copyTo4444 and all_bitmap_configs, > and now also 565 in all_bitmap_configs. > > BUG=chromium:720105 > > Change-Id: I19406f57aa6d2b2f98d98c093da302b004c7cd8b > Reviewed-on: https://skia-review.googlesource.com/17419 > Commit-Queue: Mike Klein <mtklein@chromium.org> > Reviewed-by: Matt Sarett <msarett@google.com> > TBR=mtklein@chromium.org,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:720105 Change-Id: Ia9ece7dccef325233b870102ab38fbed2336b95d Reviewed-on: https://skia-review.googlesource.com/17442 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* dither copies when decreasing precisionGravatar Mike Klein2017-05-20
| | | | | | | | | | | | Still seeing the same 4444 diffs on copyTo4444 and all_bitmap_configs, and now also 565 in all_bitmap_configs. BUG=chromium:720105 Change-Id: I19406f57aa6d2b2f98d98c093da302b004c7cd8b Reviewed-on: https://skia-review.googlesource.com/17419 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com>
* SkWebpEncoder: use bgra for lossless and yuv for lossyGravatar Matt Sarett2017-05-19
| | | | | | | | | | Previosuly, we would (accidentally) always use just yuv. Bug: 713862 Change-Id: I00acc6ca2841ba0636494119b7b4f46a9deee401 Reviewed-on: https://skia-review.googlesource.com/17406 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/2537c8c2d9fb1b2aa5def9315e0d48da41e93871 chromite: Stop setting LANG to a known value. (dgarrett@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifa98070323e03a8f3c887ae064d3585a879e14c5 Reviewed-on: https://skia-review.googlesource.com/17417 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/31b834a0e849ce66bd5a7c8544071dce1276ef2f Closure: turn down the old GYP format (dbeam@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idb053a1f28af1bd6825b26187a30630b5c9dde95 Reviewed-on: https://skia-review.googlesource.com/17414 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Update Porter Duff analysis to match LCD logic.Gravatar Greg Daniel2017-05-19
| | | | | | | | Bug: skia: Change-Id: Ib222c37f7ebb307752806829742a3b6278dbae3d Reviewed-on: https://skia-review.googlesource.com/17410 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Remove debug flag for ios botsGravatar Stephan Altmueller2017-05-19
| | | | | | | | | TBR=borenet Bug: skia: Change-Id: I791ad92203ca8cdd6da8abe7c9f45fde528cb7b9 Reviewed-on: https://skia-review.googlesource.com/17409 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Improve test coverage of image decode modesGravatar Matt Sarett2017-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the new world... --image CodecSrc and ImageGenSrc tests run on: (1) 8888 with kIgnore transfer fn behavior (2) srgb with kRespect transfer fn behavior (3) f16 AndroidCodecSrc and BRDCodecSrc tests run on: (1) 8888, since SkAndroidCodec always uses kIgnore (2) f16, since android uses f16 --colorImage ColorCodecSrc tests run on: (1) 8888 in kBaseline mode, so we can see what the raw pixels look like (2) srgb in color correct modes (3) f16 in color correct modes Bug: skia: Change-Id: I65d1a04051da6f94bf5e48f7bc610f482870dc75 Reviewed-on: https://skia-review.googlesource.com/17396 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* stage version of verticesGravatar Mike Reed2017-05-19
| | | | | | | | | | | | | | | | This CL, just to limit its size/complexity, only handles colors but not textures. Future CLs will cover everything. Performance is pretty exciting. Its faster than the old code-path, and when we fix a bug in pathutils to preserve opaqueness, it gets a lot faster (8 -> 5) Bug: skia: Change-Id: I4113060e25fe25fe4e6a0ea59bd4fa5e33abc668 Reviewed-on: https://skia-review.googlesource.com/17276 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* minor skslc bugfixesGravatar Ethan Nicholas2017-05-19
| | | | | | | | | | This fixes the attributes on sk_VertexID, and a backwards test on SkSL::String::startsWith and ::endsWith. Change-Id: Icfddfc8ca95454d8646a1771761685c2525b296e Reviewed-on: https://skia-review.googlesource.com/17398 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/0104dcd6b327b06880b9020f1cb2ca2b93d08a5d Fix recipe typo (martiniss@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I167a43ad87b66295d479d1012512e2a79d9f5a86 Reviewed-on: https://skia-review.googlesource.com/17400 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Comment out lcd assert to make GLPrograms test happyGravatar Greg Daniel2017-05-19
| | | | | | | | | | | TBR=bsalomon@google.com Bug: skia:6661 Change-Id: I944d05c31d3d5511f3c1679c9eb689dbcfbbb109 Reviewed-on: https://skia-review.googlesource.com/17399 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Remove transitional parts from iOS job namesGravatar Stephan Altmueller2017-05-19
| | | | | | | | Bug: skia: Change-Id: If19e5a956d3f10448cfe889127c2f79d9c42926e Reviewed-on: https://skia-review.googlesource.com/17372 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Fix gpu lcd blending to semi-correctly handle alpha coverageGravatar Greg Daniel2017-05-19
| | | | | | | | Bug: skia:6606 Change-Id: I16ccd97f5d047eb7fddfed5310bf669e7435ccdd Reviewed-on: https://skia-review.googlesource.com/17370 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Temporarily use default webp encode method for bzlGravatar Matt Sarett2017-05-19
| | | | | | | | | | I suspect that this will fix the failing golden image tests. Bug: skia: Change-Id: I9f88206ae782e6a04817e72cdfcb3e0c4bdaa293 Reviewed-on: https://skia-review.googlesource.com/17393 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Update NexusPlayers to O Preview 2Gravatar Kevin Lubick2017-05-19
| | | | | | | | | | | This may help with NexusPlayers flaking out. Bug: skia:6045 NOTRY=true Change-Id: I1ac1bf3cb5e17d26069082da7cb0f420865c9630 Reviewed-on: https://skia-review.googlesource.com/17388 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* detect (and preserve) if patch colors are opaqueGravatar Mike Reed2017-05-19
| | | | | | | | Bug: skia: Change-Id: Ida3a1ff3f78db2498a6dfc655d8be4de8ad912c7 Reviewed-on: https://skia-review.googlesource.com/17380 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkDocument: remove deprecated functionGravatar Hal Canary2017-05-19
| | | | | | | | | | I meant to land this after https://crrev.com/2726103006 , but got sidetracked. Change-Id: I4f0397302d41e89d2394bec545190cb024929bd8 Reviewed-on: https://skia-review.googlesource.com/17390 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Updated workaround for Intel 6xxx clear to 0/1 bugGravatar Eric Karl2017-05-19
| | | | | | | | | | | | | The previous workaround only handled the glClearColor(0,0,0,1) case, it turns out we need to work around any glClearColor made up of entirely 0s and 1s. R=bsalomon@google.com Bug: 710443 Change-Id: I78a75559fc11811ad9a218436231354d66d2ad51 Reviewed-on: https://skia-review.googlesource.com/17327 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Eric Karl <ericrk@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/c33bbcee5e1f89a78814b7b9ebbc7cdbe19eddc8 Dart: Increase timeout for IE bots, use fewer processors (whesse@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8993e271c3252b57ce723f1f7095f38ceb5b50d7 Reviewed-on: https://skia-review.googlesource.com/17389 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac [cronet] Don't use is_official_build universally on cronet bots. (jbudorick@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8408708568bebc62682439f9322a4684550b46b5 Reviewed-on: https://skia-review.googlesource.com/17385 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/00749f571ff265c29cc9f2be07120364b00fcda8 Dart: Add "debug" and "unittests" options to dart2js recipe. (whesse@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6d8bcf28eaf04733eae8fcd587fb24b9b2beb652 Reviewed-on: https://skia-review.googlesource.com/17384 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/28ebfb41f178f521e9187108c7b6ddd66b8e4a85 V8: Bump shards on PPC and S390 bots (machenbach@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I669307e2e1b10f2fb5e2f66781d3bb12839bff70 Reviewed-on: https://skia-review.googlesource.com/17383 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6 Refactor PRESUBMIT support for tags (agable@chromium.org) https://crrev.com/064f6f4a9d2932ae699dbf4355bc63359e599026 gclient flatten: first pass (phajdan.jr@chromium.org) https://crrev.com/063814f82efdda25a0d1737395172faa88a5fd0f Remove "url" recipe module. (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I85f0df7d2de9782fc8c66e827c53eb16c03edf34 Reviewed-on: https://skia-review.googlesource.com/17382 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/e99a7805ce3c1fef96b428fb542d23fe975e8c5c Fix bot config for battor non linux builders (martiniss@chromium.org) https://crrev.com/cdf1ebd83441bc4bb54899e3f94d92d7953b8c66 Remove Android Swarming Tester (martiniss@chromium.org) https://crrev.com/9d08858e8f2f3aa0c556c1339eeca3d88bb44d46 Add four more slaves to N5 bot on chromium.swarm (bpastene@google.com) https://crrev.com/16c52aa6473518cf6751a9503a6e0b0d684979f8 CrOS: Update Chromite pin. (nodir@google.com) https://crrev.com/2cc4e2912d055df545a22801adaae8d16fbcb216 Convert Android One Perf builder to swarming (martiniss@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I75e3e2f14548081e5dfb585b22aec25f48a81e76 Reviewed-on: https://skia-review.googlesource.com/17374 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/f347ca1f531aad4cfb60ac6f23b4a8d8426195db ios/try: add regression test for patch application failure (phajdan.jr@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3a296e258c78850341874b8698242ec75260f5ba Reviewed-on: https://skia-review.googlesource.com/17373 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Update clearOp for split-OpList world"Gravatar Robert Phillips2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7f1ce29c9bb9be8b2d8dbf9a99f14f74d5dc6d80. Reason for revert: Maybe causing problems in imagemakewithfilter & dropshadowimagefilter Original change's description: > Update clearOp for split-OpList world > > It would reduce a lot of noise if the GrRenderTargetOpList kept a pointer to the GrCaps but, for now, I'm trying to shrink the GrRTOpList, not expand it. > > Change-Id: Ieed56fa2a41a3fb20234e26552ae2d301147e4f2 > Reviewed-on: https://skia-review.googlesource.com/17323 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ib23ce4515d9427759ebd2b6d4c9d3a670f00a153 Reviewed-on: https://skia-review.googlesource.com/17326 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Disable resource cache in shadow_utils GM for now""Gravatar Jim Van Verth2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0b58ef7b525e5325ecd194c4b470e4c924cbb56a. Reason for revert: Wasn't actually fixed. Original change's description: > Revert "Disable resource cache in shadow_utils GM for now" > > This reverts commit c34a946d5a975ba8b8cd51f79b55174a5ec0f99f. > > Reason for revert: This is probably fixed with https://skia-review.googlesource.com/c/17279/. > > Original change's description: > > Disable resource cache in shadow_utils GM for now > > > > This should make the GMs more stable in tiled mode. > > > > Change-Id: I72996b1305fc99e60626af35267952d0a5c38624 > > Reviewed-on: https://skia-review.googlesource.com/17275 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Jim Van Verth <jvanverth@google.com> > > > > TBR=jvanverth@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I0d21652a301b3f81e7ec04638bedbaabc723e583 > Reviewed-on: https://skia-review.googlesource.com/17304 > Reviewed-by: Jim Van Verth <jvanverth@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> > TBR=mtklein@google.com,jvanverth@google.com,reviews@skia.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: If606795bfeb4e6ed78f199fcb86ee2767bde5216 Reviewed-on: https://skia-review.googlesource.com/17371 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* comment SK_API and add fix paramsGravatar Cary Clark2017-05-18
| | | | | | | | | | | | | | | | | I thought that SK_API on operator== was redundant with SK_API on the enclosing class, and was not needed. Turns out for mac_chromium_debug_ng it is needed. Added comments for history. Meanwhile, bookmaker found some missing and mis-named parameters, so all is not lost. R=reed@google.com Change-Id: I88645666a9d06ec90c5ac133673460d6e6c75528 Reviewed-on: https://skia-review.googlesource.com/17277 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Remove ambient and spot mask filters.Gravatar Jim Van Verth2017-05-18
| | | | | | | | | Also remove a deprecated interface in SkShadowUtils. Change-Id: I32e67271be953f11071c512cb39a47ea1e7dcaaf Reviewed-on: https://skia-review.googlesource.com/17266 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Update clearOp for split-OpList worldGravatar Robert Phillips2017-05-18
| | | | | | | | | It would reduce a lot of noise if the GrRenderTargetOpList kept a pointer to the GrCaps but, for now, I'm trying to shrink the GrRTOpList, not expand it. Change-Id: Ieed56fa2a41a3fb20234e26552ae2d301147e4f2 Reviewed-on: https://skia-review.googlesource.com/17323 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add microbench for shadowsGravatar Jim Van Verth2017-05-18
| | | | | | | | | Based on Android's shadowgrid2. Change-Id: I33209b6b84fc63a762405c4988afbdbffcc170d6 Reviewed-on: https://skia-review.googlesource.com/17360 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/09b389732d01bbeb2bfb17f5de06e15a952f0cbb buildbot: log path where pruning is happening (nodir@google.com) https://crrev.com/e13406ec6a3459b6dccd3eca4be5bdcd5325682e Remove Win10 experimental bots (hinoka@google.com) https://crrev.com/745e8d9fbc8344d522a84131ffa9b43472dbb06d Revert "Reland: zip_build.py: Exclude secondary toolchain obj and gen, as well as .ninja" (agrieve@chromium.org) depot_tools: https://crrev.com/16d2ae8cb05c27956530d8f05a893caec6a488ac bot_update: fix regression with swallowed exception (phajdan.jr@chromium.org) recipe_engine: https://crrev.com/2f2d5c663eddcd8b6924a8775aaf88f3600d2ac8 [step_runner] expand try/catch to cover all step preparation functionality (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0dfbef52e05e67b967846b91813ca1c6ee3abf15 Reviewed-on: https://skia-review.googlesource.com/17366 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Remove GrSurfaceDesc member from GrSurface."Gravatar Greg Daniel2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 84911546b9535a2fff6c5e07f588f175d5a04f45. Reason for revert: Breaking bots possibly? Original change's description: > Remove GrSurfaceDesc member from GrSurface. > > Change-Id: I0fe979994e1e3fc457b952dfb5e0090c45fad771 > Reviewed-on: https://skia-review.googlesource.com/17273 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I404e509fcd3e3d5527b3bc6e286b7d436c12e879 Reviewed-on: https://skia-review.googlesource.com/17364 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Hide SkPerlinNoiseShader impl detailsGravatar Florin Malita2017-05-18
| | | | | | | | | | Move the shader impl to a private class, leave SkPerlinNoiseShader as a factory class only (similar to e.g. SkLightingShader). Change-Id: Ic1180db8f5dfd3d8f6fba133c6bf6bbdfa4f97a4 Reviewed-on: https://skia-review.googlesource.com/17318 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Use persistent checkout for UpdateMetaConfig botGravatar Ravi Mistry2017-05-18
| | | | | | | | | | | Bot is failing without this. BUG=skia:6591 Change-Id: I29cf5e18a7fa240d3e45bdadf83c1f91060f45f5 Reviewed-on: https://skia-review.googlesource.com/17319 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove GrSurfaceDesc member from GrSurface.Gravatar Brian Salomon2017-05-18
| | | | | | | Change-Id: I0fe979994e1e3fc457b952dfb5e0090c45fad771 Reviewed-on: https://skia-review.googlesource.com/17273 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Switch over GrDiscardOp to IORef-ing the GrRenderTargetProxyGravatar Robert Phillips2017-05-18
| | | | | | | | | | | This cannot land until after https://skia-review.googlesource.com/c/14186/ (Split up opLists (take 3)) sticks. This is because, prior to that CL, the SurfaceProxies have a ref on the last OpList that wrote to them. Since this CL adds a IORef from a discardOp in an opList to the SurfaceProxy this can result in a loop. After the required CL sticks, opLists have a IORef on the SurfaceProxy to which they wrote and the SurfaceProxy just has a raw back pointer so there will be no loop. Change-Id: I198035f5dd5a8fad549052dea6aaa61477a89844 Reviewed-on: https://skia-review.googlesource.com/16663 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-20 22:56:33 +0000