aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add SkImageGenerator InterfaceGravatar halcanary@google.com2013-11-21
| | | | | | | | | | | | | | | | | | - Add SkDiscardablePixelRef class that uses SkDiscardableMemory and a SkImageGenerator. - Add SkDecodingImageGenerator class as an example of a SkImageGenerator. - Add DecodingImageGenerator unit test. - Add SkBasicDiscardableMemory implmentation for unit tests only. R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/74793011 git-svn-id: http://skia.googlecode.com/svn/trunk@12341 2bbb7eff-a529-9590-31e7-b0007b416f81
* Avoid printing draw target info to stderr while running unit testsGravatar commit-bot@chromium.org2013-11-21
| | | | | | | | | | | | | | Change draw target dump function to return a SkString. Clients can do whatever they want with the string. BUG=skia:1837 R=caryclark@google.com, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/72353003 git-svn-id: http://skia.googlecode.com/svn/trunk@12340 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove mutex around image decoding in skpdiff.Gravatar commit-bot@chromium.org2013-11-21
| | | | | | | | | | | | | | | | I removed the mutex to investigate BUG=skia:1803, and I get no crashes. The crashes may have been related to other multithreading issues. Removing the mutex will allow skpdiff to run faster. R=djsollen@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/61603008 git-svn-id: http://skia.googlecode.com/svn/trunk@12339 2bbb7eff-a529-9590-31e7-b0007b416f81
* Minor fixes for distance field fonts:Gravatar commit-bot@chromium.org2013-11-21
| | | | | | | | | | | | | | - Remove additional transform in drawpostext() - Use bitmap fonts if rasterizer set in paint - Correctly set scale ratio for drawtext() R=bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/79283004 git-svn-id: http://skia.googlecode.com/svn/trunk@12338 2bbb7eff-a529-9590-31e7-b0007b416f81
* More Windows 64b compilation warning fixesGravatar robertphillips@google.com2013-11-21
| | | | | | | | https://codereview.chromium.org/47513017/ git-svn-id: http://skia.googlecode.com/svn/trunk@12337 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make the debugger left panel resizable.Gravatar commit-bot@chromium.org2013-11-21
| | | | | | | | | | | | Use QSplitters to allow resizing the left debugger panels. R=robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/79573002 git-svn-id: http://skia.googlecode.com/svn/trunk@12336 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-11-21
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12335 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement a benchmark for GrResourceCacheGravatar commit-bot@chromium.org2013-11-21
| | | | | | | | | | | | | | | | | | | | | | | Adds "grresourcecache_add" and "grresourcecache_find" bench tests to test GrResourceCache::add and GrResourceCache::find. The tests work only with GPU backends, since GrResourceCache needs an GrGpu. Modifies bench tests to override SkBenchmark::isSuitableFor(Backend) function that specifies what kind of backend the test is inteded for. This replaces the previous "fIsRendering" flag that would indicate test that did no rendering. Adds SkCanvas::getGrContext() call to get the GrContext that the canvas ends up drawing to. The member function solves a common use-case that is also used in the benchmark added here. R=mtklein@google.com, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/73643005 git-svn-id: http://skia.googlecode.com/svn/trunk@12334 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move PdfTokenLooper into its own file.Gravatar scroggo@google.com2013-11-20
| | | | | | | | Otherwise, leave the class unchanged. Review URL: https://codereview.chromium.org/79773002 git-svn-id: http://skia.googlecode.com/svn/trunk@12333 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ifdef guard for SkPdfContext.Gravatar scroggo@google.com2013-11-20
| | | | | | Review URL: https://codereview.chromium.org/79723002 git-svn-id: http://skia.googlecode.com/svn/trunk@12332 2bbb7eff-a529-9590-31e7-b0007b416f81
* Only SkFontMgr_New_DirectWrite should call GetSystemFontCollection.Gravatar bungeman@google.com2013-11-20
| | | | | | | | | | | | Aside from the factory helper, there should be no calls to IDWriteFactory::GetSystemFontCollection. All other code should work in terms of IDWriteFontCollection for flexibility and correctness. R=caryclark@google.com Review URL: https://codereview.chromium.org/77023006 git-svn-id: http://skia.googlecode.com/svn/trunk@12331 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move SkPdfContext into its own files.Gravatar scroggo@google.com2013-11-20
| | | | | | | | Otherwise, the class is unchanged. Review URL: https://codereview.chromium.org/77763007 git-svn-id: http://skia.googlecode.com/svn/trunk@12330 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make changes based on talks with Edison.Gravatar scroggo@google.com2013-11-20
| | | | | | | | | | Mostly FIXMEs, to go back and look at in more detail. Fix a bug where ET did not set fTextBlock back to false. Corresponds to notes in https://code.google.com/p/skia/source/detail?r=12270 git-svn-id: http://skia.googlecode.com/svn/trunk@12329 2bbb7eff-a529-9590-31e7-b0007b416f81
* Changes to SkTDStackNester.Gravatar scroggo@google.com2013-11-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SkTDStackNester is a class used by PdfViewer to assist in saving and restoring the PDF state. Clean up and test this class. Add some documentation. Add FIXME's where I have questions to resolve. Fix a bug where fNestingLevel was not initialized. Remove a commented out line of code copied over from SkTDStack. Rename SkTDStackNester::nests() to nestingLevel() and make it const. Remove unnecessary predeclaration and friend declaration. Remove index() (both const and non-const versions). They were unused, return something that may not be expected (index from the top, rather than from the bottom), and don't work to get any elements in earlier Recs once the first one is full. Report a warning if the nesting level goes above the maximum level, or if we attempt to bring it below zero. Prevent fNestingLevel from dropping below zero. Add kUnusedObject_SkPdfIssue, and use it where appropriate. Depends on https://codereview.chromium.org/64093009/ R=mtklein@google.com Review URL: https://codereview.chromium.org/68843006 git-svn-id: http://skia.googlecode.com/svn/trunk@12328 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SkMatrix44::invert(...) for identity matrices and a NULL parameterGravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | | | | | | | Currently, to check if an SkMatrix44 is singular, we call ::invert(NULL) and check the result. Usually this does no more work than is necessary. One case where we do far too much work is if |this| is an identity matrix. In this case, we do not early out and compute a (partial) determinant (we don't do the full shebang because there are no perspective components). BUG=None R=ajuma@chromium.org, reed@google.com Author: vollick@chromium.org Review URL: https://codereview.chromium.org/79333002 git-svn-id: http://skia.googlecode.com/svn/trunk@12327 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unnamed namespace usage from 'gm'.Gravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | | | | Skia prefers static over unnamed namespaces. BUG=None TEST=None R=bsalomon@google.com, robertphillips@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/79173002 git-svn-id: http://skia.googlecode.com/svn/trunk@12326 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move SkTDStackNester into its own private file.Gravatar scroggo@google.com2013-11-20
| | | | | | | | | | | | Also remove depth(), which is unused. Otherwise the class is unchanged. R=mtklein@google.com Review URL: https://codereview.chromium.org/64093009 git-svn-id: http://skia.googlecode.com/svn/trunk@12324 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: clean up thread locksGravatar epoger@google.com2013-11-20
| | | | | | | | | | | followup to https://codereview.chromium.org/66803004/ ('rebaseline_server: improve thread locks to allow read access during updates') (SkipBuildbotRuns) R=jcgregorio@google.com Review URL: https://codereview.chromium.org/64273011 git-svn-id: http://skia.googlecode.com/svn/trunk@12323 2bbb7eff-a529-9590-31e7-b0007b416f81
* More common_conditions simplifications.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | BUG= R=bungeman@google.com, djsollen@google.com Review URL: https://codereview.chromium.org/78653002 git-svn-id: http://skia.googlecode.com/svn/trunk@12322 2bbb7eff-a529-9590-31e7-b0007b416f81
* Hide unused gFormats.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | | | Presumably this is WIP code? Otherwise, we delete it? BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/78503003 git-svn-id: http://skia.googlecode.com/svn/trunk@12321 2bbb7eff-a529-9590-31e7-b0007b416f81
* GpuTest::GetContext() doesn't exist.Gravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | BUG= R=bsalomon@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/76143003 git-svn-id: http://skia.googlecode.com/svn/trunk@12320 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove the SKIA_IGNORE_GPU_MIPMAPS now that Chrome sets glGenMipmap forGravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | | the skia GL interface. R=bsalomon@google.com, humper@google.com Author: skaslev@chromium.org Review URL: https://codereview.chromium.org/74783011 git-svn-id: http://skia.googlecode.com/svn/trunk@12319 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update expectations for Ubuntu x32 bot.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | | GM diffs are few, tiny, and unreproducable on our workstations. BUG= Review URL: https://codereview.chromium.org/78913002 git-svn-id: http://skia.googlecode.com/svn/trunk@12318 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix a warning building DM using ninja on Mac.Gravatar scroggo@google.com2013-11-20
| | | | | | | | | | | | | | Here is the warning: ../../dm/DMTask.cpp: In copy constructor ‘DM::Task::Task(const DM::Task&)’: ../../dm/DMTask.cpp:17: warning: base class ‘class SkRunnable’ should be explicitly initialized in the copy constructor Also add an SK_OVERRIDE. R=mtklein@google.com Review URL: https://codereview.chromium.org/76903002 git-svn-id: http://skia.googlecode.com/svn/trunk@12317 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting r12315 (More Windows 64b compilation warning fixes) due to ↵Gravatar robertphillips@google.com2013-11-20
| | | | | | compilation failures git-svn-id: http://skia.googlecode.com/svn/trunk@12316 2bbb7eff-a529-9590-31e7-b0007b416f81
* More Windows 64b compilation warning fixesGravatar robertphillips@google.com2013-11-20
| | | | | | | | https://codereview.chromium.org/47513017/ git-svn-id: http://skia.googlecode.com/svn/trunk@12315 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add extra warnings to match what Android uses.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | | R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=12310 Review URL: https://codereview.chromium.org/74193005 git-svn-id: http://skia.googlecode.com/svn/trunk@12314 2bbb7eff-a529-9590-31e7-b0007b416f81
* De-generalize create_typeface on Windows.Gravatar bungeman@google.com2013-11-20
| | | | | | | | | | | | The gdi and dw backends have a local create_typeface function. This function is now called in only one place, onLegacyCreateTypeface. Move the implementation into the caller. R=caryclark@google.com Review URL: https://codereview.chromium.org/76763002 git-svn-id: http://skia.googlecode.com/svn/trunk@12313 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add missing (trivial) virtual destructors.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/78543002 git-svn-id: http://skia.googlecode.com/svn/trunk@12312 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Add extra warnings to match what Android uses."Gravatar scroggo@google.com2013-11-20
| | | | | | | | This reverts commit d234662df1ffeb1bf45b2ade16c4acfb94f89450. This change broke the build. Will resubmit after fixing warnings. git-svn-id: http://skia.googlecode.com/svn/trunk@12311 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add extra warnings to match what Android uses.Gravatar djsollen@google.com2013-11-20
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/74193005 git-svn-id: http://skia.googlecode.com/svn/trunk@12310 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix bench so that if SK_SUPPORTS_GPU even when not provided as compiler optionGravatar djsollen@google.com2013-11-20
| | | | | | | | | | | | | In the case that SK_SUPPORTS_GPU is not provided to the compiler the value is eithe defined in in the SkUserConfig.h or SkPostConfig.h. Prior to this change those headers were not read prior to trying to include the GPU headers which resulted in a failed compile. R=bsalomon@google.com Review URL: https://codereview.chromium.org/76213004 git-svn-id: http://skia.googlecode.com/svn/trunk@12309 2bbb7eff-a529-9590-31e7-b0007b416f81
* SkMemoryStream::setData should also set the current offset to 0.Gravatar bungeman@google.com2013-11-18
| | | | | | | | R=scroggo@google.com Review URL: https://codereview.chromium.org/73273004 git-svn-id: http://skia.googlecode.com/svn/trunk@12308 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unused kMaxPOI.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | | BUG= R=djsollen@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/62333026 git-svn-id: http://skia.googlecode.com/svn/trunk@12307 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert SK_REQUIRE_LOCAL_VAR changes for DEPS roll.Gravatar mtklein@google.com2013-11-18
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/59703012 git-svn-id: http://skia.googlecode.com/svn/trunk@12306 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unnecessary includes.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | R=djsollen@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/68893028 git-svn-id: http://skia.googlecode.com/svn/trunk@12304 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix Windows build after the SkAutoFoo guard CL.Gravatar mtklein@google.com2013-11-18
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/66593004 git-svn-id: http://skia.googlecode.com/svn/trunk@12303 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix DocumentTest/SkDocument memory leaksGravatar robertphillips@google.com2013-11-18
| | | | | | | | https://codereview.chromium.org/72833002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12302 2bbb7eff-a529-9590-31e7-b0007b416f81
* Guard against most unintentionally ephemeral SkAutoFoo instantiations.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | | | | | | | | | | I think I applied the trick everywhere possible. Limitations: - can't be used with templated classes - all constructors and destructors must be defined inline A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I deleted them. This change caught the same bugs Cary found in SkPath, plus one more in SampleApp. BUG= R=reed@google.com, caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/72603005 git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test CQ.Gravatar commit-bot@chromium.org2013-11-17
| | | | | | | | | | | | TBR= NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/74723002 git-svn-id: http://skia.googlecode.com/svn/trunk@12300 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix general-pespective for conical gradient bug=1744Gravatar mike@reedtribe.org2013-11-14
| | | | | | | | | BUG= R=edisonn@google.com Review URL: https://codereview.chromium.org/71303003 git-svn-id: http://skia.googlecode.com/svn/trunk@12299 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore GM dashing_gpu on Debug ANGLEGravatar jvanverth@google.com2013-11-14
| | | | | | | | | | | | BUG=Skia:1844 Committed: http://code.google.com/p/skia/source/detail?r=12297 R=robertphillips@google.com Review URL: https://codereview.chromium.org/72993002 git-svn-id: http://skia.googlecode.com/svn/trunk@12298 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore GM dashing_gpu on Debug ANGLEGravatar commit-bot@chromium.org2013-11-14
| | | | | | | | | | | BUG=Skia:1844 R=robertphillips@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/72993002 git-svn-id: http://skia.googlecode.com/svn/trunk@12297 2bbb7eff-a529-9590-31e7-b0007b416f81
* Pdfviewer refactoring.Gravatar scroggo@google.com2013-11-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mostly superficial changes, to help me make sure I understand the code while making modifications. SkPdfRenderer: First class I'm modifying. Move it into include/ and src/ directories. Inherit from SkNoncopyable. Replace load() with factory function which returns NULL if the load fails. Remove unload() and loaded(), which no longer make sense, since the factory will return NULL on a failure to load, and unload() happens on destruction. Use a const char* for loading a PDF, following the convention of SkStream::NewFromFile. Remove unnecessary call to sqrt in SkPDFNativeRenderToBitmap. Also in SkPDFNativeRenderToBitmap, use an appropriate SkScalar macro to convert to an integer. Use this-> when calling member functions. pdf_viewer_main.cpp: Call the new interface for SkPdfRenderer. gyp files: Refer to the new location of SkPdfRenderer. R=edisonn@google.com Review URL: https://codereview.chromium.org/59493011 git-svn-id: http://skia.googlecode.com/svn/trunk@12296 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add missing functions to SkNWayCanvasGravatar commit-bot@chromium.org2013-11-14
| | | | | | | | | | | R=reed@google.com BUG=none Author: enne@chromium.org Review URL: https://codereview.chromium.org/65513003 git-svn-id: http://skia.googlecode.com/svn/trunk@12295 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove suppression of blurrect_outerGravatar robertphillips@google.com2013-11-14
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12294 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline blurrect_outer imagesGravatar robertphillips@google.com2013-11-14
| | | | | | | | https://codereview.chromium.org/70103015/ git-svn-id: http://skia.googlecode.com/svn/trunk@12293 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix warnings and Win only error in pdf_viewer.Gravatar scroggo@google.com2013-11-14
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12292 2bbb7eff-a529-9590-31e7-b0007b416f81
* increase coverage of SkPath.cpp, remove unused codeGravatar commit-bot@chromium.org2013-11-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using Mike Klein's excellent coverage tool, increase the unit testing of SkPath.cpp from 70% to 95%. Along the way, determined that these functions were not maintained or used: SkPath::pathTo SkPath::contains as well as a large block of SkPath::cheapGetDirection(). Changed SkPath::validate() to permit infinities in the path data points. Fixed errors in preserving direction. Fixed error setting direction when convexity is unknown. Added missing conic to moveTo only detector. BUG= R=bsalomon@google.com, reed@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/65493004 git-svn-id: http://skia.googlecode.com/svn/trunk@12291 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline and re-enable rrect_aa, rrect_bw, simpleaaclip_aaclip, ↵Gravatar jvanverth@google.com2013-11-14
| | | | | | simpleaaclip_path, strokerect, strokes_round git-svn-id: http://skia.googlecode.com/svn/trunk@12290 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-09 02:05:09 +0000