aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public APIGravatar msarett2016-04-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918873002 Review URL: https://codereview.chromium.org/1918873002
* SkStringPrintf and SkString::printf now are no longer limted by a static bufferGravatar halcanary2016-04-25
| | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1403803002 Committed: https://skia.googlesource.com/skia/+/606cadd5aac62299ef2e277709b3684cae2bf96c Review URL: https://codereview.chromium.org/1403803002
* simplify handle-affine: subclass overrides just describe their leaf behaviorGravatar reed2016-04-25
| | | | | | | | | added new test case (that would have failed before) of blur with a colorfilter input BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915943002 Review URL: https://codereview.chromium.org/1915943002
* Whitespace change.Gravatar herb2016-04-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915073002 Review URL: https://codereview.chromium.org/1915073002
* Whitespace changeGravatar stephana2016-04-25
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920893002 TBR=borenet NOTREECHECKS=true Review URL: https://codereview.chromium.org/1920893002
* Revert of Call SkGraphics::Init() automatically for Google3 processes. ↵Gravatar benjaminwagner2016-04-25
| | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1906813002/ ) Reason for revert: Fixed in a different way in internal cl/120632580. Original issue's description: > Call SkGraphics::Init() automatically for Google3 processes. > > This is logically a partial revert of https://codereview.chromium.org/1903503002. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906813002 > > Committed: https://skia.googlesource.com/skia/+/868060602975834c33eb33a937545c6af8ac8395 TBR=mtklein@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Review URL: https://codereview.chromium.org/1916793002
* Fix kSubset_Mode tests on non-native swizzlesGravatar msarett2016-04-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918813002 Review URL: https://codereview.chromium.org/1918813002
* Revert of Batch multiple single NVPR draw paths to instanced draws (patchset ↵Gravatar stephana2016-04-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #5 id:80001 of https://codereview.chromium.org/1908433002/ ) Reason for revert: This causes what looks like significantly wrong results. Here is an example: https://gold.skia.org/diff?test=stroke-fill&left=cb47dc2cabbad7d146aedaac199ebace&top=2c6e65d597c574e3bb170a19ca9634c6 Original issue's description: > Batch multiple single NVPR draw paths to instanced draws > > Batch multiple single NVPR draw paths to instanced draws. > A draw path batch can be combined to other batch if the > batches do not overlap and have same draw characteristics. > > Join the batches in linked list and flatten the list to a > path list during draw time. > > Replace GrPathRendering::drawPath with GrPathRendering::drawPaths. > > Perf changes ARM, Shield TV device, Tegra X1 GPU: > desk_chalkboard.skp_1 21.5ms -> 17.8ms 0.83x > desk_mapsvg.skp_1 7.49ms -> 6.18ms 0.82x > Others results are more volatile. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908433002 > > Committed: https://skia.googlesource.com/skia/+/3c33c389e9f8d14d86756ea1ddeba2097f31ad22 TBR=joshualitt@chromium.org,bsalomon@google.com,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1919843002
* Make SkDrawable an SkFlattenableGravatar msarett2016-04-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911403004 Review URL: https://codereview.chromium.org/1911403004
* Use BUILD_TYPE in cmake_build.Gravatar rmistry2016-04-25
| | | | | | | | | | | Build files were directly written to the out directory. This change makes them go to the expected out/{Release, Debug} directory. BUG=skia:5160 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916773002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review URL: https://codereview.chromium.org/1916773002
* "Using Skia" tutorial: googlecode -> googlesourceGravatar borenet2016-04-25
| | | | | | | | | BUG=skia:5212 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915013002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1915013002 Review URL: https://codereview.chromium.org/1915013002
* Batch multiple single NVPR draw paths to instanced drawsGravatar kkinnunen2016-04-25
| | | | | | | | | | | | | | | | | | | Batch multiple single NVPR draw paths to instanced draws. A draw path batch can be combined to other batch if the batches do not overlap and have same draw characteristics. Join the batches in linked list and flatten the list to a path list during draw time. Replace GrPathRendering::drawPath with GrPathRendering::drawPaths. Perf changes ARM, Shield TV device, Tegra X1 GPU: desk_chalkboard.skp_1 21.5ms -> 17.8ms 0.83x desk_mapsvg.skp_1 7.49ms -> 6.18ms 0.82x Others results are more volatile. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908433002 Review URL: https://codereview.chromium.org/1908433002
* Compute bounds union while combining path range draw path batchesGravatar kkinnunen2016-04-24
| | | | | | | | | Compute bounds union while combining batches generated by NVPR device independent text code-path. Otherwise the overlap test of the GrDrawTarget::recordBatch violate painter's algorithm order. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1894973008 Review URL: https://codereview.chromium.org/1894973008
* Update DNG SDK versionGravatar yujieqin2016-04-24
| | | | | | | | | * Add PATENTS file BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1897773003 Review URL: https://codereview.chromium.org/1897773003
* Update SKP versionGravatar update-skps2016-04-24
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918653002 Review URL: https://codereview.chromium.org/1918653002
* allow imagefilter to manage CTM decompositionGravatar reed2016-04-23
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908173006 Review URL: https://codereview.chromium.org/1908173006
* Remove SkCanvas::LayerIter guardGravatar robertphillips2016-04-23
| | | | | | | | | | The LayerIter is no longer required by the Bazel build. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917693002 Review URL: https://codereview.chromium.org/1917693002
* Support the non-native (RGBA/BGRA) swizzleGravatar msarett2016-04-22
| | | | | | | BUG=skia:4456 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1907593004 Review URL: https://codereview.chromium.org/1907593004
* Use SkEncodedInfo in place of SkSwizzler::SrcConfigGravatar msarett2016-04-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911613002 Review URL: https://codereview.chromium.org/1911613002
* Enable flattening/unflattening with custom unflatten procsGravatar msarett2016-04-22
| | | | | | | | | | | | | | | | | | Now flattenables are serialized using a string name, so that flattenables do not necessarily need to be registered before serialization. They just need to override getTypeName(). Allows custom unflatten procs to be set on the SkReadBuffer. This is optional if the flattenable is registered, but otherwise must be called. This was split off from: https://codereview.chromium.org/1837913003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858323002 Review URL: https://codereview.chromium.org/1858323002
* docs: fix fiddle image links.Gravatar jcgregorio2016-04-22
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915493004 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1915493004 TBR=hal Review URL: https://codereview.chromium.org/1915493004
* Optionally enable SkValidatingReadBuffer in SkPictureImageFilterGravatar robertphillips2016-04-22
| | | | | | | | | | The task here is to get the type of ReadBuffer being used in SkPicture::MakeFromBuffer mirrored in the down-stack SkPicturePlayback::draw call. BUG=skia:5208 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918433002 Review URL: https://codereview.chromium.org/1918433002
* skia.org: Update all fiddles for fiddle 2.0.Gravatar jcgregorio2016-04-22
| | | | | | | | | | | The images won't show up in the preview, which won't happen until I switch over to fiddle 2.0 in production later today. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1910593005 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1910593005 Review URL: https://codereview.chromium.org/1910593005
* Retract SkDevice a bit moreGravatar robertphillips2016-04-22
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905383002 Review URL: https://codereview.chromium.org/1905383002
* SkMD5: cleanup header and minor refactorGravatar halcanary2016-04-22
| | | | | | | | | | Also: I now define a non-virtual function in terms of a final virtual function. This reduces the number of actual functions while adding no overhead. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911363002 Review URL: https://codereview.chromium.org/1911363002
* Revert of SkStringPrintf and SkString::printf now are no longer limted by a ↵Gravatar halcanary2016-04-22
| | | | | | | | | | | | | | | | | | | | | | static buffer (patchset #5 id:80001 of https://codereview.chromium.org/1403803002/ ) Reason for revert: breaking something Original issue's description: > SkStringPrintf and SkString::printf now are no longer limted by a static buffer > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1403803002 > > Committed: https://skia.googlesource.com/skia/+/606cadd5aac62299ef2e277709b3684cae2bf96c TBR=tomhudson@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1908423002
* SkStringPrintf and SkString::printf now are no longer limted by a static bufferGravatar halcanary2016-04-22
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1403803002 Review URL: https://codereview.chromium.org/1403803002
* utils.gypi: remove empty file SkMD5.cppGravatar halcanary2016-04-22
| | | | Review URL: https://codereview.chromium.org/1905363002
* Remove some unnecessary #includes of SkImageFilter.hGravatar senorblanco2016-04-22
| | | | | | | | | R=robertphillips@google.com TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1907283002 Review URL: https://codereview.chromium.org/1907283002
* Fixes for SkRWBufferGravatar scroggo2016-04-22
| | | | | | | | | | | | | | | | | | | | | | | | | Do not call SkBufferHead::validate in SkROBuffer's destructor, which may be called in a separate thread from SkRWBuffer::append. validate() reads SkBufferBlock::fUsed, and append() writes to it, resulting in a data race. Update some comments to be more clear about how it is safe to use these classes across threads. Test the readers in separate threads. In addition, make sure it is safe to create a reader even when no data has been appended. Add tests for this case. Mark a parameter to SkBufferHead::validate() as const, reflecting its use. BUG=chromium:601578 BUG=chromium:605479 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1871953002 Review URL: https://codereview.chromium.org/1871953002
* SkPDF: PDF/A runtime switchGravatar halcanary2016-04-22
| | | | | | | | | | | | | TODO: remove gyp variable and modify API in SkDocument.h SkMD5 now moved into core as pdf depends on it now. BUG=skia:3110 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1891873002 Committed: https://skia.googlesource.com/skia/+/570f18b43417d73c3fbd113cc0b4258e08b14c82 Review URL: https://codereview.chromium.org/1891873002
* Refactor to separate backend object lifecycle and GpuResource budget decisionGravatar kkinnunen2016-04-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor GrGpuResource to contain two different pieces of state: a) instance is budgeted or not budgeted b) instance references wrapped backend objects or not The "object lifecycle" was also attached to backend object handles (ids), which made the code a bit unclear. Backend objects would be associated with GrGpuResource::LifeCycle, even though GrGpuResource::LifeCycle refers to the GpuResource, and individual backend objects in one GpuResource might be governed with different "lifecycle". Mark the budgeted/not budgeted with SkBudgeted::kYes, SkBudgeted::kNo. This was previously GrGpuResource::kCached_LifeCycle, GrGpuResource::kUncached_LifeCycle. Mark the "references wrapped object" with boolean. This was previously GrGpuResource::kBorrowed_LifeCycle, GrGpuResource::kAdopted_LifeCycle for GrGpuResource. Associate the backend object ownership status with GrBackendObjectOwnership for the backend object handles. The resource type leaf constuctors, such has GrGLTexture or GrGLTextureRenderTarget take "budgeted" parameter. This parameter is passed to GrGpuResource::registerWithCache(). The resource type intermediary constructors, such as GrGLTexture constructors for class GrGLTextureRenderTarget do not take "budgeted" parameters, intermediary construtors do not call registerWithCache. Removes the need for tagging GrGpuResource -derived subclass constructors with "Derived" parameter. Makes instances that wrap backend objects be registered with a new function GrGpuResource::registerWithCacheWrapped(). Removes "budgeted" parameter from classes such as StencilAttahment, as they are always cached and never wrap any external backend objects. Removes the use of concept "external" from the member function names. The API refers to the objects as "wrapped", so make all related functions use the term consistently. No change in functionality. Resources referencing wrapped objects are always inserted to the cache with budget decision kNo. BUG=594928 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862043002 Review URL: https://codereview.chromium.org/1862043002
* Add compile guard for SkCanvas::LayerIterGravatar robertphillips2016-04-21
| | | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911893002 Review URL: https://codereview.chromium.org/1911893002
* Revise WSI setup.Gravatar jvanverth2016-04-21
| | | | | | | | - Set up present queue creation correctly. - Move WSI functions to VulkanTestContext. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1899213002 Review URL: https://codereview.chromium.org/1899213002
* Guard against FramebufferStatus checks in GrGLRenderTargetGravatar robertphillips2016-04-21
| | | | | | | | BUG=skia:5200 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905063002 Review URL: https://codereview.chromium.org/1905063002
* Hide SkCanvas::LayerIterGravatar robertphillips2016-04-21
| | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1897863008 Committed: https://skia.googlesource.com/skia/+/a814000cbb0e90624a410b4359fff7f3ec66f0e0 Review URL: https://codereview.chromium.org/1897863008
* SkPathEffect.h: add SK_API where neededGravatar halcanary2016-04-21
| | | | | | | | | | | motivation: .so fiddle TBR=reed@google.com no api chages, only visibility GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908893004 Review URL: https://codereview.chromium.org/1908893004
* Fix indentation and casts in SkTArray.Gravatar bungeman2016-04-21
| | | | Review URL: https://codereview.chromium.org/1902423007
* SkCpu w/o static initializerGravatar mtklein2016-04-21
| | | | | | | | | | | | | | | | | | | | | | | | I think I cracked it. Though, this may not technically be legal C++... I've only got one definition of SkCpu::gCachedFeatures, but two different declarations: non-const in SkCpu.cpp, const elsewhere. Is this... - legal C++? - not C++ but probably works as I think? - not C++ and will probably blow up? - who knows, let's see? I have tested that the features are cached properly, read properly, and that the generated code treats SkCpu::gCachedFeatures as a global constant outside SkCpu.cpp. So it all observably works optimally. Expanding testing to more bots. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905683003 Review URL: https://codereview.chromium.org/1905683003
* gDefaultProfileIsSRGB symbol must exist in .soGravatar halcanary2016-04-21
| | | | | | | fix fiddle TBR= Review URL: https://codereview.chromium.org/1912593003
* Remove obsolete image codec colorspace hacks.Gravatar brianosman2016-04-21
| | | | | | | | | | | | | With Herb's latest change, the codecs themselves are emitting images tagged based on the new (separate) global flag. All of the changes we had here to fixup color profile type are no longer needed (and just create more confusion). This change effectively reverts the file to where it was two commits ago. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1904943003 Review URL: https://codereview.chromium.org/1904943003
* Fix code regression to more precise call.Gravatar herb2016-04-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905993002 Review URL: https://codereview.chromium.org/1905993002
* SkTArray: fix invalid reinterpret_casts over non-initialized memory.Gravatar krasin2016-04-21
| | | | | | | | | This should fix 'CFI Linux' buildbot, which is currently horribly broken: https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5115 BUG=605337 Review URL: https://codereview.chromium.org/1908763002
* Include scaler context flags (gamma and contrast boost) in the text blob ↵Gravatar brianosman2016-04-21
| | | | | | | | | | | | cache key. Fixes a bug in skiaserve when switching between L32 and S32 modes - we were reusing blobs created with the other (wrong) masks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905683004 Review URL: https://codereview.chromium.org/1905683004
* Update min Vulkan version to 1.0.8.0, and fix various bugsGravatar egdaniel2016-04-21
| | | | | | | | | | | | | | | | | | | | With updating the SDK, the debug layers also showed multiple bugs. I have fixed those as well in this CL. These include: 1. Incorrectly tracking the allocated descriptor sets from the descriptor pools 2. Using MemoryBarriers inside render passes. 3. Correctly setting the Stencil Image layout anytime we are using a render pass with a stencil attachment 4. Setting the correct aspect mask for Depth/Stencil in a barrier. TBR=bsalomon@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906623002 Review URL: https://codereview.chromium.org/1906623002
* VulkanViewer on AndroidGravatar djsollen2016-04-21
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903253003 Review URL: https://codereview.chromium.org/1903253003
* Fix data parameter for createBufferGravatar cdalton2016-04-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911703002 Review URL: https://codereview.chromium.org/1911703002
* Call SkGraphics::Init() automatically for Google3 processes.Gravatar mtklein2016-04-21
| | | | | | | | | This is logically a partial revert of https://codereview.chromium.org/1903503002. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906813002 Review URL: https://codereview.chromium.org/1906813002
* Image filters: remove SkBitmap-based cache.Gravatar senorblanco2016-04-21
| | | | | | | | | | | Also some #include cleanup. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905753002 Review URL: https://codereview.chromium.org/1905753002
* Remove stray filesGravatar robertphillips2016-04-21
| | | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1912583002 Review URL: https://codereview.chromium.org/1912583002
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-04 19:15:48 +0000