aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Clean up SkPathRef::makeSpace.Gravatar Ben Wagner2017-07-31
| | | | | | | | | | | | | Note that this does not clean up the users of this function, which may themselves be subject to other overflow issues. BUG=chromium:728936 Change-Id: I3eaa7627c3b6ff49296ea2618a0157dacdc1d9cc Reviewed-on: https://skia-review.googlesource.com/29121 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com>
* add more win/clang botsGravatar Mike Klein2017-07-31
| | | | | | | | | | | | - add a Debug builder - add Debug and Release CPU testers on GCE CQ_INCLUDE_TRYBOTS=skia.primary:Build-Win-Clang-x86_64-Debug,Test-Win2k8-Clang-GCE-CPU-AVX2-x86_64-Debug,Test-Win2k8-Clang-GCE-CPU-AVX2-x86_64-Release Change-Id: I4f2d7309b36a532683f68fbdde9c7a9aaaa861ea Reviewed-on: https://skia-review.googlesource.com/29023 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Tell clang/win to emulate MSVC 2015Gravatar Mike Klein2017-07-31
| | | | | | | | | | | | | By default it emulates your installed cl.exe, but the bots don't have one. I think the fallback is 2013, which causes all sorts of pre-C++11 problems. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Win-Clang-x86_64-Release Change-Id: I2556abe68825e58762b4172d067ba6826de5c133 Reviewed-on: https://skia-review.googlesource.com/29021 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add GrMtlUtil classGravatar Greg Daniel2017-07-31
| | | | | | | | | | | Currently just adding support functions to go back and forth between GrPixelConfigs and MTLPixelFormats. Bug: skia: Change-Id: I01a7d6877ebed87b87090ac2b920fee45dc0e856 Reviewed-on: https://skia-review.googlesource.com/29080 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Require clone() be implemented by GrFragmentProcessor subclassesGravatar Brian Salomon2017-07-31
| | | | | | | Change-Id: I66ba0978e5748806d563ff4f26000e4e0095ed24 Reviewed-on: https://skia-review.googlesource.com/29042 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* More GrPipeline cleanup.Gravatar Brian Salomon2017-07-31
| | | | | | | | | | | Remove CanCombine and AreEqual (unused) Remove isInitialized() now that pipelines are initialized at creation. Change-Id: Ibacf81d1f879c7ef9ea91a8f471c3d1df3eb2fed Reviewed-on: https://skia-review.googlesource.com/29020 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fix premul state in from_srgb in convert_with_pipelineGravatar Christopher Cameron2017-07-31
| | | | | | | | | | | | | | Without this patch, the pipeline 1. converts to unpremultiplied 2. applies the sRGB transfer assuming the pixel is premultiplied In step 2, we should assume the pixel is unpremultiplied. Bug:738517 Change-Id: Ic11fcf64faa423577ccb1cfc0cfe96feb57db09a Reviewed-on: https://skia-review.googlesource.com/28404 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Remove union from SkFontStyle.Gravatar Ben Wagner2017-07-31
| | | | | | | | | | | | | | | This is prompted by a bug in vc++ reported at https://developercommunity.visualstudio.com/content/problem/86829/constexpr-initializing-struct-in-union-only-zero-i.html Visual C++ will not properly constexpr initialize a struct inside a union. Removing this construct also allows us to avoid writing and reading from different members of a union. Change-Id: I76e069ecce77ef21b7ad3821bf9c29e1b0843618 Reviewed-on: https://skia-review.googlesource.com/28300 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add asserts to SkBlurImageFilter flatten & CreateProcGravatar Robert Phillips2017-07-31
| | | | | | | | | | | It seems rather implausible that this could be occuring but the Chrome bug seems to say otherwise. Bug: 748155 Change-Id: I8e14f1562c71da4ae80d626e4dba053d7ee13d97 Reviewed-on: https://skia-review.googlesource.com/28863 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* add a Win/Clang build botGravatar Mike Klein2017-07-31
| | | | | | | | | | BUG=skia:2679 CQ_INCLUDE_TRYBOTS=skia.primary:Build-Win-Clang-x86_64-Release Change-Id: I861366ae1340abcc67e87041904d08337b465bbe Reviewed-on: https://skia-review.googlesource.com/28864 Reviewed-by: Eric Boren <borenet@google.com>
* use -imsvc (~= -isystem) with win/clangGravatar Mike Klein2017-07-31
| | | | | | | | This should shut up any warnings in the win toolchain headers? Change-Id: I7d17bf6d63d56e66afffa557d0ed06bc3994200d Reviewed-on: https://skia-review.googlesource.com/28981 Reviewed-by: Ben Wagner <bungeman@google.com>
* Add clang_win assetGravatar Eric Boren2017-07-31
| | | | | | | | Bug: skia:2679 Change-Id: I7abffae32102a69271b23834a121c51426813e27 Reviewed-on: https://skia-review.googlesource.com/28785 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Don't draw text with zero glyph counts as pathsGravatar Jim Van Verth2017-07-31
| | | | | | | | Bug: chromium:750420 Change-Id: Ie1a62356a3263c440a94ba1fd637c12884465515 Reviewed-on: https://skia-review.googlesource.com/28862 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* clang on windows supportGravatar Mike Klein2017-07-31
| | | | | | | | | | | | | | | | | 1) Run python bin/fetch-clang-win 2) Set clang_win = "../bin/clang_win" 3) ??? 4) Profit Most changes here are to pass the right -mfoo flags to Clang to enable advanced instruction sets, or fixed warning-as-errors. BUG=skia:2679 Change-Id: Ieed145d35c209131c7c16fdd3ee11a3de4a1a921 Reviewed-on: https://skia-review.googlesource.com/28740 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add links to Analytic AA design docsGravatar Yuqian Li2017-07-31
| | | | | | | | | | No-Try: true Docs-Preview: https://skia.org/?cl=28860 Bug: skia: Change-Id: I19b4227bebba9070884b7dbf3530e6305e45aaf2 Reviewed-on: https://skia-review.googlesource.com/28860 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* longer is betterGravatar Cary Clark2017-07-31
| | | | | | | | | R=robertphillips@google.com Bug: 749315 Change-Id: Id8091a077771553b313aaf3aff20b7b37765cc53 Reviewed-on: https://skia-review.googlesource.com/28787 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* disable single threaded debugging codeGravatar Cary Clark2017-07-31
| | | | | | | | | | | | | | | | | Stroking has some debug code that is examined by StrokerTest.cpp; this test is not thread-safe. Chrome detects this in TSAN, so disable the test code in SkStroker.cpp the same way it is disabled in StrokerTest.cpp R=bsalomon@google.com Bug: 749315 Change-Id: I6e424648b4d28509789e3e4123112e0fc95e34ed Reviewed-on: https://skia-review.googlesource.com/28780 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* Initialize GrPipeline at construction.Gravatar Brian Salomon2017-07-31
| | | | | | | | Change-Id: I44bfa3553786ad197acdf807b15155e61d4e5952 Reviewed-on: https://skia-review.googlesource.com/28623 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* Some bots should only run on the master branchGravatar Eric Boren2017-07-31
| | | | | | | | Bug: skia:6556 Change-Id: Iebe8b30de70685f56b795521ccc2242b0682000b Reviewed-on: https://skia-review.googlesource.com/28660 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* fix self referencesGravatar Cary Clark2017-07-31
| | | | | | | | | | | | | | | try removing self references in method definitions. If this creates awkward wording, it can always be allowed in another CL. Also tighten rules for identifying function references in include comments. R=briansoman@google.com, caryclark@google.com TBR=reed@google.com Bug: skia:6898 Change-Id: I1a0e6b2a76dacfe71d134deb4589fb74e6611a03 Reviewed-on: https://skia-review.googlesource.com/28624 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Remove origin field from GrSurfaceGravatar Robert Phillips2017-07-31
| | | | | | | | | | | This mainly consists of rm origin from GrSurface and the wrapBackEnd* methods and then re-adding an explicit origin parameter to all the GrGpu methods that need it. Change-Id: Iabd79ae98b227b5b9409f3ab5bbcc48af9613c18 Reviewed-on: https://skia-review.googlesource.com/26363 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* automatically generate clone() methods for SkSL fragment processorsGravatar Ethan Nicholas2017-07-31
| | | | | | | | Bug: skia: Change-Id: Ib7b90f20d2b1558aad14f38f95c7c884e654c96d Reviewed-on: https://skia-review.googlesource.com/28620 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* added support for flat and noperspective modifiers in SPIR-VGravatar Ethan Nicholas2017-07-31
| | | | | | | | Bug: skia: Change-Id: I41f90464377be5de6813d6011b7e53dbac9230b6 Reviewed-on: https://skia-review.googlesource.com/26345 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Remove dead SK_SUPPORT_LEGACY_BILERP codeGravatar Florin Malita2017-07-31
| | | | | | | Change-Id: Iec5725d594cc4726ac72526a1cc62f48e35b6647 Reviewed-on: https://skia-review.googlesource.com/28640 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add caps files for metalGravatar Greg Daniel2017-07-31
| | | | | | | | | Bug: skia: Change-Id: I8e7488320d4237cf67d6ebeaad319d3de75b67e6 Reviewed-on: https://skia-review.googlesource.com/27741 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Uncomment glinterface asserts not that chrome has functionsGravatar Greg Daniel2017-07-31
| | | | | | | | Bug: skia: Change-Id: I4c90f8e6eb10389340155fcf7c76c7cb3a5163b3 Reviewed-on: https://skia-review.googlesource.com/28600 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Compute correct bounds for DrawShadowRec.Gravatar Jim Van Verth2017-07-31
| | | | | | | | Bug: skia:6880 Change-Id: Ia8b94e52eec3feb5104d2351bf7a7e6f99101deb Reviewed-on: https://skia-review.googlesource.com/26370 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* updated spirv-tools to latest versionGravatar Ethan Nicholas2017-07-31
| | | | | | | | Bug: skia: Change-Id: I6a6ee1a3d7e63981e6e9c45cf2672060e31a6213 Reviewed-on: https://skia-review.googlesource.com/25020 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Don't create GrAtlasTextBlobs for zero glyph count text draws.Gravatar Brian Salomon2017-07-31
| | | | | | | | | Bug: chromium:749472 Change-Id: I709889dd6bb06032e30cbf820ca67e7534cfac58 Reviewed-on: https://skia-review.googlesource.com/28540 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* fix capitalizationGravatar Cary Clark2017-07-31
| | | | | | | | | | | | | | | Fix 'arcs' at sentence start to Arcs. This fix corrected other capitalizations as well, and exposed some mis-capitalizations in the bmh doc. R=brianosman@google.com TBR=reed@google.com Bug: skia: Change-Id: I4d51388556f7e8ff868a9236ce76745915560327 Reviewed-on: https://skia-review.googlesource.com/28241 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Gradient stages cleanupGravatar Florin Malita2017-07-30
| | | | | | | | | | | | | Hoist the matrix setup into SkGradientShaderBase. Drop the bool return for adjustMatrixAndAppendStages(), and rename to appendGradientStages(). Change-Id: Iad412f638f86223e5af46a7d3dea6f768f52bcad Reviewed-on: https://skia-review.googlesource.com/26427 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Update SKP versionGravatar UpdateSKPs2017-07-30
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I42bf807fe84f84793a9ace7eee5e893c451a8c6a Reviewed-on: https://skia-review.googlesource.com/28520 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Remove stale SkTwoPointConicalGradient assertGravatar Florin Malita2017-07-29
| | | | | | | | | Change-Id: If46426393e5151dad4f66ee5a54341024701e87e TBR= NOTRY=true Reviewed-on: https://skia-review.googlesource.com/28500 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Don't instantiate degenerate 2pt gradientsGravatar Florin Malita2017-07-29
| | | | | | | | | We can catch the condition at construction time, no need to defer. Change-Id: I973b9e1b79998e2b334e3a91694c793882dfd65a Reviewed-on: https://skia-review.googlesource.com/26564 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com>
* Remove now-dead SK_SUPPORT_LEGACY_GRADIENT_MATRIX_MATH codeGravatar Florin Malita2017-07-29
| | | | | | | | Change-Id: I080942c44d2ce1a018ba127944c0a477af876158 TBR= Reviewed-on: https://skia-review.googlesource.com/28480 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Enable delta AA by defaultGravatar Yuqian Li2017-07-29
| | | | | | | | | | | | The earlier CL doesn't change the flag definition so it's not turned on yet. Bug: skia: Change-Id: Id278ae5fc27d703ab7f6628bed95093d32cd7d0b TBR: caryclark@google.com, fmalita@chromium.org Reviewed-on: https://skia-review.googlesource.com/28161 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* use new Stage ABI for ARMv7 tooGravatar Mike Klein2017-07-29
| | | | | | | | | | | | | | | | | | | | | | | | | ARMv7 can pass 16 floats as function arguments. We've been slicing that as 8 2-float vectors. This CL switches to 4 4-float vectors. We'll now operate on 4 pixels at a time instead of 2, at the expense of keeping the d-vectors (mostly used for blending) on the stack. It'll be interesting to see how this plays out performance-wise. One nice side effect is now both ARMv7 and ARMv8 use 4-float NEON vectors. Most of the code is now shared, with just a couple checks to use new instructions added in ARMv8. It looks like we do see a ~15% win: $ bin/droid out/monobench SkRasterPipeline_srgb 200 Before: 644.029ns After: 547.301ns ARMv8: 453.838ns (just for reference) Change-Id: I184ff29a36499e3cdb4c284809d40880b02c2236 Reviewed-on: https://skia-review.googlesource.com/27701 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* fixed a vec2 -> float2 that got missedGravatar Ethan Nicholas2017-07-28
| | | | | | | | | Bug: skia: Change-Id: I51ae880ba0949d0c71331be6ce0ff13411169191 Reviewed-on: https://skia-review.googlesource.com/28122 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Two small fixes from recent changes prepping for ↵Gravatar Brian Salomon2017-07-28
| | | | | | | | | | std::unique_ptr<GrFragmentProcessor>. Change-Id: I5d58c7a1ef27095685215eef814df204e9beb63a Reviewed-on: https://skia-review.googlesource.com/28240 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* renamed SkSL types in preparation for killing precision modifiersGravatar Ethan Nicholas2017-07-28
| | | | | | | | Bug: skia: Change-Id: Iff0289e25355a89cdc289a0892ed755dd1b1c900 Reviewed-on: https://skia-review.googlesource.com/27703 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* fix output header in bookmakerGravatar Cary Clark2017-07-28
| | | | | | | | | | | | change underscore to space if needed remove bmh_ prefix TBR=caryclark@google.com Bug: skia: Change-Id: I9d4d29c7ff91d9d29bf8740d163724f371e5e211 Reviewed-on: https://skia-review.googlesource.com/28044 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* bookmaker generated site docsGravatar Cary Clark2017-07-28
| | | | | | | | | | | | The documents were generated by running tools/bookmaker against docs/*.bmh No-Try: true Docs-Preview: https://skia.org/?cl=28002 Change-Id: I7d7dd73cdea4a234c6175646d5b8938e1af3117a Reviewed-on: https://skia-review.googlesource.com/28002 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Add Metal build botGravatar Greg Daniel2017-07-28
| | | | | | | Bug: skia:6896 Change-Id: If2ed083703e6300b9d2a86cfb298011bbf54e018 Reviewed-on: https://skia-review.googlesource.com/28180 Reviewed-by: Eric Boren <borenet@google.com>
* Add clone methods to unit test GrFragmentProcessor classesGravatar Brian Salomon2017-07-28
| | | | | | | | | Also adds testing of copying ImageStorageAccess and ref counts of proxies held by cloned FPs. Change-Id: Ia23220bf65b4df83d1c874b46d8525cc3540f716 Reviewed-on: https://skia-review.googlesource.com/28004 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Add placeholder GrMtlTypes in include/gpu/mtlGravatar Greg Daniel2017-07-28
| | | | | | | | | | | | | | This is needed since there are currently no files in the include dir, and some of our tests that check all the public headers complain if it doesn't exists. Bug: skia:6896 Change-Id: I3f70293b64b5096a55d6ba0ea5f4e6ebbfd7f62b Reviewed-on: https://skia-review.googlesource.com/28003 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Enable Delta AA by defaultGravatar Yuqian Li2017-07-28
| | | | | | | | | Bug: skia: Change-Id: I1ff9e18cc667d719d7a692555ae5c0f9cdd88993 Reviewed-on: https://skia-review.googlesource.com/27721 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@google.com>
* bookmaker initial checkinGravatar Cary Clark2017-07-28
| | | | | | | | | | | | bookmaker is a tool that generates documentation backends from a canonical markup. Documentation for bookmaker itself is evolving at docs/usingBookmaker.bmh, which is visible online at skia.org/user/api/bmh_usingBookmaker Change-Id: Ic76ddf29134895b5c2ebfbc84603e40ff08caf09 Reviewed-on: https://skia-review.googlesource.com/28000 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* Make op-level texture uploading be GrProxy-basedGravatar Robert Phillips2017-07-28
| | | | | | | Change-Id: I898d626eff059fa7c687357b536d09409a174358 Reviewed-on: https://skia-review.googlesource.com/28001 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Remove the temporary flag SK_NO_ANALYTIC_AAGravatar Yuqian Li2017-07-28
| | | | | | | | | | | We will then rebase the tests in Google3 before completely removing SK_NO_ANALYTIC_AA. Bug: skia: Change-Id: I47ec0cde78374bd53f7cdf7c0f2f6607ca6c18c2 Reviewed-on: https://skia-review.googlesource.com/27801 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Implement clone for GrLightingEffect descendantsGravatar Brian Salomon2017-07-28
| | | | | | | | | Also use sk_sp for ref management of owned light object. Change-Id: I2fa8427a9374351996c09f992f74cc83008605f1 Reviewed-on: https://skia-review.googlesource.com/28040 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 09:56:32 +0000