aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix new IT blocks ARMv8Gravatar Amaury Le Leyzour2017-04-26
| | | | | | | | | | | | | | | | | | ARMv8 specifies that an IT block should be followed by only one 16-bit instruction. * SkFloatToFix is back to a C implementation that mirrors the assembly code. * S32A_D565_Opaque_neon switched the usage of the temporary 'ip' register to let the compiler choose what is best in the context of the IT block. And replaced 'keep_dst' by 'ip' where low register or high register does not matter. BUG=skia: CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: If587110a0c74b637ae99460419d46cf969c694fc Reviewed-on: https://skia-review.googlesource.com/9346 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix uncached getROPixels from GPU imagesGravatar Brian Osman2017-04-26
| | | | | | | | | | | | | We were allocating a local bitmap, but then attempting to read into an uninitialized local pixmap. The only public API that funnels the caching hint to this function is scalePixels, so I added a test (which previously failed). Bug: skia: Change-Id: Ib4370350be664935b4c85e34c70b675e6d82ba64 Reviewed-on: https://skia-review.googlesource.com/14402 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Remove pre-allocated clip space from GrRenderTargetOpListGravatar Robert Phillips2017-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | It seems like this should be safe (perf-regression-wise) since the arena allocated clips are used infrequently. In the following, each GM run has 621 srcs and a total of 81087 ops. Each skp run has 87 srcs and a total of 14709 ops. The following table shows how many times the arena allocator is called for each config/src. Overall, I think is safe to only allocate the arena-allocated space on an as needed basis. gl-gm: 0 gl-skp: 0 gl-msaa4: 0 gl-msaa4: 0 glinst-gm: 1225 glinst-skp: 579 glnvpr4-gm: 623 glnvpr4-skp: 77 Change-Id: I78e04b060b6ad3b78697519249bb4b9c3193fc85 Reviewed-on: https://skia-review.googlesource.com/14392 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* prep for more constantsGravatar Mike Klein2017-04-26
| | | | | | | | | | | | | - Add -z to print zero bytes instead of ... - avx+hsw will create 32-byte constants in .const, so we should disassemble those too, and align to 32 bytes. - The default _text section on Windows is 16-byte aligned, so we make a new one that's 32-byte aligned. Change-Id: Icb2a962baa4c3735e98a992f2285eaf5cb1680fd Reviewed-on: https://skia-review.googlesource.com/14364 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* add SkLightingColorFilter for makeColorSpace()Gravatar Mike Klein2017-04-26
| | | | | | | | | | | | | This implementation should be identical to the previous one, except we remember that the inputs to our matrix were colors and transform them if so requested. This fixes the GM lightingcolorfilter in gbr-8888 config. Change-Id: Iea0d1079e1c0f5515019b3a4786fc5387dac92ff Reviewed-on: https://skia-review.googlesource.com/14378 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com>
* Add releaseAndAbandonGpuContext botGravatar Eric Boren2017-04-26
| | | | | | | | Bug: skia:5142 Change-Id: I35bd42d1a9da2293092a2f09aaaf523a0f36537a Reviewed-on: https://skia-review.googlesource.com/14376 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* SkColorFilter::makeColorSpace()Gravatar Mike Klein2017-04-26
| | | | | | | Change-Id: Idea4afac67ef348c2f4e64f4fe6a03704a86652f Reviewed-on: https://skia-review.googlesource.com/14375 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkPngCodec: Do not return kInvalidConversion on corrupt pngGravatar Matt Sarett2017-04-26
| | | | | | | | | | | In this case, the fuzzer thinks there is a bug because we are returning kInvalidConversion for a corrupt png file. Bug: skia:6550 Change-Id: I33f588442f5eaa8a4d642e9328750779f9a9ef5d Reviewed-on: https://skia-review.googlesource.com/14324 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Remove GrResourceProvider & GrGpu pointers from GrRenderTargetOpListGravatar Robert Phillips2017-04-26
| | | | | | | | | Additional shrinking of GrRenderTargetOpList since there will soon be more of them. Change-Id: Ib3e68fdf3462838baf7a5a2644e418be066cf79c Reviewed-on: https://skia-review.googlesource.com/14363 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Respect cropRect in SkDropShadowImageFilter::onMakeColorSpace()Gravatar Matt Sarett2017-04-26
| | | | | | | | Bug: skia:6516 Change-Id: Iec940c585654d0c45aa8de7743c270bd54f6af7a Reviewed-on: https://skia-review.googlesource.com/14370 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* broke up SkSLConstantFolding testGravatar Ethan Nicholas2017-04-26
| | | | | | | | Bug: skia: Change-Id: I496a6d1c82b4d3b6fdb34671de373c34abe90018 Reviewed-on: https://skia-review.googlesource.com/14321 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Describe GCC-like asm steps as "assemble ..."Gravatar Mike Klein2017-04-26
| | | | | | | | | Oddly, the MSVC toolchain already says "assemble ...". Change-Id: Iabf06afa1b7c05b5699a26813f1469346be439a5 Reviewed-on: https://skia-review.googlesource.com/14367 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Hardwire opList lookAhead & lookBack parametersGravatar Robert Phillips2017-04-26
| | | | | | | | | | If/when we double check these settings we can either re-add these parameters or change the code manually. The driving goal here is to shrink GrRenderTargetOpList. Change-Id: I7819de18f97e8282e8754e3438130f797ebb3c37 Reviewed-on: https://skia-review.googlesource.com/14381 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* remove to_2dot2 and from_2dot2Gravatar Mike Klein2017-04-26
| | | | | | | | | | The parametric_{r,g,b} stages are just as good now; under the hood it's all going through approx_powf. Change-Id: If7f3ae1e24fcee2ddb201c1d66ce1dd64820c89a Reviewed-on: https://skia-review.googlesource.com/14320 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove SK_IGNORE_GASP_VERSION_CHECK.Gravatar Ben Wagner2017-04-26
| | | | | | | | | All users have now been updated and this define is no longer used. Change-Id: Ib701b6e31f7c0958eed3d97e033b334e09fa9bb0 Reviewed-on: https://skia-review.googlesource.com/14365 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Link to vulkan in tools but not library.Gravatar Brian Salomon2017-04-26
| | | | | | | | | This also now requires an explicit vulkan proc address getter to be used with GrVkBackendContext::Create. Change-Id: I768ec487398dab68e6e10409419ac7a00ec1822a Reviewed-on: https://skia-review.googlesource.com/14322 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Prevent creation of zero-sized proxiesGravatar Robert Phillips2017-04-26
| | | | | | | | | | | | | This wasn't seen locally b.c. it is an assert and I only ran release locally and the CQ also only runs release. I have added linux_trusty_blink_dbg as a try job. TBR=bsalomon@google.com Bug: 715392 Change-Id: I010626cb97e886d2fbfd767f948bc640f0534338 Reviewed-on: https://skia-review.googlesource.com/14361 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Make SkNoncopyable movableGravatar Chris Blume2017-04-26
| | | | | | | | | | | | | | | | | | | | SkNoncopyable declares (but does not define) its copy constructor and copy assignment operator. These are also private so the error for misuse happens at compile-time instead of link-time. However, this seems to be from before C++11. Because other constructors were declared, the compiler does not generate a move constructor or a move assignment operator. The result of this is perfectly legal non-copying scenarios are also accidentally blocked. An example of this is returning the non-copyable type. The object being returned is a candidate for a move, since it is about to be destroyed. And in C++17 copy elision is actually guaranteed. Change-Id: Ia31be9091c644f31a45dd18216330a68be3cf456 Reviewed-on: https://skia-review.googlesource.com/14294 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Inject a dsb into SkAnalyticEdge::setLine() to work around ARMv7 CPU erratum.Gravatar Mike Klein2017-04-25
| | | | | | | | | BUG=chromium:710131 Change-Id: I4568bc24cc8fabb6f9df3b7645b01a98e11791b8 Reviewed-on: https://skia-review.googlesource.com/14062 Reviewed-by: Doug Anderson <dianders@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove SkOpts::run_pipeline() declaration.Gravatar Mike Klein2017-04-25
| | | | | | | | | | | I missed this while removing SkRasterPipeline_opts.h. It's just a declaration... this won't change any generated code. Change-Id: I66f6e9fe5341e9ff6a91981da9275c944a63fee9 Reviewed-on: https://skia-review.googlesource.com/14325 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update PixelC to latest build.Gravatar Ben Wagner2017-04-25
| | | | | | | | | Bug: skia: No-Try: true Change-Id: I1d9a6a7c1d1e0ca11abac4c3334eafe021fc825f Reviewed-on: https://skia-review.googlesource.com/14302 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add ability to relinquish control of VkDevice and VkInstance lifetime to ↵Gravatar Brian Salomon2017-04-25
| | | | | | | | | GrVkBackendContext Change-Id: I355a8bf573a84b4ba7cbfeed60feec13e251b352 Reviewed-on: https://skia-review.googlesource.com/14303 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* sksl can now fold constant vector or matrix equality expressionsGravatar Ethan Nicholas2017-04-25
| | | | | | | | Bug: skia: Change-Id: Icaddae68e53ed3629bcdc04b5f0b541d9e4398e2 Reviewed-on: https://skia-review.googlesource.com/14260 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Fix writePixels of sRGB data to legacy GPU surfaceGravatar Brian Osman2017-04-25
| | | | | | | | | | Adjusted unit test to verify this behavior. Bug: skia:6547 chromium:713632 chromium:713702 Change-Id: I6240937b2faf6ccb6adfc9477dc85ae961cdbbb7 Reviewed-on: https://skia-review.googlesource.com/14279 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add GrVkInterface constructor with sepereate instance/device proc getters.Gravatar Brian Salomon2017-04-25
| | | | | | | Change-Id: I8498c711ee1fa1cded71e4a7a63317a4b125272b Reviewed-on: https://skia-review.googlesource.com/14277 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Disable msaa on all current iOS devicesGravatar Stephan Altmueller2017-04-25
| | | | | | | | Bug: skia: Change-Id: I6b46f6e448b52a4473c5c16342ebe002b6818c8a Reviewed-on: https://skia-review.googlesource.com/14301 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Use system Vulkan headers except when no building with vulkan supportGravatar Greg Daniel2017-04-25
| | | | | | | | | | | | We now will always use the system vulkan.h files whenever we are building with vulkan. With non vulkan builds we use our checked in header to so that we can get the needed symbols for compiling. Bug: skia: Change-Id: I352a3e007b33c575cefcfd6752db0b3b12b86a16 Reviewed-on: https://skia-review.googlesource.com/14270 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Make SkColorSpaceXformer::apply(SkPaint) safe to call recursivelyGravatar Matt Sarett2017-04-25
| | | | | | | | | | | | | Before, we would stomp on the original paint in the recursive call. This fixes 4 gbr-8888 gms. Currently, this only affects loopers and SkPaintImageFilter. Bug: skia:6516 Change-Id: Ic47d637a912370c0a1ae8ef3282ad7d15d9902e3 Reviewed-on: https://skia-review.googlesource.com/14182 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove compressed texture support from cacheratorGravatar Brian Osman2017-04-25
| | | | | | | | | | | All variants of (on)?[rR]efEncoded(Data)? no longer need a GrContext parameter. Bug: skia:5485 skia:4971 Change-Id: If4f5e785718d5522eb3df8588318ccb8a02a5749 Reviewed-on: https://skia-review.googlesource.com/14269 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Improve variation comment for iOS.Gravatar bungeman2017-04-25
| | | | | | | | | | | | CTFontCopyVariationAxes returns nullptr for fonts which began life with CGFontCreateWithDataProvider on macOS 10.10 and earlier and iOS 9 and earlier. The issue was fixed in maxOS 10.11 and iOS 10. Improve the existing comments to make this clear. Change-Id: I0de1734e266d30aab7d38d0dd752f66259f677d9 Reviewed-on: https://skia-review.googlesource.com/14278 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* xform saveLayer() backdropGravatar Mike Klein2017-04-25
| | | | | | | | | | | | | Just noticed this TODO is easy now. This doesn't seem to change any GMs, and definitely isn't used by Chrome or Android... this is just for completeness. It's also definitely correct to unfurl pictures. Change-Id: Ida6e43788d1de7a9452dad47aea8a5fbe41a1f46 Reviewed-on: https://skia-review.googlesource.com/14276 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com>
* Enable ios on Raspberry PiGravatar Stephan Altmueller2017-04-25
| | | | | | | | | | | Adds more jobs to iOS testing and switches to RPi based hosts. Bug: skia: Change-Id: I0124c6554173fa3b22b077a198612bb30691d1fb Reviewed-on: https://skia-review.googlesource.com/11521 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Balance save()/restore() calls in dont_clip_to_layer gmGravatar Matt Sarett2017-04-25
| | | | | | | | Bug: skia:6516 Change-Id: Id09336def938f6e4da028807912494cdae5f3734 Reviewed-on: https://skia-review.googlesource.com/14190 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* Delete SkGTypeface and SkGScalerContextGravatar Matt Sarett2017-04-25
| | | | | | | | Bug: skia: Change-Id: I6a513d0cb3600678bc3b9c2bdfa8e04d692e9acf Reviewed-on: https://skia-review.googlesource.com/14191 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* SkMergeImageFilter: fModes might be nullptrGravatar Matt Sarett2017-04-25
| | | | | | | | | Bug:714994 Change-Id: Ib8349e8fc0aba455472035c9a4e873a1720b73e0 Reviewed-on: https://skia-review.googlesource.com/14267 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Name 'client' parameter so comment makes senseGravatar Brian Osman2017-04-25
| | | | | | | | | | Feedback from https://skia-review.googlesource.com/c/14192/ Bug: skia: Change-Id: I8f1f1b57aabb37c476d244414b3b2fa8693594bd Reviewed-on: https://skia-review.googlesource.com/14266 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* SkDiscardableMemoryPool: modernizeGravatar Hal Canary2017-04-25
| | | | | | | | | | * Use unique_ptr, sk_sp, SkAutoFree, using. * Rely on thread-safe static global initializion. Change-Id: I7c14e0e57622163b1b81b97a218b816fe6d02926 Reviewed-on: https://skia-review.googlesource.com/13818 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Improve the Codec_end test and add fixesGravatar Leon Scroggins III2017-04-25
| | | | | | | | | | | | | | | | | | | Better imitate the original Android bug. Create a stream with multiple images in it, and verify that it successfully decodes after decoding once. This exposes a bug in SkPngCodec, which did not work for interlaced images. Test more formats that also happen to succeed: ICO, BMP, and WBMP This explicitly does *not* attempt to fix sampled or subset decodes, which already stopped early when decoding as an optimization. Change-Id: Ib0b8918f14ba3fb0fa31e9c71c8100dcbeeb465f Reviewed-on: https://skia-review.googlesource.com/14104 Reviewed-by: Matt Sarett <msarett@google.com>
* Rm makeRenderTargetContext in favor of deferred version (take 3)Gravatar Robert Phillips2017-04-25
| | | | | | | | | | | This is a reland of: https://skia-review.googlesource.com/c/13001/ (Rm makeRenderTargetContext in favor of deferred version) TBR=bsalomon@google.com Change-Id: If81f4d9fb889c091cd37ffde133d906fb3e37773 Reviewed-on: https://skia-review.googlesource.com/14027 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Add new GrVkBackendContext::Create explicitly requiring vk proc gettersGravatar Brian Salomon2017-04-24
| | | | | | | | | Also remove the feature of GrVkGpu that creates the instance/device if the client doesn't provide one. Change-Id: Ie617313b6c684ed355333a475b80d0aae7e3a026 Reviewed-on: https://skia-review.googlesource.com/14261 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* [recipes] Fix *_VERSION step failure handlingGravatar Eric Boren2017-04-24
| | | | | | | | | | Bug: skia:6473 Change-Id: I2fa6f800f59f40f74b5c080c52cdec3a32329ef7 NOTRY=true Reviewed-on: https://skia-review.googlesource.com/14240 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Simplify SkImageCacherator slightlyGravatar Brian Osman2017-04-24
| | | | | | | | | | | | | | - lockAsBitmap supported reading back textures to a bitmap, but this was only used by one GM. Removed all of that code, and merged the two bitmap functions together. - To make the GM cleaner, don't use SkImageCacherator directly - construct actual images. Bug: skia: Change-Id: Iad17184a02a72f89ccc851fa158764d6c871befa Reviewed-on: https://skia-review.googlesource.com/14192 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Only respect version 1 gasp tables for symmetric.Gravatar Ben Wagner2017-04-24
| | | | | | | | | | When determining whether or not to use symmetric rendering, only look at the gasp table if it's version 1. Change-Id: Ib64ec1853545eb2c467a9e280d9e00f51e8b0aa8 Reviewed-on: https://skia-review.googlesource.com/13863 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Dominik Röttsches <drott@google.com>
* [recipes] Add env recipe moduleGravatar Eric Boren2017-04-24
| | | | | | | | | | | | | | | | Simplifies the process of nesting environments. Usage: with api.env({'myvar': 'myval'}): # do stuff Same as api.step.context but specialized for just environment and merges PATH variable intelligently. Bug: skia:6473 Change-Id: I5769c69cbbbcdab0c6298cee6c5e1fe9caf89c78 Reviewed-on: https://skia-review.googlesource.com/14189 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Revert "Split up opLists (take 2)"Gravatar Robert Phillips2017-04-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit df2bf213649e0b2bcb9402548af9976bbdf7a218. Reason for revert: Maybe AndroidOne timing out Original change's description: > Split up opLists (take 2) > > Reland of: https://skia-review.googlesource.com/c/11581/ (Split up opLists) > > https://skia-review.googlesource.com/c/13860/ (Make InstancedRendering more opList-splitting friendly) has landed so this should be good for another attempt. > > Change-Id: Icc9998196587510328e0a9ca1b2ce42013a86c6c > Reviewed-on: https://skia-review.googlesource.com/13802 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I744f2a3145b294e5911862bb39d57ca33a1b9a5a Reviewed-on: https://skia-review.googlesource.com/14184 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Remove a print statement I meant to not check inGravatar Leon Scroggins III2017-04-24
| | | | | | | | | | TBR=msarett@google.com Change-Id: I8861e7b0c7e7135c872cbcd5a9b53531acdb30dd Reviewed-on: https://skia-review.googlesource.com/14181 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Fix decoding incomplete PNG imagesGravatar Leon Scroggins III2017-04-24
| | | | | | | | | | | | | | | If process_data is unable to read (and therefore process) as many bytes as it expects, process the bytes read before returning false. Fixes differences in Gold. Add a test that verifies that it is okay to call png_process_data with 0 bytes. (We could special case 0, but libpng already checks for 0.) Change-Id: Id500b9305ee3bb6a1a7e8fc70d4e723cb4742b55 Reviewed-on: https://skia-review.googlesource.com/14144 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Split up opLists (take 2)Gravatar Robert Phillips2017-04-24
| | | | | | | | | | | Reland of: https://skia-review.googlesource.com/c/11581/ (Split up opLists) https://skia-review.googlesource.com/c/13860/ (Make InstancedRendering more opList-splitting friendly) has landed so this should be good for another attempt. Change-Id: Icc9998196587510328e0a9ca1b2ce42013a86c6c Reviewed-on: https://skia-review.googlesource.com/13802 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Fix spelling of SkImageGenerator in commentGravatar Brian Osman2017-04-24
| | | | | | | Bug: skia: Change-Id: Ibc6698b4db8aabeb14224d2c3ec8412f7ecfecb9 Reviewed-on: https://skia-review.googlesource.com/14146 Reviewed-by: Brian Osman <brianosman@google.com>
* Remove two more gpu headers from include/*Gravatar Robert Phillips2017-04-24
| | | | | | | | | | | This is probably it until GrTexture.h can be hidden. TBR=bsalomon@google.com Change-Id: Ie743c937f72aa0dc9f5e84def572f655f0abe041 Reviewed-on: https://skia-review.googlesource.com/14143 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-06 14:08:38 +0000