| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/335603003/)
Reason for revert:
Caused many shadertext GM failures
Original issue's description:
> Fix SkPaint::measureText for stroked hairline text
>
> SkPaint::measureText and text drawing used different criteria for
> determining whether text should be drawn as paths or not.
>
> Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> positioning in the rendering. Mainly added in order to define what is the
> expected text rendering when hairline stroke is used with various transform
> options.
>
> The testcase also tries to note or highlight the fact that SkPaint::measureText
> is not expected to produce intuitively matching results when compared to a
> rendering, if the rendering is done so that the device ends up having a device
> transform.
>
> This fixes the glyph_pos_h_s (hairline, stroked) test-case.
>
> Ignore shadertext2_pdf-poppler.png gm on
> Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
>
> Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793
R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com
TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/354433002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add OpenGL ES extension functions needed to support NV_path_rendering in OpenGL
ES.
The added glProgramPathFragmentInputGenNV call is defined in NV_path_rendering
revision 30, similar to following:
Append to the end of the "Shader Inputs" subsection of Section 3.12.2
"Shader Execution":
The command
void ProgramPathFragmentInputGenNV(uint program,
int location,
enum genMode,
int components,
const float *coeffs);
controls how a user-defined (non-built-in) fragment input of a
GLSL program object is computed for fragment shading operations that
occur as a result of CoverFillPathNV or CoverStrokePathNV.
/program/ names a GLSL program object. If /program/ has not been
successfully linked, the error INVALID_OPERATION is generated.
The given fragment input generation state is loaded into the fragment
input variable location identified by /location/. This location
is a value returned either by GetProgramResourceLocation with a
/programInterface/ of FRAGMENT_INPUT_NV and a given fragment shader
input variable name or by GetProgramResourceiv with FRAGMENT_INPUT_NV
for the /programInterface/ and LOCATION for the property for a given
fragment input resource index.
....
glProgramPathFragmentInputGenNV will be used instead of glPathTexGen,
because the latter depends on fixed function pipeline that is not
exposed in ES.
Also add glGetProgramResourceLocation from OpenGL 4.3 or
ARB_program_interface_query.
Also add FRAGMENT_INPUT define to be used with glGetProgramResourceLocation.
The added functions are not used yet, but they're needed when implementing
NV_path_rendering support for OpenGL ES. They can also be used on OpenGL.
Remove uncalled NV_path_rendering functions, so they do not cause confusion
or take space in the interface definition. The ones that are later used
can be re-added when needed.
Remove definitions NV_path_rendering that are for NV_path_rendering function
parameters that are not used. The ones that are later used
can be re-added when needed.
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/345723002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support using OpenGL ES context on desktop for unix and Android platforms. This
is mainly useful in development.
Add --gpuAPI flag to gm, dm, bench, bench_pictures and render_pictures. The
possible parameters for the flag are "gl" and "gles".
R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/319043005
|
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/352473002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkPaint::measureText and text drawing used different criteria for
determining whether text should be drawn as paths or not.
Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
positioning in the rendering. Mainly added in order to define what is the
expected text rendering when hairline stroke is used with various transform
options.
The testcase also tries to note or highlight the fact that SkPaint::measureText
is not expected to produce intuitively matching results when compared to a
rendering, if the rendering is done so that the device ends up having a device
transform.
This fixes the glyph_pos_h_s (hairline, stroked) test-case.
Ignore shadertext2_pdf-poppler.png gm on
Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
R=jvanverth@google.com, reed@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/335603003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
target.
"flags" target does it by direct_dependent_settings which exports the
include_dirs to targets that depend on it.
Along the way fixed the indentation of experimental.gyp and v8.gyp.
BUG=None
TEST=make all
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/343283002
|
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/345933004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This declares a static library target in gyp/sk_tool_utils.gyp, so other
targets can depend directly on it instead of including the source file
in their source lists.
BUG=None
TEST=make all
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/348623006
|
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/348183003
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9efd66b8451f25465abd1027e09a3bcfa7b9c554.
R=reed@google.com
TBR=reed@google.com
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/348903004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on mac/clang, using circularclips gm/bench
- before: 400ms
- after: 250ms
BUG=skia:
R=tomhudson@chromium.org, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/348143002
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/342403002
|
|
|
|
|
|
|
|
|
|
|
| |
Original Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=901208
R=reed@google.com, mtklein@google.com, reed1
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/337853003
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=reed@google.com, bsalomon@google.com, tfarina@chromium.org
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/325843002
|
|
|
|
|
|
|
|
| |
R=bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/347673002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/337923004
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/341313002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=krajcevski@google.com, rmistry@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/345183003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks a bunch of circular dependencies between tools and gm and bench.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot
R=tfarina@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/344213003
|
|
|
|
|
|
|
|
| |
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/348113002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/344213003/)
Reason for revert:
GpuTimer broken
Original issue's description:
> Move BenchTimer to tools as Timer
>
> This breaks a bunch of circular dependencies between tools and gm and bench.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed
R=tfarina@chromium.org, mtklein@chromium.org
TBR=mtklein@chromium.org, tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/346753003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In keeping with the FreeType and Mac scaler contexts, do not artificially
round already subpixel metrics.
The subpixel flag should be the 'forceSubpixel' flag when it comes to
metrics. Existing backends will give subpixel metrics when 'subpixel' is
requested, but will not round proper metrics when 'subpixel' is not
requested.
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/344253002
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks a bunch of circular dependencies between tools and gm and bench.
BUG=skia:
R=tfarina@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/344213003
|
|
|
|
|
|
|
|
|
| |
BUG=374398
R=reed@google.com, bsalomon@google.com, rmistry@google.com, borenet@google.com
Author: sheyang@chromium.org
Review URL: https://codereview.chromium.org/346853004
|
|
|
|
|
|
|
|
| |
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/338973006
|
|
|
|
|
|
|
|
|
| |
TBR=bsalomon@google.com
BUG=skia:
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/347103003
|
|
|
|
|
|
|
|
| |
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/349623004
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
not waiting for (dead?) win builder
NOTRY=True
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/348063002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=reed@google.com, rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/334633008
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2682
NOTRY=true
R=rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/342353002
|
|
|
|
|
|
|
|
|
|
| |
This fixes an Adreno driver bug where GL programs fail to link if the FS refers to these components of gl_FragCoord.
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/345083002
|
|
|
|
|
|
|
|
|
|
|
| |
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/344853005
|
|
|
|
|
|
|
|
|
|
|
| |
confusion with OS X's maths library
BUG=skia:
R=reed@google.com
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/326623004
|
|
|
|
|
|
|
|
|
|
| |
R=bsalomon@google.com, reed@google.com
NOTREECHECKS=true
NOTRYS=true
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/347563006
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/344873004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If dithering is turned on, apply an effect that filters the pixel through
the following pipeline:
for each channel c:
1. Compute quantized colors [low, high] that c is between
2. Pick high by flipping a coin weighted by (c - low)
R=bsalomon@google.com, egdaniel@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/321253002
|
|
|
|
|
|
|
|
| |
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/338093005
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ffa9b500d7e83e7dddf6a8902f47c4355b608c30.
R=reed@google.com
TBR=reed@google.com
NOTRY=True
NOTREECHECKS=True
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/340413004
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer.
Cubics that are nearly degenerate now make it down here via the convex path renderer. They used to get filtered out by the path iterator but that was problematic. We wound up producing NaN vertices.
BUG=2677
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/338633007
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This idea came while commenting on
https://codereview.chromium.org/343583005/
Since SkBenchmark, SkBenchLogger and SkGMBench are not part of the Skia library,
they should not have the Sk prefix.
BUG=None
TEST=make all
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/347823004
|
|
|
|
|
|
|
|
|
|
| |
Also adds upload tracing for Chrome.
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/347563005
|
|
|
|
|
|
|
|
|
|
| |
These were found by the clang on Windows build.
R=mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/328303005
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop using restricted font outlines and honor don't subset restriction.
Resubmit of r12600.
R=halcanary@google.com, bungeman@google.com, reed@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/334443002
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a marker is placed using a GrContext, it will add a marker to both the
drawBuffer and gpu targets of that context.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/340893002
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plus, print out assertion failures on Windows,
and some little tweaks to CrashHandler on other platforms for consistency.
BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/340523007
|
|
|
|
|
|
|
|
|
|
|
| |
R=reed@google.com
TBR=reed@google.com
NOTRY=True
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/347693002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/343783002/)
Reason for revert:
webkit still uses getTotalClip -- need to find where they define the guard.
../../skia/ext/skia_utils_mac.mm:400:42: error: no member named 'getTotalClip' in 'SkCanvas'
const SkRegion& clipRgn = canvas_->getTotalClip();
~~~~~~~ ^
Original issue's description:
> remove guarded code - there are no more callers
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c5d5cf9489977aa6fba077d1dc242029fbb4859e
R=scroggo@google.com, reed@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/342843002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the external cache is active, do not intersect the saveLayer
bounds with the clip bounds. This is so that the cache is always the
full size of the primitive's bounds, regardless of the clip active on
first draw. (Drawing of the filtered or cached result is always drawn
against the active clip, though, since it is restored before
internalDrawDevice() is called.)
This is a slightly hacky solution, but this code can all go away
(including the external cache) once all platforms have switched to
impl-side painting.
See Chromium bug http://crbug.com/379147.
BUG=skia:
R=reed@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/340203002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/343783002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This idea emerged while doing https://codereview.chromium.org/321723002/
(commit 880914c35c8f7fc2e9c57134134c883baf66e538).
BUG=None
TEST=make tests && out/Debug/tests
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/346453002
|