aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add more valgrind suppressionsGravatar robertphillips@google.com2013-12-09
| | | | | | | | https://codereview.chromium.org/102443003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12561 2bbb7eff-a529-9590-31e7-b0007b416f81
* SkDecodingImageGenerator now uses SkStreamRewindableGravatar halcanary@google.com2013-12-09
| | | | | | | | | | | | | | | | | | This makes sense since Android will be giving us a stream and the decoders expect a stream. This also removes some glue code, DecodeMemoryToTarget, that works better using a SkImageGenerator. Motivation: This is a necessary step to move from SkImageRef to SkDiscardablePixelRef. SkImageDecoder::DecodeMemoryToTarget function removed. BUG= R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/101973005 git-svn-id: http://skia.googlecode.com/svn/trunk@12560 2bbb7eff-a529-9590-31e7-b0007b416f81
* add SkImageInfo to SkGrPixelRef constructor, to prep for larger CLGravatar reed@google.com2013-12-09
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/104923011 git-svn-id: http://skia.googlecode.com/svn/trunk@12559 2bbb7eff-a529-9590-31e7-b0007b416f81
* Just a typo. Rename StrokeRect to StrokeRects in strokerects.cpp, making it ↵Gravatar commit-bot@chromium.org2013-12-09
| | | | | | | | | | | | different from the class name in strokerect.cpp for debugging. R=bungeman@google.com, reed@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/99573004 git-svn-id: http://skia.googlecode.com/svn/trunk@12557 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-12-07
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12555 2bbb7eff-a529-9590-31e7-b0007b416f81
* gpudevice should never allocate pixels for its backendGravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | | BUG= R=bsalomon@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/109013002 git-svn-id: http://skia.googlecode.com/svn/trunk@12554 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove explicit when we have 2 argsGravatar reed@google.com2013-12-06
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12553 2bbb7eff-a529-9590-31e7-b0007b416f81
* add SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR, initially always onGravatar reed@google.com2013-12-06
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/106183007 git-svn-id: http://skia.googlecode.com/svn/trunk@12552 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert "Revert "PixelRef now returns (nearly) everything that is ↵Gravatar reed@google.com2013-12-06
| | | | | | | | | | | | | | currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""" This reverts commit 5f035e90d6dea0139a4f204b634e7b7b3b4976d7. Reverting because it breaks chrome/blink due to new SkPixelRef constructor arg. BUG= Review URL: https://codereview.chromium.org/108993002 git-svn-id: http://skia.googlecode.com/svn/trunk@12551 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert "PixelRef now returns (nearly) everything that is currently ↵Gravatar reed@google.com2013-12-06
| | | | | | | | | | | | in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."" This reverts commit 4174afb18a9746bbad2a06c0ec2d4ad35f72d790. BUG= Review URL: https://codereview.chromium.org/108723003 git-svn-id: http://skia.googlecode.com/svn/trunk@12547 2bbb7eff-a529-9590-31e7-b0007b416f81
* Additional SampleApp tiling options.Gravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | | | | | | | | | | Adding some more tiling options (both relative and fixed size): kNo_Tiling, kAbs_128x128_Tiling, kAbs_256x256_Tiling, kRel_4x4_Tiling, kRel_1x16_Tiling, kRel_16x1_Tiling, R=bungeman@google.com, reed@google.com, fmalita@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/108213004 git-svn-id: http://skia.googlecode.com/svn/trunk@12545 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fixed a few places where uninitialized memory could have been readGravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | | | | Also added early exit in SkImageFilter's constructor to avoid attempting to deserialize all inputs once a bad input has been found. This avoids hanging if a filter pretends to have 1 billion inputs when that's just an error on the number of inputs read by the filter. BUG=326206,326197,326229 R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/106943002 git-svn-id: http://skia.googlecode.com/svn/trunk@12544 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add GM to test bitmap shaders with basic geometry and bitmap masks.Gravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | R=reed@google.com, bsalomon@google.com, rmistry@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/98433004 git-svn-id: http://skia.googlecode.com/svn/trunk@12543 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "PixelRef now returns (nearly) everything that is currently in ↵Gravatar reed@google.com2013-12-06
| | | | | | | | | | | | SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap." This reverts commit 154e08b2f5904ef533da694e3510befcb9a3f3e2. revert due to warnings Review URL: https://codereview.chromium.org/108513003 git-svn-id: http://skia.googlecode.com/svn/trunk@12538 2bbb7eff-a529-9590-31e7-b0007b416f81
* PixelRef now returns (nearly) everything that is currently in SkBitmap. The ↵Gravatar reed@google.com2013-12-06
| | | | | | | | | | goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap. R=mtklein@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/68973005 git-svn-id: http://skia.googlecode.com/svn/trunk@12537 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix #define for distance field fontsGravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | R=robertphillips@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/108413002 git-svn-id: http://skia.googlecode.com/svn/trunk@12536 2bbb7eff-a529-9590-31e7-b0007b416f81
* Nobody knows the rebaselines I've seen...Gravatar jvanverth@google.com2013-12-06
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12535 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting 12528 & 12533 (Implement srcRect and dstRect functionality in ↵Gravatar robertphillips@google.com2013-12-06
| | | | | | | | | | SkBitmapSource) due to image differences on N4 https://codereview.chromium.org/108623002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12534 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix Windows compiler warnings/errorsGravatar robertphillips@google.com2013-12-06
| | | | | | | | https://codereview.chromium.org/108563002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12533 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test CQ.Gravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | | | | | | (SkipBuildbotRuns) BUG= TBR=borenet@google.com NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/108553002 git-svn-id: http://skia.googlecode.com/svn/trunk@12532 2bbb7eff-a529-9590-31e7-b0007b416f81
* Generalize valgrind suppressions & a 2 moreGravatar robertphillips@google.com2013-12-06
| | | | | | | | https://codereview.chromium.org/107443004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12531 2bbb7eff-a529-9590-31e7-b0007b416f81
* commit remaining pdf-poppler GM results as unreviewed-by-humansGravatar epoger@google.com2013-12-06
| | | | | | | | | BUG=skia:1884 TBR=vandebo Review URL: https://codereview.chromium.org/103033004 git-svn-id: http://skia.googlecode.com/svn/trunk@12530 2bbb7eff-a529-9590-31e7-b0007b416f81
* pdf-poppler GM results: updated more still-unreviewed expectationsGravatar epoger@google.com2013-12-06
| | | | | | | | | | (The prior revision of these expectations were unreviewed-by-humans anyway) BUG=skia:1578,skia:1759 TBR=vandebo Review URL: https://codereview.chromium.org/93883003 git-svn-id: http://skia.googlecode.com/svn/trunk@12529 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement srcRect and dstRect functionality in SkBitmapSource. This is ↵Gravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | | | | | required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource". This also includes some changes to the xfermodeimagefilter and tileimagefilter GMs to properly handle the CTM. This worked before only because SkBitmapSource was ignoring the CTM. Now that it respects it, we need to give the correct transform. This also means the GMs now work while zoomed. R=reed@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/106933002 git-svn-id: http://skia.googlecode.com/svn/trunk@12528 2bbb7eff-a529-9590-31e7-b0007b416f81
* A simple draw() function in Javascript.Gravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | R=robertphillips@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/102803003 git-svn-id: http://skia.googlecode.com/svn/trunk@12527 2bbb7eff-a529-9590-31e7-b0007b416f81
* Really truly final (?) rebaseline for https://codereview.chromium.org/102683002/Gravatar jvanverth@google.com2013-12-06
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12526 2bbb7eff-a529-9590-31e7-b0007b416f81
* ARM Skia NEON patches - 32 - Xfermode: 1-pixel NEON modeprocsGravatar commit-bot@chromium.org2013-12-06
| | | | | | | | | | | | | | | | | In some cases, it's easy to provide a NEON version of the 1-pixel modeprocs. Combined with https://codereview.chromium.org/23724013/ (merged) it allows up to 35% speed improvement on Xfermodes when aa is non-NULL. Signed-off-by: Kévin PETIT <kevin.petit@arm.com> BUG= R=djsollen@google.com, reed@google.com, mtklein@google.com, luisjoseromeroesclusa@hotmail.com Author: kevin.petit.arm@gmail.com Review URL: https://codereview.chromium.org/104883004 git-svn-id: http://skia.googlecode.com/svn/trunk@12525 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-12-06
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12524 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Implement srcRect and dstRect functionality in SkBitmapSource. This ↵Gravatar senorblanco@chromium.org2013-12-05
| | | | | | | | | | | | | is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource"." until I can sort out the xfermodeimagefilter and tileimagefilter failures. This reverts commit b26725c8c9755415284c34399e76be098868e01a, aka r12522. BUG= TBR=reed@google.com Review URL: https://codereview.chromium.org/107093005 git-svn-id: http://skia.googlecode.com/svn/trunk@12523 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement srcRect and dstRect functionality in SkBitmapSource. This is ↵Gravatar senorblanco@chromium.org2013-12-05
| | | | | | | | | | | | | required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource". Note: I initially implemented this as a fully-generic SkResizeImageFilter, but then I realized that the dstRect should always be transformed by the filter matrix, but that the srcRect should not (since it's specified relative to the dimensions of the original bitmap). Since this would be confusing for someone attempting to use this as a generic resizing filter, I decided to build the functionality into SkBitmapSource instead. BUG= R=reed@google.com Review URL: https://codereview.chromium.org/106933002 git-svn-id: http://skia.googlecode.com/svn/trunk@12522 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update not-reviewed-by-human poppler baselinesGravatar epoger@google.com2013-12-05
| | | | | | | | | | | | | | | | | | | | BUG=skia:1657,skia:1578 TBR=vandebo These were already annotated as belonging to https://code.google.com/p/skia/issues/detail?id=1578 ('commit GM actuals as expectations for all tests, marking them as unreviewed'), which means they had not been visually reviewed in the first place. So we have no reason to believe their current results are incorrect (for all we know, they were wrong before) For these and all other expectations with the bug1578 annotation, we should figure out a way to validate them. But that's for another day... Review URL: https://codereview.chromium.org/107293002 git-svn-id: http://skia.googlecode.com/svn/trunk@12521 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix refcounting bug for Type1 font usage with more than 255 characters.Gravatar commit-bot@chromium.org2013-12-05
| | | | | | | | | | R=bungeman@google.com Author: vandebo@chromium.org Review URL: https://codereview.chromium.org/103423003 git-svn-id: http://skia.googlecode.com/svn/trunk@12520 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix change src/ports/SkImageDecoder_empty.cpp missed in 103033002Gravatar halcanary@google.com2013-12-05
| | | | | | | | | BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/107123002 git-svn-id: http://skia.googlecode.com/svn/trunk@12519 2bbb7eff-a529-9590-31e7-b0007b416f81
* SkOnce: let f be any functor, update commentsGravatar commit-bot@chromium.org2013-12-05
| | | | | | | | | | | BUG= R=bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/104433005 git-svn-id: http://skia.googlecode.com/svn/trunk@12518 2bbb7eff-a529-9590-31e7-b0007b416f81
* expectations/gm/ignored-tests.txt: add links to tracking bugsGravatar epoger@google.com2013-12-05
| | | | | | | | (SkipBuildbotRuns) Review URL: https://codereview.chromium.org/106643003 git-svn-id: http://skia.googlecode.com/svn/trunk@12516 2bbb7eff-a529-9590-31e7-b0007b416f81
* Big Cleanup: SkBitmapFactory, SkLazyPixelRef, SkImageCacheGravatar halcanary@google.com2013-12-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed SkBitmapFactory since no clients were using it. New cache selection mechanism can simply pass a SkDiscardableMemory::Factory into the SkDiscardablePixelRef if non-default SkDiscardableMemory should be used. Removed BitmapFactoryTest. SkDiscardableMemory::Factory interface. Android will need this functionality in the future inside their BitmapFactory. Removed SkLazyPixelRef, since it's functionality is now subsumed into SkDiscardablePixelRef. Removed LazyPixelRef test. Modified SkDiscardablePixelRef to optionally allow it to use a SkDiscardableMemory::Factory. This tiny change makes it a replacement for SkLazyPixelRef. This functioanlity is also necessary for moving Android over to SkDiscardablePixelRef from SkImageRef in a later CL. Added a test for this. SkDecodingImageGenerator::Install can optionally pass a factory in to SkDiscardablePixelRef. Removed SkImageCache, SkLruImageCache, and SkPurgeableImageCache. This functionality can be handled much more cleanly by SkDiscardableMemory. New SkDiscardableMemoryPool class to replace SkLruImageCache. In a later CL, we will replace SkImageRef_GlobalPool (used by android) as well. This is a concrete implementation of SkDiscardableMemory::Factory. Added a test for this. modified gm/factory.cpp to remove dependnce on SkBitmapFactory + SkLruImageCache. Now uses SkDecodingImageGenerator + SkDiscardablePixelRef + SkDiscardableMemoryPool. SkImageDecoder::Target replaces SkBitmapFactory::Target. The DecodeMemoryToTarget function may disappear in the future. Moved SkLazyCachingPixelRef::DecodeProc replaces SkBitmapFactory::DecodeProc. This is a short term change, since another CL changes SkLazyCachingPixelRef to use SkImageGenerator instead of DecodeProc. Modified DrawBitmapRectTest to use SkDiscardablePixelRef instead of SkLazyPixelRef. tools/LazyDecodeBitmap.cpp now uses SkDecodingImageGenerator + SkDiscardablePixelRef instead of a SkBitmapFactory. bench_pictures uses the Global SkDiscardableMemoryPool instead of a global gLruImageCache. R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/103033002 git-svn-id: http://skia.googlecode.com/svn/trunk@12515 2bbb7eff-a529-9590-31e7-b0007b416f81
* One last rebaseline (I hope)Gravatar jvanverth@google.com2013-12-05
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12514 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: add "deep linking" to allow bookmarking of particular viewsGravatar epoger@google.com2013-12-05
| | | | | | | | | | (SkipBuildbotRuns) R=jcgregorio@google.com Review URL: https://codereview.chromium.org/104623003 git-svn-id: http://skia.googlecode.com/svn/trunk@12513 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make sure four_byte_interp benches the entire FourByteInterp call.Gravatar commit-bot@chromium.org2013-12-05
| | | | | | | | | | | | | | | | | | | | | | | | | Relative bench performance still says switch to Fast. Desktop: four_byte_interp_slow_256 11.68 four_byte_interp_slow_255 12.11 four_byte_interp_fast_256 7.17 four_byte_interp_fast_255 8.17 N5: four_byte_interp_slow_256 28.49 four_byte_interp_slow_255 25.08 four_byte_interp_fast_256 19.40 four_byte_interp_fast_255 21.69 BUG= R=reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/102053006 git-svn-id: http://skia.googlecode.com/svn/trunk@12512 2bbb7eff-a529-9590-31e7-b0007b416f81
* Finish rebaselines for https://codereview.chromium.org/102683002/Gravatar jvanverth@google.com2013-12-05
| | | | | | Review URL: https://codereview.chromium.org/106773002 git-svn-id: http://skia.googlecode.com/svn/trunk@12511 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update valgrind suppressions for new driverGravatar robertphillips@google.com2013-12-05
| | | | | | | | https://codereview.chromium.org/102473003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12510 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: start HTTP server immediately, auto-reload once results ↵Gravatar epoger@google.com2013-12-05
| | | | | | | | | | | | | are available BUG=skia:1877 (SkipBuildbotRuns) R=vandebo@chromium.org Review URL: https://codereview.chromium.org/106453002 git-svn-id: http://skia.googlecode.com/svn/trunk@12509 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add Windows compilation support to V8 exampleGravatar robertphillips@google.com2013-12-05
| | | | | | | | https://codereview.chromium.org/106163004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12508 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update documentation around drawBitmap and shadersGravatar commit-bot@chromium.org2013-12-05
| | | | | | | | | | R=reed@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/105823004 git-svn-id: http://skia.googlecode.com/svn/trunk@12507 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix MacOS build error from 36d08c5c90c7Gravatar halcanary@google.com2013-12-05
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/105453005 git-svn-id: http://skia.googlecode.com/svn/trunk@12506 2bbb7eff-a529-9590-31e7-b0007b416f81
* SkCachingPixelRef to use SkImageGeneratorGravatar halcanary@google.com2013-12-05
| | | | | | | | | | | | | - Remove SkLazyCachingPixelRef class. - Refactor unit tests. BUG= R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/84083002 git-svn-id: http://skia.googlecode.com/svn/trunk@12505 2bbb7eff-a529-9590-31e7-b0007b416f81
* update android build to use SDK API level 19.Gravatar djsollen@google.com2013-12-05
| | | | | | | | BUG=1817 Review URL: https://codereview.chromium.org/88223002 git-svn-id: http://skia.googlecode.com/svn/trunk@12504 2bbb7eff-a529-9590-31e7-b0007b416f81
* V8 and SkiaGravatar commit-bot@chromium.org2013-12-05
| | | | | | | | | | R=robertphillips@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/93933005 git-svn-id: http://skia.googlecode.com/svn/trunk@12503 2bbb7eff-a529-9590-31e7-b0007b416f81
* Image rebaselinesGravatar robertphillips@google.com2013-12-05
| | | | | | | | https://codereview.chromium.org/101313004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12502 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix compilation with SK_ENABLE_INST_COUNT=1Gravatar commit-bot@chromium.org2013-12-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add INHERITED declarations to class declarations that prevent compilation with the flag. Remove SK_DEFINE_INST_COUNT from all class implementations. Instead, use function-local static variables in the reference count helper classes to create the global instances to store the needed info. The accessor functions are defined inline in the helper classes, so definitions are not needed. The initialization point of the variables should be as well defined as previously. Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT instead. This avoids possible future compilation errors further. For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member function to all classes that use SK_DECLARE_INST_COUNT and SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes contain public INHERITED typedef. This member function seems to be compiled away. This shouĺd ensure that part of the compilation errors are caught earlier. Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses. R=robertphillips@google.com, richardlin@chromium.org, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/98703002 git-svn-id: http://skia.googlecode.com/svn/trunk@12501 2bbb7eff-a529-9590-31e7-b0007b416f81